Supply additional checks in order to prevent unexpected results.
Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf")
Suggested-by: Dan Carpenter
Signed-off-by: Lee Jones
---
Destined for v4.4.y and v4.9.y
drivers/staging/android/ion/ion.c | 6 ++
1 file changed, 6 insertion
On Fri, 26 Nov 2021, Greg KH wrote:
> On Fri, Nov 26, 2021 at 08:56:27AM +0000, Lee Jones wrote:
> > On Fri, 26 Nov 2021, Dan Carpenter wrote:
> >
> > > On Thu, Nov 25, 2021 at 06:18:22PM +0300, Dan Carpenter wrote:
> > > > I had thought that ->kmap_cn
> handle->kmap_cnt++;
> return buffer->vaddr;
> }
Which is all well and good until somebody changes the type.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter |
On Thu, 25 Nov 2021, Dan Carpenter wrote:
> On Thu, Nov 25, 2021 at 03:07:37PM +0000, Lee Jones wrote:
> > On Thu, 25 Nov 2021, Dan Carpenter wrote:
> >
> > > On Thu, Nov 25, 2021 at 02:20:04PM +, Lee Jones wrote:
> > > > Supply additional checks in
On Thu, 25 Nov 2021, Lee Jones wrote:
> On Thu, 25 Nov 2021, Dan Carpenter wrote:
>
> > On Thu, Nov 25, 2021 at 02:20:04PM +0000, Lee Jones wrote:
> > > Supply additional checks in order to prevent unexpected results.
> > >
> > > Fixes: b892bf7
On Thu, 25 Nov 2021, Dan Carpenter wrote:
> On Thu, Nov 25, 2021 at 02:20:04PM +0000, Lee Jones wrote:
> > Supply additional checks in order to prevent unexpected results.
> >
> > Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf")
> > Signed-off-by:
Supply additional checks in order to prevent unexpected results.
Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf")
Signed-off-by: Lee Jones
---
Should be back-ported from v4.9 and earlier.
drivers/staging/android/ion/ion.c | 5 +
1 file changed, 5 insertions(+)
diff --git
On Thu, 25 Nov 2021, Greg KH wrote:
> On Thu, Nov 25, 2021 at 01:03:46PM +0000, Lee Jones wrote:
> > On Thu, 25 Nov 2021, Greg KH wrote:
> >
> > > On Thu, Nov 25, 2021 at 12:46:23PM +, Lee Jones wrote:
> > > > On Thu, 25 Nov 2021, Greg KH wrote:
> >
On Thu, 25 Nov 2021, Greg KH wrote:
> On Thu, Nov 25, 2021 at 12:46:23PM +0000, Lee Jones wrote:
> > On Thu, 25 Nov 2021, Greg KH wrote:
> >
> > > On Thu, Nov 25, 2021 at 12:02:34PM +, Lee Jones wrote:
> > > > Supply additional checks in
On Thu, 25 Nov 2021, Greg KH wrote:
> On Thu, Nov 25, 2021 at 12:02:34PM +0000, Lee Jones wrote:
> > Supply additional checks in order to prevent unexpected results.
> >
> > Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf")
> > Signed-off-by: Lee Jones
Supply additional checks in order to prevent unexpected results.
Fixes: b892bf75b2034 ("ion: Switch ion to use dma-buf")
Signed-off-by: Lee Jones
---
drivers/staging/android/ion/ion.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/android/ion/ion.c
b/drive
t; Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lee Jones
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_
On Fri, 29 Jan 2021, Mauro Carvalho Chehab wrote:
> Hi Lee,
>
> Em Wed, 27 Jan 2021 11:05:37 +0000
> Lee Jones escreveu:
>
> > On Tue, 19 Jan 2021, Mauro Carvalho Chehab wrote:
> >
> > > This driver is ready for mainstream. So, move it out of staging.
mi-pmic.c (100%)
I've already reviewed this:
https://lore.kernel.org/driverdev-devel/20210127110537.GI4903@dell/
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
mic.c (100%)
Replied to an earlier submission where I was able to reply in-line.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
__
pmic->irqs[i] = virq;
> + dev_dbg(dev, "%s: pmic->irqs[%d] = %d\n",
> + __func__, i, pmic->irqs[i]);
This is ugly. Please remove it.
> + }
> +
> + ret = request_threaded_irq(pmic->irq, hi6421_spmi_irq_handler, NU
.
I would have expected the whole set to be merged as a set into a
single tree, placed on an immutable branch and a pull-request to be
sent out for the other maintainers to pull from (if they so wished).
This would ensure development could continue on any/all of the
affected drivers/files.
On Mon, 18 Jan 2021, Mauro Carvalho Chehab wrote:
> Em Mon, 18 Jan 2021 15:12:27 +
> Lee Jones escreveu:
>
> > On Mon, 18 Jan 2021, Mauro Carvalho Chehab wrote:
> >
> > > This driver is ready for mainstream. So, move it out of staging.
> > >
>
;s the `git format-patch` -M flag that you want.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
___
devel mailing list
de...@linuxdriverproject.org
Jakub Kicinski
Cc: Yanir Lubetkin
Cc: net...@vger.kernel.org
Cc: de...@driverdev.osuosl.org
Signed-off-by: Lee Jones
---
drivers/staging/wimax/i2400m/tx.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/tx.c
b/drivers/staging/wimax/i2400m/tx.c
index 1255302e251
rivers/net/wimax/i2400m/fw.c:1548: warning: Function parameter or member
'flags' not described in 'i2400m_dev_bootstrap'
Cc: Greg Kroah-Hartman
Cc: Inaky Perez-Gonzalez
Cc: linux-wi...@intel.com
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Yanir Lubetkin
Cc: net...@v
;arg_size' description in 'i2400m_set_init_config'
Cc: Greg Kroah-Hartman
Cc: Inaky Perez-Gonzalez
Cc: linux-wi...@intel.com
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: net...@vger.kernel.org
Cc: de...@driverdev.osuosl.org
Signed-off-by: Lee Jones
---
drivers/staging/wimax/i2400
ller"
Cc: Jakub Kicinski
Cc: Yanir Lubetkin
Cc: net...@vger.kernel.org
Cc: de...@driverdev.osuosl.org
Signed-off-by: Lee Jones
---
drivers/staging/wimax/i2400m/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/netdev.c
b/drivers/stagi
chunk_len' description in 'i2400m_download_chunk'
Cc: Greg Kroah-Hartman
Cc: Inaky Perez-Gonzalez
Cc: linux-wi...@intel.com
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Yanir Lubetkin
Cc: net...@vger.kernel.org
Cc: de...@driverdev.osuosl.org
Signed-off-by: Lee Jones
---
drivers/s
not described in 'i2400m_setup'
drivers/net/wimax/i2400m/driver.c:942: warning: Function parameter or member
'i2400m' not described in 'i2400m_release'
Cc: Greg Kroah-Hartman
Cc: Inaky Perez-Gonzalez
Cc: linux-wi...@intel.com
Cc: "David S. Miller"
Cc: Ja
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This is a rebased set that went to Net before the move to Staging.
Lee Jones (6):
staging: net: wimax: i2400m: control: Fix some misspellings in
te mode 100644 drivers/staging/hikey9xx/Makefile
> create mode 100644 drivers/staging/hikey9xx/TODO
> create mode 100644 drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> create mode 100644 drivers/staging/hikey9xx/hi6421v600-regulator.c
> create mode 100644 drivers/staging/hikey9xx/hi
On Mon, 16 Oct 2017, mario.limoncie...@dell.com wrote:
> > -Original Message-
> > From: Lee Jones [mailto:lee.jo...@linaro.org]
> > Sent: Friday, October 13, 2017 4:15 PM
> > To: Limonciello, Mario
> > Cc: rui_f...@realsil.com.cn; gre...@linux
less pain.
That cannot be guaranteed.
If people's words would have been their bond in the past, I would have
more trust and the world would be a nicer place. :)
> > Ok, how does it hook up to the hardware to talk to the reader?
>
> This particular case its PCIe. I don't
On Fri, 13 Oct 2017, Greg KH wrote:
> On Fri, Oct 13, 2017 at 10:54:22AM +0100, Lee Jones wrote:
> > On Fri, 13 Oct 2017, Greg KH wrote:
> >
> > > On Fri, Oct 13, 2017 at 04:50:35PM +0800, rui_f...@realsil.com.cn wrote:
> > > > From: rui_feng
> > >
ces which reside on the same piece of silicon.
This driver does basically none of that. Instead it *is* the (what we
describe above as) sub-device. It does everything.
In the absence of a subsystem which covers this type of device, I
suggested Misk as a good locati
_drv.c | 2 +-
> drivers/media/platform/soc_camera/omap1_camera.c | 2 +-
> drivers/media/platform/soc_camera/soc_camera_platform.c | 2 +-
> drivers/media/platform/timblogiw.c| 2 +-
> drivers/media/radio/radio-timb.c
On Sat, 10 Oct 2015, 敬锐 wrote:
> Sorry for bother you, but I still can't see this patch applied.
> Is there something wrong?
Sorry about that Micky, I guess this one fell through the gaps.
Re-applied, should be in -next by tomorrow.
> On 07/08/2015 03:38 PM, Lee Jones wrote:
>
On Wed, 08 Jul 2015, 敬锐 wrote:
>
>
> On 07/07/2015 07:46 PM, Lee Jones wrote:
> > On Mon, 29 Jun 2015, micky_ch...@realsil.com.cn wrote:
> >
> >> From: Micky Ching
> >>
> >> rts522a(rts5227s) is derived from rts5227, and mainly same with rts52
> #define PHY_ANA1A_RXT_BIST 0x0500
> #define PHY_ANA1A_TXR_BIST 0x0040
> #define PHY_ANA1A_REV 0x0006
> +#define PHY_FLD0_INIT_27S 0x2546
> #define PHY_FLD1 0x1B
> #define PHY_FLD2 0x1C
a subsequent patch, can you define all of the magic numbers used in
this driver please?
Apart from that, patch looks fine:
Acked-by: Lee Jones
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 38356e3..2c52f93 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/
Driver unbind, .remove
> power_supply_unregister()
> Device fully removed
[...]
> include/linux/mfd/abx500/ux500_chargalg.h | 11 +-
> include/linux/mfd/rt5033.h| 2 +-
> include/l
.
>
> Signed-off-by: Micky Ching
> Acked-by: Lee Jones
> ---
> drivers/mfd/Makefile | 2 +-
> drivers/mfd/rts5227.c| 2 +-
> drivers/mfd/rts5249.c| 3 +--
> drivers/mfd/rtsx_gops.c | 37 -
> drivers/mfd/r
0x0800
> -#define PHY_REG_REV_RXIDLE_EN0x0400
> -#define PHY_REG_REV_CLKREQ_DLY_TIMER_1_0 0x0040
> -#define PHY_REG_REV_STOP_CLKRD 0x0020
> -#define PHY_REG_REV_RX_PWST 0x0008
> -#define PHY_REG_REV_STOP_CLKWR
On Wed, 25 Feb 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> pcr_dbg is a wrapper of dev_dbg, which can save some code,
> and help to enable/disable debug message static.
>
> Signed-off-by: Micky Ching
> Acked-by: Lee Jones
> ---
>
cky Ching
> Acked-by: Lee Jones
> ---
> include/linux/mfd/rtsx_pci.h | 836
> +++
> 1 file changed, 369 insertions(+), 467 deletions(-)
Applied, thanks.
> diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h
> ind
On Wed, 25 Feb 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> update card drive settings, This setting can be used for rts5249
> rts524A and rts525A.
>
> Signed-off-by: Micky Ching
> Acked-by: Lee Jones
> ---
> drivers/mfd/rts5249.c | 12 ++
19
> +#define _PHY_REV0_FILTER_OUT 0x3800
> +#define _PHY_REV0_CDR_BYPASS_PFD 0x0100
> +#define _PHY_REV0_CDR_RX_IDLE_BYPASS 0x0002
>
> #define PHY_FLD0 0x1A
> #define PHY_ANA1A0x1A
> @@ -800,6 +808,13 @@
>
DIG1E_TX_TERM_KEEP 0x0008
> +#define PHY_DIG1E_RX_TERM_KEEP 0x0004
> +#define PHY_DIG1E_TX_EN_KEEP 0x0002
> +#define PHY_DIG1E_RX_EN_KEEP 0x0001
> #define PHY_DUM_REG 0x1F
>
> #define PCR_SETTING_REG1 0x72
On Wed, 25 Feb 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> PETXCFG is defined at 0xFF03, the old 0xFE49 not used any more.
>
> Signed-off-by: Micky Ching
> Acked-by: Lee Jones
> ---
> drivers/mfd/rts5227.c| 6 ++
> drive
+++-
> include/linux/mfd/rtsx_pci.h | 109
> ++-
> 2 files changed, 72 insertions(+), 66 deletions(-)
Acked-by: Lee Jones
> diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c
> index 2fe2854..8de8220 100644
> --- a/drivers
On Wed, 25 Feb 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> Re-format coding-style, using uniform SPC after "#define" keyword
> instead of mixing using TAB and SPC.
>
> Signed-off-by: Micky Ching
> Acked-by: Lee Jones
> ---
>
| 13 --
> drivers/mfd/rtsx_pcr.h | 1 +
> include/linux/mfd/rtsx_pci.h | 15 +++
> 4 files changed, 129 insertions(+), 3 deletions(-)
Acked-by: Lee Jones
> diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c
> index 32be803..d1ff32f 100644
> --- a/driv
| 25 +-
> drivers/mfd/rtsx_pcr.h | 7 ++
> include/linux/mfd/rtsx_pci.h | 132 +-
> 4 files changed, 318 insertions(+), 32 deletions(-)
Acked-by: Lee Jones
> diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c
> index 3c77058..32
On Wed, 25 Feb 2015, 敬锐 wrote:
>
> On 02/16/2015 10:28 PM, Lee Jones wrote:
> >
> > +static int rts524a_optimize_phy(struct rtsx_pcr *pcr)
> > +{
> > + int err;
> > +
> > + err = rtsx_pci_write_register(pcr, RTS524A_PM_CTRL3,
> > +
== 0x524A)
> + if (PCI_PID(pcr) == 0x524A || PCI_PID(pcr) == 0x525A)
Please consider holding a pm_ctrl_reg attribute in the device data
structure, then only doing this once during initialisation.
Other than that, I have the same comments as before.
--
Lee Jones
Linaro STMicroelec
+++-
> include/linux/mfd/rtsx_pci.h | 10 +-
> 6 files changed, 21 insertions(+), 55 deletions(-)
> delete mode 100644 drivers/mfd/rtsx_gops.c
Acked-by: Lee Jones
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open sou
efine PHY_DIG1E_RCLK_TX_EN_KEEP 0x0040
> +#define PHY_DIG1E_RCLK_TX_TERM_KEEP0x0020
> +#define PHY_DIG1E_RCLK_RX_EIDLE_ON 0x0010
> +#define PHY_DIG1E_TX_TERM_KEEP 0x0008
> +#define PHY_DIG1E_RX_TERM_KEEP 0x0004
> +#define PHY_DIG1E_TX_EN_KEEP
r(pcr, PHY_PCR,
> - PHY_PCR_FORCE_CODE | PHY_PCR_OOBS_CALI_50 |
> - PHY_PCR_OOBS_VCM_08 | PHY_PCR_OOBS_SEN_90 |
> - PHY_PCR_RSSI_EN);
> + PHY_PCR_FORCE_CODE | PHY_PCR_OOBS_CALI_50 |
> + PHY_PCR_OOBS_VCM_08 | PHY_P
;
> > #define PHY_IMR 0x09
> > #define PHY_BPCR 0x0A
> > @@ -698,12 +782,19 @@
> > #define PHY_REV_STOP_CLKWR 0x0004
> >
> > #define PHY_FLD0 0x1A
> > +#de
_pci.h | 1109
> ++----
> 10 files changed, 966 insertions(+), 699 deletions(-)
> delete mode 100644 drivers/mfd/rtsx_gops.c
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: F
On Tue, 20 Jan 2015, Ulf Hansson wrote:
> On 20 January 2015 at 15:47, Lee Jones wrote:
> > On Tue, 23 Dec 2014, micky_ch...@realsil.com.cn wrote:
> >
> >> From: Micky Ching
> >>
> >> Add helper function to write u32 to registers, if we want to put u32
On Wed, 21 Jan 2015, Roger Tseng wrote:
> On Tue, 2015-01-20 at 16:07 +0000, Lee Jones wrote:
> > On Tue, 20 Jan 2015, Roger Tseng wrote:
> >
> > > On Mon, 2015-01-19 at 09:45 +, Lee Jones wrote:
> > > > On Thu, 15 Jan 2015, Roger Tseng wrote:
>
On Tue, 20 Jan 2015, Roger Tseng wrote:
> On Mon, 2015-01-19 at 09:45 +0000, Lee Jones wrote:
> > On Thu, 15 Jan 2015, Roger Tseng wrote:
> >
> > > sd_set_power_mode() in derived module drivers/mmc/host/rtsx_usb_sdmmc.c
> > > acquires dev_mutex and then calls p
On Tue, 23 Dec 2014, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> Add helper function to write u32 to registers, if we want to put u32
> value to 4 continuous register, this can help us reduce tedious work.
>
> Signed-off-by: Micky Ching
> Acked-by: Lee Jo
On Tue, 20 Jan 2015, 敬锐 wrote:
> On 01/19/2015 03:47 PM, Lee Jones wrote:
> > On Mon, 19 Jan 2015, 敬锐 wrote:
> >> >On 01/18/2015 08:29 PM, Lee Jones wrote:
> >>> > >On Thu, 15 Jan 2015,micky_ch...@realsil.com.cn wrote:
> >>> > >
>
(SD_CD | MS_CD))
> + return -EAGAIN;
> + } else {
> + /* There is an ongoing operation*/
> + return -EAGAIN;
> + }
> + }
> +
> return 0;
&g
NOT a permanent state and could be turned on anytime later.
> - * Thus no need to call turn_on when resunming.
> - */
> - mutex_lock(&ucr->dev_mutex);
> - rtsx_usb_turn_off_led(ucr);
> - mutex_unlock(&ucr->dev_mutex);
> -
> return 0;
>
On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 08:28 PM, Lee Jones wrote:
> > On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> >
> >> From: Micky Ching
> >>
> >> To enable/disable ASPM we should find LINK CONTROL register
> >> i
On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 08:39 PM, Lee Jones wrote:
> > On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> >
> >> From: Micky Ching
> >>
> >> Re-format coding-style, using uniform SPC after "#define" keyword
On Mon, 19 Jan 2015, 敬锐 wrote:
> On 01/18/2015 08:29 PM, Lee Jones wrote:
> > On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> >
> >> From: Micky Ching
> >>
> >> update phy register value and using direct value instead of macros.
> >> It
On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 07:13 PM, Lee Jones wrote:
> >> @@ -97,7 +97,7 @@ static void rts5249_force_power_down(struct rtsx_pcr
> >> *pcr, u8 pm_state)
> >> > rtsx_pci_write_register(pcr, AUTOLOAD_CFG_BASE + 3, 0x01, 0);
&
On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 08:20 PM, Lee Jones wrote:
> >> +static int rts524a_optimize_phy(struct rtsx_pcr *pcr)
> >> >+{
> >> >+ int err;
> >> >+
> >> >+ err = rtsx_pci_write_register(pcr, RTS524A_PM_CTRL3
On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 08:20 PM, Lee Jones wrote:
> >> +};
> >> >+
> >> >+void rts524a_init_params(struct rtsx_pcr *pcr)
> >> >+{
> >> >+ rts5249_init_params(pcr);
> >> >+
> >> >+ pcr
_RSP_80CLK_TIMEOUT_EN 0x01
>
> /* Card Transfer Reset Register */
> #define SPI_STOP 0x01
> @@ -574,13 +574,13 @@
>
> #define SRCTL0xFC13
>
> -#define DCM_DRP_CTL 0xFC23
> -#d
d-off-by: Micky Ching
> ---
> include/linux/mfd/rtsx_pci.h | 836
> +++
> 1 file changed, 369 insertions(+), 467 deletions(-)
As you wish.
Acked-by: Lee Jones
> diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h
> index
((pcr)->pci->vendor)
> #define PCI_PID(pcr) ((pcr)->pci->device)
>
> +#define pcr_dbg(pcr, fmt, arg...)\
> + dev_dbg(&(pcr)->pci->dev, fmt, ##arg)
> #define SDR104_PHASE(val)((val) & 0xF
changed, 6 insertions(+), 6 deletions(-)
There is no way for me to know if this is correct or not.
Code looks fine though, so:
Acked-by: Lee Jones
> diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c
> index 225ad55..2fe2854 100644
> --- a/drivers/mfd/rts5249.c
> +++ b/drivers/mfd/rt
---
> include/linux/mfd/rtsx_pci.h | 2 +-
> 3 files changed, 5 insertions(+), 9 deletions(-)
Acked-by: Lee Jones
> diff --git a/drivers/mfd/rts5227.c b/drivers/mfd/rts5227.c
> index 3240740..1f387d4 100644
> --- a/drivers/mfd/rts5227.c
> +++ b/drivers/mfd/rts5227.c
> @@ -118,
r(pcr, PHY_TUNE,
> - PHY_TUNE_TUNEREF_1_0 | PHY_TUNE_VBGSEL_1252 |
> - PHY_TUNE_SDBUS_33 | PHY_TUNE_TUNED18 |
> - PHY_TUNE_TUNED12);
> +
> + return 0;
> }
>
> static int rts5249_turn_on_led(struct rtsx_pcr *pcr)
-
x 80baa10..f7cebdb 100644
> --- a/include/linux/mfd/rtsx_pci.h
> +++ b/include/linux/mfd/rtsx_pci.h
> @@ -662,15 +662,6 @@
> #define PHY_FLD4 0x1E
> #define PHY_DUM_REG 0x1F
>
> -#define LCTLR
->device == (pid))
> #define PCI_VID(pcr) ((pcr)->pci->vendor)
> #define PCI_PID(pcr) ((pcr)->pci->device)
> -
> +#define is_version(pcr, pid, ver)\
> + (CHK_PCI_PID(pcr, pid) && (pcr)->ic_vers
(base, len);
> if (!pcr->remap_addr) {
> ret = -ENOMEM;
> diff --git a/drivers/mfd/rtsx_pcr.h b/drivers/mfd/rtsx_pcr.h
> index 0535265..4c00544 100644
> --- a/drivers/mfd/rtsx_pcr.h
> +++ b/drivers/mfd/rtsx_pcr.h
> @@ -37,6 +37,7 @@ void rtl8402_init_p
> drivers/mfd/rts5209.c | 4 ++--
> drivers/mfd/rts5227.c | 4 ++--
> drivers/mfd/rts5229.c | 4 ++--
> drivers/mfd/rts5249.c | 4 ++--
> drivers/mfd/rtsx_pcr.c | 49 ++---
> 6 files changed, 35 insertions(+), 41 deletions(-)
On Mon, 08 Dec 2014, Ulf Hansson wrote:
> On 8 December 2014 at 10:57, Lee Jones wrote:
> > On Fri, 05 Dec 2014, micky_ch...@realsil.com.cn wrote:
> >> From: Micky Ching
> >>
> >> Add helper function to write u32 to registers, if we want to put u32
> >
On Mon, 08 Dec 2014, 敬锐 wrote:
>
> On 12/08/2014 04:49 PM, Lee Jones wrote:
> >> diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h
> >> >index 74346d5..9234449 100644
> >> >--- a/include/linux/mfd/rtsx_pci.h
> >> >+++ b/
On Fri, 05 Dec 2014, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> Add helper function to write u32 to registers, if we want to put u32
> value to 4 continuous register, this can help us reduce tedious work.
>
> Signed-off-by: Micky Ching
> Acked-by: Lee Jo
On Fri, 05 Dec 2014, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> Add helper function to write u32 to registers, if we want to put u32
> value to 4 continuous register, this can help us reduce tedious work.
>
> Signed-off-by: Micky Ching
> Acked-by: Lee Jo
linux/mfd/rtsx_pci.h | 9 +
> 1 file changed, 9 insertions(+)
Looks fine to me. Let me know how you want to handle this:
For my own reference:
Acked-by: Lee Jones
> diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h
> index 74346d5..9234449 100644
>
reg + 2, 0xFF, val >> 8);
> + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 3, 0xFF, val);
> +}
> +
> #endif
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
gt; 8);
> + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 2, 0xFF, val >> 16);
> + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 3, 0xFF, val >> 24);
> +}
> #endif
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software fo
0x08
> +#define LCTLR_RESERVED 0x04
> +#define LCTLR_ASPM_CTL_MASK0x03
> +
> #define PCR_SETTING_REG1 0x724
> #define PCR_SETTING_REG2 0x814
> #define PCR_SETTING_REG3 0x747
> @@ -967,4 +983,16
end)
> +{
> + int err;
> + u8 val;
> +
> + err = pci_read_config_byte(pcr->pci, addr, &val);
> + if (err < 0)
> + return err;
> + return pci_write_config_byte(pcr->pci, addr, (val & mask) | append);
> +}
> +
Why is this in
3 +++
> include/linux/mfd/rtsx_pci.h | 28
These are Card Reader drivers right?
Do you know why these are in MFD?
> 6 files changed, 79 insertions(+), 1 deletion(-)
> create mode 100644 drivers/mfd/rtsx_gops.c
--
Lee Jones
Linaro STMicroelectronics Landing Team
On Thu, 09 Oct 2014, Guenter Roeck wrote:
> On 10/09/2014 03:49 AM, Lee Jones wrote:
> >On Thu, 09 Oct 2014, Catalin Marinas wrote:
> >
> >>On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote:
> >>>On Mon, 06 Oct 2014, Guenter Roeck wrote:
>
On Thu, 09 Oct 2014, Catalin Marinas wrote:
> On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote:
> > On Mon, 06 Oct 2014, Guenter Roeck wrote:
> > > --- a/drivers/mfd/ab8500-sysctrl.c
> > > +++ b/drivers/mfd/ab8500-sysctrl.c
> > > @@ -6,6 +6,7 @@
&
On Mon, 06 Oct 2014, Guenter Roeck wrote:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly. Register with a low priority value of 64 to reflect that
> the original code only sets pm_power_off if it was not already set.
>
> Cc: Linus Walleij
static as it is only called from the twl4030-power
> driver.
>
> Cc: Samuel Ortiz
> Cc: Lee Jones
> Signed-off-by: Guenter Roeck
> ---
> drivers/mfd/twl4030-power.c | 25 +
> include/linux/i2c/twl.h | 1 -
> 2 files changed, 21 inser
ct rtsx_pcr *pcr, int addr,
> + u8 mask, u8 append)
> +{
> + int err;
> + u8 val;
> +
> + err = pci_read_config_byte(pcr->pci, addr, &val);
> + if (err < 0)
> + return err;
> + return pci_write_conf
On Thu, 18 Sep 2014, micky wrote:
> On 09/18/2014 12:53 PM, Lee Jones wrote:
> >On Thu, 18 Sep 2014, micky_ch...@realsil.com.cn wrote:
> >
> >>From: Micky Ching
> >>
> >>Fix rts5227&5249 failed send buffer cmd after suspend,
> >>PM_CTRL
int addr,
> + u8 mask, u8 append)
> +{
> + int err;
> + u8 val;
> +
> + err = pci_read_config_byte(pcr->pci, addr, &val);
> + if (err < 0)
> + return err;
> + return pci_write_config_byte(pcr->pci, addr, (val & mask) | appen
u8 append)
> +{
> + int err;
> + u8 val;
> +
> + err = pci_read_config_byte(pcr->pci, addr, &val);
> + if (err < 0)
> + return err;
> + return pci_write_config_byte(pcr->pci, addr, (val & mask) | append);
> +}
> +
>
--
include/linux/mfd/rtsx_pci.h | 6 ++
3 files changed, 181 insertions(+), 34 deletions(-)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
On Wed, 02 Jul 2014, micky wrote:
> On 06/18/2014 04:00 PM, Lee Jones wrote:
> >On Mon, 16 Jun 2014, Ulf Hansson wrote:
> >
> >>On 16 June 2014 14:20, Lee Jones wrote:
> >>>>From: Micky Ching
> >>>>
> >>>>rtsx driver using a
On Mon, 16 Jun 2014, Ulf Hansson wrote:
> On 16 June 2014 14:20, Lee Jones wrote:
> >> From: Micky Ching
> >>
> >> rtsx driver using a single function for transfer data, dma map/unmap are
> >> placed in one fix function. We need map/unmap dma in differe
1 - 100 of 149 matches
Mail list logo
