t seems odd (and unclear if so).
I doubt that was the intention. I'll correct WHENCE in a separate
commit. Thank you for reporting the issue.
josh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
are 3.14
All 3 applied and pushed out.
josh
>
> WHENCE| 18 ++
> silabs/wfm_wf200_C0.sec | Bin 305232 -> 0 bytes
> {silabs => wfx}/LICENCE.wf200 | 0
> wfx/brd4001a.pds | Bin 0 -> 625 bytes
> wfx
fb_reg_set(vb->P3c4, 0x05, 0x86);
>
> I chose "vb" based on the struct name... "dev" and "info" aren't very
> useful in a name because there are a lot of devices and lots of types
> of info.
>
> regards,
> dan carpneter
>
That
remove one
> from the middle. That's a more complicated patch, but it's a useful
> patch.
>
> regards,
> dan carpenter
>
Great point. I will work on that and get the patch out!
-Josh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
"Read without prior read command\n");
> >
>
> This is incorrect, as this function is an interrupt handler and we cannot
> sleep in interrupt context.
>
> Cheers,
> Mikko
My mistake. Thank you for the feedback!
-Josh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
nal code here makes much more sense, doesn't it?
>
> Sometimes checkpatch is wrong :)
>
> thanks,
>
> greg k-h
It does make a lot more sense.
I will trust checkpatch less, and my eyes more :)
-Josh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Nov 08, 2017 at 02:52:30PM +0300, Dan Carpenter wrote:
> On Wed, Nov 08, 2017 at 06:25:06AM -0500, Joshua Abraham wrote:
> > This patch completes TODO improvements in rf69.c to change shift
> > constants to a define.
> >
> > Signed-off-by: Joshua Abraham
> > ---
> > drivers/staging/pi433
On Wed, Sep 23, 2015 at 12:10:13PM -0500, atull wrote:
> On Tue, 22 Sep 2015, Josh Cartwright wrote:
[..]
> > > +struct fpga_manager *of_fpga_mgr_get(struct device_node *node)
> > > +{
> > > + struct fpga_manager *mgr;
> > > + struct device *dev;
> >
dev, mgr);
> +
> + dt_label = of_get_property(mgr->dev.of_node, "label", NULL);
> + if (dt_label)
> + ret = dev_set_name(&mgr->dev, "%s", dt_label);
> + else
> + ret = dev_set_name(&mgr->dev, "fpga%d", id);
I'm wondering if an alias {} node is better for this.
[..]
> +++ b/include/linux/fpga/fpga-mgr.h
[..]
> +/*
> + * FPGA Manager flags
> + * FPGA_MGR_PARTIAL_RECONFIG: do partial reconfiguration if supported
> + */
> +#define FPGA_MGR_PARTIAL_RECONFIGBIT(0)
> +
> +/**
> + * struct fpga_manager_ops - ops for low level fpga manager drivers
> + * @state: returns an enum value of the FPGA's state
> + * @write_init: prepare the FPGA to receive confuration data
^configuration
> + * @write: write count bytes of configuration data to the FPGA
> + * @write_complete: set FPGA to operating state after writing is done
> + * @fpga_remove: optional: Set FPGA into a specific state during driver
> remove
Any specific state? State in the FPGA-manager-state-machine case? Or a
basic 'reset' state?
Josh
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
A doesn't support BE (which my follow up question would be: why
not?). Same thing applies with seemingly cavalier usages of the
__raw_readl/writel variants.
Josh
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
0 or NULL,
> where some of the fields already use labels, and where there are nested
> structures.
I responded to patches 6 and 8 with comments; for the rest (1-5, 7, 9):
Reviewed-by: Josh Triplett
___
devel mailing list
de...@linuxdriverp
294967295.
> This is a bug in the kernel source not sparse.
Except that "filter" has an "int channel" (signed), so it can
successfully test "channel < 0" and return early; it'll never call
ni_stc_dma_channel_select_bitfield(channel) with a negative number.
I do agree that this code should sort out the signedness of its types,
but in this case I don't think the bad shift can actually happen, making
this a false positive.
- Josh Triplett
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Jun 25, 2014 at 04:50:31PM +0200, Matthias Beyer wrote:
> On 23-06-2014 13:44:22, j...@joshtriplett.org wrote:
> > On Mon, Jun 23, 2014 at 11:42:33AM +0200, Matthias Beyer wrote:
> > > Signed-off-by: Matthias Beyer
> >
> > As with the previous line-wrapping patch, this doesn't seem like a
On Mon, Jun 23, 2014 at 11:42:33AM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer
As with the previous line-wrapping patch, this doesn't seem like a net
improvement; the lines seem far more readable un-wrapped.
> drivers/staging/bcm/DDRInit.c | 31 +--
>
s why I'm curious about it.
>
> I did not merge these nested if-statements, as I don't know if I'm
> destroying logical seperated checks with it.
>
> Signed-off-by: Matthias Beyer
Reviewed-by: Josh Triplett
> drivers/staging/bcm/DDRInit.c | 10 +-
> 1 f
On Mon, Jun 23, 2014 at 11:42:30AM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer
Honestly, none of these seem like improvements. Checkpatch's line-width
warnings rarely result in improved code.
(Its "maximum indentation level" warnings, which prompt people to
refactor functions,
On Mon, Jun 23, 2014 at 11:42:29AM +0200, Matthias Beyer wrote:
> This patch fixes some indentation errors, where multi-line statements
> where not indented.
>
> Signed-off-by: Matthias Beyer
This patch also fixes some whitespace issues, such as a lack of space
before '/', which should probably
On Mon, Jun 23, 2014 at 11:42:28AM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer
Reviewed-by: Josh Triplett
> drivers/staging/bcm/DDRInit.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/bcm/DDRInit.c b/driv
_addr_copy' instead of 'memcpy'
> remaining.
>
> Signed-off-by: Johannes Stadlinger
> Signed-off-by: Maximilian Eschenbacher
> CC: linux-ker...@i4.cs.fau.de
> CC: Greg Kroah-Hartman
> CC: Tugce Sirin
> CC: Josh Triplett
> CC: Himangi Saraogi
&
> CC: Tugce Sirin
> CC: Josh Triplett
> CC: Vitaly Osipov
> CC: Neil Armstrong
> CC: Paul Gortmaker
> CC: de...@driverdev.osuosl.org
> CC: linux-ker...@vger.kernel.org
Reviewed-by: Josh Triplett
> drivers/staging/wlan-ng/prism2sta.c | 3 +--
> 1 file changed, 1 i
g Kroah-Hartman
> CC: Tugce Sirin
> CC: Josh Triplett
> CC: Neil Armstrong
> CC: Paul Gortmaker
> CC: Vitaly Osipov
> CC: de...@driverdev.osuosl.org
> CC: linux-ker...@vger.kernel.org
Most of these look fine, but...
> @@ -1271,7 +1275,8 @@ void prism2sta
emaining.
>
> Signed-off-by: Johannes Stadlinger
> Signed-off-by: Maximilian Eschenbacher
> CC: linux-ker...@i4.cs.fau.de
> CC: Greg Kroah-Hartman
> CC: Josh Triplett
> CC: Vitaly Osipov
> CC: Himangi Saraogi
> CC: de...@driverdev.osuosl.org
> CC: linux-
On Thu, Jun 19, 2014 at 09:20:16PM +0200, Johannes Stadlinger wrote:
> This patch fixes a warning of checkpatch about string splitting.
>
> Signed-off-by: Johannes Stadlinger
> Signed-off-by: Maximilian Eschenbacher
> CC: linux-ker...@i4.cs.fau.de
> CC: Greg Kroah-Hartman
&
C: Greg Kroah-Hartman
> CC: Josh Triplett
> CC: Himangi Saraogi
> CC: Vitaly Osipov
> CC: de...@driverdev.osuosl.org
> CC: linux-ker...@vger.kernel.org
This is one case where I think checkpatch is just wrong; this doesn't
make the code any more (or less) readable.
Meh-by: J
man
> CC: Himangi Saraogi
> CC: Josh Triplett
> CC: Vitaly Osipov
> CC: de...@driverdev.osuosl.org
> CC: linux-ker...@vger.kernel.org
Reviewed-by: Josh Triplett
> drivers/staging/wlan-ng/prism2mgmt.c | 26 ++
> 1 file changed, 10 insertions(+), 16
On Thu, Jun 12, 2014 at 12:24:25AM +0300, Dan Carpenter wrote:
> Let's forward this to the Sparse mailing list.
>
> We're seeing a Sparse false positive testing
> drivers/staging/comedi/drivers/ni_pcimio.c.
>
> CHECK drivers/staging/comedi/drivers/ni_pcimio.c
> drivers/staging/comedi/drivers/
On Thu, May 22, 2014 at 09:58:02PM +0200, Rickard Strandqvist wrote:
> Removal of null pointer checks that could never happen
>
> Signed-off-by: Rickard Strandqvist
Reviewed-by: Josh Triplett
> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 110
> +-
xing or
silencing. At most, it might be helpful to add annotations like GCC's
"nonnull", if that helps the checker and the compiler generate more
useful warnings.
- Josh Triplett
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Move functions declaration to coherent internal header file.
>
> Signed-off-by: Neil 'Superna' Armstrong
Reviewed-by: Josh Triplett
> drivers/staging/wlan-ng/prism2mgmt.h |5 +
> drivers/staging/wlan-ng/prism2sta.c |4
> 2 files changed, 5 insertions(+
On Wed, Apr 09, 2014 at 09:25:55AM +0200, Martin Kepplinger wrote:
> Use the common kernel coding style.
>
> Signed-off-by: Martin Kepplinger
Reviewed-by: Josh Triplett
>
> drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |6 +++---
> 1 file changed, 3 insertio
On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> This patch solves some sparse warnings about "symbol [...] was not
> declared. Should it be static?" by including the correct header files.
>
> Signed-off-by: Jonas Hahnfeld
Reviewed-by: Josh Triplett
&g
*)(hi->addr_mapped[0]));
While this may "fix" the sparse warning, it's far from ideal. Like I
had suggested on IRC, a much better cleanup would be to make the
addr_mapped member an array of __iomem-tagged pointers, and fixup the
users.
Josh
___
erman
> Signed-off-by: Levente Kurusa
Reviewed-by: Josh Triplett
> drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> b/drivers/staging/media/davi
On Thu, Jan 30, 2014 at 2:31 PM, Fabio Estevam wrote:
> On Thu, Jan 30, 2014 at 5:28 PM, Josh Boyer wrote:
>> Hi All,
>>
>> After the DRM merge the imx-hdmi driver fails to build with the error
>> below. I'm somewhat surprised this wasn't hit in linux-n
Hi All,
After the DRM merge the imx-hdmi driver fails to build with the error
below. I'm somewhat surprised this wasn't hit in linux-next.
josh
drivers/staging/imx-drm/imx-hdmi.c:55:6: error: nested redefinition of
'enum hdmi_colorimetry'
enum hdmi_colorimetry {
^
On Fri, Jan 24, 2014 at 04:14:00AM +0530, Rashika Kheria wrote:
> Mark functions as static in bpctl_mod.c because they are not used
> outside this file. Remove unused function from bpctl_mod.c.
>
[...]
>
> Signed-off-by: Rashika Kheria
Reviewed-by
The kernel already has this information, and individual drivers
shouldn't duplicate that. This also eliminates the use of __DATE__ and
__TIME__, which make the build non-deterministic.
Signed-off-by: Josh Triplett
---
drivers/staging/wlags49_h2/wl_version.h | 4
1 file chang
The kernel already has this information, and individual drivers
shouldn't duplicate that. This also eliminates the use of __DATE__ and
__TIME__, which make the build non-deterministic.
Signed-off-by: Josh Triplett
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 -
1 file chang
make sure no new
uses get added.
Josh Triplett (7):
mtd: denali: Drop print of build date/time
net: wireless: brcm80211: Drop debug version with build date/time
staging: rtl8188eu: Drop print of build date/time
staging: rts5139: Drop print of build time
staging: wlags49_h2: Drop debug
The kernel already has this information, and individual drivers
shouldn't duplicate that. This also eliminates the use of __TIME__,
which makes the build non-deterministic. (And, without __DATE__,
__TIME__ provided little useful information to begin with.)
Signed-off-by: Josh Tri
s’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/bcm/Qos.c |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
> index 1609a2
ce.c:
> drivers/staging/dgnc/dgnc_trace.c:180:6: warning: no previous prototype for
> ‘dgnc_tracer_free’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/dgnc/dgnc_trace.c |1 +
> 1 file changed, 1 insertion(+)
>
rototype for
> ‘PropagateCalParamsFromEEPROMToMemory’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/bcm/nvm.c | 61
> -
> 1 file changed, 61 deletions(-)
>
> diff --git a/drivers/staging/bcm/nvm.c
ce.c:
> drivers/staging/dgap/dgap_trace.c:181:6: warning: no previous prototype for
> ‘dgap_tracer_free’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/dgap/dgap_trace.c |1 +
> 1 file changed, 1 insertion(+)
>
totype for
> ‘t3e3_port_del_stats’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/sbe-2t3e3/ctrl.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/sbe-2t3e3/ctrl.c
p/dgap_parse.c:1252:7: warning: no previous prototype for
> ‘dgap_create_config_string’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1311:7: warning: no previous prototype for
> ‘dgap_get_config_letters’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by:
vious prototype for
> ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/dwc2/core.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dwc2/core.c b
s prototype for
> ‘smtcfb_setmode’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/sm7xxfb/sm7xxfb.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
&
s prototype for ‘hv_synic_free_cpu’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/hv/hv.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index f0c5e07.
.o
> drivers/staging/ft1000/ft1000-usb/ft1000_download.c: In function
> 'request_code_segment':
> drivers/staging/ft1000/ft1000-usb/ft1000_download.c:581:6: warning:
> 'status' may be used uninitialized in this function [-Wuninitialized]
>
>
> Signed-
On Tue, Nov 19, 2013 at 09:39:19PM -0800, Greg KH wrote:
> On Tue, Nov 19, 2013 at 08:56:59PM -0500, Josh Boyer wrote:
> > On Mon, Nov 18, 2013 at 10:03:10AM +0100, Sascha Hauer wrote:
> > > On Tue, Nov 12, 2013 at 12:15:45PM -0500, Josh Boyer wrote:
> > > > commit
On Mon, Nov 18, 2013 at 10:03:10AM +0100, Sascha Hauer wrote:
> On Tue, Nov 12, 2013 at 12:15:45PM -0500, Josh Boyer wrote:
> > commit b8d181e408af (staging: drm/imx: add drm plane support) added a file
> > to the make target for DRM_IMX_IPUV3 but didn't adjust the objs requ
the name of the resulting .ko. We also add an
EXPORT_SYMBOL_GPL for imx_drm_crtc_id.
Signed-off-by: Josh Boyer
---
drivers/staging/imx-drm/Makefile | 4 +++-
drivers/staging/imx-drm/imx-drm-core.c | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/M
On Tue, Nov 12, 2013 at 9:57 AM, Sascha Hauer wrote:
> Hi Josh,
>
> On Tue, Nov 12, 2013 at 09:32:08AM -0500, Josh Boyer wrote:
>> On Mon, Nov 11, 2013 at 11:22 AM, Josh Boyer
>> wrote:
>> > Hi All,
>> >
>> > With v3.12-2839-gedae583 (Linus&#
On Mon, Nov 11, 2013 at 11:22 AM, Josh Boyer wrote:
> Hi All,
>
> With v3.12-2839-gedae583 (Linus' tree as of this morning), the
> ipuv3-crtc.ko module fails to link with the following messages:
>
> ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/
X_IPUV3_CORE=m
CONFIG_DRM_IMX_IPUV3=m
I can send the full .config if people would like to see it.
I'm guessing the ipu_plane_* functions listed here need EXPORT_SYMBOL
statements added to them. Is this currently queued in anyone's tree?
josh
__
On Mon, Nov 04, 2013 at 10:01:00AM +0300, Dan Carpenter wrote:
> I've dropped most of the people from the CC list.
>
> On Sun, Nov 03, 2013 at 08:31:50PM -0800, Josh Triplett wrote:
> > On Mon, Nov 04, 2013 at 02:11:50AM +0300, Dan Carpenter wrote:
> > > On Sun, Nov
On Mon, Nov 04, 2013 at 02:11:50AM +0300, Dan Carpenter wrote:
> On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote:
> > On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote:
> > > The icount.reserved[] array isn't initialized so it leaks stack
> &g
On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote:
> The icount.reserved[] array isn't initialized so it leaks stack
> information to userspace.
>
> Reported-by: Nico Golde
> Reported-by: Fabian Yamaguchi
> Signed-off-by: Dan Carpenter
Reviewed-by: Josh Tri
at code, especially as I don't test it :)
>
> Minchan, Jiang, Nitin, what do you think of the patch below? Can I get
> your ack on it so that I can apply it?
I think you actually want to review v3 of this patch, not v2.
- Josh Triplett
___
60 matches
Mail list logo
