On Mon, 2015-06-22 at 22:12 +0300, Giedrius Statkevičius wrote:
> Convert a Microsoft compiler specific directive "#pragma pack(1)" to a
> GCC equivalent __attribute__ ((__packed__)). Also, by doing this we save
> ourselves from trouble if any other struct definitions are added after
> the #pragma
also a good
> one.
>
> Linux kernel style is based on Joe Perches finding that 80% of the code
> prefers one way or the other. That's a valid method for determining
> code style. I bet it normally picks the more readable style but it
> would be interesting to measure it more formally.
On Tue, 2015-06-23 at 12:23 +0300, Dan Carpenter wrote:
> people decided that
> Yoda code was a good idea based on their gut instead of using statistics
> and measurements and science.
I think that style exists because compilers
disallow CONST = val assignment typos.
On Fri, 2015-06-26 at 17:11 +0200, Luis de Bethencourt wrote:
> On Fri, Jun 26, 2015 at 07:49:32AM -0700, Joe Perches wrote:
> > On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote:
> > > Fix all checkpatch.pl warnings:
> > > WARNING: unnecessary whitesp
On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote:
> Fix all checkpatch.pl warnings:
> WARNING: unnecessary whitespace before a quoted newline
Unassociated but:
> diff --git a/drivers/staging/wilc1000/host_interface.c
> b/drivers/staging/wilc1000/host_interface.c
[]
> @@ -740,7 +740,7
On Sat, 2015-06-27 at 05:44 +0100, Vasiliy Korchagin wrote:
> This patch fixes the checkpatch.pl error:
>
> ERROR: Macros with complex values should be enclosed in parentheses
> +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr))
>
> Signed-off-by: Vasiliy Korchagin
> ---
> drivers/s
On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote:
> This patch fixes the checkpatch.pl error:
>
> ERROR: Macros with complex values should be enclosed in parentheses
> +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr))
>
> by expanding it as this macro is used only once.
[]
On Tue, 2015-06-30 at 10:42 +0300, Dan Carpenter wrote:
> On Tue, Jun 30, 2015 at 08:43:14AM +0200, Fabio Falzoi wrote:
> > No newline is needed since checkpatch doesn't complain about line longer
> > than 80 characters for string literals.
[]
> The original was correct.
The original was fine.
>
On Tue, 2015-06-30 at 20:45 +0300, Dan Carpenter wrote:
> On Tue, Jun 30, 2015 at 07:55:42AM -0700, Joe Perches wrote:
> > On Tue, 2015-06-30 at 10:42 +0300, Dan Carpenter wrote:
> > > On Tue, Jun 30, 2015 at 08:43:14AM +0200, Fabio Falzoi wrote:
> > > > No newl
On Wed, 2015-07-01 at 09:59 +0200, Krzysztof Hałasa wrote:
> Mario Bambagini writes:
>
> > Defines have been written in more than one line to match the 80-character
> > rule. This error has been fixed 6 times in this file.
> > The file is fully compliant with respect to the coding rules now.
>
>
On Wed, 2015-07-01 at 23:20 -0700, Joe Perches wrote:
> On Wed, 2015-07-01 at 09:59 +0200, Krzysztof Hałasa wrote:
> > Mario Bambagini writes:
> >
> > > Defines have been written in more than one line to match the 80-character
> > > rule. This error has been fixe
On Fri, 2015-07-03 at 12:58 +0200, Krzysztof Hałasa wrote:
> Joe Perches writes:
>
> > -#define LCONSOLE(mask, format, ...) CDEBUG(D_CONSOLE | (mask), format, ##
> > __VA_ARGS__)
> > -#define LCONSOLE_INFO(format, ...) CDEBUG_LIMIT(D_CONSOLE, format, ##
>
On Mon, 2015-07-06 at 08:07 +0200, Krzysztof Hałasa wrote:
> Joe Perches writes:
> > Nah, you're not an extremist, you're just preferring narrowly
> > localized readability over global consistency.
> >
> > That's fine and all, until you come up to LCONS
On Mon, 2015-07-06 at 19:36 -0700, Greg KH wrote:
> On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote:
> > On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote:
[]
> > > Here is another version with macro expansion. Inline function
> > > expansion do
On Tue, 2015-07-07 at 15:32 -0400, valdis.kletni...@vt.edu wrote:
> All: Is it time to kill that checkpatch test, or hide it behind a non-default
> flag, to prevent code churn?
I'm not an 80 column zealot.
This is for staging isn't it?
Code churn there is expected and somewhat desired.
A lot o
On Tue, 2015-07-07 at 22:08 -0400, valdis.kletni...@vt.edu wrote:
> On Tue, 07 Jul 2015 13:38:47 -0700, Joe Perches said:
>
> > The longest line in this file is 158 chars, that's
> > probably excessive, awk shows 35 lines > 80 chars.
>
> That doesn't coun
On Mon, 2015-07-06 at 14:16 +0200, Krzysztof Hałasa wrote:
> Joe Perches writes:
>
> >> So, could we have the localized readability when it makes sense,
> >> and the default rules when nothing else applies?
> >
> > Then the question becomes how local.
>
&g
On Wed, 2015-07-08 at 22:59 -0700, Greg KH wrote:
> On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote:
> > Fixed a coding style issue.
[]
> > diff --git a/drivers/staging/android/ion/ion.c
> > b/drivers/staging/android/ion/ion.c
[]
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(st
On Mon, 2015-07-13 at 17:29 +, Craig wrote:
> Modified style issue in ion.c. Missing empty line after a definition
>
> Signed-off-by: Craig
> ---
> drivers/staging/android/ion/ion.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/ion/ion.c
> b/drivers/stagi
On Tue, 2015-07-14 at 14:07 +0300, Dan Carpenter wrote:
> A lot of the Fixes: tags go over the 75 character limit and that's ok.
>
> Fixes: 2a076f40d8c9 ('checkpatch, SubmittingPatches: suggest line wrapping
> commit messages at 75 columns')
> Signed-off-by: Dan Carpenter
> ---
> The other commo
On Thu, 2015-07-16 at 00:16 +0530, Vinay Simha BN wrote:
> scripts/checkpatch.pl kernel coding style fixes of WARNING
Please don't be a checkpatch robot.
Use tools to prompt your brain, but don't ever turn
your brain off.
> diff --git a/drivers/staging/sm750fb/ddk750_help.h
> b/drivers/staging/
On Thu, 2015-07-16 at 10:11 -0700, Greg KH wrote:
> On Thu, Jul 16, 2015 at 09:41:36AM +0200, Guillaume Bienkowski wrote:
> > Fix spaces before comma and indentation.
>
> That's two different things, so this should be two different patches
> please.
I think it'd be better to do all the whitespace
On Thu, 2015-07-16 at 23:11 +, Craig Inches wrote:
> Fixed up some checkpatch.pl style issues.
> Line greater than 80 Chars in multiple locations.
I think most all of these are not improvements.
Please use --strict when verifying your patches.
Please fix the time on your system.
On Fri, 2015-07-17 at 00:20 +, Craig Inches wrote:
> Hi Joe,
Rehi Craig.
> On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote:
> > On Thu, 2015-07-16 at 23:11 +, Craig Inches wrote:
> > > Fixed up some checkpatch.pl style issues.
> > > Line gre
On Fri, 2015-07-17 at 12:58 +0530, Vinay Simha BN wrote:
> scripts/checkpatch.pl kernel coding style fixes of WARNING
Please use checkpatch's --strict option until you know
kernel style much better.
> diff --git a/drivers/staging/sm750fb/sm750_accel.h
> b/drivers/staging/sm750fb/sm750_accel.h
[]
On Fri, 2015-07-17 at 15:59 +0200, Joseph-Eugene Winzer wrote:
> Fixed a few lines that were longer than 80 chars.
[]
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c
> b/drivers/staging/rtl8192u/r8192U_core.c
[]
> @@ -212,7 +212,9 @@ static void rtl819x_set_channel_map(u8 channel_plan,
> st
On Fri, 2015-07-17 at 15:59 +0200, Joseph-Eugene Winzer wrote:
> Reformatting the code without introducing other warnings
> like 'Avoid unnecessary line continuations' or breaking strings.
Very few of these seem to be improvements and many
of them should likely be in separate patches.
> diff --gi
On Fri, 2015-07-17 at 11:35 +0200, Luis de Bethencourt wrote:
> bool Reval is set to match the value of bHalfWirelessN24GMode just to
> this. The value can be returned directly. Removing uneeded bool.
trivia:
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c
> b/drivers/staging/rtl8192u/r819
On Sun, 2015-07-19 at 20:41 +0200, Mario Bambagini wrote:
> Fixed comment line to match the 80-char rules.
> The line contained 81 characters.
> The file is fully compliant with the code style, now.
>
> Signed-off-by: Mario Bambagini
> ---
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 2 +
On Tue, 2015-07-21 at 13:10 +0530, Vinay Simha BN wrote:
> scripts/checkpatch.pl kernel coding style fixes of WARNING
Please run your patches through scripts/checkpatch.pl --strict
> diff --git a/drivers/staging/sm750fb/ddk750_power.h
> b/drivers/staging/sm750fb/ddk750_power.h
> index b7cf6b2..a
On Thu, 2015-07-23 at 20:19 +0900, Chaehyun Lim wrote:
> Add error check if memory allocation is failed.
trivia:
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c
> b/drivers/staging/wilc1000/coreconfigurator.c
[]
> @@ -812,6 +812,9 @@ s32 ParseNetworkInfo(u8 *pu8MsgBuffer, tstrNetworkI
Making --strict the default for staging may help some people
submit patches without obvious defects.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 34ca400..50693f5
On Wed, 2015-07-29 at 21:34 -0400, Dave Perez wrote:
> This is a patch to the rtw_debug.c file that fixes styling errors relating to
> new lines after variable declarations.
[]
> diff --git a/drivers/staging/rtl8188eu/core/rtw_debug.c
> b/drivers/staging/rtl8188eu/core/rtw_debug.c
[]
> @@ -219,6
On Thu, 2015-07-30 at 13:09 +0300, Dan Carpenter wrote:
> > diff --git a/drivers/staging/android/lowmemorykiller.c
> > b/drivers/staging/android/lowmemorykiller.c
[]
> > @@ -127,11 +127,15 @@ static unsigned long lowmem_scan(struct shrinker *s,
> > struct shrink_control *sc)
> > if (!
On Fri, 2015-07-31 at 11:02 +0530, Shraddha Barke wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: do not add new typedefs
> Signed-off-by: Shraddha Barke
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> d
ao
> > Reviewed-by: Zhang Di
> > Reviewed-by: Dan Carpenter
>
> I don't really feel comfortable saying I reviewed this code. I just
> commented on a few process issues. I don't know the subsystem well
> enough to give it a seal of approval.
>
> > Review
On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote:
> On Mon, Aug 03, 2015 at 11:18:31AM +, Shah, Yash (Y.) wrote:
> > From: Yash Shah
> >
> > Fixed code indentation warning as detected by checkpatch.pl.
> >
> > Signed-off-by: Yash Shah
>
> Defines aren't allowed in .c files anyway.
T
On Mon, 2015-08-03 at 15:09 +0300, Dan Carpenter wrote:
> On Mon, Aug 03, 2015 at 04:41:40AM -0700, Joe Perches wrote:
> > On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote:
> > > On Mon, Aug 03, 2015 at 11:18:31AM +, Shah, Yash (Y.) wrote:
> > > > From: Yas
On Tue, 2015-08-04 at 16:10 +0800, Jandy Gou wrote:
> Signed-off-by: Jandy Gou
[]
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h
> b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h
[]
> @@ -721,7 +721,7 @@ kiblnd_nid2peerlist (lnet_nid_t nid)
> unsigned int hash =
>
On Sat, 2016-12-10 at 00:56 +0100, Markus Böhme wrote:
> On 12/09/2016 09:50 AM, Kalle Valo wrote:
> > Dan Carpenter writes:
> >
> > > On Thu, Dec 08, 2016 at 02:50:49PM +0300, Dan Carpenter wrote:
> > > > On Thu, Dec 08, 2016 at 01:43:42PM +0200, Kalle Valo wrote:
> > > > > But it would make me
On Sat, 2016-12-10 at 23:44 -0600, Larry Finger wrote:
> These messages are always logged and reprresent error conditions, thus
> we can use pr_err().
>
> Signed-off-by: Larry Finger
> Cc: Ping-Ke Shih
> ---
> drivers/net/wireless/realtek/rtlwifi/base.c | 15 -
> drivers/net/wireless/r
On Mon, 2016-12-12 at 19:41 +, James Simmons wrote:
> > On Mon, 2016-12-12 at 17:34 +0100, Greg Kroah-Hartman wrote:
[]
> > http://wiki.lustre.org/Lustre_Style_Guide_Includes
> >
> > There is no single mandated code style for this.
> > Some people like reverse christmas tree.
> >
> > Whatever
On Mon, 2016-12-12 at 17:34 +0100, Greg Kroah-Hartman wrote:
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top
>
> On Mon, Dec 12, 2016 at 02:42:29PM +, Ben Evans wrote:
>
On Fri, 2016-12-16 at 19:59 +0530, Tabrez khan wrote:
> Remove unnecessary braces {} for single while statement.
Your patch is fine Tabrez, but to the lustre folk:
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c
> b/drivers/staging/lustre/lustre/obdclass/cl_io.c
[]
> @@ -1371,9 +13
On Fri, 2016-12-16 at 23:29 +0530, Tabrez khan wrote:
> Remove unnecessary braces {} from single line if statement.
> This warning is found using checkpatch.pl.
[]
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/import.c
> b/drivers/staging/lustre/lustre/ptlrpc/import.c
[]
> @@ -1134,9 +1134,9
On Fri, 2016-12-16 at 21:53 +0300, Dan Carpenter wrote:
> On Fri, Dec 16, 2016 at 10:43:24AM -0800, Joe Perches wrote:
> > On Fri, 2016-12-16 at 23:29 +0530, Tabrez khan wrote:
> > > Remove unnecessary braces {} from single line if statement.
> > > This warning i
On Thu, 2016-12-15 at 12:22 -0600, Larry Finger wrote:
> These messages are always logged and represent error conditions, thus
> we can use pr_err().
OK and some trivialities:
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c
> b/drivers/net/wireless/realtek/rtlwifi/base.c
[]
> @@ -389,
ady fail!! REG_MCUFWDL:0x%08x .\n",
> - value32);
> + pr_err("Polling FW ready fail!! REG_MCUFWDL:0x%08x .\n",
> +value32);
It's odd to fix / remove " .\n" above but here and
the wrapping comment on th
On Sun, 2016-12-18 at 15:06 +0530, Devendra Sharma wrote:
> From: devendra sharma
[]
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c
> b/drivers/staging/comedi/drivers/cb_pcidas64.c
[]
> @@ -1500,10 +1500,9 @@ static int alloc_and_init_dma_members(struct
> comedi_device *dev)
>
On Sun, 2016-12-18 at 16:46 +, Afonso Bordado wrote:
> Converts from CamelCase to the recommended style.
>
> Signed-off-by: Afonso Bordado
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/
On Sun, 2016-12-18 at 15:43 +0530, devendra sharma wrote:
> Fixed check patch warnings about multiple line dereferencing
[].
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c
> b/drivers/staging/comedi/drivers/cb_pcidas64.c
[]
> @@ -2476,18 +2475,15 @@ static int setup_channel_queue(stru
On Fri, 2016-12-16 at 17:00 -0800, Kees Cook wrote:
> Prepare to mark sensitive kernel structures for randomization by making
sure they're using designated initializers.
About the designated initializer patches,
which by themselves are fine of course,
and the fundamental randomization plugin,
c gu
On Tue, 2016-12-20 at 20:58 -0600, Scott Matheina wrote:
> Fixed indention and space issues to align the code with the linux style guide.
[]
> diff --git a/drivers/staging/iio/addac/adt7316.c
> b/drivers/staging/iio/addac/adt7316.c
[]
> @@ -176,16 +176,16 @@
> */
>
> struct adt7316_chip_info {
On Wed, 2016-12-21 at 19:02 -0600, Scott Matheina wrote:
> On 12/20/2016 09:23 PM, Joe Perches wrote:
> > On Tue, 2016-12-20 at 20:58 -0600, Scott Matheina wrote:
> > > Fixed indention and space issues to align the code with the linux style
> > > guide.
> > []
&
On Tue, 2017-01-10 at 23:40 +0200, Bogdan Purcareata wrote:
> Fix following checkpatch warnings:
> - Lines over 80 characters
> - void function with return statement
> - Unaligned comment mark
> - Header function prototypes missing variable names
Please read Documentation/SubmittingPatches
(umm, m
On Tue, 2017-01-17 at 11:27 +0300, Dan Carpenter wrote:
> On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote:
> > Split line at boolean operator.
> >
> > Error was reported by checkpatch.pl as
> > WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data'
[]
> > diff
On Sat, 2017-01-21 at 19:40 -0500, James Simmons wrote:
> The upstream kernel requires proper structures so
> convert nearly all the LNet wire protocols typedefs in
> the LNet core.
Thanks.
Perhaps s/\bWIRE_ATTR\b/__packed/g one day too
___
devel maili
On Tue, 2017-01-24 at 22:22 +, Dilger, Andreas wrote:
> On Jan 24, 2017, at 09:40, Ernestas Kulik wrote:
> >
> > Using octal permissions instead of symbolic ones is preferred.
>
> Typically the reverse is true - using symbolic constants is preferred over
> numeric ones.
> Where does this re
On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote:
> Generated with checkpatch.pl --fix-inplace and git add -p out of the
> results.
Maybe another.
> diff --git a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c
> b/drivers/staging/media/platform/bcm2835/mmal-vchiq.c
[]
> @@ -239,7 +239,7
On Sat, 2017-01-28 at 19:05 +1300, Derek Robson wrote:
> A style fix across whole driver.
> changed permissions to octal style, found using checkpatch
[]
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
[]
> @@ -58,8 +58,8 @@ MODULE_LICENSE("GPL");
> MODULE_VERSION(SP
On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote:
> Joe Perches writes:
>
> > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote:
> > > Generated with checkpatch.pl --fix-inplace and git add -p out of the
> > > results.
> >
> > Maybe another.
>
On Mon, 2017-01-30 at 17:44 +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 30, 2017 at 11:31:42AM -0500, Maksymilian Piechota wrote:
> > This patch fixes the checkpatch.pl warning:
> >
> > WARNING: Statements should start on a tabstop
> >
> > Signed-off-by: Maksymilian Piechota
> > ---
> > driv
On Tue, 2017-01-31 at 06:04 -0500, Maksymilian Piechota wrote:
> On Mon, Jan 30, 2017 at 08:00:36PM -0800, Joe Perches wrote:
> > On Mon, 2017-01-30 at 17:44 +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Jan 30, 2017 at 11:31:42AM -0500, Maksymilian Piechota wrote:
> >
On Tue, 2017-01-31 at 06:33 -0500, Maksymilian Piechota wrote:
> On Tue, Jan 31, 2017 at 03:18:45AM -0800, Joe Perches wrote:
> > checkpatch is just a guide, it's brainless.
> >
> > The reason these lines are > 80 columns is
> > overly long/verbose identifi
On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote:
> This is checkpatch fix for hal/bb_cfg.c file:
> remove not necessary braces {}
>
> Signed-off-by: Martin Karamihov
> ---
> drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git
On Tue, 2017-01-31 at 10:30 -0800, Eric Anholt wrote:
> Joe Perches writes:
>
> > On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote:
> > > Joe Perches writes:
> > >
> > > > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote:
> > > > &g
On Wed, 2017-02-01 at 18:36 +0200, Martin Karamihov wrote:
>
> On 02/01/2017 12:39 AM, Joe Perches wrote:
> > On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote:
> > > This is checkpatch fix for hal/bb_cfg.c file:
> > > remove not necessary braces {}
>
On Wed, 2017-02-01 at 12:59 -0800, Logan Gorence wrote:
> Convert spaces to tabs in ks_hostif.h, according to
> the checkpatch.pl script.
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.h
> b/drivers/staging/ks7010/ks_hostif.h
[]
> @@ -569,18 +569,18 @@ struct hostif_mic_failure_confirm_t {
>
On Thu, 2017-02-02 at 03:22 +0530, Arushi wrote:
> This patch fixes the issue by aligning the * on each line in block comments.
[]
> diff --git a/drivers/staging/speakup/speakup_decpc.c
> b/drivers/staging/speakup/speakup_decpc.c
[]
> @@ -85,8 +85,8 @@
> #define CTRL_io_priority0x0c0
On Wed, 2017-02-01 at 21:43 +, Craig Kewley wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: Avoid multiple line dereference
Hi Craig.
Please try to make the code more sensible in preference to
just fixing checkpatch warnings.
> diff --git a/drivers/staging/vt6656/rxtx.c b/dri
On Thu, 2017-02-02 at 23:28 +0530, Arushi wrote:
> This patch fixes the issue by aligning the * on each line in block comments.
> [Patch v1] is rejected as the changes done is not following the linux
> coding style and [Patch v2] is rejected because forgot to mention the
> cause of rejection of [Pa
On Sun, 2017-01-29 at 17:43 +0100, Bjørn Mork wrote:
> Greg KH writes:
>
> > Please take some time, and go read Documentation/SubmittingPatches.
>
> That's quickly done nowadays:
>
> bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
> This file has moved to process
On Thu, 2017-02-02 at 08:06 +0200, Martin Karamihov wrote:
> On 02/01/2017 08:11 PM, Joe Perches wrote:
> > ...and clarifying the code for a
> > human reader is much more important than making a
> > file not have any checkpatch warnings.
>
> I agree. I respect the devel
On Thu, 2017-02-02 at 15:43 +0100, Arnd Bergmann wrote:
> Having a local variable of 1024 bytes on 64-bit architectures is a bit
> too much, and I ran into this warning while trying to see what functions
> use the largest stack:
>
> drivers/staging/fbtft/fbtft-sysfs.c: In function 'store_gamma_cur
On Fri, 2017-02-03 at 17:17 +0100, Hendrik v. Raven wrote:
> VC_AUDIO_MAX_MSG_LEN
This macro seems unused and might as well be removed.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev
64 bit stats isn't implemented, but is that really necessary?
Anything else?
It seems like the driver doesn't need to be there anymore.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverd
On Fri, 2017-02-03 at 10:50 -0800, Florian Fainelli wrote:
> (with JC's other email)
And now with Greg's proper email too
> On 02/03/2017 10:47 AM, Joe Perches wrote:
> > 64 bit stats isn't implemented, but is that really necessary?
> > Anything else?
>
>
On Fri, 2017-02-03 at 13:10 +0100, Slawomir Stepien wrote:
> On Feb 03, 2017 11:27, Greg KH wrote:
> > On Fri, Feb 03, 2017 at 11:11:35AM +0100, Slawomir Stepien wrote:
> > > Hi all
> > >
> > > There is a "false positive" error reported by checkpatch.pl:
> > >
> > > ERROR: Use 4 digit octal (0777
On Sat, 2017-02-04 at 16:31 +1300, Derek Robson wrote:
> On Sat, Feb 04, 2017 at 10:41:20AM +0800, kbuild test robot wrote:
> > Hi Derek,
> >
> > [auto build test ERROR on staging/staging-testing]
> > [also build test ERROR on v4.10-rc6 next-20170203]
> > [if your patch is applied to the wrong git
-#define USER_R (S_IFREG|S_IRUGO)
> > -#define USER_W (S_IFREG|S_IWUGO)
> > +#define USER_R (S_IFREG|0444)
> > +#define USER_W (S_IFREG|0666)
>
> which really defeat the purpose of the whole exercise.
Why do you think mixing file specific attributes
with octal permissions is a bad th
On Fri, 2017-02-03 at 22:26 -0600, Parav Pandit wrote:
> This patch makes use of is_vlan_dev() function instead of flag
> comparison which is exactly done by is_vlan_dev() helper function.
Thanks.
btw: after applying this patch, there is one left
$ git grep -E -n "&\s*IFF_802_1Q_VLAN\b" -- "*.c
On Sat, 2017-02-04 at 19:10 +0100, Julia Lawall wrote:
>
> On Fri, 3 Feb 2017, Joe Perches wrote:
>
> > (adding Julia Lawall)
> >
> > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote:
> > > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wro
On Sat, 2017-02-04 at 20:24 +0100, Julia Lawall wrote:
>
> On Sat, 4 Feb 2017, Joe Perches wrote:
>
> > On Sat, 2017-02-04 at 19:10 +0100, Julia Lawall wrote:
> > >
> > > On Fri, 3 Feb 2017, Joe Perches wrote:
> > >
> > > > (adding Juli
On Mon, 2017-02-06 at 14:03 +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 06, 2017 at 07:56:39AM -0500, Maksymilian Piechota wrote:
> > On Mon, Feb 06, 2017 at 01:50:02PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> > > > - move log
On Mon, 2017-02-06 at 11:13 -0500, Maksymilian Piechota wrote:
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c
> b/drivers/staging/wlan-ng/prism2mgmt.c
[]
> @@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev,
> void *msgp)
> && (msg->prismheader.data =
On Fri, 2017-02-10 at 17:14 +0100, AbdAllah-MEZITI wrote:
> Trailing statements should be on next line.
[]
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
> b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
[]
> @@ -563,7 +563,8 @@ int bcm2835_audio_set_ctls(struct bcm2835_chip *chip)
>
On Tue, 2015-01-20 at 16:08 +0200, Mohamed Lotfy Hammad wrote:
> This patch fixes the following checkpatch.pl warning:
> fix line over 80 characters
[]
> diff --git a/drivers/staging/dgnc/dgnc_driver.c
> b/drivers/staging/dgnc/dgnc_driver.c
[]
> @@ -54,14 +54,14 @@ MODULE_SUPPORTED_DEVICE("dgnc")
On Wed, 2015-01-21 at 18:44 +0200, Lin Kassem wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Prefer ether_addr_copy() over memcpy()
> if the Ethernet addresses are __aligned(2)
>
> Pahole showed that the 2 structs are aligned to u16
[]
> diff --git a/drivers/staging/vt6656/r
On Wed, 2015-01-21 at 16:41 +0200, Lin Kassem wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Missing a blank line after declarations
False positives. Unnecessary changes.
> diff --git a/drivers/staging/rtl8712/drv_types.h
> b/drivers/staging/rtl8712/drv_types.h
[]
> @@ -12
ectly emits a warning for
"missing a blank line after declarations".
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 8
1 file changed, 8 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 41223c9..fadb47d 100755
--- a/scripts/checkpatch.p
On Thu, 2015-01-22 at 15:30 +0800, micky_ch...@realsil.com.cn wrote:
> update card drive settings, This setting can be used for rts5249
> rts524A and rts525A.
[]
> diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c
> @@ -36,16 +36,16 @@ static u8 rts5249_get_ic_version(struct rtsx_pcr *pcr
On Thu, 2015-01-22 at 19:55 +0100, Krzysztof Adamski wrote:
> This patch fixes coding style of PCI device table declaration.
[]
> diff --git a/drivers/staging/dgnc/dgnc_driver.c
> b/drivers/staging/dgnc/dgnc_driver.c
[]
> @@ -98,11 +98,11 @@ static struct timer_list dgnc_poll_timer;
>
>
> stat
On Tue, 2015-01-27 at 22:30 +0200, Heba Aamer wrote:
> This patch set fixes most of the checkpatch.pl coding
> style errors found in drivers/staging/fbtft/fb_pcd8544.c
>
> Heba Aamer (6):
> staging: fbtft: fix space required after that ';'
> staging: fbtft: fix spaces required around that '='
On Wed, 2015-01-28 at 23:46 +0100, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
[]
> diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c
> b/drivers/staging/lustre/lustre/fid/lproc_fid.c
[]
>
On Wed, 2015-01-28 at 16:05 +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> Prefer seq_puts to seq_printf
checkpatch is pretty stupid.
Please don't just do what it says.
Look further and see what else can be improved.
> diff --git a/drivers/staging/lustre/lustr
On Mon, 2015-02-02 at 19:26 +0100, Ricardo Ribalda Delgado wrote:
> Instead of declaring a new type, define a new struct.
[]
> diff --git a/drivers/staging/unisys/visorutil/procobjecttree.c
> b/drivers/staging/unisys/visorutil/procobjecttree.c
[]
> @@ -340,7 +341,9 @@ EXPORT_SYMBOL_GPL(visor_proc_
On Tue, 2015-02-03 at 21:05 +0100, bill wrote:
> Ok,thank you, I will do that and resend the patch again.
I wouldn't.
It's probably better as a separate patch anyway.
btw: please don't top post.
cheers, Joe
> On Tue, Feb 03, 2015 at 11:05:08AM -0800, Joe Perches wrote:
&
On Tue, 2015-02-03 at 19:58 +0100, Bilel DRIRA wrote:
> This patch fix the checkpatch.pl WARNING:
[]
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
[]
> @@ -1963,11 +1948,10 @@ static irqreturn_t ft1000_interrupt(int irq, void
On Thu, 2015-02-05 at 16:30 +, Al Viro wrote:
> On Mon, Feb 02, 2015 at 08:13:10PM +0100, Andreas Ruprecht wrote:
>
> > On a serious note: I do understand what you're getting at, I don't take
> > that personally (and I will send a v2 addressing the things above), but
> > honestly, this kind of
On Thu, 2015-02-05 at 09:31 -0800, Joe Perches wrote:
> On Thu, 2015-02-05 at 20:25 +0300, Dan Carpenter wrote:
> > Acked-by: Dan Carpenter
>
> Maybe I should add sparse too... ;)
drat, of course I meant smatch...
___
devel
701 - 800 of 1318 matches
Mail list logo
