[edk2] [PATCH 1/7] ArmPkg/AsmMacroIoLibV8: remove undocumented assumption from ELx macros

The macros EL1_OR_EL2() and EL1_OR_EL2_OR_EL3() allow conditional execution of assembly sequences based on the current exception level, by jumping to caller supplied labels 1f, 2f or 3f. However, the jump to 1f is actually a fallthrough, which means the EL1 code needs to follow right after the macr

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

On 03/18/16 15:48, Gao, Liming wrote: > Laszlo: > > I understand the request to BaseTools is that AutoGen code can pass > GCC or MSFT compiler without any warning. If so, EDKII module can enable > non default warnings in itself. I will evaluate BaseTools. Thank you! > And, you raise one issue

Re: [edk2] EDK2 Staging Proposal 3rd draft, final?

David, I responded to an earlier email: == I think there are several methods we can support for development. 1) Simple bug fixes/features sent directly to edk2-devel for PRs. 2) A larger or more complex bug fix/feature can optionally post a link to a branch on

Re: [edk2] [PATCH v3] MdeModulePkg: Fixed incorrect return value of MatchString

On 2016/3/17 10:46, Zeng, Star wrote: On 2016/3/17 10:23, Cecil Sheng wrote: In UEFI2.6, CapturePtr's in the Captures array returned by MatchString are to be separatedly allocated so that they can be freed by the caller. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cec

Re: [edk2] [PATCH v3] MdeModulePkg: Fixed incorrect return value of MatchString

On 2016/3/17 10:23, Cecil Sheng wrote: In UEFI2.6, CapturePtr's in the Captures array returned by MatchString are to be separatedly allocated so that they can be freed by the caller. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cecil Sheng Reviewed-by: Samer El-Haj-Mah

[edk2] [PATCH] BaseTools: Updated BuildNotes URLs

Updated URLs (git repository and step-by-step instructions) CC: Yonghong Zhu CC: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Peter Kirmeier --- BaseTools/BuildNotes.txt | 4 ++-- BuildNotes2.txt | 24 +--- 2 files changed, 13 inse

Re: [edk2] [PATCH] Ax88772b: Fixing compilation error variable set but not used

On 19 February 2016 at 18:06, Shivamurthy Shastri < shivamurthy.shas...@linaro.org> wrote: > > On 19 February 2016 at 17:45, Laszlo Ersek wrote: > >> On 02/19/16 13:04, Shivamurthy Shastri wrote: >> > On 19 February 2016 at 16:30, Laszlo Ersek wrote: >> > >> >> On 02/10/16 15:07, Shivamurthy Sha

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

Hello, I am curious what value enabling the warning for an unused argument adds. Can someone provide some examples where enabling this warning and adding the UNUSED tag addresses real issues? I am concerned that we are enabling a warning that would impose a large number of source changes with

Re: [edk2] [PATCH] OvmfPkg/PlatformPei: suppress wrong VS2008 warning (use of uninited local)

On 03/19/16 00:35, Laszlo Ersek wrote: > VS2008 seems to think that the "PciExBarBase" variable (introduced in > commit 7b8fe63561b4) can be evaluated for the > AddReservedMemoryBaseSizeHob() function call with its value being > uninitialized / indeterminate. This is not the case (see > "mHostBridg

Re: [edk2] signedness of CHAR8

On 03/17/16 13:16, Leif Lindholm wrote: > So, as further fallout from my -Weverything experiments, I've come > across this... > > Ia32 and X64 ProcessorBind.h (BaseTools and MdePkg) both define CHAR8 as > 'char'. > ARM and AArch64 both do the same. > > However, default 'char' signedness is unsig

[edk2] [PATCH 2/7] ArmPkg/ArmExceptionLib: fold exception handler prologue into vector table

Unlike the AArch32 vector table, which has room for a single instruction for each exception type, the AArch64 exception table has 128 byte slots, which can easily hold the shared prologues that are emitted out of line. So refactor this code into a single macro, and expand it into each vector table

Re: [edk2] EDK2 Staging Proposal 3rd draft, final?

On Fri, 2016-03-18 at 14:24 +0100, Laszlo Ersek wrote: > Except my own actions. I'm already watching the github issue tracker and > get emails of the actions of others. No emails about my own actions. It > makes the email audit trail completely unusable. That's your personal email notification. If

Re: [edk2] EDK2 Staging Proposal 3rd draft, final?

David, Yes. Use of developer github forks is supported. I had summarized 3 development methods earlier in this thread. 1) PR emails send to edk2-devel. There is a Wiki page that details process for developers and maintainer. 2) Branch on developer owned github fork of edk2. There have been

Re: [edk2] [PATCH v2] MdeModulePkg: Fixed incorrect Regular expression protocol MatchString return value.

Cecil, I had two comments for the first patch, this V2 patch only covers one of the comments. And one further comment below for this V2 patch. On 2016/3/17 9:33, Cecil Sheng wrote: According to UEFI2.6, CapturePtr in the Captures array returned by MatchString() should be separatedly allocat

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

(adding Ard and Shumin because the below will tie in with another thread) On 03/17/16 19:05, Leif Lindholm wrote: > I must confess to no small amount of surprise that optionally adding > the ability to tag an unused argument as unused is controversial. I'm also surprised, but by a different thin

Re: [edk2] [RFC] MdePkg: add ARG_UNUSED notation to Base.h

> On Mar 16, 2016, at 10:06 AM, Laszlo Ersek wrote: > > On 03/16/16 17:50, Andrew Fish wrote: >> >>> On Mar 16, 2016, at 6:54 AM, Laszlo Ersek wrote: >>> >>> On 03/14/16 16:38, Leif Lindholm wrote: To permit many existing platforms to build with -Wunused-parameter, on GCC and CLANG,

Re: [edk2] [Patch] PcAtChipsetPkg/PciHostBridge: Remove PciHostBridge driver

On 03/18/16 07:34, Ruiyu Ni wrote: > MdeModulePkg contains a new PciHostBridgeDxe driver which is a > super set of PcAtChipsetPkg/PciHostBridgeDxe. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Laszlo Ersek > Cc: Xiaofeng Wang > --- > PcAtChipsetPk

[edk2] Is there any exiting way in edk2 to format a partition with FAT file system?

Hi experts, Is there any exiting way in edk2 to format a partition with FAT file system? If not, shall we implement an interface to do that? It is useful when we are using a ramdisk in UEFI, or a raw hard disk not relying on OS utilities. Thanks. Heyi

Re: [edk2] [PATCH] Ax88772b: support for multiple dongles and chips

On 18 February 2016 at 22:11, Shivamurthy Shastri < shivamurthy.shas...@linaro.org> wrote: > Adding Ruiyu Ni > > -- > > Thanks and Regards, > > Shivamurthy Shastri, > > M: +919742508553, IRC: shivamurthy, > *Linaro.org* |Open Source Software for ARM SOCs > > > On 18 February 2016 at 16:50, Shivamu

Re: [edk2] [PATCH v2] OvmfPkg/PlatformPei: Fix VS2008 build breakage

On 03/18/16 16:12, David Woodhouse wrote: > Commit 7b8fe6356 ("OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG / > ECAM) on Q35") broke the VS2008 build, causing it to complain of > "potentially uninitialized local variable 'PciExBarBase' used" at > line 275. > > On this occasion it isn't actu

[edk2] [PATCH 0/7] ArmPkg/ArmExceptionLib cleanup

After Eugene has kindly contributed his refactored version of the ArmExceptionLib, this series cleans up the original migrated code, as a general cleanup and optimization effort. Ard Biesheuvel (7): ArmPkg/AsmMacroIoLibV8: remove undocumented assumption from ELx macros ArmPkg/ArmExceptionLib:

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

> On Mar 16, 2016, at 6:59 PM, Zeng, Star wrote: > > On 2016/3/17 7:12, Andrew Fish wrote: >> I was trying to move over to DxeDebugPrintErrorLevelLib, but I can't get it >> to build >> >> For example I made DXE use >> DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/Dxe

[edk2] signedness of CHAR8

So, as further fallout from my -Weverything experiments, I've come across this... Ia32 and X64 ProcessorBind.h (BaseTools and MdePkg) both define CHAR8 as 'char'. ARM and AArch64 both do the same. However, default 'char' signedness is unsigned in the ARM architectures, and signed in the others.

Re: [edk2] [RFC] MdePkg: add ARG_UNUSED notation to Base.h

I think this question on StackOverflow might be helpful: https://stackoverflow.com/questions/7090998/portable-unused-parameter-macro-used-on-function-signature-for-c-and-c The comment by 'the swine' suggests '__pragma(warning(suppress:4100))' to be used for MSVC. I also believe the answer by 'do

[edk2] Applying the patch 5811eea0fdb56187597e50b1282e7cfab4965a65 causes UEFI boot freeze (armv8 platform)

Hi Eugene, This commit: Author: Cohen, Eugene 2016-03-07 07:16:38 Committer: Ard Biesheuvel 2016-03-17 01:15:14 Parent: 8a47a6cb9e77e4cc4bf42391f7f970173bcead27 (Omap35xxPkg: drop CpuExceptionHandlerLib library class resolution) Branch: remotes/origin/master Follows: Precedes: ArmPkg: up

Re: [edk2] [PATCH] MdePkg: Add EFI_FIRMWARE_IMAGE_DESCRIPTOR V1 and V2 structure definition.

Looks good. Reviewed-by: Jaben Carsey > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Wednesday, March 16, 2016 10:31 AM > To: edk2-devel@lists.01.org > Cc: samer.el-haj-mahm...@hpe.com; Carsey, Jaben > ; Tapan Shah > Subject: [PATCH] MdePkg: Add EFI_FIRMWARE

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

> On Mar 16, 2016, at 7:37 PM, Andrew Fish wrote: > >> >> On Mar 16, 2016, at 7:18 PM, Zeng, Star wrote: >> >> On 2016/3/17 10:02, Andrew Fish wrote: >>> On Mar 16, 2016, at 6:59 PM, Zeng, Star wrote: On 2016/3/17 7:12, Andrew Fish wrote: > I was trying to move over to D

Re: [edk2] [RFC 1/3] MdePkg: Add PCD for UART default receive FIFO depth

Hi Ruiyu, Does it also mean the type in EFI_SERIAL_IO_MODE is mainly for data alignment? Heyi On 03/17/2016 10:29 AM, Ni, Ruiyu wrote: Heyi, I agree with the general idea of the patch to add a PCD for DefaultReceiveFifoDepth. I understand you choose UINT32 for the FIFO depth because the E

Re: [edk2] [PATCH 0/7] ArmPkg/ArmExceptionLib cleanup

On Thu, Mar 17, 2016 at 02:20:08PM +0100, Ard Biesheuvel wrote: > After Eugene has kindly contributed his refactored version of the > ArmExceptionLib, this series cleans up the original migrated code, > as a general cleanup and optimization effort. Nice bit of cleanup. For the series: Reviewed-by

Re: [edk2] Applying the patch 5811eea0fdb56187597e50b1282e7cfab4965a65 causes UEFI boot freeze (armv8 platform)

On 18 March 2016 at 14:34, Cohen, Eugene wrote: > Vladimir, > >> Loading driver at 0x000BBE23000 EntryPoint=0x000BBE23280 >> ArmTimerDxe.efi > > This is the point where the Timer driver will register with the interrupt > controller driver and enable timer tick interrupts so the first IRQ interrup

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

On 17 March 2016 at 19:51, Laszlo Ersek wrote: >> I must confess to no small amount of surprise that optionally adding >> the ability to tag an unused argument as unused is controversial. > > I'm also surprised, but by a different thing. :) > (2) Beyond removing "-Wno-unused-but-set-variable", I

Re: [edk2] [PATCH] ArmPkg/AArch64Mmu: use correct AP[] bits in ArmClearMemoryRegionReadOnly

On Thu, Mar 17, 2016 at 02:55:00PM +0100, Ard Biesheuvel wrote: > The function ArmClearMemoryRegionReadOnly() was supposed to undo the > effect of ArmSetMemoryRegionReadOnly(), but instead, it sets the permissions > to EL0-no access, EL1-read-only. Since the EL0 bit should be 1 to align > with EL2/

[edk2] [PATCH v2 1/3] MdePkg: Add PCD for UART default receive FIFO depth

PcdUartDefaultReceiveFifoDepth is added to indicate UART default receive FIFO depth. Type of UINT16 is enough for FIFO depth. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo Cc: Michael D Kinney Cc: Liming Gao Cc: Ruiyu Ni --- MdePkg/MdePkg.dec | 4 1 file

Re: [edk2] [PATCH v2] OvmfPkg/PlatformPei: Fix VS2008 build breakage

On 03/19/16 01:19, David Woodhouse wrote: > Isn't that i18n.commitencoding=latin2 config on your part somewhat > gratuitous? The idea is that the tools are converting everything on the > way in and out, and that *only* affects the commit objects that are > actually encoded in the repository, right

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

Andrew, I agree that adding UNUSED to Base.h solves the issues that multiple packages may want to enable that warning and have a way to decorate implementation so the warning is not generated. I did mix two topics in this discussion. One is code review of UNUSED macro, and the other is an EDK II

[edk2] [PATCH V2 1/2] MdeModulePkg DxeCore: Check Start consistently in CoreConvertPagesEx

Current check: ASSERT (NumberOfPages); ASSERT ((Start & EFI_PAGE_MASK) == 0); ASSERT (End > Start) ; if (NumberOfPages == 0 || ((Start & EFI_PAGE_MASK) != 0) || (Start > (Start + NumberOfBytes))) { This patch is to update "(Start > (Start + NumberOfBytes))" to "(Start >= End)" to be consi

Re: [edk2] [PATCH] MdePkg: Add EFI_FIRMWARE_IMAGE_DESCRIPTOR V1 and V2 structure definition.

Tapan: Consumer can base on version value to know the structure size and date. We don't need to add old version structure definition. Thanks Liming From: Shah, Tapan [mailto:tapands...@hpe.com] Sent: Thursday, March 17, 2016 3:54 AM To: edk2-devel@lists.01.org; Kinney, Michael D ; Gao, Liming

Re: [edk2] Applying the patch 5811eea0fdb56187597e50b1282e7cfab4965a65 causes UEFI boot freeze (armv8 platform)

Hi Ard, Eugene, Thanks a lot for your help. You were absolutely right: I forgot to switch from CpuExceptionhandlerLibNull to ArmExceptionLib in my platform dsc file. Everything is OK now. Eugene, please let me know if you still want to do some testing on the platform. Thank you, Vladimir -O

Re: [edk2] EDK2 Staging Proposal 3rd draft, final?

On Fri, 2016-03-18 at 17:08 +0100, Laszlo Ersek wrote: > On 03/18/16 14:59, David Woodhouse wrote: > > Sometimes, stuff just broke and you just fix it up and move on. Let the > > people who *did* it work it out for themselves and that actually forms > > a *better* learning experience for them. > >

Re: [edk2] [PATCH] MdeModulePkg: Rescale ConSplitter Absolute Pointer.

The U64 mult/div fix seems good. Thanks for fixing it! Thanks, Derek -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Thursday, March 17, 2016 9:13 AM To: Laszlo Ersek Cc: Ni, Ruiyu ; Tian, Feng ; Lin, Derek (HPS UEFI Dev) ; edk2-devel@lists.01.org Subject: Re:

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

Andrew: DxeDebugPrintErrorLevelLib has Constructor. DxeHobLib has Constructor. If DebugLib also has Constructor, the circle of Constructor() will happen and cause build break. DxeDebugPrintErrorLevelLib instance increases the possibility of the circle Constructor(). To resolve it, we can updat

Re: [edk2] [RFC 1/3] MdePkg: Add PCD for UART default receive FIFO depth

Hi Ruiyu, I've changed the code and sent out v2 patches. Please help to review. Thanks. Heyi On 03/17/2016 10:29 AM, Ni, Ruiyu wrote: Heyi, I agree with the general idea of the patch to add a PCD for DefaultReceiveFifoDepth. I understand you choose UINT32 for the FIFO depth because the EFI_

Re: [edk2] [PATCH] BaseTools: use unsigned chars on ARM architectures

> On Mar 17, 2016, at 10:51 AM, Leif Lindholm wrote: > > Hi Andrew, > > On Thu, Mar 17, 2016 at 10:41:37AM -0700, Andrew Fish wrote: >> FYI, the char sign issue clang hit recently was due to mixing edk2 >> types with standard C type. The edk2 type system does not assume >> that char is signed o

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

On 2016/3/17 17:11, Laszlo Ersek wrote: Adding Ard On 03/17/16 08:28, Zeng, Star wrote: On 2016/3/17 15:16, Andrew Fish wrote: On Mar 17, 2016, at 12:10 AM, Gao, Liming wrote: Andrew: DxeDebugPrintErrorLevelLib has Constructor. DxeHobLib has Constructor. If DebugLib also has Constructor

[edk2] [PATCH v2] OvmfPkg/PlatformPei: Fix VS2008 build breakage

Commit 7b8fe6356 ("OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG / ECAM) on Q35") broke the VS2008 build, causing it to complain of "potentially uninitialized local variable 'PciExBarBase' used" at line 275. On this occasion it isn't actually wrong — the mHostBridgeDevId variable is global,

Re: [edk2] Problem with Author, Sign Off, and IP concerns

On Wed, 2016-03-16 at 12:15 +0100, Laszlo Ersek wrote: > My only request is that the "Author:" git metadata header be matched by > the first Signed-off-by tag. We use the Signed-off-by tag the same way as everyone else does, don't we? With reference to the "Developer's Certificate of Origin" as se

Re: [edk2] [PATCH v2] OvmfPkg/PlatformPei: Fix VS2008 build breakage

On Fri, 2016-03-18 at 17:53 +0100, Laszlo Ersek wrote: > > (1) The commit message uses at least one non-ASCII character, the EM > DASH (U+2014). Can you please replace it with a "--"? Yes, I know you > hate me for asking this. Please just write me off as stupid and replace > the character. No. Th

Re: [edk2] [PATCH v2] OvmfPkg/PlatformPei: Fix VS2008 build breakage

On 03/18/16 18:45, David Woodhouse wrote: > On Fri, 2016-03-18 at 17:53 +0100, Laszlo Ersek wrote: >> >> (1) The commit message uses at least one non-ASCII character, the EM >> DASH (U+2014). Can you please replace it with a "--"? Yes, I know you >> hate me for asking this. Please just write me off

[edk2] [PATCH 7/7] ArmPkg/ArmExceptionLib: reimplement register stack/unstack routines

This replaces the somewhat opaque preprocessor based stack/unstack macros with open coded ldp/stp sequences to preserve the interrupted context before handing over to the exception handler in C. This removes various arithmetic operations on the stack pointer, and reduces the exception return criti

Re: [edk2] [PATCH] PcAtChipsetPkg/PciHostBridgeDxe: Remove it since MdeModulePkg contains a new one.

On 03/18/16 04:02, Ni, Ruiyu wrote: > All, > > I would like to hear your concerns by the next weekend (Mar 26/27). > > If there is no concern, I will remove it on the Monday after that (Mar 28). > > > > And I think I can take Laszlo’s mail below as a r-b response. Can I? Please post the remo

Re: [edk2] [PATCH] ArmPkg/AArch64Mmu: use correct AP[] bits in ArmClearMemoryRegionReadOnly

On 17 March 2016 at 16:31, Leif Lindholm wrote: > On Thu, Mar 17, 2016 at 02:55:00PM +0100, Ard Biesheuvel wrote: >> The function ArmClearMemoryRegionReadOnly() was supposed to undo the >> effect of ArmSetMemoryRegionReadOnly(), but instead, it sets the permissions >> to EL0-no access, EL1-read-on

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

Adding Ard On 03/17/16 08:28, Zeng, Star wrote: > On 2016/3/17 15:16, Andrew Fish wrote: >> >>> On Mar 17, 2016, at 12:10 AM, Gao, Liming wrote: >>> >>> Andrew: >>> DxeDebugPrintErrorLevelLib has Constructor. DxeHobLib has >>> Constructor. If DebugLib also has Constructor, the circle of >>> Con

Re: [edk2] EDK2 Staging Proposal 3rd draft, final?

On 03/18/16 13:43, David Woodhouse wrote: > On Fri, 2016-03-18 at 13:30 +0100, Laszlo Ersek wrote: >> >> Our workflow should not be centered on github pull requests in any case, >> so I don't see the point in testing them out. > > Well, thanks for destroying the test I spent this morning setting

Re: [edk2] [patch] NetworkPkg:Fix Http boot download issue.

Hi, Lubo Since the Private->FilePathUri is extracted from the URI device path node in the FilePath, the (Private->FilePathUri != NULL) implied that the FilePath is not end device path node. So I thinke the whole change could be simplified to if ((UsingIpv6 != Private->UsingIpv6) ||

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

On 17 March 2016 at 10:11, Laszlo Ersek wrote: > Adding Ard > > On 03/17/16 08:28, Zeng, Star wrote: >> On 2016/3/17 15:16, Andrew Fish wrote: >>> On Mar 17, 2016, at 12:10 AM, Gao, Liming wrote: Andrew: DxeDebugPrintErrorLevelLib has Constructor. DxeHobLib has Construc

Re: [edk2] [PATCH] PcAtChipsetPkg/PciHostBridgeDxe: Remove it since MdeModulePkg contains a new one.

On 2016-03-17 23:13:46, Laszlo Ersek wrote: > On 03/18/16 04:02, Ni, Ruiyu wrote: > > All, > > > > I would like to hear your concerns by the next weekend (Mar 26/27). > > > > If there is no concern, I will remove it on the Monday after that (Mar 28). > > > > > > > > And I think I can take Las

[edk2] [PATCH] MdePkg: Add NORESTART flag to I2C header

From: Bartosz Szczepanek I2C_NORESTART_FLAG allows to continue transmission without repeated start operation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bartosz Szczepanek --- MdePkg/Include/Pi/PiI2c.h | 1 + 1 file changed, 1 insertion(+) diff --git a/MdePkg/Inclu

Re: [edk2] [PATCH v2 3/3] ArmPkg: Update CpuDxe to use CpuExceptionHandlerLib

Ard, > The patches look fine to me. I will proceed and apply the first two. > However, this third one needs to wait until all users of CpuDxe have > the correct resolution for CpuExceptionHandlerLib. I think this is > only ArmVirtPkg/ArmVirt.dsc.inc, but I'd like a nod from Leif before > pushing t

Re: [edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

Laszlo, Which kernel version are you using? Yes I indeed used 4.4.1 from ppa wily. I would more likely to assume 4.4.1 has a regression. Will try 4.4 tomorrow. Thanks a lot for your long mail. Thanks, Ray > 在 2016年3月16日，下午8:38，Laszlo Ersek 写道： > >> On 03/16/16 01:55, Ni, Ruiyu wrote: >> >> >

Re: [edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

On 03/16/16 14:47, Ni, Ruiyu wrote: > Laszlo, > Which kernel version are you using? Yes I indeed used 4.4.1 from ppa wily. > I would more likely to assume 4.4.1 has a regression. Will try 4.4 tomorrow. I am using a RHEL-7 kernel that is not publicly released yet. While I was working on SMM for OVM

Re: [edk2] EDK2 Staging Proposal 3rd draft, final?

On 03/18/16 12:21, David Woodhouse wrote: > On Thu, 2016-03-17 at 21:28 +, Kinney, Michael D wrote: >> >> Yes. Use of developer github forks is supported. I had summarized >> 3 development methods earlier in this thread. >> >> 1) PR emails send to edk2-devel. There is a Wiki page that detail

Re: [edk2] [PATCH v2] NetworkPkg:Fix Http boot download issue.

Yes, I not notice that, will correct when checked in. Thanks From: Fu, Siyuan Sent: Friday, March 18, 2016 4:29 PM To: Zhang, Lubo ; edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin Subject: RE: [edk2] [PATCH v2] NetworkPkg:Fix Http boot download issue. Lubo I think the AsciiStrCmp shoul

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

Andrew: First, I suggest to enhance BaseTools to report the detail information on the constructor circle. Next, we can add comments in DxeDebugPrintErrorLevelLib library instance to note it can't be used together with DxeHobLib and BaseDebugLibSerialPort instance until we have the complete sol

[edk2] [PATCH] MdeModulePkg PlatformVarCleanupLib: Locate VarCheck protocol when using

Do not locate VarCheck protocol in Constructor, then the gEdkiiVarCheckProtocolGuid could be removed from [Depex]. It will be more flexible for the library Consumer to work without VarCheck protocol installed, for example at recovery boot mode with EmuRuntimeDxe. The unused UefiLib is also been re

Re: [edk2] [PATCH] MdePkg: Add NORESTART flag to I2C header

I don't find I2C_FLAG_NORESTART definition in PI spec 1.4. Where is to get it? Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marcin Wojtas Sent: Wednesday, March 16, 2016 11:33 PM To: edk2-devel@lists.01.org Cc: ha...@marvell.com;

Re: [edk2] [PATCH] MdePkg: Add NORESTART flag to I2C header

Hi Liming, Thank you for the information, the flag will be handled within OpenPlatformPkg then. Best regards, Marcin 2016-03-17 14:49 GMT+01:00 Gao, Liming : > Bartosz: > > MdePkg definition conforms to UEFI/PI and Industry specification. If it is > not in spec, it will not be added into MdePk

Re: [edk2] signedness of CHAR8

On Thu, Mar 17, 2016 at 12:16:31PM +, Leif Lindholm wrote: > So, as further fallout from my -Weverything experiments, I've come > across this... > > Ia32 and X64 ProcessorBind.h (BaseTools and MdePkg) both define CHAR8 as > 'char'. > ARM and AArch64 both do the same. > > However, default 'ch

Re: [edk2] EDK2 Staging Proposal 3rd draft, final?

I could have sworn I'd responded to this last night, but it was late, and I see no evidence of such in my outbox or on the list. Apologies if I'm repeating myself... On Thu, 2016-03-17 at 00:15 +, Kinney, Michael D wrote: > Jordan asked a similar question about adding a 'staging' directory or

[edk2] [PATCH 2/2] Omap35xxPkg: move to ARM version of CpuExceptionHandlerLib

Change our resolution for the previously unused CpuExceptionHandlerLib from the null implementation to the newly added implementation specific to AARCH64 and ARM. This is needed since our CpuDxe will start using it in a subsequent patch. Contributed-under: TianoCore Contribution Agreement 1.0 Sign

Re: [edk2] [RFC 1/3] MdePkg: Add PCD for UART default receive FIFO depth

No. I don't think the UINT32 is for data alignment. Because EFI_SERIAL_IO_MODE isn't decorated by #pragma pack(1), it's naturally aligned. Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Thursday, March 17, 2016 3:13 PM To: Ni, Ruiyu ; edk2-devel

[edk2] [MdeModulePkg][RegularExpressionDxe] Does not link NOOPT for Xcode clang.

I can't compile RegularExpressionDxe NOOPT for Xcode clang as I get a linker failure on memset(). "_memset", referenced from: _onigenc_unicode_get_case_fold_codes_by_str in RegularExpressionDxe.lib(unicode.obj) It looks like this is the issue: diff --git a/MdeModulePkg/Universal/Regular

[edk2] [PATCH 6/7] ArmPkg/ArmExceptionLib: avoid indirect call if using vector table in place

If we are using the vector table in place, there is no need to make an indirect call to the common handler routine from the vector table entries, so just use a straight branch instruction in that case. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmP

Re: [edk2] [PATCH] BaseTools: use unsigned chars on ARM architectures

On 17 March 2016 at 14:22, Leif Lindholm wrote: > By default, the ARM architectures have unsigned chars, whereas the other > architectures supported by EDK2 by default have signed chars. > However, EDK2 uses -funsigned-chars on those architectures to change the > default behaviour. > > Unfortunate

Re: [edk2] signedness of CHAR8

On Thu, Mar 17, 2016 at 01:41:12PM +0100, Laszlo Ersek wrote: > On 03/17/16 13:34, Leif Lindholm wrote: > > On Thu, Mar 17, 2016 at 12:16:31PM +, Leif Lindholm wrote: > >> So, as further fallout from my -Weverything experiments, I've come > >> across this... > >> > >> Ia32 and X64 ProcessorBind

Re: [edk2] [RFC] MdePkg: add ARG_UNUSED notation to Base.h

> On Mar 16, 2016, at 6:54 AM, Laszlo Ersek wrote: > > On 03/14/16 16:38, Leif Lindholm wrote: >> To permit many existing platforms to build with -Wunused-parameter, on >> GCC and CLANG, the unused parameters need to be annotated as such. >> Existing regexp code already uses ARG_UNUSED for this,

[edk2] [PATCH] MdeModulePkg DiskIoDxe: Media status check not be done at DiskIo level

Found an issue that file system cannot be started on a DVD when doing the following process: Boot to shell with a DVD inside a SATA DVDROM. Eject the DVD and run "reconnect -r". Put the DVD inside again and run "reconnect -r". The cause is that after executing the second reconnect action, DiskIo

Re: [edk2] [PATCH] PcAtChipsetPkg/PciHostBridgeDxe: Remove it since MdeModulePkg contains a new one.

All, I would like to hear your concerns by the next weekend (Mar 26/27). If there is no concern, I will remove it on the Monday after that (Mar 28). And I think I can take Laszlo's mail below as a r-b response. Can I? Regards, Ray From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, Ma

Re: [edk2] [PATCH] BaseTools: use unsigned chars on ARM architectures

On Thu, Mar 17, 2016 at 02:09:56PM -0700, Andrew Fish wrote: > > > On Mar 17, 2016, at 10:51 AM, Leif Lindholm > > wrote: > > > > Hi Andrew, > > > > On Thu, Mar 17, 2016 at 10:41:37AM -0700, Andrew Fish wrote: > >> FYI, the char sign issue clang hit recently was due to mixing edk2 > >> types w

[edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

To permit many existing platforms to build with -Wunused-parameter, on GCC and CLANG, the unused parameters need to be annotated as such. Existing regexp code already uses ARG_UNUSED for this, but it is really needed across the codebase - so add a version called UNUSED in Base.h. Contributed-under

Re: [edk2] [Patch V3] OvmfPkg/LegacyRegion: Support legacy region manipulation of Q35

On 03/16/16 00:33, Jordan Justen wrote: > Regarding the subject, how about "PATCH v3" rather than "Patch V3"? > > Reviewed-by: Jordan Justen > > Pushed as db27e9f3d8f007bf26bcb8907ecab5b5f1fb8f24. Thanks guys, I skimmed it (found it in the git history already); it looks good. Nice work. Cheers

Re: [edk2] [RFC] MdePkg: add ARG_UNUSED notation to Base.h

> On Mar 16, 2016, at 7:02 PM, Gao, Liming wrote: > > Andrew: > If we enable -Wunused-parameter option for GCC and CLANG, it will bring the > big change to edk2 project. This patch is just to add ARG_UNUSED notation to > Base.h. It has no impact. So, I think this patch is fine. > Liming,

Re: [edk2] Software SMI STS bit is not set when writing port B2 in QEMU Q35

On 03/18/16 04:23, Ni, Ruiyu wrote: > Laszlo, > I downloaded the stable 4.4.6 and build it myself. > 1. enable KVM as a module in "make menuconfig" > 2. "make -j3" > 2. install the modules/kernel: "sudo make install_modules" and "sudo make > install" > 3. update the boot loader "sudo update-grub2"

[edk2] [PATCH] ArmPkg/AArch64Mmu: use correct AP[] bits in ArmClearMemoryRegionReadOnly

The function ArmClearMemoryRegionReadOnly() was supposed to undo the effect of ArmSetMemoryRegionReadOnly(), but instead, it sets the permissions to EL0-no access, EL1-read-only. Since the EL0 bit should be 1 to align with EL2/3 (where the bit is SBO), use TT_AP_RW_RW instead, which makes the entry

Re: [edk2] EDK2 Staging Repository 2nd Draft

> On 03/15/16 18:20, Kinney, Michael D wrote: > I don't object to pulling, if the submitter explicitly requests it, and > if we're making this option official now. Let's say "at the discretion of the person doing the merge" rather than writing down that it should need an explicit request. Over t

[edk2] [PATCH 4/7] ArmPkg/ArmExceptionLib: don't restore ESR and FAR upon exception return

ESR and FAR are populated by the hardware upon exception entry, and describe the exception, not the interrupted context. So there is no point in restoring their values before returning from the exception. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- A

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

> On Mar 17, 2016, at 2:34 PM, Kinney, Michael D > wrote: > > Andrew, > > I agree that adding UNUSED to Base.h solves the issues that multiple packages > may want to enable that warning and have a way to decorate implementation so > the warning is not generated. > > I did mix two topics in th

Re: [edk2] [PATCH v2] NetworkPkg:Fix Http boot download issue.

Lubo I think the AsciiStrCmp should be "!=" zero (not zero means not identical). > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhang Lubo > Sent: Friday, March 18, 2016 2:51 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Si

Re: [edk2] [PATCH] MdePkg: add UNUSED notation to Base.h

On 03/17/16 20:51, Laszlo Ersek wrote: > (adding Ard and Shumin because the below will tie in with another thread) > > On 03/17/16 19:05, Leif Lindholm wrote: > >> I must confess to no small amount of surprise that optionally adding >> the ability to tag an unused argument as unused is controvers

Re: [edk2] Has any one else had issues trying to use DxeDebugPrintErrorLevelLib? DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebugPrintErrorLevelLib/DxeDebugPrintErrorLevelLib.inf

> On Mar 17, 2016, at 5:15 AM, peter.kirme...@ts.fujitsu.com wrote: > > Hi all, > > from my point of view a library should use a constructor to initialize OWN > resources only. That means that there is no need for external resources at > this point. The library can use PeiService/SystemTable t

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemu: move to ARM version of CpuExceptionHandlerLib

On 16 March 2016 at 12:40, Laszlo Ersek wrote: > On 03/16/16 12:39, Laszlo Ersek wrote: >> On 03/16/16 12:24, Ard Biesheuvel wrote: >>> Change our resolution for the previously unused CpuExceptionHandlerLib >>> from the null implementation to the newly added implementation specific >>> to AARCH64

Re: [edk2] EDK2 Staging Proposal 3rd draft, final?

On Wed, 2016-03-16 at 22:05 +, Kinney, Michael D wrote: > > I responded to an earlier email: Ah, apologies — it wasn't clear this was intended as an answer to that question. This is one of those examples with the common email behaviour of placing the response below a carefully-selected citati

Re: [edk2] [PATCH 4/9] DuetPkg/PciBusNoEnumerationDxe: Skip disabled devices

Reviewed-by: Ruiyu Ni -Original Message- From: Bjorge, Erik C Sent: Friday, March 4, 2016 10:01 AM To: Leahy, Leroy P mailto:leroy.p.le...@intel.com>>; Ni, Ruiyu mailto:ruiyu...@intel.com>>; edk2-devel@lists.01.org Subject: RE: [PATCH 4/9] DuetPkg/Pci

Re: [edk2] [RFC] MdePkg: add ARG_UNUSED notation to Base.h

On 03/16/16 17:50, Andrew Fish wrote: > >> On Mar 16, 2016, at 6:54 AM, Laszlo Ersek wrote: >> >> On 03/14/16 16:38, Leif Lindholm wrote: >>> To permit many existing platforms to build with -Wunused-parameter, on >>> GCC and CLANG, the unused parameters need to be annotated as such. >>> Existing

[edk2] [PATCH 1/2] MdeModulePkg DxeCore: Check Start consistently in CoreConvertPagesEx

Current check: ASSERT (NumberOfPages); ASSERT ((Start & EFI_PAGE_MASK) == 0); ASSERT (End > Start) ; if (NumberOfPages == 0 || ((Start & EFI_PAGE_MASK) != 0) || (Start > (Start + NumberOfBytes))) { This patch is to update "(Start > (Start + NumberOfBytes))" to "(Start >= End)" to be consi

Re: [edk2] [Patch] MdePkg/Pci22.h: Fix a coding style issue

Reviewed-by: Qiu Shumin -Original Message- From: Ni, Ruiyu Sent: Friday, March 18, 2016 2:05 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Qiu, Shumin Subject: [Patch] MdePkg/Pci22.h: Fix a coding style issue Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu N

Re: [edk2] [RFC] MdePkg: add ARG_UNUSED notation to Base.h

Andrew: If we enable -Wunused-parameter option for GCC and CLANG, it will bring the big change to edk2 project. This patch is just to add ARG_UNUSED notation to Base.h. It has no impact. So, I think this patch is fine. Thanks Liming From: af...@apple.com [mailto:af...@apple.com] Sent: Thursday

Re: [edk2] [PATCH] ShellPkg: Modify the 'dh' Shell command to dump the Firmware Management Protocol Image Descriptor Information.

We need to split into 2 patches (a series), one for MdePkg and one for ShellPkg. Comments below inline. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Wednesday, March 16, 2016 8:55 AM > To: edk2-devel@lists.01.org > Cc: samer.el-haj-mahm...@hpe.com; Carsey,

[edk2] [PATCH 5/7] ArmPkg/ArmExceptionLib: make build time define visible to the compiler

The global gArmRelocateVectorTable is a build time constant, but due to its external linkage and lack of constness, the compiler does not see that. So turn it into a static boolean, and at the same time, make the function CopyExceptionHandlers() (which is only called if gArmRelocateVectorTable is s

[edk2] [PATCH v2 0/3] Adaptively set serial terminal polling rate

The serial terminal polling interval is now fixed by macro: #define KEYBOARD_TIMER_INTERVAL 20 // 0.02s However, this may cause fast input to be truncated on some platforms. For example, we have a serial console with below features: 1. Baud rate: 115200 2. FIFO depth of UART device:

Re: [edk2] EDK2 Staging Proposal 3rd draft, final?

David, Jordan asked a similar question about adding a 'staging' directory or 'staging' branches to the edk2 repo. If you look at the edk2 repo today, it has master and the supported UDK* branches. In the transition from SVN -> GIT, the old tags were removed and archived. The reason for sugges

  1   2   >