[edk2] [Patch v5 11/24] OvmfPkg/PlatformBootManagerLib: Do not launch Boot Manager Menu

MdeModulePkg/BDS doesn't launch UI (Boot Manager Menu) from platform side. The change removes the code which launches the UI but still set the boot timeout. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek

[edk2] [Patch v5 20/24] OvmfPkg/PlatformBootManagerLib: Add EnableQuietBoot & DisableQuietBoot

EnableQuietBoot and DisableQuietBoot are copied from IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConsole.c. Because these two functions are not in UefiBootManagerLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo

[edk2] [Patch v5 13/24] OvmfPkg/PlatformBootManagerLib: Remove unused local functions.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Reviewed-by: Laszlo Ersek --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 94 -- 1 file changed, 94

[edk2] [Patch v5 19/24] OvmfPkg/PlatformBootManagerLib: Remove unused vars and func prototypes

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- .../Library/PlatformBootManagerLib/BdsPlatform.h | 42 -- .../Library/PlatformBootManagerLib/PlatformData.c | 12 +-- 2

[edk2] [Patch v5 10/24] OvmfPkg/PlatformBootManagerLib: Init console vars in *BeforeConsole()

The major difference between IntelFrameworkModulePkg/BDS and MdeModulePkg/BDS is the latter connects the consoles in core code while the former connects in platform code. The change initializes the console variables in PlatformBootManagerBeforeConsole() and removes the console connection code. It

[edk2] [Patch v5 09/24] OvmfPkg/PlatformBootManagerLib: Use ConvertDevicePathToText()

The DevicePathToStr() function (in "IntelFrameworkModulePkg/Library/GenericBdsLib/DevicePath.c") is a simple wrapper around ConvertDevicePathToText(). DevicePathToStr() passes DisplayOnly=TRUE and AllowShortcuts=TRUE to ConvertDevicePathToText(), whereas in this patch, both parameters are flipped

[edk2] [Patch v5 22/24] OvmfPkg/PlatformBootManagerLib: Remove unused C structures definitions

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- .../Library/PlatformBootManagerLib/BdsPlatform.h | 47 -- 1 file changed, 47 deletions(-) diff --git

[edk2] [Patch v5 04/24] OvmfPkg/QemuNewBootOrderLib: Build with UefiBootManagerLib

NOTE: SetBootOrderFromQemu() interface is not changed. But when the old IntelFrameworkModulePkg/BDS is no longer used in OVMF and ArmVirtPkg, additional patch will be submitted to change this interface to remove parameter BootOptionList. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [Patch v5 21/24] OvmfPkg/PlatformBootManagerLib: Fix gcc-4.8 Ia32 build failure

The Width and Height assignment suppresses an invalid gcc-4.8 warning on Ia32. These warnings look unjustified to me. Namely, near the beginning of the function, there is a while(1) loop. In that loop, ConvertBmpToGopBlt() is called unconditionally. If the call fails, the rest of the loop body is

[edk2] [Patch v5 18/24] OvmfPkg/PlatformBootManagerLib: Remove unnecessary memory test

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 60 +- .../Library/PlatformBootManagerLib/BdsPlatform.h | 5 -- 2

[edk2] [Patch 1/2] NetworkPkg: Ignore BootFileName if it is overloaded.

Make sure "File" field is not overloaded to carry other DHCP options before use it in HTTP boot driver. Cc: Wu Jiaxin Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan ---

[edk2] [Patch 0/2] 0001-NetworkPkg-Ignore-BootFileName-if-it-is-overloaded

Fu Siyuan (2): NetworkPkg: Ignore BootFileName if it is overloaded. NetworkPkg: Ignore BootFileName if it is overloaded. NetworkPkg/HttpBootDxe/HttpBootDhcp4.c | 5 - NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 7 +-- 2 files changed, 9 insertions(+), 3 deletions(-) --

[edk2] [Patch v5 16/24] OvmfPkg/PlatformBootManagerLib: Remove PlatformBdsGetDriverOption()

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 30 -- .../Library/PlatformBootManagerLib/BdsPlatform.h | 6 - 2

[edk2] [Patch v5 12/24] OvmfPkg/PlatformBootManagerLib: Register boot options and hot keys

The patch registers "Enter" key as the continue key (hot key to skip the boot timeout wait), maps "F2" key to UI, and registers Shell boot option. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Cc:

[edk2] [Patch v5 14/24] OvmfPkg/PlatformBootManagerLib: port PlatformBdsConnectSequence to UefiBootManagerLib

The patch changes PlatformBdsConnectSequence() to use library API exposed from UefiBootManagerLib and removes the additional connect ALL action. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek ---

[edk2] [Patch v5 03/24] OvmfPkg: Duplicate QemuBootOrderLib to QemuNewBootOrderLib

QemuNewBootOrderLib will be changed to work with MdeModulePkg/BDS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- .../Library/QemuNewBootOrderLib/ExtraRootBusMap.c | 313

[edk2] [Patch v5 05/24] OvmfPkg: Duplicate PlatformBdsLib to PlatformBootManagerLib

It will be changed to build with MdeModulePkg/BDS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 1592

[edk2] [Patch v5 15/24] OvmfPkg/PlatformBootManagerLib: Use EfiBootManagerRefreshAllBootOption()

The patch uses EfiBootManagerRefreshAllBootOption() to collect all boot options and uses SetBootOrderFromQemu exposed by QemuNewBootOrderLib to adjust the boot option order. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo

[edk2] [Patch v5 02/24] OvmfPkg/PlatformPei: Add memory above 4GB as tested

Since PlatformBootManagerLib do not run memory test to convert untested memory to tested. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Tested-by: Laszlo Ersek Reviewed-by: Laszlo Ersek ---

[edk2] [Patch v5 01/24] MdeModulePkg/UefiBootManagerLib: Expose *GetLoadOptionBuffer() API

Expose EfiBootManagerGetLoadOptionBuffer() API. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- MdeModulePkg/Include/Library/UefiBootManagerLib.h | 23 +-

[edk2] [Patch v5 00/24] Use MdeModulePkg/BDS in OVMF platform

The patch serials creates a flag USE_OLD_BDS and by default the value of the flag is FALSE so that the new MdeModulePkg/BDS is used. User can define USE_OLD_BDS as TRUE to force to use IntelFrameworkModulePkg /BDS. https://github.com/niruiyu/edk2/tree/Ovmf_Bds Ruiyu Ni (24):

Re: [edk2] [PATCH] SecurityPkg: Reduce TPM debug verbosity

Samer: For Log in TcgCommLogEvent. I suggest to keep current DEBUG level because it gives message about running out of EventLog buffer. Others are good to me. Thanks & Best regards Chao Zhang -Original Message- From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com]

[edk2] [PATCH 15/19] IntelFspWrapperPkg/FspWrapperPlatformSecLib: Align PlatformSecLib defined in UefiCpuPkg.

Remove FspPlatformSecLib, and align FspWrapper Sec platform library to PlatformSecLib defined in UefiCpuPkg. Add Wrapper to indicate it for FspWrapper only. The FSP1.1 compatibility is NOT maintained. The new Intel platform will follow FSP2.0. The old platform can either use an old EDK branch,

[edk2] [PATCH 16/19] IntelFspWrapperPkg/FspWrapperSecCore: Remove FspWrapperSecCore.

Remove FspWrapperSecCore, and just use SecCore solution to UefiCpuPkg. The FSP1.1 compatibility is NOT maintained. The new Intel platform will follow FSP2.0. The old platform can either use an old EDK branch, or move FSP1.1 support to platform directory. Cc: Giri P Mudusuru

[edk2] [PATCH 18/19] IntelFspWrapperPkg/FspWrapperNotifyDxe: Update FspNotifyDxe to FspWrapperNotifyDxe.

Add Wrapper to indicate it for FspWrapper only. Add FSP2.0 EnumInitPhaseEndOfFirmware support. Cc: Giri P Mudusuru Cc: Maurice Ma Cc: Ravi P Rangarajan Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH 19/19] IntelFspWrapperPkg: Update DEC/DSC for FSP2.0.

Update FSP wrapper to follow: https://firmware.intel.com/sites/default/files/FSP_EAS_v2.0_Draft%20External.pdf Update API required by FSP2.0. Update component required by FSP2.0. The FSP1.1 compatibility is NOT maintained. The new Intel platform will follow FSP2.0. The old platform can either

[edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

Update FSP to follow: https://firmware.intel.com/sites/default/files/FSP_EAS_v2.0_Draft%20External.pdf Align to FSP2.0. Remove 1.1 support from FspInit. Split it into FspmWrapperPeim and FspsWrapperPeim, so they can build in different FV. The FSP1.1 compatibility is NOT maintained. The new

[edk2] [PATCH 12/19] IntelFspWrapperPkg/FspWrapperApiTestLib: Add ApiTestLib as hook.

Add a hook point after FSP API is invoked, so that platform has chance to do output validation. Add sample to check gFspBootLoaderTolumHobGuid. Add NULL instance. Cc: Giri P Mudusuru Cc: Maurice Ma Cc: Ravi P Rangarajan

[edk2] [PATCH 13/19] IntelFspWrapperPkg/FspWrapperHobProcessLib: Update FspHobProcessLib to FspWrapperHobProcessLib.

Add Wrapper to indicate it for FspWrapper only. Align API name to FSP2.0 spec. The FSP1.1 compatibility is NOT maintained. The new Intel platform will follow FSP2.0. The old platform can either use an old EDK branch, or move FSP1.1 support to platform directory. Cc: Giri P Mudusuru

[edk2] [PATCH 14/19] IntelFspWrapperPkg/FspWrapperPlatformLib: Update FspPlatformInfoLib to FspWrapperPlatformLib.

Add Wrapper to indicate it for FspWrapper only. Merge several APIs (GetBootMode, GetNvsBuffer, GetUpdRegionSize, GetBootLoaderTolumSize, UpdateFspUpdConfigs) into one UpdateFspmUpdData, because all parameter construcion is done in UpdateFspmUpdData(). Align API name to FSP2.0 spec. The FSP1.1

[edk2] [PATCH 09/19] IntelFspPkg/Tool: Update FSP tool for FSP2.0.

Update FSP to follow: https://firmware.intel.com/sites/default/files/FSP_EAS_v2.0_Draft%20External.pdf Update BSF handler to follow: https://firmware.intel.com/sites/default/files/BSF_1_0.pdf Update PatchFv tool to align with FSP2.0 to handle FSP-T, FSP-M, FSP-S. Update GenCfgOpt to follow

[edk2] [PATCH 11/19] IntelFspWrapperPkg/FspWrapperApiLib: Update FspApiLib to FspWrapperApiLib.

Add Wrapper to indicate it for FspWrapper only. Cc: Giri P Mudusuru Cc: Maurice Ma Cc: Ravi P Rangarajan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao

[edk2] [PATCH 08/19] IntelFspPkg: Update DEC/DSC for FSP2.0.

Update FSP to follow: https://firmware.intel.com/sites/default/files/FSP_EAS_v2.0_Draft%20External.pdf Add API required by FSP2.0. Add component required by FSP2.0. The FSP1.1 compatibility is NOT maintained. The new Intel platform will follow FSP2.0. The old platform can either use an old EDK

[edk2] [PATCH 05/19] IntelFspPkg/FspSecPlatformLib: Update FSP SecPlatform lib for FSP2.0.

Update FSP to follow: https://firmware.intel.com/sites/default/files/FSP_EAS_v2.0_Draft%20External.pdf Clean update API definition to align with FSP2.0. Clean up Null library instance. Cc: Giri P Mudusuru Cc: Maurice Ma Cc: Ravi P Rangarajan

[edk2] [PATCH 07/19] IntelFspPkg/FspNotifyPhase: Separate FSP NotifyPhase from DxeIpl to new module.

Current FspDxeIpl has lot of non-FSP related content, which is copied from normal DxeIpl from MdeModulePkg. This new design is just to reuse common code in normal DxeIpl, (like DecompressPpi, SectionExtractionPpi), and separate FSP notification logic to a new module - FspNotifyPhase PEIM. Cc:

[edk2] [PATCH 06/19] IntelFspPkg/FspSecCore: Update FSP SecCore for FSP2.0.

Update FSP to follow: https://firmware.intel.com/sites/default/files/FSP_EAS_v2.0_Draft%20External.pdf Separate SecCore to SecCoreT, SecCoreM and SecCoreS for FSP-T, FSP-M, and FSP-S. Add NASM support. The FSP1.1 compatibility is NOT maintained. The new Intel platform will follow FSP2.0. The

[edk2] [PATCH 03/19] IntelFspPkg-FspCommonLib: Update FSP common lib for FSP2.0.

Update FSP to follow: https://firmware.intel.com/sites/default/files/FSP_EAS_v2.0_Draft%20External.pdf Add more API to get FSP2.0 information - FspInfoHeader, ApiIndex, StatusCode, CarBase, CarSize. Remove FSP1.1 support - ContinuationFunc. The FSP1.1 compatibility is NOT maintained. The new

[edk2] [PATCH 02/19] IntelFspPkg: Update FSP private header file used by FSP2.0 implementation.

Add FspStatusCode to report FSP progress. Add FspDataTable to produce FSP2.0 component information. Update GlobalData to align with FSP2.0. Update MeasureId to use full name instead of abbreviate. Cc: Giri P Mudusuru Cc: Maurice Ma Cc: Ravi P

[edk2] [PATCH 04/19] IntelFspPkg/FspPlatformLib: Update FSP platform lib for FSP2.0.

Update FSP to follow: https://firmware.intel.com/sites/default/files/FSP_EAS_v2.0_Draft%20External.pdf Add FspGetResourceDescriptorByOwner/FspMemoryInitDone/FspTempRamExitDone API Get/Set FSP configuration data according to FSP2.0 API. Add EnumInitPhaseEndOfFirmware support. Add report status

[edk2] [PATCH 01/19] IntelFspPkg: Update FSP header file to follow FSP2.0 spec.

Update FSP header file to follow: https://firmware.intel.com/sites/default/files/FSP_EAS_v2.0_Draft%20External.pdf The FSP1.1 compatibility is NOT maintained. The new Intel platform follows FSP2.0. The old platform can either use an old UDK branch, or move FSP1.1 support to platform directory.

[edk2] [PATCH 00/19] Add FSP2.0 support.

This series of patch is to support FSP2.0 specification at https://firmware.intel.com/sites/default/files/FSP_EAS_v2.0_Draft%20External.pdf Some major updates include: 1) One FSP binary is separated to multiple components: FSP-T, FSP-M, FSP-S, and optional FSP-O. Each component has its own

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Pushed at 69af847603ca1f6439031c4e1fee844fdb06ca6f and 0cd1e699e5f76b3323b5881932af8a62bc5edf2a. Thanks, Star -Original Message- From: Carsey, Jaben Sent: Monday, May 2, 2016 11:33 PM To: Zeng, Star ; Cinnamon Shia ; edk2-devel@lists.01.org

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: Install menu without device dependency.

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Dong, Eric Sent: Friday, April 29, 2016 2:07 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [Patch] SecurityPkg OpalPasswordDxe: Install menu without device dependency.

Re: [edk2] [Patch v4 04/23] OvmfPkg/QemuNewBootOrderLib: Build with UefiBootManagerLib

Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Monday, May 2, 2016 6:25 PM >To: Ni, Ruiyu ; edk2-de...@ml01.01.org >Cc: Justen, Jordan L >Subject: Re: [edk2] [Patch v4 04/23]

[edk2] [Patch 0/2] Do not use hard coded TTL/ToS in PXE driver.

EFI_PXE_BASE_CODE_PROTOCOL has interface to set the TTL and ToS value, but not used by the UdpWrite() interface. The code always use a hard coded 16 for the TTL and 0 for ToS. This patch update the UpdWrite() to use the TTL and ToS which have been set by the SetParameters(). Fu Siyuan (2):

[edk2] [Patch 1/2] NetworkPkg: Do not use hard coded TTL/ToS in PXE driver.

EFI_PXE_BASE_CODE_PROTOCOL has interface to set the TTL and ToS value, but not used by the UdpWrite() interface. The code always use a hard coded 16 for the TTL and 0 for ToS. This patch update the UpdWrite() to use the TTL and ToS which have been set by the SetParameters(). Cc: Wu Jiaxin

[edk2] [Patch 2/2] MdeModulePkg: Do not use hard coded TTL/ToS in PXE driver.

EFI_PXE_BASE_CODE_PROTOCOL has interface to set the TTL and ToS value, but not used by the UdpWrite() interface. The code always use a hard coded 16 for the TTL and 0 for ToS. This patch update the UpdWrite() to use the TTL and ToS which have been set by the SetParameters(). Cc: Wu Jiaxin

Re: [edk2] [Patch v4 00/23] Use MdeModulePkg/BDS in OVMF platform

Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, May 3, 2016 1:19 AM >To: Ni, Ruiyu ; edk2-de...@ml01.01.org >Subject: Re: [edk2] [Patch v4 00/23] Use MdeModulePkg/BDS in OVMF platform > >On 04/29/16 09:00, Ruiyu Ni

Re: [edk2] [staging/HTTPS-TLS][PATCH] CryptoPkg: Fix ssl build error.

This looks good to me. Reviewed-by: Qin Long Best Regards & Thanks LONG, Qin > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, May 03, 2016 8:43 AM > To: Wu, Jiaxin; edk2-devel@lists.01.org > Cc: Samer El-Haj-Mahmoud; Long, Qin > Subject: RE: [edk2]

Re: [edk2] [staging/HTTPS-TLS][PATCH] CryptoPkg: Fix ssl build error.

Samer and Qin, Please help to review this patch. Thanks. Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Friday, April 29, 2016 9:31 AM > To: edk2-devel@lists.01.org > Cc: Samer El-Haj-Mahmoud ;

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Fix wrong HII behavior for more than 8 RAM disks

On 4/20/2016 5:10 AM, Laszlo Ersek wrote: On 04/20/16 07:57, Hao Wu wrote: The RamDiskDxe driver originally uses a variable-length HII varstore to retrieve the HII checkbox status of each registered RAM disk. could you please test this patch, for ?

[edk2] [PATCH] CorebootPayloadPkg: Remove trailing white space

Remove trailing white space from existing .dsc and .fdf files. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy --- CorebootPayloadPkg/CorebootPayloadPkg.fdf| 35 --- CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc| 117

Re: [edk2] [Patch v4 00/23] Use MdeModulePkg/BDS in OVMF platform

On 04/29/16 09:00, Ruiyu Ni wrote: > The patch serials creates a flag USE_OLD_BDS and by default the value > of the flag is FALSE so that the new MdeModulePkg/BDS is used. > User can define USE_OLD_BDS as TRUE to force to use IntelFrameworkModulePkg > /BDS. > > The v3 adopts comments for v1 and

Re: [edk2] [Patch v4 20/23] OvmfPkg/PlatformBootManagerLib: Add EnableQuietBoot & DisableQuietBoot

On 05/02/16 17:09, Laszlo Ersek wrote: > On 04/29/16 09:01, Ruiyu Ni wrote: >> EnableQuietBoot and DisableQuietBoot are copied from >> IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConsole.c. >> Because these two functions are not in UefiBootManagerLib. >> >> Contributed-under: TianoCore

Re: [edk2] [Patch v4 23/23] OvmfPkg/OvmfPkgIa32X64.dsc: Move PcdShellFile to [PcdsFixedAtBuild.X64]

On 04/29/16 09:01, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Laszlo Ersek > --- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [edk2] [Patch v4 22/23] OvmfPkg: Use MdeModulePkg/BDS

On 05/02/16 17:51, Laszlo Ersek wrote: > On 04/29/16 09:01, Ruiyu Ni wrote: >> By default the new MdeModulePkg/BDS is used. >> If USE_OLD_BDS is defined to TRUE, IntelFrameworkModulePkg/BDS >> is used. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ruiyu Ni

Re: [edk2] [Patch v4 22/23] OvmfPkg: Use MdeModulePkg/BDS

On 04/29/16 09:01, Ruiyu Ni wrote: > By default the new MdeModulePkg/BDS is used. > If USE_OLD_BDS is defined to TRUE, IntelFrameworkModulePkg/BDS > is used. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Jordan Justen

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Reviewed-by: Jaben Carsey > -Original Message- > From: Zeng, Star > Sent: Monday, May 02, 2016 1:25 AM > To: Cinnamon Shia ; edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Carsey, Jaben > ;

Re: [edk2] [Patch v4 20/23] OvmfPkg/PlatformBootManagerLib: Add EnableQuietBoot & DisableQuietBoot

On 04/29/16 09:01, Ruiyu Ni wrote: > EnableQuietBoot and DisableQuietBoot are copied from > IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConsole.c. > Because these two functions are not in UefiBootManagerLib. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu

Re: [edk2] [Patch v4 19/23] OvmfPkg/PlatformBootManagerLib: Remove unused vars and func prototypes

On 04/29/16 09:01, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Jordan Justen > Cc: Laszlo Ersek > --- > .../Library/PlatformBootManagerLib/BdsPlatform.h | 42 >

Re: [edk2] [PATCH] PerformancePkg Dp_App: Delete InitCumulativeData()

Reviewed-by: Jaben Carsey > -Original Message- > From: Shia, Cinnamon [mailto:cinnamon.s...@hpe.com] > Sent: Monday, May 02, 2016 2:23 AM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Gao, Liming >

Re: [edk2] [PATCH] ShellPkg UefiDpLib: Delete one comment introduced by 196ccda08fc4

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shia, Cinnamon > Sent: Monday, May 02, 2016 2:23 AM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Carsey, Jaben

Re: [edk2] [Patch v4 12/23] OvmfPkg/PlatformBootManagerLib: Register boot options and hot keys

On 04/29/16 09:00, Ruiyu Ni wrote: > The patch registers "Enter" key as the continue key (hot key to skip > the boot timeout wait), maps "F2" key to UI, and registers Shell > boot option. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni >

Re: [edk2] [Patch v4 10/23] OvmfPkg/PlatformBootManagerLib: Init console vars in *BeforeConsole()

On 04/29/16 09:00, Ruiyu Ni wrote: > The major difference between IntelFrameworkModulePkg/BDS and > MdeModulePkg/BDS is the latter connects the consoles in core > code while the former connects in platform code. > The change initializes the console variables in > PlatformBootManagerBeforeConsole()

Re: [edk2] [Patch v4 09/23] OvmfPkg/PlatformBootManagerLib: Use ConvertDevicePathToText()

On 04/29/16 09:00, Ruiyu Ni wrote: > The DevicePathToStr() function (in > "IntelFrameworkModulePkg/Library/GenericBdsLib/DevicePath.c") is a > simple wrapper around ConvertDevicePathToText(). > > DevicePathToStr() passes DisplayOnly=TRUE and AllowShortcuts=TRUE to > ConvertDevicePathToText(),

Re: [edk2] [Patch v4 06/23] OvmfPkg/PlatformBootManagerLib: Follow PlatformBootManagerLib interfaces

On 04/29/16 09:00, Ruiyu Ni wrote: > Change the function name to follow new library class > PlatformBootManagerLib interfaces. > > NOTE: There is no progress bar during BDS timeout waiting. > In order to show the progress bar, PlatformBootManagerWaitCallback () > needs to change to draw it. > >

Re: [edk2] [Patch v4 05/23] OvmfPkg: Duplicate PlatformBdsLib to PlatformBootManagerLib

On 04/29/16 09:00, Ruiyu Ni wrote: > It will be changed to build with MdeModulePkg/BDS. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Jordan Justen > Cc: Laszlo Ersek > --- >

Re: [edk2] [Patch v4 04/23] OvmfPkg/QemuNewBootOrderLib: Build with UefiBootManagerLib

Hi Ray, My v3 review for this patch is here: http://news.gmane.org/find-root.php?message_id=%3c571f82d8.7010...@redhat.com%3E * You didn't answer my question in (2) -- can you please answer it now? (The question was if EFI_BOOT_MANAGER_LOAD_OPTION.OptionNumber corresponds to the number of the

Re: [edk2] [Patch v4 03/23] OvmfPkg: Duplicate QemuBootOrderLib to QemuNewBootOrderLib

On 04/29/16 09:00, Ruiyu Ni wrote: > QemuNewBootOrderLib will be changed to work with MdeModulePkg/BDS. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Jordan Justen > Cc: Laszlo Ersek

Re: [edk2] [PATCH] PerformancePkg Dp_App: Delete InitCumulativeData()

Thanks for fixing it. Reviewed-by: Cinnamon Shia -Original Message- From: Star Zeng [mailto:star.z...@intel.com] Sent: Monday, May 2, 2016 4:51 PM To: edk2-devel@lists.01.org Cc: Shia, Cinnamon ; Jaben Carsey ;

Re: [edk2] [PATCH] ShellPkg UefiDpLib: Delete one comment introduced by 196ccda08fc4

Thanks for fixing it. Reviewed-by: Cinnamon Shia -Original Message- From: Star Zeng [mailto:star.z...@intel.com] Sent: Monday, May 2, 2016 4:52 PM To: edk2-devel@lists.01.org Cc: Shia, Cinnamon ; Jaben Carsey ;

[edk2] [PATCH] ShellPkg UefiDpLib: Delete one comment introduced by 196ccda08fc4

Cc: Cinnamon Shia Cc: Jaben Carsey Cc: Shumin Qiu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng ---

[edk2] [PATCH] PerformancePkg Dp_App: Delete InitCumulativeData()

InitCumulativeData is introduced by d28f77df0f51f84b0af79f09abe2c27b1f1aaa69, it is needed by ShellPkg UefiDpLib, but not needed by PerformancePkg Dp_App. This patch is to delete it. Cc: Cinnamon Shia Cc: Jaben Carsey Cc: Liming Gao

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Reviewed-by: Star Zeng to series. Thanks, Star -Original Message- From: Cinnamon Shia [mailto:cinnamon.s...@hpe.com] Sent: Monday, May 2, 2016 12:34 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin ; Zeng, Star ; Carsey,