Re: [edk2] [Patch v2 07/40] UefiCpuPkg/MpInitLib: Add AsmRellocateApLoop() assembly code

Reviewed-by: Giri P Mudusuru Fix typo Rellocate to Relocate Thanks, -Giri > -Original Message- > From: Fan, Jeff > Sent: Thursday, July 21, 2016 8:14 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Tian, Feng >

Re: [edk2] [Patch v2 06/40] UefiCpuPkg/MpInitLib: Add AP assembly code and MP_CPU_EXCHANGE_INFO

Reviewed-by: Giri P Mudusuru 1) fix typo NumApsExecutingLoction to NumApsExecutingLocation 2) add space after ; and before comment lines 172 & 173 in MpFuncs.nasm Thanks, -Giri > -Original Message- > From: Fan, Jeff > Sent: Thursday, July 21, 2016 8:14 PM >

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

Hi, Haojian The vendor need to have an override or develop a brand new one if their SD/MMC HCs don't follow SD/MMC specs. EDKII core drivers follow standard spec. Thanks Feng -Original Message- From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org] Sent: Friday, July 22, 2016

Re: [edk2] [Patch v2 05/40] UefiCpuPkg/MpInitLib: Add two instances PeiMpInitLib and DxeMpInitLib

Reviewed-by: Giri P Mudusuru 1) Change MpInitLibSwitchBsp to MpInitLibSwitchBSP (BSP caps to match the PI spec and consistent with other functions) Thanks, -Giri > -Original Message- > From: Fan, Jeff > Sent: Thursday, July 21, 2016 8:14 PM > To:

Re: [edk2] [Patch v2 04/40] UefiCpuPkg/MpInitLib: Add MP Initialize library class definition

Reviewed-by: Giri P Mudusuru 1) Add space before ( in line #65 MpInitLibInitialize( 2) Change MpInitLibSwitchBsp to MpInitLibSwitchBSP (BSP caps to match the PI spec and consistent with other functions) Thanks, -Giri > -Original Message- > From: Fan, Jeff >

Re: [edk2] [Patch v2 03/40] UefiCpuPkg/CpuS3DataDxe: Move StartupVector allocation to EndOfDxe()

Reviewed-by: Giri P Mudusuru > -Original Message- > From: Fan, Jeff > Sent: Thursday, July 21, 2016 8:14 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Tian, Feng > ; Mudusuru, Giri P

Re: [edk2] [Patch v2 02/40] UefiCpuPkg/MpInitLib: Add microcode definitions defined in IA32 SDM

Few comments 1) Please update the SDM reference to the latest version from June. 2) Add comment for Microcode date CPU_MICROCODE_DATE that it is in BCD format 3) use /** **/ block comments for multiple line comments 4) change ProcessorChecksum to Checksum in CPU_MICROCODE_EXTENDED_TABLE to align

Re: [edk2] [PATCH v3] [BaseTools/Scripts]: Preserve hii section in GCC binaries

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Thomas Palmer > Sent: Friday, July 22, 2016 10:57 AM > To: edk2-devel@lists.01.org > Cc: af...@apple.com; Gao, Liming ; >

Re: [edk2] [Patch v2 01/40] UefiCpuPkg/LocalApic.h: Remove duplicated/conflicted definitions

Reviewed-by: Giri P Mudusuru > -Original Message- > From: Fan, Jeff > Sent: Thursday, July 21, 2016 8:14 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Tian, Feng > ; Mudusuru, Giri P

Re: [edk2] [PATCH 0/5] Additional fixes for the assertion removal work

For patch 5, please also update the declaration of function LoadPciRomConnectAllDriversToAllControllers() in LoadPciRom.c. Otherwise, GCC build will fail. With that change, series Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel

[edk2] [Patch v2 40/40] UefiCpuPkg/CpuDxe: Remove un-used files and functions.

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 37/40] UefiCpuPkg/CpuMpPei: Remove unused files and codes

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 39/40] UefiCpuPkg/CpuDxe: Consume MpInitLib to produce CPU MP Protocol services

Consume MP Initialize library to produce CPU MP Protocol services to simply the code. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution

[edk2] [Patch v2 38/40] UefiCpuPkg/CpuMpPei: Delete PeiMpServices.c and PeiMpServices.h

Move the code in PeiMpServices.c & PeiMpServices.h to CpuMpPei.c & CpuMpPei.h. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution

[edk2] [Patch v2 36/40] UefiCpuPkg/CpuMpPei: Consume MpInitLib to produce CPU MP PPI services

Consume MP initialize library to produce CPU MP PPI, it could simply the code. Add STATIC for some internal functions to avoid build issue with the same functions name in PeiMpInit instance. They will be removed by the next patch. Cc: Michael Kinney Cc: Feng Tian

[edk2] [Patch v2 33/40] UefiCpuPkg/MpInitLib: Place APs in safe loop before hand-off to OS

Register Exit Boot Service callback function MpInitExitBootServicesCallback() to place AP one safe loop before hand-off to OS. Allocated one reserved memory and copy the AsmRellocateApLoop() code into it. It could avoid the CPU Dxe driver (located in Boot Service data range) crashed after Exit

[edk2] [Patch v2 32/40] UefiCpuPkg/MpInitLib: Implementation of MpInitLibStartupAllAPs()

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 25/40] UefiCpuPkg/MpInitLib: Implementation of MpInitLibGetNumberOfProcessors()

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 26/40] UefiCpuPkg/MpInitLib: Implementation of MpInitLibGetProcessorInfo()

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 27/40] UefiCpuPkg/MpInitLib: Implementation of MpInitLibWhoAmI()

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 35/40] QuarkPlatformPkg: Add MpInitLib reference in DSC files.

This update is for CpuDxe consuming MP Initialize library. Cc: Michael Kinney Cc: Feng Tian Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 34/40] OvmfPkg: Add MpInitLib reference in DSC files.

This update is for CpuMpPei consuming MP Initialize library. Cc: Michael Kinney Cc: Feng Tian Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [Patch v2 13/40] UefiCpuPkg/MpInitLib: Add MicrocodeDetect() and load microcode on BSP

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 21/40] UefiCpuPkg/MpInitLib: Send INIT-SIPI-SIPI to get processor count

CollectProcessorCount() will send the 1st INIT-SIPI-SIPI to get processor count in system. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore

[edk2] [Patch v2 22/40] UefiCpuPkg/MpInitLib: Enable x2APIC mode on BSP/APs

If x2APIC flag is set, enable x2APIC mode on all APs and BSP. Before we wakeup APs to enable x2APIC mode, we should wait all APs have finished initialization. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc:

[edk2] [Patch v2 24/40] UefiCpuPkg/MpInitLib: Skip collect processor count if GUIDed HOB exist

If GUIDed HOB mCpuInitMpLibHobGuid exists, we could get the processor count and processor APICID and Initial APICID from CPU_INFO_IN_HOB. We needn't to delay for broadcast INIT-SIPI-SIPI results and could improve performance. Cc: Michael Kinney Cc: Feng Tian

[edk2] [Patch v2 23/40] UefiCpuPkg/MpInitLib: Sort processor by ascending order of APIC ID

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 19/40] UefiCpuPkg/MpInitLib: Fill MP_CPU_EXCHANGE_INFO fields

FillExchangeInfoData() is used to fill MP_CPU_EXCHANGE_INFO date exchanged between C code and assembly code of AP reset vector. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek

[edk2] [Patch v2 29/40] UefiCpuPkg/MpInitLib: Implementation of MpInitLibEnableDisableAP()

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 28/40] UefiCpuPkg/MpInitLib: Implementation of MpInitLibSwitchBsp()

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 30/40] UefiCpuPkg/MpInitLib: Check APs Status and update APs status

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 17/40] UefiCpuPkg/MpInitLib: Allocate AP reset vector buffer under 1MB

In PeiMpInitLib, searching unallocated memory under in EFI_HOB_TYPE_RESOURCE_DESCRIPTOR hobs to find the memory under 1MB for AP reset vector. After End of PEI event triggered, we need to restore original the buffer contents to avoid crash the OS on S3 boot. In DxeMpInitLib, allocate the memory

[edk2] [Patch v2 20/40] UefiCpuPkg/MpInitLib: Add WakeUpAP()

WakeUpAP() is used to wakeup APs per current ApLoopMode and make sure APs wake up successfully. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore

[edk2] [Patch v2 14/40] UefiCpuPkg/MpInitLib: Save CPU MP Data pointer

In PeiMpInitLib, save CPU MP Data pointer into one local Guided HOB. In DxeMpInitLib, save CPU MP Data pointer into one global variable. Add helper functions GetCpuMpData()/SaveCpuMpData(). Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru

[edk2] [Patch v2 16/40] UefiCpuPkg/MpInitLib: Register one period event to check APs status

In DxeMpInitLib, register one period event callback function CheckAPsStatus() used to check AP Status. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under:

[edk2] [Patch v2 18/40] UefiCpuPkg/MpInitLib: Add ApCFunction() executed by assembly code

ApCFunction() is the first C function executed from AP reset vector. When APs waken up at the first time, it will sync BSP's MTRR setting and load microcode on APs and collect APs' BIST information. When AP tasked finished, it will place APs it one loop specified by ApLoopMode. Cc: Michael

[edk2] [Patch v2 15/40] UefiCpuPkg/MpInitLib: Register one End of PEI callback function

In PeiMpInitLib, register End of PEI callback function CpuMpEndOfPeiCallback(). Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution

[edk2] [Patch v2 12/40] UefiCpuPkg/MpInitLib: Add CPU_VOLATILE_REGISTERS & worker functions

Add CPU_VOLATILE_REGISTERS definitions for CRx and DRx required to be restored after APs received INIT IPI. Add worker functions SaveVolatileRegisters()/RestoreVolatileRegisters() used to save/restore CRx and DRx. It also check if Debugging Extensions supported or not. Cc: Michael Kinney

[edk2] [Patch v2 06/40] UefiCpuPkg/MpInitLib: Add AP assembly code and MP_CPU_EXCHANGE_INFO

Add assembly code for AP reset vector and the definition of MP_CPU_EXCHANGE_INFO that are used to exchange the data between C code and assembly code when AP wake up. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru

[edk2] [Patch v2 08/40] UefiCpuPkg/MpInitLib: Add AsmGetAddressMap() assembly code

Add AsmGetAddressMap() function to get assembly functions' entry addresses and the sizes. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore

[edk2] [Patch v2 10/40] UefiCpuPkg/MpInitLib: Allocate and initialize memory of MP Data buffer

Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch v2 02/40] UefiCpuPkg/MpInitLib: Add microcode definitions defined in IA32 SDM

Add microcode definitions defined in Intel(R) 64 and IA-32 Architectures Software Developer's Manual Volume 3A, Section 9.11. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek

[edk2] [Patch v2 05/40] UefiCpuPkg/MpInitLib: Add two instances PeiMpInitLib and DxeMpInitLib

Add two MP Initialize Library instances PeiMpInitLib.inf and DxeMpInitLib.inf with NULL implementation. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under:

[edk2] [Patch v2 07/40] UefiCpuPkg/MpInitLib: Add AsmRellocateApLoop() assembly code

AsmRellocateApLoop() is used to place APs into MWAIT-loop if MonitorMwait feature is supported before hand-off to OS, or place APs into HLT-loop if MonitorMwait feature is not supported. If the current mode is long mode, we will switch APs to protected mode before placing APs in MWAIT-loop or

[edk2] [Patch v2 11/40] UefiCpuPkg/MpInitLib: Initialize CPU_AP_DATA for CPU APs

Initialize CPU_AP_DATA for CPU APs and add GetApState()/SetApState() helper functions to get/set AP state. Cc: Michael Kinney Cc: Feng Tian Cc: Giri P Mudusuru Cc: Laszlo Ersek Contributed-under:

[edk2] [Patch v2 01/40] UefiCpuPkg/LocalApic.h: Remove duplicated/conflicted definitions

#define MSR_IA32_APIC_BASE_ADDRESS is duplicated with #define MSR_IA32_APIC_BASE defined in UefiCpuPkg/Include/Register/ArchitecturalMsr.h, so we could remove it and update the modules to use MSR_IA32_APIC_BASE from ArchitecturalMsr.h. Structure MSR_IA32_APIC_BASE conflicts with #define

[edk2] [Patch v2 00/40] MP Initialize Library

We add MP Initialize Library defined in UefiCpuPkg/Include/Library/MpInitLib.h. It will provide basic functionalities of MP services and could be consumed by CPU MP PEI and CPU MP DXE to produce CPU MP PPI and CPU MP Protocol. Then most of code could be shared between PEI and DXE modules.

[edk2] [PATCH v3] [BaseTools/Scripts]: Preserve hii section in GCC binaries

According to UEFI spec: Once an image is loaded, LoadImage() installs EFI_HII_PACKAGE_LIST_PROTOCOL on the handle if the image contains a custom PE/COFF resource with the type 'HII'. The protocol's interface pointer points to the HII package list which is contained in the resource's data. This is

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

Hi Feng, I have to say that lots of SD controllers are not compatible to SDHC, too. Just look at $Linux/drivers/mmc/host. And too many vendors are using Designware eMMC/SD controller IP, like Samsung, ST, Hisilicon, ZTE, Rockchip, Altera, and so on. If the eMMC/SD stack only supports SDHC,

[edk2] [PATCH 4/5] ShellPkg/If: Fix issue to pass static code checker

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey Cc: Hao A Wu --- ShellPkg/Library/UefiShellLevel1CommandsLib/If.c | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2] [PATCH 5/5] ShellPkg/LoadPciRom: Fix the ConnectAll() implementation

Old implementation depends on UefiHandleParsingLib and uses incorrect Index to get handle type. The simplest ConnectAll() implementation can be just to locate all handles and call BS.ConnectController() for each of them recursively. BS.ConnectController() does nothing to the image handle. Such

[edk2] [PATCH 2/5] ShellPkg: Fix a potential NULL pointer deference issue

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey Cc: Hao A Wu --- ShellPkg/Application/Shell/ShellProtocol.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[edk2] [PATCH 0/5] Additional fixes for the assertion removal work

The assertion removal patch introduces 5 bugs and they are found by the static code checker. One of them (1/5) is a critical bug that incorrectly uses "!=" in a NULL pointer check but should use "==". Ruiyu Ni (5): ShellPkg/DrvDiag: Fix a critical typo bug ShellPkg: Fix a potential NULL

[edk2] [PATCH 3/5] ShellPkg/UefiHandleParsingLib: Fix issue to pass static code checker

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey Cc: Hao A Wu --- .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 13 +++-- 1 file changed, 11 insertions(+), 2

[edk2] [PATCH 1/5] ShellPkg/DrvDiag: Fix a critical typo bug

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey Cc: Hao A Wu --- ShellPkg/Library/UefiShellDriver1CommandsLib/DrvDiag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [edk2] [PATCH] Fix IPv6 HTTPClient vendor class data

Thanks for the contribution:). Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: Zhang, Lubo > Sent: Thursday, July 21, 2016 4:50 PM > To: Michael Chang ; Wu, Jiaxin > Cc: edk2-devel@lists.01.org >

Re: [edk2] [PATCH] SecurityPkg: AuthVariableLib: Revert UserPhysicalPresent feature from AuthVariableLib

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zhang, Chao B > Sent: Thursday, July 21, 2016 3:20 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zhang, Chao B > > Subject: [PATCH] SecurityPkg: AuthVariableLib: Revert

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

Hi, Haojian JEDEC org doesn't have a eMMC host controller spec. most of eMMC h/c vendors just reuse the SD host controller spec defined by SD Association. Of course there are also some variants on eMMC host controller IP which doesn't follow SD host controller spec perfectly. The intention of

Re: [edk2] view bugzilla without login - Re: Tianocore Bugzilla Server is now live

Laszlo, I have looked for a setting to enable inline history and done some searches. This does not look like a standard feature. But it looks like there have been requests to add it and some custom extensions implemented. If anyone know how to enable this feature in Bugzilla 5.x, please let me

Re: [edk2] view bugzilla without login - Re: Tianocore Bugzilla Server is now live

On 07/21/16 21:51, Kinney, Michael D wrote: > > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, July 21, 2016 11:41 AM >> To: Kinney, Michael D ; Justen, Jordan L >> >> Cc: edk2-devel-01

Re: [edk2] view bugzilla without login - Re: Tianocore Bugzilla Server is now live

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, July 21, 2016 11:41 AM > To: Kinney, Michael D ; Justen, Jordan L > > Cc: edk2-devel-01 > Subject: Re: view bugzilla

Re: [edk2] [StdLib] Fails to compile with the latest version of Xcode/clang due to new compiler diagnostic.

On 21 July 2016 at 17:38, Andrew Fish wrote: > >> On Jul 21, 2016, at 4:00 AM, Ard Biesheuvel >> wrote: >> >> On 20 July 2016 at 23:09, Andrew Fish wrote: >>> It looks like clang has added a warning to detect infinite recursion and

Re: [edk2] [PATCH v2] [BaseTools/Scripts]: Preserve hii section in GCC binaries

On 7/21/2016 1:41 PM, Palmer, Thomas wrote: But the patch worked? Yup - see my other email with the "Tested-by" line. Thanks! -- Bruce ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2] [BaseTools/Scripts]: Preserve hii section in GCC binaries

But the patch worked? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bruce Cran Sent: Thursday, July 21, 2016 2:40 PM To: Laszlo Ersek ; Bruce Cran ; Heyi Guo Cc:

Re: [edk2] [PATCH v2] [BaseTools/Scripts]: Preserve hii section in GCC binaries

On 7/21/2016 9:09 AM, Laszlo Ersek wrote: I clicked the link myself, before posting my email, and it didn't work. :) Damn, seems I deleted it for some reason. I've created another copy at http://bluestop.org/edk2/docs/GccHiiResourcesBug.tgz . -- Bruce

Re: [edk2] [PATCH v2] [BaseTools/Scripts]: Preserve hii section in GCC binaries

On 7/20/2016 8:07 PM, Thomas Palmer wrote: This change keeps the .hii sections in GCC built binaries. Please refer to email thread titled "[edk2] HII gEfiHiiPackageListProtocolGuid problem with GCC48 (VS2012x86 works)" Reviewed-by: Bruce Cran Tested-by: Bruce Cran

Re: [edk2] Tianocore Bugzilla Server is now live

On 07/21/16 20:07, Kinney, Michael D wrote: > Laszlo, > > Try again...it was disabled for a short period of time. Yes, it's working now. I'll let you know when I'm done with the clipboard "wizardry" and the occasional reformatting :) Thanks! Laszlo >> -Original Message- >> From:

Re: [edk2] view bugzilla without login - Re: Tianocore Bugzilla Server is now live

On 07/21/16 20:29, Kinney, Michael D wrote: > > >> -Original Message- >> From: Justen, Jordan L >> Sent: Thursday, July 21, 2016 11:12 AM >> To: Kinney, Michael D ; Laszlo Ersek >> >> Cc: edk2-devel-01 >> Subject:

Re: [edk2] view bugzilla without login - Re: Tianocore Bugzilla Server is now live

> -Original Message- > From: Justen, Jordan L > Sent: Thursday, July 21, 2016 11:12 AM > To: Kinney, Michael D ; Laszlo Ersek > > Cc: edk2-devel-01 > Subject: view bugzilla without login - Re: [edk2] Tianocore

[edk2] view bugzilla without login - Re: Tianocore Bugzilla Server is now live

On 2016-07-21 08:17:33, Kinney, Michael D wrote: > > -Original Message- > > From: Laszlo Ersek [mailto:ler...@redhat.com] > > Sent: Thursday, July 21, 2016 6:15 AM > > To: Kinney, Michael D > > Cc: edk2-devel-01 > > Subject: Re: [edk2]

Re: [edk2] Tianocore Bugzilla Server is now live

Laszlo, Try again...it was disabled for a short period of time. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, July 21, 2016 10:33 AM > To: Kinney, Michael D > Cc:

Re: [edk2] [PATCH v2] [BaseTools/Scripts]: Preserve hii section in GCC binaries

Roger, I'll await feedback before sending out a v3 patch Thomas -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, July 21, 2016 8:27 AM To: Palmer, Thomas ; edk2-de...@ml01.01.org Cc: af...@apple.com; liming@intel.com; Bruce Cran

Re: [edk2] Tianocore Bugzilla Server is now live

On 07/21/16 19:05, Kinney, Michael D wrote: > Laszlo, > > Yes. We can hold off disabling GitHub. Let us know when you are ready. Thank you! However, github is rejecting my new comments in the browser tabs that I have open already, and it rejects my fresh requests for issue URLs. Thanks,

Re: [edk2] Tianocore Bugzilla Server is now live

Laszlo, Yes. We can hold off disabling GitHub. Let us know when you are ready. Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, July 21, 2016 9:56 AM > To: Kinney, Michael D > Cc: edk2-devel-01

Re: [edk2] Tianocore Bugzilla Server is now live

On 07/21/16 17:17, Kinney, Michael D wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, July 21, 2016 6:15 AM >> To: Kinney, Michael D >> Cc: edk2-devel-01 >> Subject: Re: [edk2] Tianocore

Re: [edk2] code documentation generator?

> I've been running doxygen over the tree every few weeks, and putting the results at thx! The Doxygen configs are very useful > Yes, it is already done with each UDK release. Documentations is generated for EDK II packages. See: are the tools for generating these public? Thanks Michael On

Re: [edk2] [StdLib] Fails to compile with the latest version of Xcode/clang due to new compiler diagnostic.

> On Jul 21, 2016, at 4:00 AM, Ard Biesheuvel wrote: > > On 20 July 2016 at 23:09, Andrew Fish wrote: >> It looks like clang has added a warning to detect infinite recursion and I'm >> seeing the failure here: >> >>

Re: [edk2] code documentation generator?

Yes, it is already done with each UDK release. Documentations is generated for EDK II packages. See: http://www.tianocore.org/udk/udk2015/ under Documents. thanks, Laurie   laurie.jarlst...@intel.com Intel SSG/STO/EBP (503) 712-9395 -Original Message- From: edk2-devel

Re: [edk2] Tianocore Bugzilla Server is now live

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, July 21, 2016 6:15 AM > To: Kinney, Michael D > Cc: edk2-devel-01 > Subject: Re: [edk2] Tianocore Bugzilla Server is now live > > On 07/21/16 00:47,

Re: [edk2] [PATCH v2] [BaseTools/Scripts]: Preserve hii section in GCC binaries

On 07/21/16 16:53, Bruce Cran wrote: > On 7/21/16 6:47 AM, Laszlo Ersek wrote: > >> Can you guys please test this? See: >> >> http://thread.gmane.org/gmane.comp.bios.tianocore.devel/13438 > > I'd forgotten I'd provided a project to replicate the problem - that's > nice! :) I clicked the link

Re: [edk2] [PATCH v2] [BaseTools/Scripts]: Preserve hii section in GCC binaries

On 7/21/16 6:47 AM, Laszlo Ersek wrote: Can you guys please test this? See: http://thread.gmane.org/gmane.comp.bios.tianocore.devel/13438 I'd forgotten I'd provided a project to replicate the problem - that's nice! :) I'll try and get around to testing it later today. -- Bruce

[edk2] code documentation generator?

Hi, since EDK2's code is very good commented/documented, wouldn't it make sense to support tools like doxygen to generate standalone/online documentation like the one that once was available at phoenix? Or is there something like that already and I just didn't see it? Thanks Michael

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

On 2016/7/21 19:24, Ard Biesheuvel wrote: On 21 July 2016 at 13:17, Haojian Zhuang wrote: On 2016/7/21 9:52, Haojian Zhuang wrote: 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: Hi Feng, I think the main difference is who to handle the CRC bits. In the designware

Re: [edk2] [PATCH v2] [BaseTools/Scripts]: Preserve hii section in GCC binaries

On 07/21/16 04:07, Thomas Palmer wrote: > This change keeps the .hii sections in GCC built binaries. Please > refer to email thread titled "[edk2] HII > gEfiHiiPackageListProtocolGuid problem with GCC48 (VS2012x86 works)" > > As this is the first time I've ever touched a GCC linker script, >

Re: [edk2] Instance of library class [ArmMmuLib] is not found

On 2016/7/21 19:27, Ard Biesheuvel wrote: On 20 July 2016 at 07:44, Michael Zimmermann wrote: Hi, since commit '5db1cce ArmPkg ArmVirtPkg MdeModulePkg: switch to separate ArmMmuLib' you need to add ArmMmuLib to your platform's dsc file:

Re: [edk2] Instance of library class [ArmMmuLib] is not found

On 2016/7/21 19:27, Ard Biesheuvel wrote: On 20 July 2016 at 07:44, Michael Zimmermann wrote: Hi, since commit '5db1cce ArmPkg ArmVirtPkg MdeModulePkg: switch to separate ArmMmuLib' you need to add ArmMmuLib to your platform's dsc file:

Re: [edk2] Tianocore Bugzilla Server is now live

On 07/21/16 00:47, Kinney, Michael D wrote: > Hello, > > I am pleased to announce that the Bugzilla server for Tianocore > is now live and ready to be used. The server URL is: > > https://tianocore.acgmultimedia.com > > If you do not have a user account yet, please create one. > > There

Re: [edk2] [PATCH v2] [BaseTools/Scripts]: Preserve hii section in GCC binaries

Bruce, Heyi, On 07/21/16 04:07, Thomas Palmer wrote: > This change keeps the .hii sections in GCC built binaries. Please > refer to email thread titled "[edk2] HII > gEfiHiiPackageListProtocolGuid problem with GCC48 (VS2012x86 works)" > > As this is the first time I've ever touched a GCC

Re: [edk2] [PATCH v3 0/9] MdePkg BaseTools: GCC optimization for X64

On 20 July 2016 at 17:09, Gao, Liming wrote: > After fix one platform issue, this patches can work in our X64 real hardware > platform. So, I add Tested-By: Liming Gao > > > > For the patch 6, I have given my comments.

Re: [edk2] Instance of library class [ArmMmuLib] is not found

On 20 July 2016 at 07:44, Michael Zimmermann wrote: > Hi, > > since commit '5db1cce ArmPkg ArmVirtPkg MdeModulePkg: switch to separate > ArmMmuLib' you need to add ArmMmuLib to your platform's dsc file: > > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > Indeed.

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

On 21 July 2016 at 13:17, Haojian Zhuang wrote: > On 2016/7/21 9:52, Haojian Zhuang wrote: >> >> >> >> 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: >>> >>> Hi Feng, >>> >>> I think the main difference is who to handle the CRC bits. In the >>> designware emmc/sd controller,

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

On 2016/7/21 9:52, Haojian Zhuang wrote: 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: Hi Feng, I think the main difference is who to handle the CRC bits. In the designware emmc/sd controller, the whole 128-bit value is loaded into the four response registers. There's no any shift on the 128-bit

Re: [edk2] [StdLib] Fails to compile with the latest version of Xcode/clang due to new compiler diagnostic.

On 20 July 2016 at 23:09, Andrew Fish wrote: > It looks like clang has added a warning to detect infinite recursion and I'm > seeing the failure here: > > https://github.com/tianocore/edk2/blob/master/StdLib/LibC/StdLib/Environs.c#L123 > void > _Exit(int status) > { >

Re: [edk2] [PATCH] Fix IPv6 HTTPClient vendor class data

Due to the scarce information in the internet for how to setup ISC DHCP6 configs to manage UEFI pxe/http boot from various client, here is an example config to accomplish that by means of the vendor class id. The config is also used to identify and verify the fix in the patch. Hopefully it helps

Re: [edk2] [PATCH] Fix IPv6 HTTPClient vendor class data

If no other comments, I will ask jiaxin to help you check in your patch. Reviewed-by: Zhang Lubo Thanks Lubo > -Original Message- > From: Michael Chang [mailto:mch...@suse.com] > Sent: Thursday, July 21, 2016 4:20 PM > To: Zhang, Lubo > Cc:

Re: [edk2] [PATCH v2] [BaseTools/Scripts]: Preserve hii section in GCC binaries

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Thomas Palmer [mailto:thomas.pal...@hpe.com] Sent: Thursday, July 21, 2016 10:07 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming

Re: [edk2] [Patch] BaseTools PatchCheck.py: Add line number in the print error message

Here, the print line number is the line of the source file, not the line of the patch. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, July 21, 2016 4:22 PM > To: edk2-devel@lists.01.org >

[edk2] [Patch] BaseTools PatchCheck.py: Add line number in the print error message

PatchCheck script prints File and Line information in error message. This patch adds line number in the error message to help detect the issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- BaseTools/Scripts/PatchCheck.py | 12

[edk2] [PATCH] SecurityPkg: AuthVariableLib: Revert UserPhysicalPresent feature from AuthVariableLib

Physical Presence state reporting is constrained by physical presence caching in variable driver. For example, reporting must be prior to Physical Presence after caching. After caching, Physical Presence state becomes constant rather than instant. Therefore, PlatformSecureLib is responsible for

Re: [edk2] [PATCH] IntelFsp2Pkg: Remove CarBase and CarSize from FSP_GLOBAL_DATA

Agree to remove car calculation from MSR. Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Satya Yarlagadda > Sent: Wednesday, July 20, 2016 2:49 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen

  1   2   >