[edk2] [patch] ShellPkg: Add the check of parameter number in "DrvCfg" command

In shell spec, the usage of "Drvcfg" command is: drvcfg [-l XXX] [-c] [-f |-v|-s] [DriverHandle [DeviceHandle [ChildHandle]]] [-i filename] [-o filename]. The parameter number(doesn't include the flags) cannot exceed 4, now we add this point to check whether using the command correctly. Cc: Ruiyu

[edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

When user uses the command "bcfg driver|boot [dump [-v]]", the number of command line value parameters (doesn't include the flag) must be three. We can add this point to check whether using this command correctly. Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 22/26] ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro

reviewed should mean tested ;) took me some time to find out why my system currently doesn't boot anymore but here's the fix for this commit: diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S index b7127ce..39030da 100644 --- a/ArmPlatformPkg/P

Re: [edk2] Crc32

it doesn't. it just seems that if the crc text field is not empty it calculates the crc of the crc, so you have to hit the "Reset CRC" button before reprocessing the text. On Wed, Aug 31, 2016 at 3:11 AM, valerij zaporogeci wrote: > >> after testing it it indeed produces CCITT32 results like thi

Re: [edk2] [PATCH] SecurityPkg: TPM12CommandLib: Add Response returnCode Check

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zhang, Chao B > Sent: Wednesday, August 31, 2016 9:47 AM > To: edk2-devel@lists.01.org > Cc: Long, Qin ; Yao, Jiewen ; > Zhang, Chao B > Subject: [PATCH] SecurityPkg: TPM12CommandLib: Add Response > returnCode Check > >Ch

[edk2] [PATCH] SecurityPkg: TPM12CommandLib: Add Response returnCode Check

Check response return code before return from Tpm12Extend and Tpm12PhysicalPresence. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- SecurityPkg/Library/Tpm12CommandLib/Tpm12Pcr.c | 5 + .../Library/Tpm12CommandLib/Tpm12PhysicalPresence.c

Re: [edk2] Crc32

>> after testing it it indeed produces CCITT32 results like this online >> generator: >> http://g6auc.me.uk/CRC32/index.html I only now noticed that this "calculator", gives DIFFERENT values on the same input, no matter hex or text based. Interestingly, how it could produce the same results as t

Re: [edk2] [EDK2] DxeCapsuleLib returns Status Issue

Hi Ankit Singh This seems a missing feature in current EDKII. Thanks to catch that. Would you please file a bugzillar tracker, so that it can recorded? The Bugzilla is introduced @ http://www.tianocore.org/news/2016/07/22/Bugzilla.html The URL for Bugzilla is @ https://tianocore.acgmultimedia.c

[edk2] [PATCH] IntelSiliconPkg: Rename IGD structures to make it consistent

Renamed INTEL_IGD_* to IGD_* and IGD_OPREGION_VBT to IGD_OPREGION_MBOX4 to make it consistent with file name and other mailbox naming. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- .../Include/IndustryStandard/IgdOpRegion.h | 3

Re: [edk2] [PATCH v4 3/4] MdeModulePkg/EbxDxe AARCH64: use tail call for EBC to native thunk

On Tue, Aug 30, 2016 at 03:27:23PM +0100, Ard Biesheuvel wrote: > Instead of pessimistically copying at least 64 bytes from the VM stack > to the native stack, and popping off the register arguments again > before doing the native call, try to avoid touching the stack completely > if the VM stack f

Re: [edk2] BootableImageSupportTest\StorageSecurityCommandProtocolTest

Hi Feng, Any update or suggestion on this? Can we consider this as SCT tool issue and would be fixed in next version ? Thanks, Ramesh -Original Message- From: Tian, Feng [mailto:feng.t...@intel.com] Sent: 26 August 2016 12:54 To: Ramesh R.; edk2-devel; Jin, Eric Cc: Tian, Feng Subjec

Re: [edk2] Crc32

> On Aug 30, 2016, at 8:17 AM, valerij zaporogeci wrote: > > well, that bit in the 32th (bit 33) term of the polynomial is > "implied", but it should be used, otherwise it would not give a 32 bit > remainder (crc). if to count 04c11db7 as a polynomial, its non-zero > msbit is bit 26, so with it,

Re: [edk2] Crc32

well, that bit in the 32th (bit 33) term of the polynomial is "implied", but it should be used, otherwise it would not give a 32 bit remainder (crc). if to count 04c11db7 as a polynomial, its non-zero msbit is bit 26, so with it, it would be crc25. Why results don't match, I suspect it's becuase th

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 08/19/16 14:49, Laszlo Ersek wrote: > This series solves > . In particular, > it gives AARCH64 guests running on KVM a clean, uncorrupted graphical > console. > > Anatomy of the series: > > - Patches 01 and 02 fix small bugs in QemuVideoD

Re: [edk2] [PATCH v4 0/4] MdeModulePkg/EbcDxe: AARCH64 improvements

On 30 August 2016 at 15:27, Ard Biesheuvel wrote: > This is v4 of my proposed changes to the AARCH64 implementation of EbcDxe > contributed by Jeff Brasen, which has recently been merged into Tianocore. > > Changes since v3: > - fix typo in comment (#1) > - clarify comments around computed goto in

[edk2] [PATCH v4 2/4] MdeModulePkg/EbcDxe AARCH64: use a fixed size thunk structure

The thunk generation is needlessly complex, given that it attempts to deal with variable length instructions, which don't exist on AArch64. So replace it with a simple template coded in assembler, with a matching struct definition in C. That way, we can create and manipulate the thunks easily with

[edk2] [PATCH v4 1/4] MdeModulePkg/EbcDxe AARCH64: clean up comment style in ASM file

Change to consistent // style comments. Also, remove bogus global definitions for external functions, and move the real exports to the top of the file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- MdeModulePkg/Universal/Ebc

[edk2] [PATCH v4 3/4] MdeModulePkg/EbxDxe AARCH64: use tail call for EBC to native thunk

Instead of pessimistically copying at least 64 bytes from the VM stack to the native stack, and popping off the register arguments again before doing the native call, try to avoid touching the stack completely if the VM stack frame is <= 64 bytes. Also, if the stack frame does exceed 64 bytes, ther

[edk2] [PATCH v4 4/4] MdeModulePkg/EbcDxe AARCH64: simplify interpreter entry point thunks

The prototypes of EbcInterpret() and ExecuteEbcImageEntryPoint() are private to the AARCH64 implementation of EbcDxe, so we can shuffle the arguments around a bit and make the assembler thunking glue a lot simpler. For ExecuteEbcImageEntryPoint(), this involves passing the EntryPoint argument as t

[edk2] [PATCH v4 0/4] MdeModulePkg/EbcDxe: AARCH64 improvements

This is v4 of my proposed changes to the AARCH64 implementation of EbcDxe contributed by Jeff Brasen, which has recently been merged into Tianocore. Changes since v3: - fix typo in comment (#1) - clarify comments around computed goto in EBC to native thunk, and make sure the jump target is 32-bi

Re: [edk2] Crc32

> On Aug 30, 2016, at 6:32 AM, valerij zaporogeci wrote: > > Thank you. > But the polynomial value for CCITT crc32 is 104c11db7, not its tail 04c11db7. The spec does not say it is a CCITT, it states it uses the CCITT algorithm with a seed polynomial of 0x04c11db7. > And this whole mess with

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

On 08/25/16 10:00, Fan, Jeff wrote: > Laszlo, > > After discussed with Star, I understood OVMF's circle dependency on Variable > Arch protocol and SMM CPU driver. > > I will defer to check-in this patch till found the better solution. Thank you! > Before the proper fix adopted, our platforms m

Re: [edk2] Crc32

Thank you. But the polynomial value for CCITT crc32 is 104c11db7, not its tail 04c11db7. And this whole mess with all those online calculators was the exact reson I asked here. Because they mostly give WRONG result. As your example. It's easy to check it's wrong. Because for example leading zeroes

Re: [edk2] Crc32

well as u already said, the spec says it uses 'a standard CCITT32 CRC algorithm with a seed polynomial value of 0x04c11db7' this is the implementation which confirms it: https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/RuntimeDxe/Crc32.c after testing it it indeed produces CCITT32

[edk2] Related to adding ACPI Table(RASF) to UEFI....

Hi, I am trying to add RASF ACPI table to UEFI Source(in local copy). Taken code from https://github.com/tianocore/edk2 I am not able to locate code where, other ACPI tables like HEST(Hardware Error source table) and other ACPI tables are added. I am new to UEFI, can you pls help, where can

Re: [edk2] [Patch] BaseTools: UpdateImageSize include Image auth info for FMP Auth capsule

Reviewed-by: Liming Gao -Original Message- From: Zhu, Yonghong Sent: Monday, August 29, 2016 4:11 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] BaseTools: UpdateImageSize include Image auth info for FMP Auth capsule Per UEFI spec UpdateImageSize may or may not includ