On 09/11/17 14:16, Brijesh Singh wrote:
> Consolidate the virtio VRING resource cleanup into VirtioNetUninitRing().
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Tom Lendacky
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Brijesh Singh
> ---
>
Cc: Star Zeng
Cc: Eric Dong
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdeModulePkg/MdeModulePkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
index ad85776..ad34254 1
Reviewed-by: Star Zeng
-Original Message-
From: Bi, Dandan
Sent: Wednesday, September 13, 2017 3:37 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric ; Ni,
Ruiyu
Subject: [patch] MdeModulePkg: Add UdfDxe to the dsc file
Cc: Star Zeng
Cc: Eric Dong
Cc: Ruiyu Ni
Contributed-
On 09/11/17 14:16, Brijesh Singh wrote:
> When device is behind the IOMMU then driver need to pass the device
> address when programing the bus master. The patch uses VirtioRingMap() to
> map the VRING system physical address[es] to device address[es].
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
>
QemuVideoDxe driver will install VBE SHIM into page 0. If NULL pointer
detection is enabled, page 0 must be enabled temporarily before installing and
disabled again afterwards. For Windows 7 boot, BIT7 of
PcdNullPointerDetectionPropertyMask must still be set to avoid hang.
Cc: Jiewen Yao
Cc: E
CSM code has to access memory below 4096 (BDA, int vector, etc.). If NULL
pointer detection is enabled, the page 0 must be enabled temporarily before
accessing it and disabled again afterwards. Otherwise page fault will be
triggered.
Cc: Jiewen Yao
Cc: Eric Dong
Cc: Star Zeng
Cc: Laszlo Erse
The mechanism behind is to trigger a page fault exception at address 0. This
can be made by disabling page 0 (0-4095) during page table setup. So this
feature can only be available on platform with paging enabled. Once this
feature is enabled, any code, like CSM, which has to access memory in pa
The mechanism behind is to trigger a page fault exception at address 0. This
can be made by disabling page 0 (0-4095) during page table setup. So this
feature can only be available on platform with paging enabled. Once this
feature is enabled, any code, like CSM, which has to access memory in pa
The mechanism behind is the same as NULL pointer detection enabled in EDK-II
core. SMM has its own page table and we have to disable page 0 again in SMM
mode.
Cc: Jiewen Yao
Cc: Eric Dong
Cc: Star Zeng
Cc: Laszlo Ersek
Cc: Justen, Jordan L
Cc: Kinney, Michael D
Cc: Wolman, Ayellet
Suggest
Hi Pipat,
It is useful to prefix emails regarding edk2-platforms with
[edk2-platforms] on the subject line.
+Jan Dąbroś (original author, a fact that has been
lost in the migration from OpenPlatformPkg.
also +Marcin Wojtas , Marvell platform owner.
(Neither of which are obvious from looking at t
My git has problem in email send. Please ignore these serial patches. I'll send
new ones later.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
w...@ml01.01.org
Sent: Wednesday, September 13, 2017 4:45 PM
To: edk2-devel@lists.01.org
Subject: [edk
On 09/11/17 14:16, Brijesh Singh wrote:
> When device is behind the IOMMU, VirtioNetDxe is required to use the
> device address in bus master operations. RxBuf is allocated using
> AllocatePool() which returns the system physical address.
>
> The patch uses VIRTIO_DEVICE_PROTOCOL.AllocateSharedPag
The mechanism behind is to trigger a page fault exception at address 0. This
can be made by disabling page 0 (0-4095) during page table setup. So this
feature can only be available on platform with paging enabled. Once this
feature is enabled, any code, like CSM, which has to access memory in pa
The mechanism behind is the same as NULL pointer detection enabled in EDK-II
core. SMM has its own page table and we have to disable page 0 again in SMM
mode.
Cc: Jiewen Yao
Cc: Eric Dong
Cc: Star Zeng
Cc: Laszlo Ersek
Cc: Justen, Jordan L
Cc: Kinney, Michael D
Cc: Wolman, Ayellet
Suggest
CSM code has to access memory below 4096 (BDA, int vector, etc.). If NULL
pointer detection is enabled, the page 0 must be enabled temporarily before
accessing it and disabled again afterwards. Otherwise page fault will be
triggered.
Cc: Jiewen Yao
Cc: Eric Dong
Cc: Star Zeng
Cc: Laszlo Erse
The mechanism behind is to trigger a page fault exception at address 0. This
can be made by disabling page 0 (0-4095) during page table setup. So this
feature can only be available on platform with paging enabled. Once this
feature is enabled, any code, like CSM, which has to access memory in pa
QemuVideoDxe driver will install VBE SHIM into page 0. If NULL pointer
detection is enabled, page 0 must be enabled temporarily before installing and
disabled again afterwards. For Windows 7 boot, BIT7 of
PcdNullPointerDetectionPropertyMask must still be set to avoid hang.
Cc: Jiewen Yao
Cc: E
Fix build failure caused by UefiCpuPkg/MtrrLib removes deprecated macros.
Cc: Daryl McDaniel
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
AppPkg/Applications/Sockets/WebServer/Mtrr.c | 31 +++
AppPk
I have been confused by where should new module be put for some time.
When should a new module be put at XXXPkg/Universal? For example,
MdeModule/Universal, UefiCpuPkg/Universal,
When should a new module be put at XXXPkg/Feature? For example,
UefiCpuPkg/Feature.
When should a new module be p
Good question.
Yes, I think we can put all VTd related components to
IntelSiliconPkg/Feature/VTd.
Once we finished the review, I would submit another patch to move all
components to the new location.
Thank you
Yao Jiewen
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, Septe
We have a minor conundrum, and would like an element of consensus before we
make a commit.
We want to (re-)submit patches adding HDLCD/GOP for some ARM platforms.
We have previously been asked to make this optional, as some people do not want
the overhead of GOP (and the frame buffer) in their im
Hello All,
I was trying to verify the feature "Allow SetData to clear configuration in
Ip4Config2/Ip6Config Protocol" , But SetData returns with Write Protected Error
Status
[Steps followed]
1. I've taken the above feature changes.
2. I've a UEFI test Application which call to Set
Hello All,
I was trying to verify the feature "Allow SetData to clear configuration in
Ip4Config2/Ip6Config Protocol" , But SetData returns with Write Protected Error
Status
[Steps followed]
1. I've taken the above feature changes.
2. I've a UEFI test Application which call to Set
On September 12, 2017 7:26:10 PM GMT-03:00, Laszlo Ersek
wrote:
>Repo: https://github.com/lersek/edk2.git
>Branch: udf_fixes_cleanups_round2
>
>Once these patches are sufficiently reviewed, please don't wait for me
>to commit them.
>
>Further UdfDxe issues should be please reported in the Tia
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, September 13, 2017 3:10 AM
> To: edk2-devel@lists.01.org
> Cc: Daryl McDaniel ; Carsey, Jaben
> ; Ni, Ruiyu
> Subject: [Patch] AppPkg/WebServer: Fix build failure.
> Importance: High
>
> Fix build failu
On 09/11/17 14:16, Brijesh Singh wrote:
> Each network packet is submitted for transmission by pushing the head
> descriptor of a two-part descriptor chain to the Available Ring of the
> TX queue. VirtioNetInitTx() sets up the the descriptor chains for all
> queueable packets in advance, and points
On 09/11/17 14:16, Brijesh Singh wrote:
> In next patches we will update Virtio transmit to use the device-mapped
> address of the caller-supplied packet. The patch documents the new model.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Tom Lendacky
> Cc: Laszlo Ersek
> Contributed-under: Ti
Looks good.
Reviewed-by: Daryl McDaniel
> -Original Message-
> From: Eric Dong [mailto:eric.d...@intel.com]
> Sent: Wednesday, September 13, 2017 3:10 AM
> To: edk2-devel@lists.01.org
> Cc: Daryl McDaniel ; Jaben Carsey
> ; Ruiyu Ni
> Subject: [Patch] AppPkg/WebServer: Fix build failure
Comments below.
Brian
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang,
Jian J
Sent: Wednesday, September 13, 2017 4:25 AM
To: edk2-devel@lists.01.org
Cc: jus...@ml01.01.org; Eric Dong ; kin...@ml01.01.org;
Jordan L ; wol...@ml01.01.org; Jie
Acked-by: Brian J. Johnson
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang,
Jian J
Sent: Wednesday, September 13, 2017 4:25 AM
To: edk2-devel@lists.01.org
Cc: jus...@ml01.01.org; Eric Dong ; kin...@ml01.01.org;
Jordan L ; wol...@ml01.01.org
Acked-by: Brian J. Johnson
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang,
Jian J
Sent: Wednesday, September 13, 2017 4:25 AM
To: edk2-devel@lists.01.org
Cc: jus...@ml01.01.org; Eric Dong ; kin...@ml01.01.org;
Jordan L ; wol...@ml01.01.org
ClearLegacyMemory() assumes that the memory allocation HOB comes after the
resource descriptor HOB in the HOB list. Is that guaranteed? I'd think that
the memory allocation HOB traversal should be a separate loop, after the
resource descriptor HOB traversal loop.
Other than that:
Reviewed-by:
On 2017-09-13 02:25:04, Wang, Jian J wrote:
> The mechanism behind is to trigger a page fault exception at address 0. This
> can be made by disabling page 0 (0-4095) during page table setup. So this
> feature can only be available on platform with paging enabled. Once this
> feature is enabled,
On 2017-09-13 02:25:05, Wang, Jian J wrote:
> The mechanism behind is the same as NULL pointer detection enabled in EDK-II
> core. SMM has its own page table and we have to disable page 0 again in SMM
> mode.
>
> Cc: Jiewen Yao
> Cc: Eric Dong
> Cc: Star Zeng
> Cc: Laszlo Ersek
> Cc: Justen,
On 09/11/17 14:16, Brijesh Singh wrote:
> When device is behind IOMMU, driver is require to pass the device address
> of TxBuf in the Tx VRING. The patch adds helper functions and data
> structure to map and unmap the TxBuf system physical address to a device
> address.
>
> Since the TxBuf is retur
From: Sami Mujawar
>From the UEFI perspective Device Tree is a non standard extra.
There is, thus, an existing build flag DT_SUPPORTED.
This change removes Device Tree specific code unless DT_SUPPORTED is
set.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar
S
From: EvanLloyd
There are a number of cases where it is desirable to remove unused code.
An obvious instance might be on an emulator, where executing irrelevant
code can add hours to the boot time. This change enables removal of
some code that might not be relevant, using build options that can
From: Sami
When network functionality is not required, the boot process is
impeded by redundant network timeouts. Moreover Juno is a mobile
platform so it makes sense to have an option to disable the
(ethernet) networking support. We therefore introduce the
DISABLE_NETWORK build option.
By defa
On 09/13/17 08:43, Zeng, Star wrote:
> Beyond the Rb (I do not want to block this patch series), I am curious about
> one question.
>
> There may be more this kind of workarounds to fix the build failure.
> Is it possible to disable the warning (like below example for VS) for
> specific version
On 13 September 2017 at 11:49, Laszlo Ersek wrote:
> On 09/13/17 08:43, Zeng, Star wrote:
>> Beyond the Rb (I do not want to block this patch series), I am curious about
>> one question.
>>
>> There may be more this kind of workarounds to fix the build failure.
>> Is it possible to disable the wa
On 09/13/17 20:07, Laszlo Ersek wrote:
> On 09/11/17 14:16, Brijesh Singh wrote:
>> +*/
>> +EFI_STATUS
>> +EFIAPI
>> +VirtioNetMapTxBuf (
>> + IN VNET_DEV *Dev,
>> + IN UINT16DescIdx,
>> + IN VOID *Buffer,
>> + IN UINTN NumberOf
On 09/11/17 14:16, Brijesh Singh wrote:
> When device is behind the IOMMU, driver is require to pass the device
> address of caller-supplied transmit buffer for the bus master operations.
>
> The patch uses VirtioNetMapTxBuf() to map caller-supplied Tx packet to a
> device-address and enqueue the
On 09/13/17 12:09, Eric Dong wrote:
> Fix build failure caused by UefiCpuPkg/MtrrLib removes deprecated macros.
>
> Cc: Daryl McDaniel
> Cc: Jaben Carsey
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong
> ---
> AppPkg/Applications/Sockets/Web
On 09/13/17 15:42, Paulo Alcantara wrote:
>
>
> On September 12, 2017 7:26:10 PM GMT-03:00, Laszlo Ersek
> wrote:
>> Repo: https://github.com/lersek/edk2.git
>> Branch: udf_fixes_cleanups_round2
>>
>> Once these patches are sufficiently reviewed, please don't wait for me
>> to commit them.
>>
Hi,
some of the points I'm going to make have already been pointed out by
Jordan:
(1) When posting a patch series, please collect the Cc: tags from all of
the patches, and add them *all* to the cover letter. This way everyone
will get a personal copy of the general description.
(2) The subject
Comparing adding workaround in code with suppressing it in *OLD* version GCCs,
I prefer the latter personally.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Thursday, September 14, 2017 2:52 AM
To: Laszlo Erse
I cannot find anywhere how to enable VT-x in OVMF, if anyone can point me
in the right direction, I'd greatly appreciate it.
thanks,
David Napier
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Thanks for the comments and good advices. Sorry the format issues.
This is my first patch for this project. Too many details for me to get
familiar with.
(1) Sure.
(2) I'll change that.
(3) I'll use the tool to ensure the patch format.
(4) I'll remove the ',' in name
(5) I'll add more descriptio
I'll use the tool to check the format. For the macro, it's for readability
purpose. How's the library replacement suggestion from Laszlo?
-Original Message-
From: Justen, Jordan L
Sent: Thursday, September 14, 2017 1:32 AM
To: Wang, Jian J ; edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Don
Seemingly, VS has similar issue with GCC.
VS2010/VS2012 still have the building failures below after this patch. :(
edk2\mdemodulepkg\universal\disk\udfdxe\filesystemoperations.c(1083) : error
C2220: warning treated as error - no 'executable' file generated
edk2\mdemodulepkg\universal\disk\udfdxe
See my comments start with [Jian] below.
-Original Message-
From: Justen, Jordan L
Sent: Thursday, September 14, 2017 1:28 AM
To: Wang, Jian J ; edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Dong, Eric ; Zeng,
Star ; Laszlo Ersek ; Kinney, Michael D
; Wolman, Ayellet
Subject: Re: [PATCH 1/
Right. Just initialize them. They are not reported in VS2013&VS2015, because
VS2013 and VS2015 disables this warning in ProcessorBind.h. If they are all
false warning messages, I think we can propose to disable this warning for all
VS tool chain.
For GCC, if this warning is also false, could w
Thanks for the comments. See my comment start with [Jian] below.
-Original Message-
From: Johnson, Brian (EXL - Eagan) [mailto:brian.john...@hpe.com]
Sent: Thursday, September 14, 2017 12:34 AM
To: Wang, Jian J ; edk2-devel@lists.01.org
Cc: jus...@ml01.01.org; Dong, Eric ; kin...@ml01.01.
Thanks for the comment. I think there's no problem here because I'm using two
separate HOB pointers (RscDescHob and MemAllocHob) to do the traversal. One
won't interfere with another.
-Original Message-
From: Johnson, Brian (EXL - Eagan) [mailto:brian.john...@hpe.com]
Sent: Thursday, S
Right. UEFI spec defines ExitData format that null terminated string + optional
binary data.
> -Original Message-
> From: David F. [mailto:df7...@gmail.com]
> Sent: Wednesday, September 13, 2017 12:07 PM
> To: Gao, Liming
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] StartImage()
PcdSerialIoUartDebugEnable UPD is platform specific and should not
be included in generic GenCfgOpt.py script. Remove this and platform
DSC should control the default value instead.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chasel Chiu
---
IntelFsp2Pk
Thanks to catch this.
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Chiu, Chasel
> Sent: Thursday, September 14, 2017 10:44 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Chiu, Chasel
> Subject: [PATCH] IntelFsp2Pkg-Tools: GenCfgOpt.py shouldn't include specific
>
For the use of arch protocol, there's one thing I mentioned is not accurate. I
actually tried gDS->SetMemorySpaceAttributes() but it cannot change page
attributes. That's why I have to turn to cpu arch protocol.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan
Cc: Ye Ting
Cc: Wu Jiaxin
---
NetworkPkg/IScsiDxe/IScsiConfig.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c
b/NetworkPkg/IScsiDxe/IScsiCo
I just got an idea on release mode checking.
Because the build.exe will parse target.txt to decide if current build is DEBUG
or RELEASE, I think we can enhance the GenCftOpt.py to get same information
from target.txt.
In such way, all tools get same result on debug/release.
Thank you
Yao Jiew
Reviewed-by: Wu Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Thursday, September 14, 2017 11:18 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wu, Jiaxin
> Subject: [Patch] NetworkPkg: Remove the redundant '/' in the end of
> returned ISCSIMacAddr keyword.
>
> Contributed-
A minor comment.
Should or need IntelVTdPmrPei disable PMR at endofpei?
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Friday, September 8, 2017 11:04 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH 04/11] IntelSiliconPkg/VTdDxe: Disable PMR
When VTd translation
On 2017-09-13 18:17:26, Wang, Jian J wrote:
> Thanks for the comments and good advices. Sorry the format issues.
> This is my first patch for this project. Too many details for me to get
> familiar with.
>
> (1) Sure.
> (2) I'll change that.
> (3) I'll use the tool to ensure the patch format.
>
Change build script to generate different BIOS ID to differentiate Minnow3 and
Benson Glacier board.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: lushifex
---
BuildBIOS.bat | 19 +-
BuildBIOS.sh
I did consider that before.
I do not disable at EndOfPei purposely that because I want to make sure that
the DMA protect is still available in early DXE phase, just in case there is
bug in other module which forgets disabling BME.
Later it is VTdDxe driver that disable PME, *after* it sets up tr
Then, if there is a driver wants to do DMA at early DXE, it must need a PEIM to
allocate the DMA buffers in PEI and transfer them to DXE by HOB.
Is that what we want? I want to confirm that.
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Thursday, September 14, 2017 2:03 PM
To:
Yes, I think the usage model is: Any DMA buffer MUST be requested explicitly.
We do not want to allow a driver calling AllocatePage(), then start to use the
memory as DMA.
It can help:
1) In case that the DMA buffer address is not identical.
2) DMA protection.
Thank you
Yao Jiewen
Reviewed-by: zwei4
Thanks,
David Wei
> -Original Message-
> From: Lu, ShifeiX A
> Sent: Thursday, September 14, 2017 1:59 PM
> To: edk2-devel@lists.01.org
> Cc: Wei, David
> Subject: [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Build Script.
>
>
Reviewed-by: Star Zeng
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, September 13, 2017 6:19 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH 00/11] Add IOMMU PEI support.
Good question.
Yes, I think we can put all VTd related components to
IntelSiliconPk
On 2017-09-13 18:25:22, Wang, Jian J wrote:
> See my comments start with [Jian] below.
>
> -Original Message-
> From: Justen, Jordan L
> Sent: Thursday, September 14, 2017 1:28 AM
>
> > diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf
> > b/MdeModulePkg/Core/Dxe/DxeMain.inf
> > index 30d5
It's a tab character in old version. It may look like the same if your tab
width is to a certain number. In my editor, it looks unaligned. Sometimes I
just can't resist the temptation to fix the tab:) I'll restore it to avoid
irrelevant changes in next patch update.
-Original Message-
Sure. I'll change them to functions.
-Original Message-
From: Justen, Jordan L
Sent: Thursday, September 14, 2017 1:50 PM
To: Wang, Jian J ; Laszlo Ersek
Cc: edk2-devel@lists.01.org; Dong, Eric ; Kinney, Michael
D ; Wolman, Ayellet ;
Yao, Jiewen ; Zeng, Star
Subject: RE: [edk2] [PATCH
72 matches
Mail list logo