Re: [edk2] [PATCH V5 0/6] Support bitfield in storage of vfr

Reviewed-by: Liming Gao >-Original Message- >From: Bi, Dandan >Sent: Wednesday, September 20, 2017 4:39 PM >To: edk2-devel@lists.01.org >Cc: Dong, Eric ; Gao, Liming >Subject: [PATCH V5 0/6] Support bitfield in storage of vfr > >REF: https://bugzilla.tianocore.org/show_bug.cgi?id=545 > >

[edk2] [PATCH] IntelFsp2Pkg-Tools: Add FixedAtBuild PCD support in GenCfgOpt.py

Platform is eligible to use either PcdsFeatureFlag or PcdsFixedAtBuild for build configuration and requires GenCfgOpt.py support. Cc: Jiewen Yao Cc: Maurice, Ma Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Tools/GenCfgOpt.py | 2 +- 1 file

Re: [edk2] [PATCH] IntelFsp2Pkg-Tools: Add FixedAtBuild PCD support in GenCfgOpt.py

Reviewed-by: jiewen@intel.com > -Original Message- > From: Chiu, Chasel > Sent: Thursday, September 21, 2017 3:51 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Maurice; Ma, Maurice > ; Chiu, Chasel > Subject: [PATCH] IntelFsp2Pkg-Tools: Add FixedAtBuild PCD support in > GenCfgO

Re: [edk2] [Patch] BaseTools: extend FFS alignment to 16M

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Thursday, September 21, 2017 2:01 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: extend FFS alignment to 16M > >Current FFS only supports 64KiB alignment for data, Per PI 1.6 >requireme

Re: [edk2] [Patch] BaseTools: report build time measured by module of EDKII Build

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Thursday, September 21, 2017 1:52 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: report build time measured by module of EDKII >Build > >In the build report, we add AutoGen Phase, Make

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

I did a simple test on a Windows8.1 installation DVD, and here's the result of a map command under shell: Before the patch: Mapping table FS0: Alias(s):CD0f65535a1:;BLK2: PciRoot(0x0)/Pci(0x1F,0x2)/Sata(0x5,0x,0x0)/CDROM(0x1) BLK0: Alias(s): PciRoot(0x0)/Pci(0x1F

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

VS2015 Build-tested-by: Star Zeng I have a minor comment to this patch title, how about to use "MdeModulePkg/UDF: Fix creation of UDF logical partition" as this patch is touching both PartitionDxe and UdfDxe? Otherwise, you'd better to split this patch to two, one for PartitionDxe and one for

[edk2] SNP transmit print

Hi, While performing tftp using PCI interface, below message is coming continuously: Snp->undi.transmit() 8000h:4h Snp->undi.transmit() 8000h:4h [==> ] 34812 Kb Snp->undi

[edk2] NVME DXE Driver and PATA SS

Its been reported by various hardware modding enthusiasts that when they insert the Nvme edk2 driver into an Asus Ami based bios rom (could be other vendors as well) that after its insertion the system will say there is a 'PATA SS' device present in the boot menu however after Windows has been i

[edk2] [PATCH edk2-platforms v3 00/11] Update D03/D05 binary for edk2 update and bug fix.

Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git branch: rp-1710-platforms-v3rp-1710-osi-v3 Note: If occurs BIOS boot hang up issue, please revert below commit to fix: "2f03dc8" Chenhui Sun (1): Hisilicon/D03: Disable the function of PerfTuning Heyi

[edk2] [PATCH edk2-non-osi v3 1/7] Hisilicon/D03/Net: Update Snp driver

1. Replace SnpPV660Dxe with SnpPV600Dxe; 2. Add SnpPlatform: Install protocol to enable nic port which are using. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 0 -> 26688 bytes Pla

[edk2] [PATCH edk2-platforms v3 01/11] Hisilicon/D05: Modify dsc and fdf file

1. Add Drivers/SasPlatform; 2. Add Drivers/Net/SnpPlatform; Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D05/D05.dsc | 5 - Platform/Hisilicon/D05/D05.fdf | 4 +++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/Plat

[edk2] [PATCH edk2-platforms v3 02/11] Hisilicon/D03: Modify dsc and fdf file

1. Add Drivers/SasPlatform; 2. Add Drivers/Net/SnpPlatform; Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/D03.dsc | 5 - Platform/Hisilicon/D03/D03.fdf | 5 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/Pla

[edk2] [PATCH edk2-non-osi v3 2/7] Hisilicon/D03/Sas: Add SasPlatform

Install protocol to enable sas port which is using and transmit base address info of sas port to SasDriverDxe. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi | Bin 0 -> 3040 bytes Platform/Hisilic

[edk2] [PATCH edk2-non-osi v3 3/7] Hisilicon/D03: Update binary file

Update binary file for edk2 upgrade. 1. Replace UncachedMemoryAllocationLib with DmaLib; 2. Remove ArmCpuLib dependenc; 3. Remove ConvertToPhysicalAddress; Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/Drivers/GetInfoFromBmc/GetInfoF

[edk2] [PATCH edk2-non-osi v3 7/7] Hisilicon: Fix the drivers use the same GUID issue

The drivers build from separate sources, their GUID should be different. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Reviewed-by: Leif Lindholm --- Platform/Hisilicon/D02/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.inf | 2 +- Platform/Hisili

[edk2] [PATCH edk2-platforms v3 06/11] Hisilicon/D05/Pcie: fix bug of size definition

From: huangming Fix bug of PcieRegion size definition and IO size definition. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D05/D05.dsc | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/Platform

[edk2] [PATCH edk2-platforms v3 03/11] Hisilicon: Fix the drivers use the same GUID issue

The drivers build from separate sources, their GUID should be different. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Reviewed-by: Leif Lindholm --- Platform/Hisilicon/D02/EarlyConfigPeim/EarlyConfigPeim.inf | 2 +- Platform/Hisilicon/D02/Fdt

[edk2] [PATCH edk2-platforms v3 07/11] D05/PCIe: Modify PcieRegionBase of secondary chip

From: huangming On D05 PCIe now, 2p NA PCIe2 and 2p NB PCIe0's pci domain addresses are 0x2000 and 0x3000 based. These addresses overlap with the DDR memory range 0-1G. In this situation, on the inbound direction, our pcie will drop the DDR address access that are located in the pci range

[edk2] [PATCH edk2-platforms v3 05/11] Hisilicon/PciHostBridgeDxe: Assign BAR resource from PciRegionBase

Io BAR should be based IoBase and Mem BAR should be based PciRegionBase. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Drivers/PciHostBridgeDxe/PciHostBridge.c | 37 Silicon/Hisilicon/Drivers/PciHostBridgeDxe/PciRo

[edk2] [PATCH edk2-non-osi v3 5/7] Hisilicon/D05/Sas: Add SasPlatform

Install protocol to enable sas port which is using and transmit base address info of sas port to SasDriverDxe. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi | Bin 0 -> 3424 bytes Platform/Hisilic

[edk2] [PATCH edk2-non-osi v3 4/7] Hisilicon/D05/Net: Update Snp driver

1. Replace SnpPV660Dxe with SnpPV600Dxe; 2. Add SnpPlatform: Install protocol to enable nic port which are using. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 0 -> 28544 bytes Pla

[edk2] [PATCH edk2-platforms v3 04/11] Hisilicon D03/D05: get firmware version from FIRMWARE_VER

From: Ming Huang Value of the environment variable FIRMWARE_VER is GIT SHA by default, and you can add the environment variable FIRMWARE_VER to EXTRA_OPTIONS at build time to specify something else, eg. "16.12-". Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang

[edk2] [PATCH edk2-platforms v3 08/11] Hisilicon/D03: Disable the function of PerfTuning

From: Chenhui Sun The PerTuning function is not stable, it will cause the 3008/3108 crash, disable this function first. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chenhui Sun --- Platform/Hisilicon/D03/D03.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[edk2] [PATCH edk2-non-osi v3 6/7] Hisilicon/D05: Update binary file

Fix bug 3061: D05(before EC) boot hangs at "Need Reset"; Update binary file for edk2 upgrade. 1. Replace UncachedMemoryAllocationLib with DmaLib; 2. Remove ArmCpuLib dependenc; 3. Remove ConvertToPhysicalAddress; Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Hu

[edk2] [PATCH edk2-platforms v3 09/11] D05/ACPI: Disable D05 SAS0 and SAS2

From: Ming Huang There are no interface from SAS0 and SAS2 controller on D05, so SAS0 and SAS2 can't be use. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl | 10 ++ 1 file changed, 10 insertio

[edk2] [PATCH edk2-platforms v3 10/11] D05/ACPI: Modify I2C device

From: Ming Huang 1. Disable I2C0 device avoiding access conflict in OS; 2. Modify _HID of I2C2 for matching the string in OS driver; Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05I2c.asl | 20 +-

[edk2] [PATCH edk2-platforms v3 11/11] Hisilicon D03/D05: Enlarge iATU for RP with ARI capable device.

From: Ming Huang 1. Because Hi161x chip doesn't support "ARI Forwarding Enable" function, BIOS will enumerate 32 same devices (Device Number 0~31) when attach a Non-ARI capable device in the RP. Hi161x chip will not fix it, need BIOS patch. 2. Just enlarge iatu for those root port with A

Re: [edk2] SNP transmit print

I think these error prints should be check against Status Regards Udit > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Meenakshi Aggarwal > Sent: Thursday, September 21, 2017 3:36 PM > To: edk2-devel@lists.01.org > Subject: [edk2] SNP trans

Re: [edk2] Shell input redirection question

The shell's pci command was not written to read from standard input. It expects all its input on the command line. I would say in general that if you execute a command and pass it no parameters, and it then prompts you in some way for input, then that command will likely accept input redirected fr

Re: [edk2] [PATCH edk2-platforms v3 00/11] Update D03/D05 binary for edk2 update and bug fix.

All ACPI changes apart from the small comment I had on I2C one Reviewed-by: Graeme Gregory On Thu, Sep 21, 2017 at 06:59:39PM +0800, Heyi Guo wrote: > Code can also be found in github: > https://github.com/hisilicon/OpenPlatformPkg.git > branch: rp-1710-platforms-v3rp-1710-osi-v3 > > Note:

Re: [edk2] [PATCH edk2-platforms v3 00/11] Update D03/D05 binary for edk2 update and bug fix.

On Thu, Sep 21, 2017 at 06:59:39PM +0800, Heyi Guo wrote: > Code can also be found in github: > https://github.com/hisilicon/OpenPlatformPkg.git > branch: rp-1710-platforms-v3rp-1710-osi-v3 This is looking a lot better, thanks. But it could be useful to have a separate cover letter for the edk

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

One small comment, within function PartitionInstallUdfChildHandles(): ... // // Install partition child handle for UDF file system // Status = PartitionInstallChildHandle ( ... ); if (!EFI_ERROR (Status)) { <- Is this a typo? "if (EFI_ERROR (Status)) {" Status = EFI

Re: [edk2] [RFC 0/6] Create central repository for boilerplate configuration

Hi Leif It is good to see such configuration. Here is some of my thought: 1) We have similar idea. But there is one key difference is that we do not use MACRO, but use PCD to control feature selection. For example, we defined gPlatformModuleTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE|BOOLEA

Re: [edk2] [PATCH edk2-non-osi v3 2/7] Hisilicon/D03/Sas: Add SasPlatform

On Thu, Sep 21, 2017 at 06:59:43PM +0800, Heyi Guo wrote: > Install protocol to enable sas port which is using and > transmit base address info of sas port to SasDriverDxe. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang On the whole, I'm OK with this - bu

Re: [edk2] [PATCH edk2-non-osi v3 1/7] Hisilicon/D03/Net: Update Snp driver

On Thu, Sep 21, 2017 at 06:59:40PM +0800, Heyi Guo wrote: > 1. Replace SnpPV660Dxe with SnpPV600Dxe; > 2. Add SnpPlatform: > Install protocol to enable nic port which are using. OK, that sort of explains what it is doing. Let's discuss a bit more during Connect. Two comments below. > Contrib

Re: [edk2] [PATCH edk2-non-osi v3 3/7] Hisilicon/D03: Update binary file

On Thu, Sep 21, 2017 at 06:59:44PM +0800, Heyi Guo wrote: > Update binary file for edk2 upgrade. > 1. Replace UncachedMemoryAllocationLib with DmaLib; > 2. Remove ArmCpuLib dependenc; > 3. Remove ConvertToPhysicalAddress; OK, this is fine for the EDK2 bits, but: > Contributed-under: TianoCore Con

Re: [edk2] [PATCH edk2-non-osi v3 4/7] Hisilicon/D05/Net: Update Snp driver

On Thu, Sep 21, 2017 at 06:59:47PM +0800, Heyi Guo wrote: > 1. Replace SnpPV660Dxe with SnpPV600Dxe; > 2. Add SnpPlatform: > Install protocol to enable nic port which are using. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilico

Re: [edk2] [PATCH edk2-platforms v3 05/11] Hisilicon/PciHostBridgeDxe: Assign BAR resource from PciRegionBase

On Thu, Sep 21, 2017 at 06:59:49PM +0800, Heyi Guo wrote: > Io BAR should be based IoBase and Mem BAR should be based PciRegionBase. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > Silicon/Hisilicon/Drivers/PciHostBrid

Re: [edk2] [PATCH edk2-non-osi v3 6/7] Hisilicon/D05: Update binary file

On Thu, Sep 21, 2017 at 06:59:51PM +0800, Heyi Guo wrote: > Fix bug 3061: D05(before EC) boot hangs at "Need Reset"; > > Update binary file for edk2 upgrade. > 1. Replace UncachedMemoryAllocationLib with DmaLib; > 2. Remove ArmCpuLib dependenc; > 3. Remove ConvertToPhysicalAddress; > > Cont

Re: [edk2] [PATCH edk2-non-osi v3 5/7] Hisilicon/D05/Sas: Add SasPlatform

On Thu, Sep 21, 2017 at 06:59:48PM +0800, Heyi Guo wrote: > Install protocol to enable sas port which is using and > transmit base address info of sas port to SasDriverDxe. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D05/Driv

Re: [edk2] [PATCH edk2-platforms v3 01/11] Hisilicon/D05: Modify dsc and fdf file

On Thu, Sep 21, 2017 at 06:59:41PM +0800, Heyi Guo wrote: > 1. Add Drivers/SasPlatform; > 2. Add Drivers/Net/SnpPlatform; > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D05/D05.dsc | 5 - > Plat

Re: [edk2] [PATCH edk2-platforms v3 02/11] Hisilicon/D03: Modify dsc and fdf file

On Thu, Sep 21, 2017 at 06:59:42PM +0800, Heyi Guo wrote: > 1. Add Drivers/SasPlatform; > 2. Add Drivers/Net/SnpPlatform; > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D03/D03.dsc | 5 - > Platform/Hisilicon/D03/D03.fdf | 5

Re: [edk2] [PATCH edk2-platforms v3 04/11] Hisilicon D03/D05: get firmware version from FIRMWARE_VER

On Thu, Sep 21, 2017 at 06:59:46PM +0800, Heyi Guo wrote: > From: Ming Huang > > Value of the environment variable FIRMWARE_VER is GIT SHA by default, > and you can add the environment variable FIRMWARE_VER to EXTRA_OPTIONS > at build time to specify something else, eg. "16.12-". > > Contributed

Re: [edk2] [PATCH edk2-platforms v3 06/11] Hisilicon/D05/Pcie: fix bug of size definition

On Thu, Sep 21, 2017 at 06:59:50PM +0800, Heyi Guo wrote: > From: huangming > > Fix bug of PcieRegion size definition and IO size definition. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D05/D05

Re: [edk2] [PATCH edk2-platforms v3 07/11] D05/PCIe: Modify PcieRegionBase of secondary chip

On Thu, Sep 21, 2017 at 06:59:52PM +0800, Heyi Guo wrote: > From: huangming > > On D05 PCIe now, 2p NA PCIe2 and 2p NB PCIe0's pci domain addresses are > 0x2000 and 0x3000 based. These addresses overlap with the DDR > memory range 0-1G. In this situation, on the inbound direction, our pci

Re: [edk2] [PATCH edk2-platforms v3 08/11] Hisilicon/D03: Disable the function of PerfTuning

On Thu, Sep 21, 2017 at 06:59:54PM +0800, Heyi Guo wrote: > From: Chenhui Sun > > The PerTuning function is not stable, it will cause the > 3008/3108 crash, disable this function first. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Chenhui Sun I do not see any of

Re: [edk2] Shell input redirection question

If the requirement for PCI to display the information when there are no parameters present, I see no reason that it could not also use a file for input. i.e. "pci" must act according to the spec, but "pci < inputfile" is not prohibited. I think that as no code currently uses PCI with file inpu

Re: [edk2] [PATCH] ShellPkg/dmpstore: Show name of known variable vendor GUID

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, September 20, 2017 10:30 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Li, Huajing > Subject: RE: [PATCH] ShellPkg/dmpstore: Show name of known variable > vendor GUID > Importance: High > > "Var

Re: [edk2] [PATCH edk2-platforms v3 09/11] D05/ACPI: Disable D05 SAS0 and SAS2

On Thu, Sep 21, 2017 at 06:59:55PM +0800, Heyi Guo wrote: > From: Ming Huang Can you ensure all "From: " tags use the proper huawei.com addresses? Signed-off-by below is already correct. Also, since you are sending these patches out, you should also add your "Signed-off-by:" below that of the pat

Re: [edk2] [PATCH edk2-platforms v3 10/11] D05/ACPI: Modify I2C device

On Thu, Sep 21, 2017 at 06:59:56PM +0800, Heyi Guo wrote: > From: Ming Huang From: Ming Huang > 1. Disable I2C0 device avoiding access conflict in OS; > 2. Modify _HID of I2C2 for matching the string in OS driver; > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Min

Re: [edk2] [PATCH edk2-platforms v3 11/11] Hisilicon D03/D05: Enlarge iATU for RP with ARI capable device.

On Thu, Sep 21, 2017 at 06:59:57PM +0800, Heyi Guo wrote: > From: Ming Huang > > 1. Because Hi161x chip doesn't support "ARI Forwarding Enable" >function, BIOS will enumerate 32 same devices (Device Number 0~31) >when attach a Non-ARI capable device in the RP. Hi161x chip will >not fi

Re: [edk2] [RFC 0/6] Create central repository for boilerplate configuration

Something I have found useful is leaving the intended file extension at the end of the file name. That way, you still know it is intended to be "!include"ed, but any editor file extensions you have set up still work on these files. ConfigPkg/Security/Security.dsc.inc => ConfigPkg/Security/Secur

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

On September 21, 2017 5:49:19 AM GMT-03:00, "Zeng, Star" wrote: >VS2015 Build-tested-by: Star Zeng > >I have a minor comment to this patch title, how about to use >"MdeModulePkg/UDF: Fix creation of UDF logical partition" as this patch >is touching both PartitionDxe and UdfDxe? Otherwise, you'

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

On September 21, 2017 9:44:10 AM GMT-03:00, "Wu, Hao A" wrote: >One small comment, within function PartitionInstallUdfChildHandles(): > > ... > // > // Install partition child handle for UDF file system > // > Status = PartitionInstallChildHandle ( >... >); >if (!EFI_ERROR (Status)

Re: [edk2] [PATCH edk2-platforms v3 00/11] Update D03/D05 binary for edk2 update and bug fix.

On 21 September 2017 at 05:40, Leif Lindholm wrote: > On Thu, Sep 21, 2017 at 06:59:39PM +0800, Heyi Guo wrote: >> Code can also be found in github: >> https://github.com/hisilicon/OpenPlatformPkg.git >> branch: rp-1710-platforms-v3rp-1710-osi-v3 > > This is looking a lot better, thanks. > But

Re: [edk2] Shell input redirection question

I think the technicality here is that given "pci < inputfile", no parameters are passed to the pci command, so it should, according to the spec, display all the devices. Another problem may be that in the "pci < inputfile" case, the pci command has no way to know that its input is being redirected

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

Does it have functional impact? Thanks, Star -Original Message- From: Paulo Alcantara [mailto:pca...@zytor.com] Sent: Thursday, September 21, 2017 9:29 PM To: Wu, Hao A ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Laszlo Ersek ; Dong, Eric ; Zeng, Star Subject: RE: [edk2] [PATCH v3 2/2] Md

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

On September 21, 2017 10:47:07 AM GMT-03:00, "Zeng, Star" wrote: >Does it have functional impact? Nope. When Partition driver walks the partition detect routine table, it executes each routine and then checks for EFI_NO_MEDIA and EFI_MEDIA_CHANGED only. So, the child handle is installed and

Re: [edk2] Shell input redirection question

The SHELL_PARAMETERS_PROTOCOL used by the pci command lists both the command line and the StdIn for the command. I think that you could check the StdIn for the file specified and then change the behavior. If we really require a parameter to enable some sort of file input mode, the spec says th

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

On Thu, Sep 21, 2017 at 10:52 AM, Paulo Alcantara wrote: > > > On September 21, 2017 10:47:07 AM GMT-03:00, "Zeng, Star" > wrote: >>Does it have functional impact? > > Nope. When Partition driver walks the partition detect routine table, it > executes each routine and then checks for EFI_NO_MED

Re: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver

On Wed, Sep 20, 2017 at 07:53:36AM +, Wang, Jian J wrote: > Jiewen, > > Yes. The patch has passed the validation of the UEFI booting Windows 10, > Windows 7 and Fedora 25. > > If no comments from you and others, I'll push the patch to upstream soon. > Hi, I think this patch series does no

Re: [edk2] [PATCH 1/5] ArmPkg: Tidy GIC code before changes.

Hi Leif. I agree/accept all the comments, except: > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: 14 September 2017 17:41 > To: Evan Lloyd > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Matteo Carlini ; nd > Subject: Re: [PATCH 1/5] ArmPkg: Tidy GI

[edk2] [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM

From: EvanLloyd This v4 series of patches corrects a problem detected on the ARM Juno platform that is actually generic (at least to ARM GIC platforms). The HardwareInterrupt protocol had no means of handling characteristics like Edge/Level triggered and polarity. A new HardwareInterrupt2 protoc

[edk2] [PATCH 4/4] ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type

From: Ard Biesheuvel Utilise the new HardwareInterrupt2 protocol to adjust the Edge/Level characteristics of the Watchdog interrupt. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Signed-off-by: Girish Pathak Signed-off-by: Evan Lloyd Tested-by: Girish P

[edk2] [PATCH 2/4] EmbeddedPkg: Introduce HardwareInterrupt2 protocol

From: Ard Biesheuvel The existing HardwareInterrupt protocol lacks the means to configure the level/edge and polarity properties of an interrupt. So introduce a new protocol HardwareInterrupt2, and add some new members that allow manipulation of those properties. Contributed-under: TianoCore Con

[edk2] [PATCH 1/4] ArmPkg: Tidy GIC code before changes.

From: Evan Lloyd This change is purely cosmetic, to tidy some code before change. Mods involve: Re-order #includes Reformat comments. Use ns consistently (always "100ns" not sometimes "100 nS") Split overlength code lines. Make protocol functions STATIC. Remove "Horor vacu

[edk2] [PATCH 3/4] ArmPkg/ArmGicDxe: Expose HardwareInterrupt2 protocol

From: Ard Biesheuvel The existing HardwareInterrupt protocol lacked a means to configure the level/edge properties of an interrupt. The new HardwareInterrupt2 protocol introduced this capability. This patch updates the GIC drivers to provide the new interfaces. The changes comprise: Update to

Re: [edk2] [PATCH 1/5] ArmPkg: Tidy GIC code before changes.

On Thu, Sep 21, 2017 at 03:34:07PM +, Evan Lloyd wrote: > Hi Leif. > I agree/accept all the comments, except: > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: 14 September 2017 17:41 > > To: Evan Lloyd > > Cc: edk2-devel@lists.01.org; Ard Bi

Re: [edk2] [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM

On Thu, Sep 21, 2017 at 05:23:40PM +0100, evan.ll...@arm.com wrote: > From: EvanLloyd > > This v4 series of patches corrects a problem detected on the ARM Juno > platform that is actually generic (at least to ARM GIC platforms). > The HardwareInterrupt protocol had no means of handling characteri

Re: [edk2] [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: 21 September 2017 18:56 > To: Evan Lloyd > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Matteo Carlini ; nd ; Arvind > Chauhan ; Daniil Egranov > ; Thomas Panakamattam Abraham > > Subject: Re: [PATCH

[edk2] [PATCH] UefiCpuPkg/SmmCpuFeaturesLib: replace hard-coded machine code

Replace hard-coded machine code with equivalent assembly source code. Change-Id: I44d08276a5f788bf46c5050c14c5257bad6b6199 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chris Ruffin --- .../Library/SmmCpuFeaturesLib/Ia32/SmiEntry.nasm | 24 ++ .../SmmCp

Re: [edk2] [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM

> On Sep 21, 2017, at 11:39 AM, Evan Lloyd wrote: > > > >> -Original Message- >> From: Leif Lindholm [mailto:leif.lindh...@linaro.org >> ] >> Sent: 21 September 2017 18:56 >> To: Evan Lloyd mailto:evan.ll...@arm.com>> >> Cc: edk2-devel@lists.01.org

Re: [edk2] [PATCH v1] MdePkg: Add definitions for the SPI protocols introduced in UEFI PI 1.6.

Good points on the use case. I'll take a look. Thanks again Vincent -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin Häuser Sent: Wednesday, September 20, 2017 2:26 PM To: edk2-devel@lists.01.org Cc: Zimmer, Vincent Subject: Re: [edk2] [PA

Re: [edk2] [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM

Hi Andrew. > From: af...@apple.com [mailto:af...@apple.com] > Sent: 21 September 2017 20:15 > To: Evan Lloyd > Cc: Leif Lindholm ; nd ; Ard > Biesheuvel ; edk2-devel@lists.01.org; Thomas > Panakamattam Abraham ; Arvind Chauhan > > Subject: Re: [edk2] [PATCH 0/4] [PATCH 0/5] Add HardwareInter

[edk2] [PATCH v2 1/2] ArmPlatformPkg: Add PCD for SBSA Watchdog Count

From: Sami Mujawar The Juno and FVP platform implement the SBSA Watchdog timers. Added PcdWatchdogCount to specify the number of Watchdog timers that are available. This allows configurability and an option to disable the watchdog timers if required for testing. Contributed-under: TianoCore Con

[edk2] [PATCH v2 0/2] Use PCD for Watchdog count

From: EvanLloyd Paired patches for edk2 and edk2-platforms that add and use a PCD indicating the number of SBSA Watchdog timers present. This makes things more configurable, and is consistent with other examples of platform characteristics. It may also help with debates over GTDT inclusion (or n

[edk2] [PATCH v2 2/2] [edk2-platforms] Platforms/ARM: SBSA Watchdog PCD and build option

From: Sami Mujawar Added PcdWatchdogCount to specify the number of Watchdog timers that are available on Juno and FVP platform. Also added DISABLE_SBSA_WATCHDOG option to disable the watchdog timers if required for testing. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH] SecurityPkg/SecureBootConfigImpl.c: Secure Boot DBX UI Enhancement.

Use 2-level format to display signature list and signature data. Support batch delete operation to delete signature list or signature data. Display more useful information for each signature data. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chen A Chen Cc: Zhang Chao B

Re: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver

Thanks for catching it. Patch is on the way. -Original Message- From: Anthony PERARD [mailto:anthony.per...@citrix.com] Sent: Thursday, September 21, 2017 11:05 PM To: Wang, Jian J Cc: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Michael D ; Laszlo Ersek ; Dong, Eric ; Zeng, Star Su

Re: [edk2] Shell input redirection question

Hi, All: Thanks for your suggestions. Appreciate it. Thanks best wishes, -邮件原件- 发件人: Carsey, Jaben [mailto:jaben.car...@intel.com] 发送时间: 2017年9月21日 22:13 收件人: jim.dai...@dell.com 抄送: edk2-devel@lists.01.org; Tiger Liu 主题: RE: [edk2] Shell input redirection question The SHELL_PARAMETERS_P

Re: [edk2] [PATCH] SecurityPkg/SecureBootConfigImpl.c: Secure Boot DBX UI Enhancement.

Reviewed-by: Chao Zhang -Original Message- From: Chen, Chen A Sent: Friday, September 22, 2017 9:07 AM To: edk2-devel@lists.01.org Cc: Chen, Chen A ; Zhang, Chao B ; Long, Qin Subject: [PATCH] SecurityPkg/SecureBootConfigImpl.c: Secure Boot DBX UI Enhancement. Use 2-level format to d

[edk2] [patch] MdeModulePkg/SetupBrowser:Add NULL check before using a pointer

Add NULL pointer check before using a pointer to avoid possible NULL pointer dereference. Cc: Eric Dong Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 10 +- 1 file changed, 5 insertions(+

Re: [edk2] [PATCH V5] MdeModulePkg/DxeCore: Fixed Interface returned by CoreOpenProtocol

Thanks all. The patch has been pushed at 89f7f2cdf0266619976cb53b45b5de1aba2f8fac. Star -Original Message- From: Zeng, Star Sent: Tuesday, September 19, 2017 3:14 PM To: Laszlo Ersek ; edk2-devel@lists.01.org Cc: Amit Kumar ; Kinney, Michael D ; Gao, Liming ; Gabriel Somlo ; Zeng, Star

[edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153

Cc: Hao Wu Cc: Anthony PERARD Suggested-by: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c b/UefiCpuP

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

Ok, I will go to help push the patch series if Ray has no any comments. Thanks, Star -Original Message- From: Paulo Alcantara [mailto:pca...@gmail.com] Sent: Thursday, September 21, 2017 10:17 PM To: Zeng, Star ; Wu, Hao A ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Laszlo Ersek ; Dong, E

Re: [edk2] [PATCH v3 1/2] MdePkg: Add UDF volume structure definitions

Paulo, Comments below: #define UDF_TAG_ID(_Tag) \ (UDF_VOLUME_DESCRIPTOR_ID)((_Tag)->TagIdentifier) 1. I prefer to remove the UDF_TAG_ID macro. Adding type-cast to get TAG_ID is very straightforward. #define UDF_LVD_REVISION(_Lv) \ *(UINT16 *)(UINTN)(_Lv)->DomainIdentifier.IdentifierSuffix

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

Paulo, Are you ok to the macro related comments I provided to patch V3.#1? If yes, could you please update the patch V3.#2 accordingly? I noticed that you put some structures that seem to be UDF standard into the UdfDxe driver local header file. I am ok with your decision. For public interfaces, n

Re: [edk2] [PATCH edk2-platforms v3 00/11] Update D03/D05 binary for edk2 update and bug fix.

Sorry we didn't catch up the community updates for several months... Actually this is a really good change for ARM MMIO controllers and we appreciate your patches to improve D0x platforms. There may be some minor issue (or even in SoC IP) that causes D05 into exception, which was just found wh

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153

One minor comment, please shorten the subject of the patch. Maybe like: UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54 With that change, Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Wang, Jian J > Sent: Friday, September 22, 2017 10:15 AM > To: edk2-

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153

Ok, thanks for the review. -Original Message- From: Wu, Hao A Sent: Friday, September 22, 2017 11:21 AM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Anthony PERARD Subject: RE: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153 One minor

[edk2] [PATCH 1/3] IntelSiliconPkg/VTdDxe: Clean up DXE flush memory.

Make sure the context table are flush to memory. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- IntelSiliconPkg/Feature/VTd/IntelVTdDxe/TranslationTable.c | 9 +++-- IntelSiliconPkg/Feature/VTd/IntelVTdDxe/TranslationTableEx.c | 4 ++--

[edk2] [PATCH 0/3] IntelVTd fix

1) Make sure context cache in VTdDxe is flushed in every path. 2) Clarify VTdPolicy PCD usage for PEI and DXE. 3) Add EndOfPei callback in VTdPrmPei for S3 resume. The patch is tested in Intel Kabylake platform. Windows 10 boot and S3 resume success with VTd enabled. Cc: Star Zeng Contributed-un

[edk2] [PATCH 3/3] IntelSiliconPkg/VTdPmrPei: Add EndOfPei callback for S3

In S3 resume, before system transfer to waking vector, the VTdPrm need turn off VTd protection based upon VTdPolicy. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- IntelSiliconPkg/Feature/VTd/IntelVTdPmrPei/IntelVTdPmrPei.c | 59 ++

[edk2] [PATCH 2/3] IntelSiliconPkg/dec: Clarify VTdPolicy.

Clarify the VTdPolicy is for both PEI and DXE. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- IntelSiliconPkg/IntelSiliconPkg.dec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec b/I

Re: [edk2] [patch] MdeModulePkg/SetupBrowser:Add NULL check before using a pointer

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Bi, Dandan > Sent: Friday, September 22, 2017 9:57 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Wu, Hao A > Subject: [patch] MdeModulePkg/SetupBrowser:Add NULL check before using a > pointer > > Add NULL point

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153

After altering the commit logs, push at: 96207191fd715e268c6ba6d6ac8650ef914e1686 Best Regards, Hao Wu > -Original Message- > From: Wang, Jian J > Sent: Friday, September 22, 2017 11:34 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Anthony PERARD > Subject: RE: [PATCH] UefiCpuPkg/Cp

Re: [edk2] [PATCH 3/3] IntelSiliconPkg/VTdPmrPei: Add EndOfPei callback for S3

Is the code comment correct? + // + // Register EndOfPei Notify for S3 to run FSP NotifyPhase + // Should the "VTdPrm" be "VTdPmr"? If checking the bootmode in entrypoint, should add gEfiPeiMasterBootModePpiGuid in the depex or not? Thanks, Star -Original Message- From: Yao, Jiewen

Re: [edk2] [PATCH 3/3] IntelSiliconPkg/VTdPmrPei: Add EndOfPei callback for S3

Good catch. Typo. It should be VTdPmr. Yes, we need add gEfiPeiMasterBootModePpiGuid - that is very good suggestion. Thank you Yao Jiewen > -Original Message- > From: Zeng, Star > Sent: Friday, September 22, 2017 12:22 PM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Cc: Zeng, Star > Su

Re: [edk2] [PATCH 3/3] IntelSiliconPkg/VTdPmrPei: Add EndOfPei callback for S3

With that updated, Reviewed-by: Star Zeng to this patch series. Thanks, Star -Original Message- From: Yao, Jiewen Sent: Friday, September 22, 2017 12:42 PM To: Zeng, Star ; edk2-devel@lists.01.org Subject: RE: [PATCH 3/3] IntelSiliconPkg/VTdPmrPei: Add EndOfPei callback for S3 Good cat

  1   2   >