Re: [edk2] [PATCH v2 1/2] MdeModulePkg: introduce SD/MMC override protocol

If making this protocol a platform level singleton instance, is it so hard to define the interfaces and parameters since different controllers may need different hook points and parameters? Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Tuesday, December 5, 2017 3:09 PM To: Ard

Re: [edk2] [PATCH v2 1/2] MdeModulePkg: introduce SD/MMC override protocol

On 11/30/2017 6:11 PM, Ard Biesheuvel wrote: Many ARM based SoCs have integrated SDHCI controllers, and often, these implementations deviate in subtle ways from the pertinent specifications. On the one hand, these deviations are quite easy to work around, but on the other hand, having a

Re: [edk2] [Patch] NetworkPkg: Update IScsiDxe to pass XCODE build

Reviewed-by: Jiaxin Wu Thanks, Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Tuesday, November 28, 2017 11:19 AM > To: edk2-devel@lists.01.org > Cc: Liang, Vincent

[edk2] [Patch 4/4] NetworkPkg/DnsDxe: Avoid to access the freed memory buffer.

The HostNameToIp() is a asynchronous function, so the caller may free the HostName buffer immediately once HostNameToIp() is returned. Then DNS driver may access the freed memory buffer later. This patch is to fix above issue. Cc: Ye Ting Cc: Fu Siyuan

[edk2] [Patch 1/4] NetworkPkg/DnsDxe: Remove the unnecessary if condition check in DNS.Config

Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/DnsDxe/DnsProtocol.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2] [Patch 2/4] NetworkPkg/DnsDxe: Update RetryCount/RetryInterval to comply with UEFI spec.

According to UEFI spec: "Retry number if no response received after RetryInterval. If zero, use the parameter configured through Dns.Configure() interface." "Minimum interval of retry is 2 second. If the retry interval is less than 2 second, then use the 2 second. If zero, use the parameter

[edk2] [Patch 0/4] NetworkPkg/DnsDxe: Fix several issues in DnsDxe driver.

Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Jiaxin Wu (4): NetworkPkg/DnsDxe: Remove the unnecessary if condition check in DNS.Config

[edk2] [Patch 3/4] NetworkPkg/DnsDxe: Fix the potential memory leak issue.

Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/DnsDxe/DnsImpl.c | 131 1 file

Re: [edk2] [PATCH v3 00/11] Implement stack guard feature

Jiewen, Thanks for the comments. 1) It's only used for Ex version of the API so I added Ex. But I don't have strong opinion on the name. 2) Do you mean we need to use separate the definition for IA32 and X64 even they share the same data? 3) Sure. 4) I'm not sure if it's necessary. But a

Re: [edk2] [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'

Reviewed-by: Liming Gao > -Original Message- > From: Wu, Hao A > Sent: Tuesday, December 5, 2017 1:18 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Gao, Liming ; Ni, > Ruiyu ; Zeng, Star >

Re: [edk2] [PATCH v2 0/4] Enable page table write protection

I haven't got time to do it in automatic way. V1 may need a shell app to check it, but current implementation might not need it because we now have 2 or 3 continuous 2MB pages to hold all page tables. We just need to verify the page attribute of those 2 or 3 page tables. It's easy to do it in a

[edk2] [Patch] MdeModulePkg/TcpIoLib: Cancel TCP token if connect/accept is timeout.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan Cc: Wu Jiaxin Cc: Ye Ting --- MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff

[edk2] [Patch] MdeModulePkg/TcpIoLib: Check input Timeout before calling CheckEvent() service.

For TcpIoConnect() and TcpIoAccept(), this patch adds the check for Timeout event before calling CheckEvent() service so as to avoid the unnecessary function call. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan Cc: Wu Jiaxin

Re: [edk2] [PATCH v2 0/4] Enable page table write protection

It's for sharing the pool between the DxeIpl and CpuDxe. If we don't care about wasting a little bit memory, it's ok to drop this definition. CpuDxe can reserve a block of memory for page table for its own uses. > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, December 05, 2017

[edk2] [platforms: PATCH v3 4/4] Marvell/Drivers: MvPhyDxe: Cleanup the header

This patch removes unused macros defined in MvPhyDxe.h, as well as improves the style and comments. Pick single definition of the autonegotiation timeout - two different macros were used for the same purpose. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2] [platforms: PATCH v3 1/4] Marvell/Armada: Switch to dynamic tftp command

After removal of the tftp library in EDK2, the tftp was disabled on Armada platform. Re-enable this functionality as a dynamic command on Armada 70x0 DB board. For this purpose add it as an option, depending on a new INCLUDE_TFTP_COMMAND parameter, which can be passed in the command line during

[edk2] [platforms: PATCH v3 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information

fupdate command's usage information referred to a deprecated '-f' flag in 'examples' section. It was a residue from the initial version of the application, removed during review before merging to upstream branch. Correct the help information and also on the occasion improve the message and its

[edk2] [platforms: PATCH v3 2/4] Marvell/Armada: Fix watchdog control base

Proper watchdog control base is 0xf061, so fix the incorrect value. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Platform/Marvell/Armada/Armada.dsc.inc | 2 +- 1 file

[edk2] [platforms: PATCH v3 0/4] Armada 7k/8k - misc improvements pt.3

Hi, The third version of the patchset brings the corrections requested in the review. Details can be found in the changelog below. The patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/misc-upstream-r20171205 I'm looking forward to your

Re: [edk2] [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Tuesday, December 5, 2017 1:18 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Dong, Eric ; Wu, Hao A

[edk2] [PATCH 2/2] MdeModulePkg/DisplayEngineDxe: Remove unnecessary parentheses in 'if'

This commit removes unnecessary parentheses in 'if' statements to resolve the build failures by the XCODE5 tool chain. Cc: Liming Gao Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH 1/2] MdeModulePkg/PartitionDxe: Remove unnecessary parentheses in 'if'

This commit removes unnecessary parentheses in 'if' statements to resolve the build failures by the XCODE5 tool chain. Cc: Liming Gao Cc: Ruiyu Ni Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore

[edk2] [PATCH 0/2] MdeModulePkg: Remove unnecessary parentheses in 'if'

The series removes unnecessary parentheses in 'if' statements. Cc: Liming Gao Cc: Ruiyu Ni Cc: Star Zeng Cc: Eric Dong Cc: Dandan Bi Hao Wu (2): MdeModulePkg/PartitionDxe: Remove

Re: [edk2] [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver

> I suggest return EFI_UNSUPPORTED for this case. The protocol implementation > could return its status besides spec defined status. Thanks to help me , how core will treat this error 1/ Wdt not available 2/ ignoring this error 3/ core is not registering handler I guess 3 is valid, On

Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe: log informative memprotect msgs at DEBUG_INFO level

Reviewed-by: Star Zeng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, December 5, 2017 3:48 AM To: edk2-devel-01 Cc: Ard Biesheuvel ; Dong, Eric ; Yao, Jiewen

Re: [edk2] [PATCH v2 0/4] Enable page table write protection

Hi Jian In V1 review, I suggest to test in UEFI shell env to make sure all page table is read only, with PageTable split in CPU driver. May I know if that is done? Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J

Re: [edk2] [PATCH v2 0/4] Enable page table write protection

I do not suggest we define PAGE_TABLE_POOL_HEADER. If we can figure out other way, that will be better. Thank you Yao Jiewen > -Original Message- > From: Wang, Jian J > Sent: Monday, December 4, 2017 5:26 PM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Yao,

Re: [edk2] [PATCH v2 0/2] quirks handling for SDHCI controllers

Include Ruiyu and Mike. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Monday, December 4, 2017 10:53 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng ; Zeng,

Re: [edk2] [PATCH v3 00/11] Implement stack guard feature

Good enhancement. I think it resolved my compatibility concern for the old API. Some comment: 1) Can we just use CPU_EXCEPTION_INIT_DATA instead of CPU_EXCEPTION_INIT_DATA_EX? I am not sure why we add _EX here. 2) Is CPU_EXCEPTION_INIT_DATA_EX for IA32 only or both IA32/X64? I found "Ia32"

Re: [edk2] [PATCH v2] MdeModulePkg/NvmExpressDxe: fix error status override

Thanks Hao :) 在 12/5/2017 8:29 AM, Wu, Hao A 写道: Pushed at 9a77210b43ef34af52ea7285fadc0ce5779306fe. Best Regards, Hao Wu -Original Message- From: Zeng, Star Sent: Monday, December 04, 2017 1:54 PM To: Wu, Hao A; Heyi Guo; linaro-u...@lists.linaro.org; edk2-devel@lists.01.org Cc:

Re: [edk2] [PATCH] MdeModulePkg CapsulePei: Sort and merge memory resource entries

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Monday, December 4, 2017 6:01 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Chiu, Chasel ; Chiang, Dakota >

Re: [edk2] [PATCH v2] MdeModulePkg/NvmExpressDxe: fix error status override

Pushed at 9a77210b43ef34af52ea7285fadc0ce5779306fe. Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Monday, December 04, 2017 1:54 PM > To: Wu, Hao A; Heyi Guo; linaro-u...@lists.linaro.org; edk2-devel@lists.01.org > Cc: Dong, Eric; Ni, Ruiyu; Zeng, Star > Subject:

Re: [edk2] [PATCH v3 07/11] ArmPkg/ArmExceptionLib: Add implementation of new API

Sure. Thanks for the feedback. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, December 04, 2017 9:59 PM > To: Wang, Jian J > Cc: edk2-devel@lists.01.org; Leif Lindholm ; Yao, > Jiewen

[edk2] [PATCH v2 13/13] ArmPlatformPkg: remove unused SP804 driver and TimerLib implementation

None of the platforms we support use these so remove them. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by-if-no-comments-by-15-Dec: Leif Lindholm --- ArmPlatformPkg/ArmPlatformPkg.dec

[edk2] [PATCH v2 10/13] ArmPlatformPkg: remove PL34xDmc driver

Remove PL34xDmc driver which is not used by any platforms Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by-if-no-comments-by-15-Dec: Leif Lindholm ---

[edk2] [PATCH v2 05/13] ArmPlatformPkg: remove old PL011UartLib implementation

Remove the PL011UartLib implementation that has been superseded by the one under Library/ Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/Drivers/PL011Uart/PL011Uart.c | 470

[edk2] [PATCH v2 02/13] ArmPlatformPkg: remove ArmVExpressPkg

Remove ArmVExpressPkg from EDK2 now that its contents have moved into edk2-platforms/Platform/ARM where they belong. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmFvpDxe.c

[edk2] [PATCH v2 08/13] ArmPlatformPkg: remove unused PL301Axi driver

No platforms use this driver so remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by-if-no-comments-by-15-Dec: Leif Lindholm --- ArmPlatformPkg/Drivers/PL301Axi/PL301Axi.c | 108

[edk2] [PATCH v2 11/13] ArmPlatformPkg: remove unused PL310 driver

This driver is not used by any platforms so remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by-if-no-comments-by-15-Dec: Leif Lindholm ---

[edk2] [PATCH v2 12/13] ArmPlatformPkg: remove unused ArmTrustZone driver

This driver is no longer used anywhere so remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by-if-no-comments-by-15-Dec: Leif Lindholm ---

[edk2] [PATCH v2 06/13] ArmPlatformPkg: add missing library class declarations to .dec file

Add ArmPlatformLib, LcdPlatformlib and NorFlashPlatformLib to the [LibraryClasses] section of ArmPlatformPkg.dec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmPlatformPkg.dec | 3 +++ 1 file changed, 3

[edk2] [PATCH v2 03/13] ArmPlatformPkg: remove ArmPlatformSysConfigLib library class

The only remaining user of ArmPlatformSysConfigLib has absorbed this definition into its own edk2-platforms package, so let's remove it from the shared code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif

[edk2] [PATCH v2 01/13] ArmPlatformPkg: remove NorFlashArmVExpressLib

Remove NorFlashArmVExpressLib now that it has been moved into edk2-platforms where it belongs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm ---

[edk2] [PATCH v2 07/13] ArmPlatformPkg/LcdGraphicsOutputDxe: move headers into driver directory

The HdLcd.h and PL111Lcd.h header files are internal headers that should not be used by other drivers. So move them from Include/Drivers into the driver directory instead. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH v2 00/13] ArmPlatformPkg: remove unused or migrated modules

Remove everything from ArmPlatformPkg that is either unused, or so highly specific to development platforms manufactured by ARM Ltd. that they really don't belong in the main branch. Note that the migration involves patches against edk2-platforms that add some of this code back under

[edk2] [PATCH v2 09/13] ArmPlatformPkg: remove unused PL35x driver

No platform uses this so remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by-if-no-comments-by-15-Dec: Leif Lindholm --- ArmPlatformPkg/Drivers/PL35xSmc/InitializeSMC.S | 60

[edk2] [PATCH v3 edk2-platforms 0/2] Move ArmPlatformPkg stuff into edk2-platforms

This v3 series contains the remaining patches that move drivers and other code that is highly specific to ARM Ltd. Versatile Express platforms into edk2-platforms, hopefully making the line between generic drivers for ARM IP and VExpress boards incorporating it less blurry. The most notable

Re: [edk2] [PATCH] ArmPlatformPkg/LcdGraphicsOutputDxe: remove VExpressPkg dependency

On 4 December 2017 at 21:34, Leif Lindholm wrote: > On Mon, Dec 04, 2017 at 08:50:52PM +, Ard Biesheuvel wrote: >> The two instantiations of LcdGraphicsOutputDxe reference VExpressPkg.dec >> without actually relying on anything it defines. In preparation of >> moving

Re: [edk2] [PATCH] ArmPlatformPkg/LcdGraphicsOutputDxe: remove VExpressPkg dependency

On Mon, Dec 04, 2017 at 08:50:52PM +, Ard Biesheuvel wrote: > The two instantiations of LcdGraphicsOutputDxe reference VExpressPkg.dec > without actually relying on anything it defines. In preparation of > moving out VExpressPkg into edk2-platforms, drop these references so we > can keep

[edk2] [PATCH] ArmPlatformPkg/LcdGraphicsOutputDxe: remove VExpressPkg dependency

The two instantiations of LcdGraphicsOutputDxe reference VExpressPkg.dec without actually relying on anything it defines. In preparation of moving out VExpressPkg into edk2-platforms, drop these references so we can keep LcdGraphicsOutputDxe in EDK2. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe: log informative memprotect msgs at DEBUG_INFO level

On 4 December 2017 at 19:47, Laszlo Ersek wrote: > In commit 7eb927db3e25 ("MdeModulePkg/DxeCore: implement memory protection > policy", 2017-02-24), we added two informative messages with the > InitializeDxeNxMemoryProtectionPolicy() function: > >>

[edk2] [PATCH] MdeModulePkg/Core/Dxe: log informative memprotect msgs at DEBUG_INFO level

In commit 7eb927db3e25 ("MdeModulePkg/DxeCore: implement memory protection policy", 2017-02-24), we added two informative messages with the InitializeDxeNxMemoryProtectionPolicy() function: > InitializeDxeNxMemoryProtectionPolicy: applying strict permissions to > active memory regions and >

Re: [edk2] [PATCH 3/6] MdePkg/Library/BaseLib: Enable VS2017/ARM builds

On 2017.12.04 15:40, Gao, Liming wrote: Pete: Why override compiler option /GL- here? I carried this /GL- override from an earlier patch, as I was initially experiencing breakage when trying to compile some drivers without it during linking. However, I have now re-tested without this

Re: [edk2] [PATCH 6/6] BaseTools/Conf: Add VS2017/ARM support

On 2017.12.04 15:48, Gao, Liming wrote: 1. You add new build for ARM. I remember the reason is that --convert-hex can't be used by trim for ARM ASM file. Right? That is correct. Maybe there's a better option to achieve just that, as duplicating the whole section just to remove an option

Re: [edk2] [PATCH 1/6] MdePkg: Disable some Level 4 warnings for VS2017/ARM

Hi Liming, Thanks for reviewing these patches. As explained in the git comment, I chose to disable warnings that I saw being generated more than 5 times during QEMU compilation, as I suspect we may inherit things from gcc that we may not want to spend too much time changing, just to keep

Re: [edk2] [PATCH edk2-platforms 2/2] Platform/Hisilicon: fix conditional inclusion of tftp shell command

On Mon, Dec 04, 2017 at 05:17:15PM +, Leif Lindholm wrote: > On Mon, Dec 04, 2017 at 05:15:35PM +, Ard Biesheuvel wrote: > > On 4 December 2017 at 17:13, Leif Lindholm wrote: > > > D02, D03 and D05 all have nice conditional clauses to only include > > > the

Re: [edk2] [PATCH edk2-platforms 2/2] Platform/Hisilicon: fix conditional inclusion of tftp shell command

On 4 December 2017 at 17:17, Leif Lindholm wrote: > On Mon, Dec 04, 2017 at 05:15:35PM +, Ard Biesheuvel wrote: >> On 4 December 2017 at 17:13, Leif Lindholm wrote: >> > D02, D03 and D05 all have nice conditional clauses to only include >>

Re: [edk2] [PATCH 00/19] ArmPlatformPkg: remove unused or migrated modules

On Sat, Nov 25, 2017 at 11:47:39AM +, Leif Lindholm wrote: > On Wed, Nov 15, 2017 at 04:56:18PM +, Ard Biesheuvel wrote: > > Remove everything from ArmPlatformPkg that is either unused, or so highly > > specific to development platforms manufactured by ARM Ltd. that they really > > don't

Re: [edk2] [PATCH edk2-platforms v2 00/13] Move ArmPlatformPkg stuff into edk2-platforms

On Sat, Nov 25, 2017 at 12:12:45PM +, Leif Lindholm wrote: > On Thu, Nov 16, 2017 at 05:58:30PM +, Ard Biesheuvel wrote: > > This is mostly a preparatory series that will allow us to get rid of a lot > > of code that is specific to only a single ARM development platform out of > > the main

Re: [edk2] [PATCH] ArmPlatformPkg: remove PlatformIntelBdsLib

On 4 December 2017 at 16:51, Leif Lindholm wrote: > On Mon, Dec 04, 2017 at 04:16:57PM +, Ard Biesheuvel wrote: >> Now that the last user has switched to the generic BDS, the >> PlatformIntelBdsLib code in ArmPlatformPkg is no longer used, so >> remove it. >> >>

Re: [edk2] [PATCH edk2-platforms 2/2] Platform/Hisilicon: fix conditional inclusion of tftp shell command

On Mon, Dec 04, 2017 at 05:15:35PM +, Ard Biesheuvel wrote: > On 4 December 2017 at 17:13, Leif Lindholm wrote: > > D02, D03 and D05 all have nice conditional clauses to only include > > the non-standard tftp shell command ifdef(INCLUDE_TFTP_COMMAND). > > > >

Re: [edk2] [PATCH edk2-platforms 2/2] Platform/Hisilicon: fix conditional inclusion of tftp shell command

On 4 December 2017 at 17:13, Leif Lindholm wrote: > D02, D03 and D05 all have nice conditional clauses to only include > the non-standard tftp shell command ifdef(INCLUDE_TFTP_COMMAND). > > Unfortunately, they all explicitly set DEFINE INCLUDE_TFTP_COMMAND=1 in > their

Re: [edk2] [PATCH edk2-platforms 1/2] Platform/Hisilicon: fix D05 .dsc line endings

On 4 December 2017 at 17:13, Leif Lindholm wrote: > Commit b324d85a466b, > ("Hisilicon D03/D05: get firmware version from FIRMWARE_VER"), > added some non CRLF line endings, resolve this. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif

[edk2] [PATCH edk2-platforms 1/2] Platform/Hisilicon: fix D05 .dsc line endings

Commit b324d85a466b, ("Hisilicon D03/D05: get firmware version from FIRMWARE_VER"), added some non CRLF line endings, resolve this. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- Platform/Hisilicon/D05/D05.dsc | 8 1

[edk2] [PATCH edk2-platforms 2/2] Platform/Hisilicon: fix conditional inclusion of tftp shell command

D02, D03 and D05 all have nice conditional clauses to only include the non-standard tftp shell command ifdef(INCLUDE_TFTP_COMMAND). Unfortunately, they all explicitly set DEFINE INCLUDE_TFTP_COMMAND=1 in their platform description files, meaning there is no way to exclude the command without an

Re: [edk2] [PATCH] ArmPlatformPkg: remove PlatformIntelBdsLib

On Mon, Dec 04, 2017 at 04:16:57PM +, Ard Biesheuvel wrote: > Now that the last user has switched to the generic BDS, the > PlatformIntelBdsLib code in ArmPlatformPkg is no longer used, so > remove it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [platforms: PATCH v2 4/4] Marvell/Drivers: MvPhyDxe: Cleanup the header

2017-12-04 17:10 GMT+01:00 Leif Lindholm : > On Mon, Dec 04, 2017 at 04:22:33PM +0100, Marcin Wojtas wrote: >> Hi Leif, >> >> >> >> 2017-12-04 15:00 GMT+01:00 Leif Lindholm : >> > On Fri, Dec 01, 2017 at 04:35:07PM +0100, Marcin Wojtas wrote: >>

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

Sounds good. Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, December 4, 2017 7:54 AM > To: Kinney, Michael D > Cc: Udit Kumar ; Meenakshi Aggarwal > ; Varun

[edk2] [PATCH] ArmPlatformPkg: remove PlatformIntelBdsLib

Now that the last user has switched to the generic BDS, the PlatformIntelBdsLib code in ArmPlatformPkg is no longer used, so remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS

On 1 December 2017 at 10:08, Laszlo Ersek wrote: > On 11/30/17 21:31, Ard Biesheuvel wrote: >> ArmVirtXen is the only remaining consumer of ArmPlatformPkg's >> PlatformIntelBdsLib implementation, which is tightly coupled to the >> deprecated Intel BDS. So move ArmVirtXen to the

Re: [edk2] [platforms: PATCH v2 4/4] Marvell/Drivers: MvPhyDxe: Cleanup the header

On Mon, Dec 04, 2017 at 04:22:33PM +0100, Marcin Wojtas wrote: > Hi Leif, > > > > 2017-12-04 15:00 GMT+01:00 Leif Lindholm : > > On Fri, Dec 01, 2017 at 04:35:07PM +0100, Marcin Wojtas wrote: > >> This patch removes unused macros defined in MvPhyDxe.h, as well > >> as

Re: [edk2] [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS

On 4 December 2017 at 16:08, Julien Grall wrote: > Hi Ard, > > On 04/12/17 15:55, Ard Biesheuvel wrote: >> >> On 4 December 2017 at 15:52, Ard Biesheuvel >> wrote: >>> >>> On 4 December 2017 at 15:19, Julien Grall >>>

Re: [edk2] [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS

Hi Ard, On 04/12/17 15:55, Ard Biesheuvel wrote: On 4 December 2017 at 15:52, Ard Biesheuvel wrote: On 4 December 2017 at 15:19, Julien Grall wrote: On 30/11/17 20:31, Ard Biesheuvel wrote: Hmm, looking again, what you tried should

Re: [edk2] [RFC v1 00/15] *** Proposal for StandaloneMmPkg ***

Thank you for reviewing it. I agree with all your comments. I will work on them and send the patch set out on the mailing list sometime in the first week of Jan. Supreeth -Original Message- From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Monday, December 4, 2017 12:36 AM To:

Re: [edk2] [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS

On 4 December 2017 at 15:52, Ard Biesheuvel wrote: > On 4 December 2017 at 15:19, Julien Grall wrote: >> Hi Ard, >> >> On 30/11/17 20:31, Ard Biesheuvel wrote: >>> ArmVirtXen is the only remaining consumer of ArmPlatformPkg's >>>

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

Hi Mike, This separate library would only be necessary specifically because an additional library to the default platform IoLib was needed. So while it's another dependency, it would likely reduce image size. Which is why I was leaning towards a wrapper. This also means the actual hw-dependent

Re: [edk2] [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS

On 4 December 2017 at 15:19, Julien Grall wrote: > Hi Ard, > > On 30/11/17 20:31, Ard Biesheuvel wrote: >> ArmVirtXen is the only remaining consumer of ArmPlatformPkg's >> PlatformIntelBdsLib implementation, which is tightly coupled to the >> deprecated Intel BDS. So move

Re: [edk2] [PATCH 6/6] BaseTools/Conf: Add VS2017/ARM support

Pete: 1. You add new build for ARM. I remember the reason is that --convert-hex can't be used by trim for ARM ASM file. Right? 2. On tools_def.txt. Why introduce /D_ARM_WINAPI_PARTITION_DESKTOP_SDK_AVAILABLE option? Thanks Liming > -Original Message- > From: Pete Batard

Re: [edk2] [PATCH] [edk2 EmbeddedPkg]:Adding secure boot and HTTP image download (Disaster recovery image) Applications for Linux based platforms

sure Leif , we will address your review comments and send updated patches. Regards, kalyan. On 4 December 2017 at 21:03, Leif Lindholm wrote: > Hi Kalyan, > > Am I right in assuming that since this is the output of your team, you > have some time to look into

Re: [edk2] [PATCH 3/6] MdePkg/Library/BaseLib: Enable VS2017/ARM builds

Pete: Why override compiler option /GL- here? > -Original Message- > From: Pete Batard [mailto:p...@akeo.ie] > Sent: Monday, December 4, 2017 9:12 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [PATCH 3/6] MdePkg/Library/BaseLib: Enable VS2017/ARM

Re: [edk2] [PATCH 1/6] MdePkg: Disable some Level 4 warnings for VS2017/ARM

Pete: I suggest to align the disabled warning list to IA32/X64 arch. I find someone are not listed in IA32/X64 arch. Could you give the more detail on why disable them by default? Thanks Liming > -Original Message- > From: Pete Batard [mailto:p...@akeo.ie] > Sent: Monday, December 4,

Re: [edk2] [PATCH] [edk2 EmbeddedPkg]:Adding secure boot and HTTP image download (Disaster recovery image) Applications for Linux based platforms

Hi Kalyan, Am I right in assuming that since this is the output of your team, you have some time to look into reworking based on feedback (unlike the HiKey support)? A few high-level comments: 1) Please generate your patches with --stat=1000 --stat-graph-width=20 as per

Re: [edk2] Enabling boot menu via serial & PXE boot in CorebootPayloadPkg

Hi Benjamin, >Hi Cameron, > >> >I get serial output from edk2 with the release build and the debug build. >> >However this serial output does not include the boot menu, I just get >> >progress and error codes (and debug messages in debug mode). >> >I have attached a runtime log of a recent debug

Re: [edk2] [platforms: PATCH v2 4/4] Marvell/Drivers: MvPhyDxe: Cleanup the header

Hi Leif, 2017-12-04 15:00 GMT+01:00 Leif Lindholm : > On Fri, Dec 01, 2017 at 04:35:07PM +0100, Marcin Wojtas wrote: >> This patch removes unused macros defined in MvPhyDxe.h, as well >> as improves the style and comments. Pick single definition >> of the

Re: [edk2] [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS

Hi Ard, On 30/11/17 20:31, Ard Biesheuvel wrote: > ArmVirtXen is the only remaining consumer of ArmPlatformPkg's > PlatformIntelBdsLib implementation, which is tightly coupled to the > deprecated Intel BDS. So move ArmVirtXen to the generic BDS as well, > allowing us to get rid of

Re: [edk2] [platforms: PATCH v2 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information

2017-12-04 14:52 GMT+01:00 Leif Lindholm : > On Fri, Dec 01, 2017 at 04:35:06PM +0100, Marcin Wojtas wrote: >> fupdate command's usage information referred to a deprecated >> '-f' flag in 'examples' section. It was a residue from the >> initial version of the application,

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacerI2CDxe: add missing __FUNCTION__ argument to %a specifier

On 4 December 2017 at 14:48, Leif Lindholm wrote: > On Mon, Dec 04, 2017 at 01:33:08PM +, Ard Biesheuvel wrote: >> The I2C driver prints a warning under DEBUG when a I2C transaction times >> out. This will occur on the rev 0.1 DeveloperBox boards due to a board >>

Re: [edk2] [PATCH v2 0/2] quirks handling for SDHCI controllers

On 30 November 2017 at 10:11, Ard Biesheuvel wrote: > Many SDHCI implementations exist that are almost spec complicant, and > could be driven by the generic SD/MMC host controller driver except > for some minimal necessary init time tweaks. > > Adding such tweaks to the

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacerI2CDxe: add missing __FUNCTION__ argument to %a specifier

On Mon, Dec 04, 2017 at 01:33:08PM +, Ard Biesheuvel wrote: > The I2C driver prints a warning under DEBUG when a I2C transaction times > out. This will occur on the rev 0.1 DeveloperBox boards due to a board > level error in the I2C routing (unless the MCU has been lifted off the > bus). > >

Re: [edk2] [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver

Mike, Liming, as MdePkg mainteiners - one question below: On Mon, Nov 27, 2017 at 04:21:50PM +0530, Meenakshi Aggarwal wrote: > diff --git a/Platform/NXP/Drivers/WatchDog/WatchDog.c > b/Platform/NXP/Drivers/WatchDog/WatchDog.c > new file mode 100644 > index 000..a9c70ef > --- /dev/null > +++

Re: [edk2] [platforms: PATCH v2 4/4] Marvell/Drivers: MvPhyDxe: Cleanup the header

On Fri, Dec 01, 2017 at 04:35:07PM +0100, Marcin Wojtas wrote: > This patch removes unused macros defined in MvPhyDxe.h, as well > as improves the style and comments. Pick single definition > of the autonegotiation timeout - two different macros were used > for the same purpose. > >

Re: [edk2] [PATCH v3 07/11] ArmPkg/ArmExceptionLib: Add implementation of new API

On 1 December 2017 at 02:37, Jian J Wang wrote: >> v3: >>Newly added > > This patch add implementation of following new API introduced into > CpuExceptionHandlerLib. Since this lib hasn't support Stack Guard > and stack switch, the new method just calls original >

Re: [edk2] [platforms: PATCH v2 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information

On Fri, Dec 01, 2017 at 04:35:06PM +0100, Marcin Wojtas wrote: > fupdate command's usage information referred to a deprecated > '-f' flag in 'examples' section. It was a residue from the > initial version of the application, removed during review > before merging to upstream branch. Correct the

[edk2] [PATCH edk2-platforms] Silicon/SynQuacerI2CDxe: add missing __FUNCTION__ argument to %a specifier

The I2C driver prints a warning under DEBUG when a I2C transaction times out. This will occur on the rev 0.1 DeveloperBox boards due to a board level error in the I2C routing (unless the MCU has been lifted off the bus). Currently, this will trigger a crash due to a missing __FUNCTION__ argument

Re: [edk2] [platforms: PATCH v2 1/4] Marvell/Armada: Switch to dynamic tftp command

On Fri, Dec 01, 2017 at 04:35:04PM +0100, Marcin Wojtas wrote: > After removal of the tftp library in EDK2, the tftp was > disabled on Armada platform. Re-enable this functionality > as a dynamic command on Armada 70x0 DB board. For this > purpose add it as a build-time selectable option,

[edk2] [PATCH 6/6] BaseTools/Conf: Add VS2017/ARM support

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- BaseTools/Conf/build_rule.template | 30 BaseTools/Conf/tools_def.template | 28 ++ 2 files changed, 58 insertions(+) diff --git

[edk2] [PATCH 4/6] ArmPkg/Library/CompilerIntrinsicsLib: Enable VS2017/ARM builds

Introduce CRT assembly replacements for __rt_sdiv, __rt_udiv, __rt_udiv64, __rt_sdiv64, __rt_srsh, memcpy and memset. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- ArmPkg/Library/CompilerIntrinsicsLib/Arm/rtdiv.asm | 255

[edk2] [PATCH 3/6] MdePkg/Library/BaseLib: Enable VS2017/ARM builds

Most of the RVCT assembly can be reused as is for MSFT except for CpuBreakpoint.asm, which we need to force to Arm mode. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- MdePkg/Library/BaseLib/Arm/CpuBreakpoint.asm | 5 -

[edk2] [PATCH 1/6] MdePkg: Disable some Level 4 warnings for VS2017/ARM

Warnings 4018, 4100, 4101, 4127, 4214, 4244, 4456, 4701 and 4703 are disabled as they were found to occur more than 5 times during QEMU firmware compilation. Also create a dummy macro for PRESERVE8, as this is not supported by the Microsoft ARM assembler. Contributed-under: TianoCore

[edk2] [PATCH 5/6] MdePkg/Include: Add VA list support for VS2017/ARM

VA_START, VA_END and VA_COPY are the same as the generic macros. VA_ARG was reverse engineered from MS ARM assembly output. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard --- MdePkg/Include/Base.h | 13 + 1 file changed, 13

  1   2   >