Mike,
Should all code use BSD licenses?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Kinney, Michael D
> Sent: Friday, January 26, 2018 7:08 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Dong, Eric ; Yao,
> Jiewen ; Kinney, Michael D
Laszlo:
Here is PERF macro PERF_START_EX(Handle, Token, Module, TimeStamp,
Identifier).
Handle is the image handle or device handle. PerfLib can base on Handle to
get its FILE guid.
Token is the measured token name.
Module is the measured module name. PERF_START macro is added before
Hi Liming,
Reviewed-by: Star Zeng
Two minor comments. Just for your information.
1. Notice the title, it may be too long.
2. In PeiAcpiTimerLib.c, you may need to add ASSERT
(PerformanceCounterFrequency != NULL) after BuildGuidHob.
And you can move " PerformanceCounterFrequency = (UINT64*)GET_G
Hi Mike,
Some MINOR comments at my first sight.
1. Should *.uni and *Extra.uni be added for this module?
2. Could EfiCreateEventReadyToBootEx() be used instead of below code? Then
gEfiEventReadyToBootGuid reference in *.inf could be also removed.
+ Status = gBS->CreateEventEx (
+
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Friday, January 26, 2018 11:50 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen ;
> Chaganty, Rangasai V
> Subject: [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: TotalSize must be
> multiples of
TotalSize must be multiples of 1024 bytes (1 KBytes) according to SDM.
Also enhance the debug message for DataSize that must be
multiples of DWORDs.
Cc: Jiewen Yao
Cc: Rangasai V Chaganty
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
.../Capsule/Microcod
On Thu, Jan 25, 2018 at 01:37:39PM +, Zhu, Yonghong wrote:
> Hi Gary,
>
> Thanks for your patches. I am still in evaluating these changes and do some
> verification for it.
> I still need some more days to give you comment. Thanks.
I forgot to mention my branch in the cover letter.
https://g
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=802
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
The EsrtFmpDxe module is a lightweight version of the EsrtDxe
module that produces ESRT entries based on
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=802
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
The EsrtFmpDxe module is a lightweight version of the EsrtDxe
module that produces ESRT entries based on
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=802
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
The EsrtFmpDxe module is a lightweight version of the EsrtDxe
module that produces ESRT entries based on
https://bugzilla.tianocore.org/show_bug.cgi?id=802
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
The EsrtFmpDxe module is a lightweight version of the EsrtDxe
module that produces ESRT entries based only on FMP Protocol
instan
Marvin/Tim,
Thanks.
Apologies, if I didn't mention that this patch was just addition of new values
EFI_FV_FILETYPE_MM_STANDALONE
EFI_FV_FILETYPE_MM_CORE_STANDALONE
and
EFI_SECTION_MM_DEPEX
No other changes.
In existing code, EFI_FV_FILETYPE_SMM and EFI_FV_FILETYPE_MM are same already.
Supreeth
On January 25, 2018 4:53:06 PM GMT-02:00, Rafael Machado
wrote:
>Hi everyone.
>
>I'm currently work on a task, and I need to write some data at a DMA
>buffer.
>At the UEFI Driver Writer's guide, at page 359 there is a sample code
>of
>how to do that.
>
>Considering that code and adapting to my
Of all the gin joints in all the towns in all the world, Zhang, Chao B had to
walk into mine at 20:53 on Wednesday 24 January 2018 and say:
> According to TCG PP1.3 spec, error PCR bank allocation input should be
> rejected by Physical Presence. Firmware has to ensure that at least one
> PCR bank
Hi Andrew
Thanks for the answer.
The allocation was done at other part of the code. But yet, I used the
PciI->AllocateBuffer() function.
One question, about the topics retrieved from the spec.
When the spec says "• The common buffer can now be accessed equally by the
processor and the DMA bus ma
Rafeal,
There are some good summaries in the UEFI Spec that really help.
DMA Bus Master Common Buffer Operation
• Call AllocateBuffer() to allocate a common buffer.
• Call Map() for EfiPciOperationBusMasterCommonBuffer or
EfiPciOperationBusMasterCommonBuffer64.
• Program the DMA Bus Master with
Hi everyone.
I'm currently work on a task, and I need to write some data at a DMA buffer.
At the UEFI Driver Writer's guide, at page 359 there is a sample code of
how to do that.
Considering that code and adapting to my scenario I got the following
function (some debug prints are present for clar
On 25 January 2018 at 12:27, Ard Biesheuvel wrote:
> Some stuff I have collected over the past 2 months or so. Note that this
> includes the SATA spread spectrum patch I sent out yesterday: I had forgotten
> all about this backlog, and I only remembered when attempting to apply it to
> the master
On Thu, Jan 25, 2018 at 05:13:17PM +, Ard Biesheuvel wrote:
> Add menu options to the SynQuacer Platform menu screen to limit the
> maximum PCIe link speed for each slot individually. This may be useful
> to work around potential PCIe issues.
>
> Contributed-under: TianoCore Contribution Agree
Hey Tim and Supreeth,
Sorry, 0x0C was a typo, 0x0D is the correct one.
The values of the SMM and MM constants are identical, this is just a naming
update plus the introduction of the new value, MM Standalone Core, so
backwards-compatibility is given.
Regarding the traditional MM Core, I just ass
Supreeth --
Doesn't Appendix A of the PI 1.6 define this as:
#define EFI_FV_FILETYPE_SMM EFI_FV_FILETYPE_MM
#define EFI_FV_FILETYPE_SMM_CORE EFI_FV_FILETYPE_MM_CORE
Thanks,
Tim
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Supreeth Venkatesh
S
Marvin,
Thanks for your comments.
As per PI v1.6 specification,
EFI_FV_FILETYPE_MM_CORE value is 0x0D (MM Foundation that support MM
Traditional Mode.)
This is traditional MM mode, which ARM is not supporting at this point. We are
more interested in MM_CORE_STANDALONE mode.
However, I have no i
Add menu options to the SynQuacer Platform menu screen to limit the
maximum PCIe link speed for each slot individually. This may be useful
to work around potential PCIe issues.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
v3:
deobfuscate the slot speed
On Thu, Jan 25, 2018 at 03:31:19PM +, Ard Biesheuvel wrote:
> Add menu options to the SynQuacer Platform menu screen to limit the
> maximum PCIe link speed for each slot individually. This may be useful
> to work around potential PCIe issues.
>
> Contributed-under: TianoCore Contribution Agree
Add menu options to the SynQuacer Platform menu screen to limit the
maximum PCIe link speed for each slot individually. This may be useful
to work around potential PCIe issues.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
v2:
Make the speed limit per-s
Hi,
On 01/24/2018 11:56 PM, Huangming (Mark) wrote:
On 2018/1/24 5:29, Jeremy Linton wrote:
Hi,
On 01/18/2018 09:01 AM, Ming Huang wrote:
From: Jason Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jason Zhang
Signed-off-by: Ming Huang
Signed-off-by: Heyi G
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, January 25, 2018 1:54 AM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: RE: [edk2] [PATCH v2] ShellPkg: Update package version from 1.01
> to 1.02
> Importance: High
>
> Review
Hi Gary,
Thanks for your patches. I am still in evaluating these changes and do some
verification for it.
I still need some more days to give you comment. Thanks.
Best Regards,
Zhu Yonghong
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Friday, January 19, 2018 12:43 P
On 25 January 2018 at 12:54, Leif Lindholm wrote:
> On Thu, Jan 25, 2018 at 12:27:31PM +, Ard Biesheuvel wrote:
>> Instead of registering a notification callback on the driver binding
>> protocol, and attempting to connect our I2C master handle each time
>> a new driver is registered, switch t
On 25 January 2018 at 13:00, Leif Lindholm wrote:
> On Thu, Jan 25, 2018 at 12:27:35PM +, Ard Biesheuvel wrote:
>> The upstream version of the Linux NETSEC driver expects the PHY DT
>> node to appear under a MDIO subnode, so fix this in the device tree.
>> Fix the node name as well, this shoul
On Thu, Jan 25, 2018 at 12:27:35PM +, Ard Biesheuvel wrote:
> The upstream version of the Linux NETSEC driver expects the PHY DT
> node to appear under a MDIO subnode, so fix this in the device tree.
> Fix the node name as well, this should be 'ethernet' not 'netsec',
> and add a clock-names pr
On Thu, Jan 25, 2018 at 12:27:34PM +, Ard Biesheuvel wrote:
> Align the UART DT nodes:
> - use 'uart' not 'fuart' as node name for the second serial port
> - create an alias 'serial1' for the second serial port
> - use UART clock reference instead of hardcoded frequency
> - split 'clocks' prope
On Thu, Jan 25, 2018 at 12:27:33PM +, Ard Biesheuvel wrote:
> To ensure that the I2C master protocol is installed immediately onto
> the handles created by PlatformDxe in its entry point, force the
> SynQuacerI2cDxe driver to be loaded before PlatformDxe. These handles
> are recursively connect
On Thu, Jan 25, 2018 at 12:27:32PM +, Ard Biesheuvel wrote:
> Remove a %r without an associated parameter.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
> ---
> Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/Syn
On Thu, Jan 25, 2018 at 12:27:31PM +, Ard Biesheuvel wrote:
> Instead of registering a notification callback on the driver binding
> protocol, and attempting to connect our I2C master handle each time
> a new driver is registered, switch to the more obvious approach of
> registering a notificat
On Thu, Jan 25, 2018 at 12:27:30PM +, Ard Biesheuvel wrote:
> Do a global replace of gPcf8563RealTimeClockLibI2cMasterProtolGuid with
> gPcf8563RealTimeClockLibI2cMasterProtocolGuid.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif
On 01/25/18 05:56, Bi, Dandan wrote:
> Hi Laszlo,
>
> Thank you for your comments.
>
> Yes. The PERF_INMODULE_START_ID macro is from "ExtendedFirmwarePerformance.h"
> which is added in the new performance infrastructure patches([ mail subject:
> patch 0/8] Update EDKII Performance infrastructur
On 01/25/18 05:52, Wu, Jiaxin wrote:
> Hi Laszlo,
>
> The HttpDxe driver needs to install the Driver Binding Protocol so as
> to check if a specific controller is supported by HttpDxe. HttpDxe
> can only be started if the TcpServiceBindingProtocol existed. So, it
> has to follow the UEFI Driver Mo
To ensure that the I2C master protocol is installed immediately onto
the handles created by PlatformDxe in its entry point, force the
SynQuacerI2cDxe driver to be loaded before PlatformDxe. These handles
are recursively connected by the DXE core as soon as they appear, and
so ensuring that the I2C
Align the UART DT nodes:
- use 'uart' not 'fuart' as node name for the second serial port
- create an alias 'serial1' for the second serial port
- use UART clock reference instead of hardcoded frequency
- split 'clocks' property into 1 cell per phandle
Contributed-under: TianoCore Contribution Agr
Remove a %r without an associated parameter.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Silicon/Socionext/SynQ
The upstream version of the Linux NETSEC driver expects the PHY DT
node to appear under a MDIO subnode, so fix this in the device tree.
Fix the node name as well, this should be 'ethernet' not 'netsec',
and add a clock-names property describing the single clock reference
as 'phy_ref_clk'.
Also, mo
Do a global replace of gPcf8563RealTimeClockLibI2cMasterProtolGuid with
gPcf8563RealTimeClockLibI2cMasterProtocolGuid.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.c | 2 +-
Silicon
Some stuff I have collected over the past 2 months or so. Note that this
includes the SATA spread spectrum patch I sent out yesterday: I had forgotten
all about this backlog, and I only remembered when attempting to apply it to
the master branch.
Ard Biesheuvel (8):
Silicon/SynQuacer/PlatformDxe
Add menu options to the SynQuacer Platform menu screen to limit the
maximum PCIe link speed for each RC individually. This may be useful
to work around potential PCIe issues.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Platform/Socionext/DeveloperBox
The ASM1061 SATA controller integrated into the DeveloperBox board
emits too much electromagnetic radiation, so it needs spread spectrum
mode enabled.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
---
Silicon/Socionext/SynQuacer
Instead of registering a notification callback on the driver binding
protocol, and attempting to connect our I2C master handle each time
a new driver is registered, switch to the more obvious approach of
registering a notification callback on the I2C master protocol directly.
The original code was
Thanks Liming.
From the way you framed your comment, I'm not completely sure if
there's action still needed on my side...
Do I actually need to resubmit a patch set with "Reviewed By"?
Or, now that each patch should have flagged as reviewed, are we simply
supposed to wait for formal integrati
Tested-by/Reviewed-by: Jian J Wang
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, January 25, 2018 5:45 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J
> Subject: [PATCH] MdeModulePkg/Partition: Fix media probe
>
> The call in ProbeMediaStatusEx() to the ReadDisk() functio
Pete:
The changes in BaseTools and MdePkg are good to me. You can add my R-B.
>-Original Message-
>From: Pete Batard [mailto:p...@akeo.ie]
>Sent: Friday, January 12, 2018 9:33 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; ard.biesheu...@linaro.org;
>eug...@hp.com
>Subject: [PATCH v5
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Thursday, January 25, 2018 3:42 PM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [Patch] BaseTool: Fixed the StructurePcd incorrect value.
>
>If user not set Structure overall value in Dsc,
>Str
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>BobCF
>Sent: Tuesday, January 23, 2018 4:01 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Fixed incorrect VPD size.
>
>The VPD size is incorrect if th
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Tuesday, January 23, 2018 11:03 AM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [Patch] BaseTools: Add comments for the Structure Pcd definition in
>PcdValueInit.c file
>
>Contributed-under: Ti
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Tuesday, January 23, 2018 9:39 AM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [Patch] BaseTools: Fixed build failure for the case that A pcd is
>initialized under one SKU but is uninitialized
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Tuesday, January 23, 2018 10:19 AM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [Patch] BaseTool: Combine the HiiPcd value if they link to same
>Variable
>
>Contributed-under: TianoCore Contrib
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Ruiyu Ni
>Sent: Wednesday, January 24, 2018 1:56 PM
>To: edk2-devel@lists.01.org
>Cc: Carsey, Jaben
>Subject: [edk2] [PATCH v2] ShellPkg: Update package version from 1.01
The call in ProbeMediaStatusEx() to the ReadDisk() function of the
EFI_DISK_IO_PROTOCOL interface implemented in DiskIoDxe/DiskIo.c
crashed in DiskIo2ReadWriteDisk() because of the NULL value of
the destination buffer pointer.
Pass the address of a buffer in the stack instead of a NULL
pointer.
T
"You, Benjamin" writes:
> Hi Arthur,
>
> Could you please give more details about your case that
> HorizontalResolution * (BitsPerPixel / 8) and pFbInfo->BytesPerScanLine
> don't match?
>
On many devices, notably Intel hardware, the STRIDE needs to be 64 byte
aligned when used in linear memory
On 1/25/2018 3:42 PM, Jian J Wang wrote:
v2:
Roll back changes (just white spaces) caused by misoperation in git
This issue is introduced by a patch at
f32bfe6d061420a15bac6083063d227c567e6388
The above patch miss the case of 64-bit PEI, which will link
X64/MpFuncs.nasm instead of Ia3
59 matches
Mail list logo
