Thanks for your comments about 'USE_OLD_SHELL'. I'll improve the patches in
next version.
Shenglei
> -Original Message-
> From: Justen, Jordan L
> Sent: Wednesday, October 31, 2018 2:48 PM
> To: edk2-devel@lists.01.org; Zhang, Shenglei
> Subject: Re: [edk2] [PATCH 0/5] Remove
Add definition of HwErrRecVariableNamePrefixLength,
HwErrRecVariableNameIndexLength and HwErrRecVariableNameLength
Make the HwErrRecVariableName as the valid string.
Ensure the HwErrRecVariable could be deleted before the test exit.
Cc: Supreeth Venkatesh
Contributed-under: TianoCore
Hi Supreeth,
Got your worry. It is difficult to define the clear/meaningful macro to express
the implication and avoid the ambiguity in my eye.
How about to document the clear comments in the key process? It is more help
for reading by someone new and sustaining.
Best Regards
Eric
Thanks. SMRR is used to prevent cache poisoning attack. IMHO, the assumption is
valid.
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Tuesday, October 30, 2018 10:51 AM
> To:
Reviewed-by: Star Zeng
-Original Message-
From: Carsey, Jaben
Sent: Thursday, November 1, 2018 3:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Wang, Jian J
Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib
The comments are incorrect for the base version of this
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Wednesday, October 31, 2018 4:46 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH v1] NetworkPkg/Mtftp6Dxe: Remove the trailing white spaces.
>
> Cc: Fu Siyuan
>
On 2018/10/31 20:08, Leif Lindholm wrote:
On Wed, Oct 31, 2018 at 12:38:43PM +0800, Zeng, Star wrote:
Good feedback.
On 2018/10/30 20:50, Leif Lindholm wrote:
On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote:
(add back the list)
Oi! Go back on holiday!
On 30 October 2018 at
Hi, Leif
So you have tested all the platform build? That's great, thanks a lot.
Do you want me to merge these 3 patches to a combo v2 patch, or can you help to
commit the patch set to edk2-platform repo?
BestRegards
Fu Siyuan
> -Original Message-
> From: Leif Lindholm
(You'll note I'm skipping over the SdMmc bits for now.)
On Fri, Sep 21, 2018 at 08:25:55AM +, Chris Co wrote:
> MsPkg is a collection of libraries and drivers that are specific
> to supporting Windows IoT Core but are not Platform/Silicon specific.
>
> Contributed-under: TianoCore
+Sumit (just to loop you two together). Is there anything Microsoft
platform specific about what will go in here?
/
Leif
On Fri, Sep 21, 2018 at 08:25:53AM +, Chris Co wrote:
> On Windows IoT Core devices with ARM TrustZone capabilities,
> EDK2 runs in normal world and we use OP-TEE to
Replace the current NULL pointer dereference to retrieve Field's
offset with a call to OFFSET_OF(). This is implemented via
__builtin_offsetof for GCC and Clang, which eliminates UB caught by
Clang UndefinedBehaviorSanitizer.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
Hey Eric,
I discovered it by accident, no tool was involved.
Regards,
Marvin
> -Original Message-
> From: Dong, Eric
> Sent: Tuesday, October 30, 2018 3:30 AM
> To: Marvin Häuser ; edk2-
> de...@lists.01.org
> Cc: ler...@redhat.com
> Subject: RE: [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm:
The comments are incorrect for the base version of this lib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
Cc: Star Zeng
Cc: Jian J Wang
---
MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22
1 file changed, 9 insertions(+), 13
On Thu, Aug 16, 2018 at 09:49:26AM +0800, Haojian Zhuang wrote:
> Replace DwEmmcDxe driver by DwMmcHcDxe driver on HiKey platform. Since
> the new driver could work on both eMMC and SD controller.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribution Agreement
Apologies for ridiculously slow response,
On Thu, Aug 16, 2018 at 09:49:25AM +0800, Haojian Zhuang wrote:
> Enable DwMmcHcDxe driver on HiKey960 platform.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang
> ---
On Wed, Oct 31, 2018 at 11:38:51AM +0800, Fu Siyuan wrote:
> The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated. All
> platform DSC/FDF files should be updated to use the dual-stack drivers in
> NetworkPkg.
>
> The NetworkPkg driver have all the functionality compared with
On Wed, 2018-10-31 at 02:29 +, Jin, Eric wrote:
> Hi Supreeth,
Hi Eric,
>
> Thank for the comments.
> I will re-create the patch to add the definition of the
> HwErrRecVariableNamePrefixLength(8) and
> HwErrRecVariableNameIndexLength(4).
Thank you.
>
> There are two meanings to 2. To
Fu Siyuan,
Just edk2-platforms/master.
Maintainers for devel and stable branches need to device
when to move to a new version of edk2 repo and perform
integration tasks.
The patch for edk2-platforms/master should include this
notification so maintainer of devel and stable branches
will know
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zhaozh1x
> Sent: Wednesday, October 31, 2018 3:36 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [PATCH] BaseTools: Check the max size for
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Tuesday, October 30, 2018 8:50 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch V2] BaseTools: Add special handle
Hi Leif,
I will try to modify D03/D05 IORT and test also and will incorporate these
fixes for v2.
Thanks you and Al Stone for finding and fix IORT bug.
On 10/31/2018 7:06 PM, Leif Lindholm wrote:
> (On further thinking, and testing ...)
>
> Could you also make sure D03/D05 ACPI is up to date
Hello,
I'm building a custom x86_64 platform. It gets to BDS, where I select an USB
with Debian as a boot device.
```
[Bds]Booting UEFI USB Flash Memory C412F52D6C89C0210002C15B
error: no suitable video mode found.
error: no video mode activated.
GNU GRUB version
I wanted to close this off,
The value was checked. The problem was that I had previously changed the
offsets/sizes of some FD/FVs.
Removing those changes fixed the issue.
---
Hristo
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: 09 October 2018 12:49
To: Hristo
“BaseCryptLib” library can be used by MM_STANDALONE drivers as well.
So add MM_STANDALONE as the module type this library supports
A new inf file is added for this because the UefiRuntimeServicesTableLib
library class cannot be used along with MM_STANDALONE modules.
Change-Id:
On Wed, Oct 31, 2018 at 12:38:43PM +0800, Zeng, Star wrote:
> Good feedback.
>
> On 2018/10/30 20:50, Leif Lindholm wrote:
> > On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote:
> > > (add back the list)
> >
> > Oi! Go back on holiday!
> >
> > > On 30 October 2018 at 09:07, Cohen,
Hi Liming,
Thanks for quick response and details,
EmulatorPkg\Win
Above folder was not present in UDK2018. But available in EDK2 master
When I used below command I'm able to build success,
build -p EmulatorPkg\EmulatorPkg.dsc -t VS2015x86 -D WIN_SEC_BUILD -a IA32
-m
Yes, Ray, that is the code block that I meant. It serves no purpose since
InputPath cannot possibly be NULL in that part of the code.
I appreciate your help in deleting this block and pushing the rest of the
patch. Also, thanks for your thorough review of this code (and the first
version)!
“VarCheckLib” library will be used by MM_STANDALONE driver too,
hence adding LIBRARY_CLASS as MM_STANDALONE
Change-Id: I1b999d05381180b511b986cd09b4923907ef2a4d
Signed-off-by: Jagadeesh Ujja
---
MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf | 5 +++--
1 file changed, 3 insertions(+), 2
“AuthVariableLib” library will be used by MM_STANDALONE driver too,
hence adding LIBRARY_CLASS as MM_STANDALONE
Change-Id: I67a10e1c60b3c859283c995f442d5b8709de89e1
Signed-off-by: Jagadeesh Ujja
---
SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf | 5 +++--
1 file changed, 3
This is hack to get the time when executing in MM Standalone mode. It is
not clear how to implement a function that gets the current time. So
using this as a hack for now.
Change-Id: I6f0ad72d2c965e8f1e7e4871039b3399cf9c3c6a
Signed-off-by: Jagadeesh Ujja
---
Adapt the variable runtime dxe driver to be used as a MM_STANDALONE
driver to provide variable storage service in MM Standalone mode.
Change-Id: Ieadd1e575d7c430b2a3223f049d41d88dfbaecb2
Signed-off-by: Jagadeesh Ujja
---
.../Universal/Variable/RuntimeDxe/Variable.c | 16 ++-
Adapt the VariableSmmRuntimeDxe driver to communicate with a VariableSmm
driver that is implemented as a MM Standalone driver.
Change-Id: I3975d021ac848f13206bc2c577a4f5fb0e29b941
Signed-off-by: Jagadeesh Ujja
---
.../Variable/RuntimeDxe/VariableSmmRuntimeDxe.c | 20 ++--
1
Adapt the FaultTolerantWriteDxe driver to be used as a MM_STANDALONE
driver to provide UEFI fault tolerant write protocol functionality
for variable reclaim operation on EFI variables stored on a NOR flash
that is only accessible to code executing in MM Standalone mode.
Change-Id:
Adapt the NorFlashDxe driver to be used as a MM_STANDALONE driver to
allow access to NOR flash for code executing in MM_STANDALONE mode.
This allows storing of EFI variables on NOR flash which is accessible
only via the MM STANDALONE mode software.
Change-Id:
Three additional library packages are being pulled into StandaloneMmPkg
from the staging area in order to support the secure variable service.
The three packages being pulled in are
- StandaloneMmHobLib
- StandaloneMmMemoryAllocationLib
- StandaloneMmServicesTableLib
Change-Id:
This RFC patch series extends the existing secure variable service support
for use with Standalone MM. This is applicable to paltforms that use
Standalone Management Mode to protect access to non-volatile memory (NOR
flash in case of these patches) used to store the secure EFI variables.
The
(On further thinking, and testing ...)
Could you also make sure D03/D05 ACPI is up to date and builds with
acpica 20181003? I think anything that compiles with 20180629 should
also work with 20181003.
Best Regards,
Leif
On Mon, Oct 29, 2018 at 06:58:46PM +, Leif Lindholm wrote:
> Hi Ming,
Hi Shenglei,
I am happy with this change, but I think the deletion from
Maintainers.txt should come last (as 3/3).
Could you rework and resubmit, and add a cover letter (0/3)?
Best Regards,
Leif
On Wed, Oct 31, 2018 at 02:05:23PM +0800, shenglei wrote:
> Given that EdkShellPkg and
Hi Fu Siyuan,
Hmm, strange.
Ming Huang (cc) has also had issues with this in his latest set (but
not before). Can you guys work together to try to figure out what is
going wrong?
Can you start by testing with an older version of git?
Best Regards,
Leif
On Wed, Oct 31, 2018 at 12:41:39AM
Hi Fu Siyuan,
That is fine too.
But I expect the change to be one to go in the week after a stable tag
has been made.
(My own philosophy is that one can be quite aggressive with removals,
because if it turns out to have been a bad idea, git revert can
quickly restore the tree to the state it
According to PCD_DATABASE_INIT in
edk2\MdeModulePkg\Include\Guid\PcdDataBaseSignatureGuid.h,
the max size for string PCD should not exceed USHRT_MAX 65535(0x).
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: ZhiqiangX Zhao
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Jim,
I checked the other parts in your patch. They looks good.
But I don't quite understand how to handle the if-statement.
Do you mean to remove the below code block?
//
// Handle the degenerate case where Path was only a file system reference.
// In that case we return the current
Shenglei,
The patch is not complete for removing EDK SHELL from EmulatorPkg.
Please also review all references of "USE_OLD_SHELL" and remove the related
contents.
Same comments apply to the changes to other platforms.
Thanks/Ray
> -Original Message-
> From: Zhang, Shenglei
> Sent:
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of shenglei
> Sent: Wednesday, October 31, 2018 2:05 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Laszlo Ersek
>
> Subject: [edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and
>
SortLib depends on MemoryAllocationLib.
How can it be a BASE type library?
Can we do it in two options?
1. Change the SortLib API to accept a temporary buffer from caller. So the
MemoryAllocationlIb dependency can be removed.
2. Do not change SortLibAPI but uses a fixed-size temporary buffer
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
---
NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h
b/NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h
index
From: Hess Chen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen
---
BaseTools/Source/Python/Eot/EotMain.py | 365 -
1 file changed, 365 deletions(-)
diff --git a/BaseTools/Source/Python/Eot/EotMain.py
I also see USE_OLD_SHELL references in the .dsc files.
(Try 'git grep USE_OLD_SHELL')
After the platforms no longer reference EdkShellBinPkg, then the bin
package will be removed?
-Jordan
On 2018-10-30 22:57:06, shenglei wrote:
> Remove EdkShellBinPkg in CorebootPayloadPkg, EmulatorPkg,
EdkShellBinPkg and EdkShellPkg are removed and so that
Maintainers.txt is modified.
shenglei (3):
Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg
EdkShellBinPkg: Remove EdkShellBinPkg
EdkShellPkg: Remove EdkShellPkg
EdkShellBinPkg/Bin/Arm/Attrib.efi | Bin 21504 -> 0
Given that EdkShellPkg and EkdShellBinPkg will be removed,
information about them in Maintainers.txt should also be
deleted.
https://bugzilla.tianocore.org/show_bug.cgi?id=1107
https://bugzilla.tianocore.org/show_bug.cgi?id=1108
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D
50 matches
Mail list logo
