> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of David
> Woodhouse
> Sent: Thursday, March 10, 2016 10:01 AM
> To: Long, Qin ; Wu, Jiaxin ;
> edk2-de...@ml01.01.org
> Cc: Ye, Ting ; Fu, Siyuan
> Subject: Re: [edk2] [P
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: David Woodhouse [mailto:david.woodho...@intel.com]
> Sent: Thursday, March 10, 2016 3:15 AM
> To: edk2-de...@ml01.01.org
> Cc: Long, Qin
> Subject: [PATCH] CryptoPkg/Ope
David,
This patch series should be based on the old version, before the back-porting
of upstreaming patch was done.
We should have no need to add the extra patches on OpenSSL now for
OpensslTlsLib build now.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> F
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Sunday, March 6, 2016 3:06 AM
> To: David Woodhouse
> Cc: Long, Qin ; edk2-devel@lists.01.org
>
> Subject: Re: [edk2] [GIT PULL] CryptoPkg/OpensslLib: Fix CRLF breakage in
>
I cannot recall the history about this flag.
Then that will be better. I think it's good to remove the flag for those
library, and put them there directly, if no any build performance impacts.
Best Regards & Thanks,
LONG, Qin
From: Ni, Ruiyu
Sent: Friday, February 26, 2016 11:29 AM
One consideration before should be build performance, to use the flag to turn
on / off those modules, since openssl build need quite a long times.
Best Regards & Thanks,
LONG, Qin
From: Ni, Ruiyu
Sent: Friday, February 26, 2016 11:17 AM
To: Wu, Jiaxin; Long, Qin; El-Haj-Mahmoud, Samer
ould be tolerant to produce the correct makefile even if we enabled both
two flags.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Friday, February 26, 2016 9:59 AM
> To: El-Haj-Mahmoud, Samer; Ye, Ting; edk2-devel@lists.01.org
> Cc: Ni,
Great.
I will sync-up these changes and follow the windows / VS toolchain
validations.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: David Woodhouse [mailto:dw...@infradead.org]
> Sent: Thursday, February 25, 2016 10:05 AM
> To: Laszlo Ersek; edk2-dev
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, February 25, 2016 5:14 AM
> To: edk2-devel-01
> Cc: Cecil Sheng; Cinnamon Shia; Daryl McDaniel; David Woodhouse; Dong,
&g
Laszlo, this is really cool. Thanks for the analysis and root-cause this.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, February 25, 2016 3:39 AM
> To: David Woodhouse; Long, Qin
> Cc
> -Original Message-
> From: David Woodhouse [mailto:dw...@infradead.org]
> Sent: Friday, February 19, 2016 5:00 PM
> To: Long, Qin; Laszlo Ersek
> Cc: Ye, Ting; edk2-de...@ml01.01.org
> Subject: Re: [edk2] [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version
>
-by-step.
Yeah, also will do more follow-ups about the remaining opens...
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> David Woodhouse
> Sent: Friday, February 19, 2016 7:01 AM
> To
eave me in the rooms. :-)
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Friday, February 19, 2016 1:08 AM
> To: David Woodhouse ; Long, Qin
> Cc: Ye, Ting ;
ed on my last patch, which will not change any build process, and
just to catch the latest release for some requirements.
(David, apology for my late feedback to your patch post.)
Let me know if any concerns.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> Fro
;cc = RShiftU64 (aa, (UINTN) xxx)"
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Rodrigo Caropreso
> Sent: Sunday, January 24, 2016 12:25 AM
> To: edk2-devel@lists.01.org
>
Authur, the patch is OK for me to use "int" here, since CrtWrapper.c was
already using the mixed type style to meet the compiler.
Thanks for catching this.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Burigo, Arthur Cripp
Thanks for the detailed analysis. The fix makes sense to me.
And yes, I also prefer to use INT32 as Laszlo's comment (since we don't
consider ILP64 data model), to keep the consistent style in this function
declaration.
Best Regards & Thanks,
LONG, Qin
> -Original Me
It's good for me.
Reviewed-by: Qin Long
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, January 19, 2016 9:46 AM
> To: Wu, Jiaxin; edk2-devel@lists.01.org
> Cc: Tian, Hot; Li, Ruth; Long, Qin
> Subject: RE: [edk2] [Patch] edk2: Update the maint
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Zhang, Chao B
> Sent: Friday, January 15, 2016 9:39 AM
> To: edk2-de...@ml01.01.org
> Cc: Long, Qin; Fu, Siyuan; Zhang, Chao B
> Subject: [PATCH] SecurityPkg: SecureBootConf
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zhang, Chao B
> Sent: Thursday, January 14, 2016 9:01 AM
> To: edk2-de...@ml01.01.org
> Cc: Fu, Siyuan; Zh
Looks good to me.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zhang, Chao B
> Sent: Friday, January 08, 2016 3:34 PM
> To: edk2-de...@ml01.01.org
> Cc: Yao,
Looks I missed this one. It's OK for me.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, December 18, 2015 12:11 AM
> To: edk2-devel@lists.01.org; Long, Qin
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Justen, Jordan L
> Sent: Saturday, December 5, 2015 4:13 AM
> To: edk2-devel@lists.01.org
> Cc: Justen, Jordan L; Long, Qin
> Subject: [PATCH v2 04/20] CryptoPkg: Convert a
Sorry, I missed this patch. Yes, this looks good.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Saturday, December 5, 2015 12:45 AM
> To: edk2-devel@lists.01.org; Lon
For the series, reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday, December 3, 2015 6:51 PM
> To: edk2-devel@lists.01.org; eug...@hp.com; Long, Qin; dw...@infrade
ase. We may be
able to remove whole EDKII-openssl-xxx.patch, and have some native EFI
configuration, INF generation, etc, if all patches were integrated into openssl
head. :-)
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun
David, do you think it's valuable to feedback to OpenSSL community? Personally,
I think the old behavior (before 1.0.2e) can be acceptable when two data
(embedded and detached data) were supplied.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Ard Biesheuv
Eugene,
As Ard's said, this patch series should cover / supersede your old fixes for
RVCT build, which was pended by me. :-)
Could you please help to validate them? Since I have no RVCT environment.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From:
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
> Biesheuvel
> Sent: Thursday, December 3, 2015 11:13 PM
> To: David Woodhouse
> Cc: edk2-devel@lists.01.org; Long, Qin; Cohen, Eugene
> Subject: Re: [edk2] [PATCH 4/4]
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday, December 3, 2015 8:52 PM
> To: David Woodhouse
> Cc: edk2-devel@lists.01.org; Cohen, Eugene; Long, Qin
> Subject: Re: [PATCH 3/4] CryptoPkg/OpensslLib: comment out unu
Looks good.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, December 03, 2015 1:27 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin
> Subject: [Patch 5/6] CryptoPkg: Disable VS2015 warni
The patch series is good to me.
Please make the patch subjects and description more clear, as Laszlo's
comments.
And also need to check the RetVal descriptions in your new-added functions.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Laszlo Er
Reviewed-by: Qin Long
Thanks, Ard.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, November 27, 2015 11:22 PM
> To: edk2-devel@lists.01.org; leif.lindh...@linaro.org; ler...@redhat.com;
> -Original Message-
> From: David Woodhouse [mailto:dw...@infradead.org]
> Sent: Wednesday, November 25, 2015 4:40 PM
> To: Long, Qin; Cohen, Eugene; Ard Biesheuvel; Leif Lindholm; Leif Lindholm
> Cc: edk2-devel@lists.01.org
> Subject: Re: [PATCH] CryptoPkg: Fix ARM R
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, November 25, 2015 12:56 AM
> To: Cohen, Eugene; Leif Lindholm; Leif Lindholm
> Cc: David Woodhouse; Long, Qin; edk2-devel@lists.01.org
> Subject: Re: [edk2] CryptoPkg: O
meet UEFI TS scenario. In
theory, there should have no this kind of link issues (duplicated macro
definitions) based on the current implementation.
OK, give me more times for digging.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Cohen, Eugene [mailto:eug
(e.g.
applying OPENSSL_SYS_UEFI) to silence it in our package, and then submit the
ticket in OpenSSL RT for the native fix.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cohen,
> Eugene
> Sent:
Thanks for the fix, Ard.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday, November 5, 2015 10:30 PM
> To: edk2-devel@lists.01.org; Long, Qin
> Cc: Ye, Ting;
Looks good.
Series Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Thomas Palmer
> Sent: Friday, October 9, 2015 1:13 AM
> To: edk2-devel@lists.01.org
> Cc: Z
_final_Aug7.pdf";
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, October 8, 2015 11:12 PM
> To: Long, Qin; Justen, Jordan L; Thomas Palmer; edk2-devel@lists.01.org;
> Kinney, Michael D
> Subject: RE: [edk2] [
Thomas,
Thanks for doing this.
I think it's better to separate your patch into two parts (one for MdePkg, and
the other for SecurityPkg). Then you can CC me as Jordan's suggestion.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [ma
Exactly. Thanks for catching this.
Will send the new patch later.
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Zhang, Chao B
> Sent: Tuesday, August 25, 2015 8:17 PM
> To: Long, Qin; edk2-devel@lists.01.org
> Subject: RE: [patch] SecurityPkg: Fix
Reviewed-by: Qin Long
> -Original Message-
> From: Zhang, Chao B
> Sent: Thursday, August 20, 2015 10:11 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Zhang, Chao B
> Subject: [PATCH] SecurityPkg: Update Package version to 0.96
>
> Update Package version
Looks good.
Reviewed-by: Qin Long < qin.l...@intel.com>
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Zhang, Chao B
> Sent: Monday, August 17, 2015 10:01 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Zhang, Chao B
> Subject: [PATCH] Secur
> -Original Message-
> From: David Woodhouse [mailto:dw...@infradead.org]
> Sent: Tuesday, July 28, 2015 4:23 PM
> To: Long, Qin; Laszlo Ersek; edk2-de...@ml01.01.org
> Subject: Re: [edk2] [RFC] OpenSSL HEAD WIP
>
> On Tue, 2015-07-28 at 08:08 +, Long, Qin w
> -Original Message-
> From: David Woodhouse [mailto:dw...@infradead.org]
> Sent: Tuesday, July 28, 2015 3:42 PM
> To: Long, Qin; Laszlo Ersek; edk2-de...@ml01.01.org
> Subject: Re: [edk2] [RFC] OpenSSL HEAD WIP
>
> On Tue, 2015-07-28 at 01:44 +
Reviewed-by: Qin Long
And Ersek, could you kindly help to double-check it will not break any shim
scenario?
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, July 27, 2015 8:17 PM
> To: David Woodhou
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, July 28, 2015 6:41 AM
> To: David Woodhouse; edk2-de...@ml01.01.org
> Cc: Long, Qin
> Subject: Re: [edk2] [RFC] OpenSSL HEAD WIP
>
> On 07/27/15 22:13, David Woodhouse wrote:
201 - 248 of 248 matches
Mail list logo
