which happened to depend on
AcpiTimerLib and thus HobLib.
HobLib will follow once the MmServicesTableLib patch has been decided on and I
will adapt others too once I run into needing them.
>
> Thanks
> Liming
> >-Original Message-
> >From: edk2-devel [mailto:edk2-devel
Good day,
I have been reading through the recently imported StandaloneMmPkg and found
three odd things.
1. GUID prefixes: GUIDs defined in StandaloneMmPkg.dec either have no common
prefix at all ("gMmFv") or use the "gEfi" prefix. Maybe the MdeModulePkg-style
"gEdkii" prefix could be used
Hey Udit,
You cannot explicitly influence the order of the calls, but implicitly via the
dependency tree, which means you need to make SerialPortLib depend on your
LibraryClass instance.
You did not mention which SerialPortLib instance you use, but probably you need
to execute FpgaInterfaceInit
hen
permanent memory has been installed.
>From what I can see, the described change only makes sense if InstallMemory is
>not called during the entire PEI phase. Am I missing something?
Thanks,
Marvin
> -Original Message-
> From: Cohen, Eugene
> Sent: Wednesday, July 18,
y 13, 2018 11:24 AM
> To: Marvin H?user ; edk2-
> de...@lists.01.org
> Cc: Dong, Eric ; Cohen, Eugene ;
> Gao, Liming ; Zeng, Star
> Subject: RE: Inquiry regarding early DxeIplPeim loading.
>
> Marvin,
>
> You can check SHA-1: ebaafbe62c70309d0ceb44a0c4199093d0a823c4.
&
Good day developers,
While checking out which edk2 modules request being shadowed, I came across
DxeIplPeim being one of them, however I am not sure why it was designed this
way.
If the Boot Mode is != S3, the module will register for shadowing and
immediately return during the pre-memory phas
Hey Star and Liming,
May I propose re-considering the introduction of a third named parameter to
reflect the first Language passed?
This would 1) have the advantage that the BOOLEAN parameter can remain as is,
which increases readability and
2) require at least two parameters related to the lang
Good day Abhishek,
I CC'd the MdeModulePkg maintainers, Ruiyu for the Platform BDS aspect (exposes
the ReadyToLock protocol) and Laszlo for his high-quality answers.
Strictly speaking you are, right, because of the description for the MM
protocol:
"Indicates that MM resources and services that
Good day,
While I was inspecting CpuS3DataDxe and the modules depending on its PCD
PcdCpuS3DataAddress, I noticed that DxeRegisterCpuFeaturesLib seemingly has an
asserted dependency on the PCD being ready when it its executed. I did neither
see a Depex entry, nor an event callback ensuring CpuS
Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Marvin H?user
> Sent: Wednesday, May 16, 2018 3:35 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID defi
Hey Sai and others,
I did not verify this is actually the case for QEMU, but the mentioned range is
usually the SMRAM ASEG.
SMRAM ranges are not reported in the Memory Map by-design.
Regards,
Marvin
> -Original Message-
> From: edk2-devel On Behalf Of Prakhya,
> Sai Praneeth
> Sent: Tu
Hey Star, Eric and everyone else,
I have seen that some platforms add a Boot Option for the UEFI Shell in
"PlatformBootManagerBeforeConsole()", which is called as part of the regular
boot flow.
This is surely beneficial for development platforms that are supposed to boot
to UEFI Shell by defaul
OvmfPkg builds fine here for X64/IA32-RELEASE-VS2013x86.
"'c:\Program' is not recognized as an internal or external command, operable
program or batch file." Indicates something trying to access a path with spaces
lacking proper quotation, so it's definitely a setup error on your side.
Maybe veri
e/edk2/tree/master/QuarkPlatformPkg/Acpi/Dx
> e/AcpiPlatform
> https://github.com/tianocore/edk2/tree/master/Vlv2TbltDevicePkg/AcpiPla
> tform
> ...
>
> Should more evaluation be done on them to see whether we can do more or
> we just suggest platform should implement its own AcpiPla
Good day,
Please consider for compatibility with some toolchains, byte-packed structs and
unions must be decorated with the define 'PACKED'.
Thanks,
Marvin.
> -Original Message-
> From: edk2-devel On Behalf Of Felix
> Polyudov
> Sent: Tuesday, February 27, 2018 10:07 PM
> To: edk2-deve
Good point with the DxeCore, I didn't consider that. Though OsBoot would be
irrelevant to the PEI phase, wouldn't it be?
Thanks,
Marvin
From: Yao, Jiewen [mailto:jiewen@intel.com]
Sent: Friday, February 2, 2018 1:40 PM
To: Marvin H?user ; edk2-devel@lists.01.org
Subject: RE: MinP
Dear developers, dear Jiewen,
I have been investigating the devel-MinPlatform branch of edk2-platforms for
educational purposes and got two questions regarding the Firmware Volume code
in PlatformInitPreMem, if you do not mind. I assume the tree was tested, so
most likely I misunderstood some t
assumed it was an oversight as MdePkg
is generic. If it wasn't, sorry.
Thanks,
Marvin
> -Original Message-
> From: Tim Lewis [mailto:tim.le...@insyde.com]
> Sent: Thursday, January 25, 2018 6:53 PM
> To: 'Supreeth Venkatesh' ; 'Marvin H?user'
> ; edk
Good day,
I noticed this patch lacks the definition of "EFI_FV_FILETYPE_MM_CORE" (0x0C).
Furthermore, may I suggest changing the *_SMM_* definitions to be defined via
the *_MM_* definitions?
Best regards,
Marvin.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.0
Dear developers,
First off, I'm writing this mail for educational purposes, so I would be very
thankful if I got a reply, though you will not miss anything if you skip it.
I was browsing several initialization codes of Intel platforms (the ones
included in the main edk2 repository, as well as M
For code style purposes, I suggest to declare the first member of the language
list as a third argument, process it, and then use it to get the following from
the VA.
Also, I think you forgot to CC the MdePkg maintainers, so I did with this mail.
Regards,
Marvin.
> -Original Message-
>
Hi Leo,
Yes, that's right. That PCD would be the only needed to be set by the platform
DSC.
Thanks,
Marvin
> -Original Message-
> From: Duran, Leo [mailto:leo.du...@amd.com]
> Sent: Thursday, October 5, 2017 4:57 PM
> To: 'Marvin H?user' ; edk2-
> de...@
Hey Jiewen,
Hey Leo,
May I suggest replacing "StandardSignatureIsAuthenticAMD()" and the PCDs
introduced by the series with a Fixed "PcdCpuVendor" enum or alike?
The contra of "StandardSignatureIsAuthenticAMD()" is that it's a runtime
action. From my point of view, this has no notable advantage
Hey,
I just noticed this patch as it recently has been pushed. I found this has been
a reaction to https://bugzilla.tianocore.org/show_bug.cgi?id=410
Though as Clang correctly detected, this is Undefined Behavior per the C
specification, so why was the warning hidden?
In context of the issue in
OL_GUID" be more fiting?
* The possible values for EFI_SPI_HC_PROTOCOL.Attributes are not defined.
* The possible values for EFI_SPI_IO_PROTOCOL.Attributes are not defined.
Thanks again for your time!
Regards,
Marvin.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On B
Sorry, I forgot to mention that the new SPI protocols still mention "SMM"
rather than "MM". Is this intended?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Marvin H?user
> Sent: Wednesday, September 6, 201
Dear UEFI contributors,
I am not an UEFI contributor and hence cannot submit changes. Could somebody
please take note of the following?
1. I do not see EFI_SPI_TRANSACTION_TYPE defined anywhere. There is a list
of names for possible values with descriptions (PI 1.6, Vol. 5, page 368),
thou
Good morning,
1.) Do you mean whether the OS exposes the Runtime Services? Windows and Linux
expose the Variable Services (Linux even more, if I remember correctly) and
macOS (not entirely sure about the latest version) the entire table via
DeviceTree.
2.) Yes, you need to write a DXE Runtime D
Dear developers,
While browsing the KabylakeSiPkg code, I noticed that 64-bit registers are read
directly via MmioRead64() as there is no PciRead64() function.
Is there a specific reason there are no PciRead64() and PciExpressRead64()
functions or were they simply not needed previously?
Thanks
> checked twice in two ASSERT(). In the original logic,
> InternalBaseLibIsListValid
> only runs once. Could we work out the same check logic?
>
> Thanks
> Liming
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>
Hello Yonghong and Andrew,
This patch may cause issues when compiling MSVC x IA32 as the optimizer might
replace the shift with an intrinsic.
I suggest you to use LShiftU64() rather than the << operator.
Regards,
Marvin.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...
A bunch of platforms, such as QuarkSocPkg, already declare such a PCD named
PcdPciExpressSize of type UINT64.
Maybe PcdPciExpressSize|UINT64 should be 'promoted' to a MdePkg PCD and the
platform-defined PCDs replaced?
Regards,
Marvin.
> -Original Message-
> From: edk2-devel [mailto:edk2
ntel.com]
> Sent: Tuesday, July 25, 2017 3:14 PM
> To: Marvin H?user ; edk2-
> de...@lists.01.org
> Cc: Zeng, Star
> Subject: RE: [UEFI PI 1.6/EDK2] Missing decorators for
> EFI_PEI_GET_VARIABLE2.
>
> ECR 1828: Add decorator 'OPTIONAL' for Attributes param
mailto:star.z...@intel.com]
> Sent: Tuesday, July 25, 2017 11:09 AM
> To: Marvin H?user ; edk2-
> de...@lists.01.org
> Cc: Zeng, Star
> Subject: RE: [UEFI PI 1.6/EDK2] Missing decorators for
> EFI_PEI_GET_VARIABLE2.
>
> As I know submitting ECR needs log in as a member at
ng
a dereference. Is this not the correct usage of IN? Is IN only used, when the
pointer's
destination is read?
Thanks again!
Regards,
Marvin.
> -Original Message-
> From: Zeng, Star [mailto:star.z...@intel.com]
> Sent: Tuesday, July 25, 2017 10:25 AM
> To: Marvin H?us
Dear developers,
I noticed that EFI_PEI_GET_VARIABLE2 is lacking decorators in both the UEFI PI
1.6 specification and the EDK2
codebase. The parameter description for 'Attributes' starts with 'If non-NULL',
hence it may be NULL, which is
not reflected in the function prototype with the decorator
Dear developers,
Dear KabylakeSiliconPkg devs: If you are not interested in the suggestion of
generic, shared modules, please read my comment on 2) nevertheless, as it
contains a potential bug report. Sorry, but I could not verify this yet.
I have been exploring the code of most of the Intel 'o
Hey,
I'm not sure if the situation changed as I did not check the license of every
single package, though in the past, at least the FAT driver was released under
a different license than the rest, due to Microsoft.
That has been resolved, though personally, I don't see a benefit in a top-level
One comment regarding the record allocation is inline.
Regards,
Marvin.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> lushifex
> Sent: Tuesday, July 4, 2017 10:24 AM
> To: edk2-devel@lists.01.org
> Cc: david@intel.com
> Subject: [edk2]
Hey,
The entry point declarations and the calling conventions have not changed since
EFI 1.10, though X64 was not a supported platform for 1.10 if I remember
correctly.
To be honest, I never saw an x64 EFI 1.10 implementation other than Apple's,
though even if it still signals that version, it'
Hey Rafael,
The UEFI calling conventions are detailed in the UEFI specification, more
specifically section 2.3 of the UEFI 2.7 specification.
Regards,
Marvin.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Rafael Machado
> Sent: Wednesday
Dear developers,
While performing some research tasks, I noticed that when
UefiDriverEntryPoint's _gDriverUnloadImageCount is 0 (only MODULE_UNLOAD
entries are count, DESTRUCTOR as they are used with libraries are not, as far
as I can see), EFI_LOADED_IMAGE_PROTOCOL.Unload is not set, even if l
Hey Mike,
Is the framework you plan to RFC a framework within the UEFI environment (UEFI
Shell) or within the OS?
Using the OS implementations of UEFI (Nt32 & Emulator) to run Unit Tests
without the need for a separate UEFI device or a reboot sounds pretty
compelling to me, to be honest.
Thank
Hey Rafael,
There actually is some generic SEC code in UefiCpuPkg you might want to take a
look at. It's generic because it does not have "Intel NDA" code, such as CAR
(Cache-As-RAM) etc.
The Reset Vector may or may not be part of SecCore. It's either embedded within
the SecCore module, or a se
heap nevertheless.
Regards,
Marvin.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Marvin H?user
> Sent: Saturday, August 13, 2016 3:47 AM
> To: edk2-devel@lists.01.org
> Cc: Andrew Fish
> Subject: Re: [edk2] [MdeModulePkg]
Hey Andrew,
Thank you very much! I suppose I was misguided by the ENTRY_POINT property
being PeiCore in the build file.
Regards,
Marvin.
> -Original Message-
> From: af...@apple.com [mailto:af...@apple.com]
> Sent: Saturday, August 13, 2016 4:47 AM
> To: Marvin H?user
>
Dear list subscribers,
I have just been looking around the PeiCore code and wondered, how it is
ensured, that the third ("Data") argument of the entry point is NULL on the
first run.
EFI_PEI_CORE_ENTRY_POINT only has two arguments and hence most SEC
implementations, including MdeModulePkg/SecCo
Hello Andrew,
Unfortunately I cannot test anything right now and I don't have a whole lot of
knowledge in this area, though I might have a hint for you.
While PpiList is equal to the original TempRam base, the TempRam based passed
to PEI is equal to the original TempRam base + the size of the P
Hey Feng,
According to the Contributions document, BSD 2-clause is one of the licenses
that can be accepted, if the parent license cannot be used:
https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Contributions.txt#L25
Regards,
Marvin.
> -Original Message-
> From: edk2-devel [m
Dear community members,
I have just been searching MdePkg for a GUID unknown to me and - to my surprise
- I found the same GUID twice in the code base:
EFI_HII_IMAGE_DECODER_PROTOCOL_GUID and EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_GUID.
As former was added only recently, I went to check the UEFI 2.6 s
Hey Andrew,
I have missed that it's not about the protocol directly, but about a returned
data structure, so please excuse me!
Thanks,
Marvin.
> -Original Message-
> From: af...@apple.com [mailto:af...@apple.com]
> Sent: Thursday, July 7, 2016 10:33 PM
> To: Marvin H
Hey Bruce,
Sorry if I am wasting your time, but where exactly is the problem?
I don't think these strings can ever be statically allocated. If pointers to
stack variables were used, the strings would be theoretically invalid the
moment the exposing function returns. Furthermore they can't be pa
Dear EDK2 community members,
Recently, I have gained interest in the Intel FSP and have been reading the
Intel documents regarding its design and integration with EDK2.
In the white paper 'A Tour Beyond BIOS Using the Intel(r) Firmware Support
Package with the EFI Developer Kit II', the chapter
.@intel.com]
> Sent: Wednesday, June 22, 2016 9:55 PM
> To: Marvin H?user ; edk2-
> de...@lists.01.org; Kinney, Michael D
> Subject: RE: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of
> FreePool() during ExitBS().
>
> Marvin,
>
> Yes. A V2 version of the patch that e
Dear EDK2 developers,
For an experimental project, I'm currently attempting to write a library
wrapper for the disassembler library 'Capstone' in a similar manner to
CryptoPkg's OpensslLib. As most C libraries, it also depends on the standard
headers, which are not provided by 'stock' EDK2. My
#x27;s the same situation, but with non-SMM
memory, so memory that does alter the UEFI Memory Map.
Regards,
Marvin.
> -Original Message-
> From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
> Sent: Wednesday, June 22, 2016 9:10 PM
> To: Marvin H?user ; edk2-
> de...@lists.0
Hey Star,
> I am still curious what is the real issue Marvin met.
There is no issue I met, I simply want to save another call to GetMemoryMap()
because it may be altered during ExitBS(). It's a break of the specification,
but it sounds like Intel complying to its own sepcification is not a
goo
Hey Bruce,
I think the exact behavior is not defined, though I remember reading (I'm not
sure if from the specification) that the OS loader should only keep calling
GetMemoryMap() and ExitBootServices() after the first ExitBootServices() call;
this would apply to drivers hooking the event as we
morrow, I think.
Regards,
Marvin.
> -Original Message-
> From: af...@apple.com [mailto:af...@apple.com]
> Sent: Wednesday, June 1, 2016 10:56 PM
> To: Marvin H?user
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] ASSERT and static code analysis
>
>
>
for more static analyzers
in the future?
If it indeed makes sense, I can get a patch ready, maybe today or tomorrow.
Regards,
Marvin.
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, June 1, 2016 10:38 PM
> To: Marvin H?user
> Cc: edk2-
Recently I was told that ASSERT() calls to check whether a variable is NULL
breaks the Clang Static Analyzer in terms of generating wrong warnings. The
reason is that, when a variable/parameter is checked for NULL, this analyzer
assumes that it can be. As it doesn't support EDK2 ASSERTs, but onl
Hey Mike,
Thank you very much for your effort of introducing a new directory structure,
it looks very nice so far!
Though, may I ask why IntelFspPkg and IntelFspWrapperPkg are now deprecated?
If 'deprecated' does not mean that the packages are likely to be removed, but
just means, if possible,
62 matches
Mail list logo
