Reviewed-by: Ray Ni
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, July 31, 2019 1:57 PM
> To: de...@edk2.groups.io; edk2-devel@lists.01.org
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek
> Subject: [PATCH 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Add check fo
All,
Now since EmulatorPkg supports to run in Windows environment, I propose to
remove Nt32Pkg.
Do you have any concern on the Nt32Pkg removal?
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-de
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, April 3, 2019 2:40 PM
> To: Ni, Ray ; edk2-devel@lists.01.org
> Subject: RE: [PATCH] UefiCpuPkg/Cpuid: Dump leaf 1FH information correctly
>
> Hi Ray,
>
> > -Original Message-
> > F
Reviewed-by: Ray Ni
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, April 3, 2019 10:46 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray
> Subject: [Patch v2] UefiCpuPkg/MpInitLib: Fix MemTest86 failure.
>
> V2 changes:
> Update the commit messa
> -Original Message-
> From: edk2-devel On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, April 2, 2019 4:49 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Cetola, Stephano ; Kinney, Michael D
> ; Gao, Liming ; Carsey,
> Jaben
> Subject: Re: [edk2] [RFC] Plan to delete ShellBinPkg from
Reviewed-by: Ray Ni
> -Original Message-
> From: Dong, Eric
> Sent: Friday, March 1, 2019 1:40 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: [Patch v2 4/4] UefiCpuPkg/RegisterCpuFeaturesLib: Correct comments.
>
> Cc: Ray Ni
> Cc:
Reviewed-by: Ray Ni
> -Original Message-
> From: edk2-devel On Behalf Of Eric Dong
> Sent: Friday, March 1, 2019 1:40 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch v2 3/4] UefiCpuPkg/RegisterCpuFeaturesLib: Simplify
> PcdCpuFeaturesSupport.
>
> PcdCpuFeaturesSupport used to
Minor comments:
1. Please add "CONST" before AndFeatureBitMask to declare that it won't be
changed in the routine.
SupportedMaskAnd (
IN UINT8 *SupportedFeatureMask,
IN CONST UINT8 *AndFeatureBitMask
)
2. Please update the year in the copyright.
With these comments ad
Reviewed-by: Ray Ni
Please remember to update the year in copyright when pushing.
> -Original Message-
> From: edk2-devel On Behalf Of Eric Dong
> Sent: Friday, March 1, 2019 1:40 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch v2 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Remove
https://devblogs.microsoft.com/cppblog/recommendations-to-speed-c-builds-in-visual-studio/#_PCH
Bob,
Per above article, It seems /Gm needs to be removed when /MP is used.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng,
> Bob C
> Sent: Fr
Reviewed-by: Ray Ni
Sent from small device
> 在 2019年3月29日，下午11:45，Vanguput, Narendra K 写道：
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1593
>
> For every SMI occurrence, save and restore CR2 register only when SMM
> on-demand paging support is enabled in 64 bit operation mode.
> Th
> -Original Message-
> From: Vanguput, Narendra K
> Sent: Friday, March 29, 2019 5:32 PM
> To: Ni, Ray ; edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Dong, Eric ;
> Laszlo Ersek
> Subject: RE: [edk2] [PATCH v6] UefiCpuPkg\CpuSmm: Save & restore CR2 on-
> demand paging
Guo,
Just to double confirm: UefiPayloadPkg will not require Legacy8254 timer
support.
The old packages Coreboot*Pkgs will be removed.
Which means now only QEMU/OVMF needs the Legacy8254 support.
Laszlo,
Now since QEMU/OVMF is the only consumer of the Legacy8254 driver, do you
agree that the Le
> + if ((!mCpuSmmStaticPageTable) && (Cr2 != 0)) {
Can the "Cr2 != 0" be removed?
> -Original Message-
> From: edk2-devel On Behalf Of
> nkvangup
> Sent: Friday, March 29, 2019 12:58 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Dong, Eric ;
> Laszlo Ersek
> Subject: [edk2] [PA
Reviewed-by: Ray Ni
> -Original Message-
> From: Zhang, Shenglei
> Sent: Friday, March 29, 2019 9:41 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray
> Subject: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused
> Guids
>
&g
Reviewed-by: Ray Ni
> -Original Message-
> From: Zhang, Shenglei
> Sent: Friday, March 29, 2019 9:41 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray
> Subject: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib
>
> With Itanium
0 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J ; Wu, Hao A ;
> Ni, Ray ; Zeng, Star ; Gao, Liming
> ; Sean Brogan ;
> Michael Turner ; Bret Barkelew
>
> Subject: [PATCH V5 14/17] MdeModulePkg: Add definitions for EDKII DEBUG
> PPI
>
> REF: https://bugzilla.tianoc
just remove the global variable and always locate the PPI?
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, March 28, 2019 4:10 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Wang, Jian J
> ; Wu, Hao A ; Ni, Ray
> ; Zeng, Star ; Sean Brogan
> ;
Thanks for the comments.
Sent out V2 with correct patch subject.
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, March 8, 2019 10:22 AM
> To: Ni, Ray ; edk2-devel@lists.01.org
> Subject: RE: [edk2] [PATCH 0/2] Fix bugs in HiiDatabase driver
>
> Quick commen
> -Original Message-
> From: edk2-devel On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, March 6, 2019 3:38 PM
> To: Ni, Ray
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] Does ARM platform produce MP protocol?
>
> On Wed, 6 Mar 2019 at 06:44, Ni, Ra
Pushed @ 219e560c20034843ac9917146c60db99bd01b6f4.
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, March 6, 2019 1:38 PM
> To: Ni, Ray ; edk2-devel@lists.01.org
> Cc: Dong, Eric ; Chen, Chen A
>
> Subject: RE: [edk2] [PATCH] UefiCpuPkg/Microcode.c: Add
Ard, Leif,
I am a bit interested in how ARM platform supports the MP?
PI Spec defines below protocol but I failed to find a driver in ARM platform
producing this protocol.
Or did I miss anything?
typedef struct _EFI_MP_SERVICES_PROTOCOL {
EFI_MP_SERVICES_GET_NUMBER_OF_PROCESSORS GetNumberOfProces
Liming,
Do I need any approval from you side before pushing the commit?
Thanks,
Ray
> -Original Message-
> From: edk2-devel On Behalf Of Ni, Ray
> Sent: Wednesday, March 6, 2019 10:15 AM
> To: Chen, Chen A ; edk2-devel@lists.01.org
> Cc: Dong, Eric
> Subject:
> -Original Message-
> From: edk2-devel On Behalf Of Jordan
> Justen
> Sent: Wednesday, March 6, 2019 5:48 AM
> To: Ni, Ray ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Laszlo Ersek
>
> Subject: Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install
>
Reviewed-by: Ray Ni
> -Original Message-
> From: edk2-devel On Behalf Of Chen A
> Chen
> Sent: Tuesday, March 5, 2019 8:21 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric
> Subject: [edk2] [PATCH] UefiCpuPkg/Microcode.c: Add verification before
> calculate CheckSum32
>
> REF: https:/
Original Message-
> From: Dong, Eric
> Sent: Tuesday, March 5, 2019 10:07 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray
> Subject: [Patch] UefiCpuPkg/MpInitLib: Direct allocate buffer for Wake up
> Buffer.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1538
>
>
> -Original Message-
> From: edk2-devel On Behalf Of Jordan
> Justen
> Sent: Sunday, March 3, 2019 5:45 AM
> To: Ni, Ray ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install
> TemporaryRamSupport PPI
>
> On 2019-03-02 04
> -Original Message-
> From: edk2-devel On Behalf Of Chen A
> Chen
> Sent: Thursday, February 28, 2019 2:03 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric
> Subject: [edk2] [PATCH 2/2] UefiCpuPkg/Microcode: Add verification logic
> before parsing payload
>
> REF: https://bugzilla.t
Reviewed-by: Ray Ni
> -Original Message-
> From: edk2-devel On Behalf Of Chen A
> Chen
> Sent: Thursday, February 28, 2019 2:03 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric
> Subject: [edk2] [PATCH 1/2] UefiCpuPkg/Microcode: Fix InComplete
> CheckSum32 issue
>
> REF: https://bugzi
Reviewed-by: Ray Ni
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, February 26, 2019 8:57 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray ; Zeng, Star ; Laszlo Ersek
>
> Subject: [PATCH v3 2/2] MdeModulePkg/RamDiskDxe: Res
Reviewed-by: Ray Ni
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, February 26, 2019 8:57 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray ; Zeng, Star ; Laszlo Ersek
>
> Subject: [PATCH v3 1/2] MdeModulePkg/PartitionDxe: Ensu
On 2/23/2019 1:16 AM, Laszlo Ersek wrote:
Yes, I was fully aware of that.
However:
The issue is that, in the BmReportLoadFailure() function, we do some
work*before* we call REPORT_STATUS_CODE_EX(). We have an ASSERT(), a
ZeroMem(), and a field assignment.
If status code reporting is disabled
Reviewed-by: Ray Ni
> -Original Message-
> From: edk2-devel On Behalf Of Hao Wu
> Sent: Friday, February 15, 2019 10:55 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A
> Subject: [edk2] [PATCH v1] MdeModulePkg/UfsBlockIoPei: Correct use of
> 'DeviceIndex' in BlkIO PPI
>
> REF:https://
Reviewed-by: Ray Ni
> -Original Message-
> From: Yao, Jiewen
> Sent: Friday, February 22, 2019 9:31 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Dong, Eric ; Ni, Ray
> ; Laszlo Ersek ; Yao, Jiewen
>
> Subject: [PATCH V3 0/4] A
Reviewed-by: Ray Ni
> -Original Message-
> From: Yao, Jiewen
> Sent: Friday, February 22, 2019 7:00 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Ni, Ray ; Laszlo Ersek
> ; Yao, Jiewen
> Subject: [PATCH V2 2/3] UefiCpuPkg/ExceptionLib: Add CET sup
Reviewed-by: Ray Ni
> -Original Message-
> From: Yao, Jiewen
> Sent: Friday, February 22, 2019 7:00 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Ni, Ray ; Laszlo Ersek
> ; Yao, Jiewen
> Subject: [PATCH V2 1/3] MdePkg/BaseLib: Add Shadow Stack Support for
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, February 21, 2019 6:41 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Wu, Hao A ;
> Wang, Jian J ; Ni, Ray ; Sean Brogan
> ; Zeng, Star
> Subject: [PATCH v3 1/5] MdeModu
Reviewed-by: Ray Ni
> -Original Message-
> From: Chen, Chen A
> Sent: Friday, February 22, 2019 8:34 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Ni, Ray ; Gao,
> Liming
> Subject: [PATCH] MdeModulePkg: Rename confusion function name
>
> REF: htt
Reviewed-by: Ray Ni
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen
> A Chen
> Sent: Friday, February 22, 2019 8:49 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] IntelSiliconPkg/MicrocodeUpdate: Fix incorrect
> checksum issue
> -Original Message-
> From: Justen, Jordan L
> Sent: Thursday, February 21, 2019 9:03 AM
> To: Gao, Liming ; Ni, Ray ; edk2-
> de...@lists.01.org
> Cc: Wu, Hao A ; Anthony Perard
> ; Laszlo Ersek ; Zeng,
> Star ; Andrew Fish
> Subject: RE: [PATCH 00/10
> -Original Message-
> From: Justen, Jordan L
> Sent: Thursday, February 21, 2019 1:44 AM
> To: Gao, Liming ; Ni, Ray ; edk2-
> de...@lists.01.org
> Cc: Wu, Hao A ; Anthony Perard
> ; Laszlo Ersek ; Zeng,
> Star
> Subject: Re: [PATCH 00/10] Fix PEI Core issue d
.
Thanks
Liming
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ray
Sent: Tuesday, February 19, 2019 10:46 AM
To: Justen, Jordan L ; edk2-devel@lists.01.org
Cc: Wu, Hao A ; Anthony Perard ;
Laszlo Ersek ; Zeng, Star
Subject: Re: [edk2] [PATCH 00
On 2/20/2019 4:16 PM, Laszlo Ersek wrote:
In the EFI_RETURN_STATUS_EXTENDED_DATA structure from PI-1.7, there may be
padding between the DataHeader and ReturnStatus members. The
REPORT_STATUS_CODE_EX() macro starts populating the structure immediately
after DataHeader, therefore the source data m
+
+/**
+ Entry point of the notification callback function itself within the PEIM.
+ It is to unlock HDD password for S3.
+
+ @param PeiServices Indirect reference to the PEI Services Table.
+ @param NotifyDescriptor Address of the notification descriptor data
structure.
+ @param
+OpalPasswordStorageSecurityPpiNotify (
+ IN EFI_PEI_SERVICES **PeiServices,
+ IN EFI_PEI_NOTIFY_DESCRIPTOR*NotifyDesc,
+ IN VOID *Ppi
)
{
- EFI_STATUSStatus;
- EFI_BOOT_MODE BootMode;
+ OPAL_PEI_DRI
+//
+// Check validity of the device path of the ATA AHCI controller.
+//
+Status = AhciCheckHcDevicePath (DevicePath, DevicePathLength);
1. Please avoid using "Check".
+if (EFI_ERROR (Status)) {
+ DEBUG ((
+DEBUG_ERROR, "%a: The device path is invalid for C
Please add some comments above "if" to explain why the it's only skipped
in S3 boot.
With the updated comments, Reviewed-by: Ray Ni
> +if ((BootMode == BOOT_ON_S3_RESUME) &&
> +(NvmeS3SkipThisController (DevicePath, DevicePathLength))) {
> + DEBUG ((
> +DEBUG_ERROR, "%a
How about changing to "NvmeIsHcDevicePathValid"? "Check" in function
name cannot tell what the return status means.
With the change, Reviewed-by: Ray Ni
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-dev
Reviewed-by: Ray Ni
--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
; From: Laszlo Ersek
> Sent: Wednesday, February 20, 2019 9:19 AM
> To: Bi, Dandan
> Cc: edk2-devel@lists.01.org; Wu, Hao A ; Ni, Ray
>
> Subject: Re: [edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when
> fail to load/start boot option
>
> Hi Dandan,
>
>
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, February 19, 2019 6:12 PM
> To: Ni, Ray ; edk2-devel@lists.01.org
> Cc: Gao, Liming ; Kinney, Michael D
>
> Subject: RE: [PATCH v2 1/2] MdePkg/UefiDevicePathLib: Add sanity check for
> FilePath
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, February 19, 2019 3:57 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Chaganty, Rangasai V
>
> Subject: [PATCH v2] IntelSiliconPkg/MicrocodeUpdateDxe: Error message
> enhancement
>
> The error
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, February 19, 2019 5:22 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Ni, Ray ; Kinney,
> Michael D
> Subject: [PATCH v2 1/2] MdePkg/UefiDevicePathLib: Add sanity check for
> FilePath device p
k2-devel@lists.01.org
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Chiu, Chasel
> Subject: [PATCH] UefiCpuPkg/SecCore: Wrong Debug Information for
> SecCore
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1533
>
> When SecCore and PeiCore in different FV, curren
Reviewed-by: Ray Ni
> -Original Message-
> From: Zeng, Star
> Sent: Monday, February 18, 2019 10:22 PM
> To: Wang, Jian J ; Zhang, Shenglei
> ; edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Ni, Ray
> Subject: RE: [PATCH] MdeModulePkg/PropertiesTableAttributesDxe:
u Yu
> ; Andrew Fish ; Anthony
> Perard ; Ard Biesheuvel
> ; Wu, Hao A ; Wang, Jian
> J ; Julien Grall ; Laszlo
> Ersek
> ; Ni, Ray ; Zeng, Star
>
> Subject: [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration
>
> https://github.com/jljusten/edk2.git temp-ram-s
I agree with Chao's comments.
Please add more code comments to:
1. describe the uCode format
2. explain all the 3 code blocks that checks the checksum.
> -Original Message-
> From: edk2-devel On Behalf Of Zhang,
> Chao B
> Sent: Tuesday, February 19, 2019 9:06 AM
> To: Chen, Chen A ; edk2
Zhichao,
Please separate the single patch to multiple patches so that every patch
just changes one component.
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, February 18, 2019 3:33 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Gao, Liming
> Subject: [PATCH
Reviewed-by: Ray Ni
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, February 18, 2019 3:33 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Gao, Liming
> Subject: [PATCH 2/2] MdeModulePkg: Add a runtime library instance of
> ResetSys
Jordan,
> Study the PeiCore migration logic a bit more, I found since PeiCore
> knows the exact size of new stack in permanent memory, it migrates
> old stack to the top of new stack.
> But the migration logic in above C code (since it doesn't know the
> size of new stack, CopySize is the size of
On 2/16/2019 3:43 PM, Ni, Ray wrote:
(Sent third times to make sure Andrew and Laszlo are in the TO list.)
I also met this issue.
I found three solutions:
1. Forcing PeiMain CC flag to "-O0" works.
2. Changing EmulatorPkg/Sec to not produce TemporaryRamSupportPpi also
works.
3. Imp
(Sent third times to make sure Andrew and Laszlo are in the TO list.)
I also met this issue.
I found three solutions:
1. Forcing PeiMain CC flag to "-O0" works.
2. Changing EmulatorPkg/Sec to not produce TemporaryRamSupportPpi also
works.
3. Implement the temporary migration routine as below in
I also met this issue.
I found three solutions:
1. Forcing PeiMain CC flag to "-O0" works.
2. Changing EmulatorPkg/Sec to not produce TemporaryRamSupportPpi also
works.
3. Implement the temporary migration routine as below in EmulatorPkg/Sec
module.
EFI_STATUS
EFIAPI
SecTemporaryRamSupport (
I also met this issue.
I found three solutions:
1. Forcing PeiMain CC flag to "-O0" works.
2. Changing EmulatorPkg/Sec to not produce TemporaryRamSupportPpi also
works.
3. Implement the temporary migration routine as below in EmulatorPkg/Sec
module.
EFI_STATUS
EFIAPI
SecTemporaryRamSupport (
Reviewed-by: Ray Ni
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Friday, February 15, 2019 9:40 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Ni, Ray ; Wu, Hao A ; Gao, Liming
> ; Kinney,
Reviewed-by: Ray Ni
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Chasel, Chiu
> Sent: Thursday, February 14, 2019 6:59 PM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Dong, Eric
> Subject: [edk2] [PATCH v3 3/3] UefiCpuPkg/SecCore:
Reviewed-by: Ray Ni
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Chasel, Chiu
> Sent: Thursday, February 14, 2019 6:59 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [edk2] [PATCH v3 1/3] MdePkg: Supp
Reviewed-by: Ray Ni
> -Original Message-
> From: Chiu, Chasel
> Sent: Thursday, February 14, 2019 6:59 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J ; Wu, Hao A ;
> Ni, Ray ; Zeng, Star ; Gao, Liming
> ; Chiu, Chasel
> Subject: [PATCH v3 2/3] MdeMo
Eric,
Please update the copyright year to 2019 for every file you changed.
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, February 13, 2019 10:04 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: [Patch 0/3] Simplify CPU Features solu
Reviewed-by: Ray Ni
On 2/13/2019 10:04 AM, Eric Dong wrote:
PcdCpuFeaturesSupport used to specify the platform policy about
what CPU features this platform supports. This value is decide by
platform owner, not by hardware. After this change, this PCD will
be used in IsCpuFeatureSupported functi
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, February 13, 2019 10:04 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: [Patch 2/3] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD
> PcdCpuFeaturesUserConfiguration.
>
>
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, February 13, 2019 5:47 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Chiu, Chasel
> Subject: [PATCH v2 3/3] UefiCpuPkg/SecCore: Support
> EFI_PEI_CORE_FV_LOCA
Sorry, please ignore my other review mail and just check this mail.
3 minor comments below.
> -Original Message-
> From: Chiu, Chasel
> Sent: Tuesday, February 12, 2019 9:20 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J ; Wu, Hao A ;
> Ni, Ray ; Zeng, Star ; Ga
1. please move the #include adjacent to other #include
2. Can you explain why
> -Original Message-
> From: Chiu, Chasel
> Sent: Tuesday, February 12, 2019 9:20 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J ; Wu, Hao A ;
> Ni, Ray ; Zeng, Star ; Gao, Limin
Chasel,
I don't think the below forward definition is needed.
typedef struct _EFI_PEI_CORE_FV_LOCATION_PPI EFI_PEI_CORE_FV_LOCATION_PPI;
It is needed when the PPI contains methods and the methods requires This pointer
as the first parameter.
> -Original Message-
> From: edk2-devel On Be
Reviewed-by: Ray Ni
--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Reviewed-by: Ray Ni
--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
On 2/11/2019 3:57 PM, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the definitions for EDKII PEI ATA PassThru PPI. This
PPI will provide services that allow ATA commands to be sent to ATA
devices attached to an ATA controller in the PEI phase.
More
On 2/11/2019 3:57 PM, Hao Wu wrote:
From: Sean Brogan
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1408
According to the information of the above BZ-1408 and other platform
owners, NVM Express devices are becoming more likely to be a critical
part during the boot process.
This commit wil
Reviewed-by: Ray Ni
--
Thanks,
Ray
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
There is an CRC16 calculation implementation in
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
Does your implementation generate the same CRC16 as above one?
> -Original Message-
> From: edk2-devel On Behalf Of Ming
> Huang
> Sent: Friday, February 1, 2019 2:02 PM
>
Reviewed-by: Ray Ni
> -Original Message-
> From: Solanki, Digant H
> Sent: Thursday, January 31, 2019 4:01 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Gao, Liming ;
> Chaganty, Rangasai V
> Subject: [PATCH 5/5] IntelSiliconPkg\Include\IndustryStandard: Update
On 1/31/2019 3:51 PM, Ard Biesheuvel wrote:
The POC code is inhttps://github.com/jyao1/edk2/tree/ReOrg.
It basically split the EDKII common code to three directories:
Core/, Device/, and Feature/.
I'm not sure I like the 'Device' name, but that's not that important
at this stage - I like that th
Even ECC doesn't complain, I still suggest to change
Encoding_table/Decoding_table to a proper name, e.g.:
EncodingTable/DecodingTable.
With the rename applied in V5 patch,
Reviewed-by: Ray Ni
___
edk2-devel mailing list
edk2-devel@lists.01.org
htt
On 1/31/2019 2:55 PM, Ni, Ray wrote:
On 1/31/2019 1:00 PM, Digant H Solanki wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1454
Based on latest IGD OpRegion Spec, IGD_OPREGION_MBOX3 needs to be
updated with two new members : Physical Address of Raw VBT Data (RVDA)
and Size of Raw
On 1/29/2019 10:21 PM, Leif Lindholm wrote:
Hi Ray,
First of all, thank you for restarting this discussion, and putting
the effort in for a POC.
On Tue, Jan 29, 2019 at 05:59:35AM +, Ni, Ray wrote:
Hello,
I'd like to propose to split today's BIG packages in foll
: TianoCore Contribution Agreement 1.1
Signed-off-by: Digant H Solanki
Cc: Liming Gao
Cc: Chaganty, Rangasai V
Cc: Ni, Ray
---
IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/IntelSiliconPkg/Include/IndustryStandard
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, January 31, 2019 10:49 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray ; Dong, Eric
> Subject: [PATCH v2 07/12] MdeModulePkg/NvmExpressPei: Consume
> S3StorageDeviceInitLis
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, January 31, 2019 10:49 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray ; Dong, Eric
> Subject: [PATCH v2 06/12] MdeModulePkg/NvmExpressPei: Add logic to
> produc
Reviewed-by: Ray Ni
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, January 31, 2019 10:49 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray
> Subject: [PATCH v2 05/12] MdeModulePkg/NvmExpressPei: Avoid updating
> the module-
Reviewed-by: Ray Ni
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, January 31, 2019 10:49 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray ; Dong, Eric
> Subject: [PATCH v2 03/12] MdeModulePkg: Add definitions for Storage
&
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, January 31, 2019 10:49 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray ; Dong, Eric
> Subject: [PATCH v2 04/12] MdeModulePkg: Add GUID for LockBox to save
> storage dev to i
Reviewed-by: Ray Ni
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, January 31, 2019 10:49 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray ; Dong, Eric
> Subject: [PATCH v2 01/12] MdeModulePkg: Add definitions for ATA AHCI
anuary 31, 2019 10:49 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray ; Dong, Eric
> Subject: [PATCH v2 02/12] MdeModulePkg: Add definitions for EDKII PEI ATA
> PassThru PPI
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
>
> This
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, January 29, 2019 7:12 PM
> To: Ni, Ray ; edk2-devel@lists.01.org
> Cc: Zimmer, Vincent ; Wolman, Ayellet
> ; Cetola, Stephano ;
> Kinn
Where does the macro name come from?
If it's not defined in Spec, how about to rename it to
"EFI_CAPSULE_FILE_DIRECTORY"?
> -Original Message-
> From: edk2-devel On Behalf Of Chen A Chen
> Sent: Tuesday, January 29, 2019 3:44 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Zh
Hello,
I'd like to propose to split today's BIG packages in following ways:
==Overview =
1. Separate Industry standard definitions from UEFI and PI interfaces.
2. Separate UEFI and PI interfaces from implementations.
a. Separate UEFI and PI interfaces to different
Minor comments regarding the parameter name.
> -Original Message-
> From: edk2-devel On Behalf Of Shenglei
> Zhang
> Sent: Thursday, January 10, 2019 8:44 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [edk2] [PATCH v2] MdePkg/BaseLib: Add Base64Encod
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: edk2-devel On Behalf Of Shenglei
> Zhang
> Sent: Wednesday, December 12, 2018 11:10 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [edk2] [PATCH v2 2/2] MdePkg/UefiDevicePathLib: Add a checking
> ste
only case that prevent
removing
the two framework packages.)
Would you like to do the clone? Or if you are busy, I can do that.
Thanks,
Ray
> -Original Message-
> From: David Woodhouse [mailto:dw...@infradead.org]
> Sent: Wednesday, January 23, 2019 5:49 PM
> To: Laszlo
1 - 100 of 107 matches
Mail list logo
