iesheuvel
> Sent: Thursday, December 7, 2017 12:47 AM
> To: Gao, Liming
> Cc: Wu, Hao A ; edk2-
> de...@lists.01.org; Andrew Fish ;
> Kinney, Michael D ; Laszlo
> Ersek ; Jeff Fan
> Subject: Re: [edk2] [Patch]
> SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate
>
mailto:ard.biesheu...@linaro.org]
>> Sent: Thursday, December 7, 2017 7:41 PM
>> To: Laszlo Ersek
>> Cc: Gao, Liming ; edk2-devel@lists.01.org; Kinney,
>> Michael D ; Wu, Hao A
>> ; Andrew Fish ; Jeff Fan
>>
>> Subject: Re: [edk2] [Patch] SourceLevelDebug
: Gao, Liming ; edk2-devel@lists.01.org; Kinney,
> Michael D ; Wu, Hao A
> ; Andrew Fish ; Jeff Fan
>
> Subject: Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
> duplicate symbol
>
> On 7 December 2017 at 11:18, Laszlo Ersek wrote:
> > On 12/07/17 09:46
On 7 December 2017 at 11:18, Laszlo Ersek wrote:
> On 12/07/17 09:46, Ard Biesheuvel wrote:
>> On 7 December 2017 at 07:48, Liming Gao wrote:
>>> From: Michael Kinney
>>>
>>> https://bugzilla.tianocore.org/show_bug.cgi?id=573
>>> https://bugzilla.tianocore.org/show_bug.cgi?id=796
>>>
>>> The sam
On 12/07/17 09:46, Ard Biesheuvel wrote:
> On 7 December 2017 at 07:48, Liming Gao wrote:
>> From: Michael Kinney
>>
>> https://bugzilla.tianocore.org/show_bug.cgi?id=573
>> https://bugzilla.tianocore.org/show_bug.cgi?id=796
>>
>> The same issue is reported again by GCC. Resend this patch again.
On 7 December 2017 at 07:48, Liming Gao wrote:
> From: Michael Kinney
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=573
> https://bugzilla.tianocore.org/show_bug.cgi?id=796
>
> The same issue is reported again by GCC. Resend this patch again.
> This patch renames the duplicated function name
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Thursday, December 07, 2017 3:48 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D; Wu, Hao A; Laszlo Ersek; Andrew Fish; Je
On 12/7/2017 3:48 PM, Liming Gao wrote:
From: Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=573
https://bugzilla.tianocore.org/show_bug.cgi?id=796
The same issue is reported again by GCC. Resend this patch again.
This patch renames the duplicated function name to fix it.
The S
On 12/7/2017 3:48 PM, Liming Gao wrote:
From: Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=573
https://bugzilla.tianocore.org/show_bug.cgi?id=796
The same issue is reported again by GCC. Resend this patch again.
This patch renames the duplicated function name to fix it.
The S
On 05/27/17 14:27, Ard Biesheuvel wrote:
> On 26 May 2017 at 23:06, Kinney, Michael D wrote:
>> Felix,
>>
>> Yes. I agree. I will work on a Bugzilla issue for this topic
>> and I prefer the idea of updating Base.h to check _MSC_VER value.
>>
>> The one challenge is that 'static' could be added i
On 26 May 2017 at 23:06, Kinney, Michael D wrote:
> Felix,
>
> Yes. I agree. I will work on a Bugzilla issue for this topic
> and I prefer the idea of updating Base.h to check _MSC_VER value.
>
> The one challenge is that 'static' could be added in front of
> GLOBAL_REMOVE_IF_UNREFERENCED, and i
Ersek
>
> Cc: Wu, Hao A ; edk2-devel@lists.01.org; Fan, Jeff
> ; Ard Biesheuvel
> Subject: RE: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
> duplicate symbol
>
> Another option to support older VS tool chains is to define
> GLOBAL_REMOVE_IF_UNREFERE
vel@lists.01.org; Fan, Jeff; Felix Poludov; Ard Biesheuvel
Subject: RE: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
duplicate symbol
Mike:
Yes. /Gw option is added since VS2013. The older VS version can't use this
option. I suggest we always define GLOBAL_REMOVE_IF_UNREFER
heuvel
>> ; Andrew Fish (af...@apple.com)
>> ; Kinney, Michael D
>> Cc: Wu, Hao A ; edk2-devel@lists.01.org; Fan, Jeff
>>
>> Subject: Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
>> duplicate symbol
>>
>> Laszlo,
>>
>>
alf Of
>> >Kinney, Michael D
>> >Sent: Friday, May 26, 2017 6:42 AM
>> >To: af...@apple.com; Laszlo Ersek ; Kinney, Michael
>D
>> >
>> >Cc: Wu, Hao A ; edk2-devel@lists.01.org; Fan, Jeff
>> >; Felix Poludov ; Ard Biesheuvel
>> >
>&g
t; >
> >Mike
> >
> >From: af...@apple.com [mailto:af...@apple.com]
> >Sent: Thursday, May 25, 2017 2:26 PM
> >To: Laszlo Ersek
> >Cc: Ard Biesheuvel ; Wu, Hao A
> >; edk2-devel@lists.01.org; Felix Poludov
> >; Kinney, Michael D ; Fan,
> >Je
Behalf Of
>Kinney, Michael D
>Sent: Friday, May 26, 2017 6:48 AM
>To: Laszlo Ersek ; Ard Biesheuvel
>; Andrew Fish (af...@apple.com)
>; Kinney, Michael D
>Cc: Wu, Hao A ; edk2-devel@lists.01.org; Fan, Jeff
>
>Subject: Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugA
l D
>Sent: Friday, May 26, 2017 6:42 AM
>To: af...@apple.com; Laszlo Ersek ; Kinney, Michael D
>
>Cc: Wu, Hao A ; edk2-devel@lists.01.org; Fan, Jeff
>; Felix Poludov ; Ard Biesheuvel
>
>Subject: Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
>duplicate symb
> To: Kinney, Michael D ; Ard Biesheuvel
> ; Andrew Fish (af...@apple.com)
> Cc: Wu, Hao A ; edk2-devel@lists.01.org; Fan, Jeff
>
> Subject: Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
> duplicate symbol
>
> On 05/25/17 21:57, Kinney, Michael D wrote:
> &g
From: af...@apple.com [mailto:af...@apple.com]
Sent: Thursday, May 25, 2017 2:26 PM
To: Laszlo Ersek
Cc: Ard Biesheuvel ; Wu, Hao A ;
edk2-devel@lists.01.org; Felix Poludov ; Kinney, Michael D
; Fan, Jeff
Subject: Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
duplicate symbol
> On May 25, 2017, at 2:02 PM, Laszlo Ersek wrote:
>
> On 05/25/17 22:37, Andrew Fish wrote:
>>
>>> On May 25, 2017, at 1:28 PM, Laszlo Ersek wrote:
>>>
>>> On 05/25/17 22:11, Ard Biesheuvel wrote:
On 25 May 2017 at 13:06, Kinney, Michael D
wrote:
> Laszlo and Andrew,
>
>
On 05/25/17 22:37, Andrew Fish wrote:
>
>> On May 25, 2017, at 1:28 PM, Laszlo Ersek wrote:
>>
>> On 05/25/17 22:11, Ard Biesheuvel wrote:
>>> On 25 May 2017 at 13:06, Kinney, Michael D
>>> wrote:
Laszlo and Andrew,
With the information that has been collected on this thread, I
>
> On May 25, 2017, at 1:28 PM, Laszlo Ersek wrote:
>
> On 05/25/17 22:11, Ard Biesheuvel wrote:
>> On 25 May 2017 at 13:06, Kinney, Michael D
>> wrote:
>>> Laszlo and Andrew,
>>>
>>> With the information that has been collected on this thread, I
>>> still think this patch in its original form
On 05/25/17 22:11, Ard Biesheuvel wrote:
> On 25 May 2017 at 13:06, Kinney, Michael D wrote:
>> Laszlo and Andrew,
>>
>> With the information that has been collected on this thread, I
>> still think this patch in its original form is a good change
>> to resolve the this one specific duplicate symb
On 25 May 2017 at 13:06, Kinney, Michael D wrote:
> Laszlo and Andrew,
>
> With the information that has been collected on this thread, I
> still think this patch in its original form is a good change
> to resolve the this one specific duplicate symbol issue for all
> tool chains. 'static' can no
On 05/25/17 21:57, Kinney, Michael D wrote:
> Laszlo,
>
> I have the same concern on final image sizes. I have done some
> evaluation:
>
> GCC5 OVMF X64 DEBUG without -whole-archive
> ==
> FV Space Information
> SECFV [19%Full] 212992 total, 42000 used, 1
Andrew Fish
>
> Subject: RE: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
> duplicate symbol
>
> Reviewed-by: Jeff Fan
>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
> Kinney
> Sent: Wednesda
On 05/25/17 21:55, Ard Biesheuvel wrote:
> On 25 May 2017 at 11:06, Laszlo Ersek wrote:
>> On 05/25/17 19:38, Kinney, Michael D wrote:
>>> Laszlo,
>>>
>>> I think the equivalent flag for GCC builds is --whole-archive.
>>>
>>> I tried adding that flag to DLINK_FLAGS in GCC5, and I get the
>>> follo
rsek [mailto:ler...@redhat.com]
> Sent: Thursday, May 25, 2017 11:07 AM
> To: Kinney, Michael D ; Ard Biesheuvel
> ; Andrew Fish (af...@apple.com)
> Cc: Wu, Hao A ; edk2-devel@lists.01.org; Fan, Jeff
>
> Subject: Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
>
ag to see if it
>> catches the same issue.
>
> Thanks!
> Laszlo
>
>>> -Original Message-
>>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>>> Sent: Thursday, May 25, 2017 9:09 AM
>>> To: Kinney, Michael D ; Ard Biesheuvel
>>> ; Andrew Fis
luating that flag to see if it
> catches the same issue.
Thanks!
Laszlo
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Thursday, May 25, 2017 9:09 AM
>> To: Kinney, Michael D ; Ard Biesheuvel
>> ; Andrew Fish (af...@apple.com)
&g
evel@lists.01.org; Fan, Jeff
>
> Subject: Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
> duplicate
> symbol
>
> On 05/25/17 03:47, Kinney, Michael D wrote:
> > Andrew,
> >
> > I think I have found an alternate fix for this XCODE5 specific
&
> On May 25, 2017, at 9:08 AM, Laszlo Ersek wrote:
>
> On 05/25/17 03:47, Kinney, Michael D wrote:
>> Andrew,
>>
>> I think I have found an alternate fix for this XCODE5 specific
>> build failure. Since there appears to be a difference in the
>> linker behavior between MSFT/GCC/XCODE tool cha
On 05/25/17 03:47, Kinney, Michael D wrote:
> Andrew,
>
> I think I have found an alternate fix for this XCODE5 specific
> build failure. Since there appears to be a difference in the
> linker behavior between MSFT/GCC/XCODE tool chains, I reviewed
> the 'ld' command line options used in XCODE5
On 05/24/17 22:18, Kinney, Michael D wrote:
> Laszlo,
>
> I agree with the request to add 'static' to the variable declaration
> in the SecPeiDebugAgentLib. The variable name change will be retained
> because the same symbol name can still be confusing when debugging.
>
> The part that is more con
; -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, May 24, 2017 5:38 PM
> To: Ard Biesheuvel ; Kinney, Michael D
>
> Cc: Laszlo Ersek ; Wu, Hao A ; edk2-
> de...@lists.01.org; af...@apple.com; Fan, Jeff
> Subject: RE: [edk2] [Patch] SourceLevelDebugPkg/SecPe
44 PM
> To: Kinney, Michael D
> Cc: Laszlo Ersek ; Wu, Hao A ; edk2-
> de...@lists.01.org; af...@apple.com; Fan, Jeff
> Subject: Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
> duplicate
> symbol
>
> On 24 May 2017 at 13:18, Kinney, Michael D wrote:
> &
On 24 May 2017 at 13:18, Kinney, Michael D wrote:
> Laszlo,
>
> I agree with the request to add 'static' to the variable declaration
> in the SecPeiDebugAgentLib. The variable name change will be retained
> because the same symbol name can still be confusing when debugging.
>
> The part that is m
rd
> Biesheuvel
> Sent: Wednesday, May 24, 2017 4:53 AM
> To: Laszlo Ersek
> Cc: Kinney, Michael D ; Wu, Hao A
> ;
> edk2-devel@lists.01.org; af...@apple.com; Fan, Jeff
> Subject: Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix
> duplicate
> symbol
On 24 May 2017 at 01:48, Laszlo Ersek wrote:
> CC Ard
>
> On 05/24/17 02:27, Kinney, Michael D wrote:
>> Andrew,
>>
>> I agree in this specific case, making the global variable static
>> should also resolve this issue.
>>
>> In general, we do not make module global variables static, so the
>> modu
CC Ard
On 05/24/17 02:27, Kinney, Michael D wrote:
> Andrew,
>
> I agree in this specific case, making the global variable static
> should also resolve this issue.
>
> In general, we do not make module global variables static, so the
> module global can be shared across multiple source files in th
Reviewed-by: Jeff Fan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
Kinney
Sent: Wednesday, May 24, 2017 7:21 AM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A; Kinney, Michael D; Laszlo Ersek; Andrew Fish; Fan, Jeff
Subject: [edk2] [Patch]
Andrew,
I agree in this specific case, making the global variable static
should also resolve this issue.
In general, we do not make module global variables static, so the
module global can be shared across multiple source files in the
module implementation.
Not sure why this issue has not been
Mike,
Do the other compilers promote (or is that demote) to static? Would not making
these lib globals, and private functions static solve this class of issue?
Thanks,
Andrew Fish
> On May 23, 2017, at 4:21 PM, Michael Kinney
> wrote:
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=573
>
44 matches
Mail list logo
