Re: [edk2] DevicePathToStr

2014-02-25 Thread John Davis
About the debugger. I did not know that. I had set a breakpoint in the uefi source back when you told me about the load address a while back. I'll try to debug an app using similar method. On Feb 25, 2014 6:10 PM, "Andrew Fish" wrote: > > On Feb 25, 2014, at 6:03 PM, John Davis wrote: > > Hello

Re: [edk2] [PATCH 1/1] MdeModulePkg: TerminalDxe: add other text resolutions

2014-02-25 Thread Laszlo Ersek
On 02/26/14 02:53, Tim Lewis wrote: > It could be a PCD. I would recommend against using EFI_GLYPH_HEIGHT and > EFI_GLYPH_WIDTH, since that is not necessarily the height of the system > font. > > > > The correct way is to call the GetFontInfo() function of the HII Font > protocol, with a NULL i

Re: [edk2] DevicePathToStr

2014-02-25 Thread Andrew Fish
On Feb 25, 2014, at 6:03 PM, John Davis wrote: > Hello Andrew, > > Thanks, I appreciate the pointer. > > FWIW, I have also learned based upon Bill Pauls previous Moo code sample, you > don't need to put apps in packages. I was using the > MdeModulePkg/Application/HelloWorld/ directory as a

Re: [edk2] DevicePathToStr

2014-02-25 Thread John Davis
Hello Andrew, Thanks, I appreciate the pointer. FWIW, I have also learned based upon Bill Pauls previous Moo code sample, you don't need to put apps in packages. I was using the MdeModulePkg/Application/HelloWorld/ directory as a source. I got tired of having to stop the emulator each time I ma

Re: [edk2] [PATCH 1/1] MdeModulePkg: TerminalDxe: add other text resolutions

2014-02-25 Thread Andrew Fish
On Feb 25, 2014, at 5:53 PM, Tim Lewis wrote: > It could be a PCD. I would recommend against using EFI_GLYPH_HEIGHT and > EFI_GLYPH_WIDTH, since that is not necessarily the height of the system font. > > The correct way is to call the GetFontInfo() function of the HII Font > protocol, with a

Re: [edk2] [PATCH 1/1] MdeModulePkg: TerminalDxe: add other text resolutions

2014-02-25 Thread Laszlo Ersek
On 02/26/14 02:44, Andrew Fish wrote: > > On Feb 25, 2014, at 5:23 PM, Li, Elvin > wrote: > >> Laszlo, >> Where do you get the video resolution list? I prefer to be more >> popular to cover most common resolutions we see. >> > > I wonder if you could add a mode that u

Re: [edk2] DevicePathToStr

2014-02-25 Thread Andrew Fish
On Feb 25, 2014, at 4:46 PM, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, John Davis had to > walk into mine at 16:34:49 on Tuesday 25 February 2014 and say: > >> Hmm. That is what I did to begin with. >> >> Here are my includes and my .inf. >> >> Now, I am rea

Re: [edk2] [PATCH 1/1] MdeModulePkg: TerminalDxe: add other text resolutions

2014-02-25 Thread Tim Lewis
It could be a PCD. I would recommend against using EFI_GLYPH_HEIGHT and EFI_GLYPH_WIDTH, since that is not necessarily the height of the system font. The correct way is to call the GetFontInfo() function of the HII Font protocol, with a NULL input for StringFontIn set to NULL. This will return t

Re: [edk2] [PATCH 1/1] MdeModulePkg: TerminalDxe: add other text resolutions

2014-02-25 Thread Laszlo Ersek
On 02/26/14 02:23, Li, Elvin wrote: > Laszlo, > Where do you get the video resolution list? I prefer to be more popular > to cover most common resolutions we see. I took the video resolution list from my other series: [edk2] [PATCH v2 12/19] OvmfPkg: QemuVideoDxe: add further BOCHS modes h

Re: [edk2] [PATCH 1/1] MdeModulePkg: TerminalDxe: add other text resolutions

2014-02-25 Thread Andrew Fish
On Feb 25, 2014, at 5:23 PM, Li, Elvin wrote: > Laszlo, > Where do you get the video resolution list? I prefer to be more popular > to cover most common resolutions we see. > I wonder if you could add a mode that used the PCD defaults and EFI_GYPH_HIGHT and EFI_GLYPH_WIDTH to calculate

Re: [edk2] [PATCH v2 00/19] OvmfPkg: improve video mode selection

2014-02-25 Thread Laszlo Ersek
On 02/26/14 00:17, Greg Elkin wrote: > Tested-by: Greg Elkin mailto:greg.el...@gmail.com>> > Works OK under qemu v1.7.0 with cirrus vga (1024x768, giving text mode > of 128x40). (not tested higher resolutions yet as need to setup spice > for -vga qxl) Awesome, thanks! :) Laszlo -

Re: [edk2] [PATCH 1/1] MdeModulePkg: TerminalDxe: add other text resolutions

2014-02-25 Thread Li, Elvin
Laszlo, Where do you get the video resolution list? I prefer to be more popular to cover most common resolutions we see. Thanks Elvin -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, February 26, 2014 3:00 AM To: edk2-devel@lists.sourceforge.net

Re: [edk2] [PATCH 2/1] MdeModulePkg: TerminalDxe: actually set resolution of PC ANSI type terms

2014-02-25 Thread Laszlo Ersek
On 02/26/14 01:05, Andrew Fish wrote: > > On Feb 25, 2014, at 2:04 PM, Laszlo Ersek > wrote: > >> The >> >> CSI Ps ; Ps ; Ps t >> >> escape sequence serves for window manipulation. We can use the >> >> CSI 8 ; ; t >> >> sequence to adapt eg. the xterm window size to

Re: [edk2] DevicePathToStr

2014-02-25 Thread John Davis
Hello Jaben, No I did not. Its odd. Sometimes you add packages and it seems to compile and link. Other times I have to add a library package. In this case, I added the GenericBdsLib in the [LibraryClasses] and now it links. Many thanks. I'll look into your suggestion on the other routine to g

Re: [edk2] [PATCH] OvmfPkg: implement LockBoxLib

2014-02-25 Thread Laszlo Ersek
Comparing this with v4 (which is basically identical to v5) and my notes for v4: On 02/24/14 19:15, Jordan Justen wrote: > From: Laszlo Ersek > > The S3 suspend/resume infrastructure depends on the LockBox library class. > The edk2 tree currently contains Null and SMM instances. The Null instanc

Re: [edk2] DevicePathToStr

2014-02-25 Thread Carsey, Jaben
Did you also add the library class to your INF file [LibraryClasses] section? From: John Davis [mailto:davi...@gmail.com] Sent: Tuesday, February 25, 2014 4:50 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] DevicePathToStr That fails as well. Creating library c:\fw\edk2\Build\N

Re: [edk2] DevicePathToStr

2014-02-25 Thread John Davis
That fails as well. Creating library c:\fw\edk2\Build\NT32IA32\DEBUG_VS2010x86\IA32\MdeModulePkg\Application\MyFindRom\MyFindRom\DEBUG\MyFindRom.lib and object c:\fw\edk2\Build\NT32IA32\DEBUG_VS201 0x86\IA32\MdeModulePkg\Application\MyFindRom\MyFindRom\DEBUG\MyFindRom.exp MyFindRom.lib(MyFindRo

Re: [edk2] DevicePathToStr

2014-02-25 Thread Carsey, Jaben
Depending on what you are doing with the resultant string ConvertDevicePathToText from DevicePathLib (header file located in MdePkg) is a much more common method to convert a device path to a text. This also supports some options on some conversion results. -Jaben -Original Message- F

Re: [edk2] DevicePathToStr

2014-02-25 Thread Bill Paul
Of all the gin joints in all the towns in all the world, John Davis had to walk into mine at 16:34:49 on Tuesday 25 February 2014 and say: > Hmm. That is what I did to begin with. > > Here are my includes and my .inf. > > Now, I am really puzzled. When I pasted the error from the build below,

Re: [edk2] DevicePathToStr

2014-02-25 Thread John Davis
Hmm. That is what I did to begin with. Here are my includes and my .inf. Now, I am really puzzled. When I pasted the error from the build below, I noticed the error is actually in the code I used as a model for this app. How could this app cause the other app which used to build to fail? --

Re: [edk2] DevicePathToStr

2014-02-25 Thread Bill Paul
Of all the gin joints in all the towns in all the world, John Davis had to walk into mine at 16:10:15 on Tuesday 25 February 2014 and say: > Hello > > I see some code which uses DevicePathToStr. When I do a grep on it, I see > it a few include files. > > 1. IntelFrameworkModulePkg > 2. OvmfPk

[edk2] DevicePathToStr

2014-02-25 Thread John Davis
Hello I see some code which uses DevicePathToStr. When I do a grep on it, I see it a few include files. 1. IntelFrameworkModulePkg 2. OvmfPkg 3. SecruityPkg I am working with the NT32 emulator so I'm guessing that I don't need the ones from source 2 and 3. However, when I try to include the h

Re: [edk2] [PATCH 2/1] MdeModulePkg: TerminalDxe: actually set resolution of PC ANSI type terms

2014-02-25 Thread Andrew Fish
On Feb 25, 2014, at 2:04 PM, Laszlo Ersek wrote: > The > > CSI Ps ; Ps ; Ps t > > escape sequence serves for window manipulation. We can use the > > CSI 8 ; ; t > > sequence to adapt eg. the xterm window size to the selected console mode. > > Reference:

Re: [edk2] [PATCH v2 00/19] OvmfPkg: improve video mode selection

2014-02-25 Thread Greg Elkin
Tested-by: Greg Elkin Works OK under qemu v1.7.0 with cirrus vga (1024x768, giving text mode of 128x40). (not tested higher resolutions yet as need to setup spice for -vga qxl) On 22 February 2014 00:58, Laszlo Ersek wrote: > This is v2 of the vidmode selection series (codenamed "be careful wh

Re: [edk2] [PATCH] ShellPkg/ShellProtocol.c: Fix case sensitivity in GetAlias and SetAlias

2014-02-25 Thread Carsey, Jaben
Looks good. Reviewed-by: Jaben Carsey From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Monday, February 24, 2014 11:18 AM To: edk2-devel@lists.sourceforge.net; Carsey, Jaben Cc: Brendan Jackman Subject: RE: [edk2] [PATCH] ShellPkg/ShellProtocol.c: Fix case sensitivity in GetAlias and

[edk2] [PATCH 2/1] MdeModulePkg: TerminalDxe: actually set resolution of PC ANSI type terms

2014-02-25 Thread Laszlo Ersek
The CSI Ps ; Ps ; Ps t escape sequence serves for window manipulation. We can use the CSI 8 ; ; t sequence to adapt eg. the xterm window size to the selected console mode. Reference: Suggested-by: Andrew Fish Contributed-under: TianoCore Contrib

Re: [edk2] [PATCH 0/1] MdeModulePkg: additional terminal (text) resolutions

2014-02-25 Thread Laszlo Ersek
On 02/25/14 20:36, Andrew Fish wrote: > Lazlo, > > If you are interested in this functionality you may want to consider > adding xterm terminal emulation. The reason being that xterm has an > escape sequence that sets the terminal size. So you could have the > mode set the terminal size. The remot

Re: [edk2] [PATCH 0/1] MdeModulePkg: additional terminal (text) resolutions

2014-02-25 Thread Andrew Fish
Lazlo, If you are interested in this functionality you may want to consider adding xterm terminal emulation. The reason being that xterm has an escape sequence that sets the terminal size. So you could have the mode set the terminal size. The remote terminal on the Unix system would then resize

[edk2] ASSERT_EFI_ERROR and nt32

2014-02-25 Thread John Davis
Hello I read an old post that this macro does not work on NT32. Is that still the case? I am running it within NT32 but it appears does not seem to do anything. -- John F. Davis 6 Kandes Court Durham, NC 27713 919-888-8358 独树一帜 --

Re: [edk2] assertion failure in Shell when scrolling back

2014-02-25 Thread Laszlo Ersek
On 01/15/14 14:06, Laszlo Ersek wrote: > On 01/15/14 04:22, Ni, Ruiyu wrote: >> Still no luck to reproduce it in OVMF. > > I can't reproduce it either... I guess I'll try to instrument the code > the next time it shows up. Thanks! I've run into another assertion failure -- it is quite reproducibl

[edk2] [PATCH 1/1] MdeModulePkg: TerminalDxe: add other text resolutions

2014-02-25 Thread Laszlo Ersek
When the console output is multiplexed to several devices by ConSplitterDxe, then ConSplitterDxe builds an intersection of text modes supported by all console output devices. Two notable output devices are provided by: (1) MdeModulePkg/Universal/Console/GraphicsConsoleDxe, (2) MdeModulePkg/Univers

[edk2] [PATCH 0/1] MdeModulePkg: additional terminal (text) resolutions

2014-02-25 Thread Laszlo Ersek
Dear MdeModulePkg maintainers, please review the patch in the next message. (1) If you deem it worthy and decide to apply it, please take care to format the SVN commit message as: - first line: Subject field of the [PATCH 1/1] email, that is: MdeModulePkg: TerminalDxe: add other text resoluti

Re: [edk2] [PATCH] ArmPkg/Library/BdsLib: Fix Linux kernel load when 1st call to BdsLoadImage fails.

2014-02-25 Thread Kirkendall, Garrett
Interesting, I was just fixing logic that was already there. If it is really desired to follow https://www.kernel.org/doc/Documentation/arm64/booting.txt BdsLinuxLoader.c should be simplified greatly. I think what my code will do is effectively move the system memory base to the lowest availab

[edk2] [PATCH 1/1] ArmPlatformPkg/Bds: stop inputting more characters when string is full

2014-02-25 Thread Ryan Harkin
If EditHIInputStr() is called, say with a MaxCmdLine of 2, the user is currently allowed to enter 2 characters. If the second character is a carriage return/line feed, this is substituted with a NULL and the function returns. If the second character is a regular character, the loop terminated and

[edk2] [PATCH 0/1] ArmPlatformPkg/Bds: stop inputting more characters when

2014-02-25 Thread Ryan Harkin
Hi Olivier, Here's the patch we discussed to stop the use inputting more characters than allowed. It also reverts the Boolean input back to 2 chars, as suggested in our email thread. Regards, Ryan. -- Flow-based real