On 08/15/14 08:22, Gao, Liming wrote:
> Hi,
> I just find one minor issue. PcdValidateOrderedCollection is
> PcdsFeatureFlag. It should be listed in [FeaturePcd] instead of [Pcd] section
> in INF file.
>
> +[Pcd]
> + gEfiMdePkgTokenSpaceGuid.PcdValidateOrderedCollection ## CONSUMES
Thank yo
Hi,
I just find one minor issue. PcdValidateOrderedCollection is PcdsFeatureFlag.
It should be listed in [FeaturePcd] instead of [Pcd] section in INF file.
+[Pcd]
+ gEfiMdePkgTokenSpaceGuid.PcdValidateOrderedCollection ## CONSUMES
Thanks
Liming
-Original Message-
From: Laszlo Ersek [
I think maybe PathCleanUpDirectories is not a good name to describe this API's
behavior. It's a API to normalize the file path but do nothing to the directory
content. Would "PathNormalize" be better?
-Original Message-
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Friday, A
Liming,
The patch looks good to me.
Reviewed-by: Michael Kinney
mailto:michael.d.kin...@intel.com>>
Mike
From: Gao, Liming [mailto:liming@intel.com]
Sent: Wednesday, August 13, 2014 7:18 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch 1/2] [IntelFrameworkPkg] INF/DEC file up
Liming,
Why was AARHCH64 was removed from VALID_ARCHITECTURES in BaseLib.inf and
BaseCpuLib.inf?
Thanks,
Mike
From: Gao, Liming [mailto:liming@intel.com]
Sent: Wednesday, August 13, 2014 7:13 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch 1/2] [MdePkg] INF/DEC file updates t
Hi, Reza
Do you see any impact with original code? Why we don't use
IdeInit.GetChannelInfo() is because we can get the info by AHCI PI register.
Thanks
Feng
-Original Message-
From: reza.jel...@tuhh.de [mailto:reza.jel...@tuhh.de]
Sent: Friday, August 15, 2014 08:20
To: edk2-devel@list
Hi, Reza
This is a reason to use IdeInit.ChannelCount rather than the constant value.
Some platforms may only expose one ide channel to external. By this way, we can
skip unnecessary enumeration time according to platform policy.
Do you see any real impact with original code?
Thanks
Feng
Larry:
The patch is good. Reviewed-by: Gao, Liming
-Original Message-
From: Hauch, Larry [mailto:larry.ha...@intel.com]
Sent: Friday, August 15, 2014 2:57 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch 1] Change svn:mime-type property on Unicode files
Hi Folks,
I agr
Hi, Olivier
Sorry for the late response. I will get back to you if I have progress.
Thanks
Feng
-Original Message-
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Friday, August 15, 2014 03:06
To: edk2-devel@lists.sourceforge.net; Tian, Feng
Cc: Brendan Jackman
Subject: RE: [
Hi Tim,
The "key" is used to compatible with framework code. I check the vfrcompile
code, found the "key" is worked only when "flags" field has "INTERACTIVE"
attribute. So the "key = 0" is not works for this sample code. I will follow
up to clean up this make user confused code.
Attach the i
Hess,
The patch is good.
Reviewed-by: Yingke Liu
Dennis
From: Chen, Hesheng [mailto:hesheng.c...@intel.com]
Sent: Thursday, August 14, 2014 3:16 PM
To: 'edk2-devel@lists.sourceforge.net'
Subject: [edk2] [Patch][Basetools]Enable long file path support on BaseTools
Hello all,
Could you help revi
The current grammar for VFR shows the following for "checkbox":
vfrStatementCheckBox ::=
"checkbox"
vfrQuestionHeader ","
{ "flags" "=" vfrCheckBoxFlags "," }
{ "key" "=" Number "," }
vfrStatementQuestionOptionList
"endcheckbox" ";"
And then a little further down it has this note:
From: Reza Jelveh
GetChannelInfo is called to initialize the SataController when
enumerating ports.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 16
1 file changed, 16 insertions(+)
d
From: Reza Jelveh
Some AHCI controllers such as the Marvel 9230 controllers do not send
PIO Setup FIS when the PIO data-in command is completed. Instead they
just send a D2H FIS.
To accomodate for this possibility the status code of the D2H FIS is
checked.
Contributed-under: TianoCore Contribut
From: Reza Jelveh
SataController reads host capabalities when the module is first loaded.
The Initialize method should only install the protocol. All host
specific information is read when ChannelInfo is accessed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelve
From: Reza Jelveh
SataController is moved to PcAtChipsetPkg for use in other packages such
as OVMF.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
DuetPkg/DuetPkg.fdf|2 +-
DuetPkg/DuetPkgIa32.dsc
From: Reza Jelveh
Currently IdeMode depends on SataController to set ChannelCount to
enumerate IDE devices. SataController sets ChannelCount to
ICH_IDE_MAX_CHANNEL, which is 2.
IdeMode should not be dependent on SataController and just use this
constant directly.
Contributed-under: TianoCore Co
From: Reza Jelveh
The SataController is moved to PcAtChipsetPkg where the IdeController
resides. The SataController is also enabled for OVMF.
Certain controllers such as Marvel 9230 controller use a D2H FIS instead
of PIO Setup FIS to denote the end of a PIO data-in command.
Some dependency on
From: Reza Jelveh
Removed:
- IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf
(provides gEfiDiskInfoProtocolGuid, gEfiBlockIoProtocolGuid)
- PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf
(provides gEfiIdeControllerInitProtocolGuid)
Added:
- MdeModulePkg/Bus/Ata/AtaBusDxe/At
Please review the attached patch.
This fixes the recently added dynamic command protocol to use the GUID defined
in the UEFI Shell 2.1 spec.
Thanks,
Chris
ShellPkg: Fix EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_GUID to match UEFI Shell 2.1
spec
Contributed-under: TianoCore Contribution
Reviewed-by: Jaben Carsey
From: Phillips, Chris J (Plano, TX) [mailto:chr...@hp.com]
Sent: Thursday, August 14, 2014 1:35 PM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Subject: ShellPkg: Fix EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_GUID to match UEFI
Shell 2.1 spec
Importance: High
Please r
Reviewed-by: Jaben Carsey
I didn't notice this email originally. I think that this looks like a good
change. What other feedback are you hoping for?
-Jaben
> -Original Message-
> From: Olivier Martin [mailto:olivier.mar...@arm.com]
> Sent: Thursday, August 14, 2014 12:06 PM
> To: edk
Ship it!
Thanks,
--Samer
-Original Message-
From: Hauch, Larry [mailto:larry.ha...@intel.com]
Sent: Thursday, August 14, 2014 1:57 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch 1] Change svn:mime-type property on Unicode files
Hi Folks,
I agree that we should modify th
Hi Mike,
Looks Good.
Reviewed-by: lhauch
Cheers,
Larry
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Thursday, August 14, 2014 11:59 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch][BaseTools] Fix --version in Rsa2048Sha256 tools
Larry,
Can you please review
Any feedback on this one?
Thanks,
Olivier
> -Original Message-
> From: Olivier Martin [mailto:olivier.mar...@arm.com]
> Sent: 24 March 2014 20:23
> To: feng.t...@intel.com
> Cc: Brendan Jackman; edk2-devel@lists.sourceforge.net
> Subject: [edk2] [PATCH 1/3] Move BasePathLib from ShellPkg
Larry,
Can you please review this patch that fixes the behavior of the -version flag
in the Rsa2048Sha256 tools and updates logic for showing program name, version,
usage, and copyright information to match other BaseTools.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
Hi Folks,
I agree that we should modify the svn property although it still does not fix
the issue with code reviews for the files.
I have attached the proposed patch; please review and let me know if there are
any issues.
Change svn:mime-type property on all Unicode files (extension .uni) in edk
Any feedback on this one?
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: 01 August 2014 20:06
To: 'Carsey, Jaben'
Cc: edk2-devel@lists.sourceforge.net; Harry Liebel
Subject: [PATCH] StdLibPrivateInternalFiles: Add AArch64 support
Dear StdLibPrivateInternalFiles maintainer,
Ple
Any feedback on this one?
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: 01 August 2014 20:01
To: 'Carsey, Jaben'
Cc: edk2-devel@lists.sourceforge.net; Harry Liebel
Subject: [PATCH] StdLib/LibC: Fix ARM symbol problems
Dear StdLib maintainer,
Please find the attached patch
Any feedback on this one?
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: 01 August 2014 20:03
To: 'Daryl McDaniel'
Cc: edk2-devel@lists.sourceforge.net; Harry Liebel
Subject: [PATCH] AppPkg: Enable ARM and AArch64 support
Dear AppPkg maintainer,
Please find the attached patch
Jaben -
There were three pieces of this (which were all geared towards making the
grammar easier to read by humans without losing specified behavior)
1) Removed some items out of the grammar. This included all conditionals.
In many case the generic "identifier" was substituted and the val
Reviewed-by: Jaben Carsey
From: Qiu, Shumin
Sent: Tuesday, August 12, 2014 6:29 PM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH]ShellPkg: Fix code style and build failure
Importance: High
Hi Jaben,
Can you help to review this patch.
ShellPkg: Fix code style and
Tim,
Can you elaborate on your rewrite? What needed to be done...
What do you think of having a shared "EBNF Document" that stores all the shared
EBNF items?
-Jaben
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Tuesday, August 12, 2014 3:46 PM
To: Hauch, Larry
Cc: edk2-devel@lists.sourc
It is not a problem for this patch (since the new UNI files are in the ZIP).
I agree that with UTF16 file types, the patch file itself is not very readable.
But at least I can take a patch file (from this email list for instance), and
apply it using SVN to my tree, and it will automatically appl
Line 615 stores TCR initially. Lines 663-672 modify the TCR variable, but then
there is no ArmSetTCR (TCR) call after lines 663-672.
Garrett Kirkendall [Description: Description: Description: purple]
SMTS Firmware Engineer | AMD Technology & Engineering
7171 Southwest Parkway, Austin, TX 78735
35 matches
Mail list logo
