Re: [edk2] [PATCH] MdeModulePkg : Misc comments and DEBUG messages

Scott, Thanks for reminder. The number one (1) and letter l (l) is so hard to distinguish that my subconscious treats this format string in debug message as %lx (letter L)… Samer, Could you help clarify what’s your original intention for this debug message? Do you want to use “l” or “1”? And I

Re: [edk2] DuetPkg: correct print formatting problem for gcc X64 build

Laszlo Ersek [mailto:ler...@redhat.com] wrote: Sent: Monday, November 03, 2014 10:34 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] DuetPkg: correct print formatting problem for gcc X64 build ]On 10/29/14 05:32, Scott Duplichan wrote: ]> Without patch: ]> LoadPe: new image base 7

Re: [edk2] [RFC PATCH V7 00/27] Introduce Mp Service protocol to UefiCpuPkg

That's fine. Thanks! Jeff -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, November 27, 2014 12:29 PM To: edk2-devel@lists.sourceforge.net; Chen, Fan; Justen, Jordan L Cc: Izumi, Taku Subject: Re: [edk2] [RFC PATCH V7 00/27] Introduce Mp Service protocol to

Re: [edk2] [PATCH v4 2/2] MdePkg: UefiScsiLib: do not encode LUN in CDB for other SCSI commands

On 11/27/14 02:36, Tian, Feng wrote: > Fine to me. let's wait MdePkg maintainer's feedback. Thanks, Feng! Mike -- can you spare a few cycles to look this over please? :) Thanks! Laszlo > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, November 27

Re: [edk2] [RFC PATCH V7 00/27] Introduce Mp Service protocol to UefiCpuPkg

On 11/27/14 04:25, Fan, Jeff wrote: > Ersek, > > This updating prevents others to use MP protocol on multiple > processors platform. I think another mail thread discussed solution > could solve your performance issue. > > If you cannot wait for it, could you introduce one MACRO in OvmfPkg > DSC

Re: [edk2] [RFC PATCH V7 00/27] Introduce Mp Service protocol to UefiCpuPkg

Ersek, This updating prevents others to use MP protocol on multiple processors platform. I think another mail thread discussed solution could solve your performance issue. If you cannot wait for it, could you introduce one MACRO in OvmfPkg DSC file temporary? Developer could pass its value by

Re: [edk2] UefiCpuPkg CpuMp improvement idea - Put APs to sleep when not busy

Yes. SIPI is simple way to wakeup APs without touch IDT table. But APs need to start from real mode. But Don't worry about SIPI performance. Per our experience. There are a few tasks assigned to APs during POST phase. The Ersek's issue will not exist. For fixed IPI solution, it's also good idea

Re: [edk2] UefiCpuPkg CpuMp improvement idea - Put APs to sleep when not busy

On Wed, 2014-11-26 at 11:10 -0800, Jordan Justen wrote: > On 2014-11-13 17:34:59, Chen, Fan wrote: > > On Thu, 2014-11-13 at 10:42 -0800, Jordan Justen wrote: > > > On 2014-11-06 17:23:01, Fan, Jeff wrote: > > > > Chen, > > > > > > > > Thanks your contribution. I will check-in your patch if ther

Re: [edk2] UefiCpuPkg CpuMp improvement idea - sync MTRRs

On Wed, 2014-11-26 at 13:09 -0800, Andrew Fish wrote: > > > On Nov 26, 2014, at 12:49 PM, Jordan Justen > > wrote: > > > > On 2014-11-26 12:07:53, Laszlo Ersek wrote: > > > On 11/26/14 20:28, Jordan Justen wrote: > > > > On 2014-11-13 17:34:59, Chen, Fan wrote: > > > > > Of course, I hope to he

Re: [edk2] [PATCH] MdeModulePkg : Misc comments and DEBUG messages

I just noticed the new statement: DEBUG((EFI_D_INFO, "PartitionValidMbr: Bad MBR partition size EndingLBA(%1x) > LastLBA(%1x)\n", EndingLBA, LastLba)); Both arguments are printed with the same %1x format, though the first is UINT32 while the second is EFI_LBA (UINT64). I believe tha

[edk2] Shell boot fail with UDK2014 & UDK2014.SP1

Hi Administrator, I built shell.efi with EDKII.SR1.UP1.P1 and it can boot to shell with following step 1. rename shell.efi to Bootx64.efi 2. copy Bootx64.efi to USB disk \EFI\Boot\ but fail with UDK2014 & UDK2014.SP1 with the same step. do I nee

Re: [edk2] UefiCpuPkg CpuMp improvement idea - Put APs to sleep when not busy

> On Nov 26, 2014, at 1:47 PM, Jordan Justen wrote: > > On 2014-11-26 12:56:06, Andrew Fish wrote: >> >>On Nov 26, 2014, at 11:10 AM, Jordan Justen >>wrote: >>One idea I have is to initialize the interrupt vector table on the >>APs, and then allow the APs to run the CpuSleep fu

Re: [edk2] [PATCH v4 2/2] MdePkg: UefiScsiLib: do not encode LUN in CDB for other SCSI commands

Fine to me. let's wait MdePkg maintainer's feedback. -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, November 27, 2014 00:09 To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH v4 2/2] MdePkg: UefiScsiLib: do not encode LUN in CDB for other SCSI c

Re: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles

Hi, Randy I found the IP4_COPY_ADDRESS macro usage in the patch is not consistent. Some are using CopyMem() and others are using IP4_COPY_ADDRESS(). I would uniform them to use IP4_COPY_ADDRESS macro when check in. Thanks Feng -Original Message- From: Pawell, Randy [mailto:randy.paw...

Re: [edk2] [RFC PATCH V7 00/27] Introduce Mp Service protocol to UefiCpuPkg

On Wed, 2014-11-26 at 16:43 +0100, Laszlo Ersek wrote: > On 11/26/14 15:48, Laszlo Ersek wrote: > > Hi, > > > > On 11/13/14 19:42, Jordan Justen wrote: > >> On 2014-11-06 17:23:01, Fan, Jeff wrote: > >>> Chen, > >>> > >>> Thanks your contribution. I will check-in your patch if there is no > >>> f

Re: [edk2] [PATCH] MdeModulePkg : Misc comments and DEBUG messages

Checked in at r16450. From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com] Sent: Wednesday, November 26, 2014 23:50 To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] MdeModulePkg : Misc comments and DEBUG messages Thanks Feng. Attached is the updated patch with the sugg

Re: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles

Feng, Attached is a revised MdeModulePkg patch. This is identical to my previous Patch01, except it omits I2cHost.c, to avoid conflict with Samer's change. Thanks, Randy Pawell MdeModulePkg: Source fixes and cleanup fo

Re: [edk2] [PATCH] MdeModulePkg : Update ACPI header file

Hi Samer This patch looks good. Thanks to catch it and fix it. Reviewed-by: Jiewen yao jiewen@intel.com Thank you Yao Jiewen From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com] Sent: Wednesday, November 26, 2014 11:55 PM To: edk2-devel@lists.sourcef

Re: [edk2] UefiCpuPkg CpuMp improvement idea - Put APs to sleep when not busy

On 2014-11-26 12:56:06, Andrew Fish wrote: > > On Nov 26, 2014, at 11:10 AM, Jordan Justen > wrote: > One idea I have is to initialize the interrupt vector table on the > APs, and then allow the APs to run the CpuSleep function. > > Like IdleLoopEventCallback does for the BSP

Re: [edk2] UefiCpuPkg CpuMp improvement idea - sync MTRRs

> On Nov 26, 2014, at 12:49 PM, Jordan Justen wrote: > > On 2014-11-26 12:07:53, Laszlo Ersek wrote: >> On 11/26/14 20:28, Jordan Justen wrote: >>> On 2014-11-13 17:34:59, Chen, Fan wrote: Of course, I hope to help improve the MP. >>> >>> Another idea I had (besides the AP sleep task) is t

Re: [edk2] UefiCpuPkg CpuMp improvement idea - Put APs to sleep when not busy

> On Nov 26, 2014, at 11:10 AM, Jordan Justen wrote: > > On 2014-11-13 17:34:59, Chen, Fan wrote: >> On Thu, 2014-11-13 at 10:42 -0800, Jordan Justen wrote: >>> On 2014-11-06 17:23:01, Fan, Jeff wrote: Chen, Thanks your contribution. I will check-in your patch if there is no >>>

Re: [edk2] UefiCpuPkg CpuMp improvement idea - sync MTRRs

On 2014-11-26 12:07:53, Laszlo Ersek wrote: > On 11/26/14 20:28, Jordan Justen wrote: > > On 2014-11-13 17:34:59, Chen, Fan wrote: > >> Of course, I hope to help improve the MP. > > > > Another idea I had (besides the AP sleep task) is to synchronize the > > APs MTRRs with the BSP. > > > > I thin

Re: [edk2] UefiCpuPkg CpuMp improvement idea - sync MTRRs

On 11/26/14 20:50, Brian J. Johnson wrote: > On 11/26/2014 01:28 PM, Jordan Justen wrote: >> On 2014-11-13 17:34:59, Chen, Fan wrote: >>> On Thu, 2014-11-13 at 10:42 -0800, Jordan Justen wrote: On 2014-11-06 17:23:01, Fan, Jeff wrote: > Chen, > > Thanks your contribution. I will ch

Re: [edk2] UefiCpuPkg CpuMp improvement idea - sync MTRRs

On 11/26/14 20:28, Jordan Justen wrote: > On 2014-11-13 17:34:59, Chen, Fan wrote: >> On Thu, 2014-11-13 at 10:42 -0800, Jordan Justen wrote: >>> On 2014-11-06 17:23:01, Fan, Jeff wrote: Chen, Thanks your contribution. I will check-in your patch if there is no further comments

Re: [edk2] UefiCpuPkg CpuMp improvement idea - sync MTRRs

On 11/26/2014 01:28 PM, Jordan Justen wrote: > On 2014-11-13 17:34:59, Chen, Fan wrote: >> On Thu, 2014-11-13 at 10:42 -0800, Jordan Justen wrote: >>> On 2014-11-06 17:23:01, Fan, Jeff wrote: Chen, Thanks your contribution. I will check-in your patch if there is no further comme

[edk2] UefiCpuPkg CpuMp improvement idea - sync MTRRs

On 2014-11-13 17:34:59, Chen, Fan wrote: > On Thu, 2014-11-13 at 10:42 -0800, Jordan Justen wrote: > > On 2014-11-06 17:23:01, Fan, Jeff wrote: > > > Chen, > > > > > > Thanks your contribution. I will check-in your patch if there is no > > > further comments from other guys. > > > > > > Reviewed

Re: [edk2] UefiCpuPkg CpuMp improvement idea - Put APs to sleep when not busy

On 11/26/14 20:10, Jordan Justen wrote: > On 2014-11-13 17:34:59, Chen, Fan wrote: >> On Thu, 2014-11-13 at 10:42 -0800, Jordan Justen wrote: >>> On 2014-11-06 17:23:01, Fan, Jeff wrote: Chen, Thanks your contribution. I will check-in your patch if there is no further comments

[edk2] UefiCpuPkg CpuMp improvement idea - Put APs to sleep when not busy

On 2014-11-13 17:34:59, Chen, Fan wrote: > On Thu, 2014-11-13 at 10:42 -0800, Jordan Justen wrote: > > On 2014-11-06 17:23:01, Fan, Jeff wrote: > > > Chen, > > > > > > Thanks your contribution. I will check-in your patch if there is no > > > further comments from other guys. > > > > > > Reviewed

Re: [edk2] EFI_BOOT_SERVICES AllocatePool() hang

> On Nov 26, 2014, at 6:14 AM, Debabrata Chattopadhyay > wrote: > > Hi, > > In our option ROM for our storage controller , I am trying to allocate some > memory using BS->AllocatePool().I see that the call just hangs and never > comes out. > > Basically , we have a structure like this : >

Re: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles

I resubmitted the patch with the '\n' added. Thanks, --Samer -Original Message- From: Pawell, Randy Sent: Wednesday, November 26, 2014 11:00 AM To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles Hi Feng, I

Re: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles

Hi Feng, I think Samer's new debug message will be fine, providing you add the missing '\n'. The Status variable will then become an in-use variable instead of unused, and so you should remove this file MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c from my submission. Good catch on the conflict. T

[edk2] [PATCH v4 1/2] MdePkg: UefiScsiLib: do not encode LUN in CDB for READ and WRITE

The "SCSI Block Commands - 2" (SBC-2) standard defines bits [7:5] of the CDB byte 1 as Reserved, for the READ and WRITE commands. The updated "SCSI Block Commands - 3" (SBC-3) standard defines the same bitfield as RDPROTECT and WRPROTECT, respectively. After reviewing the above standards, and the

[edk2] [PATCH v4 2/2] MdePkg: UefiScsiLib: do not encode LUN in CDB for other SCSI commands

The TEST UNIT READY, INQUIRY, MODE SENSE, REQUEST SENSE and READ CAPACITY commands define bits [7:5] of Cdb[1] as Reserved (potentially as part of a larger Reserved bitfield): Command Reserved bitfield in Cdb[1] SCSI spec reference -- ---

[edk2] [PATCH v4 0/2] MdePkg: UefiScsiLib: do not encode LUN in CDB

Several SCSI command implementations in UefiScsiLib encode the LUN in Cdb[1] bits [7:5]. For READ and WRITE commands, this conflicts directly with the RDPROTECT and WRPROTECT bitfield definitions in SBC-3, whereas for a number of other commands it conflicts with Reserved (all-bits-zero) bitfield de

Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol

Tim, I see your point, and it does make sense to keep the Shell as independent as possible .On the other hand, commands like DH are very useful for debugging, and we should not artificially limit their capabilities because of EDK2 source structure. I vote for your second proposal: duplicate th

Re: [edk2] [PATCH] MdeModulePkg : Fix memory leak in Ip4Config

Thanks Feng. Can you please commit the change? From: Tian, Feng [mailto:feng.t...@intel.com] Sent: Tuesday, November 25, 2014 6:33 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] MdeModulePkg : Fix memory leak in Ip4Config Agree, it's obviously a bug. Reviewed-by: Feng Tian m

Re: [edk2] [PATCH] MdeModulePkg : Update ACPI header file

Thanks Jiewen. Attached is the updated path for ACPI 5.0 and 5.1. Thanks, --Samer From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Tuesday, November 25, 2014 6:48 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] MdeModulePkg : Update ACPI header file Hi Samer This patch l

Re: [edk2] [PATCH] MdeModulePkg : Misc comments and DEBUG messages

Thanks Feng. Attached is the updated patch with the suggested changes. Please confirm once this is committed. Thanks, --Samer From: Tian, Feng [mailto:feng.t...@intel.com] Sent: Tuesday, November 25, 2014 6:44 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] MdeModulePkg : Mis

Re: [edk2] [RFC PATCH V7 00/27] Introduce Mp Service protocol to UefiCpuPkg

On 11/26/14 15:48, Laszlo Ersek wrote: > Hi, > > On 11/13/14 19:42, Jordan Justen wrote: >> On 2014-11-06 17:23:01, Fan, Jeff wrote: >>> Chen, >>> >>> Thanks your contribution. I will check-in your patch if there is no >>> further comments from other guys. >>> >>> Reviewed-by: Jeff Fan >> >> Chen

Re: [edk2] [RFC PATCH V7 00/27] Introduce Mp Service protocol to UefiCpuPkg

On 11/26/14 15:48, Laszlo Ersek wrote: > Hi, > > On 11/13/14 19:42, Jordan Justen wrote: >> On 2014-11-06 17:23:01, Fan, Jeff wrote: >>> Chen, >>> >>> Thanks your contribution. I will check-in your patch if there is no >>> further comments from other guys. >>> >>> Reviewed-by: Jeff Fan >> >> Chen

Re: [edk2] [RFC PATCH V7 00/27] Introduce Mp Service protocol to UefiCpuPkg

Hi, On 11/13/14 19:42, Jordan Justen wrote: > On 2014-11-06 17:23:01, Fan, Jeff wrote: >> Chen, >> >> Thanks your contribution. I will check-in your patch if there is no >> further comments from other guys. >> >> Reviewed-by: Jeff Fan > > Chen, > > I committed your series (r16345-r16371) for Je

[edk2] EFI_BOOT_SERVICES AllocatePool() hang

Hi, In our option ROM for our storage controller , I am trying to allocate some memory using BS->AllocatePool().I see that the call just hangs and never comes out. Basically , we have a structure like this : Struct A { //some elements void * ptr;

Re: [edk2] [PATCH v2] MdePkg: UefiScsiLib: do not encode LUN in CDB for READ and WRITE

On 11/26/14 14:02, Laszlo Ersek wrote: > Here's what I propose: let's keep my *v3* patch (ie. not this v2 one) > as-is, and I will send a followup patch (as PATCH v3 2/1) that covers > the above. I think it makes some sense to keep the patches separate, as > the first one fixes an actual mis-mappi

Re: [edk2] [PATCH v2] MdePkg: UefiScsiLib: do not encode LUN in CDB for READ and WRITE

On 11/26/14 02:39, Tian, Feng wrote: > Hi, Laszlo > > Shall we cleanup all of APIs in UefiScsiLib? I did notice that they have similar LUN encodings but I assumed those were okay. However... > Looks like TEST_UNIT_READY, according to SPC-4, 6.37, the entire Cdb[1] byte is Reserved, > INQUIRY,

[edk2] [BUG] UefiCpuDxe: duplicate symbol ExitBootServicesCallback

Hi, duplicate symbol _ExitBootServicesCallback in: CpuDxe.obj and CpuMp.obj. One of them should be excluded or renamed. Wishes, Sergey -- Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Inst