: Wednesday, July 15, 2015 9:39 AM
To: Kinney, Michael D; Scott Duplichan; edk2-devel@lists.sourceforge.net
Cc: Mcdaniel, Daryl
Subject: Re: [edk2] [PATCH] BaseTools: Add GCC49LTO tool chain: GCC49 with link
time optimization
On 7/15/2015 10:11 AM, Kinney, Michael D wrote:
> Is adding -Wl to those l
-mabi=ms"
Best regards,
Mike
-Original Message-
From: Scott Duplichan [mailto:sc...@notabs.org]
Sent: Wednesday, July 15, 2015 12:03 AM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net
Subject: RE: [edk2] [PATCH] BaseTools: Add mechanism to override or add CC_FLAG
...@notabs.org]
Sent: Wednesday, July 15, 2015 12:03 AM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net
Cc: Mcdaniel, Daryl
Subject: RE: [edk2] [PATCH] BaseTools: Add GCC49LTO tool chain: GCC49 with link
time optimization
Kinney, Michael D [mailto:michael.d.kin...@intel.com] wrote:
]
]Sent: Tuesday
Scott,
We try to minimize the build dependencies on environment variables. There are
several mechanisms already available to append CC_FLAGS. Can you please
provide more details on why the environment variable based method is better
than the existing methods?
Thanks,
Mike
-Original Mes
Hi Scott,
What is the purpose of GCCLINK_PREFIX? Why can't the Wl flag just be included
in tools_def.txt as required?
Thanks,
Mike
-Original Message-
From: Scott Duplichan [mailto:sc...@notabs.org]
Sent: Tuesday, July 14, 2015 9:44 AM
To: edk2-devel@lists.sourceforge.net
Cc: Mcdaniel
Oliver,
Reviewed-by: Michael Kinney
Mike
-Original Message-
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Tuesday, July 14, 2015 8:14 AM
To: Kinney, Michael D; Gao, Liming
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [PATCH] MdePkg/ImageAuthentication.h: Fixed ARM
understating correct?
Thanks,
Mike
-Original Message-
From: Roy Franz [mailto:roy.fr...@linaro.org]
Sent: Wednesday, June 24, 2015 11:17 AM
To: edk2-devel@lists.sourceforge.net
Cc: ler...@redhat.com; Kinney, Michael D
Subject: Re: [edk2] [PATCH] MdePkg: Describe submission of a patch
Doman,
Thanks for providing this.
In general, we like to put C functions that abstract CPU instructions in
MdePkg/BaseLib. Do you think it makes sense to add 8/16/32/64 bit functions to
BaseLib for the rdrand instruction. Then have the SecurityPkg library use the
functions from BaseLib to ex
Jordan,
Yes. With that one comment added, the entire series looks good to me..
Reviewed-by: Michael Kinney
Mike
-Original Message-
From: Justen, Jordan L
Sent: Sunday, June 07, 2015 11:13 PM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net
Cc: Liu, Yingke D; Laszlo Ersek
encodings so it can be used to
convert current UTF-16LE to UTF-8 too.
Thanks,
Mike
-Original Message-
From: Justen, Jordan L
Sent: Monday, June 01, 2015 12:32 AM
To: edk2-devel@lists.sourceforge.net
Cc: Justen, Jordan L; Liu, Yingke D; Kinney, Michael D; Laszlo Ersek
Subject: [PATCH v3 4/8
terminal type to
MdeModulePkg/Universal/Console/TerminalDxe.
Best regards,
Mike
-Original Message-
From: Roy Franz [mailto:roy.fr...@linaro.org]
Sent: Thursday, May 14, 2015 1:44 PM
To: Kinney, Michael D
Cc: Yao, Jiewen; edk2-devel@lists.sourceforge.net;
linaro-u...@lists.linaro.org
Jiewen,
I think most of the terminal emulators being discussed here layer on top of a
TTY device.
How about TtyTerm instead?
Mike
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, May 13, 2015 7:13 PM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net;
linaro-u
edk2-devel@lists.sourceforge.net
Cc: Yao, Jiewen; linaro-u...@lists.linaro.org; Tian, Feng; Kinney, Michael D
Subject: Re: [edk2] [RFC 0/4] New terminal type for Linux
> On May 13, 2015, at 6:23 PM, Kinney, Michael D
> wrote:
>
> Jiewen,
>
> Adding more GUIDs is possible i
, May 13, 2015 6:20 PM
To: edk2-devel@lists.sourceforge.net
Cc: Kinney, Michael D; linaro-u...@lists.linaro.org; Tian, Feng
Subject: Re: [edk2] [RFC 0/4] New terminal type for Linux
> On May 13, 2015, at 6:15 PM, Yao, Jiewen wrote:
>
> OK. I also have interest to know how to handle b
: Yao, Jiewen
Sent: Wednesday, May 13, 2015 6:16 PM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net;
linaro-u...@lists.linaro.org; Tian, Feng
Subject: RE: [edk2] [RFC 0/4] New terminal type for Linux
OK. I also have interest to know how to handle below case mentioned by patch
submitter
terminal
type should be very small. Especially since the TerminalDxe driver is usually
compressed.
Thanks,
Mike
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, May 13, 2015 5:59 PM
To: edk2-devel@lists.sourceforge.net; linaro-u...@lists.linaro.org; Tian, Feng;
Kinney, Michael D
Roy,
The new GUID for this terminal type should not be defined in the MdePkg. The
MdePkg is intended to only contain content from industry standard
specifications.
I recommend you add the GUID for this new terminal type to the MdeModulePkg so
it is in the same package that contains the termin
Jordan,
Yes. It is being implemented. You should start seeing details in the next
week or two.
Mike
-Original Message-
From: Jordan Justen [mailto:jordan.l.jus...@intel.com]
Sent: Monday, May 11, 2015 9:46 PM
To: Gao, Liming; edk2-devel@lists.sourceforge.net; Chan, Amy
Cc: Davis, Bra
] [PATCH] Treat ASCII DEL (0x7f) as backspace
On 05/08/15 04:26, Roy Franz wrote:
> On Thu, May 7, 2015 at 7:03 PM, Kinney, Michael D
> wrote:
>> Roy,
>>
>> Did you try the command line at the UEFI Shell prompt through a
>> serial terminal? There is line editing ava
Felix,
I like the more detailed comments.
Mike
-Original Message-
From: Felix Poludov [mailto:fel...@ami.com]
Sent: Friday, May 08, 2015 6:43 AM
To: Ni, Ruiyu; Kinney, Michael D; edk2-devel@lists.sourceforge.net; Andrew Fish
Subject: RE: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION
Roy,
Did you try the command line at the UEFI Shell prompt through a serial
terminal? There is line editing available, where backspace and delete keys
perform different actions. I think your change prevents a user from ever
getting the delete key behavior. Same would be true for the UEFI She
-
From: Felix Poludov [mailto:fel...@ami.com]
Sent: Thursday, May 07, 2015 11:50 AM
To: edk2-devel@lists.sourceforge.net; Andrew Fish; Kinney, Michael D; Ni, Ruiyu
Subject: RE: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition.
The EFI_LOAD_OPTION was not defined in the UEFI specification
Use pragma to disable warning 4200 for all VS* and DDK* toolchains to support
data structure declarations where the last field of the data structure is a
flexible array member.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
mailto:michael.d.kin...@intel.co
Brian,
Yes. DDK3790 toolchain works when warning 4200 is disabled.
Mike
-Original Message-
From: Brian J. Johnson [mailto:bjohn...@sgi.com]
Sent: Tuesday, May 05, 2015 11:43 AM
To: edk2-devel@lists.sourceforge.net; Laszlo Ersek; Kinney, Michael D
Cc: Zhang, Chao B
Subject: Re: [edk2
Jordan,
My main point about the spec is that both need to be updated if this concept is
accepted. Not that one has to be done before the other.
Mike
-Original Message-
From: Justen, Jordan L
Sent: Tuesday, May 05, 2015 11:52 AM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net
compatibility with other tools, then what would that helper tool do
with a non UCS-2 character? It is just easier for the whole file to use the
same character set.
Best regards,
Mike
-Original Message-
From: Justen, Jordan L
Sent: Tuesday, May 05, 2015 10:53 AM
To: Kinney, Michael D; edk2
, Michael D
Cc: edk2-devel@lists.sourceforge.net; Zhang, Chao B; Mcdaniel, Daryl
Subject: Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout
On 05/05/15 19:34, Kinney, Michael D wrote:
> Laszlo,
>
> I agree with the general guidance from that thread. However, data
]
Sent: Tuesday, May 05, 2015 8:53 AM
To: Kinney, Michael D
Cc: edk2-devel@lists.sourceforge.net; Zhang, Chao B; Mcdaniel, Daryl
Subject: Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout
Hello Mike,
On 05/05/15 17:35, Kinney, Michael D wrote:
> Forward reference decla
#x27;, PARSER_ERROR,
'%s contains invalid UCS-2 character at line %d.' % (File.Path, LineNumber))
Best regards,
Mike
-----Original Message-
From: Justen, Jordan L
Sent: Tuesday, May 05, 2015 12:09 AM
To: edk2-devel@lists.sourceforge.net
Cc: Justen, Jordan L; Liu, Yingke D; Kinne
Forward reference declarations are not required for this file and should be
removed.
Also, the Image[1] field of the DISPLAY_DISPLAY_PAYLOAD structure should be
declared as Image[]. That is the recommended style for new structure
declarations that have a variable sized array as the last field
, Jordan L
Sent: Monday, May 04, 2015 3:02 PM
To: edk2-devel@lists.sourceforge.net; Brian J. Johnson; Kinney, Michael D
Subject: Re: [edk2] [PATCH 0/9] Support UTF-8 (.utf8) string files
On 2015-05-04 14:32:48, Brian J. Johnson wrote:
> On 05/04/2015 02:11 PM, Laszlo Ersek wrote:
> > I
Jordan,
Some source control systems provide support a file type of UTF-16LE, so the use
of 'binary' should be avoided. What source control systems require the use of
'binary'? What diff utilities are having issues with UTF-16LE files? Can you
provide some examples?
Also, what are the pros/c
Ray,
The idea of adding EFI_LOAD_OPTION structure to MdePkg .h files has been
considered before.
This is not defined as a C data structure in the UEFI Specification. Instead,
it is described as a binary buffer that must be parsed from beginning to end.
I recommend we do not add this C data st
Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Sunday, April 26, 2015 10:55 PM
To: edk2-devel@lists.sourceforge.net; Justen, Jordan L
Subject: [edk2] [Patch V2 2/10] Add Quark SoC Compatibility: MdePkg : BaseLib
Use CPUID Leaf 01 to detect support for CLFLUSH instruction.
Contributed
Jordan,
Thanks for the feedback and the review. I will fix the commit messages.
Mike
-Original Message-
From: Justen, Jordan L
Sent: Monday, April 27, 2015 11:38 AM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net
Subject: Re: [edk2][Patch V2 1/10] Add Quark SoC Compatibility
commit log: UefiCpuPkg : DebugAgentLib => UefiCpuPkg :
CpuExceptionHandlerLib
Reviewed-by: Jeff Fan mailto:jeff@intel.com>>
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Monday, April 27, 2015 1:55 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sou
Remove use of CMOVx instruction from IA32 assembly files in
BaseMemoryLibRepStr. This matches compiler flags for all supported C compilers.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Michael Kinney
mailto:michael.d.kin...@intel.com>>
Index: Library/BaseMemoryLibRepS
Use Family from CPUID 01 to detect support for the Local APIC Base Address MSR
(MSR_IA32_APIC_BASE_ADDRESS). If this MSR is not supported, then use Local
APIC Base Address from the PCD PcdCpuLocalApicBaseAddress.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Michael Kin
Use CPUID Leaf 01 to detect support for CLFLUSH instruction. If CLFLUSH is
supported, use CPUID to determine the cache line size to use with CLFLUSH.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Michael Kinney
mailto:michael.d.kin...@intel.com>>
Index: Library/BaseCac
Use CPUID Leaf 01 to detect support for debug extensions and FXSAVE/FXRESTOR
instructions and do not enable those features in CR4 if they are not supported.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Michael Kinney
Index: Library/CpuExceptionHandlerLib/DxeCpuExc
Use CPUID Leaf 01 to detect support for debug extensions. Force use of
software breakpoints if debug extensions are not supported.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Michael Kinney
mailto:michael.d.kin...@intel.com>>
Index: Library/PeCoffExtraActionLibDebug
Add stride PCD to MdeModulePkg to support 16550 UARTs with a register stride
that is not 1 byte. Quark SoC uses a stride of 4 bytes.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Michael Kinney
mailto:michael.d.kin...@intel.com>>
Index: Library/BaseSerialPortLib16550/B
Remove use of CMOVx instruction from IA32 assembly files in BaseLib. This
matches compiler flags for all supported C compilers.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Michael Kinney
mailto:michael.d.kin...@intel.com>>
Index: Library/BaseLib/BaseLib.inf
=
Use CPUID Leaf 01 to detect support for debug extensions and FXSAVE/FXRESTOR
instructions and do not enable those features in CR4 if they are not supported.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Michael Kinney
mailto:michael.d.kin...@intel.com>>
Index: Library/D
Use CPUID Leaf 01 to detect support for CLFLUSH instruction.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Michael Kinney
mailto:michael.d.kin...@intel.com>>
Index: Library/BaseLib/Ia32/FlushCacheLine.asm
=
Avoid use of Local APIC Base Address MSR (MSR_IA32_APIC_BASE_ADDRESS) if there
is only 1 CPU present.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off by: Michael Kinney
mailto:michael.d.kin...@intel.com>>
Index: Library/DebugAgent/DebugAgentCommon/DebugMp.c
==
Reviewed-by: Michael Kinney
-Original Message-
From: Gao, Liming
Sent: Friday, April 24, 2015 1:15 AM
To: Wu, Hao A; Kinney, Michael D
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [PATCH] IntelFrameworkModulePkg: Modify IsaSerialDxe to follow
driver rules
Reviewed-by: Liming Gao
Jordan,
Yes. I tested them with GCC47. I did package DSC builds and OVMF platform
builds with GCC47 and verified OVMF booted.
Mike
-Original Message-
From: Justen, Jordan L
Sent: Wednesday, April 15, 2015 12:46 AM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net
Subject: Re
#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterStride_HELP
#language en-US "The number of bytes between registers in serial device. The
default is 1 byte."
Mike
-Original Message-
From: Justen, Jordan L
Sent: Wednesday, April 15, 2015 12:41 AM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net
Subject: R
Peter,
Is this really about a capsule used to test the feature? Is Test Capsule maybe
a better term than Fake Capsule? If it is about testing a feature, then should
it go into its own package to support the test?
Thanks,
Mike
-Original Message-
From: Jordan Justen [mailto:jordan.l.j
exception path, so not used very frequently.
Mike
-Original Message-
From: Justen, Jordan L
Sent: Wednesday, April 15, 2015 12:27 AM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [Patch 6/8] UefiCPuPkg: CpuExceptionHandlerLib: Add Quark
SoC compatibility
Grr
, 2015 12:17 AM
To: Kinney, Michael D; edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [Patch 7/8] UefiCPuPkg: ApicLibs: Add Quark SoC
compatibility
UefiCPuPkg: CPu => Cpu
Really wish I didn't have to go through the extra steps to quote the
attached patch. :\ (Ie, I like inline
, Michael D; edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [Patch 1/8] MdePkg: BaseCacheMaintenanceLib: Add Quark SoC
compatibility
On 2015-04-14 09:49:00, Kinney, Michael D wrote:
>Please review the attached patch that adds Quark SoC compatibility to the
>BaseCacheMaintenanceLib
have been made to address similar sign issues and I
found the method in the attached patch used consistently.
Thanks,
Mike
-Original Message-
From: Gao, Liming
Sent: Monday, April 13, 2015 8:29 PM
To: edk2-devel@lists.sourceforge.net; Laszlo Ersek; Kinney, Michael D
Cc: Gao, Liming
Please review the attached patch that adds Quark SoC compatibility to the
BaseLib in the MdePkg.
Some EDK II libraries assume capabilities that are not available on Quark SoC.
With these changes, applications and drivers built for IA32 are compatible with
Quark SoC.
These patches do not modify
Please review the attached patch that adds Quark SoC compatibility to the
CpuExceptionHandlerLib in the UefiCpuPkg.
Some EDK II libraries assume capabilities that are not available on Quark SoC.
With these changes, applications and drivers built for IA32 are compatible with
Quark SoC.
These pa
Please review the attached patch that adds Quark SoC compatibility to the APIC
Libraries in the UefiCpuPkg.
Some EDK II libraries assume capabilities that are not available on Quark SoC.
With these changes, applications and drivers built for IA32 are compatible with
Quark SoC.
These patches do
Please review the attached patch that adds Quark SoC compatibility to the
BaseCacheMaintenanceLib in the MdePkg.
Some EDK II libraries assume capabilities that are not available on Quark SoC.
With these changes, applications and drivers built for IA32 are compatible with
Quark SoC.
These patch
Please review the attached patch that adds Quark SoC compatibility to the
BaseMemoryLibRepStr in the MdePkg.
Some EDK II libraries assume capabilities that are not available on Quark SoC.
With these changes, applications and drivers built for IA32 are compatible with
Quark SoC.
These patches d
Please review the attached patch that adds Quark SoC compatibility to the
SerialPortLib in the MdeModulePkg.
Some EDK II libraries assume capabilities that are not available on Quark SoC.
With these changes, applications and drivers built for IA32 are compatible with
Quark SoC.
These patches d
Please review the attached patch that adds Quark SoC compatibility to the
DebugAgentLib in the SourceLevelDebugPkg.
Some EDK II libraries assume capabilities that are not available on Quark SoC.
With these changes, applications and drivers built for IA32 are compatible with
Quark SoC.
These pa
Please review the attached patch that adds Quark SoC compatibility to the
PeCoffExtraActionLibDebug in the SourceLevelDebugPkg.
Some EDK II libraries assume capabilities that are not available on Quark SoC.
With these changes, applications and drivers built for IA32 are compatible with
Quark S
: Wednesday, April 01, 2015 8:12 AM
To: Kinney, Michael D
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [PATCH] MdePkg/DevicePath.h: Fixed 'integer operation result is
out of range'
The failing line is this one:
./OvmfPkg/QemuVideoDxe/Driver.c: AcpiDeviceNode.ADR = ACPI_DISPLAY_ADR (1
(((_VendorInfo) & 0xf) << 12) | \
(((_Type) & 0xf) << 8) | \
(((_Port) & 0xf) << 4) | \
((_Index) & 0xf) ))
Thanks,
Mike
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Se
does this new GUID device path
node replace the HARDDRIVE_DEVICE_PATH node?
Thanks,
Mike
-Original Message-
From: Justen, Jordan L
Sent: Wednesday, March 25, 2015 1:58 PM
To: edk2-devel@lists.sourceforge.net; Paulo Alcantara; Kinney, Michael D
Subject: Re: [edk2] [PATCH 1/3
Dr7 = AsmReadDr7 () | BIT10;
NewDr7 = AsmReadDr7() | BIT10;
Thanks,
Mike
-Original Message-
From: Brian J. Johnson [mailto:bjohn...@sgi.com]
Sent: Monday, March 16, 2015 9:59 AM
To: edk2-devel@lists.sourceforge.net; Kinney, Michael D
Cc: Fan, Jeff
Subject: Re: [edk2] [PATCH
Brian,
In DEBUG_LOAD_IMAGE_METHOD_SOFT_INT3 mode, is there any difference in behavior
if DR7 is always restored without checking state of BIT10?
Thanks,
Mike
-Original Message-
From: Brian J. Johnson [mailto:bjohn...@sgi.com]
Sent: Monday, March 16, 2015 8:26 AM
To: edk2-devel@lists.s
, Michael D
Cc: Ard Biesheuvel
Subject: Re: [PATCH v5a 14/29] MdePkg/BaseSynchronizationLib: Add
InterlockedCompareExchange16
On 26 February 2015 at 08:50, Ard Biesheuvel wrote:
> Hello all,
>
> This is the latest version of the InterlockedCompareExchange16() patch.
> Michael has kind
, Jordan L; Kinney, Michael D
Cc: Ard Biesheuvel
Subject: [PATCH v5a 14/29] MdePkg/BaseSynchronizationLib: Add
InterlockedCompareExchange16
Hello all,
This is the latest version of the InterlockedCompareExchange16() patch.
Michael has kindly confirmed (thanks Michael) that it does the right
thing
;
anthony.per...@citrix.com; xen-de...@lists.xen.org; julien.gr...@linaro.org;
Justen, Jordan L; Kinney, Michael D; Tian, Feng
Cc: Ard Biesheuvel
Subject: [PATCH v4 14/29] MdePkg/BaseSynchronizationLib: implement 16-bit
compare-exchange
This implements the function InterlockedCompareExchange16 () for all
Cinnamon Shia,
I think the original proposal would read the FFS file contents twice.
Since the new API being proposed returns the Device Path to the FFS file in a
specific FV, LoadImage() will not search. It knows from the Device Patch
exactly where to load the FFS file from.
Mike
From: Shia
Hi,
The PciCf8Lib macros are as intended. The idea was to standardize on a single
PCI address format that is can be used for either PCI Express (4KB per device)
and PCI CF8/CFC access (256 byte max per device).
In the implementation of BasePciCf8Lib, there is a translation from the PCI
addres
Andrew,
Yes. I think these types of cleanups are good.
Mike
From: Andrew Fish [mailto:af...@apple.com]
Sent: Friday, November 07, 2014 4:11 PM
To: edk2-devel@lists.sourceforge.net
Cc: Kinney, Michael D
Subject: MdePkg ++ Should we remove redundant Family specifiers from the INF
files.
Mike
a full
> validation for .nasm file.
>
> I am fine on adding .nasm. But can we still keep original .asm and .S file?
>
>
> Thank you
> Yao Jiewen
>
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, November 06, 2014 10:48 AM
> To: Justen, Jorda
the ones generated from UPT
>>>
>>> 2) Guid value in section will be align.
>>>
>>> 3) Usage comments in section will be align.
>>>
>>> 4) One PCD section includes one PCD type. If one PCD supports more PCD
>>> types,
Tim,
Yes. This issue has been around a while. The workaround when you want to
monitor every single pool operation in the DXE Core is to use a DebugLib
instance that sends debug messages directly to a debug device such as
MdePkg/Library/BaseDebugLibSerialPort.
The issue with using a DebugLib in
Samer,
Can you please verify that the stack is aligned in native code before calling
the EBC function where this fix was required?
If the native stack is always aligned correctly, can you please provide a small
test case that reproduces the issue along with all the compiler/linker flags
used.
Samer,
Can you please provide the details on how to reproduce an incorrect stack
alignment.
It has been a long time since we have worked on this code, and I recall
reviewing the stack alignment carefully at that time.
It is possible that the code that called an EBC function has misaligned the
Visual Studio for x86 at a disadvantage?
Tim
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Wednesday, August 20, 2014 4:59 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: Re: [edk2] [StdLib] Patch for review: Add VC++ helper fu
result
is fewer hard-to-understand linker errors than before. If you miss one
function, the net result is no worse than today.
Tim
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Wednesday, August 20, 2014 12:30 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-de
e your hand if you have done a search
on u
Even a partial solution will be better than no solutions because the net result
is fewer hard-to-understand linker errors than before. If you miss one
function, the net result is no worse than today.
Tim
From: Kinney, Michael D
[mailto:michael
Thomas,
A design decision was made early in the EDK II project to not depend on any
compiler intrinsic functions. The reasons include:
1) Linking against OS specific C libs has risks because it can potentially
introduce OS specific sys calls.
2) Linking against OS specific C libs ca
Scott,
comdat folding is related to optimization. My other email on this thread
describes a debug issue seen when optimization and comdat folding is disabled
along with an example that can be used to evaluate the issue on different
debuggers.
I want to clarify that there is no "ban" on the us
Scott,
An example of a source level debug issue that can occur when all optimizations
are disabled is as follows:
int f1 (void) {return 2;}
static int f2 (void) {return 3;}
int f3 (void) {return 4;}
int main (int argc, char *argv [])
{
if (argc ==1) return f1 ();
if (argc ==2) return
Scott,
We have seen issues with some source level debuggers when using static
functions. I some cases, it will show the wrong function name when stepping
through a static function. Unless there is a really good reason, we prefer to
not use static to improve debugability.
Public functions are
noCore Contribution Agreement 1.0
Signed-off-by: Fan, Jeff mailto:jeff@intel.com>>
Thanks
Liming
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Thursday, August 07, 2014 5:32 AM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [
a little big. For new added UNI file, I zip them
together.
The second patch for below item 7 will be sent later
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fan, Jeff mailto:jeff@intel.com>>
Thanks
Liming
From: Kinney, Michael D [mailto:michael.d.kin...@int
pdates to EDK II packages
Mike:
This is a mistake. New patch has fixed them.
Thanks
Liming
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Friday, August 15, 2014 1:15 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: Re: [edk2
noCore Contribution Agreement 1.0
Signed-off-by: Gao, Liming mailto:liming@intel.com>>
Thanks
Liming
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Thursday, August 07, 2014 5:32 AM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [
to EDK II packages
Hi, all
Could you help review this patch? It includes the following changes 1-6 for
MdePkg. The patch is a little big. For new added UNI file, I zip them together.
The second patch for below item 7 will be sent later
Thanks
Liming
From: Kinney, Michael D
Larry,
Can you please review this patch that fixes the behavior of the -version flag
in the Rsa2048Sha256 tools and updates logic for showing program name, version,
usage, and copyright information to match other BaseTools.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
. I see the DXE version has done such error handling but PEI don't:)
2) For SectionExtractionPei.inf and SectionExtractionDxe.inf, shall we
support IPF and EBC?
Others are good to me.
Reviewed-by: Feng Tian mailto:feng.t...@intel.com>>
Thanks
Feng
From: Kinney, Michael D
Hi Tim,
Thanks for the feedback on this topic. We have had similar discussions over
the last couple of days for where this content should be listed.
These updates do reserve specific string token name patterns. Whenever we have
used specific keywords in syntax in the other EDK II related docu
Laszlo,
Thanks for the contribution. The patch looks good to me.
Reviewed-by: Michael Kinney
Mike
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, August 06, 2014 1:24 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH v3 3/3] AppPkg: intr
Laszlo,
Thanks for the contribution. The patch looks good to me.
Reviewed-by: Michael Kinney
Mike
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, August 06, 2014 1:24 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH v3 2/3] MdePkg: intr
Laszlo,
Thanks for the contribution. The patch looks good to me.
Reviewed-by: Michael Kinney
Mike
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, August 06, 2014 1:24 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH v3 0/3] MdePkg: orde
.
Commit-message-from: "Kinney, Michael D"
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Notes:
v3:
- introduce self-validation feature flag, drop
OrderedCollectionValidate() from public interface [Mike]
- "a entry" -->
r the font info in the strings, we can have that discussion separately
(actually, we probably have had it at one point). My point was: the formatting
codes can be embedded using escape sequences today, since they are characters,
but I think you might want to specify what can or may not be used
purely in the .inf? I can
see how PCDs work. Are you saying these .uni strings would replace that which
appears in the .inf header?
Tim
From: Kinney, Michael D [mailto:michael.d.kin...@intel.com]
Sent: Friday, August 08, 2014 1:34 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-deve
en-US
"Invalid value provided."
#string STR_gEfiMdePkgTokenSpaceGuid_PcdUartDefaultBaudRate_PROMPT
#language en-US
"Default UART Baud Rate"
#string STR_gEfiMdePkgTokenSpaceGuid_PcdUartDefaultBaudRate_HELP
#language en-US
"Indicates the default baud rate of UART. "
From: Kinney, Michael D [
1 - 100 of 206 matches
Mail list logo
