Re: [edk2] DHCPv6 IAID and NetRandomInitSeed problem in OVMF

2015-07-27 Thread Michael Chang
On Mon, Jul 27, 2015 at 05:52:48AM +, Fu, Siyuan wrote: > Hi, Michael > > Can you help to test whether this patch could solve your problem? Yes. It works for me. :) Thanks, Michael > > Thanks, > Siyuan > > -Original Message- > From: Michael Chang [mail

Re: [edk2] DHCPv6 IAID and NetRandomInitSeed problem in OVMF

2015-07-23 Thread Michael Chang
On Thu, Jul 23, 2015 at 10:13:20AM +, Fu, Siyuan wrote: > Michael, > > It's not because any benefit, it's because there is actually no place to put > the static local variable. The IaDescriptor.IaId is defined in UEFI spec, so > Dhcp6->Configure() function co

Re: [edk2] Supporting 2nd HDMI port for Intel Atom Bay-Trail (E3800)?

2015-07-23 Thread Krau, Michael P
, which seems to be appropriate to your goals. If you are using the 0.80 or later sources, then it will require a more technical and specific of discussion. Michael Krau   While I am an Intel employee, I do not represent Intel and am not authorized to speak for Intel.  -Original Message

Re: [edk2] DHCPv6 IAID and NetRandomInitSeed problem in OVMF

2015-07-23 Thread Michael Chang
On Thu, Jul 23, 2015 at 09:01:38AM +, Fu, Siyuan wrote: > Hi, Michael > > It's indeed a problem that NET_RANDOM (NetRandomInitSeed ()) may return same > value if the time service is not accuracy enough on some platform. And as you > said it's used to give unique

[edk2] DHCPv6 IAID and NetRandomInitSeed problem in OVMF

2015-07-23 Thread Michael Chang
onfigure OVMF to use it. 2. Use GetPerformanceCounter(), but that would increase image size by linking TimerLib. 3. The IaId has to be "unique" thus not necessarily to be random, probably it should be derived by some properties like MAC address and an assg

Re: [edk2] [PATCH] BaseTools: Add GCC49LTO tool chain: GCC49 with link time optimization

2015-07-15 Thread Kinney, Michael D
: Wednesday, July 15, 2015 9:39 AM To: Kinney, Michael D; Scott Duplichan; edk2-devel@lists.sourceforge.net Cc: Mcdaniel, Daryl Subject: Re: [edk2] [PATCH] BaseTools: Add GCC49LTO tool chain: GCC49 with link time optimization On 7/15/2015 10:11 AM, Kinney, Michael D wrote: > Is adding -Wl to those l

Re: [edk2] [PATCH] BaseTools: Add mechanism to override or add CC_FLAGS

2015-07-15 Thread Kinney, Michael D
-mabi=ms" Best regards, Mike -Original Message- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Wednesday, July 15, 2015 12:03 AM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net Subject: RE: [edk2] [PATCH] BaseTools: Add mechanism to override or add CC_FLAG

Re: [edk2] [PATCH] BaseTools: Add GCC49LTO tool chain: GCC49 with link time optimization

2015-07-15 Thread Kinney, Michael D
...@notabs.org] Sent: Wednesday, July 15, 2015 12:03 AM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net Cc: Mcdaniel, Daryl Subject: RE: [edk2] [PATCH] BaseTools: Add GCC49LTO tool chain: GCC49 with link time optimization Kinney, Michael D [mailto:michael.d.kin...@intel.com] wrote: ] ]Sent: Tuesday

Re: [edk2] [PATCH] BaseTools: Add mechanism to override or add CC_FLAGS

2015-07-14 Thread Kinney, Michael D
Scott, We try to minimize the build dependencies on environment variables. There are several mechanisms already available to append CC_FLAGS. Can you please provide more details on why the environment variable based method is better than the existing methods? Thanks, Mike -Original Mes

Re: [edk2] [PATCH] BaseTools: Add GCC49LTO tool chain: GCC49 with link time optimization

2015-07-14 Thread Kinney, Michael D
Hi Scott, What is the purpose of GCCLINK_PREFIX? Why can't the Wl flag just be included in tools_def.txt as required? Thanks, Mike -Original Message- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Tuesday, July 14, 2015 9:44 AM To: edk2-devel@lists.sourceforge.net Cc: Mcdaniel

Re: [edk2] [PATCH] MdePkg/ImageAuthentication.h: Fixed ARM toolchain error

2015-07-14 Thread Kinney, Michael D
Oliver, Reviewed-by: Michael Kinney Mike -Original Message- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Tuesday, July 14, 2015 8:14 AM To: Kinney, Michael D; Gao, Liming Cc: edk2-devel@lists.sourceforge.net Subject: RE: [PATCH] MdePkg/ImageAuthentication.h: Fixed ARM

Re: [edk2] [PATCH] MdePkg: Describe submission of a patch authored by someone else

2015-06-24 Thread Kinney, Michael D
understating correct? Thanks, Mike -Original Message- From: Roy Franz [mailto:roy.fr...@linaro.org] Sent: Wednesday, June 24, 2015 11:17 AM To: edk2-devel@lists.sourceforge.net Cc: ler...@redhat.com; Kinney, Michael D Subject: Re: [edk2] [PATCH] MdePkg: Describe submission of a patch

Re: [edk2] [PATCH 1/2] SecurityPkg: Add RandLib from existing RngDxe code

2015-06-19 Thread Kinney, Michael D
Doman, Thanks for providing this. In general, we like to put C functions that abstract CPU instructions in MdePkg/BaseLib. Do you think it makes sense to add 8/16/32/64 bit functions to BaseLib for the rdrand instruction. Then have the SecurityPkg library use the functions from BaseLib to ex

Re: [edk2] [PATCH v3 4/8] BaseTools/UniClassObject: Verify valid UCS-2 chars in UTF-16 .uni files

2015-06-08 Thread Kinney, Michael D
Jordan, Yes. With that one comment added, the entire series looks good to me.. Reviewed-by: Michael Kinney Mike -Original Message- From: Justen, Jordan L Sent: Sunday, June 07, 2015 11:13 PM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net Cc: Liu, Yingke D; Laszlo Ersek

Re: [edk2] [PATCH v3 4/8] BaseTools/UniClassObject: Verify valid UCS-2 chars in UTF-16 .uni files

2015-06-07 Thread Kinney, Michael D
Jordan, The functionality of the patch set looks good. Just a few comments below about needing some better comments. Reviewed-by: Michael Kinney We also discussed the need for an extra tool that can scan a workspace or a package for UNI files and convert them to UTF-16LE. This tool may

Re: [edk2] [RFC 0/4] New terminal type for Linux

2015-05-14 Thread Kinney, Michael D
terminal type to MdeModulePkg/Universal/Console/TerminalDxe. Best regards, Mike -Original Message- From: Roy Franz [mailto:roy.fr...@linaro.org] Sent: Thursday, May 14, 2015 1:44 PM To: Kinney, Michael D Cc: Yao, Jiewen; edk2-devel@lists.sourceforge.net; linaro-u...@lists.linaro.org

Re: [edk2] [RFC 0/4] New terminal type for Linux

2015-05-14 Thread Kinney, Michael D
Jiewen, I think most of the terminal emulators being discussed here layer on top of a TTY device. How about TtyTerm instead? Mike -Original Message- From: Yao, Jiewen Sent: Wednesday, May 13, 2015 7:13 PM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net; linaro-u

Re: [edk2] [RFC 0/4] New terminal type for Linux

2015-05-13 Thread Kinney, Michael D
edk2-devel@lists.sourceforge.net Cc: Yao, Jiewen; linaro-u...@lists.linaro.org; Tian, Feng; Kinney, Michael D Subject: Re: [edk2] [RFC 0/4] New terminal type for Linux > On May 13, 2015, at 6:23 PM, Kinney, Michael D > wrote: > > Jiewen, > > Adding more GUIDs is possible i

Re: [edk2] [RFC 0/4] New terminal type for Linux

2015-05-13 Thread Kinney, Michael D
, May 13, 2015 6:20 PM To: edk2-devel@lists.sourceforge.net Cc: Kinney, Michael D; linaro-u...@lists.linaro.org; Tian, Feng Subject: Re: [edk2] [RFC 0/4] New terminal type for Linux > On May 13, 2015, at 6:15 PM, Yao, Jiewen wrote: > > OK. I also have interest to know how to handle b

Re: [edk2] [RFC 0/4] New terminal type for Linux

2015-05-13 Thread Kinney, Michael D
: Yao, Jiewen Sent: Wednesday, May 13, 2015 6:16 PM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net; linaro-u...@lists.linaro.org; Tian, Feng Subject: RE: [edk2] [RFC 0/4] New terminal type for Linux OK. I also have interest to know how to handle below case mentioned by patch submitter

Re: [edk2] [RFC 0/4] New terminal type for Linux

2015-05-13 Thread Kinney, Michael D
terminal type should be very small. Especially since the TerminalDxe driver is usually compressed. Thanks, Mike -Original Message- From: Yao, Jiewen Sent: Wednesday, May 13, 2015 5:59 PM To: edk2-devel@lists.sourceforge.net; linaro-u...@lists.linaro.org; Tian, Feng; Kinney, Michael D

Re: [edk2] [RFC 0/4] New terminal type for Linux

2015-05-13 Thread Kinney, Michael D
Roy, The new GUID for this terminal type should not be defined in the MdePkg. The MdePkg is intended to only contain content from industry standard specifications. I recommend you add the GUID for this new terminal type to the MdeModulePkg so it is in the same package that contains the termin

Re: [edk2] Basetools update for CLAN support

2015-05-12 Thread Kinney, Michael D
Jordan, Yes. It is being implemented. You should start seeing details in the next week or two. Mike -Original Message- From: Jordan Justen [mailto:jordan.l.jus...@intel.com] Sent: Monday, May 11, 2015 9:46 PM To: Gao, Liming; edk2-devel@lists.sourceforge.net; Chan, Amy Cc: Davis, Bra

Re: [edk2] [PATCH] Treat ASCII DEL (0x7f) as backspace

2015-05-12 Thread Kinney, Michael D
] [PATCH] Treat ASCII DEL (0x7f) as backspace On 05/08/15 04:26, Roy Franz wrote: > On Thu, May 7, 2015 at 7:03 PM, Kinney, Michael D > wrote: >> Roy, >> >> Did you try the command line at the UEFI Shell prompt through a >> serial terminal? There is line editing ava

Re: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition.

2015-05-08 Thread Kinney, Michael D
Felix, I like the more detailed comments. Mike -Original Message- From: Felix Poludov [mailto:fel...@ami.com] Sent: Friday, May 08, 2015 6:43 AM To: Ni, Ruiyu; Kinney, Michael D; edk2-devel@lists.sourceforge.net; Andrew Fish Subject: RE: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION

Re: [edk2] [PATCH] Treat ASCII DEL (0x7f) as backspace

2015-05-07 Thread Kinney, Michael D
Roy, Did you try the command line at the UEFI Shell prompt through a serial terminal? There is line editing available, where backspace and delete keys perform different actions. I think your change prevents a user from ever getting the delete key behavior. Same would be true for the UEFI She

Re: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition.

2015-05-07 Thread Kinney, Michael D
- From: Felix Poludov [mailto:fel...@ami.com] Sent: Thursday, May 07, 2015 11:50 AM To: edk2-devel@lists.sourceforge.net; Andrew Fish; Kinney, Michael D; Ni, Ruiyu Subject: RE: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition. The EFI_LOAD_OPTION was not defined in the UEFI specification

[edk2] [Patch] MdePkg/Include: Add support for flexible array members

2015-05-05 Thread Kinney, Michael D
Use pragma to disable warning 4200 for all VS* and DDK* toolchains to support data structure declarations where the last field of the data structure is a flexible array member. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney mailto:michael.d.kin

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Kinney, Michael D
Brian, Yes. DDK3790 toolchain works when warning 4200 is disabled. Mike -Original Message- From: Brian J. Johnson [mailto:bjohn...@sgi.com] Sent: Tuesday, May 05, 2015 11:43 AM To: edk2-devel@lists.sourceforge.net; Laszlo Ersek; Kinney, Michael D Cc: Zhang, Chao B Subject: Re: [edk2

Re: [edk2] [PATCH v2 1/7] BaseTools: Support UTF-8 string data in .uni files

2015-05-05 Thread Kinney, Michael D
Jordan, My main point about the spec is that both need to be updated if this concept is accepted. Not that one has to be done before the other. Mike -Original Message- From: Justen, Jordan L Sent: Tuesday, May 05, 2015 11:52 AM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net

Re: [edk2] [PATCH v2 1/7] BaseTools: Support UTF-8 string data in .uni files

2015-05-05 Thread Kinney, Michael D
compatibility with other tools, then what would that helper tool do with a non UCS-2 character? It is just easier for the whole file to use the same character set. Best regards, Mike -Original Message- From: Justen, Jordan L Sent: Tuesday, May 05, 2015 10:53 AM To: Kinney, Michael D; edk2

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Kinney, Michael D
, Michael D Cc: edk2-devel@lists.sourceforge.net; Zhang, Chao B; Mcdaniel, Daryl Subject: Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout On 05/05/15 19:34, Kinney, Michael D wrote: > Laszlo, > > I agree with the general guidance from that thread. However, data

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Kinney, Michael D
] Sent: Tuesday, May 05, 2015 8:53 AM To: Kinney, Michael D Cc: edk2-devel@lists.sourceforge.net; Zhang, Chao B; Mcdaniel, Daryl Subject: Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout Hello Mike, On 05/05/15 17:35, Kinney, Michael D wrote: > Forward reference decla

Re: [edk2] [PATCH v2 1/7] BaseTools: Support UTF-8 string data in .uni files

2015-05-05 Thread Kinney, Michael D
#x27;, PARSER_ERROR, '%s contains invalid UCS-2 character at line %d.' % (File.Path, LineNumber)) Best regards, Mike -Original Message- From: Justen, Jordan L Sent: Tuesday, May 05, 2015 12:09 AM To: edk2-devel@lists.sourceforge.net Cc: Justen, Jordan L; Liu, Yingke D; Kinne

Re: [edk2] [Patch 1/3] MdePkg : Add Microsoft UX capsule GUID & layout

2015-05-05 Thread Kinney, Michael D
Forward reference declarations are not required for this file and should be removed. Also, the Image[1] field of the DISPLAY_DISPLAY_PAYLOAD structure should be declared as Image[]. That is the recommended style for new structure declarations that have a variable sized array as the last field

Re: [edk2] [PATCH 0/9] Support UTF-8 (.utf8) string files

2015-05-04 Thread Kinney, Michael D
, Jordan L Sent: Monday, May 04, 2015 3:02 PM To: edk2-devel@lists.sourceforge.net; Brian J. Johnson; Kinney, Michael D Subject: Re: [edk2] [PATCH 0/9] Support UTF-8 (.utf8) string files On 2015-05-04 14:32:48, Brian J. Johnson wrote: > On 05/04/2015 02:11 PM, Laszlo Ersek wrote: > > I

Re: [edk2] [PATCH 0/9] Support UTF-8 (.utf8) string files

2015-05-04 Thread Kinney, Michael D
Jordan, Some source control systems provide support a file type of UTF-16LE, so the use of 'binary' should be avoided. What source control systems require the use of 'binary'? What diff utilities are having issues with UTF-16LE files? Can you provide some examples? Also, what are the pros/c

Re: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition.

2015-05-01 Thread Kinney, Michael D
Ray, The idea of adding EFI_LOAD_OPTION structure to MdePkg .h files has been considered before. This is not defined as a C data structure in the UEFI Specification. Instead, it is described as a binary buffer that must be parsed from beginning to end. I recommend we do not add this C data st

[edk2] [Patch]: AsmFlushCacheLine() bug fixes: MdePkg/BaseLib

2015-04-29 Thread Kinney, Michael D
parameter name LinearAddress instead of the hard coded [esp + 4] stack location to prevent this issue from occurring again if there are changes to the inline assembly in the future. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney mailto:michael.d.kin...@intel.com

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-28 Thread Michael Chang
On Tue, Apr 28, 2015 at 02:03:02PM +0800, Michael Chang wrote: > On Mon, Apr 27, 2015 at 02:47:16PM +0800, Michael Chang wrote: > Apparently I made a mistake here, the exclusive open still fails. > > It's in your new patch that can survive the failed exlusive open by >

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-27 Thread Michael Chang
On Mon, Apr 27, 2015 at 02:47:16PM +0800, Michael Chang wrote: > On Sun, Apr 26, 2015 at 09:42:52AM +0300, Andrei Borzenkov wrote: > > В Tue, 21 Apr 2015 14:12:54 +0800 > > Michael Chang пишет: > > > > > > > > 3. Even I can add the card open earler befo

Re: [edk2] [Patch V2 1/10] Add Quark SoC Compatibility: MdePkg : BaseCacheMaintenanceLib

2015-04-27 Thread Kinney, Michael D
Jordan, Thanks for the feedback and the review. I will fix the commit messages. Mike -Original Message- From: Justen, Jordan L Sent: Monday, April 27, 2015 11:38 AM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net Subject: Re: [edk2][Patch V2 1/10] Add Quark SoC Compatibility

Re: [edk2] [Patch V2 10/10] Add Quark SoC Compatibility: UefiCpuPkg : DebugAgentLib

2015-04-27 Thread Kinney, Michael D
commit log: UefiCpuPkg : DebugAgentLib => UefiCpuPkg : CpuExceptionHandlerLib Reviewed-by: Jeff Fan mailto:jeff@intel.com>> From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Monday, April 27, 2015 1:55 PM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sou

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-26 Thread Michael Chang
On Sun, Apr 26, 2015 at 09:42:52AM +0300, Andrei Borzenkov wrote: > В Tue, 21 Apr 2015 14:12:54 +0800 > Michael Chang пишет: > > > > > 3. Even I can add the card open earler before hadling the dhcpv6 > > packets, it will freeze at grub_efi_open_protocol

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-26 Thread Michael Chang
On Sat, Apr 25, 2015 at 05:12:33PM +0300, Andrei Borzenkov wrote: > В Tue, 21 Apr 2015 14:12:54 +0800 > Michael Chang пишет: > > > > > > > > > +static grub_err_t > > > > +open_card (struct grub_net_card *dev) > > > > +{ > > > &g

[edk2] [Patch V2 4/10] Add Quark SoC Compatibility: MdePkg : BaseMemoryLibRepStr

2015-04-26 Thread Kinney, Michael D
Remove use of CMOVx instruction from IA32 assembly files in BaseMemoryLibRepStr. This matches compiler flags for all supported C compilers. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> Index: L

[edk2] [Patch V2 6/10] Add Quark SoC Compatibility: UefiCpuPkg : Local APIC Libraries

2015-04-26 Thread Kinney, Michael D
Use Family from CPUID 01 to detect support for the Local APIC Base Address MSR (MSR_IA32_APIC_BASE_ADDRESS). If this MSR is not supported, then use Local APIC Base Address from the PCD PcdCpuLocalApicBaseAddress. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael

[edk2] [Patch V2 1/10] Add Quark SoC Compatibility: MdePkg : BaseCacheMaintenanceLib

2015-04-26 Thread Kinney, Michael D
Use CPUID Leaf 01 to detect support for CLFLUSH instruction. If CLFLUSH is supported, use CPUID to determine the cache line size to use with CLFLUSH. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> Index: L

[edk2] [Patch V2 10/10] Add Quark SoC Compatibility: UefiCpuPkg : DebugAgentLib

2015-04-26 Thread Kinney, Michael D
Use CPUID Leaf 01 to detect support for debug extensions and FXSAVE/FXRESTOR instructions and do not enable those features in CR4 if they are not supported. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney Index: Library/CpuExceptionHandlerLib

[edk2] [Patch V2 8/10] Add Quark SoC Compatibility: SourceLevelDebugPkg : PeCoffExtraActionLibDebug

2015-04-26 Thread Kinney, Michael D
Use CPUID Leaf 01 to detect support for debug extensions. Force use of software breakpoints if debug extensions are not supported. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> Index: L

[edk2] [Patch V2 5/10] Add Quark SoC Compatibility: MdeModulePkg : BaseSerialPortLib16550

2015-04-26 Thread Kinney, Michael D
Add stride PCD to MdeModulePkg to support 16550 UARTs with a register stride that is not 1 byte. Quark SoC uses a stride of 4 bytes. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> Index: Library/BaseSerialPortLi

[edk2] [Patch V2 3/10] Add Quark SoC Compatibility: MdePkg : BaseLib

2015-04-26 Thread Kinney, Michael D
Remove use of CMOVx instruction from IA32 assembly files in BaseLib. This matches compiler flags for all supported C compilers. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> Index: Library/BaseLib/BaseL

[edk2] [Patch V2 9/10] Add Quark SoC Compatibility: SourceLevelDebugPkg : DebugAgentLib

2015-04-26 Thread Kinney, Michael D
Use CPUID Leaf 01 to detect support for debug extensions and FXSAVE/FXRESTOR instructions and do not enable those features in CR4 if they are not supported. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> Index: L

[edk2] [Patch V2 2/10] Add Quark SoC Compatibility: MdePkg : BaseLib

2015-04-26 Thread Kinney, Michael D
Use CPUID Leaf 01 to detect support for CLFLUSH instruction. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> Index: Library/BaseLib/Ia32/FlushCacheLi

[edk2] [Patch V2 7/10] Add Quark SoC Compatibility: SourceLevelDebugPkg : DebugAgentLib

2015-04-26 Thread Kinney, Michael D
Avoid use of Local APIC Base Address MSR (MSR_IA32_APIC_BASE_ADDRESS) if there is only 1 CPU present. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> Index: Library/DebugAgent/DebugAgentCommon/Deb

Re: [edk2] [PATCH] IntelFrameworkModulePkg: Modify IsaSerialDxe to follow driver rules

2015-04-24 Thread Kinney, Michael D
Reviewed-by: Michael Kinney -Original Message- From: Gao, Liming Sent: Friday, April 24, 2015 1:15 AM To: Wu, Hao A; Kinney, Michael D Cc: edk2-devel@lists.sourceforge.net Subject: RE: [PATCH] IntelFrameworkModulePkg: Modify IsaSerialDxe to follow driver rules Reviewed-by: Liming Gao

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-21 Thread Michael Chang
On Tue, Apr 21, 2015 at 02:12:54PM +0800, Michael Chang wrote: > On Mon, Apr 20, 2015 at 02:30:00PM +0800, Michael Chang wrote: > > On Sun, Apr 19, 2015 at 11:01:11AM +0300, Andrei Borzenkov wrote: > > > EDK2 network stack is based on Managed Network Protocol which is layer

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-20 Thread Michael Chang
On Mon, Apr 20, 2015 at 02:30:00PM +0800, Michael Chang wrote: > On Sun, Apr 19, 2015 at 11:01:11AM +0300, Andrei Borzenkov wrote: > > EDK2 network stack is based on Managed Network Protocol which is layered > > on top of Simple Management Protocol and does background polling. T

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-19 Thread Michael Chang
y not? :) If we don't close it, the consequence might prevent other application (for eg, the chainloaded one from grub) from using managed network protocol or related one ? The rest of the patch looks good to me and a lot better than my workaround patch. Thanks for you work on this. I can give

Re: [edk2] [Patch 1/8] MdePkg: BaseCacheMaintenanceLib: Add Quark SoC compatibility

2015-04-15 Thread Kinney, Michael D
Jordan, Yes. I tested them with GCC47. I did package DSC builds and OVMF platform builds with GCC47 and verified OVMF booted. Mike -Original Message- From: Justen, Jordan L Sent: Wednesday, April 15, 2015 12:46 AM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net Subject: Re

Re: [edk2] [Patch 8/8] MdeModulePkg: SerialPortLib: Add Quark SoC compatibility

2015-04-15 Thread Kinney, Michael D
#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterStride_HELP #language en-US "The number of bytes between registers in serial device. The default is 1 byte." Mike -Original Message- From: Justen, Jordan L Sent: Wednesday, April 15, 2015 12:41 AM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net Subject: R

Re: [edk2] [PATCH 09/11] Add a fake ESRT driver to go with Fake Capsule driver.

2015-04-15 Thread Kinney, Michael D
Peter, Is this really about a capsule used to test the feature? Is Test Capsule maybe a better term than Fake Capsule? If it is about testing a feature, then should it go into its own package to support the test? Thanks, Mike -Original Message- From: Jordan Justen [mailto:jordan.l.j

Re: [edk2] [Patch 6/8] UefiCPuPkg: CpuExceptionHandlerLib: Add Quark SoC compatibility

2015-04-15 Thread Kinney, Michael D
exception path, so not used very frequently. Mike -Original Message- From: Justen, Jordan L Sent: Wednesday, April 15, 2015 12:27 AM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch 6/8] UefiCPuPkg: CpuExceptionHandlerLib: Add Quark SoC compatibility Grr

Re: [edk2] [Patch 7/8] UefiCPuPkg: ApicLibs: Add Quark SoC compatibility

2015-04-15 Thread Kinney, Michael D
, 2015 12:17 AM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch 7/8] UefiCPuPkg: ApicLibs: Add Quark SoC compatibility UefiCPuPkg: CPu => Cpu Really wish I didn't have to go through the extra steps to quote the attached patch. :\ (Ie, I like inline

Re: [edk2] [Patch 1/8] MdePkg: BaseCacheMaintenanceLib: Add Quark SoC compatibility

2015-04-15 Thread Kinney, Michael D
, Michael D; edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch 1/8] MdePkg: BaseCacheMaintenanceLib: Add Quark SoC compatibility On 2015-04-14 09:49:00, Kinney, Michael D wrote: >Please review the attached patch that adds Quark SoC compatibility to the >BaseCacheMaintenanceLib

Re: [edk2] [PATCH] MdePkg/DevicePath.h: Fixed 'integer operation result is out of range'

2015-04-14 Thread Kinney, Michael D
Martin and Liming, I have attached the revised patch. Can you please review? Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney Tested-by: Olivier Martin I agree that adding ul to the constant 0x01 will also work. I reviewed other source code changes that

[edk2] [Patch 2/8] MdePkg: BaseLib: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> QuarkSoc_MdePkg_BaseLib.patch Description: QuarkSoc_MdePkg_BaseLib.patch -- BPM Camp - Free Virtual Workshop May 6th at 10

[edk2] [Patch 6/8] UefiCPuPkg: CpuExceptionHandlerLib: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> QuarkSoc_UefiCpuPkg_CpuExceptionHandlerLib.patch Description: QuarkSoc_UefiCpuPkg_CpuExceptionHandlerLib

[edk2] [Patch 7/8] UefiCPuPkg: ApicLibs: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> QuarkSoc_UefiCpuPkg_ApicLibs.patch Description: QuarkSoc_UefiCpuPkg_ApicLibs.patch -- BPM Camp - Free Virtual Wo

[edk2] [Patch 1/8] MdePkg: BaseCacheMaintenanceLib: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> QuarkSoc_MdePkg_BaseCacheMaintenanceLib.patch Description: QuarkSoc_MdePkg_BaseCacheMaintenanceLib.patch

[edk2] [Patch 3/8] MdePkg: BaseMemoryLibRepStr: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> QuarkSoc_MdePkg_BaseMemoryLibRepStr.patch Description: QuarkSoc_MdePkg_BaseMemoryLibRepStr.patch -- BPM Camp

[edk2] [Patch 8/8] MdeModulePkg: SerialPortLib: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> QuarkSoc_MdeModulePkg.patch Description: QuarkSoc_MdeModulePkg.patch -- BPM Camp - Free Virtual Workshop May

[edk2] [Patch 5/8] SourceLevelDebugPkg: DebugAgentLib: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> QuarkSoc_SourceLevelDebugPkg_DebugAgentLib.patch Description: QuarkSoc_SourceLevelDebugPkg_DebugAgentLib

[edk2] [Patch 4/8] SourceLevelDebugPkg: PeCoffExtraActionLibDebug: Add Quark SoC compatibility

2015-04-14 Thread Kinney, Michael D
. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off by: Michael Kinney mailto:michael.d.kin...@intel.com>> QuarkSoc_SourceLevelDebugPkg_PeCoffExtraActionLibDebug.patch Description: QuarkSoc_SourceLevelDebugPkg_PeCoffExtraActionLibDebug

Re: [edk2] [PATCH] MdePkg/DevicePath.h: Fixed 'integer operation result is out of range'

2015-04-01 Thread Kinney, Michael D
: Wednesday, April 01, 2015 8:12 AM To: Kinney, Michael D Cc: edk2-devel@lists.sourceforge.net Subject: RE: [PATCH] MdePkg/DevicePath.h: Fixed 'integer operation result is out of range' The failing line is this one: ./OvmfPkg/QemuVideoDxe/Driver.c: AcpiDeviceNode.ADR = ACPI_DISPLAY_ADR (1

Re: [edk2] [PATCH] MdePkg/DevicePath.h: Fixed 'integer operation result is out of range'

2015-04-01 Thread Kinney, Michael D
(((_VendorInfo) & 0xf) << 12) | \ (((_Type) & 0xf) << 8) | \ (((_Port) & 0xf) << 4) | \ ((_Index) & 0xf) )) Thanks, Mike From: Olivier Martin [mailto:olivier.mar...@arm.com] Se

Re: [edk2] [PATCH 1/3] MdeModulePkg/PartitionDxe: Add UDF/ECMA-167 file system support

2015-03-26 Thread Kinney, Michael D
does this new GUID device path node replace the HARDDRIVE_DEVICE_PATH node? Thanks, Mike -Original Message- From: Justen, Jordan L Sent: Wednesday, March 25, 2015 1:58 PM To: edk2-devel@lists.sourceforge.net; Paulo Alcantara; Kinney, Michael D Subject: Re: [edk2] [PATCH 1/3

Re: [edk2] [PATCH v2] PeCoffExtraActionLibDebug: Restore debug registers in PeCoffExtraActionLibDebug

2015-03-16 Thread Kinney, Michael D
Dr7 = AsmReadDr7 () | BIT10; NewDr7 = AsmReadDr7() | BIT10; Thanks, Mike -Original Message- From: Brian J. Johnson [mailto:bjohn...@sgi.com] Sent: Monday, March 16, 2015 9:59 AM To: edk2-devel@lists.sourceforge.net; Kinney, Michael D Cc: Fan, Jeff Subject: Re: [edk2] [PATCH

Re: [edk2] [PATCH v2] PeCoffExtraActionLibDebug: Restore debug registers in PeCoffExtraActionLibDebug

2015-03-16 Thread Kinney, Michael D
Brian, In DEBUG_LOAD_IMAGE_METHOD_SOFT_INT3 mode, is there any difference in behavior if DR7 is always restored without checking state of BIT10? Thanks, Mike -Original Message- From: Brian J. Johnson [mailto:bjohn...@sgi.com] Sent: Monday, March 16, 2015 8:26 AM To: edk2-devel@lists.s

Re: [edk2] Discussion about new mailing list host

2015-03-09 Thread Lorer, Michael
Hello, what about using the Github-integrated bugtracker? --- Michael -Original Message- From: Bruce Cran [mailto:bruce.c...@gmail.com] Sent: Saturday, March 07, 2015 11:08 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Discussion about new mailing list host Was that me

Re: [edk2] [MinnowBoard] [EDK2][MNW2]: Problem building MinnowMAX firmware 0.77 on Windows.

2015-03-04 Thread Krau, Michael P
n. There are no "masses and others" here, I guess it boils down to me being kind of slow to recognize when my input might be of use. (another unintended consequence of an ill matched system) Thank you, Michael Krau   From: Gerard Bucas [mailto:gerar...@tekmagic.net] Sent: Wednesday,

Re: [edk2] [MinnowBoard] [EDK2][MNW2]: Problem building MinnowMAX firmware 0.77 on Windows.

2015-03-04 Thread Krau, Michael P
the difficulty, and thank you for the input on how to make change for the better. In my other message to Bruce Cran, I outlined the parts of target plan, which I think are close to your requests. Thank you, Michael Krau Intel SSG/STO/PSI 2111 NE 25th Ave MS JF2-24 Hillsboro, OR 97124 (503

Re: [edk2] [MinnowBoard] [EDK2][MNW2]: Problem building MinnowMAX firmware 0.77 on Windows.

2015-03-04 Thread Krau, Michael P
tracking on the Open community site. This is a necessary and useful tool. Thank you, Michael Krau From: B Cran [mailto:bruce.c...@gmail.com] Sent: Wednesday, March 04, 2015 11:57 AM To: edk2-devel@lists.sourceforge.net Cc: MinnowBoard Development and Community Discussion Subject: Re: [edk2

Re: [edk2] [MinnowBoard] [EDK2][MNW2]: Problem building MinnowMAX firmware 0.77 on Windows.

2015-03-04 Thread Krau, Michael P
would be grateful to hear of where the process is failing, and how we can make improvements. Thank you, Michael Krau From: Andrew Fish [mailto:af...@apple.com] Sent: Tuesday, March 03, 2015 10:20 PM To: gerar...@tekmagic.net; edk2-devel@lists.sourceforge.net Cc: MinnowBoard Development and

Re: [edk2] [PATCH v5a 14/29] MdePkg/BaseSynchronizationLib: Add InterlockedCompareExchange16

2015-02-27 Thread Kinney, Michael D
, Michael D Cc: Ard Biesheuvel Subject: Re: [PATCH v5a 14/29] MdePkg/BaseSynchronizationLib: Add InterlockedCompareExchange16 On 26 February 2015 at 08:50, Ard Biesheuvel wrote: > Hello all, > > This is the latest version of the InterlockedCompareExchange16() patch. > Michael has kind

Re: [edk2] [PATCH v5a 14/29] MdePkg/BaseSynchronizationLib: Add InterlockedCompareExchange16

2015-02-27 Thread Kinney, Michael D
Ard, The updated patch looks good. Reviewed-by: Michael Kinney Thanks, Mike -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, February 26, 2015 12:50 AM To: edk2-devel@lists.sourceforge.net; olivier.mar...@arm.com; ler...@redhat.com; Justen

Re: [edk2] [PATCH v4 14/29] MdePkg/BaseSynchronizationLib: implement 16-bit compare-exchange

2015-02-25 Thread Kinney, Michael D
; anthony.per...@citrix.com; xen-de...@lists.xen.org; julien.gr...@linaro.org; Justen, Jordan L; Kinney, Michael D; Tian, Feng Cc: Ard Biesheuvel Subject: [PATCH v4 14/29] MdePkg/BaseSynchronizationLib: implement 16-bit compare-exchange This implements the function InterlockedCompareExchange16 () for all

Re: [edk2] [UEFI 2.1]Ata Device

2015-02-02 Thread Lorer, Michael
You might have a look at chapter 12 in the UEFI specification (12 Protocols – Media Access). Especially 12.7 (Disk I/O), 12.8 (EFI Block I/O) and 12.11 (ATA Pass Thru) should help you. Regards, Michael From: Josiel Santos [mailto:jwvsan...@outlook.com] Sent: Monday, February 02, 2015 1:11 PM

Re: [edk2] [PATHCH] MdeModulePkg : Add a new DxeServicesLib GetSectionFromAnyFvEx() function

2014-12-11 Thread Kinney, Michael D
Cinnamon Shia, I think the original proposal would read the FFS file contents twice. Since the new API being proposed returns the Device Path to the FFS file in a specific FV, LoadImage() will not search. It knows from the Device Patch exactly where to load the FFS file from. Mike From: Shia

Re: [edk2] Possible problem with PciCf8Lib

2014-12-04 Thread Kinney, Michael D
Hi, The PciCf8Lib macros are as intended. The idea was to standardize on a single PCI address format that is can be used for either PCI Express (4KB per device) and PCI CF8/CFC access (256 byte max per device). In the implementation of BasePciCf8Lib, there is a translation from the PCI addres

Re: [edk2] MdePkg ++ Should we remove redundant Family specifiers from the INF files.

2014-11-09 Thread Kinney, Michael D
Andrew, Yes. I think these types of cleanups are good. Mike From: Andrew Fish [mailto:af...@apple.com] Sent: Friday, November 07, 2014 4:11 PM To: edk2-devel@lists.sourceforge.net Cc: Kinney, Michael D Subject: MdePkg ++ Should we remove redundant Family specifiers from the INF files. Mike

Re: [edk2] [PATCH 000/345] Convert EDK II core packages to NASM for IA32/X64

2014-11-06 Thread Kinney, Michael D
a full > validation for .nasm file. > > I am fine on adding .nasm. But can we still keep original .asm and .S file? > > > Thank you > Yao Jiewen > > -Original Message- > From: Gao, Liming > Sent: Thursday, November 06, 2014 10:48 AM > To: Justen, Jorda

Re: [edk2] [Patch 2/2] [MdePkg] INF/DEC file updates to EDK II packages

2014-08-28 Thread Kinney, Michael D
the ones generated from UPT >>> >>> 2) Guid value in section will be align. >>> >>> 3) Usage comments in section will be align. >>> >>> 4) One PCD section includes one PCD type. If one PCD supports more PCD >>> types,

Re: [edk2] Endless Loop when DEBUG_POOL used with ReportStatusCode version of DebugLib

2014-08-27 Thread Kinney, Michael D
Tim, Yes. This issue has been around a while. The workaround when you want to monitor every single pool operation in the DXE Core is to use a DebugLib instance that sends debug messages directly to a debug device such as MdePkg/Library/BaseDebugLibSerialPort. The issue with using a DebugLib in

Re: [edk2] [PATCH] MdeModulePkg: Fix EBC DXE issue with x64 function call alignment

2014-08-25 Thread Kinney, Michael D
Samer, Can you please verify that the stack is aligned in native code before calling the EBC function where this fix was required? If the native stack is always aligned correctly, can you please provide a small test case that reproduces the issue along with all the compiler/linker flags used.

Re: [edk2] [PATCH] MdeModulePkg: Fix EBC DXE issue with x64 function call alignment

2014-08-25 Thread Kinney, Michael D
Samer, Can you please provide the details on how to reproduce an incorrect stack alignment. It has been a long time since we have worked on this code, and I recall reviewing the stack alignment carefully at that time. It is possible that the code that called an EBC function has misaligned the

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Kinney, Michael D
Visual Studio for x86 at a disadvantage? Tim From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, August 20, 2014 4:59 PM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] [StdLib] Patch for review: Add VC++ helper fu

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Kinney, Michael D
result is fewer hard-to-understand linker errors than before. If you miss one function, the net result is no worse than today. Tim From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, August 20, 2014 12:30 PM To: edk2-devel@lists.sourceforge.net<mailto:edk2-de

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Kinney, Michael D
e your hand if you have done a search on u Even a partial solution will be better than no solutions because the net result is fewer hard-to-understand linker errors than before. If you miss one function, the net result is no worse than today. Tim From: Kinney, Michael D [mailto:michael

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Kinney, Michael D
Thomas, A design decision was made early in the EDK II project to not depend on any compiler intrinsic functions. The reasons include: 1) Linking against OS specific C libs has risks because it can potentially introduce OS specific sys calls. 2) Linking against OS specific C libs ca

  1   2   3   >