Re: [edk2] Installation of Firmware Management Protocol 2 on PCI Adapter with 2 ASIC's

2015-08-23 Thread Tian, Feng
FMP2? Is it a typo? UEFI spec just defines FMP. There is no specific requirement on this. You need look into the BIOS you used to see what happened. Thanks Feng From: Galla Rao [mailto:gallagnv@gmail.com] Sent: Thursday, August 20, 2015 20:57 To: edk2-devel@lists.sourceforge.net Subject: [e

Re: [edk2] HID descriptor parsing

2015-08-03 Thread Tian, Feng
UsbBusDxe driver is a bus driver who is used to enumerate attached devices and start their corresponding device drivers. So you couldn’t see HID parser in UsbBus driver. You have to see it in usb device drivers. UsbMouseDxe/MouseHid.c is such sample for how parsing HID items. From: Ulysses Mck

Re: [edk2] [PATCH 3/6] MdeModulePkg: SmbiosDxe: ARM and AARCH64 are VALID_ARCHITECTURES

2015-07-15 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, July 16, 2015 06:41 To: edk2-devel@lists.sourceforge.net Cc: Tian, Feng; Elvin Li; Zeng, Star Subject: [PATCH 3/6] MdeModulePkg: SmbiosDxe: ARM and AARCH64 are VALID_ARCHITECTURES

Re: [edk2] [PATCH 0/2] MdePkg|MdeModulePkg: constify mStatusString

2015-07-15 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Gao, Liming Sent: Thursday, July 16, 2015 08:33 To: Ard Biesheuvel; Kinney, Michael D; Tian, Feng; edk2-devel@lists.sourceforge.net Subject: RE: [PATCH 0/2] MdePkg|MdeModulePkg: constify mStatusString Reviewed-by: Liming Gao

Re: [edk2] Farewell - last days at ARM Ltd

2015-07-15 Thread Tian, Feng
Martin, Many thanks for your work on EDKII community. It helps us a lot. Good luck on your new adventure:-) Thanks Feng -Original Message- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Thursday, July 16, 2015 07:42 To: edk2-de...@lists.01.org; edk2-devel@lists.sourceforge.

Re: [edk2] [PATCH] BaseTools: Add GCC49LTO tool chain: GCC49 with link time optimization

2015-07-14 Thread Tian, Feng
Hi, Scott How do you solve the linker plugin issue? GCC49 by default supports plugin now? Thanks Feng -Original Message- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Wednesday, July 15, 2015 00:44 To: edk2-devel@lists.sourceforge.net Cc: Mcdaniel, Daryl Subject: [edk2] [PATCH]

Re: [edk2] [Patch 00/28] UefiCpuPkg: Add CpuMpPei install PI CPU MP PPI

2015-07-13 Thread Tian, Feng
Shall you allow shadow in CpuMpPei driver entry point like below? // // Shadow this PEIM to run from memory // if (!EFI_ERROR (PeiServicesRegisterForShadow (FileHandle))) { return EFI_SUCCESS; } Others look good to me Reviewed-by: Feng Tian -Original Message- From: Jeff Fa

Re: [edk2] [PATCH V2 0/3] Some improvements on serial terminal

2015-07-13 Thread Tian, Feng
For patch 2&3, Reviewed-by: Feng Tian -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Monday, July 13, 2015 11:25 To: edk2-devel@lists.sourceforge.net Cc: ler...@redhat.com; ard.biesheu...@linaro.org; Tian, Feng; Heyi Guo Subject: [edk2] [PATCH V2 0/3]

Re: [edk2] [PATCH] MdeModulePkg/FvSimpleFileSystemDxe: Support file opening with no '.efi'

2015-07-09 Thread Tian, Feng
ok on that. Could you please check in the fix? Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Thursday, July 09, 2015 18:31 To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net Subject: RE: [PATCH] MdeModulePkg

Re: [edk2] [PATCH] MdeModulePkg/Core/Pei: Fix empty loop warning

2015-07-09 Thread Tian, Feng
.com] Sent: Friday, July 10, 2015 02:30 To: edk2-devel@lists.sourceforge.net; Tian, Feng Subject: RE: [edk2] [PATCH] MdeModulePkg/Core/Pei: Fix empty loop warning I have been trying to duplicate this issue using the '-pedantic' options of LLVM and GCC and I cannot reproduce this issu

Re: [edk2] [PATCH] MdeModulePkg/FvSimpleFileSystemDxe: Support file opening with no '.efi'

2015-07-09 Thread Tian, Feng
ginal Message- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Thursday, July 09, 2015 16:53 To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net Subject: RE: [PATCH] MdeModulePkg/FvSimpleFileSystemDxe: Support file opening with no '.efi' Can you try without using EFI Shell? If y

Re: [edk2] [PATCH] MdeModulePkg/FvSimpleFileSystemDxe: Support file opening with no '.efi'

2015-07-09 Thread Tian, Feng
iableInfo" or "VariableInfo.efi" cmd. Do I misunderstand something? Thanks Feng -Original Message- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Thursday, July 09, 2015 00:32 To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net Subject: RE: [PATCH] MdeModulePkg/Fv

Re: [edk2] [PATCH V4 0/5] Add TtyTerm terminal type

2015-07-08 Thread Tian, Feng
Many thanks, Laszlo. It's nice to see your help when I am managing to merge Roy's git tree to my local :-). Please do it. Thanks Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, July 09, 2015 13:10 To: Tian, Feng; Roy Franz Cc:

[edk2] [patch] MdePkg/UefiDevicePathLib:Fix link error due to missing RamDisk GUIDs

2015-07-08 Thread Tian Feng
UefiDevicePathLibOptionalDevicePathProtocol.inf needs to be updated to add RamDisk related GUIDs for passing compiler build. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- .../UefiDevicePathLibOptionalDevicePathProtocol.inf | 8 1 file

Re: [edk2] [PATCH V4 0/5] Add TtyTerm terminal type

2015-07-08 Thread Tian, Feng
Ok, I will do it. -Original Message- From: Roy Franz [mailto:roy.fr...@linaro.org] Sent: Thursday, July 9, 2015 8:38 AM To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net; ler...@redhat.com; ard.biesheu...@linaro.org; heyi@linaro.org Subject: Re: [PATCH V4 0/5] Add TtyTerm terminal

Re: [edk2] [PATCH V4 0/5] Add TtyTerm terminal type

2015-07-08 Thread Tian, Feng
Roy, For patch 1, 2, 3, I would sign Reviewed-by: Feng Tian Thanks for your contribution. Please go ahead to check them in. -Original Message- From: Roy Franz [mailto:roy.fr...@linaro.org] Sent: Thursday, July 9, 2015 3:03 AM To: edk2-devel@lists.sourceforge.net; Tian, Feng; ler

Re: [edk2] [PATCH] MdeModulePkg: Bump the NvmExpressDxe DriverSupportedEfiVersion to UEFI 2.50

2015-07-08 Thread Tian, Feng
Could you use EFI_2_50_SYSTEM_TABLE_REVISION macro rather than hardcode? Thanks Feng -Original Message- From: Bruce Cran [mailto:br...@cran.org.uk] Sent: Wednesday, July 08, 2015 01:28 To: Feng Tian; edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH] MdeModulePkg: Bump the NvmExpre

Re: [edk2] [PATCH] MdeModulePkg/FvSimpleFileSystemDxe: Support file opening with no '.efi'

2015-07-07 Thread Tian, Feng
essage- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Tuesday, July 07, 2015 00:17 To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net; Olivier Martin; Olivier Martin Subject: [PATCH] MdeModulePkg/FvSimpleFileSystemDxe: Support file opening with no '.efi' FvSimp

[edk2] [patch] MdePkg: Add UEFI2.5 Ramdisk device path definition

2015-07-07 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdePkg/Include/Protocol/DevicePath.h | 62 ++- .../Library/UefiDevicePathLib/DevicePathFromText.c | 205 + .../Library/UefiDevicePathLib/DevicePathToText.c | 70 +++

Re: [edk2] XHCI question

2015-07-06 Thread Tian, Feng
, Baraneedharan [mailto:anbazha...@hp.com] Sent: Tuesday, July 7, 2015 10:09 AM To: Tian, Feng Cc: 'Eric Wittmayer'; 'edk2-devel@lists.sourceforge.net' Subject: RE: [edk2] XHCI question Do you have any other feedback on these code changes? If not, could you please commit t

Re: [edk2] [Patch] PcRtc: Fix PcRtcInit() to not clear RegisterB.AIE always

2015-07-06 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Ni, Ruiyu Sent: Monday, July 6, 2015 2:50 PM To: edk2-devel@lists.sourceforge.net Cc: Tian, Feng Subject: RE: [Patch] PcRtc: Fix PcRtcInit() to not clear RegisterB.AIE always Fix comments as below: PcRtc: Fix PcRtcInit() to use correct

Re: [edk2] XHCI with ARM-v8 based platform

2015-07-06 Thread Tian, Feng
You can refer to Omap35xxPkg\PciEmulation which produces PCI_IO protocol on arm board and try to build this driver and EDKII xHCI driver in your firmware to see if it works. DMA issue mentioned by Andrew is the most likely to bring bugs as in most cases IA platforms are 1:1 mapping(identical) f

Re: [edk2] Questions regarding XHCI

2015-07-05 Thread Tian, Feng
Nikhil, Just like Martin said, there is a fake PCI bus driver to solve this issue. You can refer to Omap35xxPkg\PciEmulation, which produce PCI_IO protocol on arm board. PS: It's just the EDKII implementation choice to depend on PCI bus. If your platform doesn't exist real PCI bus, you can emu

Re: [edk2] XHCI question

2015-06-25 Thread Tian, Feng
Friday, June 26, 2015 01:51 To: Tian, Feng; Eric Wittmayer; edk2-devel@lists.sourceforge.net Subject: RE: [edk2] XHCI question > -Original Message----- > From: Tian, Feng [mailto:feng.t...@intel.com] > Sent: Wednesday, June 24, 2015 11:02 PM > To: Anbazhagan, Baraneedharan; Eric

Re: [edk2] [patch 0/2] Do TPer Reset for all encrypted drives

2015-06-25 Thread Tian, Feng
Also need to remove #include from AtaBus.h and gEfiMemoryOverwriteControlDataGuid from AtaBusDxe.inf? Others are good to me. Thanks, Star -Original Message- From: Tian Feng [mailto:feng.t...@intel.com] Sent: Thursday, June 25, 2015 12:01 PM To: zeng.s...@intel.com; Yao, Jiewen Cc: edk2

Re: [edk2] XHCI question

2015-06-24 Thread Tian, Feng
Hi, Baranee Which case do you think the EvtTrb would be NULL? Thanks Feng -Original Message- From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Thursday, June 25, 2015 10:43 To: Eric Wittmayer; Tian, Feng; edk2-devel@lists.sourceforge.net Subject: RE: [edk2] XHCI question

[edk2] [patch 0/2] Do TPer Reset for all encrypted drives

2015-06-24 Thread Tian Feng
At past we only did TPer Reset for ATA device in AtaBus driver. Now a common logic to do TPer Reset is extracted and putted in TcgMor module. By this way, all encrypted drives whose driver produces EFI_STORAGE_SECURITY_ COMMAND_PROTOCOL could be force reset at EndOfDxe. Tian Feng (2

[edk2] [patch 2/2] SecurityPkg/TcgMor: move TPer Reset operation to this module

2015-06-24 Thread Tian Feng
buted-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tian Feng --- SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 264 +- SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.h | 22 +- SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.inf | 13 +- 3 files changed

[edk2] [patch 1/2] MdeModulePkg/AtaBus: remove TPer Reset operation in DriverBindingStart

2015-06-24 Thread Tian Feng
Contribution Agreement 1.0 Signed-off-by: Tian Feng --- MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c | 208 +--- MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h | 17 +-- 2 files changed, 4 insertions(+), 221 deletions(-) diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c b

Re: [edk2] XHCI question

2015-06-24 Thread Tian, Feng
Hi, Baranee 1. XhcCheckUrbResult() reports URB transfer state in Urb->Result rather than Urb->Finished. 2. XhcCheckUrbResult() is an internal function rather than an exposed interface for upper layer. 3. XhcBulkTransfer() returns status according to Urb->Result rather than others. Please let m

Re: [edk2] [PATCH 0/4] Add TtyTerm terminal type

2015-06-22 Thread Tian, Feng
Roy Thanks for your contribution, We will review it soon. Thanks Feng -Original Message- From: Roy Franz [mailto:roy.fr...@linaro.org] Sent: Tuesday, June 23, 2015 07:30 To: edk2-devel@lists.sourceforge.net; Tian, Feng; ler...@redhat.com; ard.biesheu...@linaro.org Cc: Roy Franz

Re: [edk2] [PATCH] Bump default driver supported efi version to 2.5

2015-06-22 Thread Tian, Feng
Hi, Bruce I found we should use EFI_SPECIFICATION_VERSION macro here rather than hardcode it to a 0x000200xx value. Do you agree? Thanks Feng -Original Message- From: Tian, Feng Sent: Monday, June 01, 2015 10:58 To: Bruce Cran; edk2-devel@lists.sourceforge.net Cc: Tian, Feng Subject

Re: [edk2] [PATCH v3] MdeModulePkg: Regular expression protocol

2015-06-18 Thread Tian, Feng
Thanks for your contribution, Jonathan. Eric would review this patch and get back to you if he has feedback Thanks Feng -Original Message- From: Doman, Jonathan [mailto:jonathan.do...@hp.com] Sent: Friday, June 19, 2015 02:23 To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH v

Re: [edk2] [PATCH 0/4] Add an implementation of EFI_SMART_CARD_READER_PROTOCOL

2015-06-18 Thread Tian, Feng
Hi, Ludovic Just like I said before, license issue is the biggest concern. Our license expert has confirmed GNU LGPL license would corrupt EDKII BSD license. So I would suggest you wait till we have clear conclusion on how to handle non-BSD license. As for should TianoCore/EDKII be extended to

Re: [edk2] [PATCH] MdeModulePkg: remove unused variables to fix the build

2015-06-18 Thread Tian, Feng
Hi, Ard & Laszlo Sorry for not giving feedback in time. Jiaxin has been aware of this and will fix it soon. For this build error, I double check MSDN. Looks like VS only complains those unreferenced local variables (that's VS warning C4101). But if this local variable gets assigned, then there

Re: [edk2] USB question: how change to a different alternate setting of an interface?

2015-06-17 Thread Tian, Feng
EFI_DEVICE_ERROR with your original code, am I right? Thanks Feng -Original Message- From: Eric Wittmayer [mailto:e...@frescologic.com] Sent: Wednesday, June 17, 2015 14:06 To: Tian, Feng; edk2-devel@lists.sourceforge.net Subject: RE: [edk2] USB question: how change to a different alternate

Re: [edk2] [patch] MdeModulePkg/NvmExpressDxe: Add SecurityStorageProtocl support

2015-06-15 Thread Tian, Feng
Thanks for your sharp eyesight to find out these typos:) I will fix them at check-in. -Original Message- From: Zeng, Star Sent: Monday, June 15, 2015 21:47 To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net Subject: RE: [patch] MdeModulePkg/NvmExpressDxe: Add SecurityStorageProtocl

Re: [edk2] [Patch 3/3] UefiCpuPkg/CpuDxe: Get CPU BIST information from Guided HOB

2015-06-14 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Thursday, June 11, 2015 16:51 To: edk2-devel@lists.sourceforge.net Cc: Tian, Feng Subject: [Patch 3/3] UefiCpuPkg/CpuDxe: Get CPU BIST information from Guided HOB Get CPU BIST information from

Re: [edk2] USB question: how change to a different alternate setting of an interface?

2015-06-11 Thread Tian, Feng
Hi, Eric It should be enough to get alternative setting through these two steps you did. Could you let me know whether you saw this debug message " UsbSelectSetting: setting %d selected for interface %d " got printed ? and which values are in the printed message? Thanks Feng -Original Mes

[edk2] [patch] MdeModulePkg/NvmExpressDxe: Add SecurityStorageProtocl support

2015-06-10 Thread Tian Feng
Produce this protocol for each namespace at NVMe controller. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tian Feng --- MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c| 68 - MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h| 39 ++- .../Bus/Pci

[edk2] [patch] MdeModulePkg/NvmExpressDxe: Open NVME_PASS_THRU with BY_CHILD attr

2015-06-10 Thread Tian Feng
Open NVM_EXPRESS_PASS_THRU rather than PCI_IO to create parent-child relationship. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tian Feng --- MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c | 27 ++--- 1 file changed, 15 insertions(+), 12 deletions

[edk2] [patch] MdeModulePkg/NvmExpressDxe: local variable naming uniformed

2015-06-10 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tian Feng --- .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c | 64 +++--- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c b

Re: [edk2] [Patch] PcAtChipsetPkg/PcRtc: Fix a Y2K bug

2015-06-10 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Ni, Ruiyu Sent: Wednesday, June 10, 2015 12:11 To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Tian, Feng; Gao, Liming; Kinney, Michael D Subject: [Patch] PcAtChipsetPkg/PcRtc: Fix a Y2K bug The original driver cannot handle the case

Re: [edk2] [PATCH 0/4] Add an implementation of EFI_SMART_CARD_READER_PROTOCOL

2015-06-10 Thread Tian, Feng
Ludovic, The license issue is the biggest concern. EDKII project is BSD license, but your proposed patch 1 is using LGPL license which may corrupt EDKII project. Thanks Feng -Original Message- From: Ludovic Rousseau [mailto:ludovic.rouss...@gmail.com] Sent: Thursday, June 11, 2015 02:2

Re: [edk2] [Patch 2/2] IntelFrameworkModulePkg/IsaSerialDxe: Use PcdSerialClockRate instead of hard code value

2015-06-09 Thread Tian, Feng
Good to me. Reviewed-by: Feng Tian -Original Message- From: Ni, Ruiyu Sent: Wednesday, June 10, 2015 11:22 To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch 2/2] IntelFrameworkModulePkg/IsaSerialDxe: Use PcdSerialClockRate instead of hard code value So

Re: [edk2] [Patch 1/2] MdeModulePkg: Extend PcdSerialClockRate to dynamic type

2015-06-09 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Ni, Ruiyu Sent: Wednesday, June 10, 2015 11:22 To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch 1/2] MdeModulePkg: Extend PcdSerialClockRate to dynamic type So it could allow platform module to change the

Re: [edk2] Question about WinDbg Support--

2015-06-09 Thread Tian, Feng
Conclusion sharing after offline discussion with Sai: After adding /GL- besides /Od, the local variables/function parameters could be resolved in Windbg. Thanks Feng From: Saiprasad Chavali [mailto:s...@marvell.com] Sent: Wednesday, June 10, 2015 08:35 To: Tian, Feng; 'edk2-

Re: [edk2] Question about WinDbg Support--

2015-06-09 Thread Tian, Feng
l.com] Sent: Wednesday, June 10, 2015 05:47 To: Tian, Feng; 'edk2-devel@lists.sourceforge.net' Subject: RE: [edk2] Question about WinDbg Support-- Hi, Even after turning on the "Build option: /Od" for the Dxe module/driver, local variables/function parameters are not getting

Re: [edk2] [PATCH] MdeModulePkg: Fix bug of AllocatePages for large alignment

2015-06-07 Thread Tian, Feng
From: Heyi Guo [mailto:heyi@linaro.org] Sent: Monday, June 08, 2015 12:26 To: edk2-devel@lists.sourceforge.net; Tian, Feng Cc: Ilias Biris Subject: Re: [edk2] [PATCH] MdeModulePkg: Fix bug of AllocatePages for large alignment Thanks Liming. I saw Tian is the maintainer of MdeModulePkg, so I ha

Re: [edk2] [patch 0/4] EDKII Usb stack async transfer performance tunning

2015-06-04 Thread Tian, Feng
the cpu consumption in virtualization platform for Uhci/Ehci/Xhci h/w simulation should be same, just there is one more 1ms s/w timer. Thanks Feng -Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Thursday, June 04, 2015 23:36 To: Laszlo Ersek Cc: Tian, Feng; edk2

[edk2] [patch 3/4] MdeModulePkg/UhciDxe: Update async polling interval to 1ms.

2015-06-03 Thread Tian Feng
Updating the async polling interval from 50ms to 1ms for better performance. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tian Feng --- MdeModulePkg/Bus/Pci/UhciDxe/Uhci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Pci

[edk2] [patch 4/4] MdeModulePkg/EhciPei: Remove unused macro

2015-06-03 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tian Feng --- MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h b/MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h index fa1671b

[edk2] [patch 2/4] MdeModulePkg/EhciDxe: Update async polling interval to 1ms.

2015-06-03 Thread Tian Feng
Updating the async polling interval from 50ms to 1ms for better performance. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tian Feng --- MdeModulePkg/Bus/Pci/EhciDxe/Ehci.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Bus/Pci

[edk2] [patch 1/4] MdeModulePkg/XhciDxe: Update async polling interval to 1ms.

2015-06-03 Thread Tian Feng
Updating the async polling interval from 50ms to 1ms for better performance. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tian Feng --- MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Pci

[edk2] [patch 0/4] EDKII Usb stack async transfer performance tunning

2015-06-03 Thread Tian Feng
Update the value of those async polling interval macros from 50ms to 1ms. Tian Feng (4): MdeModulePkg/XhciDxe: Update async polling interval to 1ms. MdeModulePkg/EhciDxe: Update async polling interval to 1ms. MdeModulePkg/UhciDxe: Update async polling interval to 1ms. MdeModulePkg/EhciPei

Re: [edk2] NVMe question

2015-06-03 Thread Tian, Feng
Got your point. Ok, I will roll back the change Thanks Feng -Original Message- From: Busch, Keith Sent: Wednesday, June 03, 2015 22:47 To: Tian, Feng; Laszlo Ersek Cc: edk2-devel@lists.sourceforge.net; Anbazhagan, Baraneedharan; qemu devel list Subject: RE: [edk2] NVMe question

Re: [edk2] NVMe question

2015-06-02 Thread Tian, Feng
-devel@lists.sourceforge.net; Anbazhagan, Baraneedharan; Tian, Feng; Busch, Keith Cc: qemu devel list Subject: Re: [edk2] NVMe question On 06/02/15 09:19, Tian, Feng wrote: > Thanks for the info. > > > > I didn't test it on NVMe-Qemu, I just run the change on a real >

Re: [edk2] NVMe question

2015-06-02 Thread Tian, Feng
: Laszlo Ersek Cc: edk2-devel@lists.sourceforge.net; Anbazhagan, Baraneedharan; Tian, Feng; Busch, Keith; qemu devel list Subject: Re: [edk2] NVMe question Hi, On Tue, 2 Jun 2015, Laszlo Ersek wrote: > removed the nonzero initialization of Cc.Iosqes (submission queue > size?) and Cc.

Re: [edk2] NVMe question

2015-06-02 Thread Tian, Feng
Thanks for the info. I didn't test it on NVMe-Qemu, I just run the change on a real production. I will do bigger scope test to see if it's valuable to add it back. Thanks Feng From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Tuesday, June 02, 2015 06:22 To: Tian,

Re: [edk2] [PATCH] Bump default driver supported efi version to 2.5

2015-05-31 Thread Tian, Feng
Message- From: Bruce Cran [mailto:br...@cran.org.uk] Sent: Friday, May 29, 2015 23:26 To: Tian, Feng; edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] Bump default driver supported efi version to 2.5 Thanks. I've attached a new version of the patch. -- Bruce On 5/29/2015 2:

Re: [edk2] NVMe question

2015-05-31 Thread Tian, Feng
Hi, Baraneedharan Why I removed these two fields initialization is because NVMe spec 7.6.1 doesn't say it's mandatory. Do you see any real impact on this? Thanks Feng From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Saturday, May 30, 2015 06:21 To: Tian, Feng;

Re: [edk2] [PATCH] Bump default driver supported efi version to 2.5

2015-05-29 Thread Tian, Feng
Hi, Bruce The modules in MdeModulePkg couldn't depend on OptionRomPkg. So your change is not ok for me. I would prefer to directly assign 0x00020032 to gNvmExpressDriverSupportedEfiVersion.FirmwareVersion. Thanks Feng -Original Message- From: Bruce Cran [mailto:br...@cran.org.uk] Sen

[edk2] [patch] MdeModulePkg/AtaAtapiPassThru: ensure PRDT of IDE is in 64K boundary

2015-05-29 Thread Tian Feng
Follow IDE BUS Master spec to ensure the PRDT table not cross 64k boundary in memory. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 55 + 1 file changed, 38 insertions(+), 17 deletion

Re: [edk2] [PATCH] MdeModulePkg/DxeCore: Fixed build error

2015-05-28 Thread Tian, Feng
Good to me as well. Reviewed-by: Feng Tian -Original Message- From: Jordan Justen [mailto:jordan.l.jus...@intel.com] Sent: Thursday, May 28, 2015 23:01 To: Zeng, Star; edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] MdeModulePkg/DxeCore: Fixed build error For your attached

[edk2] [patch] MdeModulePkg/Ufs: Refine EDKII_UFS_HOST_CONTROLLER_PROTOCOL interface

2015-05-26 Thread Tian Feng
The EDKII_UFS_HOST_CONTROLLER_PROTOCOL is refined to provide interfaces accessing UFS host controller MMIO register. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.c | 147 - MdeModulePkg/Bus/Pci/UfsPc

Re: [edk2] [PATCH] MdePkg: fix compilation error

2015-05-24 Thread Tian, Feng
Thanks, Rousseau. Yes, it's a typo and should be fixed. Reviewed-by: Feng Tian PS: I didn't see your first mail, that's why we have no response to you. Where did you post it to? Thanks Feng -Original Message- From: Ludovic Rousseau [mailto:ludovic.rouss...@gmail.com] Sent: Saturday

[edk2] [patch] MdeModulePkg/AtaAtapiPassThruDxe: Support 4K bytes block size HDDs

2015-05-21 Thread Tian Feng
The original code hard-codes block size to 512. But after ATA 7 spec, the non-512 block size is also supported. The code is updated to dynamically calculate the block size according to IDENTIFY data. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- .../Bus/Ata

Re: [edk2] [patch 0/5] Add RecoveryBlockIo2Ppi Support

2015-05-19 Thread Tian, Feng
Hi, Star Please review the latest patches Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, May 20, 2015 10:55 To: Tian, Feng; edk2-devel@lists.sourceforge.net Cc: Gao, Liming Subject: RE: [patch 0/5] Add RecoveryBlockIo2Ppi Support For patch 2/5: In

Re: [edk2] [patch] FatPkg: Add RecoveryBlockIo2Ppi support

2015-05-19 Thread Tian, Feng
Thanks, Ray I update the patch according to your comment. Please review again Thanks Feng From: Ni, Ruiyu Sent: Tuesday, May 19, 2015 14:04 To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net Subject: RE: [patch] FatPkg: Add RecoveryBlockIo2Ppi support Feng, Could you please refine the code to

[edk2] [patch] FatPkg: Add RecoveryBlockIo2Ppi support

2015-05-17 Thread Tian, Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian mailto:feng.t...@intel.com>> Thanks Feng FatPei.patch Description: FatPei.patch -- One dashboard for servers and applications across Physi

[edk2] [patch 2/5] MdeModulePkg/IdeBusPei: Add RecoveryBlockIo2 support

2015-05-17 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/IdeBusPei/AtapiPeim.c | 363 ++- MdeModulePkg/Bus/Pci/IdeBusPei/AtapiPeim.h | 142 ++- MdeModulePkg/Bus/Pci/IdeBusPei/IdeBusPei.inf | 5 +- 3 files chang

[edk2] [patch 0/5] Add RecoveryBlockIo2Ppi Support

2015-05-17 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Tian Feng (5): MdePkg: Add RecoveryBlockIo2Ppi definition to follow PI1.4 spec MdeModulePkg/IdeBusPei: Add RecoveryBlockIo2 support MdeModulePkg/UsbBotPei: Add RecoveryBlockIo2Ppi support MdeModulePkg

[edk2] [patch 5/5] MdeModulePkg/UfsBlockIoPei: Add RecoveryBlockIo2Ppi support

2015-05-17 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 268 ++--- MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.h | 128 +- .../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.inf| 1 + 3 f

[edk2] [patch 4/5] MdeModulePkg/CdExpressPei: Add RecoveryBlockIo2Ppi support

2015-05-17 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- .../Universal/Disk/CdExpressPei/CdExpressPei.inf | 5 +- .../Universal/Disk/CdExpressPei/PeiCdExpress.c | 211 + .../Universal/Disk/CdExpressPei/PeiCdExpress.h | 20 +- 3 files ch

[edk2] [patch 1/5] MdePkg: Add RecoveryBlockIo2Ppi definition to follow PI1.4 spec

2015-05-17 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdePkg/Include/Ppi/BlockIo2.h | 223 ++ MdePkg/MdePkg.dec | 5 +- 2 files changed, 227 insertions(+), 1 deletion(-) create mode 100644 MdePkg/Include/Ppi/Blo

[edk2] [patch 3/5] MdeModulePkg/UsbBotPei: Add RecoveryBlockIo2Ppi support

2015-05-17 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c| 45 +++-- MdeModulePkg/Bus/Usb/UsbBotPei/UsbBotPei.inf | 3 +- MdeModulePkg/Bus/Usb/UsbBotPei/UsbBotPeim.c | 236 +-- MdeModulePkg/Bus/Us

Re: [edk2] Question about EFI_DISK_INFO_PROTOCOL

2015-05-17 Thread Tian, Feng
No, you have to check PI spec volume 5 section 7.3.1. EFI_DISK_INFO_PROTOCOL is defined in PI spec. it's available and is useful for BDS/upper app to show up disk info, such as the disk model string. Thanks Feng -Original Message- From: Paulo Alcantara [mailto:pca...@zytor.com] Sent:

Re: [edk2] Question about WinDbg Support--

2015-05-11 Thread Tian, Feng
.com] Sent: Tuesday, May 12, 2015 07:38 To: Tian, Feng; 'edk2-devel@lists.sourceforge.net' Subject: RE: [edk2] Question about WinDbg Support-- Hi Feng, Need some help, as USB->SerialAdapter is not an option, I replaced with a proper serial port, now I am having issues with Windbg on &quo

Re: [edk2] [PATCH 07/11] MdeModulePkg: SmmIplEntry(): don't suppress SMM core startup failure

2015-05-11 Thread Tian, Feng
Ersek [mailto:ler...@redhat.com] Sent: Saturday, May 09, 2015 02:52 To: edk2-devel@lists.sourceforge.net Cc: Tian, Feng Subject: [PATCH 07/11] MdeModulePkg: SmmIplEntry(): don't suppress SMM core startup failure When the ExecuteSmmCoreFromSmram() function fails, SmmIplEntry() restores the

[edk2] [patch] MdePkg: Add UEFI 2.5 SD (Secure Digital) Device Path Definitions

2015-05-08 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Reviewed-by: Star Zeng --- MdePkg/Include/Protocol/DevicePath.h | 11 .../Library/UefiDevicePathLib/DevicePathFromText.c | 29 .../Library/UefiDevicePathLib/DevicePathToTe

[edk2] [patch] MdePkg: Update Usb2Hc Isochronous related functions' description

2015-05-08 Thread Tian Feng
IsochronousTransfer/AsyncIsochronousTransfer() interface descriptions get updated to follow UEFI2.5 spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdePkg/Include/Protocol/Usb2HostController.h | 69 ++-- 1 file changed, 66 insert

[edk2] [patch] MdePkg: Add missing GUID variables in BlockIoCrypto.h

2015-05-08 Thread Tian Feng
Declares some extern EFI_GUID variables which correspond to guid macros in BlockIoCrypto.h for C code use. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdePkg/Include/Protocol/BlockIoCrypto.h | 4 MdePkg/MdePkg.dec | 4 2 fi

[edk2] [patch] MdePkg: Add missing GUID variables in SmartCardEdge.h

2015-05-08 Thread Tian Feng
Declares some extern EFI_GUID variables which correspond to guid macros in SmartCardEdge.h for C code use. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdePkg/Include/Protocol/SmartCardEdge.h | 13 + MdePkg/MdePkg.dec | 7

Re: [edk2] [Patch V2 0/2] MdePkg: Add URI_DEVICE_PATH.

2015-05-08 Thread Tian, Feng
Good to me. Reviewed-by: Feng.Tian -Original Message- From: Ruiyu Ni [mailto:ruiyu...@intel.com] Sent: Friday, May 08, 2015 15:23 To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch V2 0/2] MdePkg: Add URI_DEVICE_PATH. The patch adds URI device path node definition and FromText

Re: [edk2] [Patch 0/2] MdePkg: Add URI_DEVICE_PATH.

2015-05-07 Thread Tian, Feng
Looks good to me Reviewed-by: Feng Tian -Original Message- From: Ruiyu Ni [mailto:ruiyu...@intel.com] Sent: Tuesday, April 28, 2015 13:38 To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 0/2] MdePkg: Add URI_DEVICE_PATH. The patch adds URI device path node definition and Fro

Re: [edk2] Question about WinDbg Support-- Target with USB->Serial Adapter.

2015-05-06 Thread Tian, Feng
Yes, the driver you saw is a UEFI driver and only for DXE phase. To enable this feature, you need develop a new DebugCommunicationLibFtdi library instance for SEC/PEI/DXE phase. Thanks Feng From: Saiprasad Chavali [mailto:s...@marvell.com] Sent: Thursday, May 7, 2015 8:56 AM To: Tian, Feng

Re: [edk2] Question about WinDbg Support-- Target with USB->Serial Adapter.

2015-05-06 Thread Tian, Feng
Hi, Sai We don't support this usage. Such usage model needs a Ftdi driver in Target BIOS. Thanks Feng From: Saiprasad Chavali [mailto:s...@marvell.com] Sent: Thursday, May 7, 2015 1:18 AM To: edk2-devel@lists.sourceforge.net; Tian, Feng Subject: RE: [edk2] Question about WinDbg Su

Re: [edk2] Question about WinDbg Support-- Target with USB->Serial Adapter.

2015-05-06 Thread Tian, Feng
For Usb2Serial cable, we support the usage that the cable's usb end is connected with Host and the cable's serial end is connected with Target. By this way, Host will identify a new COM port when connecting this cable like above. UDK Debugger will treat it as a real serial cable to access. From

[edk2] [patch] MdePkg: Add UEFI2.5 USB Function I/O protocol definitions

2015-05-04 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Reviewed-by: Star Zeng --- MdePkg/Include/Protocol/UsbFunctionIo.h | 683 MdePkg/MdePkg.dec | 3 + 2 files changed, 686 insertions(+) create mode 100644 MdeP

[edk2] [patch] MdePkg: Add UEFI2.5 Smart Card Reader protocol definitions

2015-05-04 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Reviewed-by: Star Zeng --- MdePkg/Include/Protocol/SmartCardReader.h | 326 ++ MdePkg/MdePkg.dec | 3 + 2 files changed, 329 insertions(+) create mode 100644 Md

[edk2] [patch] MdePkg: Add UEFI2.5 Smart Card Edge protocol definitions

2015-05-04 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Reviewed-by: Star Zeng --- MdePkg/Include/Protocol/SmartCardEdge.h | 726 MdePkg/MdePkg.dec | 3 + 2 files changed, 729 insertions(+) create mode 100644 MdeP

[edk2] [patch] MdePkg: Add UEFI2.5 Inline Cryptographic Interface definition

2015-05-04 Thread Tian Feng
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Reviewed-by: Star Zeng --- MdePkg/Include/Protocol/BlockIoCrypto.h | 526 MdePkg/MdePkg.dec | 8 +- 2 files changed, 533 insertions(+), 1 deletion(-) create

Re: [edk2] [patch 0/2] Add EFI_NVME_PASS_THRU_PROTOCOL support

2015-05-03 Thread Tian, Feng
Yes, the patches are specific for UEFI 2.5 EFI_NVME_PASS_THRU_PROTOCOL support. If no further comments, I will check it in to EDKII open source repo(that is the link you show below). -Original Message- From: Simon (Xiang) Lian-SSI [mailto:simon.l...@ssi.samsung.com] Sent: Saturday, May

Re: [edk2] [Patch]: AsmFlushCacheLine() bug fixes: MdePkg/BaseLib

2015-04-29 Thread Tian, Feng
Looks good to me. Reviewed-by: Feng Tian From: Kinney, Michael D Sent: Thursday, April 30, 2015 10:29 To: edk2-devel@lists.sourceforge.net; Justen, Jordan L; Tian, Feng Subject: [edk2] [Patch]: AsmFlushCacheLine() bug fixes: MdePkg/BaseLib MdePkg/BaseLib: Preserve EBX register and fix stack

Re: [edk2] how to produce COD file for library files?

2015-04-29 Thread Tian, Feng
use /GL- /Od rather than /O1ib2s and /GL From: tiger...@zhaoxin.com [mailto:tiger...@zhaoxin.com] Sent: Wednesday, April 29, 2015 7:29 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] how to produce COD file for library files? Hi, experts: I revised Conf/tools.def.txt : DEBUG_VS2008x86_X64

Re: [edk2] [Patch V2 5/10] Add Quark SoC Compatibility: MdeModulePkg : BaseSerialPortLib16550

2015-04-27 Thread Tian, Feng
Good to me Reviewed-by: Feng Tian From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Monday, April 27, 2015 13:55 To: edk2-devel@lists.sourceforge.net; Justen, Jordan L Subject: [edk2] [Patch V2 5/10] Add Quark SoC Compatibility: MdeModulePkg : BaseSerialPortLib16550 Add stride

Re: [edk2] MdeModulePkg:Fix required in NvmExpressDxe driver

2015-04-24 Thread Tian, Feng
baban.devk...@seagate.com] Sent: Friday, April 24, 2015 14:14 To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net; baban...@gmail.com Subject: Re: MdeModulePkg:Fix required in NvmExpressDxe driver Hi Feng, This modified code does calculate PrpListNo and Remainder correctly for both aligned and

Re: [edk2] XHCI data transfer size

2015-04-22 Thread Tian, Feng
Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, April 22, 2015 16:16 To: Tian, Feng; Anbazhagan, Baraneedharan Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] XHCI data transfer size On 04/22/15 10:07, Laszlo Ersek wrote: > On 04/22/15 09:05, Tian,

Re: [edk2] XHCI data transfer size

2015-04-22 Thread Tian, Feng
oCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Thanks Feng -Original Message- From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Wednesday, April 22, 2015 06:46 To: Laszlo Ersek; Tian, Feng Cc: edk2-devel@lists.sourceforge.net Subject: RE: [edk2] XHCI data transfer

Re: [edk2] XHCI data transfer size

2015-04-21 Thread Tian, Feng
Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, April 21, 2015 15:09 To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net; Anbazhagan, Baraneedharan Subject: Re: [edk2] XHCI data transfer size On 04/21/15 05:04, Tian, Feng wrote: > Baranee & La

  1   2   3   4   >