Re: [Emc-developers] Fanuc compatibility: g52 feature branch

2015-12-18 Thread John Morris
On 11/21/2015 10:58 PM, Sebastian Kuzminsky wrote: > On 11/21/2015 03:16 PM, Chris Radek wrote: >> On Fri, Nov 06, 2015 at 10:48:17AM -0600, John Morris wrote: >>> >>> Thanks, Chris, for the initial (offline) review! >>> >>> Chris's suggestions are mostly (doc link problem fixed in main commit) >>>

Re: [Emc-developers] Fanuc compatibility: g52 feature branch

2015-11-21 Thread Sebastian Kuzminsky
On 11/21/2015 03:16 PM, Chris Radek wrote: > On Fri, Nov 06, 2015 at 10:48:17AM -0600, John Morris wrote: >> >> Thanks, Chris, for the initial (offline) review! >> >> Chris's suggestions are mostly (doc link problem fixed in main commit) >> incorporated in the top commit of [1], above. I'll squas

Re: [Emc-developers] Fanuc compatibility: g52 feature branch

2015-11-21 Thread Chris Radek
On Fri, Nov 06, 2015 at 10:48:17AM -0600, John Morris wrote: > > Thanks, Chris, for the initial (offline) review! > > Chris's suggestions are mostly (doc link problem fixed in main commit) > incorporated in the top commit of [1], above. I'll squash them down for > the final version, but left t

Re: [Emc-developers] Fanuc compatibility: g52 feature branch

2015-11-06 Thread John Morris
On 10/29/2015 10:32 PM, John Morris wrote: > Hello all, > > A feature branch [1] is ready for review that implements the G52 > instruction, 'local coordinate offsets', for increased Fanuc > compatibility. See the top commit log for more, and read the added docs. > > Thanks again to Tormach for spo

[Emc-developers] Fanuc compatibility: g52 feature branch

2015-10-29 Thread John Morris
Hello all, A feature branch [1] is ready for review that implements the G52 instruction, 'local coordinate offsets', for increased Fanuc compatibility. See the top commit log for more, and read the added docs. Thanks again to Tormach for sponsoring the work, and to Chris Radek, John Prentice