Re: [E-devel] A (Serious) Note Regarding Eflete

2018-06-25 Thread Hermet Park
Thankfully, Xavi Artigas fixed. Even though unstable but it's compilable on devel branch now. Actually, efl has been bad at compatibility so far. After 1 year leaving, Enventor has totally collapsed which was stable enough. It's not about interface nor compilation but behaviors. UIs is too

Re: [E-devel] A (Serious) Note Regarding Eflete

2018-06-25 Thread Simon Lees
On 26/06/18 04:36, Mike Blumenkrantz wrote: > Hi, > > Do not attempt to use Eflete. > > I was attempting to examine a related issue from phab today on my test > machine and Eflete somehow managed to delete nearly EVERYTHING from my home > directory. All my .directories, all my source trees,

[E-devel] A (Serious) Note Regarding Eflete

2018-06-25 Thread Mike Blumenkrantz
Hi, Do not attempt to use Eflete. I was attempting to examine a related issue from phab today on my test machine and Eflete somehow managed to delete nearly EVERYTHING from my home directory. All my .directories, all my source trees, everything deleted. Fortunately, this was only a testing

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_gfx_path: make counters unsigned

2018-06-25 Thread Stephen Houston
I agree with this. The popup scrollable bug we have all been fighting to no avail appears to be the result of a one line/one word change that has created more pain than most large commits have created. So "simple" or "easy" does not mean "impossible to get wrong" or "not buggy". Going through

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_gfx_path: make counters unsigned

2018-06-25 Thread Mike Blumenkrantz
I think it's a bit misleading to look at this patch (or any so-called trivial patch) and say "this is small, let's skip review". Please consider these points: * Even very small patches can create bugs. I think we have all seen this at one point or another, but when the author views something as

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_gfx_path: make counters unsigned

2018-06-25 Thread Hermet Park
Actually, that will be better If patches could get in after good reviews. However if the patches are very small trivial changes just like this case (no logical changes, fix just typo, fix simple compile warning, etc.. well I feel it's too burdensome than we can obtain. On Mon, Jun 25, 2018 at

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_gfx_path: make counters unsigned

2018-06-25 Thread Marcel Hollerbach
As I said in the ticket, we can get back and discuss if we need review for things like this. But i have to say, even reviewing those tiny things can be good. I can have weird things in mind for big commits or small commits, so reviewing all of them is a good idea IMO, Independent from their

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_gfx_path: make counters unsigned

2018-06-25 Thread The Rasterman
On Mon, 25 Jun 2018 14:48:54 +0900 Hermet Park said: > Hmm... do we really need to get a review for this kind of small fix? > At least, committers are proved, definitely know some patches are just > about trivial fix, not necessary get a review. if they wish to make work for themselves and