Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-20 Thread The Rasterman
On Wed, 21 Dec 2011 14:06:27 +0900 Bluezery said: > 2011/12/21 Carsten Haitzler : > > On Wed, 21 Dec 2011 11:44:29 +0900 Bluezery said: > > > >> 2011/12/20 Tom Hacohen : > >> > On 20/12/11 12:27, Carsten Haitzler (The Rasterman) wrote: > >> >> agreed. programmer should simply try and use pinch g

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-20 Thread Bluezery
2011/12/21 Carsten Haitzler : > On Wed, 21 Dec 2011 11:44:29 +0900 Bluezery said: > >> 2011/12/20 Tom Hacohen : >> > On 20/12/11 12:27, Carsten Haitzler (The Rasterman) wrote: >> >> agreed. programmer should simply try and use pinch gestures and if he >> >> doesnt get any either its not possible (

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-20 Thread The Rasterman
On Wed, 21 Dec 2011 11:44:29 +0900 Bluezery said: > 2011/12/20 Tom Hacohen : > > On 20/12/11 12:27, Carsten Haitzler (The Rasterman) wrote: > >> agreed. programmer should simply try and use pinch gestures and if he > >> doesnt get any either its not possible (no multi-touch device) or, no > >> em

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-20 Thread Bluezery
2011/12/20 Tom Hacohen : > On 20/12/11 12:27, Carsten Haitzler (The Rasterman) wrote: >> agreed. programmer should simply try and use pinch gestures and if he doesnt >> get any either its not possible (no multi-touch device) or, no emulated >> gesture/input is being used (he really is looking at zo

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-20 Thread Tom Hacohen
On 20/12/11 12:27, Carsten Haitzler (The Rasterman) wrote: > agreed. programmer should simply try and use pinch gestures and if he doesnt > get any either its not possible (no multi-touch device) or, no emulated > gesture/input is being used (he really is looking at zoom not pinch so you can > emul

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-20 Thread David Seikel
On Tue, 20 Dec 2011 19:27:34 +0900 Carsten Haitzler (The Rasterman) wrote: > On Fri, 16 Dec 2011 17:35:16 +0900 Daniel Juyung Seo > said: > > > On Thu, Dec 15, 2011 at 11:59 PM, Tom Hacohen > > wrote: > > > On 15/12/11 16:34, Bluezery wrote: > > >> > > >> I reflected Daniel's comments.  I adde

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-20 Thread The Rasterman
On Fri, 16 Dec 2011 17:35:16 +0900 Daniel Juyung Seo said: > On Thu, Dec 15, 2011 at 11:59 PM, Tom Hacohen > wrote: > > On 15/12/11 16:34, Bluezery wrote: > >> > >> I reflected Daniel's comments.  I added setter/getter APIs for all > >> gesture configuration. :D > >> Please review again. > > > >

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-20 Thread The Rasterman
On Thu, 15 Dec 2011 15:11:11 +0900 Daniel Juyung Seo said: > Overall idea looks good. > > 1) wrap 80 chars > > evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_RESIZE, > > _rect_resize_cb, obj); > > This is too long. EFL sources are written based on 80 chars per line policy. > Please wrap

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-18 Thread Tom Hacohen
On 18/12/11 10:48, Tom Hacohen wrote: > On 16/12/11 03:31, Bluezery wrote: >> No problem!! I have learned a lot. :D >> I removed whole gesture layer's get/set APIs. > > Thanks for understanding. :) > > > Actually, taking another look at the glayer code, I now remember that > zoom can be caused by t

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-18 Thread Tom Hacohen
On 16/12/11 03:31, Bluezery wrote: > No problem!! I have learned a lot. :D > I removed whole gesture layer's get/set APIs. Thanks for understanding. :) Actually, taking another look at the glayer code, I now remember that zoom can be caused by things other than "pinch" which are not patented.

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-16 Thread Daniel Juyung Seo
On Thu, Dec 15, 2011 at 11:59 PM, Tom Hacohen wrote: > On 15/12/11 16:34, Bluezery wrote: >> >> I reflected Daniel's comments.  I added setter/getter APIs for all >> gesture configuration. :D >> Please review again. > > > I have a couple of more suggestions: > 1. I'm very very sorry, I just saw so

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-15 Thread Bluezery
2011/12/15 Tom Hacohen : > I have a couple of more suggestions: > 1. I'm very very sorry, I just saw something I missed in Daniel's comment, > get/set APIs is actually not needed, sorry. :((( please remove. > The reason for that is that those are configurations you set on the > environment and shou

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-15 Thread Tom Hacohen
On 15/12/11 16:34, Bluezery wrote: > Apple actually doesn't have a patent on "pinch-to-zoom but have limited. :p > Please refers: > http://www.engadget.com/2010/10/13/apple-awarded-limited-patent-on-pinch-to-zoom/ > Anyway, we should be able to configure gestures with fingers because > we cannot r

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-15 Thread Tom Hacohen
On 15/12/11 16:34, Bluezery wrote: > I reflected Daniel's comments. I added setter/getter APIs for all > gesture configuration. :D > Please review again. I have a couple of more suggestions: 1. I'm very very sorry, I just saw something I missed in Daniel's comment, get/set APIs is actually not n

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-15 Thread Bluezery
2011/12/15 Tom Hacohen : > On 15/12/11 08:11, Daniel Juyung Seo wrote: >> Overall idea looks good. >> >> 1) wrap 80 chars >>> evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_RESIZE, >>> _rect_resize_cb, obj); >> >> This is too long. EFL sources are written based on 80 chars per line policy.

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-14 Thread Tom Hacohen
On 15/12/11 08:11, Daniel Juyung Seo wrote: > Overall idea looks good. > > 1) wrap 80 chars >> evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_RESIZE, >> _rect_resize_cb, obj); > > This is too long. EFL sources are written based on 80 chars per line policy. > Please wrap them correctly. > >

Re: [E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-14 Thread Daniel Juyung Seo
Overall idea looks good. 1) wrap 80 chars > evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_RESIZE, > _rect_resize_cb, obj); This is too long. EFL sources are written based on 80 chars per line policy. Please wrap them correctly. 2) remove unrelated changes Check config/profile.src, src/

[E-devel] [Patch][elm_config] Add pinch zoom enable configuration

2011-12-14 Thread Bluezery
Dear all, Elementary can be used for all because EFL is an open source. But multi Touch event can have paten issue such as pinch zooming action. So, I add "finger(pinch) zooming action" to elm_config to can be enabled or disabled. This configuration value can be used for diverse product. It's my p