Re: [E-devel] EFL coding style

2010-03-24 Thread Gustavo Sverzut Barbieri
On Wed, Mar 24, 2010 at 11:11 PM, Lucas De Marchi wrote: > On Wed, Mar 24, 2010 at 8:19 AM, Gustavo Sverzut Barbieri > wrote: >> On Wed, Mar 24, 2010 at 8:01 AM, Tom Hacohen wrote: >>> On Wed, Mar 24, 2010 at 1:23 AM, André Dieb wrote: >>> Ressurecting this discussion... any new thoughts?

Re: [E-devel] EFL coding style

2010-03-24 Thread Lucas De Marchi
On Wed, Mar 24, 2010 at 8:19 AM, Gustavo Sverzut Barbieri wrote: > On Wed, Mar 24, 2010 at 8:01 AM, Tom Hacohen wrote: >> On Wed, Mar 24, 2010 at 1:23 AM, André Dieb wrote: >> >>> Ressurecting this discussion... any new thoughts? >>> >>> Having a sane and consistent coding style is very importan

Re: [E-devel] EFL coding style

2010-03-24 Thread Tom Hacohen
> > I hate it, always have. I actually really like the kernel's coding > > conventions: http://www.kernel.org/doc/Documentation/CodingStyle > > Well, there is always a coding style one will hate, and another will > love. As this is meritocracy and raster did most of the code, it's > better to have

Re: [E-devel] EFL coding style

2010-03-24 Thread Vincent Torri
On Wed, 24 Mar 2010, Tom Haste wrote: > http://trac.enlightenment.org/e/wiki/ECoding > > How about updating this page to show the correct code styling? And > have it as a policy that all new contributors must read before gaining > access? (And of course, strongly encouraging current contributors

Re: [E-devel] EFL coding style

2010-03-24 Thread Tom Haste
http://trac.enlightenment.org/e/wiki/ECoding How about updating this page to show the correct code styling? And have it as a policy that all new contributors must read before gaining access? (And of course, strongly encouraging current contributors to read it) Heres what the Gnomers have http://d

Re: [E-devel] EFL coding style

2010-03-24 Thread Gustavo Sverzut Barbieri
On Wed, Mar 24, 2010 at 8:01 AM, Tom Hacohen wrote: > On Wed, Mar 24, 2010 at 1:23 AM, André Dieb wrote: > >> Ressurecting this discussion... any new thoughts? >> >> Having a sane and consistent coding style is very important, it annoyed me > quite often when I worked with e's code. > There are t

Re: [E-devel] EFL coding style

2010-03-24 Thread Tom Hacohen
On Wed, Mar 24, 2010 at 1:23 AM, André Dieb wrote: > Ressurecting this discussion... any new thoughts? > > Having a sane and consistent coding style is very important, it annoyed me quite often when I worked with e's code. There are two important things needed to be done: 1. Having a simple and c

Re: [E-devel] EFL coding style

2010-03-23 Thread The Rasterman
On Tue, 23 Mar 2010 20:23:05 -0300 André Dieb said: none - other than this actually being done. :) > Ressurecting this discussion... any new thoughts? > > On Thu, Sep 3, 2009 at 9:20 PM, Carsten Haitzler wrote: > > > On Thu, 3 Sep 2009 18:54:40 -0300 Iván Briano (Sachiel) < > > sachi...@gmail.

Re: [E-devel] EFL coding style

2010-03-23 Thread André Dieb
Ressurecting this discussion... any new thoughts? On Thu, Sep 3, 2009 at 9:20 PM, Carsten Haitzler wrote: > On Thu, 3 Sep 2009 18:54:40 -0300 Iván Briano (Sachiel) < > sachi...@gmail.com> > said: > > > On Thu, Sep 3, 2009 at 6:25 PM, Carsten Haitzler > wrote: > > > On Thu, 3 Sep 2009 10:07:54 -03

Re: [E-devel] EFL coding style

2009-09-04 Thread The Rasterman
On Thu, 3 Sep 2009 18:54:40 -0300 Iván Briano (Sachiel) said: > On Thu, Sep 3, 2009 at 6:25 PM, Carsten Haitzler wrote: > > On Thu, 3 Sep 2009 10:07:54 -0300 Iván Briano (Sachiel) > > said: > > > >> On Wed, Sep 2, 2009 at 9:43 PM, Carsten Haitzler > >> wrote: > >> > On Sun, 30 Aug 2009 07:40:47

Re: [E-devel] EFL coding style

2009-09-03 Thread Sachiel
On Thu, Sep 3, 2009 at 6:25 PM, Carsten Haitzler wrote: > On Thu, 3 Sep 2009 10:07:54 -0300 Iván Briano (Sachiel) > said: > >> On Wed, Sep 2, 2009 at 9:43 PM, Carsten Haitzler wrote: >> > On Sun, 30 Aug 2009 07:40:47 +0200 (CEST) Vincent Torri >> > said: >> > >> > hmm i disagree with some of the

Re: [E-devel] EFL coding style

2009-09-03 Thread The Rasterman
On Thu, 3 Sep 2009 10:07:54 -0300 Iván Briano (Sachiel) said: > On Wed, Sep 2, 2009 at 9:43 PM, Carsten Haitzler wrote: > > On Sun, 30 Aug 2009 07:40:47 +0200 (CEST) Vincent Torri > > said: > > > > hmm i disagree with some of the doc. specifically > > > > blah > > { > >   xx; > > } > > > > i hav

Re: [E-devel] EFL coding style

2009-09-03 Thread Sachiel
On Wed, Sep 2, 2009 at 9:43 PM, Carsten Haitzler wrote: > On Sun, 30 Aug 2009 07:40:47 +0200 (CEST) Vincent Torri > said: > > hmm i disagree with some of the doc. specifically > > blah > { >   xx; > } > > i have always had/used: > blah >  { >   xx; >  } > > ie {}'s are indented a bit. > > but... w

Re: [E-devel] EFL coding style

2009-09-03 Thread The Rasterman
On Sun, 30 Aug 2009 07:40:47 +0200 (CEST) Vincent Torri said: hmm i disagree with some of the doc. specifically blah { xx; } i have always had/used: blah { xx; } ie {}'s are indented a bit. but... we can argue over little things all day long. imho the ONLY way this will work is if we

Re: [E-devel] EFL coding style

2009-09-01 Thread David Seikel
On Tue, 1 Sep 2009 18:47:45 -0500 Nick Hughart wrote: > On Wed, 2 Sep 2009 14:34:03 +1000 > David Seikel wrote: > > > On Tue, 01 Sep 2009 23:19:37 -0400 Christopher Michael > > wrote: > > > > > Nick Hughart wrote: > > > > On Tue, 1 Sep 2009 20:03:18 +0530 > > > > Noorul Islam wrote: > > > >

Re: [E-devel] EFL coding style

2009-09-01 Thread Nick Hughart
On Wed, 2 Sep 2009 14:34:03 +1000 David Seikel wrote: > On Tue, 01 Sep 2009 23:19:37 -0400 Christopher Michael > wrote: > > > Nick Hughart wrote: > > > On Tue, 1 Sep 2009 20:03:18 +0530 > > > Noorul Islam wrote: > > > > > >> On Mon, Aug 31, 2009 at 6:31 PM, Vincent > > >> Torri wrote: > > >>>

Re: [E-devel] EFL coding style

2009-09-01 Thread Nick Hughart
On Tue, 01 Sep 2009 23:19:37 -0400 Christopher Michael wrote: > Nick Hughart wrote: > > On Tue, 1 Sep 2009 20:03:18 +0530 > > Noorul Islam wrote: > > > >> On Mon, Aug 31, 2009 at 6:31 PM, Vincent Torri > >> wrote: > >>> ok, forget about that, core devs don't care at all about coding > >>> style

Re: [E-devel] EFL coding style

2009-09-01 Thread David Seikel
On Tue, 01 Sep 2009 23:19:37 -0400 Christopher Michael wrote: > Nick Hughart wrote: > > On Tue, 1 Sep 2009 20:03:18 +0530 > > Noorul Islam wrote: > > > >> On Mon, Aug 31, 2009 at 6:31 PM, Vincent Torri > >> wrote: > >>> ok, forget about that, core devs don't care at all about coding > >>> style

Re: [E-devel] EFL coding style

2009-09-01 Thread Christopher Michael
Nick Hughart wrote: > On Tue, 1 Sep 2009 20:03:18 +0530 > Noorul Islam wrote: > >> On Mon, Aug 31, 2009 at 6:31 PM, Vincent Torri >> wrote: >>> ok, forget about that, core devs don't care at all about coding >>> style >>> >>> thread closed >>> >> I think core developers are busy. I hope they will

Re: [E-devel] EFL coding style

2009-09-01 Thread Nick Hughart
On Tue, 1 Sep 2009 20:03:18 +0530 Noorul Islam wrote: > On Mon, Aug 31, 2009 at 6:31 PM, Vincent Torri > wrote: > > > > ok, forget about that, core devs don't care at all about coding > > style > > > > thread closed > > > > I think core developers are busy. I hope they will reply soon. > I wou

Re: [E-devel] EFL coding style

2009-09-01 Thread Noorul Islam
On Mon, Aug 31, 2009 at 6:31 PM, Vincent Torri wrote: > > ok, forget about that, core devs don't care at all about coding style > > thread closed > I think core developers are busy. I hope they will reply soon. Thanks Noorul ---

Re: [E-devel] EFL coding style

2009-08-31 Thread Vincent Torri
ok, forget about that, core devs don't care at all about coding style thread closed Vincent On Sun, 30 Aug 2009, Nathan Ingersoll wrote: Hi Vincent, The Google C++ style guide has a requirement that I would suggest considering. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xm

Re: [E-devel] EFL coding style

2009-08-30 Thread Nathan Ingersoll
Hi Vincent, The Google C++ style guide has a requirement that I would suggest considering. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Calls The specific suggestion is that we provide guidance on how to wrap function definitions and calls that don't fit well on a sin

[E-devel] EFL coding style

2009-08-29 Thread Vincent Torri
Hey, I think that we all agree that the current mix of whitespace and tabulation in most of the source code is not that very nice. Also, the libraries are often using the coding style of the original author, hence we have several different coding style in different libraries (eina being even