[FFmpeg-devel] [PATCH v2] libavformat/tls_mbedtls: Changes the return code handling of mbedtls_x509_crt_parse_file

2024-07-24 Thread Mohit Gupta
mbedtls_x509_crt_parse_file returns an error with negative numbers, and positive numbers indicate the number of failed certificates to load from certificate specific issues, such as critical extensions. This would fix ticket #11079. Signed-off-by: Mohit Gupta --- libavformat/tls_mbedtls.c |

Re: [FFmpeg-devel] [PATCH 27/39] lavc/ffv1: change FFV1SliceContext.plane into a RefStruct object

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:42PM +0200, Anton Khirnov wrote: > Frame threading in the FFV1 decoder works in a very unusual way - the > state that needs to be propagated from the previous frame is not decoded > pixels(¹), but each slice's entropy coder state after decoding the slice. > > For

Re: [FFmpeg-devel] [PATCH 26/39] lavc/ffv1dec: inline copy_fields() into update_thread_context()

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:41PM +0200, Anton Khirnov wrote: > It is now only called from a single place, so there is no point in it > being a separate function. > --- > libavcodec/ffv1dec.c | 38 -- > 1 file changed, 16 insertions(+), 22 deletions(-) ok

Re: [FFmpeg-devel] [PATCH 25/39] lavc/ffv1dec: stop using per-slice FFV1Context

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:40PM +0200, Anton Khirnov wrote: > All remaining accesses to them are for fields that have the same value > in the main encoder context. > > Drop now-unused FFV1Context.slice_contexts. > --- > libavcodec/ffv1.c | 18 +++- > libavcodec/ffv1.h

Re: [FFmpeg-devel] [PATCH 24/39] lavc/ffv1dec: move slice_damaged to per-slice context

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:39PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1.h| 2 +- > libavcodec/ffv1dec.c | 18 -- > 2 files changed, 9 insertions(+), 11 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 23/39] lavc/ffv1dec: move slice_reset_contexts to per-slice context

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:38PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1.h| 16 +--- > libavcodec/ffv1dec.c | 4 ++-- > 2 files changed, 15 insertions(+), 5 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I

Re: [FFmpeg-devel] [PATCH 22/39] lavc/ffv1enc: stop using per-slice FFV1Context

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:37PM +0200, Anton Khirnov wrote: > All remaining accesses to them are for fields that have the same value > in the main encoder context. > --- > libavcodec/ffv1enc.c | 57 --- > libavcodec/ffv1enc_template.c | 24

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-24 Thread Rémi Denis-Courmont
Le keskiviikkona 24. heinäkuuta 2024, 16.08.17 EEST Michael Niedermayer a écrit : > The question is not if its "warning-worthy", the question is what action > creates the best FFmpeg. And also an enviroment we are all happy to work in. That is complete nonsense. It is more obvious than patently

Re: [FFmpeg-devel] [PATCH 21/39] lavc/ffv1: move ac_byte_count to per-slice context

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:36PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1.h| 2 +- > libavcodec/ffv1dec.c | 6 +++--- > libavcodec/ffv1enc.c | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 20/39] lavc/ffv1enc: store per-slice rc_stat(2?) in FFV1SliceContext

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:35PM +0200, Anton Khirnov wrote: > Instead of the per-slice FFV1Context, which will be removed in future > commits. > --- > libavcodec/ffv1.c | 6 ++ > libavcodec/ffv1.h | 3 +++ > libavcodec/ffv1enc.c | 20 ++--

Re: [FFmpeg-devel] [PATCH 19/39] lavc/ffv1: move RangeCoder to per-slice context

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:34PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1.c | 9 ++-- > libavcodec/ffv1.h | 5 +-- > libavcodec/ffv1dec.c | 72 > libavcodec/ffv1dec_template.c | 2 +- > libavcodec/ffv1enc.c

Re: [FFmpeg-devel] [PATCH 17/39] lavc/ffv1: always use the main context values of ac

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:32PM +0200, Anton Khirnov wrote: > It cannot change between slices. that is true currently but considering that its used in some of the inner loops i dont think carrying an additional pointer around into these loops makes sense either leave it or move the ac value to

Re: [FFmpeg-devel] [PATCH 16/39] lavc/ffv1: move FFV1Context.slice_{coding_mode, rct_.y_coef} to per-slice context

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:31PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1.h | 6 +++--- > libavcodec/ffv1dec.c | 14 +++--- > libavcodec/ffv1dec_template.c | 10 +- > libavcodec/ffv1enc.c | 26 +- >

Re: [FFmpeg-devel] [PATCH 15/39] lavc/ffv1: always use the main context values of plane_count/transparency

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:30PM +0200, Anton Khirnov wrote: > They cannot change between slices. > --- > libavcodec/ffv1.c | 2 -- > libavcodec/ffv1dec.c | 5 ++--- > libavcodec/ffv1dec_template.c | 2 +- > libavcodec/ffv1enc.c | 2 +- >

Re: [FFmpeg-devel] [PATCH 14/39] lavc/ffv1: drop write-only PlaneContext.interlace_bit_state

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:29PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1.c | 3 --- > libavcodec/ffv1.h | 1 - > 2 files changed, 4 deletions(-) ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities

Re: [FFmpeg-devel] [PATCH 11/39] lavc/ffv1enc: move bit writer to per-slice context

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:26PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1.h | 3 ++- > libavcodec/ffv1enc.c | 7 --- > libavcodec/ffv1enc_template.c | 14 +++--- > 3 files changed, 13 insertions(+), 11 deletions(-) LGTM thx [...] -- Michael

Re: [FFmpeg-devel] [PATCH 08/39] lavc/ffv1: move sample_buffer to the per-slice context

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:23PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1.c | 35 --- > libavcodec/ffv1.h | 5 +++-- > libavcodec/ffv1dec.c | 27 +-- > libavcodec/ffv1dec_template.c | 9

Re: [FFmpeg-devel] [PATCH 07/39] lavc/ffv1: add a per-slice context

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:22PM +0200, Anton Khirnov wrote: > FFV1 decoder and encoder currently use the same struct - FFV1Context - > both as codec private data and per-slice context. For this purpose > FFV1Context contains an array of pointers to per-slice FFV1Context > instances. > > This

Re: [FFmpeg-devel] [PATCH 06/39] lavc/ffv1dec: move copy_fields() under HAVE_THREADS

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:21PM +0200, Anton Khirnov wrote: > It is unused otherwise > --- > libavcodec/ffv1dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Frequently ignored answer#1

Re: [FFmpeg-devel] [PATCH 05/39] lavc/ffv1dec: drop a pointless variable in decode_slice()

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:20PM +0200, Anton Khirnov wrote: > fsdst is by construction always equal to fs, there is even an > av_assert1() checking that. Just use fs directly. > --- > libavcodec/ffv1dec.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) probably ok thx [...]

Re: [FFmpeg-devel] [PATCH 33/39] lavc: convert frame threading to the receive_frame() pattern

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:48PM +0200, Anton Khirnov wrote: > Reorganize the code such that the frame threading code does not call the > decoders directly, but instead calls back into the generic decoding > code. This avoids duplicating the logic that wraps the decoder > invocation and allows

Re: [FFmpeg-devel] [PATCH 04/39] lavc/ffv1dec: drop FFV1Context.cur

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:19PM +0200, Anton Khirnov wrote: > It is merely a pointer to FFV1Context.picture.f, which can just as well > be used directly. > --- > libavcodec/ffv1.h| 1 - > libavcodec/ffv1dec.c | 33 + > 2 files changed, 17 insertions(+), 17

Re: [FFmpeg-devel] [PATCH 03/39] lavc/ffv1dec: simplify slice index calculation

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:18PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1dec.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the

Re: [FFmpeg-devel] [PATCH 02/39] lavc/ffv1dec: declare loop variables in the loop where possible

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:17PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1dec.c | 45 ++-- > 1 file changed, 22 insertions(+), 23 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind

Re: [FFmpeg-devel] [PATCH 01/39] tests/fate/vcodec: add vsynth tests for FFV1 version 2

2024-07-24 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 07:11:16PM +0200, Anton Khirnov wrote: > --- > tests/fate/vcodec.mak| 3 ++- > tests/ref/vsynth/vsynth1-ffv1-v2 | 4 > tests/ref/vsynth/vsynth2-ffv1-v2 | 4 > tests/ref/vsynth/vsynth3-ffv1-v2 | 4 >

[FFmpeg-devel] [PATCH] lavfi/framesync: avoid forcing frame writability unnecessarily

2024-07-24 Thread Anton Khirnov
Callers of ff_framesync_get_frame() generally do not expect the result to be writable, those that do (e.g. ff_framesync_dualinput_get_writable()) ensure writability themselves. Significantly reduces memory consumption in complex graphs with framesync-based filters (e.g. scale, ssim).

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-24 Thread Michael Niedermayer
On Wed, Jul 24, 2024 at 06:49:04AM +0200, Marvin Scholz (ePirat) wrote: > > > On 24. Jul 2024, at 00:10, Michael Niedermayer > > wrote: > > > > On Tue, Jul 23, 2024 at 12:17:43PM -0300, James Almer wrote: > >>> On 7/19/2024 12:31 PM, Paul B Mahol wrote: > >>> Internal/private filter

Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if no video device is present

2024-07-24 Thread Michael Niedermayer
On Wed, Jul 24, 2024 at 07:09:45AM +, patches via ffmpeg-devel wrote: > > > -Original Message- > From: Michael Niedermayer > Sent: Tuesday, July 23, 2024 10:22 PM > To: FFmpeg development discussions and patches > Cc: patches > Subject: Re: [FFmpeg-devel

Re: [FFmpeg-devel] [PATCH] checkasm: Increase the tolerance for ac3_sum_square_butterfly_float

2024-07-24 Thread Martin Storsjö
On Tue, 23 Jul 2024, Michael Niedermayer wrote: On Wed, Jul 24, 2024 at 12:01:32AM +0300, Martin Storsjö via ffmpeg-devel wrote: Increase the tolerance from 10 ulp to 11 ulp. This fixes occasional errors for some inputs; the errors could be reproduced on aarch64/neon builds, with "checkasm

Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if no video device is present

2024-07-24 Thread patches via ffmpeg-devel
-Original Message- From: Michael Niedermayer Sent: Tuesday, July 23, 2024 10:22 PM To: FFmpeg development discussions and patches Cc: patches Subject: Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if no video device is present On Tue, Jul 23, 2024 at 08:21

[FFmpeg-devel] [PATCH] avcodec/adpcm: only process right samples when decoding stereo

2024-07-24 Thread Peter Ross
Fixes Coverity issue #1610760. --- libavcodec/adpcm.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index afdbeaa15e..58f2ef0dfb 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1684,22 +1684,24 @@ static int

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-23 Thread Marvin Scholz (ePirat)
> On 24. Jul 2024, at 00:10, Michael Niedermayer wrote: > > On Tue, Jul 23, 2024 at 12:17:43PM -0300, James Almer wrote: >>> On 7/19/2024 12:31 PM, Paul B Mahol wrote: >>> Internal/private filter structures/API changes does not need be mentioned >>> in that file, isn't that fact obvious even

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-23 Thread Michael Niedermayer
On Wed, Jul 24, 2024 at 12:10:08AM +0200, Michael Niedermayer wrote: [...] > Adding a "threat" in the form of a warning maybe works for some people in > some cases. But in others its more like slapping an already angry guy in the > face. > You get slapped harder back then have to punch and get

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-23 Thread Michael Niedermayer
On Tue, Jul 23, 2024 at 12:17:43PM -0300, James Almer wrote: > On 7/19/2024 12:31 PM, Paul B Mahol wrote: > > Internal/private filter structures/API changes does not need be mentioned > > in that file, isn't that fact obvious even for average Joe? > > There's no reason to be condescending or

Re: [FFmpeg-devel] [PATCH] avcodec/amf_enc: av1 cropping support

2024-07-23 Thread James Almer
On 7/23/2024 6:53 PM, Araz Iusubov wrote: --- libavcodec/amfenc_av1.c | 82 - 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index d40c71cb33..27599b9fbe 100644 ---

[FFmpeg-devel] [PATCH] avcodec/amf_enc: av1 cropping support

2024-07-23 Thread Araz Iusubov
--- libavcodec/amfenc_av1.c | 82 - 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index d40c71cb33..27599b9fbe 100644 --- a/libavcodec/amfenc_av1.c +++ b/libavcodec/amfenc_av1.c @@ -22,6

Re: [FFmpeg-devel] [PATCH] checkasm: Increase the tolerance for ac3_sum_square_butterfly_float

2024-07-23 Thread Michael Niedermayer
On Wed, Jul 24, 2024 at 12:01:32AM +0300, Martin Storsjö via ffmpeg-devel wrote: > Increase the tolerance from 10 ulp to 11 ulp. This fixes occasional > errors for some inputs; the errors could be reproduced on > aarch64/neon builds, with "checkasm --test=ac3dsp 3446175925". > --- >

Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice()

2024-07-23 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-07-23 22:14:19) > On Tue, Jul 23, 2024 at 08:52:58AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-07-22 23:14:04) > > > On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > > > > There is no reason to delay it and this is a more

[FFmpeg-devel] [PATCH] checkasm: Increase the tolerance for ac3_sum_square_butterfly_float

2024-07-23 Thread Martin Storsjö via ffmpeg-devel
Increase the tolerance from 10 ulp to 11 ulp. This fixes occasional errors for some inputs; the errors could be reproduced on aarch64/neon builds, with "checkasm --test=ac3dsp 3446175925". --- tests/checkasm/ac3dsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if no video device is present

2024-07-23 Thread Michael Niedermayer
On Tue, Jul 23, 2024 at 08:21:31AM +, patches via ffmpeg-devel wrote: > > -Original Message- > From: Roger Pack > Sent: Monday, July 22, 2024 5:52 PM > To: patches > Cc: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] avdev

Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice()

2024-07-23 Thread Michael Niedermayer
On Tue, Jul 23, 2024 at 08:52:58AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-22 23:14:04) > > On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > > > There is no reason to delay it and this is a more natural place for > > > this code. > > > > There is a

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-23 Thread Ronald S. Bultje
Hi Paul, On Tue, Jul 23, 2024 at 5:31 PM Paul B Mahol wrote: > Also you are extremely selective and biased in your judging. > If you believe there's anything we missed, please forward relevant communication (emails or IRC logs) to us and we will have a look. I'm not online 24/7 so I certainly

[FFmpeg-devel] [PATCH 3/3] avcodec/vvc/dsp: prefix TxType and TxSize with VVC

2024-07-23 Thread toqsxw
From: Wu Jianhua See https://github.com/ffvvc/FFmpeg/issues/180 Signed-off-by: Wu Jianhua --- libavcodec/vvc/dsp.h | 28 ++-- libavcodec/vvc/dsp_template.c | 2 +- libavcodec/vvc/intra.c| 26 +- 3 files changed, 28

[FFmpeg-devel] [PATCH 2/3] avcodec/vvc/cabac: remove vvc_refill2

2024-07-23 Thread toqsxw
From: Wu Jianhua See https://github.com/ffvvc/FFmpeg/issues/178 Signed-off-by: Wu Jianhua --- libavcodec/vvc/cabac.c | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/libavcodec/vvc/cabac.c b/libavcodec/vvc/cabac.c index 0d45eec751..c9b6f9bf3e

[FFmpeg-devel] [PATCH 1/3] avcodec/vvc_parser: move avctx->has_b_frames initialization to dec

2024-07-23 Thread toqsxw
From: Wu Jianhua >From Jun Zhao : > Should we relocate this to the decoder? Other codecs typically set this > parameter in the decoder. Signed-off-by: Wu Jianhua --- libavcodec/vvc/dec.c| 1 + libavcodec/vvc_parser.c | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 01/11] avcodec/alsdec: Clear shift_value

2024-07-23 Thread Michael Niedermayer
On Sat, Jul 20, 2024 at 02:52:31AM +0200, Michael Niedermayer wrote: > (the exact issue is unreproducable but the use of uninitialized data is > reproducable) > > Should fix: signed integer overflow: -2147483648 - 127 cannot be represented > in type 'int' > Should fix: >

Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc/hevcdec: Do not allow slices to depend on failed slices

2024-07-23 Thread Michael Niedermayer
On Sat, Jul 20, 2024 at 08:11:02AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-20 02:08:28) > > On Wed, Jul 17, 2024 at 08:42:41AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-07-15 16:48:25) > > [...] > > > > @@ -3155,8 +3156,11 @@ static int

Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc/hevcdec: Do not allow slices to depend on failed slices

2024-07-23 Thread Michael Niedermayer
On Wed, Jul 17, 2024 at 08:42:41AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-15 16:48:25) > > An alternative would be to leave the context unchanged on failure of > > hls_slice_header() > > > > Fixes: out of array access > > Fixes: NULL pointer dereference > > Fixes: >

Re: [FFmpeg-devel] [PATCH 8/9] avformat/udp: Fix temporary buffer race

2024-07-23 Thread Michael Niedermayer
On Tue, Jul 09, 2024 at 03:12:52PM +0200, Michael Niedermayer wrote: > On Mon, Jul 08, 2024 at 07:46:19PM +0200, Marton Balint wrote: > > > > > > On Sun, 9 Jun 2024, Michael Niedermayer wrote: > > > > > Fixes: CID1551679 Data race condition > > > Fixes: CID1551687 Data race condition > > > >

Re: [FFmpeg-devel] [PATCH] avformat/mov: sanity check count in IPRP

2024-07-23 Thread Michael Niedermayer
On Tue, Jul 16, 2024 at 10:31:54AM -0300, James Almer wrote: > On 7/16/2024 10:19 AM, Michael Niedermayer wrote: > > Fixes: Timeout > > Fixes: > > 69230/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6540512101203968 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-23 Thread James Almer
On 7/23/2024 1:24 PM, Paul B Mahol wrote: On Tue, Jul 23, 2024 at 6:17 PM Paul B Mahol wrote: On Tue, Jul 23, 2024 at 5:17 PM James Almer wrote: On 7/19/2024 12:31 PM, Paul B Mahol wrote: Internal/private filter structures/API changes does not need be mentioned in that file, isn't

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-23 Thread Paul B Mahol
On Tue, Jul 23, 2024 at 6:17 PM Paul B Mahol wrote: > > > On Tue, Jul 23, 2024 at 5:17 PM James Almer wrote: > >> On 7/19/2024 12:31 PM, Paul B Mahol wrote: >> > Internal/private filter structures/API changes does not need be >> mentioned >> > in that file, isn't that fact obvious even for

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-23 Thread Paul B Mahol
On Tue, Jul 23, 2024 at 5:17 PM James Almer wrote: > On 7/19/2024 12:31 PM, Paul B Mahol wrote: > > Internal/private filter structures/API changes does not need be mentioned > > in that file, isn't that fact obvious even for average Joe? > > There's no reason to be condescending or aggressive

[FFmpeg-devel] [PATCH] lavc/vp8dsp: fix RV32 stack alignment

2024-07-23 Thread Rémi Denis-Courmont
SP must be a multiple of 16 bytes at all times on POSIX - even in leaf functions - so that signal handlers have a properly aligned stack. --- libavcodec/riscv/vp8dsp_rvv.S | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/riscv/vp8dsp_rvv.S

Re: [FFmpeg-devel] [PATCH] aacdec: set ac->output_elements upon channel element free

2024-07-23 Thread Michael Niedermayer
On Mon, Jul 22, 2024 at 03:22:31AM +0200, Lynne via ffmpeg-devel wrote: > The issue is that ac->output_elements is populated from > ac->che, which may be freed, leaving dangling pointers in this > list. > > Should fix clusterfuzz. > --- > libavcodec/aac/aacdec.c | 1 + > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-23 Thread James Almer
On 7/19/2024 12:31 PM, Paul B Mahol wrote: Internal/private filter structures/API changes does not need be mentioned in that file, isn't that fact obvious even for average Joe? There's no reason to be condescending or aggressive over something so irrelevant. Is it so hard to just state the

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-23 Thread Stefan Oltmanns via ffmpeg-devel
This is the second part for loading the library at runtime, changes compared to previous patch revisions: -No atexit anymore -No global states anymore -Moved the registry read for Windows from a separate function inside the function to load the dynamic library and simplified it, reducing the

[FFmpeg-devel] [PATCH v3 1/2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-23 Thread Stefan Oltmanns via ffmpeg-devel
Hello, this is revised patch, this is the first part that just updates to the API v4 of VapourSynth. Changes in API v4: -All functions previously in header are now part of the "vssapi" object -Renames of different types and functions -YCoCg is not treated as different format to YUV anymore

[FFmpeg-devel] [PATCH v4] avfilter: fix data type for {Tile, Untile}Context's image size

2024-07-23 Thread Andrew Sayers
These are accessed as AV_OPT_TYPE_IMAGE_SIZE AVOptions, so must be implemented as (signed) int's --- libavfilter/vf_tile.c | 2 +- libavfilter/vf_untile.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_tile.c b/libavfilter/vf_tile.c index

[FFmpeg-devel] [PATCH] fftools/ffmpeg: prefer real errors over EOF in err_merge()

2024-07-23 Thread Anton Khirnov
Fixes an issue in 6.1 when reading a corrupted file with -xerror would exit with success. This specific issue is not present in master, but this should generally be a more robust behaviour. Reported-by: Andrej Peterka --- fftools/ffmpeg_utils.h | 5 +++-- 1 file changed, 3 insertions(+), 2

[FFmpeg-devel] [PATCH 4/4] swscale/aarch64/yuv2rgb: add neon yuv42{0, 2}p -> gbrp unscaled colorspace converters

2024-07-23 Thread Ramiro Polla
--- libswscale/aarch64/swscale_unscaled.c | 58 + libswscale/aarch64/yuv2rgb_neon.S | 73 ++- 2 files changed, 118 insertions(+), 13 deletions(-) diff --git a/libswscale/aarch64/swscale_unscaled.c b/libswscale/aarch64/swscale_unscaled.c index

[FFmpeg-devel] [PATCH 3/4] swscale/x86/yuv2rgb: add ssse3 yuv42{0, 2}p -> gbrp unscaled colorspace converters

2024-07-23 Thread Ramiro Polla
Note: this implementation is limited to x86_64 due to general purpose register pressure. --- libswscale/x86/yuv2rgb.c | 39 libswscale/x86/yuv_2_rgb.asm | 24 +- 2 files changed, 62 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 2/4] swscale/yuv2rgb: add yuv42{0, 2}p -> gbrp unscaled colorspace converters

2024-07-23 Thread Ramiro Polla
--- libswscale/yuv2rgb.c| 16 ++ tests/checkasm/sw_yuv2rgb.c | 60 +++-- 2 files changed, 60 insertions(+), 16 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index c283d6d1bd..3a41c4eba6 100644 --- a/libswscale/yuv2rgb.c +++

[FFmpeg-devel] [PATCH 1/4] swscale/yuv2rgb: prepare YUV2RGBFUNC macro for multi-planar rgb

2024-07-23 Thread Ramiro Polla
This will be used in the upcoming yuv42{0,2}p -> gbrp unscaled colorspace converters. --- libswscale/yuv2rgb.c | 279 ++- 1 file changed, 142 insertions(+), 137 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index

Re: [FFmpeg-devel] [PATCH 2/2] aarch64: vvc: Consistently use # for immediate constants

2024-07-23 Thread Zhao Zhili
> On Jul 23, 2024, at 19:28, Martin Storsjö wrote: > > --- > libavcodec/aarch64/vvc/alf.S | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/aarch64/vvc/alf.S b/libavcodec/aarch64/vvc/alf.S > index 828031cb90..eec193302a 100644 > ---

[FFmpeg-devel] [PATCH 2/2] aarch64: vvc: Consistently use # for immediate constants

2024-07-23 Thread Martin Storsjö
--- libavcodec/aarch64/vvc/alf.S | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/aarch64/vvc/alf.S b/libavcodec/aarch64/vvc/alf.S index 828031cb90..eec193302a 100644 --- a/libavcodec/aarch64/vvc/alf.S +++ b/libavcodec/aarch64/vvc/alf.S @@ -95,7 +95,7 @@

[FFmpeg-devel] [PATCH 1/2] aarch64: vvc: Fix compilation of alf.S with MSVC 2022 17.7 and older

2024-07-23 Thread Martin Storsjö
Use the "ldur" instruction explicitly, instead of having the assembler implicitly convert "ldr" instructions to "ldur". This fixes build errors like these: libavcodec\aarch64\vvc\alf.o.asm(1023) : error A2518: operand 2: Memory offset must be aligned ldr q22, [x3, #24]

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: drop HEVC cropping from start_frame rather than end_frame

2024-07-23 Thread epirat07
On 23 Jul 2024, at 9:36, Anton Khirnov wrote: > HEVCContext.output_frame will be removed in following commits. > > Reported-By: Max Bykov > --- > Untested, testing welcome. Tested with fate-hevc-conformance-CONFWIN_A_Sony_1 and works. LGTM > > Cf. '[PATCH 37/39] lavc/hevcdec: use a

[FFmpeg-devel] [PATCH] lavc/exr: decode_block() fails when input resolution not exactly divisable by 8

2024-07-23 Thread Sean Devonport
This stops decode_block() from failing when the .exr resolution is not divisable by 8 (e.g 108x192). The dc_w and dc_h needs to be round up and not down. Signed-off-by: Sean Devonport mailto:tonetechnic...@gmail.com>> --- libavcodec/exr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix build with older SDKs

2024-07-23 Thread Marvin Scholz
The previous fix was not sufficient. To make things easier to reason about, split the function and add the guards there instead of complicating the call site more. --- libavutil/hwcontext_videotoolbox.c | 51 +++--- 1 file changed, 39 insertions(+), 12 deletions(-) diff

Re: [FFmpeg-devel] [PATCH v4 4/4] lavc/vp9dsp: R-V V mc tap hv

2024-07-23 Thread flow gg
Because of the 3/4 update, updated it." 于2024年7月23日周二 16:59写道: > From: sunyuechi > > C908 X60 > vp9_avg_8tap_smooth_4hv_8bpp_c : 32.0 28.0 > vp9_avg_8tap_smooth_4hv_8bpp_rvv_i32 : 15.0 13.2 >

[FFmpeg-devel] [PATCH v4 4/4] lavc/vp9dsp: R-V V mc tap hv

2024-07-23 Thread uk7b
From: sunyuechi C908 X60 vp9_avg_8tap_smooth_4hv_8bpp_c : 32.0 28.0 vp9_avg_8tap_smooth_4hv_8bpp_rvv_i32 : 15.0 13.2 vp9_avg_8tap_smooth_8hv_8bpp_c : 98.0 86.2

Re: [FFmpeg-devel] [PATCH v4 3/4] lavc/vp9dsp: R-V V mc tap h v

2024-07-23 Thread flow gg
> TBH it is very hard to review this due to the large extents of code > conditionals. This should avoidable at least partly. You can name macros for > each filter and then expand those macros instead of using if's. Do you mean that before the addition of .equ ff_vp9_subpel_filters_xxx,

[FFmpeg-devel] [PATCH v4 3/4] lavc/vp9dsp: R-V V mc tap h v

2024-07-23 Thread uk7b
From: sunyuechi C908 X60 vp9_avg_8tap_smooth_4h_8bpp_c : 12.7 11.2 vp9_avg_8tap_smooth_4h_8bpp_rvv_i32:4.74.2 vp9_avg_8tap_smooth_4v_8bpp_c : 29.7 12.5

Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if no video device is present

2024-07-23 Thread patches via ffmpeg-devel
-Original Message- From: Roger Pack Sent: Monday, July 22, 2024 5:52 PM To: patches Cc: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if no video device is present On Wed, Jul 17, 2024 at 1:43 AM patches

Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if no video device is present

2024-07-23 Thread patches via ffmpeg-devel
-Original Message- From: Roger Pack Sent: Monday, July 22, 2024 5:52 PM To: patches Cc: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if no video device is present On Wed, Jul 17, 2024 at 1:43 AM patches

[FFmpeg-devel] [PATCH] lavc/videotoolbox: drop HEVC cropping from start_frame rather than end_frame

2024-07-23 Thread Anton Khirnov
HEVCContext.output_frame will be removed in following commits. Reported-By: Max Bykov --- Untested, testing welcome. Cf. '[PATCH 37/39] lavc/hevcdec: use a ContainerFifo to hold frames scheduled for output' currently on ML. --- libavcodec/videotoolbox.c | 13 - 1 file changed, 8

Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice()

2024-07-23 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-07-22 23:14:04) > On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > > There is no reason to delay it and this is a more natural place for > > this code. > > There is a reason. > By doing it later the surrounding pixels are available and one could >

[FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: Derive bind flag from frame type if no valid surface

2024-07-22 Thread fei . w . wang-at-intel . com
From: Fei Wang Fix cmd: ffmpeg.exe -init_hw_device d3d11va=d3d -init_hw_device qsv=qsv@d3d \ -filter_hw_device d3d -hwaccel qsv -hwaccel_output_format qsv \ -i in.h264 -vf "hwmap,format=d3d11,hwdownload,format=nv12" -y out.yuv Signed-off-by: Fei Wang --- libavutil/hwcontext_qsv.c | 7

Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-22 Thread Stefan Oltmanns via ffmpeg-devel
Am 22.07.24 um 08:57 schrieb Anton Khirnov: Quoting Stefan Oltmanns (2024-07-18 14:12:42) Hello Anton, can you eloborate on that? What is unacceptable with my patch that is perfectly fine in the AviSynth input module? It's the very same concept. It's not perfectly fine in avisynth, I dislike

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI

2024-07-22 Thread Timo Rothenpieler
On 23/07/2024 01:01, Josh Allmann wrote: On Tue, 9 Jul 2024 at 12:06, Josh Allmann wrote: Encoders may emit a buffering period SEI without a corresponding SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. During Annex B conversion, this may result in the SPS/PPS being inserted

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI

2024-07-22 Thread Josh Allmann
On Tue, 9 Jul 2024 at 12:06, Josh Allmann wrote: > > Encoders may emit a buffering period SEI without a corresponding > SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. > > During Annex B conversion, this may result in the SPS/PPS being > inserted *after* the buffering period SEI but

Re: [FFmpeg-devel] [PATCH] avformat/avio: avio_tell() only errors if the context is NULL

2024-07-22 Thread Michael Niedermayer
On Wed, Jul 17, 2024 at 08:47:45AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-11 11:49:37) > > Found by code review related to coverity > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/avio.h | 2 +- > > 1 file

Re: [FFmpeg-devel] [PATCH 2/2] web: move 4.1 to olddownloads

2024-07-22 Thread Michael Niedermayer
On Mon, Jul 22, 2024 at 06:13:43PM -0300, James Almer wrote: > On 7/21/2024 10:50 AM, Michael Niedermayer wrote: > > No distros are listed on downstreams that are not EOL that use 4.1 > > --- > > src/download| 37 - > > src/olddownload | 37

Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice()

2024-07-22 Thread Michael Niedermayer
On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > There is no reason to delay it and this is a more natural place for > this code. There is a reason. By doing it later the surrounding pixels are available and one could compute motion vectors from these surroundings and use all

Re: [FFmpeg-devel] [PATCH 2/2] web: move 4.1 to olddownloads

2024-07-22 Thread James Almer
On 7/21/2024 10:50 AM, Michael Niedermayer wrote: No distros are listed on downstreams that are not EOL that use 4.1 --- src/download| 37 - src/olddownload | 37 + 2 files changed, 37 insertions(+), 37 deletions(-)

Re: [FFmpeg-devel] [PATCH 1/2] web: move 6.0 to olddownloads

2024-07-22 Thread James Almer
On 7/21/2024 10:50 AM, Michael Niedermayer wrote: Only ubuntu 23.10 uses 6.0 according to downstreams and that is EOL in a few days also 23.10 users will probably upgrade to 24.04 LTS so shouldnt affect anyone --- src/download| 36 src/olddownload |

[FFmpeg-devel] [PATCH 8/8] checkasm/riscv: align the landing pads

2024-07-22 Thread Rémi Denis-Courmont
--- tests/checkasm/riscv/checkasm.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/checkasm/riscv/checkasm.S b/tests/checkasm/riscv/checkasm.S index 835cc7d315..e8bcbb271e 100644 --- a/tests/checkasm/riscv/checkasm.S +++ b/tests/checkasm/riscv/checkasm.S @@ -75,6 +75,8 @@ func

[FFmpeg-devel] [PATCH 7/8] lavu/riscv: align functions to 4 bytes

2024-07-22 Thread Rémi Denis-Courmont
Currently the start of the byte range for each function is aligned to 4 bytes. But this can lead to situations whence the function is preceded by a 2-byte C.NOP at the aligned 4-byte boundary. Then the first actual instruction and the function symbol are only aligned on 2 bytes. This forcefully

[FFmpeg-devel] [PATCH 6/6] checkasm/riscv: add forward-edge CFI landing pads

2024-07-22 Thread Rémi Denis-Courmont
--- tests/checkasm/riscv/checkasm.S | 4 1 file changed, 4 insertions(+) diff --git a/tests/checkasm/riscv/checkasm.S b/tests/checkasm/riscv/checkasm.S index 73ca85f344..835cc7d315 100644 --- a/tests/checkasm/riscv/checkasm.S +++ b/tests/checkasm/riscv/checkasm.S @@ -49,6 +49,7 @@

[FFmpeg-devel] [PATCH 5/6] sws/riscv: add forward-edge CFI landing pads

2024-07-22 Thread Rémi Denis-Courmont
--- libswscale/riscv/input_rvv.S | 12 libswscale/riscv/range_rvv.S | 4 libswscale/riscv/rgb2rgb_rvb.S | 1 + libswscale/riscv/rgb2rgb_rvv.S | 7 +++ 4 files changed, 24 insertions(+) diff --git a/libswscale/riscv/input_rvv.S b/libswscale/riscv/input_rvv.S index

[FFmpeg-devel] [PATCH 4/6] lavfi/riscv: add forward-edge CFI landing pads

2024-07-22 Thread Rémi Denis-Courmont
--- libavfilter/riscv/af_afir_rvv.S | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/riscv/af_afir_rvv.S b/libavfilter/riscv/af_afir_rvv.S index 04ec2e50d8..2d2b8b1ed3 100644 --- a/libavfilter/riscv/af_afir_rvv.S +++ b/libavfilter/riscv/af_afir_rvv.S @@ -22,6 +22,7 @@ // void

[FFmpeg-devel] [PATCH 3/6] lavc/riscv: add forward-edge CFI landing pads

2024-07-22 Thread Rémi Denis-Courmont
--- libavcodec/riscv/aacencdsp_rvv.S | 2 ++ libavcodec/riscv/aacpsdsp_rvv.S| 5 + libavcodec/riscv/ac3dsp_rvb.S | 2 ++ libavcodec/riscv/ac3dsp_rvv.S | 4 libavcodec/riscv/ac3dsp_rvvb.S | 1 + libavcodec/riscv/alacdsp_rvv.S | 3 +++

[FFmpeg-devel] [PATCH 2/6] lavu/riscv: add forward-edge CFI landing pads

2024-07-22 Thread Rémi Denis-Courmont
--- libavutil/riscv/fixed_dsp_rvv.S | 6 ++ libavutil/riscv/float_dsp_rvv.S | 12 libavutil/riscv/lls_rvv.S | 1 + 3 files changed, 19 insertions(+) diff --git a/libavutil/riscv/fixed_dsp_rvv.S b/libavutil/riscv/fixed_dsp_rvv.S index 6bac5813b8..7a872f7763 100644 ---

[FFmpeg-devel] [PATCH 1/6] lavu/riscv: assembly for zicfilp LPAD

2024-07-22 Thread Rémi Denis-Courmont
This instruction, if aligned on a 4-byte boundary, defines a valid target ("landing pad") for an indirect call or jump. Since this instruction is a HINT, it is safe to assemble even if not included in the target instruction set architecture. The necessary alignment is already provided by the

[FFmpeg-devel] [PATCH 9/9] lavc/h264dsp: use RISC-V B extension

2024-07-22 Thread Rémi Denis-Courmont
This saves one register and one instruction per transform. add16 and add16intra thus become stack-less. --- libavcodec/riscv/h264dsp_init.c | 25 libavcodec/riscv/h264idct_rvv.S | 51 - 2 files changed, 38 insertions(+), 38 deletions(-) diff --git

[FFmpeg-devel] [PATCH 8/9] lavu/riscv: add CPU flag for B bit manipulations

2024-07-22 Thread Rémi Denis-Courmont
The B extension was finally ratified in May 2024, encompassing: - Zba (addresses), - Zbb (basics) and - Zbs (single bits). It does not include Zbc (base-2 polynomials). --- doc/APIchanges| 3 +++ libavutil/cpu.c | 1 + libavutil/cpu.h | 1 +

[FFmpeg-devel] [PATCH 7/9] lavu/riscv: remove bespoke SH{1, 2, 3}ADD assembler

2024-07-22 Thread Rémi Denis-Courmont
configure checks that the assembler supports the B extension (or rather its constituents) anyway. These macros were dodging sanity checks for unsupported instructions and nothing else. --- libavutil/riscv/asm.S | 19 --- 1 file changed, 19 deletions(-) diff --git

[FFmpeg-devel] [PATCH 6/9] lavu/riscv: require B or zba explicitly

2024-07-22 Thread Rémi Denis-Courmont
--- libavutil/riscv/fixed_dsp_rvv.S | 14 +++--- libavutil/riscv/float_dsp_rvv.S | 24 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/libavutil/riscv/fixed_dsp_rvv.S b/libavutil/riscv/fixed_dsp_rvv.S index 6bac5813b8..0fa6aab3d4 100644 ---

[FFmpeg-devel] [PATCH 5/9] sws/riscv: require B or zba explicitly

2024-07-22 Thread Rémi Denis-Courmont
--- libswscale/riscv/input_rvv.S | 12 ++-- libswscale/riscv/range_rvv.S | 8 libswscale/riscv/rgb2rgb_rvb.S | 2 +- libswscale/riscv/rgb2rgb_rvv.S | 12 ++-- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/libswscale/riscv/input_rvv.S

  1   2   3   4   5   6   7   8   9   10   >