RE: [Flightgear-devel] Propeller animation speed fix

2002-05-03 Thread David Megginson
Jon Berndt writes: I was remembering first how the F-16 sim at Link was run at 25 Hz, which is of course 0.04 seconds. Wait ... (thinking, this time). Yes, that's right ;-) Then, I went to the numpad on my keyboard and hit 0.01 as I was typing in the dt for 100 Hz. Only I missed. On

RE: [Flightgear-devel] Propeller animation speed fix

2002-05-03 Thread Jon Berndt
? I don't see any harm in sticking with the integer value, but I agree that a better name, proper documentation, and some debugging is essential. This is true - particularly about documentation. Inline comments would help, too. I prefer (and we will continue to do this for JSBSim) that dt

RE: [Flightgear-devel] Propeller animation speed fix

2002-05-03 Thread Tony Peden
On Fri, 2002-05-03 at 04:20, Jon Berndt wrote: ? I don't see any harm in sticking with the integer value, but I agree that a better name, proper documentation, and some debugging is essential. This is true - particularly about documentation. Inline comments would help, too. I prefer

Re: [Flightgear-devel] Propeller animation speed fix

2002-05-03 Thread Christian Mayer
David Megginson wrote: Jon Berndt writes: I was remembering first how the F-16 sim at Link was run at 25 Hz, which is of course 0.04 seconds. Wait ... (thinking, this time). Yes, that's right ;-) Then, I went to the numpad on my keyboard and hit 0.01 as I was typing in the dt

Re: [Flightgear-devel] Propeller animation speed fix

2002-05-03 Thread Curtis L. Olson
I think I agree. When we go about fixing this up, I think we should pass a dt to the modules which would be in units = seconds and of type double. Regards, Curt. Christian Mayer writes: David Megginson wrote: Jon Berndt writes: I was remembering first how the F-16 sim at Link

Re: [Flightgear-devel] Propeller animation speed fix

2002-05-03 Thread Arnt Karlsen
On Thu, 2 May 2002 23:23:53 -0500, Jon Berndt [EMAIL PROTECTED] wrote in message [EMAIL PROTECTED]: This is ridiculous. dt is short for delta T. In a 100 Hz simulation, the corresponding dt is 0.04. For 120 Hz it's 0.00833. For people that do simulation for a living this is one of

Re: [Flightgear-devel] Propeller animation speed fix

2002-05-02 Thread Julian Foad
Andy, The original code assumed that dt was in milliseconds. The variable name velocity_rpms presumably stood for revs per millisecond. Your patch assumes that dt is in 1/120ths of a second. Is this linked to your frame rate? The meaning of dt needs to be consistent across the various

Re: [Flightgear-devel] Propeller animation speed fix

2002-05-02 Thread Andy Ross
Julian Foad wrote: The original code assumed that dt was in milliseconds. The variable name velocity_rpms presumably stood for revs per millisecond. Your patch assumes that dt is in 1/120ths of a second. I believe, although I am not authortative on this, that the dt parameter specifies an

Re: [Flightgear-devel] Propeller animation speed fix

2002-05-02 Thread David Megginson
Andy Ross writes: I believe, although I am not authortative on this, that the dt parameter specifies an integer number of iterations to perform, and not a time value per se. Under normal usage, dt will equal one. This is consistent with the multi_loop name it sometimes goes by. That

RE: [Flightgear-devel] Propeller animation speed fix

2002-05-02 Thread Jon Berndt
So, is dt recording elapse time or set to the current step time? If a sharp programmer like Andy is getting confused about what dt really is, then perhaps the variable should be called ms_elapsed or t_stepsize, etc.? This is ridiculous. dt is short for delta T. In a 100 Hz simulation, the

Re: [Flightgear-devel] Propeller animation speed fix

2002-05-02 Thread James A. Treacy
On Thu, May 02, 2002 at 10:22:22PM -0500, Jon Berndt wrote: So, is dt recording elapse time or set to the current step time? If a sharp programmer like Andy is getting confused about what dt really is, then perhaps the variable should be called ms_elapsed or t_stepsize, etc.? This is

RE: [Flightgear-devel] Propeller animation speed fix

2002-05-02 Thread Jon Berndt
This is ridiculous. dt is short for delta T. In a 100 Hz simulation, the corresponding dt is 0.04. For 120 Hz it's 0.00833. For people that do simulation for a living this is one of the *most* recognized parameters around. Jon almost assuredly meant dt = .01 for 100 Hz or dt = .04 for

[Flightgear-devel] Propeller animation speed fix

2002-04-30 Thread Andy Ross
Here's a patch to model.cxx that restores the proper rotation speed of the propeller spin. It just replaces the single 1/6 constant with one that is (hopefully) more clearly derivable from basic principles. The original number was off by a factor of 3/25; maybe something got