Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-05 Thread James Turner
On 5 Dec 2008, at 14:48, Stuart Buchanan wrote: > BTW - I've found the source of a long-standing bug were changing the > weather scenario when real-weather-fetch was enabled didn't work. Wooo! Fantastic! James --

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-05 Thread Stuart Buchanan
Curt wrote: > I did think of that after scratching my head a while ... the metar reported > several cloud layers and > I did try to switch to a new location as well as switching to fair weather > and thunderstorm ... > I did get snow and rain, but with a perfectly clear sky. I think there's a

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-05 Thread James Turner
On 5 Dec 2008, at 14:23, Yon Uriarte wrote: > a little patch for the update callback, this time in a readable > and #ifdef'ed format. > The update time goes down from 10ms to 1ms on this machine. Fog is > still applied. I'd just like to say, this kind of work is appreciated, and much nee

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-05 Thread Yon Uriarte
Hi Stuart, a little patch for the update callback, this time in a readable and #ifdef'ed format. The update time goes down from 10ms to 1ms on this machine. Fog is still applied. Bonus: trivial patch for annoying unsigned warnings. greetings, yon clouds.patch Description: Binary data -

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-05 Thread Yon Uriarte
Hi, osg::ref_ptr SGNewCloud::genCloud() { ... +GeodeList* g = (*iter).second; + +if (iter == cloudMap.end() || g->size() < num_flavours) ... dereferencing iterator::end is a no-no (it's not standard c++). suggest: GeodeList* g;// = (*iter).second; if (iter == cloudMap.end() || (g

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-04 Thread gerard robin
On vendredi 05 décembre 2008, Heiko Schulz wrote: > Hi, > > > I did think of that after scratching my head a while ... > > the metar reported > > several cloud layers and I did try to switch to a new > > location as well as > > switching to fair weather and thunderstorm ... I did get > > snow and r

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-04 Thread Heiko Schulz
Hi, > > I did think of that after scratching my head a while ... > the metar reported > several cloud layers and I did try to switch to a new > location as well as > switching to fair weather and thunderstorm ... I did get > snow and rain, but > with a perfectly clear sky. > > I can try to re-cv

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-04 Thread Curtis Olson
On Thu, Dec 4, 2008 at 4:49 PM, Martin Spott wrote: > "Curtis Olson" wrote: > > > I could easily be doing something wrong, or have inherited some > > configuration setting from a previous version, but before today's patch I > > had 3d clouds, and now I do not. This is with OSG 2.7.5. Is there >

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-04 Thread Martin Spott
"Curtis Olson" wrote: > I could easily be doing something wrong, or have inherited some > configuration setting from a previous version, but before today's patch I > had 3d clouds, and now I do not. This is with OSG 2.7.5. Is there anything > I can quickly double check? The current weather !?

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-04 Thread Curtis Olson
On Thu, Dec 4, 2008 at 2:12 PM, Stuart Buchanan wrote: > Hi All, > > Attached is yet another patch for 3D clouds. Could someone please apply it > to CVS? > > This provides the following enhancements & bug fixes > - Fix the chequer-board bug. > - Add proper cloud coverage function - so scattered cl