[Freeciv-Dev] [bug #20546] Autosettler evaluates road bonus of the road being built as one of the old road

2013-02-20 Thread Marko Lindqvist
Update of bug #20546 (project freeciv): Summary: Autosettler evaluates old road bonus as one of the road being built => Autosettler evaluates road bonus of the road being built as one of the old road ___ Reply to this item

[Freeciv-Dev] [bug #20546] Autosettler evaluates old road bonus as one of the road being built

2013-02-20 Thread Marko Lindqvist
URL: Summary: Autosettler evaluates old road bonus as one of the road being built Project: Freeciv Submitted by: cazfi Submitted on: Thu 21 Feb 2013 09:42:25 AM EET Category: ai

[Freeciv-Dev] [patch #3715] Threaded AI cities generating Worker task requests

2013-02-20 Thread Marko Lindqvist
Follow-up Comment #1, patch #3715 (project freeciv): - Mutex protection for city existence. Now there should be no possibility of crash because of lack of mutex protection. It's possible that some data it handles is inconsistent due to main thread modifying it at the same time, but I consider this

[Freeciv-Dev] [patch #3729] Attacking player specific reverse pathfinding map for cities

2013-02-20 Thread Marko Lindqvist
URL: Summary: Attacking player specific reverse pathfinding map for cities Project: Freeciv Submitted by: cazfi Submitted on: Thu 21 Feb 2013 08:57:51 AM EET Category: ai Priori

[Freeciv-Dev] [patch #3728] assess_danger() to consider AttFromNonNative unit class flag

2013-02-20 Thread Marko Lindqvist
URL: Summary: assess_danger() to consider AttFromNonNative unit class flag Project: Freeciv Submitted by: cazfi Submitted on: Thu 21 Feb 2013 08:17:26 AM EET Category: ai Priori

[Freeciv-Dev] [patch #3727] River as road & natural city names

2013-02-20 Thread Marko Lindqvist
URL: Summary: River as road & natural city names Project: Freeciv Submitted by: cazfi Submitted on: Thu 21 Feb 2013 07:13:47 AM EET Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #3701] Multiple river types

2013-02-20 Thread Marko Lindqvist
Update of patch #3701 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #3702] Citylist mutex

2013-02-20 Thread Marko Lindqvist
Update of patch #3702 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #3712] CodingStyle warning against functionality inside fc_assert()

2013-02-20 Thread Marko Lindqvist
Update of patch #3712 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #3726] Booleanize all save functions for savegame v2

2013-02-20 Thread Marko Lindqvist
Update of patch #3726 (project freeciv): Priority: 3 - Low => 5 - Normal Assigned to:None => cazfi Planned Release: => 2.5.0

[Freeciv-Dev] [patch #3726] Booleanize all save functions for savegame v2

2013-02-20 Thread Davide Baldini
URL: Summary: Booleanize all save functions for savegame v2 Project: Freeciv Submitted by: davide_at_debian Submitted on: Thu 21 Feb 2013 04:16:25 AM GMT Category: general Prior

[Freeciv-Dev] [bug #20545] String not marked for translation

2013-02-20 Thread Jacob Nevins
Update of bug #20545 (project freeciv): Category: general => client Status:None => Ready For Test Assigned to:None => jtn Planned Release:

[Freeciv-Dev] [bug #20519] Functionality inside fc_assert_ret() in unit unloading

2013-02-20 Thread Jacob Nevins
Update of bug #20519 (project freeciv): Summary: Unloading problem in release builds => Functionality inside fc_assert_ret() in unit unloading ___ Reply to this item at: ___

[Freeciv-Dev] [bug #20545] String not marked for translation

2013-02-20 Thread Jordi Negrevernis i Font
Follow-up Comment #1, bug #20545 (project freeciv): The string is '(No home city)' which appears on S2_4 on the unit selection dialog. ___ Reply to this item at:

[Freeciv-Dev] [bug #20545] String not marked for translation

2013-02-20 Thread Jordi Negrevernis i Font
URL: Summary: String not marked for translation Project: Freeciv Submitted by: jorneg Submitted on: Wed Feb 20 22:02:57 2013 Category: general Severity: 3 - Normal

[Freeciv-Dev] [patch #3279] Rusyn nation

2013-02-20 Thread J.M. Maalderink
Update of patch #3279 (project freeciv): Status:None => In Progress Assigned to:None => mixcoatl ___ Follow-up Comment #1: Changed city names

[Freeciv-Dev] [bug #20544] Sea units benefitting from City Walls

2013-02-20 Thread Marko Lindqvist
Follow-up Comment #2, bug #20544 (project freeciv): > When a unit is not in their natural element [a ship in dock or a > plane on the ground] they should be considered essentially > defenseless and automatically eliminated, IMHO. Yes, from realism point of view it doesn't make sense that ship in

[Freeciv-Dev] [bug #20544] Sea units benefitting from City Walls

2013-02-20 Thread David Lowe
Follow-up Comment #1, bug #20544 (project freeciv): I haven't actually surveyed layouts of real life cities for this, but it seems reasonable that in many cases the wall might well be built right to the water's edge. So if a ship in a harbor gets attacked by infantry, it could well be behind a wa

[Freeciv-Dev] [bug #20544] Sea units benefitting from City Walls

2013-02-20 Thread Marko Lindqvist
URL: Summary: Sea units benefitting from City Walls Project: Freeciv Submitted by: cazfi Submitted on: Wed 20 Feb 2013 05:16:57 PM EET Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #20543] lua error: Execution time limit exceeded in script

2013-02-20 Thread pepeto
URL: Summary: lua error: Execution time limit exceeded in script Project: Freeciv Submitted by: pepeto Submitted on: mer. 20 févr. 2013 16:13:33 CET Category: None Severity: 3 -

[Freeciv-Dev] [bug #20542] in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed

2013-02-20 Thread pepeto
URL: Summary: in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed Project: Freeciv Submitted by: pepeto Submitted on: mer. 20 févr. 2013 16:09:57 CET Category

[Freeciv-Dev] [bug #20541] in auto_arrange_workers() [cityturn.c::397]: assertion 'city_size_get(pcity) - spe == sum' failed

2013-02-20 Thread pepeto
URL: Summary: in auto_arrange_workers() [cityturn.c::397]: assertion 'city_size_get(pcity) - spe == sum' failed Project: Freeciv Submitted by: pepeto Submitted on: mer. 20 févr. 2013 15:51:59 CET

[Freeciv-Dev] [bug #20539] Assert failure on pregame /save

2013-02-20 Thread Davide Baldini
Follow-up Comment #2, bug #20539 (project freeciv): > ...when map is not yet created The map was created and then the game was saved immediately. The pregame status is due to savefile reload. No human player ever made any move, not even /take.

[Freeciv-Dev] [patch #3384] autosettler check current danger

2013-02-20 Thread Marko Lindqvist
Follow-up Comment #9, patch #3384 (project freeciv): > I think this is due to is_square_threatened() calling > is_ground_threat(). Given that nothing else uses this function, > perhaps it should be changed to not care about the unit move > type? To make it work well, a bit more work is needed. It

[Freeciv-Dev] [bug #20539] Assert failure on pregame /save

2013-02-20 Thread Marko Lindqvist
Update of bug #20539 (project freeciv): Summary: Assert failure on /save => Assert failure on pregame /save ___ Follow-up Comment #1: > 1: in map_get_player_city() [maphand.c::1063]: assertion 'psite > == ((void *)0) || ps

[Freeciv-Dev] [bug #20539] Assert failure on /save

2013-02-20 Thread Davide Baldini
URL: Summary: Assert failure on /save Project: Freeciv Submitted by: davide_at_debian Submitted on: Wed 20 Feb 2013 12:36:05 PM GMT Category: general Severity: 4 - Important

[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-20 Thread anonymous
Follow-up Comment #11, bug #20501 (project freeciv): > For jtn wondering what to put to NEWS: Thank you :) I was wondering exactly that. --jtn ___ Reply to this item at: _

[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-20 Thread Marko Lindqvist
Follow-up Comment #10, bug #20501 (project freeciv): > I believed it to affect client side win chance display only. For jtn wondering what to put to NEWS: "believed unit_win_chance() to affect client side win chance display only" and the change affecting unit_win_chance() in turn was specific to

[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame

2013-02-20 Thread pepeto
Follow-up Comment #2, bug #20538 (project freeciv): > Is that classic ruleset? Nationality got enabled in that > ruleset recently, so presumably savegame was created when > ruleset has no nationality, but at loading time it has. Yes, savegame says version=20105, rulesetdir="default". __

[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-20 Thread Marko Lindqvist
Follow-up Comment #9, bug #20501 (project freeciv): > One thing i've noticed in conjunction with server-side > auto-attack: units that have been given the 'Fortify' command > can be reliably counted on to engage approaching enemies. Sounds opposite of what it should be. Fortified units have have

[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame

2013-02-20 Thread Marko Lindqvist
Follow-up Comment #1, bug #20538 (project freeciv): Is that classic ruleset? Nationality got enabled in that ruleset recently, so presumably savegame was created when ruleset has no nationality, but at loading time it has. ___ Reply to this

[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame

2013-02-20 Thread pepeto
URL: Summary: Numerous assertion failures when loading an old savegame Project: Freeciv Submitted by: pepeto Submitted on: mer. 20 févr. 2013 11:58:33 CET Category: None Severit

[Freeciv-Dev] [patch #3725] Optimize disabled autoattack case

2013-02-20 Thread Marko Lindqvist
URL: Summary: Optimize disabled autoattack case Project: Freeciv Submitted by: cazfi Submitted on: Wed 20 Feb 2013 12:43:42 PM EET Category: general Priority: 5 - Normal

[Freeciv-Dev] [bug #19943] Initial protocol between trunk and S2_4-or-earlier broken

2013-02-20 Thread pepeto
Update of bug #19943 (project freeciv): Assigned to:None => pepeto Operating System:None => Any ___ Follow-up Comment #12: New version of the

[Freeciv-Dev] [patch #2190] Control of registry boolean compability

2013-02-20 Thread pepeto
Update of patch #2190 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #2206] execute_orders() changes

2013-02-20 Thread pepeto
Update of patch #2206 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #17354] Client tries to load game in spawned server before requesting "hack" access

2013-02-20 Thread pepeto
Update of bug #17354 (project freeciv): Assigned to:None => pepeto ___ Reply to this item at: ___ Message post

[Freeciv-Dev] [bug #19868] Network protocol documentation

2013-02-20 Thread Sveinung Kvilhaugsvik
Follow-up Comment #10, bug #19868 (project freeciv): > I would suggest for multi-line comment to move the comment before the macro. Thank you for your suggestion. I had to rework the original comments a bit since they now are above and need context. (file #17275)

[Freeciv-Dev] [bug #20517] Invalid read of size 4 in ruleset reloading cycle

2013-02-20 Thread pepeto
Update of bug #20517 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed Operating System:None => Any _

[Freeciv-Dev] [bug #20490] Player owner reconnecting to player while delegate user attached => server assertion failures, crash

2013-02-20 Thread pepeto
Update of bug #20490 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #20086] in astr_vadd() [astring.c::164]: assertion '(size_t) -1 != new_len' failed.

2013-02-20 Thread pepeto
Update of bug #20086 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #19868] Network protocol documentation

2013-02-20 Thread Sveinung Kvilhaugsvik
Follow-up Comment #9, bug #19868 (project freeciv): False alarm. Turns out that unless delta is enabled building using Werror will fail no matter if the patch is applied or not. ___ Reply to this item at: __

[Freeciv-Dev] [bug #20519] Unloading problem in release builds

2013-02-20 Thread Marko Lindqvist
Update of bug #20519 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #19868] Network protocol documentation

2013-02-20 Thread pepeto
Update of bug #19868 (project freeciv): Status:None => In Progress ___ Follow-up Comment #8: I would suggest for multi-line comment to move the comment before the macro. _

[Freeciv-Dev] [patch #3709] Representative icon of river road type

2013-02-20 Thread Marko Lindqvist
Update of patch #3709 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #20535] Road icons in editor are a bit ugly

2013-02-20 Thread Marko Lindqvist
Update of bug #20535 (project freeciv): Severity: 2 - Minor => 3 - Normal ___ Follow-up Comment #1: "a bit"? What we currently have is what I managed to get working in order of that icon issue not

[Freeciv-Dev] [bug #19868] Network protocol documentation

2013-02-20 Thread Sveinung Kvilhaugsvik
Follow-up Comment #7, bug #19868 (project freeciv): Warning: The attached patch breaks building when delta and bool folding is turned off. I suspect #define NAME VALUE /* start of commentn * next line */" may be involved (if NAME is replaced using "VALUE /* start of comment" but not the line that