Re: debug-early branch merged into mainline

2015-06-06 Thread Aldy Hernandez
attached fix the ia64 failure? commit 6c40c8f011bbd09ea92749f3925db83f249baf74 Author: Aldy Hernandez Date: Sat Jun 6 06:48:40 2015 -0400 * dwarf2out.c (gen_lexical_block_die): Initialize stmt_die. diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c index 2e3bee3..23cf120 100644 -

debug-early branch merged into mainline

2015-06-05 Thread Aldy Hernandez
The debug-early work has been merged into mainline. There is a known Ada failure which Eric B. knows about and approved, and for which there is an appropriate FIXME note in the Ada sources: +FAIL: gnat.dg/specs/debug1.ads scan-assembler-times DW_AT_artificial 17 There is also a known regressi

Re: Merging debug-early work?

2015-05-09 Thread Aldy Hernandez
On 05/08/2015 01:51 AM, Richard Biener wrote: Did you see if --with-build-config=bootstrap-lto still works? Just did on x86-64 Linux. Bootstrap succeeds without any problems. While doing the LTO work I wondered why you have the late_global_decl loop in toplev.c:compile_file at all (well, ma

Re: Merging debug-early work?

2015-05-07 Thread Aldy Hernandez
On 05/06/2015 04:22 AM, Richard Biener wrote: On Wed, May 6, 2015 at 12:33 AM, Aldy Hernandez wrote: Gentlemen! I believe I have done as much as is reasonable for a merge, but I'd like to get your opinion before I post a huge patch to the list. The branch bootstraps with one regressi

Merging debug-early work?

2015-05-05 Thread Aldy Hernandez
Gentlemen! I believe I have done as much as is reasonable for a merge, but I'd like to get your opinion before I post a huge patch to the list. The branch bootstraps with one regression in GCC (gcc.dg/debug/dwarf2/stacked-qualified-types-3.c) and none for GDB. The GCC regression is a missed

[debug-early] branch merged with trunk@222380

2015-04-23 Thread Aldy Hernandez
There was one minor regression which I've fixed. Tested on x86-64 Linux with the GCC and GDB testsuites. Next on my plate is (finally) a full bootstrap now that GCC's guality.exp, dwarf2.exp, and debug.exp are down to 1 regression versus mainline. And finally... submitting the branch for revi

[debug-early] emitting early debug for external variables

2015-03-18 Thread Aldy Hernandez
Gentlemen: Since we pick global symbols to be emitted early from the symbol table, we miss out on DECL_EXTERNAL's because they never appear in the symbol table: [rest_of_decl_compilation]: else if (TREE_CODE (decl) == VAR_DECL && !DECL_EXTERNAL (decl) && TREE_STATIC (decl)) v

Re: fatal error: config.h: No such file or directory

2014-12-23 Thread Aldy Hernandez
Andrew Haley writes: > On 12/21/2014 02:38 AM, Bruce Korb wrote: >> Shouldn't the configure step have made config.h? > > It's probably because you are building in srcdir. That is not > supported. Hmm, newbies run into this often enough that I wonder whether we should just error out from the con

Re: [debug-early] LTO streaming of on-the-side dwarf data structures

2014-10-15 Thread Aldy Hernandez
On 10/15/14 00:55, Richard Biener wrote: On Tue, Oct 14, 2014 at 10:07 PM, Aldy Hernandez wrote: On 10/14/14 06:21, Richard Biener wrote: On Tue, Oct 14, 2014 at 2:48 AM, Aldy Hernandez wrote: Another similar issue I've seen is handling DW_TAG_lexical_block (gen_lexical_bloc

Re: [debug-early] LTO streaming of on-the-side dwarf data structures

2014-10-14 Thread Aldy Hernandez
Another similar issue I've seen is handling DW_TAG_lexical_block (gen_lexical_block_die). Ideally we should generate the DW_TAG_lexical_block and the corresponding locals in early dumping, and then fill in the high/low attributes of the lexical block the second time around. We would need a has

Re: [debug-early] LTO streaming of on-the-side dwarf data structures

2014-10-14 Thread Aldy Hernandez
On 10/14/14 06:21, Richard Biener wrote: On Tue, Oct 14, 2014 at 2:48 AM, Aldy Hernandez wrote: Gentlemen, your feedback would be greatly appreciated! I was investigating why locals were not being early dumped, and realized Michael's patch was skipping decls_for_scope() u

[debug-early] LTO streaming of on-the-side dwarf data structures

2014-10-13 Thread Aldy Hernandez
Gentlemen, your feedback would be greatly appreciated! I was investigating why locals were not being early dumped, and realized Michael's patch was skipping decls_for_scope() unless DECL_STRUCT_FUNCTION->gimple_df was set. I assume this was to wait until location information was available. T

Re: LTO inhibiting dwarf lexical blocks output

2014-08-18 Thread Aldy Hernandez
On 08/18/14 07:31, Richard Biener wrote: On Mon, Aug 18, 2014 at 12:46 PM, Richard Biener wrote: On Fri, Aug 15, 2014 at 9:59 PM, Aldy Hernandez wrote: For the rest them on the floor instead of ICEing in dwarf2out.c. */ Should that read "For the rest, drop them on the

Re: LTO inhibiting dwarf lexical blocks output

2014-08-15 Thread Aldy Hernandez
Isn't the only real solution: to generate this kind of DIEs earlier (maybe already immediately after parsing) and stream them? Ultimately yes, and that's what I hope to work on, but I was mostly curious because at stream out time, the information *is* there, and we silently dropped it. Ald

LTO inhibiting dwarf lexical blocks output

2014-08-15 Thread Aldy Hernandez
So... I've been getting my feet wet with LTO and debugging and I noticed a seemingly unrelated yet annoying problem. On x86-64, gcc.dg/guality/pr48437.c fails when run in LTO mode. I've compared the dwarf output with and without LTO, and I noticed that the DW_TAG_lexical_block is missing from

Re: Cilk Library

2013-10-10 Thread Aldy Hernandez
On 10/09/13 13:32, Iyer, Balaji V wrote: Is it OK for trunk? I would prefer that a consumer of this library be in place before you commit. That is, until cilk_spawn/sync/etc go in.

New cilkplus-merge branch

2013-03-20 Thread Aldy Hernandez
Hi folks. In order to facilitate the contribution and possible merging of the cilkplus work into mainline, I have created a new git branch (cilkplus-merge). I have also created a wiki page where we (Balaji and myself) will keep a status of the work: http://gcc.gnu.org/wiki/cilkplus-

Re: gcc : c++11 : full support : eta?

2013-01-23 Thread Aldy Hernandez
Uday Khedker writes: > I think we need to come out of the "documentation" mindset. No amount > of conventional documentation is going to help. What we need is a > training material that included well defined assignments. FWIW, I initially learned GCC by an internal training program Jeff Law devi

Re: Merging Cilk Plus into GCC Trunk

2012-09-05 Thread Aldy Hernandez
On 09/05/12 12:09, Iyer, Balaji V wrote: I can't speak for the rest of the community, but I think items 1-12 are useful for GCC (elemental functions, SIMD annotations, and array notations for C/C++), regardless of any language extensions. Perhaps you could provide examples on these as a start

Re: Merging Cilk Plus into GCC Trunk

2012-09-04 Thread Aldy Hernandez
On 08/30/12 15:39, Iyer, Balaji V wrote: Hello Everyone, The Cilk-Plus branch is feature-complete. Programs using Cilk Plus constructs get great performance on vector and multicore hardware. Programs that don't use the new language features (enabled by a -fcilkplus flag) see no change.

Re: LTO inlining of transactional builtins

2012-06-29 Thread Aldy Hernandez
In theory we should be able to do multiple "LTO" passes. So we could do a.c a.o ... -> -> WPA -> LTRANS and TM lowering -> WPA -> LTRANS and RTL expand x.c x.o Thus, after a first wave of WPA and LTRANS in non-lowered TM we can, after the TM lowering in the first LTR

Re: LTO inlining of transactional builtins

2012-06-25 Thread Aldy Hernandez
a) If a user provides a builtin implementation to LTO, it is discarded, since by design LTO prefers builtins to user-provided versions of them. In LTO, builtins are their own prevailing decl. There is an enhancement request PR here: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51997

LTO inlining of transactional builtins

2012-06-22 Thread Aldy Hernandez
Hi gentlemen. I am looking again at LTO + TM. The goal is to be able to link with the implemented _ITM_* functions in libitm.a, and have them inlined into the transaction code when profitable. To refresh everyone's memory, the original problem was two-fold: a) If a user provides a builtin i

Re: backporting PR52558 to 4.7?

2012-06-07 Thread Aldy Hernandez
On 05/31/12 15:44, Aldy Hernandez wrote: Hello gentlemen. Would it be ok to backport the fix for PR52558 into the 4.7 branch? This PR is the store data race patch I have been iterating with Richi. Doing so will avoid critical data races for both TM and the C++ memory model. The code is all

backporting PR52558 to 4.7?

2012-05-31 Thread Aldy Hernandez
Hello gentlemen. Would it be ok to backport the fix for PR52558 into the 4.7 branch? This PR is the store data race patch I have been iterating with Richi. Doing so will avoid critical data races for both TM and the C++ memory model. The code is all predicated by flag_tm or !PARAM_VALUE (PA

Re: PRE_GCC3_DWARF_FRAME_REGISTERS

2012-03-20 Thread Aldy Hernandez
On 03/19/12 12:28, David Edelsohn wrote: On Wed, Mar 14, 2012 at 10:08 AM, Steven Bosscher wrote: Hello, The rs6000 and cr16 backends and unwinding code have a define for the DWARF frame register for pre-GCC3 compatibility (PRE_GCC3_DWARF_FRAME_REGISTERS): gcc/doc/tm.texi.in:@defmac PRE_GCC3_

Re: [trans-mem,libitm] brief report on known bugs

2012-02-07 Thread Aldy Hernandez
* Bug 51752 - trans-mem: publication safety violated I'm working on this.

Re: Memory corruption due to word sharing

2012-02-02 Thread Aldy Hernandez
Linus Torvalds writes: > Seriously - is there any real argument *against* just using the base > type as a hint for access size? If I'm on the hook for attempting to fix this again, I'd also like to know if there are any arguments against using the base type.

Re: [4.7,trans-mem] Summary of unsolved known bugs

2012-01-17 Thread Aldy Hernandez
On 12/21/11 11:06, Patrick Marlier wrote: Wonderful! Thanks Aldy. On 12/21/2011 09:11 AM, Aldy Hernandez wrote: * ICE when lto1 does not have -fgnu-tm and object file uses TM http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51280 I believe I wasn't able to reproduce this. Arg really! Fo

Re: [4.7,trans-mem] Summary of unsolved known bugs

2012-01-10 Thread Aldy Hernandez
On 01/09/12 04:20, Torvald Riegel wrote: Looking at Patrick's old list, the following bugs are still open [trans-mem] save/restore of thread-local data in nested txns is missing http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49581 Aldy, you wanted to take a look. Were you able to repr

Re: [4.7,trans-mem] Summary of unsolved known bugs

2011-12-21 Thread Aldy Hernandez
* Stack save/restore not working? -> XFAIL testcases Related to this: ICE: verify_gimple failed: invalid rhs for gimple memory store with -fgnu-tm --param tm-max-aggregate-size=32 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51472 Proposed fix, waiting for review. [trans-mem] save/restore of

transactional-memory branch has been merged into trunk

2011-11-08 Thread Aldy Hernandez
The TM branch has been merged into trunk. No regressions or problems when testing on x86-64 Linux. Thanks to Torvald and Richard for all their hard work this past week (and prior!). And thanks to all the branch reviewers. If anyone needs me, I'll be enjoying my time in Honolulu, so don't bo

[trans-mem] merge from mainline at revision 181122

2011-11-07 Thread Aldy Hernandez
No anomalies. No regressions. I will now post the full patchset I would like to post to trunk.

Re: transactional-memory status

2011-11-07 Thread Aldy Hernandez
I suppose we can freeze for the TM merge once we leave stage1 (thus, in a few hours). If you are ready by then, of course, and the tree isn't too broken. Richard. Fine by me. In the meantime we will stabilize things on the branch, merge from trunk, run tests, and have a patch ready to be ap

transactional-memory status

2011-11-07 Thread Aldy Hernandez
Dear Release Managers... We're pretty much done with the merge blockers, and even suggestions that weren't blockers :). The only outstanding patch review is a cleanup by Richard Henderson that is waiting for Richi's review here: http://gcc.gnu.org/ml/gcc-patches/2011-11/msg01033.html I am s

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-07 Thread Aldy Hernandez
Could you please fix up whitespace in the patch, at least leading tabs and trailing whitespace? On the patch it is easy to do, something like: sed 's/^+\([\t]*\) \{64\}/+\1\t\t\t\t\t\t\t\t/;s/^+\([\t]*\) \{32\}/+\1\t\t\t\t/;s/^+\([\t]*\) \{16\}/+\1\t\t/;s/^+\([\t]*\) \{8\}/+\1\t/;s/^+\(.*[^[:b

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-03 Thread Aldy Hernandez
We want to look at proper patch submissions not at websites that change from time to time. I really don't know what you take issue with, or where the difficulty is. patch submission via gcc-patches@ is a requirement since forever, not something arbitrarily imposed on specifically you to annoy

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-03 Thread Aldy Hernandez
Aldy, what folks are asking for is reasonably contained patches from the branch that can be reviewed. Ideally they could be installed independently, but it's not strictly necessary. I already did so: compiler/ libitm/ libstdc++-v3/ misc/ toplevel/ The ChangeLog's are at the top. The testsu

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-03 Thread Aldy Hernandez
Index: gcc/c-opts.c === --- gcc/c-opts.c(.../trunk) (revision 0) +++ gcc/c-opts.c(.../branches/transactional-memory) (revision 180773) @@ -0,0 +1,1773 @@ +/* C/ObjC/C++ command line option handling. + Copy

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-03 Thread Aldy Hernandez
Reviewable patches as in what goes in gcc-patches? Or do you want something else? Reviewable branch merge patch(es). You can't expect everyone to follow all development branches that may or may not end up being merged. Is what I posted not in a way that can be reviewed? Did you download

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-03 Thread Aldy Hernandez
Have you ever posted the patch, or only made it available via the website? Have you not seen the last 3 years of patches to gcc-patches? They're prefixed by [trans-mem]. Perhaps you're filtering them out. Just scanning http://quesejoda.com/redhat/tm-branch-diffs-from-trunk-at-180744/comp

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-03 Thread Aldy Hernandez
Could you please fix up whitespace in the patch, at least leading tabs and trailing whitespace? On the patch it is easy to do, something like: sed 's/^+\([\t]*\) \{64\}/+\1\t\t\t\t\t\t\t\t/;s/^+\([\t]*\) \{32\}/+\1\t\t\t\t/;s/^+\([\t]*\) \{16\}/+\1\t\t/;s/^+\([\t]*\) \{8\}/+\1\t/;s/^+\(.*[^[:b

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-03 Thread Aldy Hernandez
Is this necessary for the entire patch, or just the parts that touch existing parts of the toolchain. For example, do you want me to run this on libitm/, etc? I'm really trying to minimize changes (even whitespace stuff) at the last minute, but if you think it's imperative, I will do so. Wel

[cxx-mem-model] permission to merge cxx-mem-model branch?

2011-11-03 Thread Aldy Hernandez
I have separated out a master patchset for the cxx-mem-model work: http://quesejoda.com/redhat/cxx-mem-model-diffs-from-trunk-at-180790/ When would be a good time to ask for a trunk freeze/slush to do a merge? Aldy

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-02 Thread Aldy Hernandez
I remember at least seeing middle-end pieces in alias analysis. Yes, but they're mechanical changes. Do you mean these?: @@ -1182,6 +1182,8 @@ ref_maybe_used_by_call_p_1 (gimple call, case BUILT_IN_MEMPCPY: case BUILT_IN_STPCPY: case BUILT_IN_STPNCPY: +case BU

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-01 Thread Aldy Hernandez
I'd like to see some breakdown into subsystem patches. Can someone provide those together with changelog entries? I am doing another merge from trunk->branch, and will post a series of patches by subsystem. I will do so after the merge is complete and tested.

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-01 Thread Aldy Hernandez
Have you looked at those diffs, there's a fair amount of unrelated Will clean up. crud in there... It might help to break the blob into more easily understood hunks for actual submissions. ie, runtime bits (libitm), changes to existing runtime stuff, compiler proper, testsuite bits, etc.

Re: Potentially merging the transactional-memory branch into mainline.

2011-11-01 Thread Aldy Hernandez
Aldy, Richard, is there a patchset or master patch I could read? I have made current diff as of today: http://quesejoda.com/tm-branch-latest.bz2

Potentially merging the transactional-memory branch into mainline.

2011-10-31 Thread Aldy Hernandez
This is somewhat of a me-too message for the transactional-memory work. We would also like it to be considered for merging with mainline before the end of stage1. We have a kept a wiki here: http://gcc.gnu.org/wiki/TransactionalMemory What it is == From the wiki... Transactional me

Re: Potentially merging cxx-mem-model with mainline.

2011-10-31 Thread Aldy Hernandez
> It does not address other missing aspects of the c++ memory model. In > particular, bitfields are still not compliant with not introducing new > potential data races. Can we treat this as a bugfix to be done during stage2? There is already some support in mainline, but it performs lousy on an

[trans-mem] merge from trunk @ 178608

2011-09-14 Thread Aldy Hernandez
This was very painful, and it's still not over. We hadn't merged in almost 1.5 years, and we're paying for it now... I managed to resolve all the conflicts, and bootstrap the compiler, which is rather amazing given the size of the changes. There are still over 16 compiler failures in gcc.dg/

Re: GCC 4.7.0 Status Report (2011-09-09)

2011-09-12 Thread Aldy Hernandez
Jakub Jelinek writes: > In particular, is transactional-memory branch mergeable within > a month and half, at least some parts of cxx-mem-model branch, > bitfield lowering? What is the status of lra, reload-2a, pph, Torvald and I are looking into getting things merge read, but... The main prob

[cxx-mem-model] new branch, new project

2011-03-07 Thread Aldy Hernandez
Not that I'm abandoning the transactional memory party, but I'll also be spending some cycles on the C++0x memory model work, which is an offshoot of the atomics work Andrew Macleod has been working on (http://gcc.gnu.org/wiki/Atomic). I have added a link to the memory model work from the main

Re: [trans-mem] __sync_add_and_fetch_8 on ia32

2010-07-07 Thread Aldy Hernandez
> > ... a slightly more sophisticated variant of b) would be using > > uint64_t for 64-bit targets and uint32_t for 32-bit targets, should > > make everybody happy. > > There's a correctness issue in the library interface -- there's no > clean way to handle that value overflowing. Rather than mak

Re: RFC: VTA alias set discrepancy

2010-03-17 Thread Aldy Hernandez
> > > Are you suggesting we remove the entire code path here: > > > > > > ?/* Try harder to get a rtl. ?If this symbol ends up not being emitted > > > ? ? in the current CU, resolve_addr will remove the expression referencing > > > ? ? it. ?*/ > > > > > > ?? > > > > Yes. > > That will very much p

Re: RFC: VTA alias set discrepancy

2010-03-17 Thread Aldy Hernandez
> > ? ? rtl = DECL_RTL (decl); > > ? ? /* Reset DECL_RTL back, as various parts of the compiler expects > > ? ? ? ?DECL_RTL set meaning it is actually going to be output. ?*/ > > ? ? SET_DECL_RTL (decl, NULL); > > > > ... why do this in the first place? ?Is this an issue for all decls or just > > f

Re: RFC: VTA alias set discrepancy

2010-03-17 Thread Aldy Hernandez
> I guess best would be to make sure no new alias set is created in these > places. Perhaps > int save_strict_aliasing = flag_strict_aliasing; > flag_strict_aliasing = 0; > rtl = DECL_RTL (decl); > flag_strict_aliasing = save_strict_aliasing; > in both places? Remember when I said I had come up w

RFC: VTA alias set discrepancy

2010-03-17 Thread Aldy Hernandez
Hi folks. I am debugging a bunch of Fortran -fdebug-compare failures on the testsuite, all of which stem from symbols ending up on different alias set slots. Notice the 2 versus 3 discrepancy below: < (insn:TI# 0 0 a.f90:3 (set (mem/c/i:SI (symbol_ref:DI ("i.0.1535") [flags 0x2] ) [2 i.0+0 S4 A3

[trans-mem] __sync_add_and_fetch_8 on ia32

2010-02-19 Thread Aldy Hernandez
libitm.so won't build on ia32 because of an undefined reference to __sync_add_and_fetch_8. This is the build failure Pearly encountered here: http://gcc.gnu.org/ml/gcc-patches/2009-09/msg01201.html What happens is that we try to do a __sync_and_fetch() on global_tid, which is of type _IT

[trans-mem] merge from trunk @ 156607

2010-02-10 Thread Aldy Hernandez
Nothing major. Two minor changes: Edge frequencies are now compared with BB frequencies in verify_cgraph_node(). This showed an inconsistency in the edge created in ipa_tm_insert_gettmclone_call(). Fixed. The function free_lang_data():tree.c no longer runs for all front-ends, so lang_hooks.dec

Re: [trans-mem] ipa tm pass and dominator walks

2010-02-03 Thread Aldy Hernandez
> This part is ok. Committed. > > (ipa_tm_transform_calls_1): Rename from ipa_tm_transform_calls. > > Only process one block. > > (ipa_tm_transform_calls): Iterate through CFG and call helper > > function. > > This part isn't. As we discussed on IRC, you're missing a check > for

Re: [trans-mem] ipa tm pass and dominator walks

2010-02-03 Thread Aldy Hernandez
> I don't think that's true at all. You showed that the walking was > incorrect; I don't see you you can now argue that it is correct, > regardless of inlining and jump threading. > > All one needs to create the cfg that exhibits the problem is > multiple exits from the transaction. It's not ter

[trans-mem] ipa tm pass and dominator walks

2010-01-29 Thread Aldy Hernandez
Hey! With my last patch, we only have 3 instances of dominator tree walks left in the tree, all in the TM ipa pass. I believe we can leave those as they are, since the TM ipa pass runs early enough that nothing has altered control flow such that code outside of a transaction ends up inside a tran

Re: RFC: allowing fold to change location of args (PR/41451)

2009-10-26 Thread Aldy Hernandez
> Certainly better. But I fail to see why a different location would be > better than the original here. I assume all tokens have a correct initial > location. Then why is for example for int i; in (int) i the location of > the conversion a better location than the one of i in the folded result

Re: RFC: allowing fold to change location of args (PR/41451)

2009-10-26 Thread Aldy Hernandez
> That wasn't my question. > > tem = fold_build2_loc (loc, code, type, > fold_convert_loc (loc, TREE_TYPE (op0), > TREE_OPERAND (arg0, 1)), op1); > protected_set_expr_location (tem, loc); > > here tem is built by

Re: RFC: allowing fold to change location of args (PR/41451)

2009-10-26 Thread Aldy Hernandez
> > ? ? ?tem = fold_build2_loc (loc, code, type, > > ? ? ? ? ? ? ? ? ? ? ? ? ? ? fold_convert_loc (loc, TREE_TYPE (op0), > > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? TREE_OPERAND (arg0, 1)), op1); > > ? ? ?protected_set_expr_location (tem, loc); > > > > When --enable-checking=fold, fold verifi

RFC: allowing fold to change location of args (PR/41451)

2009-10-26 Thread Aldy Hernandez
Hi folks. In this PR the problem is that a call to fold_build2_loc() returns one of the original arguments unchanged. In the code below we take this result and change its location before returning it. tem = fold_build2_loc (loc, code, type, fold_convert_loc (lo

don't touch fold locations

2009-06-18 Thread Aldy Hernandez
Hi folks. Fold needs some serious surgery to make it location friendly. I'm currently revamping the whole thing to take locations, so if you're thinking of adding locations to any of the functions, please hold off until I'm done, to avoid duplication of work as well as a conflict nightmare. Some

Re: diagnostics-branch merged into mainline

2009-06-15 Thread Aldy Hernandez
> ../../gcc/gcc/config/i386/winnt.c: In function ?i386_pe_encode_section_info?: > ../../gcc/gcc/config/i386/winnt.c:288: error: too few arguments to > function ?make_decl_one_only? make_decl_one_only expects one argument, and that's what's being fed. Could you please debug this and find out what's

Re: diagnostics-branch merged into mainline

2009-06-15 Thread Aldy Hernandez
> Your committal of r148442 has caused an ICE during the build of libgcc > for targetting win64: I have this pending patch, which may or may not fix this. http://gcc.gnu.org/ml/gcc-patches/2009-06/msg01113.html Can you try and see if it fixes it? Otherwise, can you find out where the compiler i

Re: mainline breakage (r148442)

2009-06-15 Thread Aldy Hernandez
oliver.kell...@t-online.de (Oliver Kellogg) writes: > Anybody else seeing this? > > ‘lower_try_finally_switch’: > ../../../SOURCES/gcc/gcc/tree-eh.c:1350:5: error: ‘tf_loc’ may be used > uninitialized in this function Funny, this was never picked up in any of my bootstraps, but it is indeed a bug

Re: diagnostics-branch merged into mainline

2009-06-12 Thread Aldy Hernandez
> And now you broke PowerPC and most other targets that call build_decl: Most other targets? You mean *every* target that uses build_decl. Oops, sorry about that. The patch below fixes it. I can't do a bootstrap (I can't find the PPC machine I have access to, and everyone seems to be in a hurry

Re: diagnostics-branch merged into mainline

2009-06-12 Thread Aldy Hernandez
> Nope, I just meant that you presumably had every right to do so and should > have felt free to exercise it because merging a branch justifies asking for a > freeze. Ok, I was not aware of that. My apologies. For some reason I thought only GWP folks (or thereabouts) could ask for a freeze. I

Re: diagnostics-branch merged into mainline

2009-06-12 Thread Aldy Hernandez
On Sat, Jun 13, 2009 at 01:51:42AM +0100, Dave Korn wrote: > Aldy Hernandez wrote: > > Hi folks. > > > > At the last minute Ian got a patch in that touched a bunch of places > > that I was also changing. I resolved the conflicts, and bootstrapped > > and tes

diagnostics-branch merged into mainline

2009-06-12 Thread Aldy Hernandez
Hi folks. At the last minute Ian got a patch in that touched a bunch of places that I was also changing. I resolved the conflicts, and bootstrapped and tested for C and C++. Unfortunately, people kept committing stuff that caused conflicts, so I broke down and committed after a minor C/C++ boots

Re: [RFC] enabling -fshow-column by default

2009-06-11 Thread Aldy Hernandez
On Thu, Jun 11, 2009 at 03:09:48PM +0100, Jonathan Wakely wrote: > 2009/6/5 Jonathan Wakely: > > 2009/6/5 Aldy Hernandez: > >> > >> Which test is this? ?Can you send it to me? > > > > It tests a header that isn't checked in yet, so sending the test alon

Re: [RFC] enabling -fshow-column by default

2009-06-05 Thread Aldy Hernandez
On Fri, Jun 05, 2009 at 12:09:57AM +0100, Jonathan Wakely wrote: > 2009/5/20 Aldy Hernandez: > >> > >> My only worry is that the testsuite may confuse column and line > >> numbers and pass/fail tests because of it. > > > > Janis has a patch for the tes

Re: [RFC] enabling -fshow-column by default

2009-05-20 Thread Aldy Hernandez
On Wed, May 20, 2009 at 04:39:00PM +0200, Manuel L?pez-Ib??ez wrote: > 2009/5/20 Aldy Hernandez : > > Hi folks. > > > > Before I merge the diagnostics branch I'd like to enable it on the > > testsuite to get us all in the habit of at least being aware of columns

[RFC] enabling -fshow-column by default

2009-05-20 Thread Aldy Hernandez
Hi folks. Before I merge the diagnostics branch I'd like to enable it on the testsuite to get us all in the habit of at least being aware of columns. Joseph Myers suggested enabling it in the compiler instead of the testsuite. Are there any big objections to this? Aldy

CPP and column numbers

2009-02-19 Thread Aldy Hernandez
Hi Tom. Hi folks. Imagine: enum e { E5 = INTMAX + 1, ^ column 15. }; This addition will trigger an overflow warning in the C FE. However, the location of the '+' will not be column 15 as expected, but the pre-processed column number (19): E5 = 2147483647 + 1,

Re: [diagnostics-branch] creating new branch

2008-11-18 Thread Aldy Hernandez
> In addition, we need to consider the interests of translators, who need > some time before a release to translate new and changed messages without Ah. Agreed. Another thing. Patches to the branch should be tested against the GCC regression suite *and* the GDB testsuite. Assume any upcoming

[diagnostics-branch] creating new branch

2008-11-18 Thread Aldy Hernandez
Hi folks. Though I would have preferred to work in mainline with the appropriate maintainers (Joseph, et al) approving my patches, there seems to be no way I can limit the invasiveness of my diagnostics work... even though it's technically a regression and/or bug fix. It can't make it to 4.4, wit

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Aldy Hernandez
> * In the near future, make -fdiagnostics-show-caret the default at > least while in experimental mode or at least during stages1 and 2. > When making a release -fno-diagnostics-show-caret would be the > default. Do this through a configure option that sets the default. > > * In the far away futu

Re: [PATCH] caret diagnostics (was: broken FE diagnostics wrt complex expressions)

2008-08-14 Thread Aldy Hernandez
> Then we are not going to get correct locations ever. New users do not > read the manual. Neither old users do. New functionality disabled by > default will be lost for both. I am fairly sure that a significant > percentage of GCC developers (not just users) do not know about > -fdiagnostics-show-

Re: broken FE diagnostics wrt complex expressions

2008-08-14 Thread Aldy Hernandez
> There are various issues that would need to be addressed to have > decent caret diagnostics: Agreed. I think having caret diagnostics in place is a good first step, if only because it'll make debugging of column diagnostics easier. After this, we can modify the testsuite machinery to test colum

Re: broken FE diagnostics wrt complex expressions

2008-08-14 Thread Aldy Hernandez
> Aldy> 1. beginning/ending locations functionality as Joseph suggests. > Aldy> 2. make sure the parsers pick the proper token/location. > Aldy> 3. error reporting machinery > > Aldy> How does this sound? > > It sounds good to me. #1 might be hard, I have not looked into it. Well, we can alwa

Re: broken FE diagnostics wrt complex expressions

2008-08-13 Thread Aldy Hernandez
> If you're interested in working on this, I think one way to do it > would be to start with a parser and make sure it always picks the > proper token from which to extract a location. This is a reasonable > amount of work, and unfortunately much of it would have to be complete > before we could e

broken FE diagnostics wrt complex expressions

2008-08-13 Thread Aldy Hernandez
Hi folks. I'm looking at 3544[123] and 35742, which are all related to pp_c_expression not handling complex expressions, so we can't display correct error messages for statement expressions, etc: ({break;})() The error here is currently: #'goto_expr' not supported by pp_c_expression#'

Re: Aldy and Jakub apponted GIMPLE maintainers

2008-07-28 Thread Aldy Hernandez
On Mon, Jul 28, 2008 at 10:38:43AM -0400, David Edelsohn wrote: > I am pleased to announce that the GCC Steering Committee has > appointed Aldy Hernandez and Jakub Jelinek as GIMPLE maintainers. > > Please join me in congratulating Aldy and Jakub on their new role. &

Re: Merging tuples branch into mainline today

2008-07-25 Thread Aldy Hernandez
> In terms of regressions versus mainline, the only regressions introduced by > tuples wrt mainline are the matrix-reorg pass that still has not been > converted. It also fixes 4 libstdc++ testcases that are currently broken > in trunk: Apart from the matrix-reorg regressions, there are the Di

Re: Merging tuples branch into mainline today

2008-07-25 Thread Aldy Hernandez
> I think that someone, though, should be committed to fixing this pass ASAP > after it's checked in; waiting until late August to fix it seems bad. Is > there someone else who can commit to working on it as a high priority after > the main tuples checkin? I would obviously vote in favor of re

[tuples] Merge with mainline @138071

2008-07-23 Thread Aldy Hernandez
Nothing interesting except less regressions. Yay.

[tuples] merge with mainline @137837

2008-07-15 Thread Aldy Hernandez
I have merged mainline @137837 into the branch. Jakub reports: I don't have a testsuite_summary log from after the PRE commit but before this merge, only summary from yesterday. There are many tests fixed (most of them likely because of the PRE merge) and several

Re: [tuples] Jakub is now branch maintainer

2008-07-14 Thread Aldy Hernandez
On Mon, Jul 14, 2008 at 02:28:51PM -0700, Diego Novillo wrote: > Jakub, > > You've been doing great work on the branch, so Aldy and I think that > you don't really need patch approval for branch patches anymore. So, > from now on, feel free to commit your patches without waiting for an > explicit

Re: RFH: Building and testing gimple-tuples-branch

2008-05-08 Thread Aldy Hernandez
> "Diego" == Diego Novillo <[EMAIL PROTECTED]> writes: > are OK. If you are creating a bugzilla report, please add my address > to the CC field. Me too please. Aldy

[tuples] creating singleton sequences

2008-04-15 Thread Aldy Hernandez
Hey there. Frequently we want to create a new sequence that contains one element. This is especially common when wrapping things with a BIND or in a TRY block. I'm tired of typing the same thing over and over. How about a convenience function like this? Index: gimple.h =

Re: [tuples] Tuples branch frozen

2008-03-28 Thread Aldy Hernandez
On Fri, Mar 28, 2008 at 08:48:12AM -0400, Diego Novillo wrote: > Folks, I need to freeze the branch for a few hours. The overnight > tester returned many new failures that I need to analyze. Please > refrain from checking in anything until I unfreeze the branch. Grrr. I hope it wasn't me. I di

Re: double gimplification in C++ FE

2007-10-16 Thread Aldy Hernandez
> Yes, the gimplifier often makes several passes over the same trees to get > them completely lowered. cp_gimplify_expr is a subroutine of the > gimplifier. Good, I just wanted to make sure I wasn't off my rocker or anything. > Sure. Another alternative would be to leave the calls to gimplify

double gimplification in C++ FE

2007-10-16 Thread Aldy Hernandez
Hi Jason. Hi folks. I'm in the process of converting the C++ FE to tuples. In doing so I have noticed that the C++ FE will frequently gimplify bits of a tree, and then expect gimplify_expr() to gimplify the rest. This seems redundant, as gimplify_expr() more often than not will gimplify the ent

[tuples] mainline merge (@ 129233)

2007-10-11 Thread Aldy Hernandez
Hi folks. I have merged mainline (rev 129233) into the tuples branch. All compile.exp tests succeed. No regressions. Nothing of interest. Aldy

<    1   2   3   >