http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #39 from Alexander Potapenko glider at google dot com 2012-11-15
08:18:01 UTC ---
I agree with Kostya that no major changes to mach_override are necessary
because we are really going to dump it. However minor fixes required for
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #40 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-15
13:46:32 UTC ---
(In reply to comment #39)
I agree with Kostya that no major changes to mach_override are necessary
because we are really going to dump it.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #41 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-15
13:51:11 UTC ---
I will also post a small patch to gcc-patches to allow darwin to automatically
pass the required linker flags on the link spec in darwin.h...
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #42 from Dominique d'Humieres dominiq at lps dot ens.fr
2012-11-15 15:03:53 UTC ---
Jack,
Thanks for the patch in comment #37. I had to do some minor surgery to adjust
it to revision 193528, but otherwise it worked as
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #43 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-15
15:12:31 UTC ---
Posted updated patch to adjust for bit-rot from the libsanitizer multilib
support checkin and add required spec handling to gcc/config/darwin.h.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #44 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-15
17:53:40 UTC ---
Posted the final revision of the patch that now properly handles static linkage
options with -faddress-sanitizer...
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #45 from Iain Sandoe iains at gcc dot gnu.org 2012-11-15 17:58:21
UTC ---
(In reply to comment #35)
Is that certain to be soon enough
Not 100%. I am just warning you.
apologies for not much input to this - somewhat tied
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #46 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-15
18:28:44 UTC ---
(In reply to comment #45)
(In reply to comment #35)
Is that certain to be soon enough
Not 100%. I am just warning you.
apologies for
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #47 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-15
19:09:00 UTC ---
(In reply to comment #46)
(In reply to comment #45)
(In reply to comment #35)
Is that certain to be soon enough
Not 100%. I am just
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #48 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-15
19:19:06 UTC ---
As proof that the current mach_override.h and mach_override.c from current
compiler-rt svn are reasonable to use for gcc 4.8.0, I compiled the
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #21 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
14:24:43 UTC ---
Patch posted at http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01116.html which
assumes the libsanitizer maintainers import
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #22 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
14:45:48 UTC ---
Revised patch posted at
http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01119.html.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #23 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
15:51:44 UTC ---
Created attachment 28683
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=28683
debug output from mach_override running use_after_free test
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #24 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
15:59:55 UTC ---
Created attachment 28684
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=28684
disassembled use-after-free.o from clang 3.2
Disassembled
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #25 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
16:02:03 UTC ---
Created attachment 28685
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=28685
disassembled use-after-free.o from gcc trunk
Disassembled
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #26 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
16:03:03 UTC ---
Created attachment 28686
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=28686
diff between disassembled use-after-free.o generated by clang
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #27 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
16:06:10 UTC ---
The error in mach_override.c occurs for the use-after-free.c test case at...
Replacing function at 0x1119ef630
First 16 bytes of the function:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
Alexander Potapenko glider at google dot com changed:
What|Removed |Added
CC|
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #29 from Alexander Potapenko glider at google dot com 2012-11-14
16:40:53 UTC ---
Index: mach_override.c
===
--- mach_override.c(revision 167724)
+++
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #30 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
16:54:06 UTC ---
(In reply to comment #29)
Thanks with the patch applied from comment 29, now the use-after-free testcase
works without errors...
howarth%
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #31 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
19:10:15 UTC ---
Also fine on i386-apple-darwin10...
howarth% ./use-after-free
=
==82550==
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #32 from Konstantin Serebryany konstantin.s.serebryany at gmail
dot com 2012-11-14 20:21:19 UTC ---
Just want to repeat, that any work on mach_override may end up being wasted
time
because we plan to get rid of mach_override
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #33 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
20:56:50 UTC ---
(In reply to comment #32)
Just want to repeat, that any work on mach_override may end up being wasted
time
because we plan to get rid of
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #34 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
22:09:37 UTC ---
(In reply to comment #32)
Just want to repeat, that any work on mach_override may end up being wasted
time
because we plan to get rid of
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #35 from Konstantin Serebryany konstantin.s.serebryany at gmail
dot com 2012-11-14 23:10:00 UTC ---
Is that certain to be soon enough
Not 100%. I am just warning you.
Will the replacement of mach_override also depend on
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #36 from Dominique d'Humieres dominiq at lps dot ens.fr
2012-11-14 23:49:25 UTC ---
Jack,
Could you please post a patch with the regenerated files. I have lost my
struggle with the auto* versions and I am giving up.
TIA
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #37 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-15
02:06:45 UTC ---
Created attachment 28692
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=28692
revised patch with regenerated files and proposed darwin.h link
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #38 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-15
02:10:33 UTC ---
(In reply to comment #35)
Is that certain to be soon enough
Not 100%. I am just warning you.
Considering that the release schedule for
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #3 from Dominique d'Humieres dominiq at lps dot ens.fr 2012-11-13
13:23:28 UTC ---
You can find these files in..
http://llvm.org/svn/llvm-project/compiler-rt/branches/release_32/lib/interception/mach_override/
With this
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #4 from Iain Sandoe iains at gcc dot gnu.org 2012-11-13 13:54:52
UTC ---
(In reply to comment #3)
You can find these files in..
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #5 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-13
14:06:46 UTC ---
(In reply to comment #4)
(In reply to comment #3)
dyld: Symbol not found: _CFStringCreateCopy
this is found in the CoreFoundation
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #6 from Dominique d'Humieres dominiq at lps dot ens.fr 2012-11-13
14:10:36 UTC ---
what you need is to have -framework CoreFoundation on the link line - and I
guess the configury c. needs to arrange this.
When compiled
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #7 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-13
14:29:57 UTC ---
(In reply to comment #6)
what you need is to have -framework CoreFoundation on the link line - and
I
guess the configury c. needs to
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #8 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-13
14:39:00 UTC ---
Iain,
This brings up the sticky situation of having to modify the Makefile.am
file in libsanitizer/interception to add
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #9 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-13
19:50:20 UTC ---
Created attachment 28676
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=28676
hack to build asan support
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #10 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-13
19:52:35 UTC ---
The attached patch (with configure and Makefile.in regenerated) allows the asan
support to build on x86_64-apple-darwin12. It still isn't
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #11 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-13
20:13:18 UTC ---
For the simple test case...
int main()
{
int i;
i=5;
}
compiled with 'g++-fsf-4.8 -faddress-sanitizer -O0 -framework CoreFoundation
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #12 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-13
20:21:35 UTC ---
The disasembled testcase that is choking on shows...
test.o: file format mach-o-x86-64
Disassembly of section .text:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #13 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-13
20:25:45 UTC ---
Also note the comment in mach_override.c...
#elif defined(__x86_64__)
// TODO(glider): disassembling the 0x48, 0x89 sequences is trickier than
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #14 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-13
20:50:37 UTC ---
Actually, this appears to be just noise on the output from a functional
libasan. If I use the testcase from
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
Konstantin Serebryany konstantin.s.serebryany at gmail dot com changed:
What|Removed |Added
CC|
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
Jack Howarth howarth at nitro dot med.uc.edu changed:
What|Removed |Added
Attachment #28676|0 |1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #17 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-13
22:14:10 UTC ---
(In reply to comment #16)
Created attachment 28677 [details]
prototype patch for adding darwin asan support
Note that you need to run...
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #18 from Dominique d'Humieres dominiq at lps dot ens.fr
2012-11-13 23:21:35 UTC ---
prototype patch for adding darwin asan support
Already updated;-(
- x86_64-*-linux-* | i?86-*-linux-*)
+ x86_64-*-linux-* |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
Jack Howarth howarth at nitro dot med.uc.edu changed:
What|Removed |Added
Attachment #28677|0 |1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #20 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-14
01:30:13 UTC ---
Revised patch builds at r193494 after...
cd libsanitizer
autoconf -I. -I../config
automake-1.11
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
Jack Howarth howarth at nitro dot med.uc.edu changed:
What|Removed |Added
Target|
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
Dominique d'Humieres dominiq at lps dot ens.fr changed:
What|Removed |Added
Status|UNCONFIRMED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55289
--- Comment #2 from Jack Howarth howarth at nitro dot med.uc.edu 2012-11-13
00:46:54 UTC ---
(In reply to comment #1)
Manually adding the libsanitizer/interception/mach_override directory from
the llvm
compiler-rt 3.2 branch
49 matches
Mail list logo
