Re: [C PATCH] Diagnose predefined identifiers in pedantic mode

2014-08-11 Thread Marek Polacek
On Tue, Aug 12, 2014 at 08:17:15AM +0200, Dodji Seketeli wrote: > Marek Polacek a écrit: > > > > diff --git gcc/testsuite/gcc.dg/concat.c gcc/testsuite/gcc.dg/concat.c > > index 0b9d6f6..e3bfd46 100644 > > --- gcc/testsuite/gcc.dg/concat.c > > +++ gcc/testsuite/gcc.dg/concat.c > > @@ -1,6 +1,7 @

Re: [PATCH, i386] Remove use of vpmacsdql instruction from multiplication.

2014-08-11 Thread Uros Bizjak
On Tue, Aug 12, 2014 at 7:23 AM, Gopalasubramanian, Ganesh wrote: >> > +2014-06-10 Ganesh Gopalasubramanian >> > + >> > + >> > + * config/i386/i386.c (ix86_expand_sse2_mulvxdi3): Issue >> > +instructions "vpmuludq" and "vpaddq" instead of "vpmacsdql" for >> > +handling 32-bit multiplicatio

Re: [C PATCH] Diagnose predefined identifiers in pedantic mode

2014-08-11 Thread Dodji Seketeli
Marek Polacek a écrit: > diff --git gcc/testsuite/gcc.dg/concat.c gcc/testsuite/gcc.dg/concat.c > index 0b9d6f6..e3bfd46 100644 > --- gcc/testsuite/gcc.dg/concat.c > +++ gcc/testsuite/gcc.dg/concat.c > @@ -1,6 +1,7 @@ > /* Copyright (C) 2001 Free Software Foundation, Inc. */ > > /* { dg-do

Re: [GSoC] the separate option for all dimensions

2014-08-11 Thread Roman Gareev
> Checking for this specific AST may cause failures with future versions of > isl that choose a different schedule. Could you write a regular expression > that checks that there is no if-condition contained in a for loop? I think > this best models the issue that was addressed in the original bug r

Re: [PATCH, ARM] Keep constants in register when expanding

2014-08-11 Thread Zhenqiang Chen
On 11 August 2014 19:14, Ramana Radhakrishnan wrote: > On Mon, Aug 11, 2014 at 3:35 AM, Zhenqiang Chen > wrote: >> On 8 August 2014 23:22, Ramana Radhakrishnan >> wrote: >>> On Tue, Aug 5, 2014 at 10:31 AM, Zhenqiang Chen >>> wrote: Hi, For some large constants, ARM will split t

RE: [PATCH, i386] Remove use of vpmacsdql instruction from multiplication.

2014-08-11 Thread Gopalasubramanian, Ganesh
Hi Uros! > > +2014-06-10 Ganesh Gopalasubramanian > > + > > + > > + * config/i386/i386.c (ix86_expand_sse2_mulvxdi3): Issue > > +instructions "vpmuludq" and "vpaddq" instead of "vpmacsdql" for > > +handling 32-bit multiplication. > > > OK for mainline and release branches. I would like

Re: RFC: PATCH to allow passing non-trivial types through ...

2014-08-11 Thread Nathan Sidwell
On 08/11/14 14:02, Jason Merrill wrote: A customer was recently complaining about G++ rejecting code that tries to pass a type with a non-trivial copy constructor through ..., which is undefined in C++98 and conditionally-supported in C++11. In GCC 3.1 and below we gave a warning and then did a

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-11 Thread Chen Gang
On 8/12/14 7:38, Mike Stump wrote: > On Aug 11, 2014, at 2:27 PM, Chen Gang wrote: >> Welcome additional disccusions or completions, and if no any additional >> reply within 1 week, I shall send patch v2 for it (still use sprintf). > > So, my take is it is easier for a maintainer to re-review i

Re: PR tree-optimization/52904 testcase

2014-08-11 Thread Kugan
On 11/08/14 18:03, Richard Biener wrote: > On Sat, Aug 9, 2014 at 2:33 PM, Kugan > wrote: >> Hi, >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52904 >> >> Tescase was generating warning: assuming signed overflow does not occur >> when simplifying conditional to constant [-Wstrict-overflow]

[PING v2][Patch]Fix ICE for gcc.dg/noncompile/920507-1.c

2014-08-11 Thread Tony Wang
Ping 2, and pasted my observation about this ICE, and may someone can help? The main cause for the ICE is in the function symtab_get_node: gcc_checking_assert (TREE_CODE (decl) == FUNCTION_DECL || (TREE_CODE (decl) == VAR_DECL && (TREE_STATIC (d

Re: [testsuite patch] add __ARM_ARCH check for arm_v8_neon_ok

2014-08-11 Thread Mike Stump
On Aug 11, 2014, at 3:01 PM, Janis Johnson wrote: > The check for effective target arm_v8_neon_ok passes even if __ARM_ARCH > is not 8 or greater, but then some tests fail because intrinsic functions > used in the test have not been declared. This patch requires that > __ARM_ARCH be 8 or greater.

[patch,gomp4] make fortran loop variables implicitly private in openacc

2014-08-11 Thread Cesar Philippidis
According to section 2.6.1 in the openacc spec, fortran loop variables should be implicitly private like in openmp. This patch does just so. Also, while working on this patch, I noticed that I made the check for variables appearing in multiple openacc clauses too strict. A private variable may also

Fwd: [testsuite patch] fix ARM tests with options that conflict with thumb1

2014-08-11 Thread Mike Stump
[ dup, sorry ] On Aug 11, 2014, at 2:58 PM, Janis Johnson wrote: > Two tests in gcc.target/arm add options that conflict with thumb1 > multilib flags; skip them. Tested with arm-none-linux-gnu for mainline > and 4.9 for a variety of multilib flags. > > OK for mainline and 4.9 branch? So, my ta

Re: [testsuite patch] don't add ARM options for a thumb1 multilib

2014-08-11 Thread Mike Stump
On Aug 11, 2014, at 3:00 PM, Janis Johnson wrote: > Test gcc.dg/pr59418.c adds ARM-specific options for an ARM target, but > those options conflict with flags for a thumb1 multilib. Don't add > the extra ARM flags for a thumb1 multilib. Tested with arm-none-linux-gnu > for mainline and 4.9 with

Re: [testsuite patch] fix ARM tests with options that conflict with thumb1

2014-08-11 Thread Mike Stump
On Aug 11, 2014, at 2:58 PM, Janis Johnson wrote: > Two tests in gcc.target/arm add options that conflict with thumb1 > multilib flags; skip them. Tested with arm-none-linux-gnu for mainline > and 4.9 for a variety of multilib flags. > > OK for mainline and 4.9 branch? So, my take is you can se

Re: [testsuite patch] skip an ARM run test if not using neon hardware

2014-08-11 Thread Mike Stump
On Aug 11, 2014, at 2:59 PM, Janis Johnson wrote: > Test gcc.target/arm/neon-vext-execute.c checks that the compiler can > generate neon instructions, but it should also check that the test will > be run using hardware that supports neon, which this patch adds. > Tested with arm-none-linux-gnu for

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-11 Thread Mike Stump
On Aug 11, 2014, at 2:27 PM, Chen Gang wrote: > Welcome additional disccusions or completions, and if no any additional > reply within 1 week, I shall send patch v2 for it (still use sprintf). So, my take is it is easier for a maintainer to re-review if you do it without additional delay. I’d r

Re: RFC: PATCH to allow passing non-trivial types through ...

2014-08-11 Thread Mike Stump
On Aug 11, 2014, at 2:02 PM, Jason Merrill wrote: > > On considering the request, it occurred to me that we could handle variadic > arguments of non-trivial types the same way we handle normal value arguments > of such types: pass by invisible reference. So this patch implements that. > Sinc

[GSoC][match-and-simplify] Add abs_expr pattern

2014-08-11 Thread Prathamesh Kulkarni
Add pattern: abs (abs (x)) -> abs (x) * match.pd: Add new pattern. [gcc/testsuite/gcc.dg/tree-ssa] * match.c: New test-case. Thanks, Prathamesh Index: gcc/match.pd === --- gcc/match.pd (revision 213814) +++ gcc/match.pd (working cop

Re: [PATCH] Drop user_defined_section_attribute, directly check DECL_SECTION_NAME instead

2014-08-11 Thread Yi Yang
Sorry, it is a typo :( Patch v2: -- 2014-08-11 Yi Yang gcc: * bb-reorder.c (pass_partition_blocks::gate): Replace check. * c-family/c-common.c (handle_section_attribute): Remove user_defined_section_attribute * final.c (rest_of_handle_final): ditto * toplev.c (user_defined_se

[testsuite patch] add __ARM_ARCH check for arm_v8_neon_ok

2014-08-11 Thread Janis Johnson
The check for effective target arm_v8_neon_ok passes even if __ARM_ARCH is not 8 or greater, but then some tests fail because intrinsic functions used in the test have not been declared. This patch requires that __ARM_ARCH be 8 or greater. Tested for arm-none-linux-gnu for mainline and 4.9 with a

[testsuite patch] don't add ARM options for a thumb1 multilib

2014-08-11 Thread Janis Johnson
Test gcc.dg/pr59418.c adds ARM-specific options for an ARM target, but those options conflict with flags for a thumb1 multilib. Don't add the extra ARM flags for a thumb1 multilib. Tested with arm-none-linux-gnu for mainline and 4.9 with a variety of multilib flags. OK for mainline and the 4.9 b

[testsuite patch] skip an ARM run test if not using neon hardware

2014-08-11 Thread Janis Johnson
Test gcc.target/arm/neon-vext-execute.c checks that the compiler can generate neon instructions, but it should also check that the test will be run using hardware that supports neon, which this patch adds. Tested with arm-none-linux-gnu for mainline and 4.9 with a variety of multilib flags. OK for

[testsuite patch] fix ARM tests with options that conflict with thumb1

2014-08-11 Thread Janis Johnson
Two tests in gcc.target/arm add options that conflict with thumb1 multilib flags; skip them. Tested with arm-none-linux-gnu for mainline and 4.9 for a variety of multilib flags. OK for mainline and 4.9 branch? Janis 2014-08-11 Janis Johnson * gcc.target/arm/pr48784.c: Skip for thumb1

Re: [PATCH 1/3] gcc/ada/s-osinte-rtems.adb: Correct formatting of comment

2014-08-11 Thread Joel Sherrill
Thanks. This is committed. I leaned toward obvious as well but figured I already had two patches that needed a review, so why not. :) On 8/11/2014 3:05 PM, Arnaud Charlet wrote: >> This patch is needed to make Ada compile for *-*-rtems* >> on GCC 4.8, 4.9, and the head. Is is ok to commit? > Yes.

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-11 Thread Chen Gang
On 08/12/2014 04:25 AM, Joseph S. Myers wrote: > On Sun, 10 Aug 2014, Chen Gang wrote: > >> For "[%d]" in sprintf(), theoretically, the maximize size is 14 -- for >> 0x8000, it is sizeof("[-2147483648]"). Normally, it may not cause >> real world bug, but if another issues occur, it may lead th

Re: [PATCH 3/3] gcc/ada/socket.c: Add conditionals for RTEMS

2014-08-11 Thread Joel Sherrill
On 8/11/2014 3:09 PM, Arnaud Charlet wrote: >>> This patch is needed to make Ada compile for *-*-rtems* >>> on GCC 4.8, 4.9, and the head. Is is ok to commit? >> OK. > Actually, these includes should go in gsocket.h, as done on other targets, > which also answers your previous question. Where do y

RFC: PATCH to allow passing non-trivial types through ...

2014-08-11 Thread Jason Merrill
A customer was recently complaining about G++ rejecting code that tries to pass a type with a non-trivial copy constructor through ..., which is undefined in C++98 and conditionally-supported in C++11. In GCC 3.1 and below we gave a warning and then did a bitwise copy. From GCC 3.2 to 4.4 we

Re: [PATCH] Drop user_defined_section_attribute, directly check DECL_SECTION_NAME instead

2014-08-11 Thread H.J. Lu
On Mon, Aug 11, 2014 at 1:41 PM, Yi Yang wrote: > Replace checking user_defined_section_attribute with directly checking > DECL_SECTION_NAME. The former does not work in the presence of IPA. > > See also: discussion on the same patch in Google branch: > https://gcc.gnu.org/ml/gcc-patches/2014-08/m

Re: [GOOGLE] Do not partition the cold/hot sections of a function with "section" attribute

2014-08-11 Thread Yi Yang
I ported this to trunk. Shall I commit this patch to the Google 4_8/4_9 branches first? On Mon, Aug 11, 2014 at 12:46 PM, Teresa Johnson wrote: > Ok, thanks. This seems reasonable. Can you send the patch to trunk as well? > Teresa > > On Mon, Aug 11, 2014 at 12:35 PM, Yi Yang wrote: >> Patch v2

[PATCH] Drop user_defined_section_attribute, directly check DECL_SECTION_NAME instead

2014-08-11 Thread Yi Yang
Replace checking user_defined_section_attribute with directly checking DECL_SECTION_NAME. The former does not work in the presence of IPA. See also: discussion on the same patch in Google branch: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg00749.html -- 2014-08-11 Yi Yang gcc: * bb-reo

Re: [C PATCH] Tidy up pedwarn_c90

2014-08-11 Thread Marek Polacek
On Mon, Aug 11, 2014 at 08:19:52PM +, Joseph S. Myers wrote: > On Sat, 9 Aug 2014, Marek Polacek wrote: > > > + /* Maybe we want to issue the C90/C99 compat warning, which is more > > + specific than -pedantic. */ > > + if (warn_c90_c99_compat > 0) > > { > >diagnostic_set_i

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-11 Thread Joseph S. Myers
On Sun, 10 Aug 2014, Chen Gang wrote: > For "[%d]" in sprintf(), theoretically, the maximize size is 14 -- for > 0x8000, it is sizeof("[-2147483648]"). Normally, it may not cause > real world bug, but if another issues occur, it may lead things worse. Negative values certainly don't make sens

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

2014-08-11 Thread Chen Gang
On 08/10/2014 04:22 PM, Chen Gang wrote: > > I guess, I find the root cause: > Although I say "I guess", in fact, I already had related proofs for it. - When configure "libjava/classpath", "--disable-core-jni" is passed as parameter explicitly (can check "x86_64-.../libjava/classpatch/ c

Re: [C PATCH] Tidy up pedwarn_c90

2014-08-11 Thread Joseph S. Myers
On Sat, 9 Aug 2014, Marek Polacek wrote: > + /* Maybe we want to issue the C90/C99 compat warning, which is more > + specific than -pedantic. */ > + if (warn_c90_c99_compat > 0) > { >diagnostic_set_info (&diagnostic, gmsgid, &ap, location, DK_WARNING); That seems wrong; it mea

Re: [PATCH 3/3] gcc/ada/socket.c: Add conditionals for RTEMS

2014-08-11 Thread Arnaud Charlet
> > This patch is needed to make Ada compile for *-*-rtems* > > on GCC 4.8, 4.9, and the head. Is is ok to commit? > > OK. Actually, these includes should go in gsocket.h, as done on other targets, which also answers your previous question. Can you please repost an updated patch for review? Arn

Re: [PATCH 3/3] gcc/ada/socket.c: Add conditionals for RTEMS

2014-08-11 Thread Arnaud Charlet
> This patch is needed to make Ada compile for *-*-rtems* > on GCC 4.8, 4.9, and the head. Is is ok to commit? OK. > 2014-08-11 Joel Sherrill > > * socket.c: Add conditionals for RTEMS. Add include of > and so correct prototype of gethostbyname_r() is used.

Re: [PATCH 1/3] gcc/ada/s-osinte-rtems.adb: Correct formatting of comment

2014-08-11 Thread Arnaud Charlet
> This patch is needed to make Ada compile for *-*-rtems* > on GCC 4.8, 4.9, and the head. Is is ok to commit? Yes. This one even falls under the obvious category IMO. > 2014-08-11 Joel Sherrill > > * s-osinte-rtems.adb: Correct formatting of line in license block.

Re: [committed] Use branch with link register for jump from thunk

2014-08-11 Thread John David Anglin
On 11-Aug-14, at 3:24 PM, John David Anglin wrote: Tested on hppa-unknown-linux-gnu, hppa2.0w-hp-hpux11.11 and hppa64- hp-hpux11.11 with no observed regressions. Committed to trunk, 4.9 and 4.8. There is a problem... Patch reverted. Dave -- John David Anglin dave.ang...@bell.net

Re: [PATCH], rs6000 cleanup, make constraints tighter

2014-08-11 Thread Michael Meissner
This is the patch I checked in as subversion id 213834. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.vnet.ibm.com, phone: +1 (978) 899-4797 Index: gcc/config/rs6000/constraints.md

Re: [GOOGLE] Do not partition the cold/hot sections of a function with "section" attribute

2014-08-11 Thread Teresa Johnson
Ok, thanks. This seems reasonable. Can you send the patch to trunk as well? Teresa On Mon, Aug 11, 2014 at 12:35 PM, Yi Yang wrote: > Patch v2 > > .. > > diff --git gcc/bb-reorder.c gcc/bb-reorder.c > index fa6f62f..a1b3e65 100644 > --- gcc/bb-reorder.c > +++ gcc/bb-reorder.c > @@ -95,7 +95,6 @@

Re: [GOOGLE] Do not partition the cold/hot sections of a function with "section" attribute

2014-08-11 Thread Yi Yang
Patch v2 .. diff --git gcc/bb-reorder.c gcc/bb-reorder.c index fa6f62f..a1b3e65 100644 --- gcc/bb-reorder.c +++ gcc/bb-reorder.c @@ -95,7 +95,6 @@ #include "expr.h" #include "params.h" #include "diagnostic-core.h" -#include "toplev.h" /* user_defined_section_attribute */ #include "tree-pass.h

Go patch committed: comma-ok assignments used untyped bool

2014-08-11 Thread Ian Lance Taylor
The Go language was changed slightly so that comma-ok assignments now return the ok value as an untyped boolean value rather than as the named type "bool". The effect of this is that programs can use an existing variable of a boolean type that is not actually "bool". This patch by Chris Manghane

[committed] Use branch with link register for jump from thunk

2014-08-11 Thread John David Anglin
With a large function, the 'b' branch may not be able to reach its target without a long branch stub. Gas doesn't provide a long branch stub for a branch without a link register (i.e., it considers branches with link registers calls). This patch changes pa_asm_output_mi_thunk() to use a bl br

Re: [GOOGLE] Do not partition the cold/hot sections of a function with "section" attribute

2014-08-11 Thread Yi Yang
Thanks for pointing out this! It seems to me that this user_defined_section_attribute variable is useless now and should be removed. It is intended to work in this way: for each function { parse into tree (setting user_defined_section_attribute) do tree passes do RTL passes (using user_d

Re: [PATCH i386 AVX512] [4/n] Add new way of generating all 0/1 vector.

2014-08-11 Thread Uros Bizjak
On Mon, Aug 11, 2014 at 3:06 PM, Kirill Yukhin wrote: > On 11 Aug 13:51, Jakub Jelinek wrote: >> On Mon, Aug 11, 2014 at 03:47:07PM +0400, Kirill Yukhin wrote: >> > @@ -9020,7 +9025,8 @@ standard_sse_constant_opcode (rtx insn, rtx x) >> > } >> > >> > case 2: >> > - if (get_attr_mode

Re: [PATCH] Demangler fuzzer

2014-08-11 Thread Mike Stump
On Aug 11, 2014, at 10:57 AM, Jakub Jelinek wrote: > >> + if (timeout != -1) >> +{ >> + signal (SIGALRM, alarm_handler); >> + alarm (timeout); >> +} > > Not sure how much portable signal/alarm is. So probably should be guarded > by the existence of signal.h, SIGALRM being def

Re: [RFC/Patch] Latent issue in cp_parser_template_id

2014-08-11 Thread Jason Merrill
OK with a comment explaining how we can get there. Jason

Re: [PATCH 3/3] gcc/ada/socket.c: Add conditionals for RTEMS

2014-08-11 Thread Joel Sherrill
On 8/11/2014 1:15 PM, Mike Stump wrote: > On Aug 11, 2014, at 8:08 AM, Joel Sherrill wrote: >> +#if defined(__rtems__) >> +#include >> +/* Required, for read(), write(), and close() */ >> +#endif > Strikes me as exceptionally odd. Should be done unconditionally, and any > system that doesn’t l

Re: [PATCH 3/3] gcc/ada/socket.c: Add conditionals for RTEMS

2014-08-11 Thread Mike Stump
On Aug 11, 2014, at 8:08 AM, Joel Sherrill wrote: > +#if defined(__rtems__) > +#include > +/* Required, for read(), write(), and close() */ > +#endif Strikes me as exceptionally odd. Should be done unconditionally, and any system that doesn’t like that should be the odd ball.

[RFC/Patch] Latent issue in cp_parser_template_id

2014-08-11 Thread Paolo Carlini
Hi, while working on a patchlet for the simple c++/54377 I noticed a latent issue, which goes normally unnoticed because template/typename17.c uses the catch all dg-error "". The issue is that, whereas for C++98 we give a sensible error message, for C++11 only the late "last resort" check in

[jit] Add a multithreaded test case.

2014-08-11 Thread David Malcolm
Committed and pushed to branch dmalcolm/jit: gcc/testsuite/ * jit.dg/test-threads.c: New test case, running all of the individual test cases in separate threads. * jit.dg/test-combination.c: Move inclusion of the various individual testcases into... * jit.dg

Re: [PATCH] Demangler fuzzer

2014-08-11 Thread Jakub Jelinek
On Mon, Aug 11, 2014 at 05:04:20PM +0100, Gary Benson wrote: > + case 's': > + seed = atoi (optarg); > + break; > + > + case 't': > + timeout = atoi (optarg); > + break; > + > + case 'm': > + maxcount = atoi (optarg); > + break; > + } > +} > +

Re: [PATCH][AArch64][tests]Skip graphite tests that don't fit -mcmodel=tiny

2014-08-11 Thread Mike Stump
On Aug 11, 2014, at 2:06 AM, Richard Earnshaw wrote: > Not quite, read the subject line again. Doh. I did miss that entirely. The solutions I gave were for other cases than the case at hand. > I'm not sure what the correct change to the testsuite is here. The below is close, let me refine it

[c++-concepts] substitution fixes

2014-08-11 Thread Andrew Sutton
Fixing some bugs substituting through constraints. In particular, when diagnosing an error, make sure that we use the right arguments. There was also a bug caused by substitution through a decltype-type. In particular, when folding a non-dependent expression containing a decltype-type, the inner t

Re: [PATCH] Keep patch file permissions in mklog

2014-08-11 Thread Segher Boessenkool
On Mon, Aug 11, 2014 at 11:10:59AM +0200, Tom de Vries wrote: > +use File::Temp; > +use File::Copy qw(cp mv); > + # Copy the permissions to the temp file (in perl 2.15 and later). > + cp $diff, $tmp or die "Could not copy patch file to temp file: $!"; That's File::Copy 2.15, not Perl 2.15

Re: [C++ PATCH] Improve location info [1/many]

2014-08-11 Thread Jason Merrill
On 08/01/2014 07:59 AM, Marek Polacek wrote: Thanks for taking this on, sorry it's taken so long to respond. +convert_like_real (location_t loc, conversion *convs, tree expr, tree fn, + int argnum, int inner, bool issue_conversion_warnings, bool c_cast_p, tsu

Re: [PATCH], rs6000 cleanup, make constraints tighter

2014-08-11 Thread Michael Meissner
On Fri, Aug 08, 2014 at 03:31:48PM -0400, David Edelsohn wrote: > Okay. > > Note that you or Carrot will have to be careful about the merge of > movdi_internal64 as both of your patches affect that pattern. Carrot has checked in his patch, and I will adapt my patch (and replace the constraint wm

[C PATCH] Implement -Wc99-c11-compat

2014-08-11 Thread Marek Polacek
Now that the -Wc90-c99-compat warning is in, the next step was to implement the -Wc99-c11-compat warning, which is what this patch is about. Luckily the implementation is quite straightforward, since there are no specialized options similar to -Wlong-long that should be taken into account - thus no

Re: [PATCH] Demangler fuzzer

2014-08-11 Thread Andi Kleen
Looks good. -Andi

Re: [PATCH] Demangler fuzzer

2014-08-11 Thread Gary Benson
David Malcolm wrote: > On Mon, 2014-08-11 at 08:06 -0700, Andi Kleen wrote: > > Gary Benson writes: > > > srand(time(NULL)); > > > > That's really bad, can never be reproduced. If you use a random > > seed like this you need to at least print it. > > How about taking the random seed and the num

Re: [PATCH] Demangler fuzzer

2014-08-11 Thread David Malcolm
On Mon, 2014-08-11 at 08:06 -0700, Andi Kleen wrote: > Gary Benson writes: > > >srand(time(NULL)); > > That's really bad, can never be reproduced. If you use a random seed > like this you need to at least print it. How about taking the random seed and the number of iterations as command-line a

[PATCH 3/3] gcc/ada/socket.c: Add conditionals for RTEMS

2014-08-11 Thread Joel Sherrill
This patch is needed to make Ada compile for *-*-rtems* on GCC 4.8, 4.9, and the head. Is is ok to commit? 2014-08-11 Joel Sherrill * socket.c: Add conditionals for RTEMS. Add include of and so correct prototype of gethostbyname_r() is used. --- gcc/ada/socket.c | 7 ++- 1

[PATCH 1/3] gcc/ada/s-osinte-rtems.adb: Correct formatting of comment

2014-08-11 Thread Joel Sherrill
This patch is needed to make Ada compile for *-*-rtems* on GCC 4.8, 4.9, and the head. Is is ok to commit? 2014-08-11 Joel Sherrill * s-osinte-rtems.adb: Correct formatting of line in license block. --- gcc/ada/s-osinte-rtems.adb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH 2/3] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-11 Thread Joel Sherrill
This patch is needed to make Ada compile for *-*-rtems* on GCC 4.8, 4.9, and the head. Is is ok to commit? 2014-08-11 Joel Sherrill * Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C. --- libada/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/li

Re: [PATCH] Demangler fuzzer

2014-08-11 Thread Andi Kleen
Gary Benson writes: >srand(time(NULL)); That's really bad, can never be reproduced. If you use a random seed like this you need to at least print it. -Andi -- a...@linux.intel.com -- Speaking for myself only

Re: [GOOGLE] Do not partition the cold/hot sections of a function with "section" attribute

2014-08-11 Thread Teresa Johnson
On Fri, Aug 8, 2014 at 3:22 PM, Yi Yang wrote: > Friendly ping. Sorry, was OOO. The solution of preventing splitting for named sections is good - but it looks like there is already code that should prevent this. See the user_defined_section_attribute check here - why is that not set? Looks like

Re: Fix side case in ipa-devirt

2014-08-11 Thread Rainer Orth
Hi Jan, > * g++.dg/ipa/devirt-37.C: New testcase. it seems something is very wrong with this testcase: initially, all scans FAILed because the dump file didn't exist. But even with -O2 added to dg-options, the failures remain because either the wording is different FAIL: g++.dg/ipa/devirt

[PATCH] Fix PR62075

2014-08-11 Thread Richard Biener
The following fixes SLP pure/hybrid detection with patterns. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk sofar. Richard. 2014-08-11 Richard Biener PR tree-optimization/62075 * tree-vect-slp.c (vect_detect_hybrid_slp_stmts): Properly handle u

Re: [PATCH] Demangler fuzzer

2014-08-11 Thread Gary Benson
Jakub Jelinek wrote: > On Mon, Aug 11, 2014 at 10:27:03AM +0100, Gary Benson wrote: > > This patch adds a simple fuzzer for the libiberty C++ demangler. > > You can run it like this: > > > > make -C /path/to/build/libiberty/testsuite fuzz-demangler > > > > It will run until it dumps core (usual

Re: [GSoC] Elimination of CLooG library installation dependency

2014-08-11 Thread Roman Gareev
> Did you try your code with 64bit pointer types? Yes. It seems that the result is the same. > In any case, I don't think it is worth spending time on this. I would check > in the scop detection that we disable the handling of unsigned and pointer > types. It is a complex thing to model and the a

Re: [PATCH] PR preprocessor/61817 - Fix location of tokens in built-in macro expansion list

2014-08-11 Thread Dodji Seketeli
Hello, I have initially sent a patch for this at https://gcc.gnu.org/ml/gcc-patches/2014-07/msg01144.html. But then a patch for a similarly expressed issue https://gcc.gnu.org/ml/gcc-patches/2014-07/msg01521.html (which I think is the same underlying problem) was committed. As the PR preprocesso

[PATCH] fix hardreg_cprop to honor HARD_REGNO_MODE_OK.

2014-08-11 Thread Ilya Tocar
Hi, I've observed SPEC2006 failure on avx512-vlbwdq branch. It was caused by hardreg_cprop. In maybe_mode_change it was assumed, that all values of the same register class and same mode. are ok. This is not the case for i386/avx512. We need to honor HARD_REGNO_MODE_OK. Patch bellow does it. Ok fo

Re: [PATCH i386 AVX512] [4/n] Add new way of generating all 0/1 vector.

2014-08-11 Thread Kirill Yukhin
On 11 Aug 13:51, Jakub Jelinek wrote: > On Mon, Aug 11, 2014 at 03:47:07PM +0400, Kirill Yukhin wrote: > > @@ -9020,7 +9025,8 @@ standard_sse_constant_opcode (rtx insn, rtx x) > > } > > > > case 2: > > - if (get_attr_mode (insn) == MODE_XI > > + if (TARGET_AVX512VL > > + ||

Re: [PATCH] Fix incorrect folding of bitfield in a union on big endian target

2014-08-11 Thread Richard Biener
On Mon, Aug 11, 2014 at 9:36 AM, Thomas Preud'homme wrote: > In the code dealing with folding of structure and union initialization, there > is a > check that the size of the constructor is the same as the field being read. > However, in the case of bitfield this test can be wrong because it reli

Re: [PATCH i386 AVX512] [4/n] Add new way of generating all 0/1 vector.

2014-08-11 Thread Jakub Jelinek
On Mon, Aug 11, 2014 at 03:47:07PM +0400, Kirill Yukhin wrote: > @@ -9020,7 +9025,8 @@ standard_sse_constant_opcode (rtx insn, rtx x) > } > > case 2: > - if (get_attr_mode (insn) == MODE_XI > + if (TARGET_AVX512VL > + ||get_attr_mode (insn) == MODE_XI Formatting, add s

[PATCH i386 AVX512] [4/n] Add new way of generating all 0/1 vector.

2014-08-11 Thread Kirill Yukhin
Hello, This patch introduces new way of generating all-0 and all-1 vectors. Boostrapped. Is it ok for trunk? gcc/ * config/i386/i386.c (standard_sse_constant_opcode): Use vpxord/vpternlog if avx512 is availible. -- Thanks, K diff --git a/gcc/config/i386/i386.c b/gcc/config/i3

Re: [PATCH] Fix incorrect folding of bitfield in a union on big endian target

2014-08-11 Thread Mikael Pettersson
Thomas Preud'homme writes: > In the code dealing with folding of structure and union initialization, > there is a > check that the size of the constructor is the same as the field being read. > However, in the case of bitfield this test can be wrong because it relies on > TYPE_SIZE to get the

Re: [PATCH] Fix for PR62037

2014-08-11 Thread Richard Biener
On Sat, Aug 9, 2014 at 6:28 AM, Felix Yang wrote: > Attached please find the patch and testcase for PR62037. > > DEF1 can be a GIMPLE_NOP and gimple_bb will be NULL then. The patch > checks for that. > Bootstrapped on x86_64-suse-linux. OK for trunk? Please commit this > patch if it's OK. > Thank

Re: [PATCH, ARM] Keep constants in register when expanding

2014-08-11 Thread Ramana Radhakrishnan
On Mon, Aug 11, 2014 at 3:35 AM, Zhenqiang Chen wrote: > On 8 August 2014 23:22, Ramana Radhakrishnan > wrote: >> On Tue, Aug 5, 2014 at 10:31 AM, Zhenqiang Chen >> wrote: >>> Hi, >>> >>> For some large constants, ARM will split them during expanding, which >>> makes impossible to hoist them ou

[PATCH] Fix PR62070

2014-08-11 Thread Richard Biener
The following finally removes the SSA checking code from the gimple_duplicate_loop_to_header_edge CFG hook. We've tamed it down previously and now there is predictive commoning that also doesn't get the chance to complete its work before that checking runs. Applied as obvious. Richard. 2014-08

Re: [PATCH, ARM] Fix incorrect alignment of small values in minipool

2014-08-11 Thread Richard Earnshaw
On 11/08/14 09:53, Richard Earnshaw wrote: > On 11/08/14 08:49, Thomas Preud'homme wrote: >> Being 32-bit wide in size, constant pool entries are always filled as 32-bit >> quantities. This works fine for little endian system but gives some incorrect >> results for big endian system when the value

Re: [PATCH] Demangler fuzzer

2014-08-11 Thread Jakub Jelinek
On Mon, Aug 11, 2014 at 10:27:03AM +0100, Gary Benson wrote: > This patch adds a simple fuzzer for the libiberty C++ demangler. > You can run it like this: > > make -C /path/to/build/libiberty/testsuite fuzz-demangler > > It will run until it dumps core (usually only a few seconds). > > Is thi

[PING ^ 2] [PATCH, ARM] Set max_insns_skipped to MAX_INSN_PER_IT_BLOCK when optimize_size for THUMB2

2014-08-11 Thread Zhenqiang Chen
Ping ^ 2? Thanks! -Zhenqiang > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Zhenqiang Chen > Sent: Tuesday, April 29, 2014 5:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Ramana Radhakrishnan > Subject: [PING] [PATCH, ARM] Set

[C++ Patch] Mini parser->scope related clean up

2014-08-11 Thread Paolo Carlini
Hi, I noticed that we can remove the scope parameter from two parser functions. Tested x86_64-linux. Thanks, Paolo. 2014-08-11 Paolo Carlini * parser.c (cp_parser_diagnose_invalid_type_name, cp_parser_make_typename_type): Remove scope parameter.

[PATCH] Demangler fuzzer

2014-08-11 Thread Gary Benson
Hi all, This patch adds a simple fuzzer for the libiberty C++ demangler. You can run it like this: make -C /path/to/build/libiberty/testsuite fuzz-demangler It will run until it dumps core (usually only a few seconds). Is this ok to commit? Thanks, Gary -- 2014-08-11 Gary Benson

Re: [PATCH][LTO] Streamer re-org (what's left)

2014-08-11 Thread Richard Biener
On Thu, 7 Aug 2014, Richard Biener wrote: > On Thu, 7 Aug 2014, Richard Biener wrote: > > > > > The following are the non-cleanup parts. The patch moves us > > to compress streams (what data-streamer thinks of "streams") > > instead of whole sections. This enables us to only need > > a single

Re: [PATCH] Keep patch file permissions in mklog

2014-08-11 Thread Tom de Vries
On 11-08-14 10:18, Yury Gribov wrote: On 08/11/2014 11:22 AM, Tom de Vries wrote: I'm now using mktemp from File::Temp. The script now relies on external Perl modules. This is probably fine because AFAIK File::Temp and File::Copy are available included in all distributions. +use File::Copy "c

Re: [PATCH][AArch64][tests]Skip graphite tests that don't fit -mcmodel=tiny

2014-08-11 Thread Richard Earnshaw
On 08/08/14 18:53, Mike Stump wrote: > On Aug 7, 2014, at 1:38 AM, Kyrill Tkachov wrote: >> >> Thanks for the detailed explanation, the linker errors I was seeing were >> about relocations being truncated. > > Ah, those are bugs in your port! You should be able to generate large code > and the

Re: [PATCH, ARM] Fix incorrect alignment of small values in minipool

2014-08-11 Thread Richard Earnshaw
On 11/08/14 08:49, Thomas Preud'homme wrote: > Being 32-bit wide in size, constant pool entries are always filled as 32-bit > quantities. This works fine for little endian system but gives some incorrect > results for big endian system when the value is *accessed* with a mode smaller > than 32-bit

Re: [PATCH] Keep patch file permissions in mklog

2014-08-11 Thread Yury Gribov
On 08/11/2014 11:22 AM, Tom de Vries wrote: +if ($#ARGV == 1 && ("$ARGV[0]" eq "-i" || "$ARGV[0]" eq "--inline")) { I'd do >= 1 but that's a question of personal preference. What is the purpose of that proposed change ? Kind of laying foundation for adding more flags in the future. But as I

Re: PR tree-optimization/52904 testcase

2014-08-11 Thread Richard Biener
On Sat, Aug 9, 2014 at 2:33 PM, Kugan wrote: > Hi, > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52904 > > Tescase was generating warning: assuming signed overflow does not occur > when simplifying conditional to constant [-Wstrict-overflow] due to VRP > missing the value range. > > This seems

[PATCH, ARM] Fix incorrect alignment of small values in minipool

2014-08-11 Thread Thomas Preud'homme
Being 32-bit wide in size, constant pool entries are always filled as 32-bit quantities. This works fine for little endian system but gives some incorrect results for big endian system when the value is *accessed* with a mode smaller than 32-bit in size. Suppose the case of the value 0x1234 that is

RE: [PATCH] Fix incorrect folding of bitfield in a union on big endian target

2014-08-11 Thread Thomas Preud'homme
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Thomas Preud'homme > > No regression were observed on any of the tests. The ChangeLog is as > follows: > > > 2014-08-11 Thomas Preud'homme > > * gimple-fold.c (fold_ctor_reference): Don't fold

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-08-11 Thread Sylvestre Ledru
On 31/07/2014 00:08, Joseph S. Myers wrote: > On Mon, 7 Jul 2014, Sylvestre Ledru wrote: > >> Hello, >> >> On 17/06/2014 19:41, Joseph S. Myers wrote: >>> On Tue, 17 Jun 2014, Sylvestre Ledru wrote: >>> OK. I will do that. We should test the following: * default => run just -Wreturn-

[PATCH] Fix incorrect folding of bitfield in a union on big endian target

2014-08-11 Thread Thomas Preud'homme
In the code dealing with folding of structure and union initialization, there is a check that the size of the constructor is the same as the field being read. However, in the case of bitfield this test can be wrong because it relies on TYPE_SIZE to get the size of the field being read but TYPE_SIZ

Re: [GSoC] Elimination of CLooG library installation dependency

2014-08-11 Thread Tobias Grosser
On 11/08/2014 09:11, Roman Gareev wrote: I am confused. It seems you attached some kind of reduced version of btCollisionWorld.cpp? How did you obtain it? Did you compile and test with these versions? I’ve manually selected parts of code, which produce the scope. I’ve found out that this bug i

Re: [PATCH] Keep patch file permissions in mklog

2014-08-11 Thread Tom de Vries
On 04-08-14 13:50, Yury Gribov wrote: > thanks for the review. Np, I'm personally happy to see that script is useful. > I've now interpreted it such that --inline prints to stdout what it > would print to the patch file otherwise, that is, both log and patch. > Printing just the log to stdo

Re: [PATCH testcase]Add bind_pic_locally to case addrtmp.c

2014-08-11 Thread Bin.Cheng
On Thu, Aug 7, 2014 at 5:54 PM, Bin.Cheng wrote: > On Thu, Aug 7, 2014 at 5:43 PM, Bin Cheng wrote: >> Hi, >> >> The case depends on GCC inlining of global function, but the callee won't be >> inlined because it's global function and considered over-writable during >> run-time. > It won't be inli

Re: [GSoC] Elimination of CLooG library installation dependency

2014-08-11 Thread Roman Gareev
> I am confused. It seems you attached some kind of reduced version of > btCollisionWorld.cpp? How did you obtain it? Did you compile and test > with these versions? I’ve manually selected parts of code, which produce the scope. I’ve found out that this bug is most probably caused by absence of p

  1   2   >