LWG2593 Move from allocator state is preserved

2019-05-15 Thread François Dumont
Hi     Let's apply this resolution first before moving forward with the std::deque implementation.     Move from state of allocators (LWG2593)     * include/bits/stl_deque.h     (_Deque_base(_Deque_base&&, false_type)): Remove.     (_Deque_base(_Deque_base&&, true_type)): Remove.    

Re: [PATCH] Remove redundant accessors in hash tables

2019-05-15 Thread François Dumont
On 5/15/19 5:37 PM, Jonathan Wakely wrote: François, I noticed that _Hash_code_base and _Hashtable_base have a number of member functions which are overloaded for const and non-const:    const _Equal&    _M_eq() const { return _EqualEBO::_S_cget(*this); }    _Equal&    _M_eq() { return

Go patch committed: Improve escape analysis on interface conversions

2019-05-15 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang improves escape analysis on interface conversions. If an interface does not escape, it doesn't need a heap allocation to hold the data (for non-direct interface type). This CL improves the escape analysis to track interface conversions, and reduces

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-15 Thread Kewen.Lin
on 2019/5/15 下午4:47, Richard Biener wrote: > On Wed, 15 May 2019, Kewen.Lin wrote: > >> on 2019/5/14 下午3:26, Richard Biener wrote: >>> On Tue, May 14, 2019 at 5:10 AM wrote: From: Kewen Lin Previous version link for background:

Re: [PATCH 2/2] aarch64 back-end changes

2019-05-15 Thread Kugan Vivekanandarajah
Hi Richard, On Wed, 15 May 2019 at 23:24, Richard Earnshaw (lists) wrote: > > On 15/05/2019 13:48, Richard Earnshaw (lists) wrote: > > On 15/05/2019 03:39, kugan.vivekanandara...@linaro.org wrote: > >> From: Kugan Vivekanandarajah > >> > > > > The subject line to this email is not helpful. Why

[PATCH 2/2] [PR88836][aarch64] Fix CSE to process parallel rtx dest one by one

2019-05-15 Thread kugan . vivekanandarajah
From: Kugan Vivekanandarajah This patch changes cse_insn to process parallel rtx one by one such that any destination rtx in cse list is invalidated before processing the next. gcc/ChangeLog: 2019-05-16 Kugan Vivekanandarajah PR target/88834 * cse.c (safe_hash): Handle

[PATCH 1/2] [PR88836][aarch64] Set CC_REGNUM instead of clobber

2019-05-15 Thread kugan . vivekanandarajah
From: Kugan Vivekanandarajah For aarch64 sve while_ult pattern, Set CC_REGNUM instead of clobbering. gcc/ChangeLog: 2019-05-16 Kugan Vivekanandarajah PR target/88834 * config/aarch64/aarch64-sve.md (while_ult): Set CC_REGNUM instead of clobbering. Change-Id:

[PATCH 0/2][RFC][PR88836][AARCH64] Fix redundant ptest instruction

2019-05-15 Thread kugan . vivekanandarajah
From: Kugan Vivekanandarajah Inorder to fix this PR. * We need to change the whilelo pattern in backend * Change RTL CSE such that: - Add support for VEC_DUPLICATE - When handling PARALLEL rtx in cse_insn, we kill CSE defined by all the parallel rtx at the end. For example, with

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-15 Thread Paul Koning
> On May 15, 2019, at 2:42 PM, Eric Gallager wrote: > >> ... > > Wasn't Eric S. Raymond working on his own conversion of the GCC repo > from SVN to Git? Whatever happened to his? Yes, and from what I recall he found that doing it fully correctly is an extremely hard task. It might be a

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-15 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: Unrecognized `gnatmake' switches are not implicitly passed on to the linker, so just pasting board `ldflags' and any other linker flags verbatim into `add_flags' to use for the invocation line of `gnatmake' will make them ignored at best. [...] For `gnatmake' to

Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation

2019-05-15 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: [...] --- gcc/testsuite/lib/gnat.exp |2 ++ 1 file changed, 2 insertions(+) gcc-test-gnat-options-ada.diff Index: gcc/gcc/testsuite/lib/gnat.exp === --- gcc.orig/gcc/testsuite/lib/gnat.exp +++

[PATCH] Fix PR90394, [10 Regression] ICE in is_value_included_in, at tree-ssa-uninit.c:1055

2019-05-15 Thread Vladislav Ivanishin
Hi! Here is a simple patch fixing the regression introduced in r270660. gcc/testsuite/ChangeLog: PR tree-optimization/90394 * gcc.dg/uninit-pr90394-1-gimple.c: New test. * gcc.dg/uninit-pr90394.c: New test. gcc/ChangeLog: PR tree-optimization/90394 * tree-ssa-uninit.c

[committed] Fix up pr90478.c testcase (was Re: [PATCH] Check for overflow in tree-switch-conversion (PR middle-end/90478).)

2019-05-15 Thread Jakub Jelinek
On Wed, May 15, 2019 at 12:20:42PM +0200, Martin Liška wrote: > 2019-05-15 Martin Liska > > PR middle-end/90478 > * tree-switch-conversion.c (jump_table_cluster::can_be_handled): > Check for overflow. > > gcc/testsuite/ChangeLog: > > 2019-05-15 Martin Liska > > PR

Re: [PATCH 1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics

2019-05-15 Thread Martin Sebor
On 5/15/19 8:50 AM, Martin Sebor wrote: On 5/15/19 5:40 AM, Martin Liška wrote: On 5/14/19 11:31 PM, Martin Sebor wrote: The attached patch implements the -Wformat-diag warning to help find quoting, spelling, and other formatting issues in diagnostics issued by GCC. Just a general comment

[PATCH] OpenMP simd if clause support with runtime determined argument

2019-05-15 Thread Jakub Jelinek
Hi! The following patch implements what I've failed to do in time for 9.x, in particular, if #pragma omp simd has if clause and the argument is not constant zero (handled by the previous patch), or constant non-zero (ignored, we want normal vectorization in that case as before), this patch

Re: [PATCH] gcc: move assemble_start_function / assemble_end_function to output_mi_thunk

2019-05-15 Thread Richard Sandiford
Max Filippov writes: > Let backends call assemble_start_function after they have generated > thunk function body so that a constant pool could be output if it is > required. This may help backends to avoid implementing custom constant > loading code specifically for the MI thunk and reuse

[committed] Small OpenMP simd if and simdlen clause tweak

2019-05-15 Thread Jakub Jelinek
Hi! If simdlen clause is specified, it is the preferred number of concurrent simd lanes in the loop, though if if clause is specified and evaluates to false, the preferred number of simd lanes is 1 (i.e. no vectorization). This patch handles just the easy part, when simdlen argument is 1 or when

Re: PING^1: [PATCH] i386: Add standard scalar operation patterns

2019-05-15 Thread Richard Sandiford
"H.J. Lu" writes: > On Thu, Feb 7, 2019 at 9:49 AM H.J. Lu wrote: >> >> Standard scalar operation patterns which preserve the rest of the vector >> look like >> >> (vec_merge:V2DF >>(vec_duplicate:V2DF >> (op:DF (vec_select:DF (reg/v:V2DF 85 [ x ]) >>

Re: [PATCH] Add __raw_visit and __raw_idx_visit, use INVOKE

2019-05-15 Thread Jonathan Wakely
On 14/05/19 17:46 +0100, Jonathan Wakely wrote: This change simplifies visitation for variants, by using INVOKE for the visit form, and explicitly specifying the tag types for raw visitation, instead of inferring them from the return types of the lambda functions used as visitors. An

Re: preserve more debug stmts in gimple jump threading

2019-05-15 Thread Alexandre Oliva
On May 15, 2019, Richard Biener wrote: > On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: >> >> Gimple jump threading does not duplicate forwarder blocks that might >> be present before or after the copied block. > Empty forwarder blocks I presume? Empty except for debug stmts and

Re: C++ PATCH for CWG 2096, constraints on literal unions

2019-05-15 Thread Jason Merrill
On 5/13/19 6:07 PM, Marek Polacek wrote: This patch implements CWG 2096 which relaxes the constraints for literal unions. [basic.types]/p10 now says: A type is a literal type if... -- it is a union, at least one of its non-static data members is of non-volatile literal type, [...]

Re: [C++ PATCH] Fix up C++ loop construct debug info without -gno-statement-frontiers (PR debug/90197, take 2)

2019-05-15 Thread Jason Merrill
On 5/10/19 7:14 PM, Jakub Jelinek wrote: On Fri, May 10, 2019 at 04:26:47PM -0400, Jason Merrill wrote: That is strange. That seems to go back to Surely we should only set the incr location if it doesn't already have one, as would have been the case before that patch. So, like this then?

Re: [PATCH] fortran: C++ support for generating C prototypes

2019-05-15 Thread Janne Blomqvist
On Wed, May 15, 2019 at 4:41 PM Jakub Jelinek wrote: > > On Sun, May 12, 2019 at 12:47:04AM +0300, Janne Blomqvist wrote: > > --- a/gcc/fortran/parse.c > > +++ b/gcc/fortran/parse.c > > @@ -6331,6 +6331,24 @@ done: > >} > > > >/* Dump C prototypes. */ > > + if (flag_c_prototypes ||

Re: [PATCH] Allow opening file on multiple units

2019-05-15 Thread Janne Blomqvist
On Wed, May 15, 2019 at 9:30 PM Damian Rouson wrote: > > Could someone please update the Fortran 2018 status page on the wiki > to reflect this patch? Thanks for the reminder, done. -- Janne Blomqvist

PING^1: [PATCH] i386: Add standard scalar operation patterns

2019-05-15 Thread H.J. Lu
On Thu, Feb 7, 2019 at 9:49 AM H.J. Lu wrote: > > Standard scalar operation patterns which preserve the rest of the vector > look like > > (vec_merge:V2DF >(vec_duplicate:V2DF > (op:DF (vec_select:DF (reg/v:V2DF 85 [ x ]) > (parallel [ (const_int 0 [0])])) >

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-15 Thread Segher Boessenkool
On Wed, May 15, 2019 at 11:34:34AM +0300, Maxim Kuvyrkov wrote: > > On May 15, 2019, at 12:20 AM, Segher Boessenkool > > wrote: > > On Tue, May 14, 2019 at 07:11:18PM +0300, Maxim Kuvyrkov wrote: > >> This patch adds scripts to contrib/ to migrate full history of GCC's > >> subversion repository

Re: PATCH, testsuite, x86] Make the requires test for CET a bit stronger.

2019-05-15 Thread Uros Bizjak
On Wed, May 15, 2019 at 8:29 PM Iain Sandoe wrote: > > > > On 15 May 2019, at 19:02, Uros Bizjak wrote: > > > > On Wed, May 15, 2019 at 6:48 PM Iain Sandoe wrote: > >> > >> Hi, > >> > >> There is at least one assembler that supports ‘setssbsy' but not “endbr*”. > >> We can catch this by adding

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-15 Thread Eric Gallager
On 5/15/19, Maxim Kuvyrkov wrote: >> On May 15, 2019, at 2:19 PM, Richard Biener >> wrote: >> >> On Tue, May 14, 2019 at 6:11 PM Maxim Kuvyrkov >> wrote: >>> >>> This patch adds scripts to contrib/ to migrate full history of GCC's >>> subversion repository to git. My hope is that these scripts

Re: [PATCH] Allow opening file on multiple units

2019-05-15 Thread Damian Rouson
Could someone please update the Fortran 2018 status page on the wiki to reflect this patch? I would volunteer to do it myself, but I've tried on at least 3 occasions (including today) to set up an account or generate a new password and every attempt fails with a warning that I'm being locked out

Re: PATCH, testsuite, x86] Make the requires test for CET a bit stronger.

2019-05-15 Thread Iain Sandoe
> On 15 May 2019, at 19:02, Uros Bizjak wrote: > > On Wed, May 15, 2019 at 6:48 PM Iain Sandoe wrote: >> >> Hi, >> >> There is at least one assembler that supports ‘setssbsy' but not “endbr*”. >> We can catch this by adding "-fcf-protection” to the >> check_effective_target_cet test. > >

Re: [PATCH, i386]: Macroize DIVMOD patterns

2019-05-15 Thread Uros Bizjak
On Wed, May 15, 2019 at 2:29 PM Uros Bizjak wrote: > > I somehow missed this testsuite failure... > > Attached patch is needed. I'll commit it later today. Now regtested on x86_64-linux-gnu {,-m32} and committed with the following ChangeLog: 2019-05-15 Uroš Bizjak *

Re: PATCH, testsuite, x86] Make the requires test for CET a bit stronger.

2019-05-15 Thread Uros Bizjak
On Wed, May 15, 2019 at 6:48 PM Iain Sandoe wrote: > > Hi, > > There is at least one assembler that supports ‘setssbsy' but not “endbr*”. > We can catch this by adding "-fcf-protection” to the > check_effective_target_cet test. How about adding asm ("endbr") to the source? Uros. > OK for

Re: [PATCH, Darwin, PowerPC, testsuite] Exclude Darwin from VSX, Power8 and Power9 tests.

2019-05-15 Thread Iain Sandoe
Hi Segher, > On 15 May 2019, at 18:24, Segher Boessenkool > wrote: > > On Wed, May 15, 2019 at 12:54:03PM +0100, Iain Sandoe wrote: >> If we build Darwin with a modern assembler, then it might well >> recognise insns that cannot be used on current Darwin systems. >> >> The patch augments the

Re: [PATCH, Darwin, PowerPC, testsuite] Exclude Darwin from VSX, Power8 and Power9 tests.

2019-05-15 Thread Segher Boessenkool
Hi Iain, On Wed, May 15, 2019 at 12:54:03PM +0100, Iain Sandoe wrote: > If we build Darwin with a modern assembler, then it might well > recognise insns that cannot be used on current Darwin systems. > > The patch augments the tests for feature support for VSX, > power8 and power9 to exclude

PATCH, testsuite, x86] Make the requires test for CET a bit stronger.

2019-05-15 Thread Iain Sandoe
Hi, There is at least one assembler that supports ‘setssbsy' but not “endbr*”. We can catch this by adding "-fcf-protection” to the check_effective_target_cet test. OK for trunk? Iain gcc/testsuite/ *lib/target-supports.exp (check_effective_target_cet): Add the fcf-protection

Re: [PATCH v2 2/3] Add predict_doloop_p target hook

2019-05-15 Thread Segher Boessenkool
On Wed, May 15, 2019 at 10:53:43AM +0200, Richard Biener wrote: > I wonder if making the doloop patterns (tried to find them in rs6000.md, > but I only see define_expands with no predicates/alternatives...) "doloop_end" --> "ctr" --> "_" (all consecutive in rs6000.md btw.) Alternative 0 in "_"

Re: abstract out EH propagation cleanups

2019-05-15 Thread Aldy Hernandez
Sorry, I meant to PING this one. Aldy On Wed, May 8, 2019 at 5:08 PM Aldy Hernandez wrote: > > On 5/8/19 2:30 AM, Richard Biener wrote: > > On Tue, May 7, 2019 at 11:55 PM Jeff Law wrote: > >> > >> On 5/7/19 3:45 AM, Richard Biener wrote: > >>> On Tue, May 7, 2019 at 11:13 AM Aldy Hernandez

Re: abstract out EH propagation cleanups

2019-05-15 Thread Aldy Hernandez
PING On Wed, May 8, 2019 at 5:18 PM Aldy Hernandez wrote: > > > > On 5/8/19 2:30 AM, Richard Biener wrote: > > On Tue, May 7, 2019 at 11:55 PM Jeff Law wrote: > >> > >> On 5/7/19 3:45 AM, Richard Biener wrote: > >>> On Tue, May 7, 2019 at 11:13 AM Aldy Hernandez wrote: > > Hi. >

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-15 Thread Segher Boessenkool
On Wed, May 15, 2019 at 10:47:31AM +0200, Richard Biener wrote: > Ah, so the key issue is that the doloop IV is "free"? That > is, it doesn't consume a general register and whatnot? That > is allocating this IV doesn't really interfere with other IVs? That is one half of it, yes. > But can

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-05-15 Thread Rich Felker
On Wed, May 15, 2019 at 03:59:39PM +, Szabolcs Nagy wrote: > On 15/05/2019 16:37, Rich Felker wrote: > > On Wed, May 15, 2019 at 05:12:11PM +0200, Christophe Lyon wrote: > >> On Wed, 15 May 2019 at 16:37, Rich Felker wrote: > >>> On Wed, May 15, 2019 at 01:55:30PM +, Szabolcs Nagy wrote:

Re: [PATCH] Allow opening file on multiple units

2019-05-15 Thread Steve Kargl
On Wed, May 15, 2019 at 04:24:47PM +0300, Janne Blomqvist wrote: > As of Fortran 2018 it's allowed to open the same file on multiple > units. > > fortran/ChangeLog: > > 2019-05-15 Janne Blomqvist > > PR fortran/90461 > * io/open.c (new_unit): Don't check if the file is already

[PATCH] Testsuite: Add s390 exceptions for gen-vect

2019-05-15 Thread Robin Dapp
Hi, this patch changes three gen-vect testcases so they do not expect vectorization of an unaligned access. Vectorization happens regardless, we just ignore misalignment. Regards Robin -- gcc/testsuite/ChangeLog: 2019-05-15 Robin Dapp * gcc.dg/tree-ssa/gen-vect-26.c: Do not

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-05-15 Thread Szabolcs Nagy
On 15/05/2019 16:37, Rich Felker wrote: > On Wed, May 15, 2019 at 05:12:11PM +0200, Christophe Lyon wrote: >> On Wed, 15 May 2019 at 16:37, Rich Felker wrote: >>> On Wed, May 15, 2019 at 01:55:30PM +, Szabolcs Nagy wrote: can support both normal elf and fdpic elf so you can test/use

[PATCH] soft-fp: Update soft-fp from glibc

2019-05-15 Thread H.J. Lu
This patch is updating all soft-fp from glibc, most changes are copyright years update, and changes other than years update are * soft-fp/extenddftf2.c: Use "_FP_W_TYPE_SIZE < 64" to check if 4_FP_W_TYPEs are used for IEEE quad precision. * soft-fp/extendhftf2.c: Likewise.

Re: [PATCH] PR libstdc++/85965 delay static assertions until types are complete

2019-05-15 Thread Jonathan Wakely
On 26/03/19 15:28 +, Jonathan Wakely wrote: The static assertions added for PR libstdc++/48101 were at class scope and so were evaluated too eagerly, when it might not be possible to determine whether the function objects are invocable with the key types. The problematic cases are where the

[PATCH] S/390: Add -march to test case

2019-05-15 Thread Robin Dapp
Hi, this patch adds -march=z900 to a test case that expects larl for loading a value via the GOT. On z10 and later, lgrl is used which is tested in a new test case. Regards Robin -- gcc/testsuite/ChangeLog: 2019-05-15 Robin Dapp * gcc.target/s390/global-array-element-pic.c: Add

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-05-15 Thread Rich Felker
On Wed, May 15, 2019 at 05:12:11PM +0200, Christophe Lyon wrote: > On Wed, 15 May 2019 at 16:37, Rich Felker wrote: > > > > On Wed, May 15, 2019 at 01:55:30PM +, Szabolcs Nagy wrote: > > > On 15/05/2019 13:39, Christophe Lyon wrote: > > > > In FDPIC mode, we set -fPIE unless the user provides

[PATCH] Remove redundant accessors in hash tables

2019-05-15 Thread Jonathan Wakely
François, I noticed that _Hash_code_base and _Hashtable_base have a number of member functions which are overloaded for const and non-const: const _Equal& _M_eq() const { return _EqualEBO::_S_cget(*this); } _Equal& _M_eq() { return _EqualEBO::_S_get(*this); } The non-const ones

Re: [PATCH] gcc: move assemble_start_function / assemble_end_function to output_mi_thunk

2019-05-15 Thread augustine.sterl...@gmail.com
On Tue, May 14, 2019 at 10:28 AM Max Filippov wrote: > > Let backends call assemble_start_function after they have generated > thunk function body so that a constant pool could be output if it is > required. This may help backends to avoid implementing custom constant > loading code specifically

Re: [PATCH] [aarch64] Introduce flags for SVE2.

2019-05-15 Thread Matthew Malcomson
> Matthew Malcomson writes: >> @@ -326,16 +326,22 @@ int opt_ext_cmp (const void* a, const void* b) Cheers Richard -- modified patch attached and inlined. MM ### Attachment also inlined for ease of reply### diff --git

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-05-15 Thread Christophe Lyon
On Wed, 15 May 2019 at 16:37, Rich Felker wrote: > > On Wed, May 15, 2019 at 01:55:30PM +, Szabolcs Nagy wrote: > > On 15/05/2019 13:39, Christophe Lyon wrote: > > > In FDPIC mode, we set -fPIE unless the user provides -fno-PIE, -fpie, > > > -fPIC or -fpic: indeed FDPIC code is PIC, but we

Re: [PATCH 1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics

2019-05-15 Thread Martin Sebor
On 5/15/19 5:40 AM, Martin Liška wrote: On 5/14/19 11:31 PM, Martin Sebor wrote: The attached patch implements the -Wformat-diag warning to help find quoting, spelling, and other formatting issues in diagnostics issued by GCC. Just a general comment about this part. Wouldn't it make sense to

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-05-15 Thread Rich Felker
On Wed, May 15, 2019 at 01:55:30PM +, Szabolcs Nagy wrote: > On 15/05/2019 13:39, Christophe Lyon wrote: > > In FDPIC mode, we set -fPIE unless the user provides -fno-PIE, -fpie, > > -fPIC or -fpic: indeed FDPIC code is PIC, but we want to generate code > > for executables rather than shared

Re: [committed, wwwdocs] OpenACC status for GCC 9

2019-05-15 Thread Thomas Schwinge
Hi Gerald! On Sat, 11 May 2019 09:37:42 +0200, Gerald Pfeifer wrote: > On Thu, 2 May 2019, Thomas Schwinge wrote: > > +https://www.openacc.org;>OpenACC support in C, C++, and > > +Fortran continues to be maintained and improved. > > +Most of the OpenACC 2.5 specification is

Re: [RFC] SHIFT_COUNT_TRUNCATED and shift_truncation_mask

2019-05-15 Thread Robin Dapp
> It would really help if you could provide testcases which show the > suboptimal code and any analysis you've done. I tried introducing a define_subst pattern that substitutes something one of two other subst patterns already changed. The first subst pattern helps remove a superfluous and on

[C++ Patch, obvious] Remove REFERENCE_VLA_OK

2019-05-15 Thread Paolo Carlini
Hi, noticed this nit a few weeks ago: currently we only set the flag in one place and nowhere read it. I'm going to commit the below as obvious later today, barring objections. Thanks, Paolo. / 2019-05-15 Paolo Carlini * cp-tree.h (REFERENCE_VLA_OK): Remove.

Re: OpenACC 2.5 Profiling Interface

2019-05-15 Thread Thomas Schwinge
Hi Jakub! On Tue, 4 Dec 2018 14:13:49 +0100, Jakub Jelinek wrote: > On Sun, Nov 11, 2018 at 10:31:42PM -0600, Thomas Schwinge wrote: > > On Tue, 28 Feb 2017 18:43:36 +0100, I wrote: > > > The 2.5 versions of the OpenACC standard added a new chapter "Profiling > > > Interface". > > > > I'd like

Re: [PATCH, lto-plugin] Make the plugin more -save-temps friendly.

2019-05-15 Thread Iain Sandoe
> On 15 May 2019, at 14:52, Martin Liška wrote: > > On 5/14/19 6:45 PM, Iain Sandoe wrote: >> Currently the lto plugin has a somewhat obscure incantation to get it to >> save its temp files, and at least one is not named in any > > libtool: compile: gcc -DHAVE_CONFIG_H -I. >

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-05-15 Thread Szabolcs Nagy
On 15/05/2019 13:39, Christophe Lyon wrote: > In FDPIC mode, we set -fPIE unless the user provides -fno-PIE, -fpie, > -fPIC or -fpic: indeed FDPIC code is PIC, but we want to generate code > for executables rather than shared libraries by default. > > We also make sure to use the --fdpic

Re: [PATCH, lto-plugin] Make the plugin more -save-temps friendly.

2019-05-15 Thread Martin Liška
On 5/14/19 6:45 PM, Iain Sandoe wrote: > Currently the lto plugin has a somewhat obscure incantation to get it to save > its temp files, and at least one is not named in any sensible way for > development examination. > > This patch makes it follow the same approach as collect2. > >

Re: [PATCH] fortran: C++ support for generating C prototypes

2019-05-15 Thread Jakub Jelinek
On Sun, May 12, 2019 at 12:47:04AM +0300, Janne Blomqvist wrote: > --- a/gcc/fortran/parse.c > +++ b/gcc/fortran/parse.c > @@ -6331,6 +6331,24 @@ done: >} > >/* Dump C prototypes. */ > + if (flag_c_prototypes || flag_c_prototypes_external) > +{ > + fprintf (stdout, > +

Re: [C++ Patch] Consistently use OVL_P

2019-05-15 Thread Marek Polacek
On Wed, May 15, 2019 at 03:24:52PM +0200, Paolo Carlini wrote: > Hi, > > On 15/05/19 14:29, Nathan Sidwell wrote: > > On 5/14/19 5:20 PM, Paolo Carlini wrote: > > > Hi again, > > > > > > ... so the below passes testing on x86_64-linux. In fact, I think we > > > are on a pretty safe ground, now

Re: [C++ Patch] Consistently use OVL_P

2019-05-15 Thread Paolo Carlini
Hi, On 15/05/19 14:29, Nathan Sidwell wrote: On 5/14/19 5:20 PM, Paolo Carlini wrote: Hi again, ... so the below passes testing on x86_64-linux. In fact, I think we are on a pretty safe ground, now at the beginning of Stage 1: if, over the next months we get a testcase which causes one of

[PATCH] Allow opening file on multiple units

2019-05-15 Thread Janne Blomqvist
As of Fortran 2018 it's allowed to open the same file on multiple units. fortran/ChangeLog: 2019-05-15 Janne Blomqvist PR fortran/90461 * io/open.c (new_unit): Don't check if the file is already open for F2018. testsuite/ChangeLog: 2019-05-15 Janne Blomqvist

Re: [PATCH 2/2] aarch64 back-end changes

2019-05-15 Thread Richard Earnshaw (lists)
On 15/05/2019 13:48, Richard Earnshaw (lists) wrote: > On 15/05/2019 03:39, kugan.vivekanandara...@linaro.org wrote: >> From: Kugan Vivekanandarajah >> > > The subject line to this email is not helpful. Why should I be > interested in reviewing this patch? Also, why does it claim to be 2/2 >

Re: [PATCH] PR90424 - lowpart vector set recognition

2019-05-15 Thread Richard Biener
On Tue, 14 May 2019, Richard Sandiford wrote: > Richard Biener writes: > > On Tue, 14 May 2019, Richard Sandiford wrote: > > > >> Richard Biener writes: > >> > The following makes SSA rewrite (update-address-taken) recognize > >> > sets of aligned sub-vectors in aligned position > >> > (v2qi

[PATCH] Call update_address_taken before into-SSA

2019-05-15 Thread Richard Biener
I've noticed we fail to rewrite vectors into SSA at the earliest opportunity because FEs leave us with stray TREE_ADDRESSABLE set or IL that is not suitable for SSA but can be easily rewritten. The earliest opportunity to fix this is when we rewrite into SSA where it has low overhead (no

Re: [PATCH 2/2] aarch64 back-end changes

2019-05-15 Thread Richard Earnshaw (lists)
On 15/05/2019 03:39, kugan.vivekanandara...@linaro.org wrote: > From: Kugan Vivekanandarajah > The subject line to this email is not helpful. Why should I be interested in reviewing this patch? Also, why does it claim to be 2/2 when there's no 1/2 to go with it? Please include with all

@代@理@税@票@

2019-05-15 Thread kwwtawvpz
+ 开 各 地 正 规 普 通 税 票 详电:刘小姐 电话:136-0190-4137 ( V信:同号) QQ:195-133-0600 ++ 2019/5/15

[ARM/FDPIC v5 21/21] [ARM] FDPIC: Handle stack-protector combined patterns

2019-05-15 Thread Christophe Lyon
The recent stack_protect_combined_set_insn and stack_protect_combined_test_insn force recomputing of GOT base, but need to take into account that in FDPIC mode, the PIC register is fixed by the ABI (r9). 2019-XX-XX Christophe Lyon * config/arm/arm.md (stack_protect_combined_set_insn):

[ARM/FDPIC v5 20/21] [ARM][testsuite] FDPIC: Skip tests using architectures unsupported by FDPIC

2019-05-15 Thread Christophe Lyon
Since FDPIC currently supports arm and thumb-2 modes only, these tests fail because they enforce an architecture version that doesn't match these restrictions. This patch introduces new values for the arm_arch effective-target (v4t_thumb, v5t_thumb, v5te_thumb, v6_thumb, v6k_thumb, v6z_thumb) as

[ARM/FDPIC v5 19/21] [ARM][testsuite] FDPIC: Adjust pr43698.c to avoid clash with uclibc.

2019-05-15 Thread Christophe Lyon
uclibc defines bswap_32, so use a different name in this test. 2019-XX-XX Christophe Lyon gcc/testsuite/ * gcc.target/arm/pr43698.c (bswap_32): Rename as my_bswap_32. Change-Id: I2591bd911030814331cabf97ee5cf6cf8124b4f3 diff --git a/gcc/testsuite/gcc.target/arm/pr43698.c

[ARM/FDPIC v5 18/21] [ARM][testsuite] FDPIC: Enable tests on pie_enabled targets

2019-05-15 Thread Christophe Lyon
Some tests have the "nonpic" guard, but pass on arm*-*-uclinuxfdpiceabi because it is in PIE mode by default. Rather than adding this target to all these tests, add the "pie_enabled" effective target. 2019-XX-XX Christophe Lyon gcc/testsuite/ * g++.dg/cpp0x/noexcept03.C: Add

[ARM/FDPIC v5 17/21] [ARM][testsuite] FDPIC: Handle *-*-uclinux*

2019-05-15 Thread Christophe Lyon
Add *-*-uclinux* to tests that work on this target. 2019-XX-XX Christophe Lyon gcc/testsuite/ * g++.dg/abi/forced.C: Add *-*-uclinux*. * g++.dg/abi/guard2.C: Likewise. * g++.dg/ext/cleanup-10.C: Likewise. * g++.dg/ext/cleanup-11.C: Likewise. *

[ARM/FDPIC v5 15/21] [ARM][testsuite] FDPIC: Adjust scan-assembler patterns.

2019-05-15 Thread Christophe Lyon
In FDPIC mode, r9 is saved in addition to other registers, so update the expected patterns accordingly. 2019-XX-XX Christophe Lyon Mickaël Guêné * gcc/testsuite/ * gcc.target/arm/interrupt-1.c: Add scan-assembler pattern for arm*-*-uclinuxfdpiceabi. *

[ARM/FDPIC v5 16/21] [ARM][testsuite] FDPIC: Skip tests that don't work in PIC mode

2019-05-15 Thread Christophe Lyon
Some tests fail on arm*-*-uclinuxfdpiceabi because it generates PIC code and they don't support it: skip them. They also fail on arm*-linux* when forcing -fPIC. 2019-XX-XX Christophe Lyon gcc/testsuite/ * gcc.target/arm/eliminate.c: Accept only nonpic targets. *

[ARM/FDPIC v5 13/21] [ARM] FDPIC: Force LSB bit for PC in Cortex-M architecture

2019-05-15 Thread Christophe Lyon
Without this, when we are unwinding across a signal frame we can jump to an even address which leads to an exception. This is needed in __gnu_persnality_sigframe_fdpic() when restoring the PC from the signal frame since the PC saved by the kernel has the LSB bit set to zero. 2019-XX-XX

[ARM/FDPIC v5 14/21] [ARM][testsuite] FDPIC: Skip unsupported tests

2019-05-15 Thread Christophe Lyon
Several tests cannot work on ARM-FDPIC for various reasons: skip them, or skip some directives. gcc.dg/20020312-2.c: Skip since it forces -fno-pic. gcc.target/arm/: * Skip since r9 is clobbered by assembly code: 20051215-1.c mmx-1.c pr61948.c pr77933-1.c pr77933-2.c * Skip since the

[ARM/FDPIC v5 11/21] [ARM] FDPIC: Add support to unwind FDPIC signal frame

2019-05-15 Thread Christophe Lyon
2019-XX-XX Christophe Lyon Mickaël Guêné libgcc/ * unwind-arm-common.inc (ARM_SET_R7_RT_SIGRETURN) (THUMB2_SET_R7_RT_SIGRETURN, FDPIC_LDR_R12_WITH_FUNCDESC) (FDPIC_LDR_R9_WITH_GOT, FDPIC_LDR_PC_WITH_RESTORER) (FDPIC_FUNCDESC_OFFSET,

[ARM/FDPIC v5 10/21] [ARM] FDPIC: Implement TLS support.

2019-05-15 Thread Christophe Lyon
Support additional relocations: TLS_GD32_FDPIC, TLS_LDM32_FDPIC, and TLS_IE32_FDPIC. We do not support the GNU2 TLS dialect. 2019-XX-XX Christophe Lyon Mickaël Guêné gcc/ * config/arm/arm.c (tls_reloc): Add TLS_GD32_FDPIC, TLS_LDM32_FDPIC and TLS_IE32_FDPIC.

[ARM/FDPIC v5 12/21] [ARM] FDPIC: Restore r9 after we call __aeabi_read_tp

2019-05-15 Thread Christophe Lyon
We call __aeabi_read_tp() to get the thread pointer. Since this is a function call, we have to restore the FDPIC register afterwards. 2019-XX-XX Christophe Lyon Mickaël Guêné gcc/ * config/arm/arm.c (arm_load_tp): Add FDPIC support. * config/arm/arm.md

[ARM/FDPIC v5 09/21] [ARM] FDPIC: Add support for taking address of nested function

2019-05-15 Thread Christophe Lyon
In FDPIC mode, the trampoline generated to support pointers to nested functions looks like: .wordtrampoline address .wordtrampoline GOT address ldr r12, [pc, #8] ldr r9, [pc, #8] ldr pc, [pc, #8]

[ARM/FDPIC v5 08/21] [ARM] FDPIC: Enforce local/global binding for function descriptors

2019-05-15 Thread Christophe Lyon
Use local binding rules to decide whether we can use GOTOFFFUNCDESC to compute the function address. 2019-XX-XX Christophe Lyon Mickaël Guêné gcc/ * config/arm/arm.c (arm_local_funcdesc_p): New function. (legitimize_pic_address): Enforce binding rules on

[ARM/FDPIC v5 07/21] [ARM] FDPIC: Avoid saving/restoring r9 on stack since it is read-only

2019-05-15 Thread Christophe Lyon
2019-XX-XX Christophe Lyon Mickaël Guêné gcc/ * config/arm/arm.h (PIC_REGISTER_MAY_NEED_SAVING): New helper. * config/arm/arm.c (arm_compute_save_reg0_reg12_mask): Handle FDPIC. Change-Id: I0f3b2023ab2a2a0433dfe081dac6bbb194b7a76c diff --git

[ARM/FDPIC v5 06/21] [ARM] FDPIC: Add support for c++ exceptions

2019-05-15 Thread Christophe Lyon
The main difference with existing support is that function addresses are function descriptor addresses instead. This means that all code dealing with function pointers now has to cope with function descriptors instead. For the same reason, Linux kernel helpers can no longer be called by

[ARM/FDPIC v5 05/21] [ARM] FDPIC: Fix __do_global_dtors_aux and frame_dummy generation

2019-05-15 Thread Christophe Lyon
In FDPIC, we need to make sure __do_global_dtors_aux and frame_dummy are referenced by their address, not by pointers to the function descriptors. 2019-XX-XX Christophe Lyon Mickaël Guêné * libgcc/crtstuff.c: Add support for FDPIC. Change-Id:

[ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-05-15 Thread Christophe Lyon
In FDPIC mode, we set -fPIE unless the user provides -fno-PIE, -fpie, -fPIC or -fpic: indeed FDPIC code is PIC, but we want to generate code for executables rather than shared libraries by default. We also make sure to use the --fdpic assembler option, and select the appropriate linker emulation.

[ARM/FDPIC v5 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture

2019-05-15 Thread Christophe Lyon
The FDPIC register is hard-coded to r9, as defined in the ABI. We have to disable tailcall optimizations if we don't know if the target function is in the same module. If not, we have to set r9 to the value associated with the target module. When generating a symbol address, we have to take into

[ARM/FDPIC v5 02/21] [ARM] FDPIC: Handle arm*-*-uclinuxfdpiceabi in configure scripts

2019-05-15 Thread Christophe Lyon
The new arm-uclinuxfdpiceabi target behaves pretty much like arm-linux-gnueabi. In order the enable the same set of features, we have to update several configure scripts that generally match targets like *-*-linux*: in most places, we add *-uclinux* where there is already *-linux*, or uclinux*

[ARM/FDPIC v5 01/21] [ARM] FDPIC: Add -mfdpic option support

2019-05-15 Thread Christophe Lyon
2019-XX-XX Christophe Lyon Mickaël Guêné gcc/ * config/arm/arm.opt: Add -mfdpic option. * doc/invoke.texi: Add documentation for -mfdpic. Change-Id: I0eabd1d11c9406fd4a43c4333689ebebbfcc4fe8 diff --git a/gcc/config/arm/arm.opt b/gcc/config/arm/arm.opt index

[ARM/FDPIC v5 00/21] FDPIC ABI for ARM

2019-05-15 Thread Christophe Lyon
Hello, This patch series implements the GCC contribution of the FDPIC ABI for ARM targets. This ABI enables to run Linux on ARM MMU-less cores and supports shared libraries to reduce the memory footprint. Without MMU, text and data segments relative distances are different from one process to

Re: [PATCH, i386]: Macroize DIVMOD patterns

2019-05-15 Thread Uros Bizjak
I somehow missed this testsuite failure... Attached patch is needed. I'll commit it later today. Uros. On Wed, May 15, 2019 at 2:16 PM Richard Biener wrote: > > On Tue, May 14, 2019 at 6:23 PM Uros Bizjak wrote: > > > > Recent work by Richard Sandiford [1] enabled the possibility to > >

Re: [C++ Patch] Consistently use OVL_P

2019-05-15 Thread Nathan Sidwell
On 5/14/19 5:20 PM, Paolo Carlini wrote: Hi again, ... so the below passes testing on x86_64-linux. In fact, I think we are on a pretty safe ground, now at the beginning of Stage 1: if, over the next months we get a testcase which causes one of the 4 tightened gcc_assert to trip we'll

Re: [PATCH] Check for overflow in tree-switch-conversion (PR middle-end/90478).

2019-05-15 Thread Richard Biener
On Wed, May 15, 2019 at 1:30 PM Martin Liška wrote: > > On 5/15/19 1:21 PM, Richard Biener wrote: > > On Wed, May 15, 2019 at 12:21 PM Martin Liška wrote: > >> > >> Hi. > >> > >> The patch is about handling of overflow in > >> jump_table_cluster::can_be_handled. > >> I calculate 100 * range and

Re: [PATCH, i386]: Macroize DIVMOD patterns

2019-05-15 Thread Jakub Jelinek
On Wed, May 15, 2019 at 02:15:43PM +0200, Richard Biener wrote: > I see > > FAIL: gcc.target/i386/udivmod-1.c execution test > > on x86_64. And on i686-linux too. Jakub

Re: [PATCH, i386]: Macroize DIVMOD patterns

2019-05-15 Thread Richard Biener
On Tue, May 14, 2019 at 6:23 PM Uros Bizjak wrote: > > Recent work by Richard Sandiford [1] enabled the possibility to > macroize DIVMOD patterns in i386.md. > > 2019-05-14 Uroš Bizjak > > * config/i386/i386.md (any_div): New code iterator. > (paired_mod): New code attribute. >

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-15 Thread Maxim Kuvyrkov
> On May 15, 2019, at 2:19 PM, Richard Biener > wrote: > > On Tue, May 14, 2019 at 6:11 PM Maxim Kuvyrkov > wrote: >> >> This patch adds scripts to contrib/ to migrate full history of GCC's >> subversion repository to git. My hope is that these scripts will finally >> allow GCC project to

[PATCH, Darwin, PowerPC, testsuite] Exclude Darwin from VSX, Power8 and Power9 tests.

2019-05-15 Thread Iain Sandoe
Hi! If we build Darwin with a modern assembler, then it might well recognise insns that cannot be used on current Darwin systems. The patch augments the tests for feature support for VSX, power8 and power9 to exclude Darwin even if the assembler can handle the instructions. tested on

Re: malloc cannot alias preexisting pointers

2019-05-15 Thread Richard Biener
On Tue, May 14, 2019 at 4:05 PM Marc Glisse wrote: > > On Tue, 14 May 2019, Richard Biener wrote: > > >>> In princple PTA should know the aliasing cannot happen but possibly > >>> the info is either lost or the IL is too obfuscated at the point it gets > >>> computed. (hello C++...) > >> > >> We

Re: [PATCH 1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics

2019-05-15 Thread Martin Liška
On 5/14/19 11:31 PM, Martin Sebor wrote: > The attached patch implements the -Wformat-diag warning to help find > quoting, spelling, and other formatting issues in diagnostics issued > by GCC. Just a general comment about this part. Wouldn't it make sense to use regex for some of the string

  1   2   >