Re: [PATCH] tailcall: Fix up process_assignment [PR94001]

2020-03-03 Thread Richard Biener
On Wed, 4 Mar 2020, Jakub Jelinek wrote: > Hi! > > When a function returns void or the return value is ignored, ass_var > is NULL_TREE. The tail recursion handling generally assumes DCE has been > performed and so doesn't expect to encounter useless assignments after the > call and expects them

Re: [PATCH] [rs6000] Rewrite the declaration of a variable

2020-03-03 Thread binbin
Hi On 2020/3/4 上午8:33, Segher Boessenkool wrote: Hi! On Tue, Mar 03, 2020 at 10:13:56AM -0600, Bin Bin Lv wrote: Rewrite the declaration of toc_section from the source file rs6000.c to its header file for standardizing the code. diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs

[PATCH] tailcall: Fix up process_assignment [PR94001]

2020-03-03 Thread Jakub Jelinek
Hi! When a function returns void or the return value is ignored, ass_var is NULL_TREE. The tail recursion handling generally assumes DCE has been performed and so doesn't expect to encounter useless assignments after the call and expects them to be part of the return value adjustment that need to

[testsuite] Fix PR94019 to allow one vector char when !vect_hw_misalign

2020-03-03 Thread Kewen.Lin
Hi, As PR94019 shows, without misaligned vector access support but with realign load, the vectorized loop will end up with realign scheme. It generates mask (control vector) with return type vector signed char which breaks the not check. The fix is to differentiate powerpc vect_hw_misalign and po

[testsuite] Fix PR94023 to guard case under vect_hw_misalign

2020-03-03 Thread Kewen.Lin
Hi, As PR94023 shows, the expected SLP requires misaligned vector access support. This patch is to guard the check under the target condition vect_hw_misalign to ensure that. Verified it on ppc64-redhat-linux (Power7 BE). Is it ok for trunk, and backport to GCC 9 after some burn-in time? BR,

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-03 Thread binbin
Hi On 2020/3/4 上午8:25, Segher Boessenkool wrote: Hi! On Tue, Mar 03, 2020 at 09:40:47AM -0600, Bin Bin Lv wrote: The source file rs6000.c was split up into several smaller source files through commit 1acf024. However, variable "altivec_builtin_mask_for_load" and "builtin_mode_to_type[MAX_MACH

Re: [PATCH] PR target/93995 ICE in patch_jump_insn, at cfgrtl.c:1290 on riscv64-linux-gnu

2020-03-03 Thread Kito Cheng
Committed, thanks :) On Wed, Mar 4, 2020 at 6:23 AM Jim Wilson wrote: > > On Tue, Mar 3, 2020 at 12:03 AM Kito Cheng wrote: > > gcc/ChangeLog > > * config/riscv/riscv.c (riscv_emit_float_compare): Using NE to > > compare > > the result of IOR. > > > > gcc/testsuite/ChangeLog >

Re: [PATCH 3/4] libstdc++: Add a test range type that has a sized sentinel

2020-03-03 Thread Patrick Palka
On Tue, 3 Mar 2020, Jonathan Wakely wrote: > On 03/03/20 11:30 -0500, Patrick Palka wrote: > > This adds a test range type whose end() is a sized sentinel to > > , which will be used in the tests that verify LWG > > 3355. > > > > libstdc++-v3/ChangeLog: > > > > * testsuite/util/testsuite_ite

*Ping^1* [PATCH v3] ipa-cp: Fix PGO regression caused by r278808

2020-03-03 Thread luoxhu
Hi Honza, The performance regression still exists. For exchange2, the performance is about 28% slower for option: "-fprofile-generate/-fprofile-use --param ipa-cp-eval-threshold=0 --param ipa-cp-unit-growth=80 -fno-inline". r278808: commit ad06966f6677d55c11214d9c7b6d5518f915e341 Author: hubicka

Re: [PATCH] c++: Fix mismatch in template argument deduction [PR90505]

2020-03-03 Thread Jason Merrill
On 3/3/20 7:50 PM, Marek Polacek wrote: My GCC 9 patch for C++20 P0846R0 (ADL and function templates) tweaked cp_parser_template_name to only return an identifier if name lookup didn't find anything. In the deduce4.C case it means that we now return an OVERLOAD. That means that cp_parser_templa

[PATCH] c++: Fix mismatch in template argument deduction [PR90505]

2020-03-03 Thread Marek Polacek
My GCC 9 patch for C++20 P0846R0 (ADL and function templates) tweaked cp_parser_template_name to only return an identifier if name lookup didn't find anything. In the deduce4.C case it means that we now return an OVERLOAD. That means that cp_parser_template_id will call lookup_template_function w

Re: [PATCH] [rs6000] Rewrite the declaration of a variable

2020-03-03 Thread Segher Boessenkool
Hi! On Tue, Mar 03, 2020 at 10:13:56AM -0600, Bin Bin Lv wrote: > Rewrite the declaration of toc_section from the source file rs6000.c to its > header file for standardizing the code. > diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c > index 0faf44b..c0a6e86 100644 > --- a/gc

Re: Add dg-require to existing powerpc/pr93122.c test

2020-03-03 Thread Segher Boessenkool
Hi! On Tue, Mar 03, 2020 at 09:42:10AM -0600, will schmidt wrote: > This test (gcc.target/powerpc/pr93122.c) uses the > -mcpu=future option. It should also ensure the > target can support the same. > Thus, add a dg-requires clause to indicate > a future target is supported on the platform. > >

Re: Remove unnecessary XFAILs from existing testcase 20050603-3.c

2020-03-03 Thread Segher Boessenkool
Hi! On Tue, Mar 03, 2020 at 08:59:52AM -0600, will schmidt wrote: > Remove unnecessary XFAILs from existing testcase 20050603-3.c. > > The XFAILs in this testcase (20050603-3.c) are no longer necessary > since the fix to PR68803 was committed with svn revision r242681. > > OK for mas

Re: [PATCH] use all same precision in wide_int arguments (PR 93986)

2020-03-03 Thread Martin Sebor
On 3/3/20 11:50 AM, Richard Biener wrote: On March 3, 2020 4:39:34 PM GMT+01:00, Martin Sebor wrote: On 3/3/20 2:42 AM, Richard Biener wrote: On Tue, Mar 3, 2020 at 12:04 AM Martin Sebor wrote: The wide_int APIs expect operands to have the same precision and abort when they don't. This is

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-03 Thread Segher Boessenkool
Hi! On Tue, Mar 03, 2020 at 09:40:47AM -0600, Bin Bin Lv wrote: > The source file rs6000.c was split up into several smaller source files > through commit 1acf024. However, variable "altivec_builtin_mask_for_load" and > "builtin_mode_to_type[MAX_MACHINE_MODE][2]" were marked with the wrong syntax

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-03 Thread Fangrui Song
On 2020-03-03, Joseph Myers wrote: On Tue, 3 Mar 2020, Egeyar Bagcioglu wrote: Although we discussed after the submission of the first version that there are several other options performing similar tasks, I believe we established that there is still a need for this specific functionality. Ther

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-03 Thread Joseph Myers
On Tue, 3 Mar 2020, Egeyar Bagcioglu wrote: > Although we discussed after the submission of the first version that > there are several other options performing similar tasks, I believe we > established that there is still a need for this specific functionality. > Therefore, I am skipping in thi

Re: [PATCH] Clear --help=language and --help=common interaction.

2020-03-03 Thread Joseph Myers
On Tue, 3 Mar 2020, Martin Liška wrote: > On 3/2/20 11:52 PM, Joseph Myers wrote: > > On Mon, 2 Mar 2020, Martin Liška wrote: > > > > > +version of GCC@. If an option is supported by all languages, one needs > > > +to use @var{common} qualifier instead. > > > > "common" is literal text, so it s

Re: [PATCH] libstdc++: Fix incorrect use of memset in ranges::fill_n (PR 94017)

2020-03-03 Thread Jonathan Wakely
On 03/03/20 17:13 -0500, Patrick Palka wrote: On Tue, 3 Mar 2020, Patrick Palka wrote: When deciding whether to perform the memset optimization in ranges::fill_n, we were crucially neglecting to check whether the output pointer's value type is a byte type. This patch adds such a check to the p

Re: [PATCH] PR target/93995 ICE in patch_jump_insn, at cfgrtl.c:1290 on riscv64-linux-gnu

2020-03-03 Thread Jim Wilson
On Tue, Mar 3, 2020 at 12:03 AM Kito Cheng wrote: > gcc/ChangeLog > * config/riscv/riscv.c (riscv_emit_float_compare): Using NE to compare > the result of IOR. > > gcc/testsuite/ChangeLog > * gcc.dg/pr93995.c: New. Thanks. This looks good to me. Jim

Re: [PATCH] re PR tree-optimization/90883 (Generated code is worse if returned struct is unnamed)

2020-03-03 Thread Jim Wilson
On Mon, Mar 2, 2020 at 11:34 PM Kito Cheng wrote: > PR tree-optimization/90883 > * g++.dg/tree-ssa/pr90883.c: Add --param max-inline-insns-size=1. > Add aarch64-*-* mips*-*-* to XFAIL. This looks good to me. Jim

Re: [PATCH], PR target/93937, Fix variable vec_extract insn that will never match

2020-03-03 Thread Segher Boessenkool
On Mon, Mar 02, 2020 at 07:41:42PM -0500, Michael Meissner wrote: > On Fri, Feb 28, 2020 at 06:45:25AM -0600, Segher Boessenkool wrote: > > On Fri, Feb 28, 2020 at 12:32:06AM -0500, Michael Meissner wrote: > > > There is a wider issue to optimize all cases of vec_extract to do the > > > sign, > >

Re: [PATCH] libstdc++: Fix incorrect use of memset in ranges::fill_n (PR 94017)

2020-03-03 Thread Patrick Palka
On Tue, 3 Mar 2020, Patrick Palka wrote: > When deciding whether to perform the memset optimization in ranges::fill_n, we > were crucially neglecting to check whether the output pointer's value type is > a > byte type. This patch adds such a check to the problematic condition in > ranges::fill_n

[PATCH] libstdc++: Fix incorrect use of memset in ranges::fill_n (PR 94017)

2020-03-03 Thread Patrick Palka
When deciding whether to perform the memset optimization in ranges::fill_n, we were crucially neglecting to check whether the output pointer's value type is a byte type. This patch adds such a check to the problematic condition in ranges::fill_n. I think the __is_byte<_Tp>::__value check, which c

Re: [PATCH 4/4] libstdc++: Move-only input iterator support in algorithms (LWG 3355)

2020-03-03 Thread Jonathan Wakely
On 03/03/20 11:30 -0500, Patrick Palka wrote: This adds support for move-only input iterators in the ranges::unitialized_* algorithms defined in , as per LWG 3355. The only changes needed are to add calls to std::move in the appropriate places and to use operator-() instead of ranges::distance()

Re: [PATCH 3/4] libstdc++: Add a test range type that has a sized sentinel

2020-03-03 Thread Jonathan Wakely
On 03/03/20 11:30 -0500, Patrick Palka wrote: This adds a test range type whose end() is a sized sentinel to , which will be used in the tests that verify LWG 3355. libstdc++-v3/ChangeLog: * testsuite/util/testsuite_iterators.h (test_range::get_iterator): Make protected instead

Re: [PATCH] PR libstdc++/91620 Implement DR 526 for std::[forward_]list::remove_if/unique

2020-03-03 Thread Jonathan Wakely
On 03/03/20 21:32 +, Jonathan Wakely wrote: On 03/03/20 06:42 +0100, François Dumont wrote: Hi     Isn't it something to fix before gcc 10 release ? No, I don't think so. It's not a regression. (And is not experimental C++20 stuff, and is not just changing tests or docs).

Re: [PATCH] rs6000: Fix -mpower9-vector -mno-altivec ICE (PR87560)

2020-03-03 Thread Segher Boessenkool
Hi! On Mon, Mar 02, 2020 at 04:01:11PM -0600, Bill Schmidt wrote: > PR87560 reports an ICE when a test case is compiled with -mpower9-vector > and -mno-altivec. This patch terminates compilation with an error when > this combination (and other unreasonable ones) are requested. (If th

Re: [PATCH 2/4] libstdc++: Add a move-only testsuite iterator type

2020-03-03 Thread Jonathan Wakely
On 03/03/20 11:30 -0500, Patrick Palka wrote: This adds a move-only testsuite iterator type to , which will be used in the tests that verify LWG 3355 and has already seen a need in the tests for LWG 3389 and 3390. libstdc++-v3/ChangeLog: * testsuite/util/testsuite_iterators.h (input_ite

Re: GLIBC libmvec status

2020-03-03 Thread GT
‐‐‐ Original Message ‐‐‐ On Monday, March 2, 2020 4:59 PM, Jakub Jelinek wrote: > Indeed, there aren't any yet on the vectorizer side, I thought I've > implemented it > already in the vectorizer but apparently didn't, just the omp-simd-clone.c > part is > implemented (the more important

Re: [PATCH 1/4] libstdc++: Fix use of is_nothrow_assignable_v in

2020-03-03 Thread Jonathan Wakely
On 03/03/20 11:30 -0500, Patrick Palka wrote: We are passing a value type as the first argument to is_nothrow_assignable_v, but the result of that is always false. Since this predicate is a part of the condition that guards the corresponding optimizations for these algorithms, this bug means the

Re: [PATCH] PR libstdc++/91620 Implement DR 526 for std::[forward_]list::remove_if/unique

2020-03-03 Thread Jonathan Wakely
On 03/03/20 06:42 +0100, François Dumont wrote: Hi     Isn't it something to fix before gcc 10 release ? No, I don't think so. It's not a regression.

Re: Fix Debug mode Undefined Behavior

2020-03-03 Thread Jonathan Wakely
On 03/03/20 22:11 +0100, François Dumont wrote: After the fix of PR 91910 I tried to consider other possible race condition and I think we still have a problem. Like stated in the PR when a container is destroyed all associated iterators are made singular. If at the same time another thread tr

Fix Debug mode Undefined Behavior

2020-03-03 Thread François Dumont
After the fix of PR 91910 I tried to consider other possible race condition and I think we still have a problem. Like stated in the PR when a container is destroyed all associated iterators are made singular. If at the same time another thread try to access this iterator the _M_singular check

RE: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-03 Thread Richard Wai
Richard Wai Managing Director T. 416.316.9806 > -Original Message- > From: Eric Botcazou > Sent: March 3, 2020 3:50 PM > To: Richard Wai > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities > > > Discovered this error when att

Re: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-03 Thread Eric Botcazou
> Discovered this error when attempting to allocate from a > Root_Storage_Pool_With_Subpools derived type. If the type is derived in the > current compilation unit, and Allocate is not overridden on derivation (as > is typically the case with Root_Storage_Pool_With_Subpools), the entity for > Alloc

[PATCH] tree-ssa-strlen: Fix up count_nonzero_bytes* [PR94015]

2020-03-03 Thread Jakub Jelinek
Hi! As I said already yesterday in another PR, I'm afraid the mixing of apples and oranges (what we are actually computing, whether what bytes are zero or non-zero in the native representation of EXP itself or what EXP points to) in a single function where it performs some handling which must be s

[PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-03 Thread Richard Wai
Hi, Discovered this error when attempting to allocate from a Root_Storage_Pool_With_Subpools derived type. If the type is derived in the current compilation unit, and Allocate is not overridden on derivation (as is typically the case with Root_Storage_Pool_With_Subpools), the entity for Allocat

[PATCH] sccvn: Avoid overflows in push_partial_def

2020-03-03 Thread Jakub Jelinek
Hi! The following patch attempts to avoid dangerous overflows in the various push_partial_def HOST_WIDE_INT computations. This is achieved by performing the subtraction offset2i - offseti in the push_partial_def function and before doing that doing some tweaks. If a constant store (non-CONSTRUCTOR

[PATCH] inliner: Copy DECL_BY_REFERENCE in copy_decl_to_var [PR93888]

2020-03-03 Thread Jakub Jelinek
Hi! In the following testcase we emit wrong debug info for the karg parameter in the DW_TAG_inlined_subroutine into main. The problem is that the karg PARM_DECL is DECL_BY_REFERENCE and thus in the IL has const K & type, but in the source just const K. When the function is inlined, we create a VAR

Re: [PATCH] use all same precision in wide_int arguments (PR 93986)

2020-03-03 Thread Richard Biener
On March 3, 2020 4:39:34 PM GMT+01:00, Martin Sebor wrote: >On 3/3/20 2:42 AM, Richard Biener wrote: >> On Tue, Mar 3, 2020 at 12:04 AM Martin Sebor >wrote: >>> >>> The wide_int APIs expect operands to have the same precision and >>> abort when they don't. This is especially insidious in code wh

Re: [PATCH] c++: Fix non-constant TARGET_EXPR constexpr handing [PR93998]

2020-03-03 Thread Jason Merrill
On 3/3/20 8:03 AM, Jakub Jelinek wrote: Hi! We ICE on the following testcase since I've added the SAVE_EXPR-like constexpr handling where the TARGET_EXPR initializer (and cleanup) is evaluated only once (because it might have side-effects like new or delete expressions in it). The problem is if

Re: [PATCH] Wrap array in ctor with braces.

2020-03-03 Thread Jason Merrill
On 3/3/20 4:04 AM, Martin Liška wrote: Hi. The patch is about to silent a few clang warnings: /home/marxin/Programming/gcc/gcc/cp/method.c:903:26: warning: suggest braces around initialization of subobject [-Wmissing-braces]    { "partial_ordering", "equivalent", "greater", "less", "unordere

Re: [committed] Fix STATIC_CHAIN_REGNUM for v850 port

2020-03-03 Thread Hans-Peter Nilsson
On Sat, 29 Feb 2020, Jeff Law wrote: > > Wow, I think I wrote the v850 port back in circa 1997 and this bug has been > latent all this time. Vlad's IRA changes twiddled register allocation in just > the right way to expose this bug. > > I'm not sure what I was thinking, but apparently I made a spe

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-03 Thread Egeyar Bagcioglu
On 3/3/20 3:44 PM, Egeyar Bagcioglu wrote: In addition to the new test case, I built binutils as my test case after passing this option to CFLAGS. The added .GCC.command.line section of ld.bfd listed many compile commands as expected. Tested on x86_64-pc-linux-gnu. As mentioned above, I use

Re: ACLE intrinsics: BFloat16 store (vst{q}_bf16) intrinsics for AArch32

2020-03-03 Thread Delia Burduv
Hi, I noticed that the patch doesn't apply cleanly. I fixed it and this is the latest version. Thanks, Delia On 3/3/20 4:23 PM, Delia Burduv wrote: Sorry, I forgot the attachment. On 3/3/20 4:20 PM, Delia Burduv wrote: Hi, I made a mistake in the previous patch. This is the latest version

Re: [PATCH 2/3] [ARC] Remove malign-call

2020-03-03 Thread Jeff Law
On Tue, 2020-03-03 at 11:40 +0200, Claudiu Zissulescu wrote: > The malign-call option is obsolete, remove it. > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc.opt (malign-call): Remove option. > * doc/invoke.texi (ARC): Remove malign-call doc. > * common/config/a

Re: [PATCH 1/3] [ARC] Remove mmixed-code option.

2020-03-03 Thread Jeff Law
On Tue, 2020-03-03 at 10:54 +0100, Richard Biener wrote: > On Tue, Mar 3, 2020 at 10:41 AM Claudiu Zissulescu wrote: > > The mmixed-code option is obsolete, remove it. > > You might want to preserve the option and ignore it like we do > for some in common.opt: > > fargument-alias > Common Ignore

Re: [PATCH] [COMMITTED] arc: Add ARC entry for gcc-10/changes.html

2020-03-03 Thread Martin Sebor
On 3/3/20 2:12 AM, Claudiu Zissulescu wrote: Add ARC entry for gcc-10/changes.html --- htdocs/gcc-10/changes.html | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html index 53d0ca08..4e27c05b 100644 --- a/ht

Re: [GCC][PATCH][AArch64] ACLE intrinsics for BFCVTN, BFCVTN2 (AArch64 AdvSIMD) and BFCVT (AArch64 FP)

2020-03-03 Thread Delia Burduv
Hi, Here is the latest version of the patch. On 2/18/20 1:51 PM, Richard Sandiford wrote: Tamar Christina writes: Hi Richard, ..ffb5305e2e5ea1aadae07e82f d8e d6f9f247c1a9 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfcvt-c

[PATCH v2 1/3] Introduce dg-require-target-object-format

2020-03-03 Thread Egeyar Bagcioglu
gcc/testsuite/: 2020-02-27 Egeyar Bagcioglu * lib/target-supports-dg.exp (dg-require-target-object-format): New. --- gcc/testsuite/lib/target-supports-dg.exp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/gcc/testsuite/lib/target-supports-dg.exp b/gcc/testsuite/lib/t

[PATCH v2 2/3] Introduce the gcc option --record-gcc-command-line

2020-03-03 Thread Egeyar Bagcioglu
gcc: 2020-02-27 Egeyar Bagcioglu * common.opt (--record-gcc-command-line): New option. * config/elfos.h (TARGET_ASM_RECORD_GCC_COMMAND_LINE): Define as elf_record_gcc_command_line. * doc/tm.texi: Regenerate. * doc/tm.texi.in (TARGET_ASM_RECORD_GCC_COMMAND

[PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-03 Thread Egeyar Bagcioglu
Hello, I would like to propose the second version of the patches which introduce a compile option --record-gcc-command-line. When passed to gcc, it saves the command line invoking gcc into the produced object file. The option makes it trivial to trace back with which command a file was compiled

[PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-03 Thread Egeyar Bagcioglu
This patch is for .GCC.command.line sections in LTO objects to be copied into the final objects as in the following example: [egeyar@localhost lto]$ gcc -flto -O3 demo.c -c -g --record-gcc-command-line [egeyar@localhost lto]$ gcc -flto -O2 demo2.c -c -g --record-gcc-command-line -DFORTIFY=2 [egey

[PATCH 4/4] libstdc++: Move-only input iterator support in algorithms (LWG 3355)

2020-03-03 Thread Patrick Palka
This adds support for move-only input iterators in the ranges::unitialized_* algorithms defined in , as per LWG 3355. The only changes needed are to add calls to std::move in the appropriate places and to use operator-() instead of ranges::distance() because the latter cannot be used with a move-o

[PATCH 3/4] libstdc++: Add a test range type that has a sized sentinel

2020-03-03 Thread Patrick Palka
This adds a test range type whose end() is a sized sentinel to , which will be used in the tests that verify LWG 3355. libstdc++-v3/ChangeLog: * testsuite/util/testsuite_iterators.h (test_range::get_iterator): Make protected instead of private. (test_sized_range_sized_sent

[PATCH 2/4] libstdc++: Add a move-only testsuite iterator type

2020-03-03 Thread Patrick Palka
This adds a move-only testsuite iterator type to , which will be used in the tests that verify LWG 3355 and has already seen a need in the tests for LWG 3389 and 3390. libstdc++-v3/ChangeLog: * testsuite/util/testsuite_iterators.h (input_iterator_wrapper_nocopy): New testsuite ite

[PATCH 1/4] libstdc++: Fix use of is_nothrow_assignable_v in

2020-03-03 Thread Patrick Palka
We are passing a value type as the first argument to is_nothrow_assignable_v, but the result of that is always false. Since this predicate is a part of the condition that guards the corresponding optimizations for these algorithms, this bug means these optimizations are never used. We should be p

Re: ACLE intrinsics: BFloat16 store (vst{q}_bf16) intrinsics for AArch32

2020-03-03 Thread Delia Burduv
Sorry, I forgot the attachment. On 3/3/20 4:20 PM, Delia Burduv wrote: Hi, I made a mistake in the previous patch. This is the latest version. Please let me know if it is ok. Thanks, Delia On 2/21/20 3:18 PM, Delia Burduv wrote: Hi Kyrill, The arm_bf16.h is only used for scalar operations

Re: ACLE intrinsics: BFloat16 store (vst{q}_bf16) intrinsics for AArch32

2020-03-03 Thread Delia Burduv
Hi, I made a mistake in the previous patch. This is the latest version. Please let me know if it is ok. Thanks, Delia On 2/21/20 3:18 PM, Delia Burduv wrote: Hi Kyrill, The arm_bf16.h is only used for scalar operations. That is how the aarch64 versions are implemented too. Thanks, Delia

[PATCH] [rs6000] Rewrite the declaration of a variable

2020-03-03 Thread Bin Bin Lv
Hi, Rewrite the declaration of toc_section from the source file rs6000.c to its header file for standardizing the code. Bootstrap and regression were done on powerpc64le-linux-gnu (LE) with no regressions. Is it OK for trunk? Thanks, Bin Bin Lv gcc/ChangeLog 2020-03-03 Bin Bin Lv

[committed] libgcc: arm: convert thumb1 code to unified syntax

2020-03-03 Thread Richard Earnshaw (lists)
Unified syntax has been the official syntax for thumb1 assembly for over 10 years now. It's time we made preparations for that becoming the default in the assembler. But before we can start doing that we really need to clean up some laggards from the olden days. Libgcc support for thumb1 is

Re: [PATCH][AARCH64] Fix for PR86901

2020-03-03 Thread Wilco Dijkstra
Hi Modi, > The zero extract now matching against other modes would generate a test + > branch rather > than the combined instruction which led to the code size regression. I've > updated the patch > so that tbnz etc. matches GPI and that brings code size down to <0.2% in > spec2017 and <0.4% in

Re: [PATCH][AARCH64] Fix for PR86901

2020-03-03 Thread Wilco Dijkstra
Hi Modi, > The zero extract now matching against other modes would generate a test + > branch rather > than the combined instruction which led to the code size regression. I've > updated the patch > so that tbnz etc. matches GPI and that brings code size down to <0.2% in > spec2017 and <0.4% in

Add dg-require to existing powerpc/pr93122.c test

2020-03-03 Thread will schmidt
Add dg-require to existing pr93122.c test Hi, This test (gcc.target/powerpc/pr93122.c) uses the -mcpu=future option. It should also ensure the target can support the same. Thus, add a dg-requires clause to indicate a future target is supported on the platform. Sniff tested successfully. (

[PATCH] [rs6000] Fix a wrong GC issue

2020-03-03 Thread Bin Bin Lv
Hi, The source file rs6000.c was split up into several smaller source files through commit 1acf024. However, variable "altivec_builtin_mask_for_load" and "builtin_mode_to_type[MAX_MACHINE_MODE][2]" were marked with the wrong syntax "GTY(([options])) type name", which led these two variables were

Re: [PATCH] use all same precision in wide_int arguments (PR 93986)

2020-03-03 Thread Martin Sebor
On 3/3/20 2:42 AM, Richard Biener wrote: On Tue, Mar 3, 2020 at 12:04 AM Martin Sebor wrote: The wide_int APIs expect operands to have the same precision and abort when they don't. This is especially insidious in code where the operands normally do have the same precision but where mixed prec

Re: [committed][ARM] Fix minor testsuite fallout on ARM due to recent IRA changes

2020-03-03 Thread Richard Earnshaw (lists)
On 02/03/2020 16:44, Jeff Law wrote: On Mon, 2020-03-02 at 16:40 +, Richard Earnshaw (lists) wrote: On 02/03/2020 15:46, Jeff Law wrote: More minor fallout from Vlad's IRA changes. Previously this test used r3 to hold a value across a call (it's an ipa-ra test). After Vlad's changes we're

Remove unnecessary XFAILs from existing testcase 20050603-3.c

2020-03-03 Thread will schmidt
Remove unnecessary XFAILs from existing testcase 20050603-3.c. Hi, The XFAILs in this testcase (20050603-3.c) are no longer necessary since the fix to PR68803 was committed with svn revision r242681. OK for master? Thanks -Will 2020-03-03 Will Schmidt testsuite

devel/omp/gcc-9 branch (was: [wwwdocs] Document existence of openacc-gcc-9-branch)

2020-03-03 Thread Thomas Schwinge
- Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter --- Begin Message --- Hi! On 2019-06-04T23:05:53+0100, Julian Brown wrote: > I've pushed a new branch "openacc-gcc

Re: [PATCH coroutines] Handle component_ref in captures_temporary

2020-03-03 Thread JunMa
在 2020/3/3 下午8:15, Nathan Sidwell 写道: On 3/3/20 12:42 AM, JunMa wrote: 在 2020/3/2 下午10:49, Nathan Sidwell 写道: On 2/12/20 2:23 AM, JunMa wrote: Hi nathan Here is the updated patch This is ok, with a correction in a comment: +  /* This isn't a temporary or argument.  */    /* This i

Re: [Ping][PATCH][Arm] ACLE intrinsics: AdvSIMD BFloat16 convert instructions

2020-03-03 Thread Dennis Zhang
Hi Kyrill On 03/03/2020 09:39, Kyrill Tkachov wrote: Hi Dennis, On 3/2/20 5:41 PM, Dennis Zhang wrote: Hi all, On 17/01/2020 16:46, Dennis Zhang wrote: > Hi all, > > This patch is part of a series adding support for Armv8.6-A features. > It depends on Arm BFMode patch > https://gcc.gnu.org/ml

[PATCH] c++: Fix non-constant TARGET_EXPR constexpr handing [PR93998]

2020-03-03 Thread Jakub Jelinek
Hi! We ICE on the following testcase since I've added the SAVE_EXPR-like constexpr handling where the TARGET_EXPR initializer (and cleanup) is evaluated only once (because it might have side-effects like new or delete expressions in it). The problem is if the TARGET_EXPR (but I guess in theory SAV

Re: [PATCH 2/4 GCC11] Add target hook stride_dform_valid_p

2020-03-03 Thread Kewen.Lin
>> Hi Segher and Richard S., >> >> Sorry for late response. Thanks for your comments on legitimate_address_p >> hook >> and function addr_offset_valid_p. I updated the IVOPTs part with >> addr_offset_valid_p, although rs6000_legitimate_offset_address_p doesn't >> check >> strictly all the time

Re: [PATCH coroutines] Handle component_ref in captures_temporary

2020-03-03 Thread Nathan Sidwell
On 3/3/20 12:42 AM, JunMa wrote: 在 2020/3/2 下午10:49, Nathan Sidwell 写道: On 2/12/20 2:23 AM, JunMa wrote: Hi nathan Here is the updated patch This is ok, with a correction in a comment: + /* This isn't a temporary or argument. */ /* This isn't a temporary. */ is sufficient.

[committed] Darwin, libsanitizer: Update minimum supported system version.

2020-03-03 Thread Iain Sandoe
Hi, The imported sources from 'upstream’ on the 9 branch do not support Darwin10 or earlier, so do not enable these by default. tested on x86_64-darwin and linux, applied to the branch thanks Iain libsanitizer/ChangeLog: 2020-03-03 Iain Sandoe * configure.tgt (x86_64-*-darwin*, i?86

[committed] libstdc++: Micro-optimisations for lexicographical_compare_three_way

2020-03-03 Thread Jonathan Wakely
As noted in LWG 3410 the specification in the C++20 draft performs more iterator comparisons than necessary when the end of either range is reached. Our implementation followed that specification. This removes the redundant comparisons so that we do no unnecessary work as soon as we find that we've

Hope Project

2020-03-03 Thread Leonie Botha
HSA Hope Project Hundreds of children are going to school hungry, exhausted and poorly clothed because their parents are so strapped for cash. Starving pupils dressed in ­threadbare clothes and shabby shoes stealing food from classmates - it sounds like a scene from a horror movie, but thi

[PATCH] tree-optimization/93946 - fix bogus redundant store removal in FRE, DSE and DOM

2020-03-03 Thread Richard Biener
This fixes a common mistake in removing a store that looks redudnant but is not because it changes the dynamic type of the memory and thus makes a difference for following loads with TBAA. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2020-03-03 Richard Biener

Re: [PATCH 1/3] [ARC] Remove mmixed-code option.

2020-03-03 Thread Richard Biener
On Tue, Mar 3, 2020 at 10:41 AM Claudiu Zissulescu wrote: > > The mmixed-code option is obsolete, remove it. You might want to preserve the option and ignore it like we do for some in common.opt: fargument-alias Common Ignore Does nothing. Preserved for backward compatibility. this avoids compi

Re: [PATCH] sccvn: Improve handling of load masked with integer constant [PR93582]

2020-03-03 Thread Richard Biener
On Mon, 2 Mar 2020, Jakub Jelinek wrote: > On Mon, Mar 02, 2020 at 12:46:30PM +0100, Richard Biener wrote: > > > + void *r = data.push_partial_def (pd, 0, prec); > > > + if (r == (void *) -1) > > > + return NULL_TREE; > > > + gcc_assert (r == NULL_TREE); >

Re: [PATCH] use all same precision in wide_int arguments (PR 93986)

2020-03-03 Thread Richard Biener
On Tue, Mar 3, 2020 at 12:04 AM Martin Sebor wrote: > > The wide_int APIs expect operands to have the same precision and > abort when they don't. This is especially insidious in code where > the operands normally do have the same precision but where mixed > precision arguments can come up as a re

[PATCH 3/3] [ARC] Remove munalign-prob-threshold.

2020-03-03 Thread Claudiu Zissulescu
The munalign-prob-threshold option is obsolete, remove it. gcc/ -xx-xx Claudiu Zissulescu * config/arc/arc.opt (munalign-prob-threshold): Remove option. * doc/invoke.texi (ARC): Remove munalign-prob-threshold doc. * config/arc/arc.c (arc_unalign_branch_p): Remove un

[PATCH 2/3] [ARC] Remove malign-call

2020-03-03 Thread Claudiu Zissulescu
The malign-call option is obsolete, remove it. gcc/ -xx-xx Claudiu Zissulescu * config/arc/arc.opt (malign-call): Remove option. * doc/invoke.texi (ARC): Remove malign-call doc. * common/config/arc/arc-common.c (arc_option_optimization_table): Remove malign-

[PATCH 1/3] [ARC] Remove mmixed-code option.

2020-03-03 Thread Claudiu Zissulescu
The mmixed-code option is obsolete, remove it. gcc/ -xx-xx Claudiu Zissulescu * config/arc/arc.c (arc_override_options): Remove TARGET_MIXED_CODE reference. * config/arc/arc.md (abssi2_mixed): Remove pattern. * config/arc/arc.h (TARGET_MIXED_CODE): Remove ma

Re: [Ping][PATCH][Arm] ACLE intrinsics: AdvSIMD BFloat16 convert instructions

2020-03-03 Thread Kyrill Tkachov
Hi Dennis, On 3/2/20 5:41 PM, Dennis Zhang wrote: Hi all, On 17/01/2020 16:46, Dennis Zhang wrote: > Hi all, > > This patch is part of a series adding support for Armv8.6-A features. > It depends on Arm BFMode patch > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01448.html > > This patch imple

Re: [PATCH PR93674]Avoid introducing IV of enumeral type in case of -fstrict-enums

2020-03-03 Thread Richard Biener
On Mon, Mar 2, 2020 at 6:14 PM Andrew Pinski wrote: > > On Mon, Mar 2, 2020 at 1:40 AM Richard Biener > wrote: > > > > On Mon, Mar 2, 2020 at 9:07 AM bin.cheng > > wrote: > > > > > > Hi, > > > This is a simple fix for PR93674. It adds cand carefully for enumeral > > > type iv_use in > > > cas

Re: [PATCH] explow: Fix ICE caused by plus_constant [PR94002]

2020-03-03 Thread Richard Biener
On Tue, 3 Mar 2020, Jakub Jelinek wrote: > Hi! > > The following testcase ICEs in cross to riscv64-linux. The problem is > that we have a DImode integral constant (that doesn't fit into SImode), > which is pushed into a constant pool and later access just the first half of > it using a MEM. Whe

[PATCH] [COMMITTED] arc: Add ARC entry for gcc-10/changes.html

2020-03-03 Thread Claudiu Zissulescu
Add ARC entry for gcc-10/changes.html --- htdocs/gcc-10/changes.html | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html index 53d0ca08..4e27c05b 100644 --- a/htdocs/gcc-10/changes.html +++ b/htdocs/gcc-10/chan

[PATCH] Wrap array in ctor with braces.

2020-03-03 Thread Martin Liška
Hi. The patch is about to silent a few clang warnings: /home/marxin/Programming/gcc/gcc/cp/method.c:903:26: warning: suggest braces around initialization of subobject [-Wmissing-braces] { "partial_ordering", "equivalent", "greater", "less", "unordered" }, ^~~

Re: [PATCH 4/4] arc: Update legitimate small data address.

2020-03-03 Thread Claudiu Zissulescu
Thank you for your review. All 4 patches are pushed. Claudiu From: Jeff Law Sent: Friday, February 28, 2020 11:15 PM To: Claudiu Zissulescu ; gcc-patches@gcc.gnu.org Cc: Claudiu Zissulescu ; Francois Bedard ; andrew.burg...@embecosm.com Subject: Re: [PATCH 4/

Re: [PATCH] Clear --help=language and --help=common interaction.

2020-03-03 Thread Martin Liška
On 3/2/20 11:52 PM, Joseph Myers wrote: On Mon, 2 Mar 2020, Martin Liška wrote: +version of GCC@. If an option is supported by all languages, one needs +to use @var{common} qualifier instead. "common" is literal text, so it should be @samp{common} not @var{common}, and the existing documenta

[PATCH] PR target/93995 ICE in patch_jump_insn, at cfgrtl.c:1290 on riscv64-linux-gnu

2020-03-03 Thread Kito Cheng
Last code gen change of LTGT didn't consider the situation of cbranch with LTGT, branch only support few compare codes. gcc/ChangeLog * config/riscv/riscv.c (riscv_emit_float_compare): Using NE to compare the result of IOR. gcc/testsuite/ChangeLog * gcc.dg/pr93995.c: New