Re: [PATCH] [PING] Asan changes for RISC-V.

2020-11-06 Thread Kito Cheng via Gcc-patches
LGTM. Verified with Fedora rawhide image running on qemu, kernel version is 5.5.0, I got slightly different gcc testsuite result, but after reviewing all failed cases, it should not be a blocker for this patch. It seems environment issue, some minor issues like stack unwinding or library search

Re: Fwd: libstdc++: Attempt to resolve PR83562

2020-11-06 Thread Liu Hao via Gcc-patches
Ping? 在 2020/10/29 下午3:56, Liu Hao 写道: > I forward it here for comments. > > Basing on the behavior of both GCC and Clang, `__cxa_thread_atexit` is used > to register the > destructor of thread_local objects directly, suggesting the first parameter > should have `__thiscall` > convention.

Re: Fwd: libstdc++: Attempt to resolve PR83562

2020-11-06 Thread Martin Storsjö
On Fri, 6 Nov 2020, Liu Hao via Gcc-patches wrote: 在 2020/10/29 下午3:56, Liu Hao 写道: I forward it here for comments. Basing on the behavior of both GCC and Clang, `__cxa_thread_atexit` is used to register the destructor of thread_local objects directly, suggesting the first parameter should h

Re: [PATCH] dumpfile.c: use prefixes other that 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION}

2020-11-06 Thread Thomas Schwinge
Hi! On 2018-09-25T16:00:14-0400, David Malcolm wrote: > As noted at Cauldron, dumpfile.c currently emits "note: " for all kinds > of dump message, so that (after filtering) there's no distinction between > MSG_OPTIMIZED_LOCATIONS vs MSG_NOTE vs MSG_MISSED_OPTIMIZATION in the > textual output. > >

[PATCH] tree-optimization/97732 - fix init of SLP induction vectorization

2020-11-06 Thread Richard Biener
This PR exposes two issues - one that the vector builder treats &x as eligible for VECTOR_CST elements and one that SLP induction vectorization forgets to convert init elements to the vector component type which makes a difference for pointer vs. integer. Bootstrap & regtest pending on x86_64-unkn

Re: [PATCH] SLP: Move load/store-lanes check till late

2020-11-06 Thread Christophe Lyon via Gcc-patches
On Thu, 5 Nov 2020 at 11:21, Tamar Christina via Gcc-patches wrote: > > > -Original Message- > > From: rguent...@c653.arch.suse.de On > > Behalf Of Richard Biener > > Sent: Thursday, November 5, 2020 10:17 AM > > To: Tamar Christina > > Cc: gcc-patches@gcc.gnu.org; nd ; o...@ucw.cz > > S

Re: [PATCH] dumpfile.c: use prefixes other that 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION}

2020-11-06 Thread Thomas Schwinge
Hi! On 2018-09-25T16:00:14-0400, David Malcolm wrote: > The patch adds "dg-optimized" and "dg-missed" directives Another small thing I just noticed: > --- a/gcc/testsuite/lib/gcc-dg.exp > +++ b/gcc/testsuite/lib/gcc-dg.exp > +# Handle output from -fopt-info for MSG_OPTIMIZED_LOCATIONS: > +# a

Re: [r11-4733 Regression] FAIL: gcc.dg/guality/pr54519-4.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects -DPREVENT_OPTIMIZATION line 17 y == 25 on Linux/x86_64

2020-11-06 Thread Richard Biener
On Thu, 5 Nov 2020, sunil.k.pandey wrote: > On Linux/x86_64, > > 1436ef2a57e79b6b8ce5b03e32a38dd64f46c97c is the first bad commit > commit 1436ef2a57e79b6b8ce5b03e32a38dd64f46c97c > Author: Richard Biener > Date: Thu Nov 5 09:27:28 2020 +0100 > > debug/97718 - fix abstract origin referenc

[committed] common: Remove DEBUG_FUNCTION from verify_sequence_points

2020-11-06 Thread Jakub Jelinek via Gcc-patches
Hi! While perhaps the function name might suggest that it is a verification/debugging only routine, it is actually implementation of the -Wsequence-point warning and so doesn't need the DEBUG_FUNCTION macro on it. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvio

[PATCH] c++: Propagate attributes to clones in duplicate_decls [PR67453]

2020-11-06 Thread Jakub Jelinek via Gcc-patches
Hi! On the following testcase where the cdtor attributes aren't on the in-class declaration but on an out-of-class definition, the cdtors have their clones created from the in-class declaration, and later on duplicate_decls updates attributes on the abstract cdtors, but nothing propagates them to

Add 'dg-note' next to 'dg-optimized', 'dg-missed' (was: [PATCH] dumpfile.c: use prefixes other that 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION})

2020-11-06 Thread Thomas Schwinge
Hi, again! On 2018-09-25T16:00:14-0400, David Malcolm wrote: > As noted at Cauldron, dumpfile.c currently emits "note: " for all kinds > of dump message, so that (after filtering) there's no distinction between > MSG_OPTIMIZED_LOCATIONS vs MSG_NOTE vs MSG_MISSED_OPTIMIZATION in the > textual outp

[PATCH v3] Include checking of 0 cost dependency due to bypass in rank_for_schedule

2020-11-06 Thread Jojo R
Insn seqs before sched: .L1: a5 = insn-1 (a0) a6 = insn-2 (a1) a7 = insn-3 (a7, a5) a8 = insn-4 (a8, a6) Jmp .L1 Insn-3 & insn-4 is REG_DEP_TRUE of insn-1 & insn-2, so insn-3 & insn-4 will be as the last of ready list. And this patch will put 0 cost dependency due to a bypass as highest numbered

Re: [PATCH v2] Replace dep_list_size with dep_list_costs for better scheduling

2020-11-06 Thread Jojo R
Jojo 在 2020年11月6日 +0800 AM11:18,Jeff Law ,写道: On 11/5/20 7:50 PM, Jim Wilson wrote: On Thu, Nov 5, 2020 at 6:03 PM Jojo R wrote: > >         gcc/ > >         * haifa-sched.c (dep_list_costs): New. > >         (rank_for_schedule): Use dep_list_costs. > > When you post a patch, you should

Re: [PATCH v2] Add bypass_p cost check in flag_sched_last_insn_heuristic

2020-11-06 Thread Jojo R
Jojo 在 2020年11月6日 +0800 AM11:18,Jeff Law ,写道: On 11/5/20 7:52 PM, Jim Wilson wrote: On Thu, Nov 5, 2020 at 6:10 PM Jojo R wrote: > >         gcc/ > >         * haifa-sched.c (rank_for_schedule): Add bypass_p > >         cost check in flag_sched_last_insn_heuristic. > > > > +         ||

Re: [Patch] x86: Enable GCC support for Intel AVX-VNNI extension

2020-11-06 Thread Uros Bizjak via Gcc-patches
> This patch is about to support Intel AVX-VNNI instructions. > > AVX-VNNI is an equivalent to AVX512-VNNI with VEX encoding. The instructions > are same, but with extra {vex} prefix to distinguish from AVX512-VNNI > instructions > in assembler. > > For more details, please refer to > https://sof

Re: Use EAF_RETURN_ARG in tree-ssa-ccp.c

2020-11-06 Thread Richard Biener
On Thu, 5 Nov 2020, Jan Hubicka wrote: > > > > On 10/27/20 3:01 AM, Richard Biener wrote: > > > On Tue, 27 Oct 2020, Jan Hubicka wrote: > > > > > >>> On Mon, 26 Oct 2020, Jan Hubicka wrote: > > >>> > > Hi, > > while looking for special cases of buitins I noticed that tree-ssa-ccp > > >>

Re: [PATCH, 1/3, OpenMP] Target mapping changes for OpenMP 5.0, front-end parts

2020-11-06 Thread Jakub Jelinek via Gcc-patches
On Wed, Nov 04, 2020 at 02:02:25AM +0800, Chung-Lin Tang wrote: > gcc/c-family/ > * c-common.h (c_omp_adjust_map_clauses): New declaration. > * c-omp.c (c_omp_adjust_map_clauses): New function. > > gcc/c/ > * c-parser.c (c_parser_omp_target_data): Add use of > n

Re: [PATCH, 2/3, OpenMP] Target mapping changes for OpenMP 5.0, middle-end parts and compiler testcases

2020-11-06 Thread Jakub Jelinek via Gcc-patches
On Wed, Nov 04, 2020 at 02:02:56AM +0800, Chung-Lin Tang wrote: > gcc/ > * gimplify.c (is_or_contains_p): New static helper function. > (omp_target_reorder_clauses): New function. > (gimplify_scan_omp_clauses): Add use of omp_target_reorder_clauses to > reorder clause

Re: [PATCH] Clean up loop-closed PHIs at loopdone pass

2020-11-06 Thread Richard Biener
On Fri, 6 Nov 2020, Jiufu Guo wrote: > On 2020-11-05 21:43, Richard Biener wrote: > > Hi Richard, > > Thanks for your comments and suggestions! > > > On Thu, Nov 5, 2020 at 2:19 PM guojiufu via Gcc-patches > > wrote: > >> > >> In PR87473, there are discussions about loop-closed PHIs which > >

Re: [PATCH, 3/3, OpenMP] Target mapping changes for OpenMP 5.0, libgomp parts [resend]

2020-11-06 Thread Jakub Jelinek via Gcc-patches
On Wed, Nov 04, 2020 at 02:03:27AM +0800, Chung-Lin Tang wrote: > >     libgomp/ > >     * libgomp.h (enum gomp_map_vars_kind): Adjust enum values to be > > bit-flag > >     usable. > >     * oacc-mem.c (acc_map_data): Adjust gomp_map_vars argument flags to > >     'GOMP_M

Re: [PATCH v9] genemit.c (main): split insn-emit.c for compiling parallelly

2020-11-06 Thread Richard Sandiford via Gcc-patches
Sorry, going it over it again before committing, I spotted a couple of things… Jojo R writes: > gcc/ChangeLog: > > * genemit.c (main): Print 'split line'. > * Makefile.in (insn-emit.c): Define split count and file > > --- > gcc/Makefile.in | 35 +++- > gcc/genemit.c |

RE: [PATCH] SLP: Move load/store-lanes check till late

2020-11-06 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Christophe Lyon > Sent: Friday, November 6, 2020 8:42 AM > To: Tamar Christina > Cc: Richard Biener ; nd ; gcc- > patc...@gcc.gnu.org; o...@ucw.cz > Subject: Re: [PATCH] SLP: Move load/store-lanes check till late > > On Thu, 5 Nov 2020 at 11:21, Tamar Chris

Re: [PATCH] SLP: Move load/store-lanes check till late

2020-11-06 Thread Christophe Lyon via Gcc-patches
On Fri, 6 Nov 2020 at 11:18, Tamar Christina wrote: > > > > > -Original Message- > > From: Christophe Lyon > > Sent: Friday, November 6, 2020 8:42 AM > > To: Tamar Christina > > Cc: Richard Biener ; nd ; gcc- > > patc...@gcc.gnu.org; o...@ucw.cz > > Subject: Re: [PATCH] SLP: Move load/st

Re: [Patch] OpenACC (C/C++): Fix 'acc atomic' parsing

2020-11-06 Thread Tobias Burnus
On 05.11.20 13:13, Jakub Jelinek wrote: Wouldn't it be much simpler and more readable to do: else if (!strcmp (p, "capture")) new_code = OMP_ATOMIC_CAPTURE_NEW; + else if (openacc) + { + p = NULL; + error_at (cloc, "expected %, %, %, " +

Re: [committed 1/2] libstdc++: Export basic_stringbuf constructor [PR 97729]

2020-11-06 Thread Rainer Orth
Hi Jonathan, > libstdc++-v3/ChangeLog: > > PR libstdc++/97729 > * config/abi/pre/gnu.ver (GLIBCXX_3.4.29): Add exports. > * src/c++20/sstream-inst.cc (basic_stringbuf): Instantiate > private constructor taking __xfer_bufptrs. > > Tested powerpc64le-linux. Committed to trunk

Re: Move pass_oacc_device_lower after pass_graphite

2020-11-06 Thread Frederik Harwath
Hi Richard, Richard Biener writes: > On Tue, Nov 3, 2020 at 4:31 PM Frederik Harwath > What's on my TODO list (or on the list of things to explore) is to make > the dump file names/suffixes explicit in passes.def like via > > NEXT_PASS (pass_ccp, true /* nonzero_p */, "oacc") > > and we'd ge

[Patch, committed] OpenACC/Fortran: Reject '!$acc atomic update capture'

2020-11-06 Thread Tobias Burnus
This patch adds some OpenACC atomic testcases, based on my just committed C/C++ patch. https://gcc.gnu.org/pipermail/gcc-patches/2020-November/558288.html And it fixes an issue I introduced when updating the Fortran atomic handling (for OpenMP and a bit OpenACC) at https://gcc.gnu.org/pipermail/g

RE: [PATCH] SLP: Move load/store-lanes check till late

2020-11-06 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Christophe Lyon > Sent: Friday, November 6, 2020 10:27 AM > To: Tamar Christina > Cc: Richard Biener ; nd ; gcc- > patc...@gcc.gnu.org; o...@ucw.cz > Subject: Re: [PATCH] SLP: Move load/store-lanes check till late > > On Fri, 6 Nov 2020 at 11:18, Tamar Chri

Re: [PATCH] SLP: Move load/store-lanes check till late

2020-11-06 Thread Christophe Lyon via Gcc-patches
On Fri, 6 Nov 2020 at 12:33, Tamar Christina wrote: > > > > > -Original Message- > > From: Christophe Lyon > > Sent: Friday, November 6, 2020 10:27 AM > > To: Tamar Christina > > Cc: Richard Biener ; nd ; gcc- > > patc...@gcc.gnu.org; o...@ucw.cz > > Subject: Re: [PATCH] SLP: Move load/s

[PATCH] tree-optimization/97706 - part one, refactor vect_determine_mask_precision

2020-11-06 Thread Richard Biener
This computes vect_determine_mask_precision in a RPO forward walk rather than in a backward walk and using a worklist. It will make fixing PR97706 easier but for bisecting I wanted it to be separate. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2020-11-06 Richard Biener

Re: [RFC PATCH] phiopt: Optimize x ? 1024 : 0 to (int) x << 10 [PR97690]

2020-11-06 Thread Christophe Lyon via Gcc-patches
On Wed, 4 Nov 2020 at 10:59, Richard Biener wrote: > > On Wed, 4 Nov 2020, Jakub Jelinek wrote: > > > Hi! > > > > The following patch generalizes the x ? 1 : 0 -> (int) x optimization > > to handle also left shifts by constant. > > > > During x86_64-linux and i686-linux bootstraps + regtests it tr

Move ipa-refs from GC to heap

2020-11-06 Thread Jan Hubicka
Hi, this patch moves ipa-refs from ggc to heap. They are half in heap anyway (so they can not go to PCH) and thus finishing it easy and makes code also bit cleaner. While refs points to statements all those statements are also reachable from function bodies. Bootstrapped/regtested x86_64-linux.

Re: [PING] [PATCH] S/390: Do not turn maybe-uninitialized warnings into errors

2020-11-06 Thread Andreas Krebbel via Gcc-patches
On 06.11.20 04:52, Jeff Law via Gcc-patches wrote: > > On 10/30/20 7:01 AM, Richard Biener wrote: >> >> It's not that more / different inlining inherently exposes _more_ >> false positives in the middle-end warnings. They simply expose >> others and the GCC codebase is cleansed (by those who chan

[committed] ipa-modref: Fix comment typos

2020-11-06 Thread Jakub Jelinek via Gcc-patches
Hi! I've done this mainly to test whether the git hooks logging of sent mails hack I've added to help debugging the missing mails problem works. 2020-11-06 Jakub Jelinek * ipa-modref-tree.h: Fix comment typos. * ipa-modref.c: Likewise. --- gcc/ipa-modref-tree.h +++ gcc/ipa-mo

Re: [PATCH v2] Add if-chain to switch conversion pass.

2020-11-06 Thread Richard Biener via Gcc-patches
On Fri, Oct 16, 2020 at 4:04 PM Martin Liška wrote: > > Hello. > > There's another version of the patch that should be based on what > I discussed with Richi and Jakub: > > - the first patch introduces a new option -fbit-tests that analogue to > -fjump-tables >and will control the new if-to-s

[PATCH] refactor SLP analysis

2020-11-06 Thread Richard Biener
This passes down the graph entry kind down to vect_analyze_slp_instance which simplifies it and makes it a shallow wrapper around vect_build_slp_instance. Bootstrapped / tested on x86_64-unknown-linux-gnu, pushed. 2020-11-06 Richard Biener * tree-vect-slp.c (vect_analyze_slp): Pass do

Re: Move pass_oacc_device_lower after pass_graphite

2020-11-06 Thread Richard Biener via Gcc-patches
On Fri, Nov 6, 2020 at 12:18 PM Frederik Harwath wrote: > > > Hi Richard, > > Richard Biener writes: > > > On Tue, Nov 3, 2020 at 4:31 PM Frederik Harwath > > > What's on my TODO list (or on the list of things to explore) is to make > > the dump file names/suffixes explicit in passes.def like via

Re: [patch] Add dg-require-effective-target fpic to an aarch64 specific test in gcc.dg

2020-11-06 Thread Olivier Hainque
> On 4 Nov 2020, at 20:16, Richard Sandiford wrote: > > Olivier Hainque writes: >> Hello, >> >> This patch adds dg-require-effective-target fpic >> to an aarch64 specific gcc.dg test using -fPIC, >> which helps circumvent a failure we observed while >> testing the aarch64 port for VxWorks. >

Re: [patch] i386 tests: Add dg-require-profiling to i386 tests using -pg

2020-11-06 Thread Olivier Hainque
> On 6 Nov 2020, at 04:56, Jeff Law wrote: > > OK Thanks for your prompt feedback Jeff!

Re: Split up "gfortran.dg/goacc/loop-2.f95"

2020-11-06 Thread Thomas Schwinge
Hi! On 2018-12-09T13:56:40+0100, I wrote: > Committed to trunk in r266921: > Split up "gfortran.dg/goacc/loop-2.f95" > > gcc/testsuite/ > * gfortran.dg/goacc/loop-2.f95: Split into... > * gfortran.dg/goacc/loop-2-kernels-nested.f95: ... this new >

Re: Use existing middle end checking for Fortran OpenACC loop clauses

2020-11-06 Thread Thomas Schwinge
Hi! On 2018-12-09T13:58:51+0100, I wrote: > Committed to trunk in r266922: > Use existing middle end checking for Fortran OpenACC loop clauses > > Don't duplicate in the Fortran front end what's generically being checked > in > the middle end. > > gcc/fortran/ >

[PATCH][pushed] testsuite: fix malloc alignment in test

2020-11-06 Thread Martin Liška
Hi. The patch fixes the testcase on ppc64. I'm going to push the commit. Martin gcc/testsuite/ChangeLog: PR gcov-profile/97461 * gcc.dg/tree-prof/pr97461.c: Return aligned memory. --- gcc/testsuite/gcc.dg/tree-prof/pr97461.c | 8 +++- 1 file changed, 7 insertions(+), 1 del

c++: Parser tweaks

2020-11-06 Thread Nathan Sidwell
We need to adjust the wording for 'export'. Between c++11 and c++20 it is deprecated. Outside those ranges it is unsupported (at the moment). While here, there's also an unneeded setting of a bool -- it's inside an if block that just checked it was true. gcc/cp/ * parser.c (cp

[PATCH] tree-optimization/97706 - handle PHIs in pattern recog mask precison

2020-11-06 Thread Richard Biener
This adds handling of PHIs to mask precision compute which is eventually needed to detect a bool pattern when the def chain contains such a PHI node. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2020-11-06 Richard Biener PR tree-optimization/97706 * tree-vect-p

[PATCH V2] arm: [testcase] Better narrow some bfloat16 testcase

2020-11-06 Thread Andrea Corallo via Gcc-patches
Christophe Lyon writes: > On Thu, 5 Nov 2020 at 15:30, Andrea Corallo wrote: >> >> Christophe Lyon writes: >> >> > On Thu, 5 Nov 2020 at 12:11, Andrea Corallo wrote: >> >> >> >> Christophe Lyon writes: >> >> >> >> [...] >> >> >> >> >> I think you need to add -mfloat-abi=hard to the dg-additio

Re: [00/32] C++ 20 Modules

2020-11-06 Thread Boris Kolpackov
Nathan Sidwell writes: > The repo is providing a mechanism by which two processes can synchronize > on a fixed location in the file system that is not /. You need such a > capability as the file system is the bulk transfer mechanism. > > The alternatives are to always use absolute paths, or r

[PATCH 4/6] Add documentation for dead field elimination

2020-11-06 Thread Erick Ochoa
From 015634bee522cf6224b0d4bcfd3adaf3a6a38fa0 Mon Sep 17 00:00:00 2001 From: Erick Ochoa Date: Mon, 10 Aug 2020 09:10:37 +0200 Subject: [PATCH 4/6] Add documentation for dead field elimination 2020-11-04 Erick Ochoa * gcc/Makefile.in: Add file to documentation sources * gcc/doc/dfe.t

[PATCH 2/6] Add Dead Field Elimination

2020-11-06 Thread Erick Ochoa
From 2cd94824269e94babedd2a963e4b9ee96889ec82 Mon Sep 17 00:00:00 2001 From: Erick Ochoa Date: Thu, 6 Aug 2020 14:07:20 +0200 Subject: [PATCH 2/6] Add Dead Field Elimination Using the Dead Field Analysis, Dead Field Elimination automatically transforms gimple to eliminate fields that are never r

[PATCH 0/6] Dead Field Elimination and Field Reorder

2020-11-06 Thread Erick Ochoa
Just submitting changes to the previously submitted patches. * I have removed all non-essential flags I introduced * I have placed the standard headers before config * I have squashed some changes that I sent to the patches mailing list and make sure that the transformation bootstraps on every c

[PATCH 6/6] Add heuristic to take into account void* pattern.

2020-11-06 Thread Erick Ochoa
From ccd82a7e484d9e4562c23f1b9cbebf3f47e2a822 Mon Sep 17 00:00:00 2001 From: Erick Ochoa Date: Fri, 16 Oct 2020 08:49:08 +0200 Subject: [PATCH 6/6] Add heuristic to take into account void* pattern. We add a heuristic in order to be able to transform functions which receive void* arguments as a w

[PATCH 5/6] Abort if Gimple from C++ or Fortran sources is found.

2020-11-06 Thread Erick Ochoa
From f5dbfa73962d5443013d0193b2f91ea112a6d2d1 Mon Sep 17 00:00:00 2001 From: Erick Ochoa Date: Sun, 30 Aug 2020 10:21:35 +0200 Subject: [PATCH 5/6] Abort if Gimple from C++ or Fortran sources is found. 2020-11-04 Erick Ochoa * gcc/ipa-field-reorder: Add flag to exit transformation *

[PATCH 3/6] Add Field Reordering

2020-11-06 Thread Erick Ochoa
From 72e6ea57b04ca2bf223faef262b478dc407cdca7 Mon Sep 17 00:00:00 2001 From: Erick Ochoa Date: Sun, 9 Aug 2020 10:22:49 +0200 Subject: [PATCH 3/6] Add Field Reordering Field reordering of structs at link-time 2020-11-04 Erick Ochoa * gcc/Makefile.in: add new file to list of sources

[PATCH] make PRE constant value IDs negative

2020-11-06 Thread Richard Biener
This separates constant and non-constant value-ids to allow for a more efficient constant_value_id_p and for more efficient bit-packing inside the bitmap sets which never contain any constant values. There's further optimization opportunities but at this stage I'll do small refactorings. Bootstra

Re: [PATCH]ira: recompute regstat as max_regno changes [PR97705]

2020-11-06 Thread Vladimir Makarov via Gcc-patches
On 2020-11-06 1:15 a.m., Kewen.Lin wrote: Hi, As PR97705 shows, my commit r11-4637 caused some dumping comparison difference error on pass ira. It exposed one issue about the newly introduced function remove_scratches, which can increase the largest pseudo reg number if it succeeds, later som

Re: [PATCH] arm: Implement vceqq_p64, vceqz_p64 and vceqzq_p64 intrinsics

2020-11-06 Thread Christophe Lyon via Gcc-patches
On Thu, 5 Nov 2020 at 12:55, Christophe Lyon wrote: > > On Thu, 5 Nov 2020 at 10:36, Kyrylo Tkachov wrote: > > > > H, Christophe, > > > > > -Original Message- > > > From: Gcc-patches On Behalf Of > > > Christophe Lyon via Gcc-patches > > > Sent: 15 October 2020 18:23 > > > To: gcc-patche

Re: Fix uninitialized memory use in ipa-modref

2020-11-06 Thread Martin Liška
On 11/5/20 6:54 PM, Jan Hubicka wrote: On 11/5/20 3:27 PM, Jan Hubicka wrote: poly_int64 offset; struct modref_parm_map parm_map; + parm_map.parm_offset_known = false; + parm_map.parm_offset = 0; + I'm curious, can't we use a proper C++ class construction. The IPA pass is new and s

Re: Fix uninitialized memory use in ipa-modref

2020-11-06 Thread Martin Liška
On 11/5/20 6:37 PM, Jan Hubicka wrote: We can't because our vec does not accept non-pods and this needs to be GGC safe since it points to trees. Ah, that's new to me! Thanks, Martin

Re: [PATCH] generalized range_query class for multiple contexts

2020-11-06 Thread Martin Sebor via Gcc-patches
On 11/5/20 8:08 PM, Andrew MacLeod wrote: On 11/5/20 7:50 PM, Martin Sebor wrote: On 11/5/20 5:02 PM, Andrew MacLeod wrote: On 11/5/20 4:02 PM, Martin Sebor wrote: On 11/5/20 12:29 PM, Martin Sebor wrote: On 10/1/20 11:25 AM, Martin Sebor wrote: On 10/1/20 9:34 AM, Aldy Hernandez wrote: O

Re: [PATCH] use get_size_range to get allocated size (PR 92942)

2020-11-06 Thread Jeff Law via Gcc-patches
On 8/28/20 11:12 AM, Martin Sebor via Gcc-patches wrote: > The gimple_call_alloc_size() function that determines the range > of sizes of allocated objects and constrains the bounds in calls > to functions like memcpy calls get_range() instead of > get_size_range() to obtain its result.  The latte

Re: [PATCH] issue -Wstring-compare in more case (PR 95673)

2020-11-06 Thread Jeff Law via Gcc-patches
On 9/30/20 6:14 PM, Martin Sebor via Gcc-patches wrote: > -Wstring-compare triggers under the same strict conditions as > the strcmp/strncmp call is folded into a constant: only when > all the uses of the result are [in]equality expressions with > zero.  However, even when the call cannot be fold

Re: Patch for 96948

2020-11-06 Thread Jeff Law via Gcc-patches
On 9/8/20 9:34 AM, Martin Storsjö wrote: > Hi, > > On Tue, 8 Sep 2020, Kirill Müller wrote: > >> Thanks for the heads up. The coincidence is funny -- a file that >> hasn't been touched for years. > > I think we both may originally be triggered from the same guy asking > around in different places

Re: [PATCH, rs6000] Update instruction attributes for Power10

2020-11-06 Thread Pat Haugen via Gcc-patches
On 11/5/20 4:32 PM, will schmidt wrote: > On Wed, 2020-11-04 at 14:42 -0600, Pat Haugen via Gcc-patches wrote: >> * config/rs6000/rs6000.c (rs6000_final_prescan_insn): Only add 'p' for >> PREFIXED_YES. > > The code change reads as roughly > - next_insn_prefixed_p != PREFIXED_NO > > + n

[PATCH] aarch64: Support permutes on unpacked SVE vectors

2020-11-06 Thread Richard Sandiford via Gcc-patches
This patch adds support for permuting unpacked SVE vectors using: - DUP - EXT - REV[BHW] - REV - TRN[12] - UZP[12] - ZIP[12] This involves rewriting the REV[BHW] permute code so that the inputs and outputs of the insn pattern have the same mode as the vectors being permuted. This is different fr

libcpp: Provide date routine

2020-11-06 Thread Nathan Sidwell
Joseph pointed me at cb_get_source_date_epoch, which allows repeatable builds and solves a FIXME I had on the modules branch. Unfortunately it's used exclusively to generate __DATE__ and __TIME__ values, which fallback to using a time(2) call. It'd be nicer if the preprocessor made whatever time

[PATCH] rework PRE PHI translation cache

2020-11-06 Thread Richard Biener
Turns out its size and time requirements can be stripped down dramatically. Bootstrap & regtest running on x86_64-unknown-linux-gnu. 2020-11-06 Richard Biener * tree-ssa-pre.c (expr_pred_trans_d): Modify so elements are embedded rather than allocated. Remove hashval member,

Re: [21/32] miscelaneous

2020-11-06 Thread Nathan Sidwell
On 11/5/20 8:30 AM, Richard Biener wrote: On Tue, Nov 3, 2020 at 10:16 PM Nathan Sidwell wrote: These are changes to gcc/tree.h adding some raw accessors to nodes, which seemed preferable to direct field access. I also needed access to the integral constant cache can you please document the

Re: [PATCH] Support the new ("v0") mangling scheme in rust-demangle.

2020-11-06 Thread Jeff Law via Gcc-patches
On 11/1/20 10:26 AM, Nikhil Benesch via Gcc-patches wrote: > > > On 11/1/20 6:57 AM, Eduard-Mihai Burtescu wrote: >> Reading the diff patch, the v0 changes look great. I wouldn't be too >> worried >> about the "printable character" aspect, there are similar >> Unicode-related >> issues elsewhere,

Re: [PATCH] arc: Improve/add instruction patterns to better use MAC instructions.

2020-11-06 Thread Jeff Law via Gcc-patches
On 10/9/20 8:24 AM, Claudiu Zissulescu wrote: > From: Claudiu Zissulescu > > ARC MYP7+ instructions add MAC instructions for vector and scalar data > types. This patch adds a madd pattern for 16it datum that is using the > 32bit MAC instruction, and dot_prod patterns for v4hi vector > types. The

Re: [PATCH] Optimize macro: make it more predictable

2020-11-06 Thread Jeff Law via Gcc-patches
On 10/23/20 5:47 AM, Martin Liška wrote: > Hey. > > This is a follow-up of the discussion that happened in thread about > no_stack_protector > attribute: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545916.html > > The current optimize attribute works in the following way: > - 1) we take c

Re: Rename DECL_IS_BUILTIN to DECL_IS_UNDECLARED_BUILTIN

2020-11-06 Thread Jeff Law via Gcc-patches
On 10/23/20 6:48 AM, Nathan Sidwell wrote: > Patch affects C++, C, GO, common-core > > In cleaning up C++'s handling of hidden decls, I renamed its > DECL_BUILTIN_P, which checks for loc == BUILTINS_LOCATION to > DECL_UNDECLARED_BUILTIN_P, because the location gets updated, if user > source decla

Re: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 13.0.0

2020-11-06 Thread Jeff Law via Gcc-patches
On 10/23/20 9:01 AM, Lewis Hyatt via Gcc-patches wrote: > Hello- > > The attached patch updates cpp_wcwidth() (for computation of display > widths needed to calculate column numbers in diagnostics) from Unicode 12 > to Unicode 13. The patch was purely mechanical, following the directions > in con

Re: [PATCH] c-family: Fix regression in location-overflow-test-1.c [PR97117]

2020-11-06 Thread Jeff Law via Gcc-patches
On 10/14/20 9:56 AM, Patrick Palka via Gcc-patches wrote: > The r11-3266 patch that added macro support to -Wmisleading-indentation > accidentally suppressed the column-tracking diagnostic in > get_visual_column in some cases, e.g. in the location-overflow-test-1.c > testcase. > > More generally,

Re: [Patch, fortran] PR83118 - [8/9/10/11 Regression] Bad intrinsic assignment of class(*) array component of derived type

2020-11-06 Thread Tobias Burnus
Hi Paul, sorry for the belated attempt to review your patch. Attempt as both via @gcc.gnu.org as in the direct email, I did not see the attached patch. (Matches what Andre mentioned to you today at IRC #gfortran.) I only see: * Content-Type: multipart/alternative Content-Type: text/plain; char

Re: [Patch] testsuite: Avoid TCL errors when rootme or ASAN/TSAN/UBSAN is not available (was: Re: [Patch] testsuite: Avoid TCL errors when ASAN/TSAN/UBSAN is not available)

2020-11-06 Thread Jeff Law via Gcc-patches
On 10/19/20 10:03 AM, Tobias Burnus wrote: > Thomas Schwinge and Joseph convinced me that 'rootme' only makes sense > for in-tree testing and, hence, does not need (or: should not) be set in > site.exp. > > Thus, if it is not set, we have to check its existence before using it – > to avoid simila

Re: builtins: Add DFP signaling NaN built-in functions

2020-11-06 Thread Jeff Law via Gcc-patches
On 11/4/20 5:35 PM, Joseph Myers wrote: > Add built-in functions __builtin_nansd32, __builtin_nansd64 and > __builtin_nansd128 to return signaling NaNs of decimal floating-point > types, analogous to the functions already present for binary > floating-point types. > > This patch, independent of >

Re: float.h: C2x decimal signaling NaN macros

2020-11-06 Thread Jeff Law via Gcc-patches
On 11/5/20 4:21 PM, Joseph Myers wrote: > C2x adds macros for decimal floating-point signaling NaNs to > . Add these macros to GCC's implementation. > > Note that the current C2x draft has these under incorrect names > D32_SNAN, D64_SNAN, D128_SNAN. The intent was to change the naming > conven

Re: [PATCH][AArch64] Use intrinsics for upper saturating shift right

2020-11-06 Thread Richard Sandiford via Gcc-patches
David Candler writes: > Hi Richard, > > Thanks for the feedback. > > Richard Sandiford writes: >> > diff --git a/gcc/config/aarch64/aarch64-builtins.c >> > b/gcc/config/aarch64/aarch64-builtins.c >> > index 4f33dd936c7..f93f4e29c89 100644 >> > --- a/gcc/config/aarch64/aarch64-builtins.c >> > +++

Re: [PATCH, rs6000] Update instruction attributes for Power10

2020-11-06 Thread will schmidt via Gcc-patches
On Fri, 2020-11-06 at 10:46 -0600, Pat Haugen wrote: > On 11/5/20 4:32 PM, will schmidt wrote: > > On Wed, 2020-11-04 at 14:42 -0600, Pat Haugen via Gcc-patches > > wrote: > > > * config/rs6000/rs6000.c (rs6000_final_prescan_insn): Only add > > > 'p' for > > > PREFIXED_YES. > > > > The code ch

Re: [10/32] config

2020-11-06 Thread Jeff Law via Gcc-patches
On 11/4/20 12:24 PM, Nathan Sidwell wrote: > I managed to flub sending this yesterday. > > This is the gcc/configure.ac changes (rebuild configure and > config.h.in after applying).  Generally just checking for > network-related functionality.  If it's not available, those features > of the modul

Re: [patch] Add dg-require-effective-target fpic to an aarch64 specific test in gcc.dg

2020-11-06 Thread Richard Sandiford via Gcc-patches
Olivier Hainque writes: >> On 4 Nov 2020, at 20:16, Richard Sandiford wrote: >> >> Olivier Hainque writes: >>> Hello, >>> >>> This patch adds dg-require-effective-target fpic >>> to an aarch64 specific gcc.dg test using -fPIC, >>> which helps circumvent a failure we observed while >>> testing

Re: [patch] Add dg-require-effective-target fpic to an aarch64 specific test in gcc.dg

2020-11-06 Thread Olivier Hainque
> On 6 Nov 2020, at 19:03, Richard Sandiford wrote: >>> OK, thanks. Also OK for any other current or future aarch64 test that >>> has -fpic or -fPIC in the options and forgets to do this. >> For the avoidance of doubt, that would hold for arm >> tests as well, right ? > > Yeah, it does. >

Re: [10/32] config

2020-11-06 Thread Nathan Sidwell
On 11/6/20 12:56 PM, Jeff Law wrote: On 11/4/20 12:24 PM, Nathan Sidwell wrote: I managed to flub sending this yesterday. This is the gcc/configure.ac changes (rebuild configure and config.h.in after applying).  Generally just checking for network-related functionality.  If it's not available,

[r11-4770 Regression] FAIL: gcc.dg/ipa/modref-2.c scan-ipa-dump modref "Parm 1 param offset:0 offset:0 size:-1 max_size:64" on Linux/x86_64

2020-11-06 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 6cef01c32817b3d08af2cadcdb0e23c72ceed426 is the first bad commit commit 6cef01c32817b3d08af2cadcdb0e23c72ceed426 Author: Jan Hubicka Date: Fri Nov 6 10:23:58 2020 +0100 Add fnspec handling to ipa mode of ipa-modef. caused FAIL: gcc.dg/ipa/modref-2.c scan-ipa-dump modref

Re: [PATCH] RX add control register PC

2020-11-06 Thread Jeff Law via Gcc-patches
On 8/26/20 4:24 AM, Darius Galis wrote: > Hello, > Thank you for adjusting the patch. > I don't have commit privileges, so if you could please commit it, that would > be great. Sorry it took so long.  I got pulled away for most of the last few months. It's committed to the trunk. jeff

[PATCH] c++: DR 1914 - Allow duplicate standard attributes.

2020-11-06 Thread Marek Polacek via Gcc-patches
Following Joseph's change for C to allow duplicate C2x standard attributes , this patch does a similar thing for C++. This is DR 1914, to be resolved by , which is not part of the standard yet, but has a wide support so look like

Re: [PATCH] c++: DR 1914 - Allow duplicate standard attributes.

2020-11-06 Thread Jason Merrill via Gcc-patches
On 11/6/20 2:06 PM, Marek Polacek wrote: Following Joseph's change for C to allow duplicate C2x standard attributes , this patch does a similar thing for C++. This is DR 1914, to be resolved by , which is not part of the standar

Re: [PATCH] c++: Propagate attributes to clones in duplicate_decls [PR67453]

2020-11-06 Thread Jason Merrill via Gcc-patches
On 11/6/20 4:07 AM, Jakub Jelinek wrote: Hi! On the following testcase where the cdtor attributes aren't on the in-class declaration but on an out-of-class definition, the cdtors have their clones created from the in-class declaration, and later on duplicate_decls updates attributes on the abstr

Re: [PATCH] c++: Small tweak to can_convert_eh [PR81660]

2020-11-06 Thread Jason Merrill via Gcc-patches
On 11/6/20 1:15 AM, Marek Polacek wrote: While messing with check_handlers_1, I spotted this bug report which complains that we don't warn about the case when we have two duplicated handlers of type int. can_convert_eh implements [except.handle] and that says: A handler is a match for an excepti

[PATCH] Combine new calculated ranges with existing range.

2020-11-06 Thread Andrew MacLeod via Gcc-patches
This patch fixed PR 97737 and 97741. basically, when we re-calculate a range, intersect it with whatever we knew before so we dont lose any accumulated information.  PR97741 details the specific case, but I was considering doing this anyway as it will allo us to retain any externally accumulat

Re: [PATCH] c++: DR 1914 - Allow duplicate standard attributes.

2020-11-06 Thread Marek Polacek via Gcc-patches
On Fri, Nov 06, 2020 at 02:23:10PM -0500, Jason Merrill via Gcc-patches wrote: > On 11/6/20 2:06 PM, Marek Polacek wrote: > > Following Joseph's change for C to allow duplicate C2x standard attributes > > , > > this patch does a si

[pushed] Darwin: Darwin 20 is to be macOS 11 (Big Sur).

2020-11-06 Thread Iain Sandoe
Hi, It looks like the next macOS release is imminent. Tested across the Darwin patch, and on x86_64-linux-gnu, pushed to master thanks Iain -- As per Nigel Tufnel's assertion "... this one goes to 11". The various parts of the code that deal with mapping Darwin versions to macOS (X) versio

[pushed] Objective-C/C++ (parsers) : Update @property attribute parsing.

2020-11-06 Thread Iain Sandoe
Hi This is preparatory work for bringing at least one aspect of the Objective-C implementation up to date. Tested on a number of Darwin revisions, and x86_64-linux-gnu pushed to master, thanks Iain --- At present, we are missing parsing and checking for around half of the property attribute

Re: [01/32] langhooks

2020-11-06 Thread Jeff Law via Gcc-patches
On 11/3/20 2:13 PM, Nathan Sidwell wrote: > I needed a set of hook interfacing the preprocessor to the language. > they get called from pieces in c-family. > > preprocess_main_file:  we need to know when any forced headers have > been parsed in order to deal with linemaps and macro visibility > >

Re: [PATCH 1/4] c++: Fix ICE with variadic concepts and aliases [PR93907]

2020-11-06 Thread Jason Merrill via Gcc-patches
On 11/5/20 8:40 PM, Patrick Palka wrote: This patch (naively) extends the PR93907 fix to also apply to variadic concepts invoked with a type argument pack. Without this, we ICE on the below testcase (a variadic version of concepts-using2.C) in the same manner as we used to on concepts-using2.C b

[pushed] Objective-C/C++ : Allow visibility prefix attributes on interfaces.

2020-11-06 Thread Iain Sandoe
Hi, Some system headers apply visibility attributes to Objective-C @interface declarations. Those are “default”, but still need to be accepted. tested across the Darwin patch and on x86_64-linux-gnu, pushed to master, thanks Iain - This passes visibility through without warning (so that, f

Re: [PATCH] c++: DR 1914 - Allow duplicate standard attributes.

2020-11-06 Thread Jason Merrill via Gcc-patches
On 11/6/20 2:34 PM, Marek Polacek wrote: On Fri, Nov 06, 2020 at 02:23:10PM -0500, Jason Merrill via Gcc-patches wrote: On 11/6/20 2:06 PM, Marek Polacek wrote: Following Joseph's change for C to allow duplicate C2x standard attributes

Re: [02/32] linemaps

2020-11-06 Thread Jeff Law via Gcc-patches
On 11/3/20 2:13 PM, Nathan Sidwell wrote: > Location handling needs to add 2 things > > 1) a new kind of inclusion -- namely a module.  We add LC_MODULE as a > map kind, > > 2) the ability to allocate blocks of line-maps for both ordinary > locations and macro locations, that are then filled in b

Re: [03/32] cpp-callbacks

2020-11-06 Thread Jeff Law via Gcc-patches
On 11/3/20 2:13 PM, Nathan Sidwell wrote: > Here are the callbacks in the preprocessor itself. > > a) one to handle deferred macros > > b) one to handle include translation.  For every '#include ', > there is the possibility of replacing that with 'import '.  > This hook determines if that happen

[PATCH] openmp: Retire nest-var ICV

2020-11-06 Thread Kwok Cheung Yeung
Hello In addition to deprecating the omp_(get|set)_nested() functions and OMP_NESTED environment variable, OpenMP 5.0 also removes the nest-var ICV altogether, defining it in terms of the max-active-levels-var ICV instead. This patch removes the ICV, and implements the handling of omp_(get|s

Re: [committed 1/2] libstdc++: Export basic_stringbuf constructor [PR 97729]

2020-11-06 Thread Jonathan Wakely via Gcc-patches
On 06/11/20 11:56 +0100, Rainer Orth wrote: Hi Jonathan, libstdc++-v3/ChangeLog: PR libstdc++/97729 * config/abi/pre/gnu.ver (GLIBCXX_3.4.29): Add exports. * src/c++20/sstream-inst.cc (basic_stringbuf): Instantiate private constructor taking __xfer_bufptrs. Tes

  1   2   >