[PATCH][gcc] libgccjit: add bitfield support

2019-06-03 Thread Andrea Corallo
Andrea Corallo andrea.cora...@arm.com * docs/topics/compatibility.rst (LIBGCCJIT_ABI_12): New ABI tag. * docs/topics/types.rst: Add gcc_jit_context_new_bitfield. * jit-common.h (namespace recording): Add class bitfield. * jit-playback.c: Include "c-family/c-common.h" (playbac

[PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

2019-06-10 Thread Andrea Corallo
Hi all, I would like to propose this patch to check for the return type of binary operators to be a numeric type. Not doing so can lead the compiler into funny crashes. Does not introduce regressions running make check-jit. OK for trunk? Bests Andrea 2019-06-09 Andrea Corallo andrea.cora

PING: [PATCH][gcc] libgccjit: add bitfield support

2019-06-18 Thread Andrea Corallo
Just wanted to politely ping to have have a status on that. Bests Andrea Andrea Corallo writes: > Hi all, > I would like to submit this patch that aims to introduce bitfields support > into libgccjit. > > A new entry point gcc_jit_context_new_bitfield is added plus relat

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-06-18 Thread Andrea Corallo
David Malcolm writes: > Thanks for working on this; sorry for the delay in reviewing it. > > Overall, this looks close to being ready, but I have a few notes: > > [...] Cool thanks for the review. I'll adress your comments. When you have time if you could take a look to the other pending patch

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-06-24 Thread Andrea Corallo
Hi all, second version here of the gcc_jit_context_new_bitfield patch addressing review comments. Checked with make check-jit runs clean. Bests Andrea 2019-06-20 Andrea Corallo andrea.cora...@arm.com * docs/topics/compatibility.rst (LIBGCCJIT_ABI_12): New ABI tag. * docs/topics/types.rst

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

2019-06-24 Thread Andrea Corallo
mplex cases can be cause of crashes having the result type structures etc... Tested with make check-jit OK for trunk? Bests Andrea 2019-06-09 Andrea Corallo andrea.cora...@arm.com * libgccjit.c (gcc_jit_context_new_binary_op): Check result_type to be a numeric type. 2019-06-20 Andrea Cora

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

2019-06-24 Thread Andrea Corallo
David Malcolm writes: > On Mon, 2019-06-24 at 15:30 +0000, Andrea Corallo wrote: >> Hi all, >> second version for this patch. >> Given the suggestion for the bit-field one I've tried to improve also >> here the error message. > > Thanks. > >> I&#x

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

2019-06-24 Thread Andrea Corallo
David Malcolm writes: > On Mon, 2019-06-24 at 16:37 +0000, Andrea Corallo wrote: >> David Malcolm writes: >> >> > On Mon, 2019-06-24 at 15:30 +, Andrea Corallo wrote: >> > > Hi all, >> > > second version for this patch. >> > > Give

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

2019-06-25 Thread Andrea Corallo
Hi, third version for this patch with the simplified test. make check-jit pass clean Bests Andrea 2019-06-09 Andrea Corallo andrea.cora...@arm.com * libgccjit.c (gcc_jit_context_new_binary_op): Check result_type to be a numeric type. 2019-06-20 Andrea Corallo andrea.cora...@arm.com

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-06-26 Thread Andrea Corallo
. I'm not sure this assumption is sufficent, in case is not we have to find another way around this. Checked with make check-jit runs clean. Bests Andrea 2019-06-20 Andrea Corallo andrea.cora...@arm.com * docs/topics/compatibility.rst (LIBGCCJIT_ABI_12): New ABI tag. * docs/topics/type

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

2019-06-26 Thread Andrea Corallo
David Malcolm writes: > On Tue, 2019-06-25 at 08:11 +0000, Andrea Corallo wrote: >> Hi, >> third version for this patch with the simplified test. >> >> make check-jit pass clean >> >> Bests >> Andrea >> >> 2019-06-09 A

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-06-27 Thread Andrea Corallo
Hi Dave, last version for this patch addressing the suggestion about the JIT_BIT_FIELD macros comment description. Thank you for all the suggestions. Regarding the write access please see my previous answer into the binary op patch thread. Bests Andrea 2019-06-20 Andrea Corallo andrea.cora

[PATCH] Fix PR83033

2019-03-29 Thread Andrea Corallo
Hi all, simple patch addressing minor style issue into gcc/config/aarch64/cortex-a57-fma-steering.c. make BOOT_CFLAGS='-mcpu=cortex-a57' bootstrap Okay for trunk? Bests Andrea 2019-03-29 Andrea Corallo PR target/83033 * config/aarch64/cortex-a57-fma-

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

2019-07-01 Thread Andrea Corallo
Andrea Corallo writes: > David Malcolm writes: > >> On Tue, 2019-06-25 at 08:11 +0000, Andrea Corallo wrote: >>> Hi, >>> third version for this patch with the simplified test. >>> >>> make check-jit pass clean >>> >>> Bests >&

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

2019-07-02 Thread Andrea Corallo
David Malcolm writes: >> Hi David, >> I can work on to get the SVN commit access. >> As a maintainer has to sponsor it would you mind being the one? > > https://www.gnu.org/software/gcc/svnwrite.html says: > "a well-established GCC maintainer (including reviewers) can approve > for write access

[PATCH, committed] Add myself to MAINTAINERS

2019-07-03 Thread Andrea Corallo
Hi all, I have committed the attached patch adding myself to the Write After Approval section of the MAINTAINERS file. Bests Andrea ChangeLog: 2019-07-02 Andrea Corallo * MAINTAINERS (Write After Approval): Add myself. diff --git a/MAINTAINERS b/MAINTAINERS index b8d703c..7c1eebc

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-07-04 Thread Andrea Corallo
Andrea Corallo writes: > Hi Dave, > last version for this patch addressing the suggestion about the > JIT_BIT_FIELD macros comment description. > > Thank you for all the suggestions. > > Regarding the write access please see my previous answer into the binary > op

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op

2019-07-04 Thread Andrea Corallo
Andrea Corallo writes: > David Malcolm writes: > >>> Hi David, >>> I can work on to get the SVN commit access. >>> As a maintainer has to sponsor it would you mind being the one? >> >> https://www.gnu.org/software/gcc/svnwrite.html says: >

[PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_unary_op

2019-07-18 Thread Andrea Corallo
k-jit runs clean Is it okay for trunk? Bests Andrea gcc/jit/ChangeLog 2019-07-18 Andrea Corallo * libgccjit.c (gcc_jit_context_new_unary_op): Check result_type to be a numeric type. * libgccjit.c (gcc_jit_context_new_binary_op): Fix nit in error message. gcc/test

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_unary_op

2019-07-18 Thread Andrea Corallo
David Malcolm writes: > On Thu, 2019-07-18 at 14:20 +0000, Andrea Corallo wrote: >> Hi all, >> I've just realized that what we has been done recently for >> gcc_jit_context_new_binary_op should be done also for the unary >> version. >> This patch checks

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_unary_op

2019-07-22 Thread Andrea Corallo
Hi all, second version of the patch here addressing comments. make check-jit runs clean Bests Andrea gcc/jit/ChangeLog 2019-07-18 Andrea Corallo * jit-recording.c (unary_op_reproducer_strings): Make it extern. (binary_op_reproducer_strings): Likewise. * jit

Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_unary_op

2019-07-22 Thread Andrea Corallo
David Malcolm writes: > On Thu, 2019-07-18 at 14:20 +0000, Andrea Corallo wrote: >> Hi all, >> I've just realized that what we has been done recently for >> gcc_jit_context_new_binary_op should be done also for the unary >> version. >> This patch checks

Re: [PATCH] Fix PR83033

2019-04-05 Thread Andrea Corallo
Richard Earnshaw (lists) writes: > On 29/03/2019 11:01, Andrea Corallo wrote: >> Hi all, >> simple patch addressing minor style issue into >> gcc/config/aarch64/cortex-a57-fma-steering.c. >> >> make BOOT_CFLAGS='-mcpu=cortex-a57' bootstrap &g

Re: [PATCH] Fix PR83033

2019-04-08 Thread Andrea Corallo
Richard Earnshaw (lists) writes: > Ah, you've just changed the ChangeLog entries. By comments, I meant in > the source code, so that it's clear these don't exist. ChangeLog update > is good too. > > R. Hi Richard, sorry my misunderstanding. Bests Andre

Re: [PATCH] Fix PR83033

2019-04-08 Thread Andrea Corallo
Richard Earnshaw (lists) writes: > On 08/04/2019 09:59, Andrea Corallo wrote: >> >> Richard Earnshaw (lists) writes: >> >>> Ah, you've just changed the ChangeLog entries. By comments, I meant in >>> the source code, so that it's clear the

[PATCH][gcc] libgccjit: handle long literals in playback::context::new_string_literal

2019-09-02 Thread Andrea Corallo
c/jit/ChangeLog 2019-??-?? Andrea Corallo * jit-playback.h (gcc::jit::recording::context m_recording_ctxt): Remove m_char_array_type_node field. * jit-playback.c (playback::context::context) Remove m_char_array_type_node from member initializer

Re: [PATCH][gcc] libgccjit: handle long literals in playback::context::new_string_literal

2019-09-09 Thread Andrea Corallo
Andrea Corallo writes: > Hi all, > yesterday I've found an interesting bug in libgccjit. > Seems we have an hard limitation of 200 characters for literal strings. > Attempting to create longer strings lead to ICE during pass_expand > while performing a sanity check

[PATCH] IPA-CP release transformation summary (PR jit/91928)

2019-09-30 Thread Andrea Corallo
86-64. Bests Andrea gcc/ChangeLog 2019-??-?? Andrea Corallo * cgraphunit.c (expand_all_functions): Release ipcp_transformation_sum when finished. * ipa-prop.c (ipcp_free_transformation_sum): New function. * ipa-prop.h (ipcp_free_transformation_sum): Add declar

Re: [PATCH][gcc] libgccjit: handle long literals in playback::context::new_string_literal

2019-09-30 Thread Andrea Corallo
Andrea Corallo writes: > Andrea Corallo writes: > >> Hi all, >> yesterday I've found an interesting bug in libgccjit. >> Seems we have an hard limitation of 200 characters for literal strings. >> Attempting to create longer strings lead to ICE during pass_

Re: [PATCH] IPA-CP release transformation summary (PR jit/91928)

2019-10-01 Thread Andrea Corallo
Martin Jambor writes: > Hi, > > On Mon, Sep 30 2019, Andrea Corallo wrote: >> Hi all, >> I'd like to submit this patch. >> It release the ipa cp transformation summary after functions being expanded. >> This is to fix the compiler when used with libgccjit on

Re: [PATCH] IPA-CP release transformation summary (PR jit/91928)

2019-10-03 Thread Andrea Corallo
Jeff Law writes: > On 10/1/19 4:11 AM, Andrea Corallo wrote: >> Martin Jambor writes: >> >>> Hi, >>> >>> On Mon, Sep 30 2019, Andrea Corallo wrote: >>>> Hi all, >>>> I'd like to submit this patch. >>>> It releas

[PATCH][gcc] libgccjit: introduce gcc_jit_context_add_driver_option

2019-01-18 Thread Andrea Corallo
-16 Andrea Corallo andrea.cora...@arm.com * docs/topics/compatibility.rst (LIBGCCJIT_ABI_11): New ABI tag. * docs/topics/contexts.rst (Additional driver options): New section. * jit-playback.c (invoke_driver): Add call to append_driver_options. * jit-recording.c: Within namespace gcc::jit

[PATCH][gcc] libgccjit: introduce gcc_jit_context_add_driver_option

2019-01-21 Thread Andrea Corallo
sions running make check-jit Bests Andrea gcc/jit/ChangeLog 2019-01-16 Andrea Corallo andrea.cora...@arm.com * docs/topics/compatibility.rst (LIBGCCJIT_ABI_11): New ABI tag. * docs/topics/contexts.rst (Additional driver options): New section. * jit-playback.c (invoke_driver): Add ca

Re: Late-breaking jit features (was Re: [PATCH][gcc] libgccjit: introduce gcc_jit_context_add_driver_option)

2019-02-05 Thread Andrea Corallo
David Malcolm writes: > On Sat, 2019-02-02 at 16:34 +0100, Jakub Jelinek wrote: >> On Sat, Feb 02, 2019 at 10:18:43AM -0500, David Malcolm wrote: >> > > > Alternatively, should these patches go into a branch of queued >> > > > jit >> > > > changes for gcc 10? >> > > >> > > Is there anything like

Re: [PATCH] IPA-CP release transformation summary (PR jit/91928)

2019-10-05 Thread Andrea Corallo
Jeff Law writes: > On 10/3/19 6:47 AM, Andrea Corallo wrote: >> >> Jeff Law writes: >> >>> On 10/1/19 4:11 AM, Andrea Corallo wrote: >>>> Martin Jambor writes: >>>> >>>>> Hi, >>>>> >>>>> On Mon

[PATCH] arm: Fix unwanted fall-throughs in arm.c

2020-05-28 Thread Andrea Corallo
Hi all, this small patch fix some unintentional fall-throughs in `mve_vector_mem_operand'. Regtested and bootstraped on arm-linux-gnueabihf. Okay for trunk? Regards Andrea gcc/ChangeLog 2020-05-28 Andrea Corallo * config/arm/arm.c (mve_vector_mem_operand): Fix unw

Re: [PATCH] arm: Fix unwanted fall-throughs in arm.c

2020-05-28 Thread Andrea Corallo
Kyrylo Tkachov writes: >> -Original Message- >> From: Andrea Corallo >> Sent: 28 May 2020 10:20 >> To: gcc Patches >> Cc: nd ; Kyrylo Tkachov ; Richard >> Earnshaw >> Subject: [PATCH] arm: Fix unwanted fall-throughs in arm.c >> >>

Re: [PATCH 1/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-05-28 Thread Andrea Corallo
Andrea Corallo writes: > Hi all, > > I'd like to submit this patch introducing the following 64bit builtins > variants as FPCR and FPSR registers getter/setter: > > unsigned long long __builtin_aarch64_get_fpcr64 () > void __builtin_aarch64_set_fpcr64 (unsigned long

[PATCH] [arm] Implement Armv8.1-M low overhead loops

2020-02-11 Thread Andrea Corallo
/ChangeLog: 2020-??-?? Andrea Corallo 2020-??-?? Mihail-Calin Ionescu 2020-??-?? Iain Apreotesei * config/arm/arm.c (TARGET_INVALID_WITHIN_DOLOOP): (arm_invalid_within_doloop): Implement invalid_within_doloop hook. * config/arm/arm.h (TARGET_HAVE_LOB): Add new macro

Re: [PATCH] [arm] Implement Armv8.1-M low overhead loops

2020-02-11 Thread Andrea Corallo
Hi Richard, "Richard Earnshaw (lists)" writes: >> gcc/ChangeLog: >> 2020-??-?? Andrea Corallo >> 2020-??-?? Mihail-Calin Ionescu >> 2020-??-?? Iain Apreotesei >> * config/arm/arm.c (TARGET_INVALID_WITHIN_DOLOOP): >>

Re: [PATCH] [arm] Implement Armv8.1-M low overhead loops

2020-02-13 Thread Andrea Corallo
Hi Roman, Roman Zhuykov writes: > This patch is stage1 material, right? Yes >> >>> +(define_insn "*doloop_end" >>> + [(parallel [(set (pc) >>> + (if_then_else >>> + (ne (reg:SI LR_REGNUM) (const_int 1)) >>> + (label_ref (match_operan

Re: [PATCH] [arm] Implement Armv8.1-M low overhead loops

2020-02-19 Thread Andrea Corallo
str r3, [r0, #4]! addsr3, r3, #1 le lr, .L2 ldr pc, [sp], #4 SMS is disabled in tests not to break them when SMS does loop versioning. bootstrapped arm-none-linux-gnueabihf, do not introduce testsuite regressions. Andrea gcc/ChangeLog: 2020-??-

Re: [PATCH] [arm] Implement Armv8.1-M low overhead loops

2020-02-24 Thread Andrea Corallo
Hi Roman, Roman Zhuykov writes: >> SMS is disabled in tests not to break them when SMS does loop versioning. > > And I'm not really sure about this.  First of all, there are a lot of > scan-assembler-times tests which fail when modulo-scheduler is enabled, > probably the same happens when some u

Re: [PATCH] [arm] Implement Armv8.1-M low overhead loops

2020-02-25 Thread Andrea Corallo
str r3, [r0, #4]! addsr3, r3, #1 le lr, .L2 ldr pc, [sp], #4 bootstrapped arm-none-linux-gnueabihf, do not introduce testsuite regressions. Andrea gcc/ChangeLog: 2020-??-?? Andrea Corallo Mihail-Calin Ionescu

Re: [PATCH][gcc] libgccjit: introduce version entry points

2020-03-06 Thread Andrea Corallo
David Malcolm writes: > On Thu, 2020-01-16 at 11:11 +0000, Andrea Corallo wrote: >> Hi, second version of the patch here cleaning up an unnecessary >> change. >> >> Does not introduce regressions with make check-jit. >> >> Andrea >> >&

Re: [PATCH][gcc] libgccjit: handle long literals in playback::context::new_string_literal

2020-03-07 Thread Andrea Corallo
David Malcolm writes: > On Mon, 2019-09-02 at 09:16 +0000, Andrea Corallo wrote: >> Hi all, >> yesterday I've found an interesting bug in libgccjit. >> Seems we have an hard limitation of 200 characters for literal >> strings. >> Attempting to create longer

Re: [PATCH][gcc] libgccjit: introduce version entry points

2020-03-08 Thread Andrea Corallo
Hi, thanks for reviewing, I've totally missed this multi-thread aspect. David Malcolm writes: > On Thu, 2020-03-05 at 21:34 -0500, David Malcolm wrote: >> On Thu, 2020-01-16 at 11:11 +, Andrea Corallo wrote: > > Responding to my own ideas about thread-safety. >

Re: [PATCH v2][gcc] libgccjit: handle long literals in playback::context::new_string_literal

2020-03-09 Thread Andrea Corallo
Hi all, second version of the patch for the 200 characters limit for literal strings addressing comments. make check-jit is passing clean. Best Regards Andrea gcc/jit/ChangeLog 2020-??-?? Andrea Corallo * jit-playback.h (gcc::jit::playback::context m_recording_ctxt

[PATCH 1/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-10 Thread Andrea Corallo
void __builtin_aarch64_set_fpsr64 (unsigned long long) Regards Andrea gcc/ChangeLog: 2020-??-?? Andrea Corallo * config/aarch64/aarch64-builtins.c (aarch64_builtins): Add enums for 64bits fpsr/fpcr getter setters builtin variants. (aarch64_init_fpsr_fpcr_builtins)

[PATCH 2/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-10 Thread Andrea Corallo
order to preserve the original high 32 bits of the system register. Both FPSR and FPCR became 64bit regs with armv8.1. Bootstrapped on aarch64-linux-gnu, does not introduce regressions. Regards Andrea gcc/ChangeLog: 2020-??-?? Andrea Corallo * config/aarch64/aarch64.md (insv_reg

Re: [PATCH 2/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-17 Thread Andrea Corallo
Andrea Corallo writes: > Hi all, > > second and last patch of the two reworking FPCR and FPSR builtins. > > This rework __builtin_aarch64_set_fpcr (unsigned) and > __builtin_aarch64_set_fpsr (unsigned) to emit a read-modify-sequences > as: > > mrs x1, fps

[PATCH][gcc] libgccjit: introduce version entry points

2020-01-15 Thread Andrea Corallo
. Andrea gcc/jit/ChangeLog 2020-??-?? Andrea Corallo * Make-lang.in (libgccjit.o): Add dependecy plus define BASEVER. * docs/topics/compatibility.rst (LIBGCCJIT_ABI_13): New ABI tag plus add version paragraph. * libgccjit++.h (namespace gccjit::version): Add new

Re: [PATCH][gcc] libgccjit: introduce version entry points

2020-01-16 Thread Andrea Corallo
Hi, second version of the patch here cleaning up an unnecessary change. Does not introduce regressions with make check-jit. Andrea gcc/jit/ChangeLog 2020-??-?? Andrea Corallo * docs/topics/compatibility.rst (LIBGCCJIT_ABI_13): New ABI tag plus add version paragraph

Re: [PATCH][gcc] libgccjit: handle long literals in playback::context::new_string_literal

2020-01-23 Thread Andrea Corallo
> Andrea Corallo writes: > >> Andrea Corallo writes: >> >>> Andrea Corallo writes: >>> >>>> Hi all, >>>> yesterday I've found an interesting bug in libgccjit. >>>> Seems we have an hard limitation of 200 characters for

Re: [PATCH v4] arm: Implement Armv8.1-M low overhead loops

2020-07-10 Thread Andrea Corallo
Andrea Corallo writes: > Andrea Corallo writes: > >> Hi all, >> >> here the latest version of the patch to enable Armv8.1-M Mainline >> LOB (low overhead branch) extension low overhead loops (LOL) feature >> using the 'loop-doloop' pass. >>

Re: [PATCH v4] arm: Implement Armv8.1-M low overhead loops

2020-07-10 Thread Andrea Corallo
Kyrylo Tkachov writes: [...] > > Ok. > Thanks for doing this. > Kyrill Hi Kyrill, installed into trunk as d2ed233cb940. Thanks Andrea

Re: [PATCH] libgccjit: Add new gcc_jit_context_new_blob entry point

2020-07-14 Thread Andrea Corallo
Andrea Corallo writes: > Andrea Corallo writes: > >>> It occurred to me that the entrypoint is combining two things: >>> - creating a global char[] >>> - creating an initializer for that global >>> >>> which got me wondering if we should ins

[committed] build: Fix 'make TAGS' in gcc/

2020-07-16 Thread Andrea Corallo
Hi all, the following simple patch fixes 'make TAGS' for gcc/ Wasn't working because still searching for params.def. Committed as obvious fix. Regards Andrea gcc/ChangeLog: 2020-07-16 Andrea Corallo * Makefile.in (TAGS): Remove 

Re: [PATCH][GCC][aarch64] Generation of adjusted ldp/stp for vector types

2020-07-21 Thread Andrea Corallo
Przemyslaw Wirkus writes: > diff --git a/gcc/testsuite/gcc.target/aarch64/ldp_vec_v2sf.c > b/gcc/testsuite/gcc.target/aarch64/ldp_vec_v2sf.c > new file mode 100644 > index > ..fbdae1c6cff1aef40db644361381ce511f0be64a > --- /dev/null > +++ b/gcc/testsuite/

Re: [PATCH][GCC][aarch64] Generation of adjusted ldp/stp for vector types

2020-07-21 Thread Andrea Corallo
Richard Sandiford writes: > Yeah, that's certainly true for code in the compiler itself. Tests > kind-of get a pass stylewise though. It would be bad if everything in > the testsuite used GNU style, since then we'd never test anything else. ;-) LOL, good to know thanks Andrea

Re: [PATCH] libgccjit: Handle truncation and extension for casts [PR 95498]

2020-07-21 Thread Andrea Corallo
Hi Antoni, a couple of nits and some thoughts. Antoni Boucher via Gcc-patches writes: > 2020-07-12 Antoni Boucher > > gcc/jit/ > PR target/95498 > * jit-playback.c: Add support to handle truncation and extension ^^^ here we usually a

[PATCH] libgccjit: Improve doc and comments regarding type casts (Was: Clarifying the permitted type conversions)

2020-07-22 Thread Andrea Corallo
documenting what do we accept, and I guess we should just consider bugs if some of these conversions is not handled correctly or leads to ICE. Bests Andrea gcc/jit/ChangeLog 2020-07-21 Andrea Corallo * docs/_build/texinfo/libgccjit.texi (Type-coercion): Improve doc on allowed

[PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-07-22 Thread Andrea Corallo
ssive eating of nops. It was deemed that a new RTX class was less invasive than modifying behavior in regards to standard UNSPEC nops. 1/2 is requirement for 2/2. Please see this the cover letter of this last for more details on the pass itself. Regards Andrea gcc/ChangeLog 2020-07-17 Andrea Co

[PATCH 2/2] Aarch64: Add branch diluter pass

2020-07-22 Thread Andrea Corallo
cessful compilation of 3 stage bootstrap with the pass forced on (for stage 2, 3) - No additional compilation failures (SPEC CPU 2006 and SPEC CPU 2017) - No 'make check' regressions Regards Andrea gcc/ChangeLog 2020-07-17 Andrea Corallo Carey Williams *

Re: [PATCH 2/2] Aarch64: Add branch diluter pass

2020-07-22 Thread Andrea Corallo
Hi Andrew, thanks for reviewing I'll work on your comments. Just replying to the high level questions. Andrew Pinski writes: > On Wed, Jul 22, 2020 at 3:10 AM Andrea Corallo wrote: >> >> Hi all, >> >> this second patch implements the AArch64 specific b

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-07-22 Thread Andrea Corallo
Richard Biener writes: > I wonder if such effect of instructions on the pipeline can be modeled > in the DFA and thus whether the scheduler could issue (always ready) > NOPs? I might be wrong but the DFA model should be reasoning in terms of executed instructions given an execution path, on the

Re: [PATCH 2/2] Aarch64: Add branch diluter pass

2020-07-22 Thread Andrea Corallo
Segher Boessenkool writes: > Hi! > > On Wed, Jul 22, 2020 at 03:53:34PM +0200, Andrea Corallo wrote: >> Andrew Pinski writes: >> > Can you give a simple example of what this patch does? >> >> Sure, this pass simply moves a sliding window over the insns tryin

Re: [PATCH 2/2] Aarch64: Add branch diluter pass

2020-07-24 Thread Andrea Corallo
Segher Boessenkool writes: > On Wed, Jul 22, 2020 at 09:45:08PM +0200, Andrea Corallo wrote: >> > Should that actually be a sliding window, or should there actually just >> > not be more than N branches per aligned block of machine code? Like, >> > per fetch gr

Re: [PATCH 2/2] Aarch64: Add branch diluter pass

2020-07-24 Thread Andrea Corallo
Segher Boessenkool writes: > Hi! > > On Fri, Jul 24, 2020 at 09:01:33AM +0200, Andrea Corallo wrote: >> Segher Boessenkool writes: >> >> Correct, it's a sliding window only because the real load address is not >> >> known to the compiler and

Re: [PATCH 2/2] Aarch64: Add branch diluter pass

2020-07-28 Thread Andrea Corallo
ss sure if text/x-diff is such and insane mime type for a mailing list software :) ] > On Wed, Jul 22, 2020 at 12:09:08PM +0200, Andrea Corallo wrote: >> this second patch implements the AArch64 specific back-end pass >> 'branch-dilution' controllable by the followings comm

Re: [PATCH 1/2] Add new RTX instruction class FILLER_INSN

2020-07-28 Thread Andrea Corallo
Segher Boessenkool writes: > Hi Andrea, > > On Wed, Jul 22, 2020 at 12:02:33PM +0200, Andrea Corallo wrote: >> This first patch implements the addition of a new RTX instruction class >> FILLER_INSN, which has been white listed to allow placement of NOPs >> outside of

[PATCH] Aarch64: Add missing clobber for fjcvtzs

2020-07-31 Thread Andrea Corallo
a [1] https://developer.arm.com/docs/ddi0596/latest/simd-and-floating-point-instructions-alphabetic-order/fjcvtzs-floating-point-javascript-convert-to-signed-fixed-point-rounding-toward-zero gcc/ChangeLog 2020-07-30 Andrea Corallo * config/aarch64/aarch64.md (aarch64_fjcvtzs): Add mi

Re: [PATCH] libgccjit: Add new gcc_jit_context_new_blob entry point

2020-08-03 Thread Andrea Corallo
t num_bytes); 'global' must be an array but in the seek of generality it now supports all the various integral types and is not limited to char[]. As you anticipated the implementation I came up is currently not safe for cross-compilation, not sure is requirement tho. make check-jit is cle

Re: [PATCH] Aarch64: Add missing clobber for fjcvtzs

2020-08-04 Thread Andrea Corallo
gcc/ChangeLog 2020-07-30 Andrea Corallo * config/aarch64/aarch64.md (aarch64_fjcvtzs): Add missing clobber. gcc/testsuite/ChangeLog 2020-07-30 Andrea Corallo * gcc.target/aarch64/acle/jcvt_2.c: New testcase. * lib/target-support

Re: [PATCH] Aarch64: Add missing clobber for fjcvtzs

2020-08-04 Thread Andrea Corallo
hat. The attached is committed into master as d2b86e14c14. Andrea >From d2b86e14c14020f3e119ab8f462e2a91bd7d46e5 Mon Sep 17 00:00:00 2001 From: Andrea Corallo Date: Wed, 29 Jul 2020 19:04:40 +0200 Subject: [PATCH] aarch64: Add missing clobber for fjcvtzs gcc/ChangeLog 2020-07-30 Andrea Cor

Re: [PATCH] Aarch64: Add missing clobber for fjcvtzs

2020-08-04 Thread Andrea Corallo
Andrea Corallo writes: > Hi Kyrill, > > thanks for catching that. > > The attached is committed into master as d2b86e14c14. > > Andrea And backported in releases/gcc-10 as e5907f3b631. Andrea

[PATCH PR96375] arm: Fix testcase selection for Low Overhead Loop tests

2020-08-04 Thread Andrea Corallo
oduce regressions in my testing and fix the reported one according to Christophe (in Cc). Okay for trunk? Thanks Andrea 2020-07-31 Andrea Corallo * gcc.target/arm/lob1.c: Fix missing flag. * gcc.target/arm/lob2.c: Likewise. * gcc.target/arm/lob3.c: Lik

Re: [PATCH] libgccjit: Improve doc and comments regarding type casts

2020-08-06 Thread Andrea Corallo
Andrea Corallo writes: > Hi Alex, > > Looking at the code I believe all these casts are meant to be supported > (read your intuition was correct). > > Also IMO source of confusion is that the doc is mentioning 'int' and > 'float' but I believe wo

Re: [PATCH V3][gcc] libgccjit: introduce version entry points

2020-03-18 Thread Andrea Corallo
ll in stage4. As result I've mostly applied the mutex solution. 'make check-jit' runs clean Bests Andrea gcc/jit/ChangeLog 2020-??-?? Andrea Corallo David Malcolm * docs/topics/compatibility.rst (LIBGCCJIT_ABI_13): New ABI tag plus a

Re: [PATCH v2][gcc] libgccjit: handle long literals in playback::context::new_string_literal

2020-03-18 Thread Andrea Corallo
Andrea Corallo writes: > Hi all, > > second version of the patch for the 200 characters limit for literal > strings addressing comments. > > make check-jit is passing clean. > > Best Regards > Andrea > > gcc/jit/ChangeLog > 2020-??-?? Andrea Corallo >

[PATCH] Fix ICE PR94144

2020-03-23 Thread Andrea Corallo
I (reg:CC 66 cc) (const_int 0 [0]))) was simplified into (ordered:SI (reg:CC 66 cc) (const_int 0 [0])) causing ICE. Bootstrapped on x86_64-linux-gnu and aarch64-unknown-linux-gnu does not introduce testsuite regressions. Andrea gcc/ChangeLog 2020-??-?? Andrea Corall

Re: [committed][gcc] libgccjit: handle long literals in playback::context::new_string_literal

2020-03-23 Thread Andrea Corallo
2020-03-23 Andrea Corallo * jit-playback.h (gcc::jit::playback::context m_recording_ctxt): Remove m_char_array_type_node field. * jit-playback.c (playback::context::context) Remove m_char_array_type_node from member initializer list.

Re: [PATCH V3][gcc] libgccjit: introduce version entry points

2020-03-29 Thread Andrea Corallo
David Malcolm writes: > On Wed, 2020-03-18 at 23:51 +0100, Andrea Corallo wrote: > Please add the new test to the header in its alphabetical location, > i.e. between: > > /* test-vector-types.cc: We don't use this, since it's C++. */ > > and > > /* test-

Re: [PATCH V3][gcc] libgccjit: introduce version entry points

2020-03-31 Thread Andrea Corallo
David Malcolm writes: > Andrea: I've pushed my proposed fix for the above to master as > 3809bcd6c0ee324cbd855c68cee104c8bf134dbe. Does this fix the issue you > were seeing? > > Thanks > Dave Hi, yes super! I'll update the patch thanks. Andrea

Re: [PATCH 2/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-31 Thread Andrea Corallo
Richard Earnshaw writes: > On 17/03/2020 12:34, Wilco Dijkstra wrote: >> Hi Andrea, >> I think the first part is fine when approved, but the 2nd part is >> problematic like Szabolcs >> already pointed out. We can't just change the ABI or semantics, and these >> builtins are critical >> for GLIBC

[PATCH V4][gcc] libgccjit: introduce version entry points

2020-03-31 Thread Andrea Corallo
Hi all, Updated version of the patch addressing last comments. Regression clean, okay to apply? Bests Andrea gcc/jit/ChangeLog 2020-??-?? Andrea Corallo David Malcolm * docs/topics/compatibility.rst (LIBGCCJIT_ABI_13): New ABI tag plus add version paragraph

Re: [PATCH V4][gcc] libgccjit: introduce version entry points

2020-03-31 Thread Andrea Corallo
David Malcolm writes: > On Tue, 2020-03-31 at 14:05 +0200, Andrea Corallo wrote: >> Hi all, >> >> Updated version of the patch addressing last comments. > > Thanks. > >> Regression clean, okay to apply? > > OK Committed as 63b2923dc6f5. Thanks Andrea

[PATCH]libstdc++-v3/test: Skip "use_service.cc" for aarch64 baremetal

2020-04-01 Thread Andrea Corallo
ssue is tackled would be possible to install this patch to have it disabled on aarch64 baremetal where it is known to be failing? Thanks Andrea libstdc++-v3/ChangeLog 2020-??-?? Andrea Corallo * testsuite/experimental/net/execution_context/use_service.cc: Skip on aarch64-

Re: [PATCH]libstdc++-v3/test: Skip "use_service.cc" for aarch64 baremetal

2020-04-02 Thread Andrea Corallo
Jonathan Wakely writes: > On 01/04/20 16:56 +0100, Jonathan Wakely wrote: > Does that help, or does it still fail for other reasons? Yes it does thanks! Updated patch follows. Okay for trunk? Thanks Andrea libstdc++-v3/ChangeLog 2020-??-?? Andrea Corallo * tes

Re: [PATCH]libstdc++-v3/test: Skip "use_service.cc" for aarch64 baremetal

2020-04-02 Thread Andrea Corallo
Jonathan Wakely writes: > On 02/04/20 10:44 +0200, Andrea Corallo wrote: >>Jonathan Wakely writes: >> >>> On 01/04/20 16:56 +0100, Jonathan Wakely wrote: >> >>> Does that help, or does it still fail for other reasons? >> >>Yes it does thanks!

[PATCH] PR target/48240

2020-04-08 Thread Andrea Corallo
Hi all, I'd like to submit this for PR48240. Bootstrapped on aarch64-unknown-linux-gnu. Okay for trunk when finished with regression? Andrea gcc/ChangeLog 2020-??-?? Andrea Corallo PR target/48240 * gcc/config/aarch64/falkor-tag-collision-avoidance.c (valid_

Re: [PATCH] PR target/48240

2020-04-09 Thread Andrea Corallo
Richard Sandiford writes: > Andrea Corallo writes: >> Hi all, >> >> I'd like to submit this for PR48240. >> >> Bootstrapped on aarch64-unknown-linux-gnu. >> Okay for trunk when finished with regression? > > OK, but the PR number looks like a

Re: [PATCH] PR target/48240

2020-04-09 Thread Andrea Corallo
Kyrylo Tkachov writes: > diff --git a/gcc/config/aarch64/falkor-tag-collision-avoidance.c > b/gcc/config/aarch64/falkor-tag-collision-avoidance.c > index 719df484ee61..4e07a43282f7 100644 > --- a/gcc/config/aarch64/falkor-tag-collision-avoidance.c > +++ b/gcc/config/aarch64/falkor-tag-collision-

[committed] PR target/94530 (was [PATCH] PR target/48240)

2020-04-09 Thread Andrea Corallo
Hi all, Second version of the patch for PR94530 (pr num fixed) addressing comments. Bootstrapped on aarch64-unknown-linux-gnu. Committed. Andrea gcc/ChangeLog 2020-04-09 Andrea Corallo PR target/pr94530 * config/aarch64/falkor-tag-collision-avoidance.c

[PATCH]aarch64: falkor-tag-collision-avoidance.c fix valid_src_p for use of uninitialized value

2020-04-14 Thread Andrea Corallo
r field in aarch64_classify_address for safeness. gcc/ChangeLog 2020-??-?? Andrea Corallo * config/aarch64/falkor-tag-collision-avoidance.c (valid_src_p): Check for aarch64_address_info type before accessing base field. >From 4af5bb32cd88bb4e65591207839fb0e276b2eb23 Mon

Re: [PATCH]aarch64: falkor-tag-collision-avoidance.c fix valid_src_p for use of uninitialized value

2020-04-14 Thread Andrea Corallo
Kyrylo Tkachov writes: > - if (!REG_P (addr.base)) > + if (addr.type == ADDRESS_SYMBOLIC || !REG_P (addr.base)) > return false; > > Hmm, given that the code below only handles the ADDRESS_REG_* forms, how > about we get defensive here and check that addr.type is not one of > ADDRESS_REG

Re: [PATCH V2]aarch64: falkor-tag-collision-avoidance.c fix valid_src_p for use of uninitialized value

2020-04-15 Thread Andrea Corallo
Hi all, Second version of this addressing comments. Bootstraped on aarch64 and regressioned. Okay for trunk? Andrea gcc/ChangeLog 2020-??-?? Andrea Corallo * config/aarch64/falkor-tag-collision-avoidance.c (valid_src_p): Check for aarch64_address_info type before

Re: [PATCH V2]aarch64: falkor-tag-collision-avoidance.c fix valid_src_p for use of uninitialized value

2020-04-15 Thread Andrea Corallo
Kyrylo Tkachov writes: > Hi Andrea, > >> -Original Message----- >> From: Andrea Corallo >> Sent: 15 April 2020 09:47 >> To: Kyrylo Tkachov >> Cc: nd ; gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH V2]aarch64: falkor-tag-collision-avoidance.c f

Re: [PATCH V2]aarch64: falkor-tag-collision-avoidance.c fix valid_src_p for use of uninitialized value

2020-04-16 Thread Andrea Corallo
gcc/ChangeLog 2020-??-?? Andrea Corallo * config/aarch64/falkor-tag-collision-avoidance.c (valid_src_p): Check for aarch64_address_info type before accessing base field. gcc/testsuite/ChangeLog 2020-??-?? Andrea Corallo * gcc.target/aarch64/pr94530.c: New

Re: [PATCH V2]aarch64: falkor-tag-collision-avoidance.c fix valid_src_p for use of uninitialized value

2020-04-20 Thread Andrea Corallo
Kyrylo Tkachov writes: >> Bootstrapped and reg tested. Ok for release/gcc-9? > > Ok. > Thanks, > Kyrill Pushed as 5e022e3b3f7b. Thanks Andrea

  1   2   3   4   5   >