Re: [PATCH] rs6000: Add xxeval and vec_ternarylogic

2020-05-09 Thread David Edelsohn via Gcc-patches
On Fri, May 8, 2020 at 9:13 PM Bill Schmidt wrote: > > From: Kelvin Nilsen > > Add the xxeval insn and access it via the vec_ternarylogic built-in > function. As part of this, add support to the built-in function > infrastructure for functions that take four arguments. > > Bootstrapped and

Re: [PATCH] rs6000: Fix rs6000_atomic_assign_expand_fenv [PR94826]

2020-04-29 Thread David Edelsohn via Gcc-patches
On Wed, Apr 29, 2020 at 7:48 AM Jakub Jelinek wrote: > > Hi! > > This is the rs6000 version of the earlier committed x86, aarch64 and arm > fixes, as create_tmp_var_raw is used because the C FE can call this outside > of function context, we need to make sure the first references to those >

Re: [PATCH v3] c++, middle-end, rs6000: Fix C++17 ABI incompatibilities during class layout and [[no_unique_address]] handling [PR94707]

2020-04-28 Thread David Edelsohn via Gcc-patches
On Tue, Apr 28, 2020 at 4:02 PM Jakub Jelinek wrote: > > On Tue, Apr 28, 2020 at 05:42:00PM +0200, Jakub Jelinek wrote: > > Ok, below in the updated patch: > > This is what I've successfully bootstrapped/regtested on powerpc64le-linux > (last posted patch with the lto-common.c addition included).

[wwwdocs] Update cxx1y links to cxx-status

2020-04-28 Thread David Edelsohn via Gcc-patches
While looking up C++14 information, I noticed that some links in current navigation pages refer to cxx1y.html instead of cxx-status.html. This patch changes the NEWS item to refer to cxx-status.html#cxx14 and the Projects index to refer to C++ language features instead of C++14 language features.

Re: [PATCH] c++, middle-end, rs6000: Fix C++17 ABI incompatibilities during class layout [PR94707]

2020-04-25 Thread David Edelsohn via Gcc-patches
On Sat, Apr 25, 2020 at 6:03 AM Jakub Jelinek wrote: > > Hi! > > As reported by Iain and David, powerpc-darwin and powerpc-aix* have C++14 > vs. C++17 ABI incompatibilities which are not fixed by mere adding of > cxx17_empty_base_field_p calls. Unlike the issues that were seen on other > targets

Re: [PATCH] rs6000: Replace outdated link to ELFv2 ABI

2020-04-23 Thread David Edelsohn via Gcc-patches
On Thu, Apr 23, 2020 at 12:13 PM Bill Schmidt wrote: > > A user reported that we are still referring to a public review > draft of the ELFv2 ABI specification. Replace that by a permalink. > > Tested with "make pdf" and verified the link is hot. Is this okay > for master? > > Thanks, > Bill > >

Re: [PATCH] gcc/config/rs6000: Add link with libc128 with -mlong-double-128 for AIX

2020-04-02 Thread David Edelsohn via Gcc-patches
On Thu, Apr 2, 2020 at 5:30 AM CHIGOT, CLEMENT wrote: > > Description: > * AIX applications using 128-bit long double must be linked with >libc128.a, in order to have 128-bit compatible routines. > > Tests: > * AIX 7.2, 7.1: Build/Tests: OK > > Changelog: > * config/rs6000/aix61.h

Re: [PATCH] calls.c precompute_register_parameters for TLS

2020-03-28 Thread David Edelsohn via Gcc-patches
On Sat, Mar 28, 2020 at 6:42 AM Richard Sandiford wrote: > > David Edelsohn via Gcc-patches writes: > > This patch is for an AIX problem, but the only robust solution is in > > common code: calls.c:precompute_register_parameters(). > > > > AIX, like other platf

[PATCH] calls.c precompute_register_parameters for TLS

2020-03-27 Thread David Edelsohn via Gcc-patches
This patch is for an AIX problem, but the only robust solution is in common code: calls.c:precompute_register_parameters(). AIX, like other platforms, needs to call a function to obtain the pointer to thread-local storage. If the thread local variable is referenced as a parameter to a function

[COMMITTED] rs6000: Correct logic to disable NO_SUM_IN_TOC and NO_FP_IN_TOC [PR94065]

2020-03-06 Thread David Edelsohn
aix61.h, aix71.h and aix72.h intends to prevent SUM_IN_TOC and FP_IN_TOC when cmodel=large. This patch defines the variables associated with the target options to 1 to _enable_ NO_SUM_IN_TOC and enable NO_FP_IN_TOC. Bootstrapped on powerpc-ibm-aix7.2.0.0 PR target/94065 *

Re: [RFC c-common PATCH] PR c++/40752 - useless -Wconversion with short +=.

2020-01-24 Thread David Edelsohn
On Fri, Jan 24, 2020 at 12:00 PM Jason Merrill wrote: > > On 1/24/20 8:45 AM, David Edelsohn wrote: > > There is no ChangeLog entry for the testsuite changes. > > I don't believe in ChangeLog entries for testcases, but I'll add one for > the target-supports.exp change, thank

Re: [RFC c-common PATCH] PR c++/40752 - useless -Wconversion with short +=.

2020-01-24 Thread David Edelsohn
Jason, There is no ChangeLog entry for the testsuite changes. I'm also still trying to determine if Wconversion-pr40752.c requires -fsigned-char option. Thanks, David

Re: Bountysource campaign for gcc-rust?

2019-12-27 Thread David Edelsohn
> John Paul Adrian Glaubitz wrote: > The programming language Rust has become very popular over the past few years > with many projects rewriting parts of their codebase in that language. While > these rewrites often make the code perform faster and potentially safer, using > Rust makes these

Re: SPARC build broken

2019-12-05 Thread David Edelsohn
Done. r279003. - David On Thu, Dec 5, 2019 at 9:33 AM Jakub Jelinek wrote: > > On Thu, Dec 05, 2019 at 09:25:40AM -0500, David Edelsohn wrote: > > Sorry. I had to add tm_p.h because Jakub's earlier patch to add > > output.h to cp-gimplify.c broke AIX. > > > > W

Re: SPARC build broken

2019-12-05 Thread David Edelsohn
Sorry. I had to add tm_p.h because Jakub's earlier patch to add output.h to cp-gimplify.c broke AIX. We certainly can add memmodel.h to cp-gimplify.c. Thanks, David On Thu, Dec 5, 2019 at 8:32 AM Joseph Myers wrote: > > The change > > 2019-12-04 David Edelsohn > >

[PATCH] ggc-common.c bootstrap breakage

2019-11-04 Thread David Edelsohn
The change to add malloc.h to ggc-common.c broke bootstrap. system.h must be included before system header files. The following patch fixes this, committed as obvious with concurrence by Richi. Thanks, David * ggc-common.c: Include system.h before malloc.h. Index: ggc-common.c

Re: [PATCH] PR85678: Change default to -fno-common

2019-10-28 Thread David Edelsohn
>> Has this been bootstrapped and regression tested? > > Yes, it bootstraps OK of course. I ran regression over the weekend, there > are a few minor regressions in lto due to relying on tentative definitions > and a few latent bugs. I'd expect there will be a few similar failures on > other

Re: [PATCH], Patch #10, move PowerPC data structures & helper functions from rs6000.c to rs6000-internal.h

2019-07-20 Thread David Edelsohn
On Sat, Jul 20, 2019 at 12:13 PM Michael Meissner wrote: > > I will be iterating on patch #9 and sending out a replacement shortly. > > This is patch #10. It moves the various data structures from rs6000.c to > rs6000-internal.h. In the future, it will allow us to move more things from >

Re: [PATCH] rs6000: Handle Modula-2 in the traceback table

2019-07-11 Thread David Edelsohn
On Thu, Jul 11, 2019 at 2:34 PM Segher Boessenkool wrote: > > This patch recognises Modula-2 as language for the traceback table, > fixing the problem shown in > https://gcc.gnu.org/ml/gcc-patches/2019-07/msg00848.html . The value "8" is predefined in the ABI and AIX headers as the "language

Re: [PATCH,RFC] collect2 LTO for AIX

2019-07-05 Thread David Edelsohn
On Thu, Jul 4, 2019 at 11:43 AM Martin Liška wrote: > > On 7/4/19 5:03 PM, David Edelsohn wrote: > > On Thu, Jul 4, 2019 at 10:38 AM Martin Liška wrote: > >> > >> Hi. > >> > >> Recently I've introduced a new .gnu.lto_.lto section that > >

Re: [PATCH,RFC] collect2 LTO for AIX

2019-07-04 Thread David Edelsohn
On Thu, Jul 4, 2019 at 10:38 AM Martin Liška wrote: > > Hi. > > Recently I've introduced a new .gnu.lto_.lto section that > is supposed to provide meta information about a LTO bytecode. > > As a further step, I'm planning to teach binutils about > existence of the section and I'll remove in the

[PATCH] AIX unwind register number fixes

2019-06-05 Thread David Edelsohn
The recent changes to rs6000 "debug" register numbers created a conflict in libgcc aix unwind support. aix-unwind.h provided definitions of the DWARF register numbers for its own reference. After the internal register number changes and the definition of those register names in rs6000.md, the

[PATCH] GCC 8 Backports for AIX

2019-05-14 Thread David Edelsohn
I would like to backport two AIX-specific patches to GCC 8. These both fix bugs that generate wrong code on AIX. 1) XCOFF private read only data section 2) Follow AIX ABI to not pass FP structures in FPRs. These patches have been on trunk / GCC 9 for months. Bootstrapped gcc-8-branch on

[PATCH] Fix rs6000 exception handling (PR target/90418)

2019-05-13 Thread David Edelsohn
Following the same pattern as the AArch64 patch, this patch fixes the PPC32 BE and AIX EH failures after the sibcall changes. This does not address the Darwin failures because of SAVE_WORLD. Bootstrapped on powerpc-ibm-aix7.2.0.0, powerpc64le-unknown-linux-gnu, powerpc64-unknown-linux-gnu,

Re: [PATCH v2] go: disable mvsx and maltivec for aix/ppc

2019-04-24 Thread David Edelsohn
On Tue, Apr 23, 2019 at 4:27 AM CHIGOT, CLEMENT wrote: > > Description: > * This patch removes -mvsx and -maltivec for go aix/ppc. > These options don't seem compatible with Go stack layout. > > Tests: > * AIX 7.2: Configure/Build: SUCCESS > > Changelog: > * config/rs6000/aix71.h

Re: [PATCH v2] go: disable mvsx and maltivec for aix/ppc

2019-04-24 Thread David Edelsohn
On Wed, Apr 24, 2019 at 9:31 AM Ian Lance Taylor wrote: > > On Tue, Apr 23, 2019 at 1:27 AM CHIGOT, CLEMENT > wrote: > > > > Description: > > * This patch removes -mvsx and -maltivec for go aix/ppc. > > These options don't seem compatible with Go stack layout. > > > > Tests: > > * AIX

[PATCH, AIX] Fix private_read_only_data_section definition

2019-04-05 Thread David Edelsohn
When not using -fdata-sections or when there is no containing name, GCC falls back to a default section name. Because AIX uses XCOFF, it always has generated it's own section (CSECT) names (based on the filename) and not using the GCC defaults. unicode.org icu code has elicited behavior from the

Re: [PATCH,AIX] go: disable mvsx and maltivec for aix/ppc

2019-04-02 Thread David Edelsohn
On Tue, Apr 2, 2019 at 10:24 AM CHIGOT, CLEMENT wrote: > > > On Tue, Apr 2, 2019 at 4:05 PM David Edelsohn wrote: > > On Tue, Apr 2, 2019 at 10:01 AM CHIGOT, CLEMENT > > wrote: > > > On Tue, Apr 2, 2019 at 8:01 PM Ian Lance Taylor wrote: > > > > On

Re: [PATCH,AIX] go: disable mvsx and maltivec for aix/ppc

2019-04-02 Thread David Edelsohn
On Tue, Apr 2, 2019 at 10:01 AM CHIGOT, CLEMENT wrote: > > On Tue, Apr 2, 2019 at 8:01 PM Ian Lance Taylor wrote: > > > > On Mon, Apr 1, 2019 at 7:28 PM David Edelsohn wrote: > > > > > > On Mon, Apr 1, 2019 at 10:12 PM Ian Lance Taylor wrote: > >

Re: [PATCH,AIX] go: disable mvsx and maltivec for aix/ppc

2019-04-01 Thread David Edelsohn
On Mon, Apr 1, 2019 at 10:12 PM Ian Lance Taylor wrote: > > On Mon, Apr 1, 2019 at 7:06 PM David Edelsohn wrote: > > > > On Mon, Apr 1, 2019 at 9:50 PM Ian Lance Taylor wrote: > > > > > > On Mon, Apr 1, 2019 at 12:43 AM CHIGOT, CLEMENT >

Re: [PATCH,AIX] go: disable mvsx and maltivec for aix/ppc

2019-04-01 Thread David Edelsohn
On Mon, Apr 1, 2019 at 9:50 PM Ian Lance Taylor wrote: > > On Mon, Apr 1, 2019 at 12:43 AM CHIGOT, CLEMENT > wrote: > > > > Description: > > * This patch removes -mvsx and -maltivec for go aix/ppc. > > These options don't seem compatible with Go stack layout. > > Can you give some more

Re: [PATCH,AIX] go: disable mvsx and maltivec for aix/ppc

2019-04-01 Thread David Edelsohn
On Mon, Apr 1, 2019 at 3:43 AM CHIGOT, CLEMENT wrote: > > Description: > * This patch removes -mvsx and -maltivec for go aix/ppc. > These options don't seem compatible with Go stack layout. > > Tests: > * AIX 7.2: Configure/Build: SUCCESS > > Changelog: > * go/gospec.c

Re: [PATCH] Don't run ident tests on powerpc-darwin

2018-12-26 Thread David Edelsohn
On Sun, Dec 23, 2018 at 6:16 AM Iain Sandoe wrote: > > Hi > > The c-c++-common tests fail (or XPASS depending on which) on Darwin > because it doesn't currently emit .ident marker. > > For powerpc darwin (and, I think, AIX - hence copying David), there’s no > .ident support in the assembler, and

[PATCH] AIX extra_headers

2018-12-17 Thread David Edelsohn
Currently the AIX configuration defines extra_headers to install some PowerPC-specific headers, such as altivec.h. The GCC configuration for Power was changed to define this centrally and the individual definitions for Linux were removed, but remained for AIX. This means that AIX overrides the

Re: [PATCH] rs6000: Fix AIX aggregate passing fix

2018-12-13 Thread David Edelsohn
On Tue, Dec 4, 2018 at 7:26 PM Segher Boessenkool wrote: > > David's fix for the AIX aggregate passing from yesterday unfortunately > also triggers on powerpc64-linux. This fixes it. > > David, looking at this once more, does this not need a "&& type" test > on AIX? Before the AGGREGATE_TYPE_P

Re: [RS6000] Don't pass -many to the assembler

2018-12-13 Thread David Edelsohn
On Thu, Dec 13, 2018 at 5:26 AM Alan Modra wrote: > > On Wed, Nov 14, 2018 at 01:43:57PM +1030, Alan Modra wrote: > > On Tue, Nov 13, 2018 at 05:17:41AM -0600, Segher Boessenkool wrote: > > > On Tue, Nov 13, 2018 at 12:02:55PM +1030, Alan Modra wrote: > > > > OK, fair enough. Another option is

Re: PR88346, Inconsistent list of CPUs supported by the rs6000 backend after r266502

2018-12-11 Thread David Edelsohn
On Mon, Dec 10, 2018 at 6:17 PM Segher Boessenkool wrote: > > Hi Alan, > > Let's ask David? (Cc:ed). Strange that no one noticed powerpc64 before; > titan and rs64 aren't so strange though ;-) The patch is okay with me. Thanks for catching the renaming and the processor missing from the list.

Re: [committed] Handle targets with 2 byte wchar_t better in strlenopt-58.c

2018-12-05 Thread David Edelsohn
Jeff, Thanks for the patch. I continue to see a failure on AIX 32 bit mode (2 byte wchar). FAIL: gcc.dg/strlenopt-58.c scan-tree-dump-times optimized "call_in_true_branch_not_eliminated" 0 I'm not certain if this is AIX-specific or more fallout from wchar size. I could ignore with target

[PATCH,RFC] PR target/61976 PowerPC & AIX parameter passing

2018-11-30 Thread David Edelsohn
This patch corrects the manner in which single element structures are passed. The implementation always has been wrong and did not match the AIX ABI. The AIX ABI specifies that aggregates are passed by values in GPRs, but GCC passes small floating point aggregates in FPRs. The PPC64 BE ELFv1

Re: [committed 0/4] (Partial) OpenMP 5.0 support for GCC 9

2018-11-09 Thread David Edelsohn
> 2018-11-08 Rainer Orth > > * affinity.c: Include , . > (gomp_display_affinity_place): Remove cpusetp. > * teams.c: Include . This fixed AIX bootstrap failure also. Thanks, David

Re: [Patch, Fortran] PR fortran/83522 – reject array-valued substrings

2018-10-11 Thread David Edelsohn
is not pedantically conformant with the standard. Thanks, David On Wed, Oct 10, 2018 at 7:12 PM Paul Richard Thomas wrote: > > This seems to have caused errors in the testsuite. I guess that the > problem is that the testcases are invalid :-( > > From David Edelsohn: > Error: S

Re: [Patch, Fortran] PR fortran/83522 – reject array-valued substrings

2018-10-11 Thread David Edelsohn
, Oct 10, 2018 at 7:12 PM Paul Richard Thomas wrote: > > This seems to have caused errors in the testsuite. I guess that the > problem is that the testcases are invalid :-( > > From David Edelsohn: > Error: Substring reference of nonscalar not permitted at (1) > > arrayio

Re: [PATCH, testsuite] memchr-1.c wide char and AIX

2018-10-06 Thread David Edelsohn
On Fri, Oct 5, 2018 at 5:47 PM Martin Sebor wrote: > > David, > > Attached is a patch to conditionalize the memchr-1.c test > to pass even with 2-byte wchar_t's. It also adds a compile > only test to verify memchr with -fnarrow-wchar. I verified > the changes on LE x86_64-linux and BE

[PATCH, testsuite] memchr-1.c wide char and AIX

2018-10-05 Thread David Edelsohn
memchr-1.c tests for char (test_narrow) and wchar (test_wide). The wide character test assumes 32 bit wide character, while 32 bit AIX uses 16 bit wide character. This assumption causes the wide character part of the test to fail in 32 bit mode on AIX (it succeeds on 64 bit AIX). The testcase

Re: OpenRISC Port Submission

2018-08-23 Thread David Edelsohn
Stafford, Thanks for rewriting and contributing the new OpenRISC port for GCC. I have forwarded your request to the GCC Steering Committee to formally accept the contribution. The port still requires a technical review and approval from a GCC Global Reviewer. You mentioned Richard Henderson as

[PATCH,FORTRAN] Remove OS dependency in definition of ASYNC_IO

2018-08-23 Thread David Edelsohn
The recent fix for Async I/O on systems without Gthread cond support added an explicit test for _AIX. This test is unnecessary because __GTHREAD_HAS_COND is not defined on AIX. Protecting the use of __gthread_cond_t inside in the ASYNC_IO macro for the declaration of struct adv_cond is

Re: Async I/O patch with compilation fix

2018-08-23 Thread David Edelsohn
Thomas, Once the plural.c file has been re-generated incorrectly using the local Yacc, it must be deleted and checked out again. Did you pull it fresh from the repository in your AIX tree after the incorrect checkout? Thanks, David On Wed, Aug 22, 2018 at 5:30 PM Thomas Koenig wrote: > Hi

Re: Async I/O patch with compilation fix

2018-08-23 Thread David Edelsohn
Thomas, After your complaint about bootstrap on gcc119, I tried it again. My bootstrap worked correctly. I used exactly the public instructions. Others have been able to bootstrap on gcc119. The problem is local to you. Does your environment have any special variables? You can see the

Re: Async I/O patch with compilation fix

2018-08-22 Thread David Edelsohn
Thomas, This patch broke bootstrap on AIX again. This is completely unacceptable. In file included from */nasfarm/edelsohn/src/src/libgfortran/runtime/error.c:28*: */nasfarm/edelsohn/src/src/libgfortran/io/async.h:333:3:* *error: *unknown type name '*__gthread_cond_t*' 333 |

Re: [PATCH] assume sprintf formatting of wide characters may fail (PR 86853)

2018-08-20 Thread David Edelsohn
builtin-sprintf-warn-1.c, builtin-sprintf-warn-2.c, and builtin-sprintf-11.c now are failing on AIX. I expect that at least part of the reason is 32 bit AIX uses 16 bit wchar_t #ifdef __64BIT__ typedef unsigned intwchar_t; #else typedef unsigned short wchar_t; #endif /* __64BIT__ */ Are

[PATCH] XFAIL 18_support/new_nothrow.cc on AIX

2018-08-20 Thread David Edelsohn
18_support/new_nothrow.cc relies upon overriding operator new. This is not enabled by default in libstdc++ on AIX. This patch XFAILs the testcase. Bootstrapped on powerpc-ibm-aix7.2.0.0 Okay? Thanks, David * testsuite/18_support/new_nothrow.cc: XFAIL on AIX. Index: 18_support/new_nothrow.cc

[PATCH] Remove AIX 4.x, 5.x configuration

2018-08-13 Thread David Edelsohn
AIX 4.3, 5.1, 5.2, and 5.3 no longer are supported by IBM. This patch removes the GCC config.gcc stanzas and configuration files corresponding to those AIX releases. Thanks, David * config.gcc [rs6000-ibm-aix4.x]: Delete. [rs6000-ibm-aix5.1]: Delete. [rs6000-ibm-aix5.2]: Delete.

Re: [PATCH] adjust sprintf range for AIX QNaN output (PR 86571)

2018-08-04 Thread David Edelsohn
On Sat, Aug 4, 2018, 18:19 Martin Sebor wrote: > On 08/02/2018 01:46 PM, Martin Sebor wrote: > > The recently added test gcc.dg/torture/builtin-sprintf.c > > to verify that the sprintf result computed by GCC matches > > libc's for Infinity and NaN has been failing on AIX which > > formats NaN as

Re: [PATCH] PR libstdc++/60555 std::system_category() should recognise POSIX errno values

2018-08-02 Thread David Edelsohn
On Thu, Aug 2, 2018 at 12:12 PM Jonathan Wakely wrote: > > On 02/08/18 11:32 -0400, David Edelsohn wrote: > >Jonathan > > > >This patch broke AIX bootstrap. > > > >/nasfarm/edelsohn/src/src/libstdc++-v3/src/c++11/system_error.cc: In > >member function '

Re: [PATCH] PR libstdc++/60555 std::system_category() should recognise POSIX errno values

2018-08-02 Thread David Edelsohn
Jonathan This patch broke AIX bootstrap. /nasfarm/edelsohn/src/src/libstdc++-v3/src/c++11/system_error.cc: In member function 'virtual std::error_condition {anonymous}::system_error_category::default_error_condition(int) const':

Re: Build fail on gthr-simple.h targets (Re: AsyncI/O patch committed)

2018-07-27 Thread David Edelsohn
Thomas, Correct, the proposed patch does not fix the build failure on AIX. Please see the information on the GCC Compile Farm wiki page for instructions to bootstrap on gcc119. https://gcc.gnu.org/wiki/CompileFarm#Projects_Ideas - at the bottom of Project ideas. Thanks, David On Fri, Jul 27,

Re: Build fail on gthr-simple.h targets (Re: AsyncI/O patch committed)

2018-07-26 Thread David Edelsohn
> Ulrich Weigand wrote: > Nicholas Koenig wrote: > >> Hello everyone, >> >> I have committed the async I/O patch as r262978. >> >> The test cases are in libgomp.fortran for now, maybe that can be changed >> later. > > It looks like this broke building libgfortran on spu, and presumably > any

[PATCH,fixincludes] AIX unistd header

2018-07-23 Thread David Edelsohn
AIX unistd.h defines a static function without a parameter, which justifiably upsets C++ code when the header is included and referenced. This patch to fixincludes adjusts the header to declare the parameter as void. Bootstrapped on powerpc-ibm-aix7.2.0.0 and powerpc64le-linux Thanks, David *

[PATCH, testsuite] PPC testsuite pr85456.c

2018-07-17 Thread David Edelsohn
And another test that needs to be restricted because it assumes 128 bit long double. Thanks, David * gcc.target/powerpc/pr85456.c: Require longdouble128. Index: pr85456.c === --- pr85456.c (revision 262824) +++ pr85456.c

[PATCH, testsuite] Restrict some PPC tests

2018-07-17 Thread David Edelsohn
Two of the powerpc testcases have additional requirements. Fixed thus. Thanks, David * gcc.target/powerpc/pr57150.c: Require longdouble128. * gcc.target/powerpc/pr79916.c: Require dfp. Index: pr79916.c === --- pr79916.c

Re: [PATCH, rs6000] Fix AIX test case failures

2018-07-13 Thread David Edelsohn
On Fri, Jul 13, 2018 at 7:15 PM Carl Love wrote: > > On Fri, 2018-07-13 at 16:00 -0500, Segher Boessenkool wrote: > > On Fri, Jul 13, 2018 at 10:51:24AM -0400, David Edelsohn wrote: > > > On AIX it would be calling divtc3, but AIX defaults to 64 bit long > > > doub

Re: [PATCH, rs6000] Fix AIX test case failures

2018-07-13 Thread David Edelsohn
On Mon, Jun 25, 2018 at 1:04 PM Segher Boessenkool wrote: > > On Mon, Jun 25, 2018 at 09:53:17AM -0700, Carl Love wrote: > > On Mon, 2018-06-25 at 04:44 -0500, Segher Boessenkool wrote: > > > On Fri, Jun 22, 2018 at 02:55:44PM -0700, Carl Love wrote: > > > > ---

[PATCH] libstdc++/testsuite/experimental/algorithm link errors

2018-06-26 Thread David Edelsohn
The recent addition of testsuite/experimental/algorithm/sample-2.cc testsuite/experimental/algorithm/shuffle.cc introduced link errors on AIX. AIX (and Solaris) require additional options for TLS in some situations. This patch adds the dejagnu TLS directives. Was this dependency intended? Is

Re: Invert sense of NO_IMPLICIT_EXTERN_C

2018-06-25 Thread David Edelsohn
On Mon, Jun 25, 2018 at 12:48 PM Nathan Sidwell wrote: > > NO_IMPLICIT_EXTERN_C was introduced to tell the compiler that it didn't > need to fake up 'extern "C" { ... }' around system header files. Over > the years more and more system headers have become C++-aware, leading to > more targets

Re: [PATCH] add support for strnlen (PR 81384)

2018-06-19 Thread David Edelsohn
Martin, Does attr-nonstring-3.c assume a 64 bit environment? I'm seeing new errors on the rs6000 port FAIL: gcc.dg/attr-nonstring-3.c (internal compiler error) /nasfarm/edelsohn/src/src/gcc/testsuite/gcc.dg/attr-nonstring-3.c:73:1: error: could not split insn (insn 3244 3245 3246 (set (reg:SI 5

[PATCH] Protect rs6000_passes_ieee128 declaration

2018-06-08 Thread David Edelsohn
The new variable rs6000_passes_ieee128 is not referenced on non-ELF paths. This patch protects the definition to avoid unused variable warnings. Thanks, David * config/rs6000/rs6000.c (rs6000_passes_ieee128): Protect with #if TARGET_ELF. Index: rs6000.c

Re: [PATCH] PPC: remove usage of cgraph_node::instrumentation_clone and cgraph_node::instrumented_version.

2018-06-08 Thread David Edelsohn
On Fri, Jun 8, 2018 at 9:24 AM Martin Liška wrote: > > Hi. > > This is MPX removal follow-up. The code is dead for PPC and was always false. > > I'll install that after some PPC maintainer will approve that. > Thanks, > Martin > > gcc/ChangeLog: > > 2018-06-08 Martin Liska > > *

Re: libgcov-driver-system bootstrap failure

2018-06-06 Thread David Edelsohn
Hi, Martin Thanks for both patches. GCC bootstrap on AIX is progressing much better with the patches installed. Thanks, David On Wed, Jun 6, 2018 at 5:05 AM Martin Liška wrote: > > On 06/06/2018 03:09 AM, David Edelsohn wrote: > > Also, there seems to be a find-and-replace mistak

Re: libgcov-driver-system bootstrap failure

2018-06-05 Thread David Edelsohn
ot "cs_all" #if !GCOV_LOCKED all = _prg->ctrs[t_ix]; and all_prg no longer has some of the members. Was the !GCOV_LOCKED path not tested for the recent changes? Thanks, David On Tue, Jun 5, 2018 at 8:28 PM David Edelsohn wrote: > > Martin, > > With your recent patch, I rec

libgcov-driver-system bootstrap failure

2018-06-05 Thread David Edelsohn
Martin, With your recent patch, I receive the following failure building libgcov-driver-system.c In file included from /nasfarm/edelsohn/src/src/gcc/../libgcc/libgcov-driver.c:322:0: /nasfarm/edelsohn/src/src/gcc/../libgcc/libgcov-driver-system.c: In function 'char*

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-30 Thread David Edelsohn
On Mon, Apr 30, 2018 at 3:50 AM Richard Biener <rguent...@suse.de> wrote > On Sun, 29 Apr 2018, Richard Biener wrote: > > On April 29, 2018 1:06:47 AM GMT+02:00, David Edelsohn < dje@gmail.com> wrote: > > >Hi, Richi > > > > > >I had be

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-28 Thread David Edelsohn
Richard Biener <rguent...@suse.de> wrote: > On Sat, 28 Apr 2018, Richard Biener wrote: > > On Fri, 27 Apr 2018, Richard Biener wrote: > > > > > On Fri, 27 Apr 2018, David Edelsohn wrote: > > > > > > > Hi, Richi > > > > > > >

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-26 Thread David Edelsohn
Hi, Richi This patches causes a boostrap failure on AIX. Everything miscompares. The code itself is the same, but the DWARF debug information contains many differences. - David

GCC 8.1 RC1 Bootstrap comparison failure on AIX

2018-04-25 Thread David Edelsohn
Jakub and Richi, GCC 8.1 is experiencing the same bootstrap failure with GCC 8.1 RC1 as we saw previously. Bootstrap comparison failure! gcc/function-tests.o differs And the same reason: unique, static symbol that includes a random timestamp. 1949c1949 < [1936]m 0x0060 1

Re: [PATCH] rs6000: Enable -fasynchronous-unwind-tables by default

2018-04-05 Thread David Edelsohn
On Thu, Apr 5, 2018 at 5:50 AM, Jakub Jelinek wrote: > On Thu, Apr 05, 2018 at 09:45:54AM +, Segher Boessenkool wrote: >> To find out where on-entry register values live at any point in a >> program, GDB currently tries to parse to parse the executable code. >> This does not

Re: Deprecate not defining NO_IMPLICIT_EXTERN_C

2018-03-21 Thread David Edelsohn
AIX still requires implicit extern C. I previously have tried to disable the feature on AIX and it failed miserably. Thanks, David On Wed, Mar 21, 2018 at 8:15 AM, Nathan Sidwell wrote: > Port maintainers CC'd, apologies if I've missed you. > > NO_IMPLICIT_EXTERN_C is a target

[PATCH] AIX 7.1 and 7.2 configure support

2018-02-28 Thread David Edelsohn
AIX 7.1 continues to support Power4 as the minimum ISA level, so this reverts the recent patch to aix71.h. AIX 7.2 requires Power7 as the minimum ISA level. The second part of this patch adds a new aix72.h file and updates config.gcc. Thanks, David * config.gcc (powerpc-ibm-aix7.1.*): New

[PATCH] pr84014 testcase fix

2018-02-28 Thread David Edelsohn
The powerpc-specific testcase should test ilp32 and not invoke -m32 explicitly. Thanks, David Index: pr84014.c === --- pr84014.c (revision 258076) +++ pr84014.c (working copy) @@ -1,5 +1,5 @@ -/* { dg-do compile { target

[PATCH] Fix pt.c bootstrap breakage

2018-02-27 Thread David Edelsohn
The recent change to pt.c broke bootstrap by including C++ header file directly and including it first. This patch changes to the necessary method which includes the header file via system.h. Okay? Thanks, David * pt.c: Don't include string. Define INCLUDE_STRING before system.h. Index: pt.c

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-27 Thread David Edelsohn
Martin, This patch broke bootstrap. diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index 42fd872..9c2e5e6 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -24,6 +24,7 @@ along with GCC; see the file COPYING3. If not see all methods must be provided in header files; can't use a source file that

Re: [PATCH,AIX] aix71.h Increase ISA default

2018-02-24 Thread David Edelsohn
On Sat, Feb 24, 2018 at 6:19 PM, Segher Boessenkool <seg...@kernel.crashing.org> wrote: > Hi David, > > On Fri, Feb 23, 2018 at 02:13:52PM -0500, David Edelsohn wrote: >> AIX 7.1 minimum hardware is Power6. This patch changes TARGET_DEFAULT >> to ISA 2.05. > >>

[PATCH,AIX] aix71.h Increase ISA default

2018-02-23 Thread David Edelsohn
AIX 7.1 minimum hardware is Power6. This patch changes TARGET_DEFAULT to ISA 2.05. Thanks, David * config/rs6000/aix71.h (TARGET_DEFAULT): Change to ISA_2_5_MASKS_EMBEDDED. Index: aix71.h === --- aix71.h (revision 257941) +++

[PATCH,AIX] Fixincludes for vec_malloc, vec_calloc

2018-02-22 Thread David Edelsohn
AIX stdlib.h header decides to redefine malloc and calloc when __VEC__ is defined. Hilarity ensues, such as when GCC uses __attribute__(("malloc")). Fixed with the appended fixincludes patch. Thanks, David * inclhack.def (aix_stdlib_vec_malloc): New. (aix_stdlib_vec_calloc): New. * fixincl.x:

Re: [committed] Fix overload15.C testcase (PR c++/79064)

2018-02-19 Thread David Edelsohn
On Mon, Feb 19, 2018 at 3:35 PM, Jakub Jelinek <ja...@redhat.com> wrote: > On Mon, Feb 19, 2018 at 03:31:13PM -0500, David Edelsohn wrote: >> https://gcc.gnu.org/ml/gcc-testresults/2018-02/msg01247.html >> >> === g++ tests === >> >> >> Running tar

Re: [committed] Fix overload15.C testcase (PR c++/79064)

2018-02-19 Thread David Edelsohn
++98 (test for excess errors) - David On Mon, Feb 19, 2018 at 3:28 PM, Jakub Jelinek <ja...@redhat.com> wrote: > On Mon, Feb 19, 2018 at 03:20:25PM -0500, David Edelsohn wrote: >> This testcase continues to fail for -m32 on powerpc64-linux-gnu and on AIX. >> >> Excess e

Re: [committed] Fix overload15.C testcase (PR c++/79064)

2018-02-19 Thread David Edelsohn
This testcase continues to fail for -m32 on powerpc64-linux-gnu and on AIX. Excess errors: /nasfarm/edelsohn/src/src/gcc/testsuite/g++.dg/template/overload15.C:14:10: error: call of overloaded 'f<0>(char (*)[1])' is ambiguous

Re: [PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins

2018-02-06 Thread David Edelsohn
On Tue, Feb 6, 2018 at 10:43 AM, Peter Bergner <berg...@vnet.ibm.com> wrote: > On 2/6/18 6:42 AM, Peter Bergner wrote: >> On 2/5/18 10:48 PM, David Edelsohn wrote: >>> On Mon, Feb 5, 2018 at 9:43 PM, Peter Bergner <berg...@vnet.ibm.com> wrote: >>>> I did a

Re: [PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins

2018-02-05 Thread David Edelsohn
On Mon, Feb 5, 2018 at 9:43 PM, Peter Bergner <berg...@vnet.ibm.com> wrote: > On 2/5/18 7:32 PM, David Edelsohn wrote: >> Peter, >> >> Why can't you place the tests into the final condition of the pattern >> so that the pattern fails and the normal GCC fall

Re: [PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins

2018-02-05 Thread David Edelsohn
Peter, Why can't you place the tests into the final condition of the pattern so that the pattern fails and the normal GCC fallback machinery is used instead of manually implementing the fallback emulation? The GPR iterator only defines DI for TARGET_POWERPC64, so how does GCC get into the muldi3

Re: [PATCH] rs6000: Fix safe-indirect-jump-[18].c

2018-01-26 Thread David Edelsohn
On Fri, Jan 26, 2018 at 2:27 PM, Segher Boessenkool wrote: > Thist patch merges the safe-indirect-jump-1.c and -8.c testcases, > since they do the same thing. On the 64-bit and AIX ABIs the indirect > call is not a sibcall, since there is code generated after the call

Re: [PATCH] Document PowerPC 'native' cpu type

2018-01-25 Thread David Edelsohn
On Thu, Jan 25, 2018 at 1:44 PM, Segher Boessenkool <seg...@kernel.crashing.org> wrote: > Hi! > > On Thu, Jan 25, 2018 at 01:24:56PM -0500, David Edelsohn wrote: >> +Specifying @samp{native} as cpu type detects and selects the >> +architecture option that corres

[PATCH] Document PowerPC 'native' cpu type

2018-01-25 Thread David Edelsohn
The PowerPC port(s) of GCC have included auto-detection of host cpu type through the "native" option, but it had not been documented. This patch adds the documentation to the GCC Manual. * doc/invoke.texi (PowerPC Options): Document 'native' cpu type. Thanks, David Index: invoke.texi

Re: [PATCH, rs6000] Skip safe-indirect-jump-8.c for AIX

2018-01-21 Thread David Edelsohn
On Sun, Jan 21, 2018 at 8:46 AM, Bill Schmidt wrote: > Hi, > > Segher discovered that one of the new safe-indirect-jump tests fails on AIX > because of a difference between AIX_V4 and AIX_ABI for 32-bit code. The > former generates sibcalls for nonlocal function

Re: [PATCH, rs6000] Use $ instead of . for PC

2018-01-19 Thread David Edelsohn
On Fri, Jan 19, 2018 at 3:58 PM, Bill Schmidt wrote: > Hi, > > My recent patches to trunk and gcc-7-branch for avoiding speculation of > indirect branches has a flaw, pointed out by David. Usage of "." to > represent the program counter is not portable across all

Re: [PATCH v2, rs6000] Implement 32- and 64-bit BE handling for -mno-speculate-indirect-jumps

2018-01-19 Thread David Edelsohn
This patch is incorrect for AIX. Which also means that the backport to GCC 7 branch is incorrect for AIX and must be corrected before the release. AIX assembler does not accept "." (period) as the current address. "b ." is incorrect. And testing for "b ." is incorrect. I am going to try

Re: [PATCH,AIX] Optimize parsing of include files.

2018-01-19 Thread David Edelsohn
On Thu, Jan 18, 2018 at 9:56 AM, REIX, Tony wrote: > > Description: > * This patch optimizes the time required for parsing the include files. > > Tests: > * AIX: Build: SUCCESS >- build made by means of gmake on AIX. > > ChangeLog: > * xcoff.c: Optimize parsing of

Re: [PATCH] rs6000: Remove -mstring

2018-01-12 Thread David Edelsohn
On Fri, Jan 12, 2018 at 11:22 AM, Segher Boessenkool wrote: > -mstring is only enabled by default on 601, and with -Os on some > configurations. It is almost always slower (than not using it) and > does not very often lead to smaller code. > > This patch disables it.

Re: [SFN] Bootstrap broken

2017-12-12 Thread David Edelsohn
Rainer, PR83396 opened. you can add Solaris to the list of targets. - David On Tue, Dec 12, 2017 at 1:49 PM, Rainer Orth wrote: > Hi David, > >> Something in this series broke bootstrap on AIX, probably Power in general. > > I'm seeing the same in a

[SFN] Bootstrap broken

2017-12-12 Thread David Edelsohn
Something in this series broke bootstrap on AIX, probably Power in general. - David /nasfarm/edelsohn/src/src/gcc/gimple-pretty-print.c: In function 'void pp_gimple_stmt_1(pretty_printer*, gimple*, int, dump_flags_t)': /nasfarm/edelsohn/src/src/gcc/gimple-pretty-print.c:2645:1: error: invalid

[PATCH,libstdc++ testsuite] Fix hyperg failures

2017-12-07 Thread David Edelsohn
When the testcases were regenerated due to PR libstdc++/PR66689, -ffp-contract=off was omitted from (at least) the hyperg check_value.cc testcases, causing runtime regression. This patch restores the dg-options directive. This returns the libstdc++ testsuite to all passing on AIX. Bootstrapped

<    1   2   3   4   5   6   7   8   9   10   >