Re: [GOOGLE] Fixup varpool references after LIPO linking

2014-08-28 Thread Teresa Johnson
node. The non-external node is a COMDAT, as as the comments in that routine indicate, COMDATs can be removed even if they are externally_visible. Teresa David On Thu, Aug 28, 2014 at 1:29 PM, Teresa Johnson tejohn...@google.com wrote: This patch fixes up varpool nodes after LIPO linking

[GOOGLE] Fix gcda build info support

2014-09-10 Thread Teresa Johnson
is the google/4_8 patch - I plan to commit there first then port it along with the original build info patch to 4_9. Passes regression tests - ok for google branches? Thanks, Teresa 2014-09-10 Teresa Johnson tejohn...@google.com libgcc: * libgcov-driver.c (gcov_scan_to_function_data): Rename

Re: [GOOGLE] Fix gcda build info support

2014-09-11 Thread Teresa Johnson
one in gcov_exit_merge_gcda further down in the same file? Sure, I could outline that and pass in the gi_ptr for the merger case. Let me know if you meant something else. Teresa David On Wed, Sep 10, 2014 at 10:24 AM, Teresa Johnson tejohn...@google.com wrote: While porting recent support

Re: [GOOGLE] Fix gcda build info support

2014-09-11 Thread Teresa Johnson
On Thu, Sep 11, 2014 at 10:17 AM, Xinliang David Li davi...@google.com wrote: Yes, that is what I meant. David On Thu, Sep 11, 2014 at 10:09 AM, Teresa Johnson tejohn...@google.com wrote: On Wed, Sep 10, 2014 at 3:31 PM, Xinliang David Li davi...@google.com wrote: Can you share

[GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

2014-09-12 Thread Teresa Johnson
the gcov-tool output (remove an overly-verbose output, make all output consistently go to stderr). Passes regression tests and manual tests. Ok for google branches? 2014-09-12 Teresa Johnson tejohn...@google.com * gcc/coverage.c (read_counts_file): Handle new section. * gcc/gcov.c

Re: [GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

2014-09-16 Thread Teresa Johnson
-driver.cc (dyn_cgraph_node), which is where it is allocated. That routine does not have access to the dyn-ipa cgraph. Teresa David On Fri, Sep 12, 2014 at 4:31 PM, Teresa Johnson tejohn...@google.com wrote: This patch addresses issues when running gcov-tool after performing COMDAT fixup during

Re: [GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

2014-09-16 Thread Teresa Johnson
as a bitvector as we do in the gcda file. Teresa David On Tue, Sep 16, 2014 at 7:57 AM, Teresa Johnson tejohn...@google.com wrote: On Mon, Sep 15, 2014 at 9:29 PM, Xinliang David Li davi...@google.com wrote: Is it necessary to declare zero_counts array at all? Can a flag field be added

Re: [GOOGLE] Fix LIPO COMDAT fixup and gcov-tool interactions

2014-09-22 Thread Teresa Johnson
be flagged in some way for downstream phases, but it is not a compilation mode we are using so I have not experimented. Thanks, Teresa nathan -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

[GOOGLE] Fix dynamic instrumentation patching for cold sections

2014-09-23 Thread Teresa Johnson
tests. Ok for google branches? Thanks, Teresa 2014-09-23 Teresa Johnson tejohn...@google.com Google ref b/17608598. * config/i386/i386.c (ix86_output_function_nops_prologue_epilogue): Ensure we switch to correct section. * testsuite/gcc.dg/tree-prof

[GOOGLE] Fix new tests

2014-09-24 Thread Teresa Johnson
does splitting. Ok for google branches? Teresa 2014-09-24 Teresa Johnson tejohn...@google.com * testsuite/gcc.dg/tree-prof/cold_partition_patch.c: * testsuite/g++.dg/tree-prof/partition_patch.C: Index: testsuite/gcc.dg/tree-prof/cold_partition_patch.c

Re: [GOOGLE] Fix new tests

2014-09-24 Thread Teresa Johnson
if it is x86_64, otherwise it simply does splitting. Ok for google branches? Teresa 2014-09-24 Teresa Johnson tejohn...@google.com * testsuite/gcc.dg/tree-prof/cold_partition_patch.c: * testsuite/g++.dg/tree-prof/partition_patch.C: Index: testsuite/gcc.dg/tree-prof

[google/gcc-4_7] Backport r193747 to using working set for bb hotness (issue6907063)

2012-12-10 Thread Teresa Johnson
This is a backport of r193747 to use the working set from the profile summary to determine the bb hot count threshold. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for google 4_7 branch? Thanks, Teresa 2012-12-10 Teresa Johnson tejohn...@google.com Backport r193747 from

Re: [PATCH] New fdo summary-based icache sensitive unrolling (issue6351086)

2012-12-11 Thread Teresa Johnson
On Tue, Dec 11, 2012 at 10:12 AM, Jan Hubicka hubi...@ucw.cz wrote: On 2012.12.11 at 09:13 -0800, Teresa Johnson wrote: Ping. Teresa On Mon, Nov 19, 2012 at 4:58 PM, Teresa Johnson tejohn...@google.com wrote: This patch was proposed awhile back, and the new working set program

Re: PR other/54324: allow bootstrapping with older compilers

2012-12-12 Thread Teresa Johnson
: Thanks for uncovering the gcov-io.c bug :-) Yes, thanks for fixing this. The fix looks good to me. Thanks, Teresa Ciao! Steven -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: PR other/54324: allow bootstrapping with older compilers

2012-12-12 Thread Teresa Johnson
On Wed, Dec 12, 2012 at 7:25 AM, Richard Biener rguent...@suse.de wrote: On Wed, 12 Dec 2012, Teresa Johnson wrote: On Wed, Dec 12, 2012 at 2:21 AM, Steven Bosscher stevenb@gmail.com wrote: On Wed, Dec 12, 2012 at 6:07 AM, Aldy Hernandez wrote: I don't know how much

Re: [PATCH] Use new dump scheme for loop unroll passes

2012-12-13 Thread Teresa Johnson
the following MSG_MISSED_OPTIMIZATION == MSG_MISSED MSG_OPTIMIZED_LOCATIONS == MSG_OPTIMIZED But that is pure renaming and can be done separately.) I have bootstrapped and tested this patch on x86_64 and found no new failures. Okay for trunk? Thanks, Sharad -- Teresa

[PATCH] Fix LTO binary size increases (PR gcov-profile/55674) (issue6946049)

2012-12-13 Thread Teresa Johnson
2012-12-13 Teresa Johnson tejohn...@google.com PR gcov-profile/55674 * lto-cgraph.c (merge_profile_summaries): Set min correctly the first time we merge into a histogram entry. Index: lto-cgraph.c

[PATCH] Compute and emit working set information from gcov-dump (issue6940061)

2012-12-14 Thread Teresa Johnson
thresholds based on that. This required moving the bulk of the compute_working_sets functionality into gcov-io.c so that it was accessible by gcov-dump.c. Bootstrapped and tested on x86_64-unknown-linux-gnu, and tested with various gcda files. Ok for trunk? 2012-12-14 Teresa Johnson tejohn

Re: [PATCH] Use new dump scheme to emit loop unroll/peel summary info (issue6941070)

2012-12-20 Thread Teresa Johnson
On Thu, Dec 20, 2012 at 1:21 AM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: Thanks for your comments. Responses inlined below, and new patch include below. On Mon, Dec 17, 2012 at 10:44:59PM -0800, Teresa Johnson wrote: Index: tree-ssa-loop-ivcanon.c

Re: [google 4.7] fdo build for linux kernel (issue6968046)

2012-12-21 Thread Teresa Johnson
unsigned gcov_gcda_file_size (struct gcov_info *); #else /* Available outside libgcov */ GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, -- This patch is available for review at http://codereview.appspot.com/6968046 -- Teresa Johnson | Software Engineer | tejohn...@google.com

Re: [google 4.7] fdo build for linux kernel (issue6968046)

2012-12-21 Thread Teresa Johnson
, Teresa Johnson tejohn...@google.com wrote: On Wed, Dec 19, 2012 at 12:11 PM, Rong Xu x...@google.com wrote: Hi, This patch updates the support for FDO build in linux kernel for gcc 4.7. Tested with 2.6.34 kernel and google internal benchmarks. Thanks, -Rong 2012-12-19 Rong Xu x

Re: [PATCH] Use new dump scheme to emit loop unroll/peel summary info (issue6941070)

2013-01-02 Thread Teresa Johnson
On Thu, Dec 20, 2012 at 9:20 AM, Teresa Johnson tejohn...@google.com wrote: On Thu, Dec 20, 2012 at 1:21 AM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: Thanks for your comments. Responses inlined below, and new patch include below. On Mon, Dec 17, 2012 at 10:44:59PM -0800

Re: Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2013-02-05 Thread Teresa Johnson
2012 20:26, Teresa Johnson tejohn...@google.com wrote: On Wed, Nov 28, 2012 at 7:48 AM, Christophe Lyon christophe.l...@linaro.org wrote: I have updated my trunk checkout, and I can confirm that eval.c now compiles with your patch (and the other 4 patches I added to PR55121). good Now

[google 4_7] Fix bad merge into coverage_init (issue7322063)

2013-02-12 Thread Teresa Johnson
This patch fixes a bad merge from google/integration to google/4_7. Passes regression tests. Ok for google/4_7? Thanks, Teresa 2013-02-12 Teresa Johnson tejohn...@google.com * coverage.c (coverage_init): Move test coverage handling to the correct location within coverage_init

Re: [google 4_7] Fix bad merge into coverage_init (issue7322063)

2013-02-12 Thread Teresa Johnson
Ok, I will apply the same fix to google/main after appropriate testing. Teresa On Tue, Feb 12, 2013 at 1:54 PM, Xinliang David Li davi...@google.com wrote: ok. The same problem exists in google/main too. David On Tue, Feb 12, 2013 at 1:38 PM, Teresa Johnson tejohn...@google.com wrote

MAINTAINERS: add myself

2011-10-24 Thread Teresa Johnson
mjam...@suse.cz Andrew Jenner and...@codesourcery.com Janis Johnson jani...@codesourcery.com +Teresa Johnson tejohn...@google.com Kean Johnston j

[Patch, i386] Avoid LCP stalls (issue5975045)

2012-04-04 Thread Teresa Johnson
Opteron and the results were neutral. Bootstrapped and tested on x86_64-unknown-linux-gnu. Is this ok for trunk? Thanks, Teresa 2012-04-04 Teresa Johnson tejohn...@google.com * config/i386/i386.h (ix86_tune_indices): Add X86_TUNE_LCP_STALL. * config/i386/i386.md (move

Re: [Patch, i386] Avoid LCP stalls (issue5975045)

2012-04-04 Thread Teresa Johnson
On Wed, Apr 4, 2012 at 5:39 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Apr 4, 2012 at 5:07 PM, Teresa Johnson tejohn...@google.com wrote: New patch to avoid LCP stalls based on feedback from earlier patch. I modified H.J.'s old patch to perform the peephole2 to split immediate moves

Re: [Patch, i386] Avoid LCP stalls (issue5975045)

2012-04-05 Thread Teresa Johnson
the peephole2 to split immediate moves to HImode memory. This is now enabled for Core2, Corei7 and Generic. 2012-04-04   Teresa Johnson  tejohn...@google.com       * config/i386/i386.h (ix86_tune_indices): Add       X86_TUNE_LCP_STALL.       * config/i386/i386.md (move immediate to memory peephole2

[google/google-main] Fix for unused variable warning in libgcov.c (issue6052049)

2012-04-17 Thread Teresa Johnson
I have a patch to fix a compile time warning about an unused variable due to the use being guarded by #ifndef __GCOV_KERNEL__. Tested with bootstrap. Ok for google-main? Teresa 2012-04-17 Teresa Johnson tejohn...@google.com Google ref b/5910724. * libgcc/libgcov.c

[PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-04-24 Thread Teresa Johnson
.gobmk (with FDO feedback where unrolling kicks in) by close to 1% on AMD Opteron. Other performance effects are neutral. Bootstrapped and tested on x86_64-unknown-linux-gnu. Is this ok for trunk? Thanks, Teresa 2012-04-24 Teresa Johnson tejohn...@google.com * loop-unroll.c

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-04-24 Thread Teresa Johnson
Resending my response in plain text so it will go through to gcc-patches... On Tue, Apr 24, 2012 at 2:36 PM, Teresa Johnson tejohn...@google.com wrote: On Tue, Apr 24, 2012 at 2:30 PM, Andrew Pinski pins...@gmail.com wrote: On Tue, Apr 24, 2012 at 2:26 PM, Teresa Johnson tejohn

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-04-25 Thread Teresa Johnson
On Tue, Apr 24, 2012 at 4:38 PM, Steven Bosscher stevenb@gmail.com wrote: On Tue, Apr 24, 2012 at 11:26 PM, Teresa Johnson tejohn...@google.com wrote:        * params.def (PARAM_MIN_ITER_UNROLL_WITH_BRANCHES): New param.        (PARAM_UNROLL_OUTER_LOOP_BRANCH_BUDGET): Ditto. You should

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-04-25 Thread Teresa Johnson
On Tue, Apr 24, 2012 at 6:13 PM, Andi Kleen a...@firstfloor.org wrote: tejohn...@google.com (Teresa Johnson) writes: This patch adds heuristics to limit unrolling in loops with branches that may increase branch mispredictions. It affects loops that are not frequently iterated

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-04-25 Thread Teresa Johnson
On Wed, Apr 25, 2012 at 2:03 AM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Apr 24, 2012 at 11:26 PM, Teresa Johnson tejohn...@google.com wrote: This patch adds heuristics to limit unrolling in loops with branches that may increase branch mispredictions. It affects loops

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue 6099055)

2012-05-01 Thread Teresa Johnson
#newcode319 params.def:319: missing comment. http://codereview.appspot.com/6099055/ -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

[PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-05-01 Thread Teresa Johnson
2012-05-01 Teresa Johnson tejohn...@google.com * doc/invoke.texi: Update the documentation with new params. * loop-unroll.c (max_unroll_with_branches): New function. (loop_exit_at_end_p, decide_peel_once_rolling): Rename niter_desc to loop_desc

[PATCH] libgcov support for profile collection in region of interest (issue6186044)

2012-05-03 Thread Teresa Johnson
-05-03 Teresa Johnson tejohn...@google.com * libgcc/libgcov.c (gcov_clear, __gcov_reset): New functions. (__gcov_dump): Ditto. (gcov_dump_complete): New global variable. (__gcov_flush): Outline functionality now in gcov_clear. * gcc/gcov-io.h (__gcov_reset

[PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-05-04 Thread Teresa Johnson
to compute the average number of branches in the loop. 4) Detect more types of floating point computations in the loop by walking all set instructions, not just single sets. 2012-05-04 Teresa Johnson tejohn...@google.com * doc/invoke.texi: Update the documentation with new params

[PATCH] libgcov support for profile collection in region of interest (issue6186044)

2012-05-08 Thread Teresa Johnson
Hi Honza, I added L_gcov_reset and L_gcov_dump for the new interfaces, and also added a description into the gcov man page. Let me know if it looks ok now. Bootstrapped and tested on x86_64-unknown-linux-gnu. Thanks, Teresa 2012-05-08 Teresa Johnson tejohn...@google.com * libgcc

Re: [PATCH] libgcov support for profile collection in region of interest (issue6186044)

2012-05-08 Thread Teresa Johnson
. Thanks, Teresa 2012-05-08   Teresa Johnson  tejohn...@google.com       * libgcc/libgcov.c (gcov_clear, __gcov_reset): New functions.       (__gcov_dump): Ditto.       (gcov_dump_complete): New global variable.       (__gcov_flush): Outline functionality now in gcov_clear.       * gcc

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-05-11 Thread Teresa Johnson
Ping? Teresa On Fri, May 4, 2012 at 3:41 PM, Teresa Johnson tejohn...@google.com wrote: On David's suggestion, I have removed the changes that rename niter_desc to loop_desc from this patch to focus the patch on the unrolling changes. I can submit a cleanup patch to do the renaming as soon

[google] Instrumented sampling FDO interface cleanup (issue6210058)

2012-05-14 Thread Teresa Johnson
-generate-sampling, and fuction __gcov_sampling_enabled to return the state of this flag. The flag is checked when a call is made to set the sampling period. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for google branches? Thanks, Teresa 2012-05-14 Teresa Johnson tejohn...@google.com

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-05-18 Thread Teresa Johnson
Ping? Teresa On Fri, May 11, 2012 at 6:11 AM, Teresa Johnson tejohn...@google.com wrote: Ping? Teresa On Fri, May 4, 2012 at 3:41 PM, Teresa Johnson tejohn...@google.com wrote: On David's suggestion, I have removed the changes that rename niter_desc to loop_desc from this patch to focus

Re: [PATCH] Improve andq $0xffffffff, %reg handling (PR target/53110)

2012-07-24 Thread Teresa Johnson
On Tue, Jul 24, 2012 at 3:18 AM, Uros Bizjak ubiz...@gmail.com wrote: On Mon, Jul 23, 2012 at 10:17 PM, Teresa Johnson tejohn...@google.com wrote: Resending in plain text mode so it goes through. Teresa On Mon, Jul 23, 2012 at 12:03 PM, Teresa Johnson tejohn...@google.com wrote: Any

Re: [google] Modification of gcov pmu format to reduce gcda size bloat (issue6427063)

2012-07-25 Thread Teresa Johnson
Resending in plain text mode so that it goes through to mailing list... On Wed, Jul 25, 2012 at 11:32 AM, Teresa Johnson tejohn...@google.com wrote: On Tue, Jul 24, 2012 at 3:03 PM, Chris Manghane cm...@google.com wrote: This patch modifies pmu-profile to allow gooda_feedback access

Re: [PATCH] New fdo summary-based icache sensitive unrolling (issue6351086)

2012-07-26 Thread Teresa Johnson
Ping. Teresa On Wed, Jul 18, 2012 at 8:48 AM, Teresa Johnson tejohn...@google.com wrote: Ping (retrying ping in plain text mode so that it goes through properly). Thanks, Teresa On Wed, Jul 11, 2012 at 10:42 AM, Teresa Johnson tejohn...@google.com wrote: Ports some patches related

Re: [PATCH] New fdo summary-based icache sensitive unrolling (issue 6351086)

2012-07-26 Thread Teresa Johnson
Resending in plain text mode...sigh. Teresa On Thu, Jul 26, 2012 at 1:32 PM, Teresa Johnson tejohn...@google.com wrote: On Thu, Jul 26, 2012 at 11:26 AM, davi...@google.com wrote: http://codereview.appspot.com/6351086/diff/1/gcc/gcov-io.h File gcc/gcov-io.h (right): http

[PATCH] New fdo summary-based icache sensitive unrolling (issue6351086)

2012-07-26 Thread Teresa Johnson
on x86_64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2012-07-26 Teresa Johnson tejohn...@google.com * libgcc/libgcov.c (sort_by_reverse_gcov_value): New function. (gcov_compute_cutoff_values): Ditto. (gcov_exit): Call gcov_compute_cutoff_values and merge new summary

Re: [PATCH] New fdo summary-based icache sensitive unrolling (issue6351086)

2012-07-27 Thread Teresa Johnson
On Fri, Jul 27, 2012 at 12:31 AM, Steven Bosscher stevenb@gmail.com wrote: On Fri, Jul 27, 2012 at 6:47 AM, Teresa Johnson tejohn...@google.com wrote: * gcc/gcov-io.h (GCOV_TAG_SUMMARY_LENGTH): Update for new summary info. (struct gcov_ctr_summary): Add new summary info

Re: Fwd: [PATCH] New fdo summary-based icache sensitive unrolling (issue6351086)

2012-07-27 Thread Teresa Johnson
for the gcov changes only, and a follow-on patch with my loop unroller changes. Thanks! Teresa Honza -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [google] Remove deprecated pfmon-specific functions/structs from pmu-profile.c (was: Changed strucs to structs) (issue6442086)

2012-08-06 Thread Teresa Johnson
(); - - if (tool_details-cleanup_pmu_data) -tool_details-cleanup_pmu_data (the_pmu_tool_info-pmu_data); -} - #endif -- This patch is available for review at http://codereview.appspot.com/6442086 -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [google] Remove deprecated pfmon-specific functions/structs from pmu-profile.c (was: Changed strucs to structs) (issue6442086)

2012-08-06 Thread Teresa Johnson
-patch.py script or is there something I'm missing? Thanks, Chris On Mon, Aug 6, 2012 at 9:13 AM, Teresa Johnson tejohn...@google.com wrote: Revised the subject to add [google] tag and add original patch description. Chris, you can use the same subject as the original patch and just

Re: [google] Remove deprecated pfmon-specific functions/structs from pmu-profile.c (issue6442086)

2012-08-08 Thread Teresa Johnson
I have committed this to google/main for Chris (approved by Rong). Chris, please prepare a patch to backport this to google/4_7. Teresa On Tue, Aug 7, 2012 at 3:55 PM, Chris Manghane cm...@google.com wrote: Removes references in libgcov.c to functions and structs removed from pmu-profile.c

Re: [PATCH] Add working-set size and hotness information to fdo summary (issue6465057)

2012-08-19 Thread Teresa Johnson
entries for 64-bit counters, and each entry contains 2 gcov_type counter values and one unsigned int. The working set entries only have one gcov_type counter and one unsigned. So it could be close to 4x. What do you think? Thanks, Teresa Honza -- Teresa Johnson | Software Engineer | tejohn

Re: [PATCH] Add working-set size and hotness information to fdo summary (issue6465057)

2012-08-20 Thread Teresa Johnson
with the approach of scaling the counter values using the sum_all ratio, or encode/merge the histograms instead. Teresa Honza Thanks, Teresa Honza -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413 -- Teresa Johnson | Software Engineer | tejohn

Re: [PATCH] Add working-set size and hotness information to fdo summary (issue6465057)

2012-08-20 Thread Teresa Johnson
is dealing with a single gcda file containing multiple program summaries. Is there code somewhere that will cause this to happen? Thanks, Teresa Ciao! Steven -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Add working-set size and hotness information to fdo summary (issue6465057)

2012-08-20 Thread Teresa Johnson
between the new and old sum_all when merging? Thanks, Teresa Honza -Andi -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Add working-set size and hotness information to fdo summary (issue6465057)

2012-08-21 Thread Teresa Johnson
? Why the grouping is not done inside linker plugin? Honza David -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413 -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Add working-set size and hotness information to fdo summary (issue6465057)

2012-08-22 Thread Teresa Johnson
reasons why it can not be done at link-time when all gcda files are available? Why the grouping is not done inside linker plugin? Honza David -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413 -- Teresa Johnson

[google/4_7] New fix to avoid LCP stalling andw with 0xff

2012-08-23 Thread Teresa Johnson
will prefer to convert to a zero-extending move when the constant is 0xff and the machine has LCP stalls. Google ref b/6615073. Tested with crosstool. Ok for google-4_7? 2012-08-23 Teresa Johnson tejohn...@google.com * config/i386/i386.md (anddi_1): Add new r,qm,Lh pattern first

Re: [google/4_7] New fix to avoid LCP stalling andw with 0xff

2012-08-23 Thread Teresa Johnson
On Thu, Aug 23, 2012 at 3:33 PM, Xinliang David Li davi...@google.com wrote: On Thu, Aug 23, 2012 at 2:01 PM, Teresa Johnson tejohn...@google.com wrote: This patch is for google branches only. This is the patch I plan to apply after reverting an earlier set of patches ported over from trunk

Re: [google] Modification of gcov pmu format to reduce gcda size bloat (issue 6427063)

2012-08-27 Thread Teresa Johnson
/ -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

[PATCH] Add counter histogram to fdo summary (issue6465057)

2012-08-28 Thread Teresa Johnson
://gcc.gnu.org/ml/gcc-patches/2012-07/msg01412.html Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2012-08-28 Teresa Johnson tejohn...@google.com * libgcc/libgcov.c (gcov_histogram_insert): New function. (gcov_compute_histogram): Ditto

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-08-29 Thread Teresa Johnson
it will always require the same number of gcov_unsigned ints (8). Patch is OK if it passed profiledbootstrap modulo the comments above. Ok, thanks. Working on the fixes above. Teresa Thanks! Honza -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-09-04 Thread Teresa Johnson
data point is the minimum counter value and number of counters required to reach a given percentage of the cumulative counter sum across the profiled execution (sum_all in the program summary). 2012-09-04 Teresa Johnson tejohn...@google.com * libgcc/libgcov.c (struct gcov_summary_buffer

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-09-05 Thread Teresa Johnson
that you could send me I can start with that. Sounds like there is a profile merging problem that I didn't see, that is corrupting the gcda files in both cases. Thanks, Teresa On Wed, Sep 5, 2012 at 12:12 AM, Markus Trippelsdorf mar...@trippelsdorf.de wrote: On 2012.09.04 at 14:23 -0700, Teresa Johnson

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-09-05 Thread Teresa Johnson
On Wed, Sep 5, 2012 at 8:44 AM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Sep 5, 2012 at 8:09 AM, Teresa Johnson tejohn...@google.com wrote: Sorry about that. I am right now trying to reproduce the profiledbootstrap problem that H.J. reported, which is on x86_64-unknown-linux-gnu where I had

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-09-05 Thread Teresa Johnson
On Wed, Sep 5, 2012 at 9:13 AM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Sep 5, 2012 at 8:50 AM, Teresa Johnson tejohn...@google.com wrote: On Wed, Sep 5, 2012 at 8:44 AM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Sep 5, 2012 at 8:09 AM, Teresa Johnson tejohn...@google.com wrote: Sorry

Re: [google] Added new dump flag -pmu to display pmu data in pass summaries (issue6489092)

2012-09-06 Thread Teresa Johnson
(pmu_profile_data) +-fpmu-profile-use=[pmuprofile.gcda] The pmu profile data file to use for pmu feedback. fpredictive-commoning Common Report Var(flag_predictive_commoning) Optimization -- This patch is available for review at http://codereview.appspot.com/6489092 -- Teresa Johnson | Software

Re: [google] Added new dump flag -pmu to display pmu data in pass summaries (issue6489092)

2012-09-06 Thread Teresa Johnson
On Thu, Sep 6, 2012 at 5:34 PM, Chris Manghane cm...@google.com wrote: On Thu, Sep 6, 2012 at 5:08 PM, Teresa Johnson tejohn...@google.com wrote: On Thu, Sep 6, 2012 at 2:49 PM, Chris Manghane cm...@google.com wrote: This patch adds a new dump flag that dumps PMU profile information using

[PATCH] Fix part of PR gcov-profile/54487 (issue6501100)

2012-09-06 Thread Teresa Johnson
different histograms when summaries are merged in different orders. Tested with bootstrap and profiledbootstrap on x86_64-unknown-linux-gnu. Ok for trunk? Teresa 2012-09-06 Teresa Johnson tejohn...@google.com PR gcov-profile/54487 * libgcc/libgcov.c (gcov_exit): Avoid warning

[google] Fix exception in unroller code size heuristics (issue6498112)

2012-09-10 Thread Teresa Johnson
Fix divide by zero error. Passes bootstrap and regression tests. Ok for google branches? Teresa 2012-09-10 Teresa Johnson tejohn...@google.com * loop-unroll.c (code_size_limit_factor): Index: loop-unroll.c === --- loop

[PATCH] Fix PR gcov-profile/54487 (profiledbootstrap intermittent failures) (issue6496113)

2012-09-12 Thread Teresa Johnson
set. The fix is to add a compile test in the configure to set it. Tested with bootstrap and profiledbootstrap on x86_64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2012-09-12 Teresa Johnson tejohn...@google.com * configure.ac(HOST_HAS_F_SETLKW): Set based on compile test

Re: [PATCH] Fix PR gcov-profile/54487 (profiledbootstrap intermittent failures) (issue6496113)

2012-09-12 Thread Teresa Johnson
On Wed, Sep 12, 2012 at 1:54 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Sep 12, 2012 at 01:45:12PM -0700, Teresa Johnson wrote: This fixes PR gcov-profile/54487 where the gcda files were not locked by the profile-use read, enabling writes by other instrumented compiles to change

Re: [PATCH] Fix PR gcov-profile/54487 (profiledbootstrap intermittent failures) (issue6496113)

2012-09-12 Thread Teresa Johnson
On Wed, Sep 12, 2012 at 2:12 PM, Teresa Johnson tejohn...@google.com wrote: On Wed, Sep 12, 2012 at 1:54 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Sep 12, 2012 at 01:45:12PM -0700, Teresa Johnson wrote: This fixes PR gcov-profile/54487 where the gcda files were not locked

[google] libgcov workaround for weak reference issue (issue6276043)

2012-06-01 Thread Teresa Johnson
L_gcov) that will always be referenced during -fprofile-generate builds. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for google branches? Thanks, Teresa 2012-06-01 Teresa Johnson tejohn...@google.com * libgcov.c: Add references to gcov_reset and gcov_dump from L_gcov

Re: [google] libgcov workaround for weak reference issue (issue 6276043)

2012-06-01 Thread Teresa Johnson
choice is to let __gcov_flush calls __gcov_dump + __gcov_reset -- but the dump_completed state needs to be saved and restored. David http://codereview.appspot.com/6276043/ -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

[google] New fdo summary-based icache sensitive unrolling (issue6282045)

2012-06-03 Thread Teresa Johnson
on x86_64-unknown-linux-gnu. Ok for google branches? Thanks, Teresa 2012-06-01 Teresa Johnson tejohn...@google.com * libgcc/libgcov.c (sort_by_reverse_gcov_value): New function. (gcov_compute_cutoff_values): Ditto. (gcov_merge_gcda_file): Merge new summary information

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-06 Thread Teresa Johnson
the larger value? that's a good idea - fixed. New patch coming shortly. Thanks, Teresa http://codereview.appspot.com/6282045/ -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-06 Thread Teresa Johnson
. (especially for non-LTO compilations). Any plans fo rmainline version? Yes, I would like to put this in mainline as well. I'll send that patch out after I have added this to the google branches. Thanks, Teresa Honza -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-06 Thread Teresa Johnson
On Wed, Jun 6, 2012 at 3:09 PM, Xinliang David Li davi...@google.com wrote: On Wed, Jun 6, 2012 at 2:02 PM, Teresa Johnson tejohn...@google.com wrote: On Tue, Jun 5, 2012 at 11:46 AM,  davi...@google.com wrote: http://codereview.appspot.com/6282045/diff/1/gcc/gcov-io.h File gcc/gcov-io.h

[google/main] New fdo summary-based icache sensitive unrolling (issue6282045)

2012-06-07 Thread Teresa Johnson
of the previous approach is reverted. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for google branches? Thanks, Teresa 2012-06-06 Teresa Johnson tejohn...@google.com * libgcc/libgcov.c (sort_by_reverse_gcov_value): New function. (gcov_compute_cutoff_values): Ditto

[google/4_6] New fdo summary-based icache sensitive unrolling (issue6298056)

2012-06-07 Thread Teresa Johnson
This is the google/4_6 version of the patch to add new program summary information to the gcov profile files to use as a estimate of code size for guiding unrolling. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for google/4_6? Thanks, Teresa Index: doc/invoke.texi

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-07 Thread Teresa Johnson
going in shortly. Thanks, Teresa http://codereview.appspot.com/6282045/ -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-06-19 Thread Teresa Johnson
Ping. Teresa On Fri, May 18, 2012 at 7:21 AM, Teresa Johnson tejohn...@google.com wrote: Ping? Teresa On Fri, May 11, 2012 at 6:11 AM, Teresa Johnson tejohn...@google.com wrote: Ping? Teresa On Fri, May 4, 2012 at 3:41 PM, Teresa Johnson tejohn...@google.com wrote: On David's suggestion

[PATCH] New fdo summary-based icache sensitive unrolling (issue6351086)

2012-07-11 Thread Teresa Johnson
structure (the optimization portions of that change are not included here, and have an outstanding review request for mainline). Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2012-07-11 Teresa Johnson tejohn...@google.com * libgcc/libgcov.c

Re: [PATCH] New fdo summary-based icache sensitive unrolling (issue6351086)

2012-07-18 Thread Teresa Johnson
Ping (retrying ping in plain text mode so that it goes through properly). Thanks, Teresa On Wed, Jul 11, 2012 at 10:42 AM, Teresa Johnson tejohn...@google.com wrote: Ports some patches related to improving FDO program summary information and using it to guide loop unrolling from google

[google] Enable loop unroll/peel notes under -fopt-info

2011-10-31 Thread Teresa Johnson
This patch is for google-main only. Tested with bootstrap and regression tests. Print unroll and peel factors along with loop source position under -fopt-info. Teresa 2011-10-31 Teresa Johnson tejohn...@google.com * common.opt (fopt-info): Disable -fopt-info by default

Re: [google] Enable loop unroll/peel notes under -fopt-info

2011-11-01 Thread Teresa Johnson
*# times loop is entered). Thanks, Teresa On Tue, Nov 1, 2011 at 2:53 AM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Nov 1, 2011 at 1:46 AM, Teresa Johnson tejohn...@google.com wrote: This patch is for google-main only. Tested with bootstrap and regression tests. Print unroll

[Patch, i386] Add minus to list of promotable operators

2011-11-02 Thread Teresa Johnson
. Successfully bootstrapped and checked with x86_64-unknown-linux-gnu. Could someone please review the change? Thanks, Teresa 2011-11-02 Teresa Johnson tejohn...@google.com * config/i386/predicates.md (promotable_binary_operator): Add minus to the list of promotable operators

[google] Limit unrolling and peeling under LIPO estimates of large code size/icache pressure

2011-11-22 Thread Teresa Johnson
This patch is for google-main only. Tested with bootstrap and regression tests. Under LIPO, estimate the code size footprint from the partial call graph, and if it is large limit unrolling and peeling to avoid increasing icache pressure. Teresa 2011-11-21 Teresa Johnson tejohn...@google.com

Re: [google] Limit unrolling and peeling under LIPO estimates of large code size/icache pressure

2011-11-23 Thread Teresa Johnson
is/will be tested cleanly on google-46. David On Tue, Nov 22, 2011 at 1:12 PM, Diego Novillo dnovi...@google.com wrote: On 11-11-22 16:06 , Teresa Johnson wrote: This patch is for google-main only. Tested with bootstrap and regression tests. Under LIPO, estimate the code size footprint from

Re: [Patch, i386] Limit unroll factor for certain loops on Corei7

2011-12-02 Thread Teresa Johnson
then. Bye, -Andreas- -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Re: [Patch, i386] Limit unroll factor for certain loops on Corei7

2011-12-02 Thread Teresa Johnson
On Fri, Dec 2, 2011 at 11:36 AM, Andi Kleen a...@firstfloor.org wrote: Teresa Johnson tejohn...@google.com writes: Interesting optimization. I would be concerned a little bit about compile time, does it make a measurable difference? I haven't measured compile time explicitly, but I don't

Re: [Patch, i386] Limit unroll factor for certain loops on Corei7

2012-03-16 Thread Teresa Johnson
Ping - now that stage 1 is open, could someone review? Thanks, Teresa On Sun, Dec 4, 2011 at 10:26 PM, Teresa Johnson tejohn...@google.com wrote: Latest patch which improves the efficiency as described below is included here. Boostrapped and checked again with x86_64-unknown-linux-gnu. Could

Re: [google][4.6][i386]Support autocloning for corei7 with -mvarch= option to remove LCP stalls in loops (issue5865043)

2012-03-20 Thread Teresa Johnson
function's body with a      ifunc dispatch call to the right version.  */   gseq = dispatch_using_ifunc (num_versions, current_function_decl, -- This patch is available for review at http://codereview.appspot.com/5865043 -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460

Re: [Patch, i386] Limit unroll factor for certain loops on Corei7

2012-03-30 Thread Teresa Johnson
Pulling this one back as I have a better solution, patch coming shortly. Thanks, Teresa On Fri, Mar 16, 2012 at 3:33 PM, Teresa Johnson tejohn...@google.com wrote: Ping - now that stage 1 is open, could someone review? Thanks, Teresa On Sun, Dec 4, 2011 at 10:26 PM, Teresa Johnson tejohn

[Patch, i386] Avoid LCP stalls (issue5975045)

2012-03-30 Thread Teresa Johnson
avoids this by forcing such instructions to be split into two: a move of the corresponding 32-bit constant into a register, and a move of the register's lower 16 bits into memory. Bootstrapped and tested on x86_64-unknown-linux-gnu. Is this ok for trunk? Thanks, Teresa 2012-03-29 Teresa Johnson

Re: [Patch, i386] Avoid LCP stalls (issue5975045)

2012-03-30 Thread Teresa Johnson
. Thanks, Teresa On Fri, Mar 30, 2012 at 7:18 AM, Teresa Johnson tejohn...@google.com wrote: This patch addresses instructions that incur expensive length-changing prefix (LCP) stalls on some x86-64 implementations, notably Core2 and Corei7. Specifically, a move of a 16-bit constant

<    1   2   3   4   5   >