[Geany-devel] Split Window Patches

2011-03-16 Thread Matthew Brush
Hi, I've done some hacking on splitwindow.c and eliminated some bugs and added some features. I checked the geany/geany-plugins feature/bug trackers and I'll list which of the items I think can be closed. The patches: #0001 Enable code folding on the split window. Closes bug #3097780[1] #0

Re: [Geany-devel] Split Window Patches

2011-03-16 Thread Lex Trotman
Hi Matthew, Wow you've been busy, well done. Seems to work for me. > #0002 > Enable Scintilla's default popup editor menu on the split window editor so > that there's a way to copy/paste/undo/redo/etc. Does this mean that editing now fully works between the two split windows? > Closes bug #29

Re: [Geany-devel] Split Window Patches

2011-03-26 Thread Colomban Wendling
Hi Matthew! Le 17/03/2011 00:49, Matthew Brush a écrit : > #0001 > Enable code folding on the split window. > Closes bug #3097780[1] Applied a slightly modified version to SVN, thanks! :) > #0002 > Enable Scintilla's default popup editor menu on the split window editor > so that there's a way to

Re: [Geany-devel] Split Window Patches

2011-03-26 Thread Matthew Brush
On 03/26/11 17:31, Colomban Wendling wrote: #0002 Enable Scintilla's default popup editor menu on the split window editor so that there's a way to copy/paste/undo/redo/etc. Closes bug #2983145[2] although the keybindings and main menu items still don't work in the split window. Not sure about t

Re: [Geany-devel] Split Window Patches

2011-03-26 Thread Lex Trotman
>> Not sure about this one since the menu is neither translatable nor look >> like other Geany's menus. Maybe manually implementing a basic menu would >> be better? > > Should a bug/feature request also be reported to Scintilla? Its not really Scintilla's problem that Geany menus look different :-

Re: [Geany-devel] Split Window Patches

2011-03-26 Thread Matthew Brush
On 03/26/11 22:44, Lex Trotman wrote: >>> Not sure about this one since the menu is neither translatable nor look >>> like other Geany's menus. Maybe manually implementing a basic menu would >>> be better? >> >> Should a bug/feature request also be reported to Scintilla? > > Its not really Scint

Re: [Geany-devel] Split Window Patches

2011-03-27 Thread Enrico Tröger
On Sat, 26 Mar 2011 22:26:42 -0700, Matthew wrote: >On 03/26/11 17:31, Colomban Wendling wrote: >>> #0002 >>> Enable Scintilla's default popup editor menu on the split window >>> editor so that there's a way to copy/paste/undo/redo/etc. >>> Closes bug #2983145[2] although the keybindings and main

Re: [Geany-devel] Split Window Patches

2011-03-27 Thread Enrico Tröger
On Sun, 27 Mar 2011 16:41:40 +0200, Enrico wrote: >On Sat, 26 Mar 2011 22:26:42 -0700, Matthew wrote: > >>On 03/26/11 17:31, Colomban Wendling wrote: #0002 Enable Scintilla's default popup editor menu on the split window editor so that there's a way to copy/paste/undo/redo/etc.

Re: [Geany-devel] Split Window Patches

2011-03-27 Thread Colomban Wendling
Le 27/03/2011 16:41, Enrico Tröger a écrit : > On Sat, 26 Mar 2011 22:26:42 -0700, Matthew wrote: #0003 Remove the widget reparenting in an attempt to make the plugin work on Windows again. Although I can't test on Windows, I think there's a good chance this will fix the issues

Re: [Geany-devel] Split Window Patches

2011-03-27 Thread Matthew Brush
On 03/27/11 09:11, Colomban Wendling wrote: We need a better fix then. Maybe you can try to find out why the X clipboard get broken on Scintilla (and fix it :D). If it get fixed, we will probably can re-apply the patch. I spent a lot of time studying the Scintilla source and trying various thi

Re: [Geany-devel] Split Window Patches

2011-03-27 Thread Lex Trotman
On 28 March 2011 11:31, Matthew Brush wrote: > On 03/27/11 09:11, Colomban Wendling wrote: >> >> We need a better fix then. Maybe you can try to find out why the X >> clipboard get broken on Scintilla (and fix it :D). If it get fixed, we >> will probably can re-apply the patch. > > I spent a lot o

Re: [Geany-devel] Split Window Patches

2011-03-27 Thread Thomas Martitz
On 28.03.2011 02:31, Matthew Brush wrote: So after spending way too much time on this, and getting nowhere, I give up. I'm attaching a patch that no dev is going to like because it behaves differently on Windows than it does on non-Windows to work around a know issue in GTK+ that is not docu

Re: [Geany-devel] Split Window Patches

2011-03-27 Thread Matthew Brush
On 03/27/11 18:19, Lex Trotman wrote: I only had a short time at lunch to look, but I noticed that Scintilla GTK selection code depends on USE_GTK_CLIPBOARD defined or not. I can't find where its defined so I presume its not. Maybe try with it defined? https://github.com/codebrainz/geany/blob

Re: [Geany-devel] Split Window Patches

2011-03-27 Thread Lex Trotman
On 28 March 2011 13:35, Matthew Brush wrote: > On 03/27/11 18:19, Lex Trotman wrote: >> >> I only had a short time at lunch to look, but I noticed that Scintilla >> GTK selection code depends on USE_GTK_CLIPBOARD defined or not.  I >> can't find where its defined so I presume its not.  Maybe try w

Re: [Geany-devel] Split Window Patches

2011-03-27 Thread Matthew Brush
On 03/27/11 09:11, Colomban Wendling wrote: We need a better fix then. Maybe you can try to find out why the X clipboard get broken on Scintilla (and fix it :D). If it get fixed, we will probably can re-apply the patch. When the ScintillaObject gets reparented (unrealized/re-realized), it does

Re: [Geany-devel] Split Window Patches

2011-03-27 Thread Matthew Brush
On 03/27/11 23:39, Matthew Brush wrote: On 03/27/11 09:11, Colomban Wendling wrote: We need a better fix then. Maybe you can try to find out why the X clipboard get broken on Scintilla (and fix it :D). If it get fixed, we will probably can re-apply the patch. When the ScintillaObject gets repa

Re: [Geany-devel] Split Window Patches

2011-03-28 Thread Lex Trotman
On 28 March 2011 17:39, Matthew Brush wrote: > On 03/27/11 09:11, Colomban Wendling wrote: >> >> We need a better fix then. Maybe you can try to find out why the X >> clipboard get broken on Scintilla (and fix it :D). If it get fixed, we >> will probably can re-apply the patch. > > When the Scinti

Re: [Geany-devel] Split Window Patches

2011-03-28 Thread Enrico Tröger
On Mon, 28 Mar 2011 21:38:22 +1100, Lex wrote: >On 28 March 2011 17:39, Matthew Brush wrote: >> On 03/27/11 09:11, Colomban Wendling wrote: >>> >>> We need a better fix then. Maybe you can try to find out why the X >>> clipboard get broken on Scintilla (and fix it :D). If it get fixed, >>> we wil

Re: [Geany-devel] Split Window Patches

2011-03-28 Thread Matthew Brush
On 03/28/11 11:49, Enrico Tröger wrote: On Mon, 28 Mar 2011 21:38:22 +1100, Lex wrote: I havn't had a chance to try it, but perhaps you should report the problem to Scintilla and submit the two patches to Neil. In general Geany tries to use an unmodified version of Scintilla so that changes don

Re: [Geany-devel] Split Window Patches

2011-03-29 Thread Nick Treleaven
On Mon, 28 Mar 2011 23:44:42 -0700 Matthew Brush wrote: > > First, the Scintilla patches should be shared with upstream, ideally > > they apply them. Then we can patch Geany. > > Done. > > I re-did the patches proper against Scintilla's Mercurial repository and > posted a bug report on Source

Re: [Geany-devel] Split Window Patches

2011-03-29 Thread Matthew Brush
On 03/29/11 06:03, Nick Treleaven wrote: On Mon, 28 Mar 2011 23:44:42 -0700 Matthew Brush wrote: First, the Scintilla patches should be shared with upstream, ideally they apply them. Then we can patch Geany. Done. I re-did the patches proper against Scintilla's Mercurial repository and post

Re: [Geany-devel] Split Window Patches

2011-03-30 Thread Nick Treleaven
On Tue, 29 Mar 2011 18:39:37 -0700 Matthew Brush wrote: > The patches were committed[1][2]. > > So now, can we patch our copy of Scintilla, or do we need to wait until > their next release and then until we update to that version? We can patch our copy now. > I'm pretty confident those patche

Re: [Geany-devel] Split Window Patches

2011-03-30 Thread Enrico Tröger
On Wed, 30 Mar 2011 13:03:33 +0100, Nick wrote: >On Tue, 29 Mar 2011 18:39:37 -0700 >Matthew Brush wrote: > >> The patches were committed[1][2]. Cool! (btw, I also didn't get the mails from the SF tracker although I'm monitoring it, also not all of these mails didn't arrive on the scintilla list

Re: [Geany-devel] Split Window Patches

2011-03-30 Thread Colomban Wendling
Le 30/03/2011 22:59, Enrico Tröger a écrit : > On Wed, 30 Mar 2011 13:03:33 +0100, Nick wrote: >> [...] >> We update soon after a Scintilla release unless it's a major Scintilla >> release that may introduce bugs. > > Currently there is the problem with dropped support for old C++ > compilers whic

Re: [Geany-devel] Split Window Patches

2011-03-30 Thread Lex Trotman
>> Currently there is the problem with dropped support for old C++ >> compilers which may not affect us directly but more over the >> introduction of new C++0x code. >> For details see >> http://groups.google.com/group/scintilla-interest/browse_thread/thread/8f9c4aae5f5c5368/6ecc660f51cecefc. >> Th

Re: [Geany-devel] Split Window Patches

2011-03-30 Thread Matthew Brush
On 03/30/11 05:03, Nick Treleaven wrote: On Tue, 29 Mar 2011 18:39:37 -0700 Matthew Brush wrote: The patches were committed[1][2]. So now, can we patch our copy of Scintilla, or do we need to wait until their next release and then until we update to that version? We can patch our copy now.

Re: [Geany-devel] Split Window Patches - Scintilla C++0x

2011-03-31 Thread Nick Treleaven
On Thu, 31 Mar 2011 09:17:26 +1100 Lex Trotman wrote: > >> Currently there is the problem with dropped support for old C++ > >> compilers which may not affect us directly but more over the > >> introduction of new C++0x code. > >> For details see > >> http://groups.google.com/group/scintilla-inte

Re: [Geany-devel] Split Window Patches - Scintilla C++0x

2011-03-31 Thread Enrico Tröger
On Thu, 31 Mar 2011 16:56:44 +0100, Nick wrote: >On Thu, 31 Mar 2011 09:17:26 +1100 >Lex Trotman wrote: > >> >> Currently there is the problem with dropped support for old C++ >> >> compilers which may not affect us directly but more over the >> >> introduction of new C++0x code. >> >> For detail

Re: [Geany-devel] Split Window Patches - Scintilla C++0x

2011-04-02 Thread Matthew Brush
On 03/31/11 10:34, Enrico Tröger wrote: Ok, then we could update our Scintilla copy soon, either with the current release and patch Matthew's patches in or wait for the next release which includes the patches. FWIW, I finally got Geany compiling on Windows XP. Even without the patches, using