Re: [gem5-dev] Review Request: slicc: isinstance bugfix

2013-01-22 Thread Hower, Derek
If we don't accept this patch, then we will need to modify all the existing protocols, as they all use the duplicate names (do a grep "Address Address"). The only reason they compile is that they get lucky at this check and the Address the symbol table finds first is the one it is looking for. I

Re: [gem5-dev] Allocating main event queues dynamically

2013-01-22 Thread Nilay
Steve, I think things are working correctly. Note that I was just printing the help message. So simulate() will never get called. And at exit, the stats.dump function gets called which queries for the current tick. -- Nilay On Tue, January 22, 2013 9:10 pm, Steve Reinhardt wrote: > That seems st

Re: [gem5-dev] Allocating main event queues dynamically

2013-01-22 Thread Steve Reinhardt
That seems strange... atexit.register(stats.dump) should just be enqueuing a pointer to the stats.dump function to be called when the simulator exits. The stats.dump function should not actually be executed at that point in time. Steve On Tue, Jan 22, 2013 at 6:25 PM, Nilay wrote: > On Tue, J

Re: [gem5-dev] Review Request: slicc: isinstance bugfix

2013-01-22 Thread Nilay
On Thu, January 17, 2013 2:28 pm, Hower, Derek wrote: > Most protocols, by convention, use uppercase names for members of TBEs, > messages, etc. > My opinion is that the compiler should do as little work as possible. Unless allowing such convention makes the compiler's job simpler, I would vote ag

Re: [gem5-dev] Allocating main event queues dynamically

2013-01-22 Thread Nilay
On Tue, January 22, 2013 3:35 pm, Steve Reinhardt wrote: > I think the question Ali was asking is where in the python is curTick() > being called before simulate(). On the C++ side, any call from python is > going to come through core_wrap.cc. You might have to use the python > debugger and put a

Re: [gem5-dev] Allocating main event queues dynamically

2013-01-22 Thread Nilay
Let's drop the dynamic allocation of queues for the time being. Assume that we have N event queues, N threads. Here N is known statically. Each thread will operate on one event queue. The curTick() function when called, will return the tick value of the event queue associated with the thread calli

[gem5-dev] Review Request: arm: fix some fp comparisons that worked by accident.

2013-01-22 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1663/ --- Review request for Default. Description --- Changeset 9482:188525ba03fb --

[gem5-dev] Review Request: ARM: Fix an issue with clang generating wrong code.

2013-01-22 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1662/ --- Review request for Default. Description --- Changeset 9480:2c188ea1262d --

[gem5-dev] Review Request: cpu: fix case with o3 cpu blocking and unblocking decode in cycle

2013-01-22 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1661/ --- Review request for Default. Description --- Changeset 9514:dbc0f2f7a43c --

[gem5-dev] Review Request: cpu: Fix a livelock in the o3 cpu.

2013-01-22 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1660/ --- Review request for Default. Description --- Changeset 9513:86c772cdcb3e --

Re: [gem5-dev] Allocating main event queues dynamically

2013-01-22 Thread Ali Saidi
And the second part of the question is what information do you need to make a sensible decision about event queues? I'm not quite sure what you're doing, so I'm not completely sure. If you want to create one per physical core on the machine, you should be able to do that as early as main(), if y

Re: [gem5-dev] Allocating main event queues dynamically

2013-01-22 Thread Steve Reinhardt
I think the question Ali was asking is where in the python is curTick() being called before simulate(). On the C++ side, any call from python is going to come through core_wrap.cc. You might have to use the python debugger and put a breakpoint on the python side of the swig-generated code to figu

Re: [gem5-dev] Allocating main event queues dynamically

2013-01-22 Thread Nilay
Ali, curTick() is being called from the file python/swig/core_wrap.cc. I am running the following command: ./build/X86/gem5.debug ./configs/example/ruby_network_test.py --help When I try to run the network test itself, i.e. with out the help option, I get a segmentation fault, again because of cur

Re: [gem5-dev] Allocating main event queues dynamically

2013-01-22 Thread Ali Saidi
Is something calling the curTick() method or are you saying that by virtue of wrapping curTick() it's being called somehow. I'm not sure how the latter could happen. In the case of the prior, any idea what's calling it? Ali On 22.01.2013 14:56, Nilay wrote: > I am trying to allocate the ma

[gem5-dev] Allocating main event queues dynamically

2013-01-22 Thread Nilay
I am trying to allocate the main event queue(s) dynamically, but I am running into a problem related to curTick(). In the file src/python/swig/core.i, the function curTick() has been declared. This leads SWIG to generate code that calls curTick(). It seems this function call happens before the main

Re: [gem5-dev] Review Request: mem: Add tTAW and tFAW to the SimpleDRAM model

2013-01-22 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1588/ --- (Updated Jan. 22, 2013, 10:59 a.m.) Review request for Default. Description (upda

[gem5-dev] Cron /z/m5/regression/do-regression quick

2013-01-22 Thread Cron Daemon
scons: `build/ALPHA_MOESI_hammer/tests/opt/quick/fs' is up to date. scons: `build/ALPHA_MESI_CMP_directory/tests/opt/quick/fs' is up to date. scons: `build/ALPHA_MOESI_CMP_directory/tests/opt/quick/fs' is up to date. scons: `build/ALPHA_MOESI_CMP_token/tests/opt/quick/fs' is up to date. scons: `bui