[gem5-dev] changeset in gem5: gpu-compute: remove unnecessary member from c...

2017-02-27 Thread Tony Gutierrez
changeset 3bfed693ff22 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=3bfed693ff22 description: gpu-compute: remove unnecessary member from class The clang compiler complains that the wavefront member in the GpuISA class is unused. This changeset remo

Re: [gem5-dev] Review Request 3827: python: Use PyBind11 instead of SWIG for Python wrappers

2017-02-23 Thread Tony Gutierrez
for using PyBind besides Python 2.7 or 3.x and the std clibs? I see that the PyBind GitHub only mentions these dependencies, and I wanted to get confirmation based on your experiences using it. - Tony Gutierrez On Feb. 21, 2017, 10:56 a.m., Andreas Sandberg wrote

Re: [gem5-dev] Review Request 3830: syscall_emul: remove unused class and member

2017-02-23 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3830/#review9460 --- Ship it! Ship It! - Tony Gutierrez On Feb. 23, 2017, 11:33 a.m

Re: [gem5-dev] Review Request 3819: python: Add a generalized mechanism to configure stats

2017-02-23 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3819/#review9459 --- Ship it! Ship It! - Tony Gutierrez On Feb. 22, 2017, 2:02 a.m

Re: [gem5-dev] Review Request 3820: tests: Disable descriptions in stat files

2017-02-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3820/#review9445 --- Ship it! Ship It! - Tony Gutierrez On Feb. 21, 2017, 10:53 a.m

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

2017-02-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9441 --- Ship it! Ship It! - Tony Gutierrez On Feb. 21, 2017, 9:34 a.m

Re: [gem5-dev] Review Request 3680: syscall_emul: [patch 13/22] add system call retry capability

2017-02-17 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3680/#review9436 --- Ship it! Ship It! - Tony Gutierrez On Feb. 17, 2017, 2:03 p.m

Re: [gem5-dev] Review Request 3806: sparc: fix bugs caused by cd7f3a1dbf55

2017-02-15 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3806/#review9428 --- Ship it! Ship It! - Tony Gutierrez On Feb. 10, 2017, 12:31 p.m

Re: [gem5-dev] Review Request 3802: mem, stats: fix typos in CommMonitor and Stats

2017-02-06 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3802/#review9408 --- Ship it! Ship It! - Tony Gutierrez On Feb. 6, 2017, 5:43 a.m

Re: [gem5-dev] Review Request 3806: sparc: fix bugs caused by cd7f3a1dbf55

2017-02-06 Thread Tony Gutierrez
it you can use the 2 arg variant of bits(T val, int bit), which will call the 3 arg version with fist == last. - Tony Gutierrez On Feb. 3, 2017, 10:48 a.m., Brandon Potter wrote: > > --- > This is an automatically generated e-ma

Re: [gem5-dev] Review Request 3800: x86: fix Mul1u instruction

2017-02-05 Thread Tony Gutierrez
ed e-mail. To reply, visit: http://reviews.gem5.org/r/3800/#review9400 --- On Feb. 3, 2017, 4:13 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To

Re: [gem5-dev] Review Request 3800: x86: fix Mul1u instruction

2017-02-03 Thread Tony Gutierrez
used causes the high 64b to be corrupted for certain inputs. here we fix the computation. Diffs (updated) - src/arch/x86/isa/microops/regop.isa ed89cb178ecd7586296d2a2e83595174474db554 Diff: http://reviews.gem5.org/r/3800/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3803: sim: Patch to fix the statfs build

2017-02-03 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3803/#review9394 --- Ship it! Ship It! - Tony Gutierrez On Feb. 3, 2017, 8:25 a.m

Re: [gem5-dev] Review Request 3800: x86: fix Mul1u and Mul1s instructions

2017-02-03 Thread Tony Gutierrez
--- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3804: sim: fix build breakage in process.cc after brandon@11801

2017-02-03 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3804/#review9392 --- Ship it! Ship It! - Tony Gutierrez On Feb. 3, 2017, 8:29 a.m

Re: [gem5-dev] Review Request 3800: x86: fix Mul1u instructions

2017-02-02 Thread Tony Gutierrez
used causes the high 64b to be corrupted for certain inputs. here we fix the computation. Diffs (updated) - src/arch/x86/isa/microops/regop.isa ed89cb178ecd7586296d2a2e83595174474db554 Diff: http://reviews.gem5.org/r/3800/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3800: x86 fix Mul1u instructions

2017-02-02 Thread Tony Gutierrez
e high 64b. - Tony --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3800/#review9366 --- On Feb. 1, 2017, 4:32 p.m.,

[gem5-dev] Review Request 3800: x86 fix Mul1u instructions

2017-02-01 Thread Tony Gutierrez
__uint128_t, which is supported by gcc and clang to simplify the code and get correct results. Diffs - src/arch/x86/isa/microops/regop.isa ed89cb178ecd7586296d2a2e83595174474db554 Diff: http://reviews.gem5.org/r/3800/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3791: dev: net/i8254xGBe add two more wakeup registers to ignore

2017-01-25 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3791/#review9319 --- Ship it! Ship It! - Tony Gutierrez On Jan. 25, 2017, 3:28 a.m

Re: [gem5-dev] Review Request 3757: arch: added generic vector register

2017-01-24 Thread Tony Gutierrez
> On Jan. 20, 2017, 9:11 a.m., Tony Gutierrez wrote: > > LGTM, nice implementation. I just have an ask for a few more comments. > > > > 1) A high-level description of the API, and some direction on usage for > > this library would be useful as a top-level comment i

Re: [gem5-dev] Review Request 3790: x86: fixed branching computation for branch uops that only changes nupc and not npc

2017-01-23 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3790/#review9293 --- Ship it! Ship It! - Tony Gutierrez On Jan. 23, 2017, 7:39 a.m

Re: [gem5-dev] Review Request 3757: arch: added generic vector register

2017-01-20 Thread Tony Gutierrez
views such that the primitive data types are accessed and normal operators used? Or should operators be overloaded here? - Tony Gutierrez On Jan. 16, 2017, 3:54 a.m., Rekai Gonzalez Alberquilla wrote: > > --- > This is an auto

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

2017-01-19 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3676/#review9280 --- Ship it! Ship It! - Tony Gutierrez On Nov. 16, 2016, 9:59 a.m

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-19 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9279 --- Ship it! Ship It! - Tony Gutierrez On Jan. 19, 2017, 10:28 a.m

Re: [gem5-dev] Review Request 3677: syscall_emul: [patch 11/22] extend functionality of fcntl

2017-01-19 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3677/#review9275 --- Ship it! Ship It! - Tony Gutierrez On Jan. 19, 2017, 8:05 a.m

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-19 Thread Tony Gutierrez
d the inclusion of any system headers? - Tony Gutierrez On Jan. 19, 2017, 9:30 a.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://review

[gem5-dev] changeset in gem5: ruby: guard usage of GPUCoalescer code in Pro...

2017-01-19 Thread Tony Gutierrez
changeset e034a4566653 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=e034a4566653 description: ruby: guard usage of GPUCoalescer code in Profiler the GPUCoalescer code is used in the ruby profiler regardless of whether or not the coalescer code has b

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

2017-01-18 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/#review9271 --- Ship it! Ship It! - Tony Gutierrez On Oct. 17, 2016, 8:14 a.m

Re: [gem5-dev] Review Request 3784: sim,kvm,arm: fix typos

2017-01-18 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3784/#review9270 --- Ship it! Ship It! - Tony Gutierrez On Jan. 17, 2017, 2:04 p.m

Re: [gem5-dev] Review Request 2691: mem: implement x86 locked accesses in timing-mode classic cache

2017-01-18 Thread Tony Gutierrez
> On Jan. 5, 2017, 8:32 a.m., Tony Gutierrez wrote: > > Is there anything holding this up from being shipped? > > Andreas Hansson wrote: > In my view the patch needs two things: > > 1) Some thought around the design. I am still hoping there is a

Re: [gem5-dev] Review Request 2691: mem: implement x86 locked accesses in timing-mode classic cache

2017-01-16 Thread Tony Gutierrez
> On Jan. 5, 2017, 8:32 a.m., Tony Gutierrez wrote: > > Is there anything holding this up from being shipped? > > Andreas Hansson wrote: > In my view the patch needs two things: > > 1) Some thought around the design. I am still hoping there is a

Re: [gem5-dev] Review Request 2691: mem: implement x86 locked accesses in timing-mode classic cache

2017-01-05 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2691/#review9228 --- Is there anything holding this up from being shipped? - Tony Gutierrez

[gem5-dev] Review Request 3771: ruby: guard usage of GPUCoalescer code in Profiler

2016-12-20 Thread Tony Gutierrez
GPUCoalescer code. eventually we should refactor this code to use probe points. Diffs - SConstruct dccdf4e12a0b5814b5e5ed9c7ddf2d272aedc13c src/mem/ruby/profiler/Profiler.cc dccdf4e12a0b5814b5e5ed9c7ddf2d272aedc13c Diff: http://reviews.gem5.org/r/3771/diff/ Testing --- Thanks, Tony

[gem5-dev] changeset in gem5: ruby: fix typo in DMASequencer::ackCallback()

2016-12-20 Thread Tony Gutierrez
changeset dccdf4e12a0b in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=dccdf4e12a0b description: ruby: fix typo in DMASequencer::ackCallback() diffstat: src/mem/ruby/system/DMASequencer.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (12 lines):

[gem5-dev] changeset in gem5: ruby: fix issue with unused var in DMASequencer

2016-12-20 Thread Tony Gutierrez
changeset ca38721228f3 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=ca38721228f3 description: ruby: fix issue with unused var in DMASequencer the iterator declared in DMASequencer::ackCallback() is only used in an assert, this causes clang to fail w

Re: [gem5-dev] Review Request 3708: commit 752c67b134f4cb0b7ca68a907c39a5a482de30b3

2016-12-08 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3708/#review9189 --- Ship it! Ship It! - Tony Gutierrez On Nov. 17, 2016, 12:02 p.m

Re: [gem5-dev] Review Request 3718: syscall_emul: extend sysinfo system call to include mem_unit

2016-12-04 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3718/#review9183 --- Ship it! Ship It! - Tony Gutierrez On Nov. 17, 2016, 12:27 p.m

[gem5-dev] changeset in gem5: hsail: fix unsigned offset bug in address cal...

2016-12-02 Thread Tony Gutierrez
changeset 96c81efdd3be in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=96c81efdd3be description: hsail: fix unsigned offset bug in address calculation it's possible for the offset provided to an HSAIL mem inst to be a negative value, however the varia

[gem5-dev] changeset in gem5: gpu-compute: fix segfault when constructing G...

2016-11-21 Thread Tony Gutierrez
changeset 511b47e9b9bc in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=511b47e9b9bc description: gpu-compute: fix segfault when constructing GPUExecContext the GPUExecContext context currently stores a reference to its parent WF's GPUISA object, howev

[gem5-dev] changeset in gem5: gpu-compute: init valid field of GpuTlbEntry ...

2016-11-21 Thread Tony Gutierrez
changeset 499071baed7b in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=499071baed7b description: gpu-compute: init valid field of GpuTlbEntry in default ctor valid field for GpuTlbEntry is not set in the default ctor, which can lead to strange behavior

[gem5-dev] changeset in gem5: ruby: add default ctor for MachineID type

2016-11-21 Thread Tony Gutierrez
changeset 70052ef97ce1 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=70052ef97ce1 description: ruby: add default ctor for MachineID type not all uses of MachineID initialize its fields, so here we add a default ctor. diffstat: src/mem/ruby/common

[gem5-dev] changeset in gem5: x86: fix issue with casting in Cvtf2i

2016-11-21 Thread Tony Gutierrez
changeset 8565c34ec32e in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=8565c34ec32e description: x86: fix issue with casting in Cvtf2i UBSAN flags this operation because it detects that arg is being cast directly to an unsigned type, argBits. this pat

Re: [gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.

2016-11-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/#review9144 --- Ship it! Ship It! - Tony Gutierrez On Nov. 21, 2016, 2:32 p.m

Re: [gem5-dev] Review Request 3721: x86: fix issue with casting in Cvtf2i

2016-11-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3721/#review9139 --- Thoughts? I would like to ship this today. - Tony Gutierrez On Nov

Re: [gem5-dev] Review Request 3692: gpu-compute: fix segfault when constructing GPUExecContext

2016-11-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3692/#review9138 --- Any other thoughts? Plan on shipping this today. - Tony Gutierrez On

[gem5-dev] Review Request 3741: ruby: add default ctor for MachineID type

2016-11-21 Thread Tony Gutierrez
/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3738: Ruby: Initialize MessageSizeType of SequencerMsg to Request_Control

2016-11-21 Thread Tony Gutierrez
this request. - Tony Gutierrez On Nov. 18, 2016, 2:20 p.m., Sooraj Puthoor wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3739: gpu-compute: init valid field of GpuTlbEntry in default ctor

2016-11-21 Thread Tony Gutierrez
/gpu-compute/gpu_tlb.hh 9e5050028323260c6d2211d7158ac4a4145ed8bc Diff: http://reviews.gem5.org/r/3739/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3739: gpu-compute: init valid field of GpuTlbEntry in default ctor

2016-11-21 Thread Tony Gutierrez
9e5050028323260c6d2211d7158ac4a4145ed8bc Diff: http://reviews.gem5.org/r/3739/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3693: riscv: [Patch 7/5] Corrected LRSC semantics

2016-11-21 Thread Tony Gutierrez
Roelke wrote: > I see. It sounds like fixing it would require making changes to the O3 > model itself, is that right? Are there changes I can make within the scope > of this patch, or others in the series, that will make it work? This may > actually explain other errors I'm

[gem5-dev] changeset in gem5: x86: fix loading/storing of Float80 types

2016-11-19 Thread Tony Gutierrez
changeset f7e79ee7fb4c in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=f7e79ee7fb4c description: x86: fix loading/storing of Float80 types diffstat: src/arch/x86/utility.cc | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diffs (26 lines): diff -

Re: [gem5-dev] Review Request 3738: Ruby: Initialize MessageSizeType of SequencerMsg to Request_Control

2016-11-18 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3738/#review9125 --- Ship it! - Tony Gutierrez On Nov. 18, 2016, 2:20 p.m., Sooraj Puthoor

Re: [gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

2016-11-18 Thread Tony Gutierrez
- Tony --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3690/#review9122 --- On Nov. 15, 2016, 11:52 a.m., Tony Gutier

[gem5-dev] Review Request 3721: x86: fix issue with casting in Cvtf2i

2016-11-17 Thread Tony Gutierrez
signed int into argBits. Diffs - src/arch/x86/isa/microops/mediaop.isa c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3721/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org

Re: [gem5-dev] Review Request 3715: hsail: add popcount type and generate popcount instructions

2016-11-17 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3715/#review9110 --- Ship it! Ship It! - Tony Gutierrez On Nov. 17, 2016, 12:28 p.m

Re: [gem5-dev] Review Request 3712: hsail: remove the panic guarding function directives

2016-11-17 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3712/#review9113 --- Ship it! Ship It! - Tony Gutierrez On Nov. 17, 2016, 12:25 p.m

Re: [gem5-dev] Review Request 3717: hsail: disable asserts to allow immediate operands i.e. 0 with loads

2016-11-17 Thread Tony Gutierrez
ttp://reviews.gem5.org/r/3717/#comment7854> remove the assert as opposed to commenting it out - Tony Gutierrez On Nov. 17, 2016, 12:27 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply

Re: [gem5-dev] Review Request 3716: hsail: add stub type and stub out several instructions

2016-11-17 Thread Tony Gutierrez
this - otherwise it looks good. src/arch/hsail/insts/decl.hh (line 762) <http://reviews.gem5.org/r/3716/#comment7853> These should all be marked as override, correct? - Tony Gutierrez On Nov. 17, 2016, 12:28 p.m., Brandon P

Re: [gem5-dev] Review Request 3714: hsail: add a wavesize case statement to register operand code

2016-11-17 Thread Tony Gutierrez
230) <http://reviews.gem5.org/r/3714/#comment7852> can you directly initialize reg_kind to BRIG_REGISTER_KIND_DOUBLE? - Tony Gutierrez On Nov. 17, 2016, 12:28 p.m., Brandon Potter wrote: > > --- > This is an automatica

Re: [gem5-dev] Review Request 3713: hsail: generate mov instructions for more arith_types and bit_types

2016-11-17 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3713/#review9108 --- Ship it! Ship It! - Tony Gutierrez On Nov. 17, 2016, 12:28 p.m

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

2016-11-16 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3688/#review9096 --- Ship it! Ship It! - Tony Gutierrez On Oct. 27, 2016, 12:45 a.m

Re: [gem5-dev] Review Request 3705: dev: Fix buffer length when unserializing an eth pkt

2016-11-16 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3705/#review9091 --- Ship it! Ship It! - Tony Gutierrez On Nov. 15, 2016, 1:22 p.m

Re: [gem5-dev] Review Request 3706: style: local variable name correction

2016-11-16 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3706/#review9085 --- Ship it! Ship It! - Tony Gutierrez On Nov. 16, 2016, 8:24 a.m

Re: [gem5-dev] Review Request 3707: syscall_emul: return -errno on a failed close call

2016-11-16 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3707/#review9084 --- Ship it! Ship It! - Tony Gutierrez On Nov. 16, 2016, 8:25 a.m

Re: [gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

2016-11-15 Thread Tony Gutierrez
to fputils have been pulled into gem5. - Tony --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3690/#review9075 --- On Nov. 15, 2016,

Re: [gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

2016-11-15 Thread Tony Gutierrez
http://reviews.gem5.org/r/3690/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

2016-11-15 Thread Tony Gutierrez
ext/fputils/fpbits.h c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 ext/fputils/include/fputils/fptypes.h c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 src/arch/x86/isa/microops/fpop.isa c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3690/diff/ Testing --- Thanks,

Re: [gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

2016-11-15 Thread Tony Gutierrez
Are you asking me to not push this into gem5 though? - Tony --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3690/#review9072 ---

Re: [gem5-dev] Review Request 3704: style: change NULL to nullptr in syscall files

2016-11-14 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3704/#review9068 --- Ship it! Ship It! - Tony Gutierrez On Nov. 14, 2016, 1:02 p.m

Re: [gem5-dev] Review Request 3680: syscall_emul: [patch 13/22] add system call retry capability

2016-11-14 Thread Tony Gutierrez
ocess waits. 2) Do you have any feeling for how this will affect apps that poll on some of the syscalls? E.g., if the syscall would have returned EAGAIN (or similar) will this no longer be exposed to the calling app? - Tony Gutierrez On Nov. 7, 2016, 3:20 p.m., Brandon Potter

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

2016-11-14 Thread Tony Gutierrez
On Nov. 10, 2016, 2:52 p.m., Brandon Potter wrote: > > Minor issue, otherwise it LGTM, assuming you address Jason's comments as > > well. > > Brandon Potter wrote: > I'm going to create a separate patch that does this after all of my other > patches are applied. I don't want to have to go

Re: [gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

2016-11-14 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3690/#review9050 --- Any thoughts? Otherwise I'll ship this soon. - Tony Gutierrez O

Re: [gem5-dev] Review Request 3657: configs: add an option to set the deadlock timeouts for the TCPs and SQCs

2016-11-14 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3657/#review9049 --- Ship it! Ship It! - Tony Gutierrez On Nov. 11, 2016, 1:33 p.m., Joe

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

2016-11-14 Thread Tony Gutierrez
comment on this. - Tony Gutierrez On Oct. 27, 2016, 12:45 a.m., Andreas Hansson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://

Re: [gem5-dev] Review Request 3699: syscall_emul: [PATCH 18/22] refactor and add functionality for dup, dup2, and pipe

2016-11-10 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3699/#review9042 --- Ship it! Ship It! - Tony Gutierrez On Nov. 7, 2016, 2:09 p.m

Re: [gem5-dev] Review Request 3701: syscall_emul: [PATCH 20/22] add the tgkill system call

2016-11-10 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3701/#review9039 --- Ship it! Ship It! - Tony Gutierrez On Nov. 7, 2016, 2:10 p.m

Re: [gem5-dev] Review Request 3700: syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

2016-11-10 Thread Tony Gutierrez
700/#comment7779> Not the correct license. - Tony Gutierrez On Nov. 7, 2016, 2:09 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://revie

Re: [gem5-dev] Review Request 3697: style: [PATCH 16/22] correct some style issues

2016-11-10 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3697/#review9037 --- Ship it! Ship It! - Tony Gutierrez On Nov. 7, 2016, 2:05 p.m

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-10 Thread Tony Gutierrez
02/#comment> Newline after the return type. src/sim/se_signal.cc (line 2) <http://reviews.gem5.org/r/3702/#comment7778> Should this not be 2014, 2016? - Tony Gutierrez On Nov. 7, 2016, 2:20 p.m., Brandon Potter wrote: > > --

Re: [gem5-dev] Review Request 3703: syscall_emul: [PATCH 22/22] ignore system calls that are unimplemented.

2016-11-10 Thread Tony Gutierrez
explaining why you're targetting only these sys calls in particular? - Tony Gutierrez On Nov. 7, 2016, 2:57 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://review

Re: [gem5-dev] Review Request 3698: syscall_emul: [PATCH 17/22] refactor and add functionality to open syscall family

2016-11-10 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3698/#review9034 --- Ship it! Ship It! - Tony Gutierrez On Nov. 7, 2016, 2:07 p.m

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

2016-11-10 Thread Tony Gutierrez
g/r/3681/#comment7774> Use nullptr throughout. Minor issue, otherwise it LGTM, assuming you address Jason's comments as well. - Tony Gutierrez On Nov. 7, 2016, 1:56 p.m., Brandon Potter wrote: > > --- > This

Re: [gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

2016-11-10 Thread Tony Gutierrez
an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3690/#review9029 --- On Nov. 1, 2016, 12:36 p.m., Tony Gutierrez wrote: > > --- > This is an aut

Re: [gem5-dev] Review Request 3693: riscv: [Patch 7/5] Corrected LRSC semantics

2016-11-10 Thread Tony Gutierrez
> On Nov. 2, 2016, 12:38 p.m., Alec Roelke wrote: > > This doesn't work with the O3 CPU model; I wrote a simple program that > > performs a lr.w followed by sc.w that works with the atomic-simple, > > timing-simple, and minor CPU models, but with the O3 model I get this error: > > > > gem5.deb

Re: [gem5-dev] Review Request 3693: riscv: [Patch 7/5] Corrected LRSC semantics

2016-11-10 Thread Tony Gutierrez
gem5.org/r/3693/#comment7773> Should you be using cacheBlockMask here, as opposed to 0xF? - Tony Gutierrez On Nov. 2, 2016, 12:34 p.m., Alec Roelke wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: [gem5-dev] Review Request 3692: gpu-compute: fix segfault when constructing GPUExecContext

2016-11-01 Thread Tony Gutierrez
hat it may be set to null. Diffs (updated) - src/gpu-compute/gpu_exec_context.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 src/gpu-compute/gpu_exec_context.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3692/diff/ Testing --- Thanks, Tony

[gem5-dev] Review Request 3692: gpu-compute: fix segfault when constructing GPUExecContext

2016-11-01 Thread Tony Gutierrez
src/gpu-compute/gpu_exec_context.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 src/gpu-compute/gpu_exec_context.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3692/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-d

Re: [gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

2016-11-01 Thread Tony Gutierrez
2e2f4 src/arch/x86/utility.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3690/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3630: riscv: [Patch 5/5] Added missing support for timing CPU models

2016-11-01 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3630/#review9018 --- Ship it! Ship It! - Tony Gutierrez On Oct. 21, 2016, 11:32 a.m

Re: [gem5-dev] Review Request 3629: riscv: [Patch 4/5] Added RISC-V atomic memory extension RV64A

2016-11-01 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3629/#review9017 --- Ship it! Ship It! - Tony Gutierrez On Oct. 31, 2016, 6:33 p.m., Alec

Re: [gem5-dev] Review Request 3668: riscv: [Patch 6/5] Improve Linux emulation for RISC-V

2016-11-01 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3668/#review9016 --- Ship it! Ship It! - Tony Gutierrez On Oct. 21, 2016, 11:33 a.m

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-11-01 Thread Tony Gutierrez
> On Oct. 31, 2016, 4:33 p.m., Tony Gutierrez wrote: > > src/arch/riscv/faults.hh, line 51 > > <http://reviews.gem5.org/r/3624/diff/11/?file=61979#file61979line51> > > > > Are these duplicate values right? > > Alec Roelke wrote: > Yes. RIS

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-11-01 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3624/#review9015 --- Ship it! Ship It! - Tony Gutierrez On Oct. 31, 2016, 6:29 p.m., Alec

Re: [gem5-dev] Review Request 3691: hsail: fix unsigned offset bug in address calculation

2016-11-01 Thread Tony Gutierrez
ews.gem5.org/r/3691/#review9009 --- On Oct. 31, 2016, 4:13 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [gem5-dev] Review Request 3627: riscv: [Patch 2/5] Added RISC-V multiply extension RV64M

2016-10-31 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3627/#review9007 --- Ship it! Ship It! - Tony Gutierrez On Sept. 29, 2016, 11:59 a.m

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-31 Thread Tony Gutierrez
gem5.org/r/3624/#comment7763> Public/private should be indented 2 spaces. Fix throughout. - Tony Gutierrez On Oct. 21, 2016, 11:12 a.m., Alec Roelke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

[gem5-dev] Review Request 3691: hsail: fix unsigned offset bug in address calculation

2016-10-31 Thread Tony Gutierrez
alues when the offset is negative, which will almost certainly cause the access to go out of bounds. Diffs - src/arch/hsail/operand.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 Diff: http://reviews.gem5.org/r/3691/diff/ Testing --- Thanks, Tony Guti

Re: [gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

2016-10-28 Thread Tony Gutierrez
) the bits[] of fp80_t to the mem allocated by the caller. Diffs - ext/fputils/include/fputils/fptypes.h b29aca3fcb75f5ad92429001ab11c65b2f9635b0 src/arch/x86/utility.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 Diff: http://reviews.gem5.org/r/3690/diff/ Testing --- Thanks,

Re: [gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

2016-10-28 Thread Tony Gutierrez
hanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3690: x86, ext: fix buf overflow in fp80 ops; pad fp80_t in fputils

2016-10-28 Thread Tony Gutierrez
aller. Diffs - ext/fputils/include/fputils/fptypes.h b29aca3fcb75f5ad92429001ab11c65b2f9635b0 src/arch/x86/utility.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 Diff: http://reviews.gem5.org/r/3690/diff/ Testing --- Thanks, Tony Guti

  1   2   3   4   5   >