[gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/ --- Review request for Default. Repository: gem5 Description --- Changeset 11186

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/#review7429 --- src/mem/request.hh (line 89)

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/#review7592 --- Why are you changing the numerical values of existing flags? Doing that w

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/ --- (Updated Nov. 19, 2015, 1:07 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

> On Oct. 30, 2015, 3:38 p.m., Andreas Hansson wrote: > > src/mem/request.hh, line 664 > > > > > > No command has both set. Seems odd to check... There are HSAIL instructions that have acq/rel semantics, although they aren'

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

> On Oct. 30, 2015, 3:38 p.m., Andreas Hansson wrote: > > src/mem/request.hh, line 667 > > > > > > This seems strange to me. We rely on the flags being fixed. I don't see > > why you would want to change such a fundamental

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/ --- (Updated Nov. 19, 2015, 2:49 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/ --- (Updated Nov. 19, 2015, 2:50 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/#review7616 --- Ship it! Thanks! My concerns have been addressed, but please make sure t

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/#review7622 --- src/mem/request.hh (line 158)

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/ --- (Updated Nov. 20, 2015, 12:04 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

On Nov. 20, 2015, 5:33 a.m., Tony Gutierrez wrote: > > I am still not really understanding the request and the packet part. How > > are the two related (are they)? I have a patch to undo the packet ACQ/REL changes, and will post it soon. Honestly I think the original author of this patch may h

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/ --- (Updated Nov. 20, 2015, 1:52 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/#review7628 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 20, 2015, 9:52 p.m., Ton

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

On Nov. 20, 2015, 1:33 p.m., Tony Gutierrez wrote: > > I am still not really understanding the request and the packet part. How > > are the two related (are they)? > > Tony Gutierrez wrote: > I have a patch to undo the packet ACQ/REL changes, and will post it soon. > Honestly I think the o

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

On Nov. 20, 2015, 5:33 a.m., Tony Gutierrez wrote: > > I am still not really understanding the request and the packet part. How > > are the two related (are they)? > > Tony Gutierrez wrote: > I have a patch to undo the packet ACQ/REL changes, and will post it soon. > Honestly I think the o

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

On Nov. 20, 2015, 1:33 p.m., Tony Gutierrez wrote: > > I am still not really understanding the request and the packet part. How > > are the two related (are they)? > > Tony Gutierrez wrote: > I have a patch to undo the packet ACQ/REL changes, and will post it soon. > Honestly I think the o

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3180/#review7719 --- Andreas H., I want to make sure you're explicitly ok with me shipping thi