[gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3228/ --- Review request for Default. Repository: gem5 Description --- Distributed gem

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3228/#review7655 --- src/sim/pseudo_inst.cc (line 459)

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

> On Nov. 28, 2015, 11:58 p.m., Ali Saidi wrote: > > src/sim/pseudo_inst.cc, line 459 > > > > > > rather than magic values why not have initparam pass a string key and > > get value. That will mean less annoying issues in

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3228/ --- (Updated Dec. 9, 2015, 11:34 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3228/#review7794 --- Qre the dist_*.{cc,hh} files basically just renames (with internal symbol

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3228/ --- (Updated Jan. 7, 2016, 9:58 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

> On Dec. 31, 2015, 5:09 a.m., Steve Reinhardt wrote: > > Qre the dist_*.{cc,hh} files basically just renames (with internal symbol > > renames) of the equivalent multi_* files, or are there significant > > differences? Were they renamed with 'hg rename/mv'? > > > > I still haven't had time t

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3228/#review7830 --- Why was this patch committed? There are no ship-its, and there was no wa

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

> On Jan. 7, 2016, 11:14 p.m., Steve Reinhardt wrote: > > Why was this patch committed? There are no ship-its, and there was no > > warning. I was complaining about minor things to buy myself a little time, > > and also because I hoped the changes between the similar files would be > > easie

Re: [gem5-dev] Review Request 3228: dist: Distributed Ethernet link support for distributed gem5 simulations

> On Jan. 7, 2016, 3:14 p.m., Steve Reinhardt wrote: > > Why was this patch committed? There are no ship-its, and there was no > > warning. I was complaining about minor things to buy myself a little time, > > and also because I hoped the changes between the similar files would be > > easier