Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

2010-07-30 Thread nathan binkert
> That's useful information... most of my motivation for iterChildren() > was to be consistent with other python methods like iteritems(), > iterkeys(), etc., so if that's going away then I'm less motivated to > stick with it.  I haven't played with python3 so I didn't know that. > See, I told you

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

2010-07-30 Thread Steve Reinhardt
That's useful information... most of my motivation for iterChildren() was to be consistent with other python methods like iteritems(), iterkeys(), etc., so if that's going away then I'm less motivated to stick with it. I haven't played with python3 so I didn't know that. See, I told you that you w

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

2010-07-30 Thread nathan binkert
By the way, I don't hate iterChildren(). I just agree with the python guys who don't feel that the word iter is necessary. (In python3, iteritems doesn't exist anymore, it's just called items). Nate On Fri, Jul 30, 2010 at 10:45 PM, nathan binkert wrote: >> I tried unproxying without sorting

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

2010-07-30 Thread nathan binkert
> I tried unproxying without sorting and the regressions passed, so it looks > like you were right that it's unnecessary.  I then got rid of > iterSortedChildren() and replaced the one remaining use with >  for obj in sorted(root.iterChildren(), key=lambda o: o.path()): >      obj.print_ini(ini_f

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

2010-07-30 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/27/#review132 --- I tried unproxying without sorting and the regressions passed, so it looks

Re: [m5-dev] Review Request: exitGroupFunc syscall patch

2010-07-30 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/73/#review131 --- You need a space after "for" and "if" (see http://m5sim.org/wiki/index.php

[m5-dev] Cron /z/m5/regression/do-regression quick

2010-07-30 Thread Cron Daemon
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/inorder-timing passed. * build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-atomic passed. * build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-timing-ruby passed. * build/ALPHA_SE/tests/fast/quick/00.hello/a