Hi,
The vote to release Apache ShenYu (incubating) 2.4.0 has passed with
6 +1 binding and 1 +1 non-binding votes, no +0 or -1 votes.
Binding votes:
Justin Mclean
Duo Zhang
Kevin Ratnasekera
Willem Jiang
Jean-Baptiste Onofré
Atri Sharma
Non-Binding votes:
Xun Liu
Vote thread:
+1 (binding)
checked:
- incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are good
- All source files have ASF headers
-
On Thu, 5 Aug 2021, 20:51 Kevin Ratnasekera,
wrote:
> +1 ( binding )
>
> I checked the following.
>
> - Incubating in name.
>
> - PGP Signatures.
>
> - SHA512
+1 (binding)
I quickly checked:
- LICENSE and NOTICE files are there and look good
- DISCLAIMER is there
- ASF headers
- Build is OK
Regards
JB
On 06/08/2021 11:45, Willem Jiang wrote:
+1 binding.
I checked :
The Git tag is right for me.
There are no binary files in the Source release kit.
I
+1 binding.
I checked :
The Git tag is right for me.
There are no binary files in the Source release kit.
I can build the code from source.
License and NOTICE files look good to me.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Wed, Aug 4, 2021 at 10:59 AM Zhang Yonglun wrote:
>
>
+1 ( binding )
I checked the following.
- Incubating in name.
- PGP Signatures.
- SHA512 Checksums.
- DISCLAIMER exists.
- LICENSE and NOTICE are fine.
- Maven Build passes on MacOS.
Regards
Kevin
On Thu, Aug 5, 2021 at 6:26 PM 张铎(Duo Zhang) wrote:
> +1 (binding)
>
> Checked sigs and
+1 (binding)
Checked sigs and sums: Matched
DISCLAIMER: In place
LICENSE and NOTICE: In place
Built from source(jdk-11.0.11): 'mvn clean install -DskipTests', passed
Rat check: Passed
Xun Liu 于2021年8月5日周四 上午9:46写道：
>
> +1 (non-binding) from me, I have checked the following items:
>
> -
+1 (non-binding) from me, I have checked the following items:
- Incubating in name
- LICENSE and NOTICE is fine
- DISCLAIMER exists
- All links are valid
- No unexpected binary files
- All ASF files have ASF headers
- Checksums and PGP signatures are valid.
- No compiled archives bundled in
Hi,
+1 (binding)
I checked:
- incubating in name
- signatures and hashes are fine
- DISCLAIMER exists
- LICENSE and NOTICE are good
- All source files have ASF headers
- No unexpected binary files
- Can compile from source
Thanks,
Justin
If you start another round of releases, please cancel the vote first.
it could be better to use rc2 name to specify the release candidate to
avoid this situation.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Mon, Aug 2, 2021 at 4:03 PM Zhang Yonglun wrote:
>
> This vote thread is
Hi,
It’s recommend that (P)PMC members write down what they check when voting, but
you will see some variation from project to project on this and some TLP don’t
do this at all. It also recommended that you encourage your mentors to vote and
get mentor votes on your releases, but it’s not a
Hi Sheng,
> If there is nothing checked by them, it is hard to say they could be
> counted as a binding(PPMC level) vote.
I would be glad to change the result from 12 +1 votes to 6 +1 votes if the
rest 6 votes are invalid.
Before that, I'd like to make sure whether the rest 6 votes are invalid
Inline
Zhang Yonglun 于2021年8月4日周三 上午11:38写道：
>
> Hi Sheng,
>
> Thanks for your comments.
>
> > all the incubating process is about letting the
> > PPMC having enough knowledge and practices to check the release,
> > making sure it follows the policies.
>
> I agree with you. I have talked with
Hi Sheng,
Thanks for your comments.
> all the incubating process is about letting the
> PPMC having enough knowledge and practices to check the release,
> making sure it follows the policies.
I agree with you. I have talked with all PPMC members and let them check
all items in the list before
Hi
I just reviewed your vote,
https://lists.apache.org/thread.html/r2c48a513573f6031d38ad669d6c5e2784ff43964f4cbd75b00ea1205%40%3Cdev.shenyu.apache.org%3E
There are only 3-4 PPMC members showing what they checked, others are
only having a simple +1, but from the vote result, there are 12 PPMC
Hello Incubator Community,
This is a call for vote to release Apache ShenYu (incubating) version 2.4.0.
The Apache ShenYu community has voted on and approved a proposal to release
Apache ShenYu (incubating) version 2.4.0.
We now kindly request the Incubator PMC members review and vote on this
I'm cancelling this vote because of license issues. I'll fix them and start
the round 2 vote process.
The detail of the modifications are as follows:
1. Remove the file ThreadLocalUtilTest.java
2. Removes the files be built from shenyu-dashboard
Thanks a lot for all your help.
--
Zhang Yonglun
This vote thread is canceled for some issues. I will start the 2nd round
vote later.
--
Zhang Yonglun
Apache ShenYu (Incubating)
Apache ShardingSphere
Zhang Yonglun 于2021年7月27日周二 上午10:57写道：
> Hello Incubator Community,
>
> This is a call for vote to release Apache ShenYu (incubating) version
Hi Zhenxu,
> If you think the release candidate is not good enough or need some fixes,
please cancel the voting thread as soon as possible
> instead of changing it silently when the voting thread is still open, so
that people don’t waste time in voting a changing candidate.
Sorry for that. We
Hi, -1 (binding)
1. the commit ID claimed in this thread doesn’t match the release tag v2.4.0
(https://github.com/apache/incubator-shenyu/commit/dc841a2720ea0b5a6ca71f1b9c1aa7958d241f16).
> Release Commit ID:
>
I tried to run rat (version 0.9, 0.10, 0.11, 0.12, 0.13) via the command
line:
java -jar apache-rat-0.13.jar -d shenyu-admin
All the results are:
AL./src/test/java/org/apache/shenyu/admin/utils/ThreadLocalUtilTest.java
The results marked ThreadLocalUtilTest.java AL(Apache License headers),
Hi,
> This file contains some very simple test cases, we assume that they are not
> from another project, but just added a wrong license header. We are trying
> to contact the contributor who contribute this file to make things clear.
> Before he/she respond, we'd like to remove this file to
Hi Justin,
Thanks for your help.
> This file [1] has an incorrect header and may be from another project.
Where sis this code come from?
This file contains some very simple test cases, we assume that they are not
from another project, but just added a wrong license header. We are trying
to
Hi,
Look like I hit send too soon there:
"Sorry but it -1 binding form me. LICENSE is missing 3rd party license
information”
Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional
HI,
Sorry but it -1 binding form me. LICENSE is missing 3rd
I checked:
- incubating in name
- DISCLAIMER exists
- LICENSE is missing some licenses
- NOTICE is OK
- No unexpected binary files
- source files have ASF headers
This file [1] has an incorrect header and may be from another project.
+1 (non-binding) from me, I have checked the following items:
- Incubating in name
- LICENSE and NOTICE is fine
- DISCLAIMER exists
- All links are valid
- No unexpected binary files
- All ASF files have ASF headers
- Checksums and PGP signatures are valid.
- No compiled archives bundled in
Hi Sheng,
Thanks for pointing out this problem.
The escape character in the test class is not compatible with OpenJDK 11.
We plan to support JAVA 11 in the next release.
Please try to build with JAVA 8, and I'll update the release doc to specify
the JAVA version.
--
Zhang Yonglun
Apache ShenYu
Hi
I can't find the compiling doc in the mail, but when I run compiling using
OpenJDK11, it fails
```
Expected: a string containing "Extension instance(name: canNotInstantiated,
class: class org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI) could
not be instantiated: Class
+1 (binding)
Just forward my vote in the PPMC here.
There is incubating in the release kits' name.
The maven stage repo looks good.
No compiled archives bundled in source archive
The LICENSE and NOTICE files are OK for me.
There is a DISCLAIMER file in the release kits.
I can build the kit from
+1(binding)
Checked sigs and sums: Matched
NOTICE and LICENSE: In place
DISCLAIMER: In Place
Built from src: 'mvn clean install -DskipTests' passed
Rat check: Passed
Zhang Yonglun 于2021年7月27日周二 上午10:57写道：
>
> Hello Incubator Community,
>
> This is a call for vote to release Apache ShenYu
Hello Incubator Community,
This is a call for vote to release Apache ShenYu (incubating) version 2.4.0.
The Apache ShenYu community has voted on and approved a proposal to release
Apache ShenYu (incubating) version 2.4.0.
We now kindly request the Incubator PMC members review and vote on this
30 matches
Mail list logo
