[VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-08 Thread ???? Sheng Wu
Hi All, This is a call for vote to release Apache SkyWalking (Incubating) version 5.0.0-RC2. The Apache SkyWalking community has tested, voted and approved the proposed release of Apache SkyWalking (Incubating) 5.0.0-RC2 We now kindly request the Incubator PMC members review and vote on this i

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-08 Thread Justin Mclean
Hi, Sorry but I still cannot vote +1 own this as the README.md still points to https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-build.md for build instructions which gives a 404, please include the instructions on how the build the source in the release in the README.md

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-08 Thread ???? Sheng Wu
SkyWalking From Wu Sheng 's phone. -- Original -- From: Justin Mclean Date: Sun,Sep 9,2018 6:50 AM To: general Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2 Hi, Sorry but I still cannot vote +1 own this as the README.md still p

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-08 Thread Ignasi Barrera
lking > > From Wu Sheng 's phone. > > > ------ Original ---------- > From: Justin Mclean > Date: Sun,Sep 9,2018 6:50 AM > To: general > Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version > 5.0.0-RC2 > > > >

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-08 Thread Justin Mclean
Hi, > Check our two major code branches, > - master https://github.com/apache/incubator-skywalking In which README no longer contains any build instruction or direct pointers to them. I don’t think this is an improvement. So now I need to stop looking at the terminal, open up a browser, goto Gi

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-08 Thread ???? Sheng Wu
n,Sep 9,2018 9:26 AM To: general Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2 Hi, > Check our two major code branches, > - master https://github.com/apache/incubator-skywalking In which README no longer contains any build instruction or direct pointers to

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-08 Thread Justin Mclean
Hi, I’m not involved in your project, and I may be mistaken, but it seems to me you might have a wider issue here. > Besides that, because many users are using git clone tag as sources too, > although in Apache, we consider our source tar only. But in the community, > they really use in anothe

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-08 Thread ???? Sheng Wu
Btw, they perfer GitHub because it is easier to pull request new plugin and bug fix. Sheng Wu Apache SkyWalking From Wu Sheng 's phone. -- Original -- From: Justin Mclean Date: Sun,Sep 9,2018 0:18 PM To: general Subject: Re: [VOTE] Release Apache SkyWalking

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-08 Thread Mick Semb Wever
> First of all, there is a direct link to that build page, in README of > master and 5.x branches. See > https://github.com/apache/incubator-skywalking#compiling-project > We have both links to document and compiling guide. This is excellent in my opinion. >From the terminal I can read the RE

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-09 Thread Justin Mclean
Hi, > Justin, given that the next release will provide this information so clearly > from the base directory, knowing that the next release will be in order, are > you ok with letting this release pass through? That is not up to me, that is up for other IPMC members to vote +1 on it. Thanks, J

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-09 Thread Ignasi Barrera
That's why I meant when I said finding the build instructions was trivial enough that I thought it should not block a release. The README contains a clear link to the Documentation (which is a link to a local file), and that file is a very comprehensive index with direct links to architecture, tes

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-11 Thread Ignasi Barrera
+1 * SHA 512 checksums are present and valid * Signatures are valid * The expanded source archive builds and passes tests * Expanded source archives match the contents of the RC tags * All LICENSE and NOTICE files are present and correct, including the MIT stuff detected in the previous IPMC vote

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-12 Thread Mick Semb Wever
> Voting will start now (2018/9/8 date) and will remain open for at least > 72 hours, Request IPMC to give their vote. > [ ] +1 Release this package. > [ ] +0 No opinion. > [ ] -1 Do not release this package because +1 Checked - sha512s ok - checked maven artefacts - source artefact bu

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-12 Thread ???? Sheng Wu
om: Mick Semb Wever Date: Wed,Sep 12,2018 6:33 PM To: general Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2 > Voting will start now (2018/9/8 date) and will remain open for at least > 72 hours, Request IPMC to give their vote. > [ ] +1 Release this packag

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-12 Thread Willem Jiang
+1 (Binding) 1. Checked signed key and sha512 of source and binary package of https://dist.apache.org/repos/dist/dev/incubator/skywalking 2. Source code build successfully 3. Checked the artifacts in the staging repository 4. LICENSE and NOTICE are OK in source code and distribution package 5. Apa

Re: [RESULT][VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2

2018-09-12 Thread Sheng Wu
Hi all, The vote for releasing Apache SkyWalking 5.0.0-RC2 (incubating) is closed, now. Vote result: 3 (+1 binding) (Ignasi, Mick and William) Thank you everyone for taking the time to review the release and help us. I will process to publish the release and send ANNOUNCE. Justin, Our 5.x b