Thanks for your review, this vote is closed.
Best,
Shaokang Lv
Huajie Wang 于2024年4月29日周一 18:17写道：
> Thanks for your review work with profound respect. we have always
> attached great importance to License compliance issues. We will close
> the current vote later and initiate a new round of
Thanks for your review work with profound respect. we have always
attached great importance to License compliance issues. We will close
the current vote later and initiate a new round of voting.
Best,
Huajie Wang
Justin Mclean 于2024年4月29日周一 17:52写道：
> Hi,
>
> > Thanks for your
Hi,
> Thanks for your clarification. We have submitted a PR[1] to address this
> issue. I believe this issue will be resolved quickly.
>
> [1] https://github.com/apache/incubator-streampark/pull/3689
That looks good to me, thanks.
Kind Regards,
Justin
Thanks for your clarification. We have submitted a PR[1] to address this
issue. I believe this issue will be resolved quickly.
[1] https://github.com/apache/incubator-streampark/pull/3689
Best,
Huajie Wang
tison 于2024年4月29日周一 16:02写道：
> > So a condition of including MIT licensed code is
> But I found a potential issue that it's possible StreamPark copied some
code from flink-sql-gateway to streampark-flink-sql-gateway.
Thanks for your review work, the "streampark-flink-sql-gateway" module is
in the dev branch and is currently in the development phase, As you said,
some of the
> Even if they have changed a lot, that could still be an issue. Copying an
earlier version of a file is still an issue that needs to be dealt with.
Even copying 5% of something needs to be treated correctly. The files seem
to have permissive licenses, so there is no category X licensing issue, at
Hi,
> * Some false positive on testing assertions utils. Match rate < 50%, file
> is small, and those utilities are trivial. Even when I go to the "origins",
> they are lost or changed a lot. Clearly not the same origin.
Even if they have changed a lot, that could still be an issue. Copying an
But I found a potential issue that it's possible StreamPark copied some
code from flink-sql-gateway to streampark-flink-sql-gateway.
If that's the case, we should convey this info in the LICENSE file. But
since Flink is also an ASF project, we don't need to convey another copy of
ALv2 and no need
> It looks like additional third-party code might also be in the release,
but it is difficult to tell.
Yeah. The result gives a lot of noise. I run SCANOSS locally, and don't
find any other third-party code included:
* Many of the reference to streamx is the original project before
StreamPark
> vue-vben-admin is under MIT[1] license, In the LICENST[2] file of
> StreamPark, we listed which files are copied from vue-vben-admin
The issue here is that, as MIT license writes:
> The above copyright notice and this permission notice shall be included
in all copies or substantial portions of
> So a condition of including MIT licensed code is to include the relevant
MIT license text. That seems to be missing for for vue-vben-admin , as I
can’t find it anywhere in the release
vue-vben-admin is under MIT[1] license, In the LICENST[2] file of
StreamPark, we listed which files are copied
Here is a draft that participants in this thread can review: [1]
[1] https://github.com/apache/incubator-streampark/pull/3689
Best,
tison.
tison 于2024年4月29日周一 16:01写道：
> > So a condition of including MIT licensed code is to include the
> relevant MIT license text.
>
> Confirmed this is the
> So a condition of including MIT licensed code is to include the relevant
MIT license text.
Confirmed this is the case.
I found the mention to vue-vben-admin is licensed under MIT at [1] but I
don't find the LICENSE of vue-vben-admin bundled also.
I agree that the LICENSE file at [2] seems to
Hi,
-1 (binding) from me
I checked:
- incubating in name
- signatures and hashes correct
- disclaimer exists
- LICENSE is missing some info on the MIT license
- NOTICE looks fine
- I didn't compile from source
So a condition of including MIT licensed code is to include the relevant MIT
license
> To verify the release here is supposed to verify the release candidate
stored at the Apache distribution, right?
Is it wrong to verify the code repo downloaded by git clone?
When we are releasing a new version, we will create a git tag for the
release. Here, "-b v2.1.4-rc1[1]" is to verify
hi Suyan,
Thank you for your careful review. The version by git clone is the same as
the apache release candidate. To avoid ambiguity, we'll add a comment to
the vote template later.
Best,
Shaokang Lv
Suyan 于2024年4月28日周日 21:20写道：
> +1 binding
> Apache ID: suyanhanx
>
> I checked:
>
> [x]
+1 binding
Apache ID: suyanhanx
I checked:
[x] Download links are valid.
[x] Checksums and signatures.
gpg: Signature made Mon Apr 22 00:02:13 2024 CST
gpg:using RSA key B0AD51795657CF5C303FE79B5CEB5ECFD38791FF
gpg: checking the trustdb
gpg: marginals needed: 3 completes needed:
+1 binding
Checked sigs and sums: Matched
NOTICE and LICENSE: Looks fine
DISCLAIMER: In place
Built from src: Passed with jdk11 by calling build.sh
Thanks.
Huajie Wang 于2024年4月27日周六 10:06写道：
>
> Carrying my non-binding +1 vote from the StreamPark community.
>
>
> Best,
> Huajie Wang
>
>
>
>
Carrying my non-binding +1 vote from the StreamPark community.
Best,
Huajie Wang
Huajie Wang 于2024年4月26日周五 00:27写道：
> hi tison:
>
> Thanks very much for your thorough checking work. You even found such a
> minor issue as the version number mismatch in the README.md file, We have
> created
hi tison:
Thanks very much for your thorough checking work. You even found such a
minor issue as the version number mismatch in the README.md file, We have
created an issues[1] to tracking DISCLAIMER and README.md issue
[1] https://github.com/apache/incubator-streampark/issues/3680
> This is
+1 binding with a few suggestions.
I checked:
* Download links valid.
* Signature and checksum match.
* LICENSE, NOTICE and DISCLAIMER are included in both source and binary
releases. The content looks good to me.
* No binary files in the source release
Below are two suggestions:
1. You may
Hello Incubator Community:
This is a call for a vote to release Apache StreamPark(Incubating) version
2.1.4-RC1.
The Apache StreamPark community has voted on and approved a proposal to
release Apache StreamPark(Incubating) version 2.1.4-RC1.
We now kindly request the Incubator PMC members review
22 matches
Mail list logo
