Re: [gentoo-portage-dev] Signing off patches

2014-01-21 Thread W. Trevor King
On Tue, Jan 21, 2014 at 07:41:21PM +0100, Tom Wijsman wrote: On Tue, 21 Jan 2014 09:20:04 -0800 W. Trevor King wrote: On Tue, Jan 21, 2014 at 05:59:54PM +0100, Tom Wijsman wrote: On Tue, 21 Jan 2014 08:51:14 -0800 W. Trevor King wrote: On Tue, Jan 21, 2014 at 04:40:19PM +0100, Tom

Re: [gentoo-portage-dev] Signing off patches

2014-01-21 Thread Tom Wijsman
On Tue, 21 Jan 2014 11:18:39 -0800 W. Trevor King wk...@tremily.us wrote: I'm all for recording suggested conventions in DEVELOPING, but I don't think it's worth the trouble to over-specify the conditions under which each tag should be used, or to lay out consequences for cases where they're

Re: [gentoo-portage-dev] Signing off patches

2014-01-21 Thread W. Trevor King
On Tue, Jan 21, 2014 at 08:22:31PM +0100, Tom Wijsman wrote: On Tue, 21 Jan 2014 11:18:39 -0800 W. Trevor King wrote: I'm all for recording suggested conventions in DEVELOPING, but I don't think it's worth the trouble to over-specify the conditions under which each tag should be used, or to

Re: [gentoo-portage-dev] Signing off patches

2014-01-19 Thread Mike Frysinger
On Saturday 18 January 2014 17:57:38 Tom Wijsman wrote: On Sat, 18 Jan 2014 08:43:12 -0800 W. Trevor King wrote: On Sat, Jan 18, 2014 at 04:02:02PM +0100, Tom Wijsman wrote: I think the idea is that you shouldn't need to refer to an external resource like the mailing list to understand the

Re: [gentoo-portage-dev] Signing off patches

2014-01-19 Thread Tom Wijsman
On Sat, 18 Jan 2014 20:15:57 -0800 W. Trevor King wk...@tremily.us wrote: On Sun, Jan 19, 2014 at 02:33:06AM +0100, Tom Wijsman wrote: On Sat, 18 Jan 2014 15:24:59 -0800 W. Trevor King wk...@tremily.us wrote: If it doesn't need to get updated, then it probably already started out

Re: [gentoo-portage-dev] Signing off patches

2014-01-19 Thread W. Trevor King
On Mon, Jan 20, 2014 at 03:09:14AM +0100, Tom Wijsman wrote: On Sat, 18 Jan 2014 20:15:57 -0800 W. Trevor King wrote: On Sun, Jan 19, 2014 at 02:33:06AM +0100, Tom Wijsman wrote: On Sat, 18 Jan 2014 15:24:59 -0800 W. Trevor King wrote: If it doesn't need to get updated, then it probably

Re: [gentoo-portage-dev] Signing off patches

2014-01-18 Thread Tom Wijsman
On Sat, 18 Jan 2014 08:43:12 -0800 W. Trevor King wk...@tremily.us wrote: On Sat, Jan 18, 2014 at 04:02:02PM +0100, Tom Wijsman wrote: I think the idea is that you shouldn't need to refer to an external resource like the mailing list to understand the idea behind the patch, Either someone

Re: [gentoo-portage-dev] Signing off patches

2014-01-18 Thread Tom Wijsman
On Sat, 18 Jan 2014 15:24:59 -0800 W. Trevor King wk...@tremily.us wrote: If it doesn't need to get updated, then it probably already started out explaining the consensus ;). That is a guess, you can look this up in past patches. You spend time if you want to spend time and add whoever you

Re: [gentoo-portage-dev] Signing off patches

2014-01-18 Thread W. Trevor King
On Sun, Jan 19, 2014 at 02:33:06AM +0100, Tom Wijsman wrote: On Sat, 18 Jan 2014 15:24:59 -0800 W. Trevor King wk...@tremily.us wrote: If it doesn't need to get updated, then it probably already started out explaining the consensus ;). That is a guess, you can look this up in past

[gentoo-portage-dev] Signing off patches

2014-01-16 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 We have quite a few dedicated developers now. To ensure that good taste is exercised, and that best practices are followed, patches should be signed. My proposals: Signed-off-by: Wrote (a substantial portion of) the patch Reviewed-by: Reviewed the

Re: [gentoo-portage-dev] Signing off patches

2014-01-16 Thread Alec Warner
On Thu, Jan 16, 2014 at 5:20 AM, Alexander Berntsen alexan...@plaimi.netwrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 We have quite a few dedicated developers now. To ensure that good taste is exercised, and that best practices are followed, patches should be signed. I'm

Re: [gentoo-portage-dev] Signing off patches

2014-01-16 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 16/01/14 17:45, W. Trevor King wrote: I love Signed-off-by, but in all projects where I've seen it used it means the signer is agreeing to some form of a Developer's Certificate of Origin [1]. Without such a DCO, I think the usual commit

Re: [gentoo-portage-dev] Signing off patches

2014-01-16 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 16/01/14 17:41, Alec Warner wrote: I'm confused, are you proposing all patches have all of these fields? Or we should simply cherry-pick the fields we think are useful? Nearly all patches should have Signed-off-by. The others are situational.

Re: [gentoo-portage-dev] Signing off patches

2014-01-16 Thread W. Trevor King
On Thu, Jan 16, 2014 at 06:05:50PM +0100, Alexander Berntsen wrote: On 16/01/14 17:45, W. Trevor King wrote: I love Signed-off-by, but in all projects where I've seen it used it means the signer is agreeing to some form of a Developer's Certificate of Origin [1]. Without such a DCO, I

Re: [gentoo-portage-dev] Signing off patches

2014-01-16 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 16/01/14 18:24, Jesus Rivero (Neurogeek) wrote: So, how would this work with emails to this list, exactly? An email should be sent any time one of those fields is changed? That's not necessary, in my opinion. We already send emails, looks OK to

Re: [gentoo-portage-dev] Signing off patches

2014-01-16 Thread Jesus Rivero (Neurogeek)
On Thu, Jan 16, 2014 at 12:44 PM, Alexander Berntsen alexan...@plaimi.netwrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 16/01/14 18:24, Jesus Rivero (Neurogeek) wrote: So, how would this work with emails to this list, exactly? An email should be sent any time one of those