Re: [Geotools-devel] geotools 8.0 jars in maven repo?

2012-08-31 Thread Michael Bedward
On 31 August 2012 16:47, Joachim Van der Auwera wrote: > They are not (at least that was the situation a couple of months ago). We > have staged many Geomajas artefacts through oss.sonatype.org which have > repository tags and references to dependencies (like GeoTools) which are not > in central.

Re: [Geotools-devel] [ExternalEmail] Voting for ComplexFeature Parsing and Building Support

2012-08-31 Thread Ben Caradoc-Davies
+1. Thanks, Adam. On 29/08/12 14:55, adam.br...@csiro.au wrote: > Hi all, > > I’d like to request a vote on getting my ComplexFeature parsing work > integrated in trunk. > > The change proposal is here: > http://docs.codehaus.org/display/GEOTOOLS/ComplexFeature+Parsing+and+Building+Support > > An

Re: [Geotools-devel] Voting for ComplexFeature Parsing and Building Support

2012-08-31 Thread Andrea Aime
On Wed, Aug 29, 2012 at 4:19 PM, Andrea Aime wrote: > On Wed, Aug 29, 2012 at 3:45 PM, David Winslow wrote: > >> >> https://github.com/Adam-Brown/geotools/compare/geotools:master...Adam-Brown:master > > > Heck, I did try that (following a github blog) and kept on getting a 404.. > I guess I must h

[Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Andrea Aime
Hi, I'm wondering if we have, anywhere in the dev guide, a tutorial on how to contribute a patch. Something like: - fork on github - make your changes - don't reformat the code, keep coding style consistent with what you're modifying - make sure the changes are covered - prepare a quick guide that

[Geotools-devel] osgeo repo webdav not working - release 8.1 blocked

2012-08-31 Thread Jody Garnett
Daniele has been a hero trying to get this one moving; I think it is upsetting the release of imageio-ext 1.1.5 as well? We are trundling slowly along through the following issue: - http://trac.osgeo.org/osgeo/ticket/993 The suggestion has come back to try alternate transport protocols? - ftp <

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Andrea Aime
On Fri, Aug 31, 2012 at 10:31 AM, Andrea Aime wrote: > Hi, > I'm wondering if we have, anywhere in the dev guide, a tutorial on how to > contribute a patch. > Jody on IRC pointed me at these: (10:34:14) jgarnett: http://docs.geotools.org/latest/developer/procedures/hack.html (10:35:05) jgarnett:

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Jody Garnett
I personally get in trouble with code formats all the time. I have this habit of hitting "Alt-Shift-F" before committing (taken from the uDig project). Justin has asked me to commit code formatting changes as a separate commit; but I have not been quite sure how this helps. -- Jody Garnett On

Re: [Geotools-devel] osgeo repo webdav not working - release 8.1 blocked

2012-08-31 Thread Jody Garnett
Just to confirm Daniele's experience, when trying to deploy GeoTools 8.0 "missing" modules I get the following: INFO: Already tried to authenticate with 'OSGeo Login' authentication realm at download.osgeo.org, but still receiving: HTTP/1.1 401 Authorization Required Uploading: http://download

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Ian Turton
On 31 August 2012 10:50, Jody Garnett wrote: > I personally get in trouble with code formats all the time. I have this > habit of hitting "Alt-Shift-F" before committing (taken from the uDig > project). Shouldn't eclipse "know" what our code style is when you hit alt-shift-f? I thought we had a f

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Andrea Aime
On Fri, Aug 31, 2012 at 11:54 AM, Ian Turton wrote: > On 31 August 2012 10:50, Jody Garnett wrote: > > I personally get in trouble with code formats all the time. I have this > > habit of hitting "Alt-Shift-F" before committing (taken from the uDig > > project). > > Shouldn't eclipse "know" what

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Jody Garnett
It does and we do. However we have several sections of the codebase that have been formatted by hand. As such when you blindly do "Alt-Shift-F" you introduce a lot of noise into your patch. Why does this matter? It basically screws anyone who is trying to apply the patch across different branch

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Andrea Aime
On Fri, Aug 31, 2012 at 11:50 AM, Jody Garnett wrote: > I personally get in trouble with code formats all the time. I have this > habit of hitting "Alt-Shift-F" before committing (taken from the uDig > project). > Justin has asked me to commit code formatting changes as a separate > commit; but I

Re: [Geotools-devel] osgeo repo webdav not working - release 8.1 blocked

2012-08-31 Thread Andrea Aime
On Fri, Aug 31, 2012 at 10:31 AM, Jody Garnett wrote: > Daniele has been a hero trying to get this one moving; I think it is > upsetting the release of imageio-ext 1.1.5 as well? > > We are trundling slowly along through the following issue: > - http://trac.osgeo.org/osgeo/ticket/993 > > The sugge

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Andrea Aime
On Fri, Aug 31, 2012 at 12:04 PM, Andrea Aime wrote: > It helps because it makes the patch reviewable. If you have a mix of > format and actual changes one has to painfully > look line by line to find the actual changes in the storm caused by the > reformat > > Have a look at one of Adam's diffs t

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Ian Turton
On 31 August 2012 11:03, Jody Garnett wrote: > It does and we do. > > However we have several sections of the codebase that have been formatted by > hand. As such when you blindly do "Alt-Shift-F" you introduce > a lot of noise into your patch. In which case we should tell the auto formatter not

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Andrea Aime
On Fri, Aug 31, 2012 at 12:37 PM, Ian Turton wrote: > > > > Why does this matter? It basically screws anyone who is trying to apply > the > > patch across different branches / releases. > > > > My guess is that by doing the whitespace change is a separate patch; > Justin > > would be able to "che

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Jody Garnett
Andrea the switch to a common release cycle may give us the opportunity to do the "whole world" reformat. Perhaps as the last thing we do before branch off a new stable branch. Gives us a fresh baseline to work with for the next release cycle. -- Jody Garnett On Friday, 31 August 2012 at 8:45

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Andrea Aime
On Fri, Aug 31, 2012 at 2:19 PM, Jody Garnett wrote: > Andrea the switch to a common release cycle may give us the opportunity > to do the "whole world" reformat. Perhaps as the last thing we do > before branch off a new stable branch. Gives us a fresh baseline to work > with for the next release

Re: [Geotools-devel] geotools 8.0 jars in maven repo?

2012-08-31 Thread Andrea Aime
On Thu, Aug 30, 2012 at 8:40 AM, Michael Bedward wrote: > Hi Jody, > > Sorry, don't know the answer to your question but just wondering if > there are still plans to publish to maven central at some stage ? > For the record, I would be +1 on publishing jars there. Wondering, is there any size lim

[Geotools-devel] Trying the release again tomorrow

2012-08-31 Thread Andrea Aime
Hi, tomorrow I'm going to try again the release of GeoServer 2.2-RC3 and GeoTools 8.1 I know that the deploy on maven won't work, but we can at least publish the release artifacts onto sourceforce. Or do you think it's best to delay yet another week and hope that the OSGeo deploy issue will be so

[Geotools-devel] Reminder about the PMS/PSC meeting on Monday

2012-08-31 Thread Andrea Aime
Hi, just a quick reminder that Monday we're going to have the GeoTools/GeoServer meeting on skype Cheers Andrea -- == Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via Poggio alle Viti 1187

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Jody Garnett
> Maybe reformatting trunk right before the new stable braches off then? > > > Yes that is what I was trying to say. That way both master and the new branch start from the same (formatted) place. Jody -- Live Securi

Re: [Geotools-devel] Do we have a page about contributing a patch?

2012-08-31 Thread Justin Deoliveira
In general I am pretty -1 on any major reformatting like this as whenever I have seen it done it does more harm than good. Maybe on a few classes here and there perhaps that are known to be a mess. We should really be on people when they commit stuff to use proper formatting. As for patches on mis